Changes wrt. v1:
addressed the comments from Jingoo Han and Mark Rutland
- added another patch to convert the driver to use devm_* functions
- removed sysfs reference from bindings documentation
- changed '_' to '-' in property name
- added 'edt,' prefix to properties names
- added sanity check for
Hi,
Shawn Guo wrote:
> On Wed, Mar 19, 2014 at 02:28:40PM +0100, Lothar Waßmann wrote:
> >
> > Signed-off-by: Lothar Waßmann
> > ---
> > arch/arm/boot/dts/imx53-tx53-x13x.dts | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff
Hi,
Huang Shijie wrote:
> On Fri, Mar 21, 2014 at 11:50:17AM +0100, Lothar Waßmann wrote:
> > With a flash-based BBT there is no reason to move the Factory Bad
> > Block Marker from the data area buffer (to where it is mapped by the
> > GPMI NAND controller) to the OOB bu
Hi,
Huang Shijie wrote:
> 于 2014年03月26日 16:51, Lothar Waßmann 写道:
> > I don't see why this should not be supported on i.MX28 (i.MX23 doesn't
> > do byteswapping anyway, so this wouldn't change anything for i.MX23).
> > The partitions used by Linux need n
-
>"In order to preserve the BI (bad block information), flash updater
> or gang programmer applications need to swap Bad Block Information (BI) data
> to byte 0 of
> metadata area for every page before programming NAND Flash. ROM when loading
> firmware,
it,
> check "
> + "'Documentation/i2c/instantiating-devices' for
> alternatives.\n",
>
It's usually a bad idea to split kernel messages across source lines
because it makes searching for the corresponding source line fo
> + return err;
> +
> + err = clk_prepare_enable(priv->clk_per);
> + if (err)
> + goto out_disable_ipg;
> +
> + reg = flexcan_read(®s->ecr);
>
flexcan_get_berr_counter() may be called from interrupt context and
thus must not call
Hi,
Felipe Balbi wrote:
> On Fri, Jul 18, 2014 at 11:31:30AM +0200, Lothar Waßmann wrote:
> > There is no need to throw the baby out with the bath due to a bad
> > failure analysis. The commit:
> > 7adb5c876e9c usb: musb: Fix panic upon musb_am335x module removal
> >
Hi,
Felipe Balbi wrote:
> Hi,,
>
> On Mon, Jul 21, 2014 at 10:03:07AM +0200, Lothar Waßmann wrote:
> > Hi,
> >
> > > On Fri, Jul 18, 2014 at 11:31:29AM +0200, Lothar Waßmann wrote:
> > > > This patch makes it possible to use the musb driver with HW th
for (i = 0; i < msgs->len - 2; i++) {
> + result = i2c_imx_trx_complete(i2c_imx);
> + if (result)
> + return result;
> + msgs->buf[i] = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR);
> +
Hi,
Yao Yuan wrote:
> Hi,
>
> Thanks for your review.
>
> Lothar Waßmann wrote:
> > Yuan Yao wrote:
> > > Add dma support for i2c. This function depend on DMA driver.
> > > You can turn on it by write both the dmas and dma-name properties in dts
> >
Hi,
Varka Bhadram wrote:
> On 07/23/2014 04:41 PM, Yao Yuan wrote:
> > Hi,
> >
> > Thanks for your review.
> >
> > Lothar Waßmann wrote:
> >> Yuan Yao wrote:
> >>> Add dma support for i2c. This function depend on DMA driver.
> >>>
wm_backlight_data as valid gpio number, and
request this GPIO as enable pin. In case of multiple driver instances,
the second will fail to register with the error message:
pwm-backlight backlight1.23: failed to request GPIO#0: -16
Fix this by setting enable_gpio in the pdata struct to -EINVAL.
S
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/imx6qdl.dtsi |2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index ce05991..3266d01 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
Make the messages that are printed in case of fatal errors actually
visible to the user without having to recompile the driver with
debugging enabled.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index d797c7b..582ac3a 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -25,20
The i.MX pwm unit on i.MX27 and newer SoCs provides a configurable
output polarity. This patch adds support to utilize this feature where
available.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 38 +++---
1 file changed, 35 insertions(+), 3
sting DTS files.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/core.c| 18 ++
drivers/pwm/pwm-atmel-tcb.c |1 -
drivers/pwm/pwm-atmel.c |4 +---
drivers/pwm/pwm-pxa.c |5 ++---
drivers/pwm/pwm-renesas-tpu.c |1 -
drivers/pwm/pwm-samsu
This patch series adds support for polarity inversion to the pwm-imx
driver. The patches have been tested on i.MX6, i.MX53 and with the
ti-ehrpwm.c driver.
Changes wrt. v2:
- make the use of '#pwm-cells = <3>' optional, so that the change does
not break existing DT blobs as suggested by Arnd Ber
-tx6dl-comtft.dts).
Changes wrt. v1
- addressed comments by Shawn Guo
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile |8 +
arch/arm/boot/dts/imx6dl-tx6dl-comtft.dts| 103
arch/arm/boot/dts/imx6dl-tx6u-801x.dts | 177 +++
arch/arm/boot/dts
Add support for Ka-Ro electronics i.MX51 based TX51 modules
Signed-off-by: Lothar Waßmann
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/imx51-tx51.dts | 620 ++
2 files changed, 621 insertions(+)
create mode 100644 arch/arm/boot/dts/imx51
Hi,
Huang Shijie wrote:
> 于 2014年03月27日 20:21, Lothar Waßmann 写道:
> > I can assure you that the>100.000 i.MX28 based modules, that we sold
> > up to now boot from NAND just fine without any block mark swapping in
> > the U-Boot pages.
> >
> Our driver should fol
This patch series adds support for polarity inversion to the pwm-imx
driver.
Changes wrt. v2:
- make the use of '#pwm-cells = <3>' optional, so that the change does
not break existing DT blobs as suggested by Arnd Bergmann and Sascha
Hauer.
--
To unsubscribe from this list: send the line "un
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index cc47733..52aac5e 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -25,20
The i.MX pwm unit on i.MX27 and newer SoCs provides a configurable
output polarity. This patch adds support to utilize this feature where
available.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers
sting DTS files.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/core.c | 46 --
1 file changed, 16 insertions(+), 30 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index a804713..dc15543 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/co
Hi,
Huang Shijie wrote:
> 于 2014年03月28日 16:16, Lothar Waßmann 写道:
> > Still there is no need for the Linux NAND driver to be able to read or
> > write partitions in a format that the Boot ROM can understand. Thus it
> If you do not use the NAND boot, there really no need to do
nux kernel does not have any business with the FCB, so it is
completely irrelevant for Linux whether byte swapping can be disabled
in the FCB or not.
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone
Hi,
Huang Shijie wrote:
> 于 2014年03月28日 17:33, Huang Shijie 写道:
> > 于 2014年03月28日 17:01, Lothar Waßmann 写道:
> >> There is no need for the ROM code to access any other partition than
> >> the bootloader itself. Thus Linux can perfectly well be booted from
> &g
Hi,
Huang Shijie wrote:
> 于 2014年03月28日 17:31, Lothar Waßmann 写道:
> > Hi,
> >
> > Huang Shijie wrote:
> >> 于 2014年03月28日 17:00, Sascha Hauer 写道:
> >>> - disables swapping of BB marks in the FCB the ROM won't swap bytes.
> >> We can not disab
Hi,
Liu Ying wrote:
> This patch contains no logic change to cleanup indentation
> for register definitions only.
>
> Cc: Thierry Reding
> Cc: Sascha Hauer
> Cc: Shawn Guo
> Cc: Lothar Waßmann
> Cc: linux-...@vger.kernel.org
> Cc: linux-arm-ker...@lists.infrade
Hi,
Shawn Guo wrote:
> On Thu, Jun 12, 2014 at 03:09:44PM +0200, Lothar Waßmann wrote:
> > Add support for Ka-Ro electronics i.MX51 based TX51 modules
> >
> > Signed-off-by: Lothar Waßmann
> > ---
> > arch/arm/boot/dts/Makefile |1 +
> >
enced/ pinctrl_ecspi1_1: ecspi1grp-1 {
^^
s/unef/unref/
not really important here, but bad for copy/pasters
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402
with zero size need to be
changed?
Or is it an unintended side effect of some recent change?
Lothar Waßmann
--
___
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäft
Hi,
Ming Lei wrote:
> On Wed, 23 Oct 2013 11:06:18 +0200
> Lothar Waßmann wrote:
>
[...]
> > Or is it an unintended side effect of some recent change?
>
> Maybe yes, could you test below patch?
>
> Tejun, looks we need to keep special attention on zero size of bin
OF_USE_NATIVE_MODE flag.
Since all current dts files only have one entry in their
display-timings node, this bug was not apparent and the fix does not
change the driver's behaviour for the current users.
Signed-off-by: Lothar Waßmann
---
drivers/video/mxsfb.c | 120 -
Make the messages that are printed in case of fatal errors actually
visible to the user without having to recompile the driver with
debugging enabled.
Signed-off-by: Lothar Waßmann
---
drivers/video/mxsfb.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
The first patch in this set converts some messages that are printed
in case of errors to be error messages rather than debug messages.
The second patch fixes a bug in the video selection code that
incorrectly OR's together the 'pixelclk-active' and 'de-active'
flags from all possible video modes s
Hi,
Lothar Waßmann wrote:
> This patch series adds support for polarity inversion to the pwm-imx
> driver. The patches have been tested on i.MX6, i.MX53 and with the
> ti-ehrpwm.c driver.
>
> Changes wrt. v2:
> - make the use of '#pwm-cells = <3>' optional, so
When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO
driver, request_irq() fails with -EINVAL, because the GPIO driver
requires a nested interrupt handler.
Use request_any_context_irq() to be able to use any GPIO driver as LED
trigger.
Signed-off-by: Lothar Waßmann
---
drivers
These patches make it possible to use the ledtrig-gpio driver with
GPIO drivers that require threaded IRQs (like the PCA953x I2C driver).
It has been tested with a PCA9554 chip on an i.MX28 module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
by using the _cansleep() variant of gpio_get_value().
Signed-off-by: Lothar Waßmann
---
drivers/leds/trigger/ledtrig-gpio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/trigger/ledtrig-gpio.c
b/drivers/leds/trigger/ledtrig-gpio.c
index 35812e3..c86c418
.
Similar patches are most probably required for a bunch of other
drivers too.
Signed-off-by: Lothar Waßmann
---
drivers/gpio/gpio-pca953x.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index e2da64a..770ef6b 100644
--- a
.
Signed-off-by: Lothar Waßmann
---
drivers/input/keyboard/matrix_keypad.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/input/keyboard/matrix_keypad.c
b/drivers/input/keyboard/matrix_keypad.c
index 8d2e19e..e651fa6 100644
--- a/drivers/input/keyboard
t; +};
> +
> +static struct snd_soc_card imx_tlv320_card = {
> + .num_links = 1,
> + .owner = THIS_MODULE,
> + .dai_link = &imx_tlv320_dai,
> + .dapm_widgets = aic3x_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(aic3x_dapm_widgets),
> +
ct platform_pwm_backlight_data as valid gpio number, and
request this GPIO as enable pin. In case of multiple driver instances,
the second will fail to register with the error message:
pwm-backlight backlight1.23: failed to request GPIO#0: -16
Fix this by setting enable_gpio in the pdata struct to -
sting DTS files.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/core.c| 18 ++
drivers/pwm/pwm-atmel-tcb.c |1 -
drivers/pwm/pwm-atmel.c |4 +---
drivers/pwm/pwm-pxa.c |5 ++---
drivers/pwm/pwm-renesas-tpu.c |1 -
drivers/pwm/pwm-samsu
The i.MX pwm unit on i.MX27 and newer SoCs provides a configurable
output polarity. This patch adds support to utilize this feature where
available.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 38 +++---
1 file changed, 35 insertions(+), 3
Signed-off-by: Lothar Waßmann
---
drivers/pwm/pwm-imx.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 5449d91..f836635 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -25,20
Make the messages that are printed in case of fatal errors actually
visible to the user without having to recompile the driver with
debugging enabled.
Signed-off-by: Lothar Waßmann
---
drivers/pwm/core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm
This patch series adds support for polarity inversion to the pwm-imx
driver. The patches have been tested on i.MX6, i.MX53 and with the
ti-ehrpwm.c driver.
Changes wrt. v2:
- make the use of '#pwm-cells = <3>' optional, so that the change does
not break existing DT blobs as suggested by Arnd Ber
.get_function_groups = pcs_get_function_groups,
> - .set_mux = pcs_sex_mux,
> + .set_mux = pcs_set_mux,
> .gpio_request_enable = pcs_request_gpio,
> };
>
Congrats, you passed the Turing test! ;)
Lothar Waßmann
--
__
her inadequate here!
But looking a little closer at the function, the timeout value seems to
be rather bogus to me. The loop counter 'timeout' is initialized from
the constant IMX_I2C_DMA_TIMEOUT which is also used in
|wait_for_completion_interruptible_timeout(
|
Hi,
David Miller wrote:
> From: Lothar Waßmann
> Date: Tue, 4 Nov 2014 11:29:12 +0100
>
> > Hi David,
> >
> > Lothar Waßmann wrote:
> >> David Miller wrote:
> >> > From: Lothar Waßmann
> >> > Date: Thu, 30 Oct 2014 07:51:04
Hi,
David Miller wrote:
> From: Lothar Waßmann
> Date: Tue, 28 Oct 2014 14:22:55 +0100
>
> > Changes wrt. v1:
> > - added some cleanup patches
> > - simplify handling of 'quirks' flags as suggested by Russell King.
> > - remove DIV_ROUND_UP() from by
Hi,
Sören Brinkmann wrote:
> On Wed, 2014-10-29 at 05:49AM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > Sören Brinkmann wrote:
> > > On Tue, 2014-10-28 at 04:16PM +0100, Lothar Waßmann wrote:
> > > > Hi,
> > > >
> > > &g
Hi,
David Miller wrote:
> From: Lothar Waßmann
> Date: Thu, 30 Oct 2014 07:51:04 +0100
>
> >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop
> >> in swap_buffer() is valid. The whole point is that the current
> >> code handles buffers wh
Changes wrt. v1:
- added some cleanup patches
- simplify handling of 'quirks' flags as suggested by Russell King.
- remove DIV_ROUND_UP() from byte swapping loop as suggested by
Eric Dumazet
Subject:
In-Reply-To:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
o the byte swapping and copying to the new skb in one go if
necessary.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/ne
fep->bufdesc_ex is used as boolean flag; thus declare it as such.
Also remove an unnecessary initialization to 0.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h |2 +-
drivers/net/ethernet/freescale/fec_main.c |4 +---
2 files changed, 2 insertions(+)
when swap_buffer() is being called, we know for sure, that we need to
byte swap the data. Also this function is called for swapping data in
both directions. Thus cpu_to_be32() is semantically not correct for
all use cases. Use swab32s() to reflect this.
Signed-off-by: Lothar Waßmann
---
drivers
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index e364d1f..decea57 100644
--- a/drivers/net/ethernet
Eliminate the DIV_ROUND_UP() and change the loop counter increment to
4 instead. This results in saving 6 instructions in the functions
assembly code.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h |1 +
drivers/net/ethernet/freescale/fec_main.c | 105 ++---
2 files changed, 38 insertions(+), 68 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet
Hi,
David Laight wrote:
> From: Lothar Waßmann
> > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > performance")
> > introduced a regression for i.MX28. The swap_buffer() function doing
> > the endian conversion of the rece
Hi,
David Laight wrote:
> From: Lothar Waßmann
> > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > performance")
> > introduced a regression for i.MX28. The swap_buffer() function doing
> > the endian conversion of the received data o
Changes wrt. v1:
- added some cleanup patches
- simplify handling of 'quirks' flags as suggested by Russell King.
- remove DIV_ROUND_UP() from byte swapping loop as suggested by
Eric Dumazet
Changes wrt. v2:
- rebased against next-20141028
- added some more cleanups in fec.h
- removed unused ret
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet/freescale/fec.h
index e778b9e..27e75cf 100644
--- a/drivers
consistently use TABs for indentation
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h | 108 +-
1 file changed, 54 insertions(+), 54 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet/freescale/fec.h
fep->bufdesc_ex is used as boolean flag; thus declare it as such.
Also remove an unnecessary initialization to 0.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h |2 +-
drivers/net/ethernet/freescale/fec_main.c |4 +---
2 files changed, 2 insertions(+)
when swap_buffer() is being called, we know for sure, that we need to
byte swap the data. Also this function is called for swapping data in
both directions. Thus cpu_to_be32() is semantically not correct for
all use cases. Use swab32s() to reflect this.
Signed-off-by: Lothar Waßmann
---
drivers
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet/freescale/fec_main.c
index ddfc57d..e52864c 100644
--- a/drivers/net/ethernet
Eliminate the DIV_ROUND_UP() and change the loop counter increment to
4 instead. This results in saving 6 instructions in the functions
assembly code.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
o the byte swapping and copying to the new skb in one go if
necessary.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/ne
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h |1 +
drivers/net/ethernet/freescale/fec_main.c | 106 +++--
2 files changed, 39 insertions(+), 68 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec.h | 88 +-
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec.h
b/drivers/net/ethernet/freescale/fec.h
index 3047db4..e778b9e 100644
--- a
Hi,
David Laight wrote:
> From: Lothar Waßmann
> > David Laight wrote:
> > > From: Lothar Waßmann
> > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > > > performance")
> > > > introduced a regression
PINMUX_FUNCTION(can0, 0x10),
> + DEFINE_ZYNQ_PINMUX_FUNCTION(can1, 0x10),
> + DEFINE_ZYNQ_PINMUX_FUNCTION(uart0, 0x70),
> + DEFINE_ZYNQ_PINMUX_FUNCTION(uart1, 0x70),
> + DEFINE_ZYNQ_PINMUX_FUNCTION(i2c0, 0x20),
> + DEFINE_ZYNQ_PINMUX_FUNCTION(i2c1, 0x20),
> + DEF
Hi,
Sören Brinkmann wrote:
> On Tue, 2014-10-28 at 04:16PM +0100, Lothar Waßmann wrote:
> > Hi,
> >
> > Soren Brinkmann wrote:
> > > Signed-off-by: Soren Brinkmann
> > > ---
> > > changes since RFC:
> > > - use syscon/regmap to access
o the byte swapping and copying to the new skb in one go if
necessary.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/ne
Hi,
David Laight wrote:
> From: Lothar Waßmann
> > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > performance")
> > introduced a regression for i.MX28. The swap_buffer() function doing
> > the endian conversion of the received data o
Hi,
David Miller wrote:
> From: Lothar Waßmann
> Date: Tue, 7 Oct 2014 15:19:37 +0200
>
> > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > performance")
> > introduced a regression for i.MX28. The swap_buffer() function doing
>
Hi,
David Laight wrote:
> From: Lothar
> > David Laight wrote:
> > > From: Lothar Waßmann
> > > > commit 1b7bde6d659d ("net: fec: implement rx_copybreak to improve rx
> > > > performance")
> > > > introduced a regression for i.MX28
bout that as well.
> I wouldn't have expected ppc to support misaligned transfers, and you'd also
> want to make sure that cpu_to_be(*src) was using a byte-swapping instruction.
> Hmmm... cpu_to_be() doesn't sound like the right 'swap' macro name.
>
??? So wh
Changes wrt. v1:
- added some cleanup patches
- simplify handling of 'quirks' flags as suggested by Russell King.
- remove DIV_ROUND_UP() from byte swapping loop as suggested by
Eric Dumazet
Changes wrt. v2:
- rebased against next-20141028
- added some more cleanups in fec.h
- removed unused ret
o the byte swapping and copying to the new skb in one go if
necessary.
Signed-off-by: Lothar Waßmann
---
drivers/net/ethernet/freescale/fec_main.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/ne
Hi David,
Lothar Waßmann wrote:
> David Miller wrote:
> > From: Lothar Waßmann
> > Date: Thu, 30 Oct 2014 07:51:04 +0100
> >
> > >> Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop
> > >> in swap_buffer() is valid. The whole poi
uot;atmel,sama5d4-wdt", },
> + { },
The empty initializer must always be the last element of the array, so
there is no point in having a trailing ',' (whose purpose is to
facilitate adding more entries after the last one).
Without the comma there will be a compile error if (e.g. due
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Use an open coded version of of_get_drm_display_mode() to get access
to these flags
The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/parallel-display.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/g
Currently these flags are lost in the call
drm_display_mode_from_videomode()
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/imx-ldb.c | 37 ++
drivers/gpu/drm/imx/parallel-display.c | 31
2 files changed, 56 insertions
ative-mode property pointing to the first entry
- let the bootloader select the appropriate timing
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/imx-ldb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
ind
Hi,
On Tue, 24 May 2016 16:16:40 +0200 Philipp Zabel wrote:
> Hi Lothar,
>
> thank you for rebasing. I have applied the other two patches.
> With this one, I'd like to avoid the duplicated code. See below:
>
> Am Dienstag, den 24.05.2016, 08:31 +0200 schrieb Lothar Waßma
The 'mode_valid' flag is never set in this driver. Remove it and the
code that depends on it.
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/parallel-display.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c
b/drivers/g
ative-mode property pointing to the first entry
- let the bootloader select the appropriate timing
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/imx-ldb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
ind
Currently these flags are lost in the call
drm_display_mode_from_videomode()
Signed-off-by: Lothar Waßmann
---
drivers/gpu/drm/imx/imx-drm-core.c | 12 +++
drivers/gpu/drm/imx/imx-drm.h | 7 ---
drivers/gpu/drm/imx/imx-ldb.c | 37
The 'de-active' and 'pixelclk-active' DT properties are evaluated
by of_parse_display_timing() called from of_get_drm_display_mode(),
but later lost in the conversion from videomode.flags to
drm_display_mode.flags.
Use an open coded version of of_get_drm_display_mode() to get access
to these flags
ased on top of https://patchwork.kernel.org/patch/9113791/ as
per Philipp Zabel's request
GIT: [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when
GIT: [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags
GIT: [PATCHv2 3/3] drm/imx: remove dead code
Signed-off-b
UP and DOWN state:
fec 800f.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
fec 800f.ethernet eth0: Link is Down
fec 800f.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
fec 800f.ethernet eth0: Link is Down
[...]
Signed-off-by: Lothar Waßmann
---
drivers
Hi,
> On Fri, Nov 27, 2015 at 02:39:10PM +0100, Lothar Waßmann wrote:
> > When ENET_OUT is being used as reference clock for an external PHY,
> > the clock must not be disabled while the PHY is active. Otherwise the
> > PHY may lose its internal state and require a reset to
201 - 300 of 454 matches
Mail list logo
