On Monday 19 May 2014 05:42 AM, Rusty Russell wrote:
Hugh Dickins hu...@google.com writes:
On Thu, 15 May 2014, Madhavan Srinivasan wrote:
Hi Ingo,
Do you have any comments for the latest version of the patchset. If
not, kindly can you pick it up as is.
With regards
Maddy
Kirill
>
> V2 Changes:
> Created Kconfig parameter for FAULT_AROUND_ORDER
> Added check in do_read_fault to handle FAULT_AROUND_ORDER value of 0
> Made changes in commit messages.
>
> Madhavan Srinivasan (2):
> mm: move FAULT_AROUND_ORDER to arch/
> powerpc/pseries: init
in do_read_fault to handle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
powerpc/pseries: init fault_around_order for pseries
arch/powerpc/platforms/pseries/pseries.h |2 ++
arch/powerpc/platforms/pseries/setup.c
068 4.662729948 31.732848290
stddev for time ( +- 6.85% ) ( +- 4.09% ) ( +- 1.71% ) ( +-
3.45% ) ( +- 2.40% ) ( +- 0.68% )
Signed-off-by: Madhavan Srinivasan
---
arch/powerpc/platforms/pseries/pseries.h |2 ++
arch/powerpc/platforms/pseries/setup.c |5 +
rms.
Made changes in commit messages.
V2 Changes:
Created Kconfig parameter for FAULT_AROUND_ORDER
Added check in do_read_fault to handle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
powerpc/pseries: i
ure maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also defaults
FAULT_AROUND_ORDER Kconfig element to 4.
Signed-off-by: Madhavan Srinivasan
---
mm/Kconfig |8
mm/memory.c | 25 ++---
2 files chan
maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also defaults
FAULT_AROUND_ORDER Kconfig element to 4.
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
mm/Kconfig |8
mm/memory.c | 25
.
Made changes in commit messages.
V2 Changes:
Created Kconfig parameter for FAULT_AROUND_ORDER
Added check in do_read_fault to handle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
powerpc/pseries: init
4.662729948 31.732848290
stddev for time ( +- 6.85% ) ( +- 4.09% ) ( +- 1.71% ) ( +-
3.45% ) ( +- 2.40% ) ( +- 0.68% )
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
arch/powerpc/platforms/pseries/pseries.h |2 ++
arch/powerpc/platforms/pseries
On Wednesday 30 April 2014 12:34 PM, Rusty Russell wrote:
> Ingo Molnar writes:
>> * Madhavan Srinivasan wrote:
>>
>>> Performance data for different FAULT_AROUND_ORDER values from 4 socket
>>> Power7 system (128 Threads and 128GB memory). perf stat with repeat o
On Wednesday 30 April 2014 12:34 PM, Rusty Russell wrote:
Ingo Molnar mi...@kernel.org writes:
* Madhavan Srinivasan ma...@linux.vnet.ibm.com wrote:
Performance data for different FAULT_AROUND_ORDER values from 4 socket
Power7 system (128 Threads and 128GB memory). perf stat with repeat of 5
On Tuesday 29 April 2014 12:36 PM, Ingo Molnar wrote:
>
> * Madhavan Srinivasan wrote:
>
>> Performance data for different FAULT_AROUND_ORDER values from 4 socket
>> Power7 system (128 Threads and 128GB memory). perf stat with repeat of 5
>> is used to get the stdde
On Tuesday 29 April 2014 07:48 AM, Rusty Russell wrote:
> Madhavan Srinivasan writes:
>> diff --git a/arch/powerpc/platforms/pseries/setup.c
>> b/arch/powerpc/platforms/pseries/setup.c
>> index 2db8cc6..c87e6b6 100644
>> --- a/arch/powerpc/platforms/pseries/se
On Monday 28 April 2014 02:36 PM, Peter Zijlstra wrote:
> On Mon, Apr 28, 2014 at 02:31:29PM +0530, Madhavan Srinivasan wrote:
>> +unsigned int fault_around_order = CONFIG_FAULT_AROUND_ORDER;
>
> __read_mostly?
>
Agreed. Will add it.
Thanks for review.
With regards
Maddy
--
T
On Monday 28 April 2014 03:06 PM, Kirill A. Shutemov wrote:
> Madhavan Srinivasan wrote:
>> Kirill A. Shutemov with 8c6e50b029 commit introduced
>> vm_ops->map_pages() for mapping easy accessible pages around
>> fault address in hope to reduce number of minor page faults.
On Monday 28 April 2014 03:06 PM, Kirill A. Shutemov wrote:
Madhavan Srinivasan wrote:
Kirill A. Shutemov with 8c6e50b029 commit introduced
vm_ops-map_pages() for mapping easy accessible pages around
fault address in hope to reduce number of minor page faults.
This patch creates
On Monday 28 April 2014 02:36 PM, Peter Zijlstra wrote:
On Mon, Apr 28, 2014 at 02:31:29PM +0530, Madhavan Srinivasan wrote:
+unsigned int fault_around_order = CONFIG_FAULT_AROUND_ORDER;
__read_mostly?
Agreed. Will add it.
Thanks for review.
With regards
Maddy
--
To unsubscribe from
On Tuesday 29 April 2014 07:48 AM, Rusty Russell wrote:
Madhavan Srinivasan ma...@linux.vnet.ibm.com writes:
diff --git a/arch/powerpc/platforms/pseries/setup.c
b/arch/powerpc/platforms/pseries/setup.c
index 2db8cc6..c87e6b6 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch
On Tuesday 29 April 2014 12:36 PM, Ingo Molnar wrote:
* Madhavan Srinivasan ma...@linux.vnet.ibm.com wrote:
Performance data for different FAULT_AROUND_ORDER values from 4 socket
Power7 system (128 Threads and 128GB memory). perf stat with repeat of 5
is used to get the stddev values. Test
dle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
powerpc/pseries: init fault_around_order for pseries
arch/powerpc/platforms/pseries/setup.c |5 +
mm/Kconfig |8
mm/memor
ure maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also defaults
FAULT_AROUND_ORDER Kconfig element to 4.
Signed-off-by: Madhavan Srinivasan
---
mm/Kconfig |8
mm/memory.c | 11 ---
2 files changed,
% ) ( +- 2.40% ) ( +- 0.68% )
Signed-off-by: Madhavan Srinivasan
---
arch/powerpc/platforms/pseries/setup.c |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/setup.c
b/arch/powerpc/platforms/pseries/setup.c
index 2db8cc6..c87e6b6 100644
--- a/arch/powerpc
% ) ( +- 2.40% ) ( +- 0.68% )
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
arch/powerpc/platforms/pseries/setup.c |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/setup.c
b/arch/powerpc/platforms/pseries/setup.c
index 2db8cc6..c87e6b6 100644
maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also defaults
FAULT_AROUND_ORDER Kconfig element to 4.
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
mm/Kconfig |8
mm/memory.c | 11 ---
2
FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
powerpc/pseries: init fault_around_order for pseries
arch/powerpc/platforms/pseries/setup.c |5 +
mm/Kconfig |8
mm/memory.c
On Wednesday 09 April 2014 09:18 PM, Dave Hansen wrote:
> On 04/09/2014 01:20 AM, Peter Zijlstra wrote:
>> This still misses out on Ben's objection that its impossible to get this
>> right at compile time for many kernels, since they can boot and run on
>> many different subarchs.
>
> Completely
On Wednesday 09 April 2014 09:18 PM, Dave Hansen wrote:
On 04/09/2014 01:20 AM, Peter Zijlstra wrote:
This still misses out on Ben's objection that its impossible to get this
right at compile time for many kernels, since they can boot and run on
many different subarchs.
Completely agree.
On Friday 04 April 2014 11:20 PM, David Miller wrote:
> From: Dave Hansen
> Date: Fri, 04 Apr 2014 09:18:43 -0700
>
>> On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote:
>>> This patch creates infrastructure to move the FAULT_AROUND_ORDER
>>> to arch/ using Kconf
On Friday 04 April 2014 09:48 PM, Dave Hansen wrote:
> On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote:
>> This patch creates infrastructure to move the FAULT_AROUND_ORDER
>> to arch/ using Kconfig. This will enable architecture maintainers
>> to decide on suitable FAULT_ARO
On Friday 04 April 2014 06:47 PM, Kirill A. Shutemov wrote:
> On Fri, Apr 04, 2014 at 11:57:14AM +0530, Madhavan Srinivasan wrote:
>> Kirill A. Shutemov with faultaround patchset introduced
>> vm_ops->map_pages() for mapping easy accessible pages around
>> fault address
On Friday 04 April 2014 06:47 PM, Kirill A. Shutemov wrote:
On Fri, Apr 04, 2014 at 11:57:14AM +0530, Madhavan Srinivasan wrote:
Kirill A. Shutemov with faultaround patchset introduced
vm_ops-map_pages() for mapping easy accessible pages around
fault address in hope to reduce number of minor
On Friday 04 April 2014 09:48 PM, Dave Hansen wrote:
On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote:
This patch creates infrastructure to move the FAULT_AROUND_ORDER
to arch/ using Kconfig. This will enable architecture maintainers
to decide on suitable FAULT_AROUND_ORDER value based
On Friday 04 April 2014 11:20 PM, David Miller wrote:
From: Dave Hansen dave.han...@intel.com
Date: Fri, 04 Apr 2014 09:18:43 -0700
On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote:
This patch creates infrastructure to move the FAULT_AROUND_ORDER
to arch/ using Kconfig. This will enable
ent for powerpc.
V2 Changes:
Created Kconfig parameter for FAULT_AROUND_ORDER
Added check in do_read_fault to handle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
mm: add FAULT_AROUND_ORDER Kconfig parama
ure maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also adds
FAULT_AROUND_ORDER Kconfig element in arch/X86.
Signed-off-by: Madhavan Srinivasan
---
arch/x86/Kconfig |4
include/linux/mm.h |9 +
mm/memor
-by: Madhavan Srinivasan
---
arch/powerpc/platforms/pseries/Kconfig |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/Kconfig
b/arch/powerpc/platforms/pseries/Kconfig
index 2cb8b77..2246d9f 100644
--- a/arch/powerpc/platforms/pseries/Kconfig
+++ b/arch/powerpc
maintainers
to decide on suitable FAULT_AROUND_ORDER value based on
performance data for that architecture. Patch also adds
FAULT_AROUND_ORDER Kconfig element in arch/X86.
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
arch/x86/Kconfig |4
include/linux/mm.h |9
-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
arch/powerpc/platforms/pseries/Kconfig |5 +
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/Kconfig
b/arch/powerpc/platforms/pseries/Kconfig
index 2cb8b77..2246d9f 100644
--- a/arch/powerpc/platforms/pseries/Kconfig
for powerpc.
V2 Changes:
Created Kconfig parameter for FAULT_AROUND_ORDER
Added check in do_read_fault to handle FAULT_AROUND_ORDER value of 0
Made changes in commit messages.
Madhavan Srinivasan (2):
mm: move FAULT_AROUND_ORDER to arch/
mm: add FAULT_AROUND_ORDER Kconfig paramater
On Tuesday 25 March 2014 11:20 PM, Dave Hansen wrote:
> On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote:
+/*
+ * Fault around order is a control knob to decide the fault around pages.
+ * Default value is set to 0UL (disabled), but the arch can override it as
+ * desired.
On Tuesday 25 March 2014 11:20 PM, Dave Hansen wrote:
On 03/25/2014 10:36 AM, Kirill A. Shutemov wrote:
+/*
+ * Fault around order is a control knob to decide the fault around pages.
+ * Default value is set to 0UL (disabled), but the arch can override it as
+ * desired.
+ */
+#ifndef
On Tuesday 25 March 2014 11:06 PM, Kirill A. Shutemov wrote:
> On Tue, Mar 25, 2014 at 12:20:15PM +0530, Madhavan Srinivasan wrote:
>> Kirill A. Shutemov with the commit 96bacfe542 introduced
>> vm_ops->map_pages() for mapping easy accessible pages around
>> fault address
On Tuesday 25 March 2014 11:06 PM, Kirill A. Shutemov wrote:
On Tue, Mar 25, 2014 at 12:20:15PM +0530, Madhavan Srinivasan wrote:
Kirill A. Shutemov with the commit 96bacfe542 introduced
vm_ops-map_pages() for mapping easy accessible pages around
fault address in hope to reduce number of minor
s 4.
This patch moves the FAULT_AROUND_ORDER macro to arch/ for
architecture maintainers to decide on suitable FAULT_AROUND_ORDER
value based on performance data for that architecture.
Signed-off-by: Madhavan Srinivasan
---
arch/powerpc/include/asm/pgtable.h |6 ++
arch/x86/include/asm/pgtabl
8.711074863
128 threads
minor-faults 131255 131239 131228 131228
131229 131243
times in seconds 0.817782148 1.124631348 2.023730928
3.184792382 5.331392072 17.309524609
Madhavan Srinivasan (1):
mm: move
moves the FAULT_AROUND_ORDER macro to arch/ for
architecture maintainers to decide on suitable FAULT_AROUND_ORDER
value based on performance data for that architecture.
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/pgtable.h |6 ++
arch/x86
8.711074863
128 threads
minor-faults 131255 131239 131228 131228
131229 131243
times in seconds 0.817782148 1.124631348 2.023730928
3.184792382 5.331392072 17.309524609
Madhavan Srinivasan (1):
mm: move
On Saturday 22 February 2014 05:44 AM, Cody P Schafer wrote:
> /sys/devices/system/cpu/cpu*/smt-snooze-delay was converted into a NOP
> in commit 3fa8cad82b94d0bed002571bd246f2299ffc876b, and now does
> nothing. Add a pr_warn() to convince any users that they should stop
> using it.
>
> The
On Saturday 22 February 2014 05:44 AM, Cody P Schafer wrote:
/sys/devices/system/cpu/cpu*/smt-snooze-delay was converted into a NOP
in commit 3fa8cad82b94d0bed002571bd246f2299ffc876b, and now does
nothing. Add a pr_warn() to convince any users that they should stop
using it.
The commit
nderscored version of the API */
> __register_cpu_notifier(_cpu_notifier);
>
> cpu_maps_update_done();
>
>
> Fix the sysfs code in powerpc by using this latter form of callback
> registration.
Acked-by: Madhavan Srinivasan
>
> Cc: Benjamin Herrenschmidt
&g
);
cpu_maps_update_done();
Fix the sysfs code in powerpc by using this latter form of callback
registration.
Acked-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Cc: Paul Mackerras pau...@samba.org
Cc: Madhavan Srinivasan ma...@linux.vnet.ibm.com
>> /usr/local/src/linux-git/scripts/kconfig/menu.c:586:18: warning: ‘jump’ may
>>> be used uninitialized in this function [-Wmaybe-uninitialized]
>>> /usr/local/src/linux-git/scripts/kconfig/menu.c:547:19: note: ‘jump’ was
>>> declared here
>>
>> Grrr, only
-uninitialized]
/usr/local/src/linux-git/scripts/kconfig/menu.c:547:19: note: ‘jump’ was
declared here
Grrr, only after I sent this message I found this was reported in
September already by Madhavan Srinivasan: https://lkml.org/lkml/2013/9/19/24
Does anybody know the state of this fix?
My
cripts/kconfig/menu.c:547:19: note: ???jump??? was declared here
struct jump_key *jump;
^
Change V2:
1)Added comment as suggested.
Signed-off-by: Madhavan Srinivasan
---
scripts/kconfig/menu.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/k
/kconfig/menu.c:547:19: note: ???jump??? was declared here
struct jump_key *jump;
^
Change V2:
1)Added comment as suggested.
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
scripts/kconfig/menu.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
n Poirier spake thusly:
>>>> On 2013/09/19 12:58, Madhavan Srinivasan wrote:
>>>>> In file included from scripts/kconfig/zconf.tab.c:2537:0:
>>>>> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
>>>>> scripts/kconfig/menu.c:586
config/menu.c:547:19: note: ‘jump’ was declared here
struct jump_key *jump;
^
Signed-off-by: Madhavan Srinivasan
---
scripts/kconfig/menu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index c1d5320..23b1827
:547:19: note: ‘jump’ was declared here
struct jump_key *jump;
^
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
scripts/kconfig/menu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index
On Friday 20 September 2013 01:34 AM, Yann E. MORIN wrote:
Benjamin, All,
On 2013-09-19 15:13 -0400, Benjamin Poirier spake thusly:
On 2013/09/19 19:27, Yann E. MORIN wrote:
Benjamin, Madhavan, All,
On 2013-09-19 11:22 -0400, Benjamin Poirier spake thusly:
On 2013/09/19 12:58, Madhavan
struct jump_key *jump;
^
Signed-off-by: Madhavan Srinivasan
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 7e233a6..cfe4648 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/
*jump;
^
Signed-off-by: Madhavan Srinivasan ma...@linux.vnet.ibm.com
---
scripts/kconfig/menu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 7e233a6..cfe4648 100644
--- a/scripts/kconfig/menu.c
+++ b
601 - 661 of 661 matches
Mail list logo
