Re: GPS driver for Linux - kernel or user-space driver?

2013-04-03 Thread Marcel Holtmann
Hi Greg, >> I've been approached by a developer at Sony who wants to publish an >> open source driver for a Sony GPS receiver module. > > What does the device look like? USB device? UART? Something else? > >> I've looked in the kernel source, and only see one standalone GPS >> driver, for Gar

Re: GPS driver for Linux - kernel or user-space driver?

2013-04-03 Thread Marcel Holtmann
Hi Greg, I've been approached by a developer at Sony who wants to publish an open source driver for a Sony GPS receiver module. >>> >>> What does the device look like? USB device? UART? Something else? >>> I've looked in the kernel source, and only see one standalone GPS d

Re: [PATCH 4/7] net/bluetooth/rfcomm/core.c: fix error return code

2012-08-29 Thread Marcel Holtmann
gt; ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // > > Signed-off-by: Julia Lawall > > --- > net/bluetooth/rfcomm/core.c |4 +++- > 1 file c

Build error on PowerPC

2008-02-01 Thread Marcel Holtmann
Hi, I get the following build error on PowerPC: CC [M] sound/ppc/awacs.o In file included from sound/ppc/awacs.c:25: include/asm/nvram.h:62: error: field ‘partition’ has incomplete type make[2]: *** [sound/ppc/awacs.o] Error 1 make[1]: *** [sound/ppc] Error 2 make: *** [sound] Error 2 Regards

Re: [PATCH][v4] ipwireless: driver for 3G PC Card

2008-02-01 Thread Marcel Holtmann
Hi David, > +irqreturn_t ipwireless_interrupt(int irq, void *dev_id, struct pt_regs *regs) > +{ > + struct ipw_hardware *hw = dev_id; > + > + if (hw->hw_version == HW_VERSION_1) > + return ipwireless_handle_v1_interrupt(irq, hw); > + else > + return ipwireless_h

Re: Build error on PowerPC

2008-02-01 Thread Marcel Holtmann
ake: *** [sound] Error 2 Signed-off-by: Marcel Holtmann <[EMAIL PROTECTED]> --- commit 5613f9f9aa321cf59915137cc611aea9fd95ed75 tree 3c55137ccc3d16e49b757a0e6135f32fb2086ae3 parent aa6299926950c8dfe2fea638276cad6def092bc9 author Marcel Holtmann <[EMAIL PROTECTED]> Sat, 02 Feb 2008 03:5

ACPI problem on PowerPC

2008-02-02 Thread Marcel Holtmann
Hi Greg, the following happens with the latest ACPI and PCI merges on my Quad G5: CC drivers/pci/pcie/aspm.o In file included from include/acpi/platform/acenv.h:140, from include/acpi/acpi.h:54, from include/acpi/acpi_bus.h:31, from driver

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-03 Thread Marcel Holtmann
Hi David, > > As there is some controversy over the definition of derived work > > (think Linus' comments on porting a driver or a filesystem from > > another operating system here), we use the EXPORT_SYMBOL_GPL > > annotations as a big warning sign that what you're doing is likely to > > be consi

Re: What's about WiMAX?

2008-02-04 Thread Marcel Holtmann
Hi Marc, > i have here a few wimax 802.16e zyxel pcmcia cards, which only work on > windows. is anybody interrested in developing a driver for these wimax cards? are these PCMCIA or CardBus cards. Or do they actually end up exposing an USB host controller? Regards Marcel -- To unsubscribe fr

Re: Where to send new pcmcia driver?

2008-02-04 Thread Marcel Holtmann
Hi Kristoffer, > Im almost finished with my pcmcia driver for the h64461 chipset, it works > fine just need to clean it up. > > Now looking at the MAINTAINER list it doesn't reference anyone special as the > maintainer for pcmcia subsystem. > So in short where should I send the patch? > > Also

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-04 Thread Marcel Holtmann
Hi Christer, > > In the cited example it's illegal to go outside certain parameters > > SOMEWHERE (if it was illegal everywhere, the the hardware shouldn't > > allow it and the sw could do nothing... not considering hw mods). > > Another example is WiFi: USA, Europe and Japan allows a different

Re: [PATCH][BLUETOOTH] add HCI_BROKEN_ISOC for 0e5e:6622 (bugzilla #9027)

2008-02-13 Thread Marcel Holtmann
Hi, > This patch fix bugzilla #9027. > ``Syslog flooded with "hci_scodata_packet: hci0 SCO packet for unknown > connection handle 92" message" > > see http://bugzilla.kernel.org/show_bug.cgi?id=9027 when we get the content of /proc/bus/usb/devices for this one. Do you have the manufacturer name

Re: [PATCH][BLUETOOTH] add HCI_BROKEN_ISOC for 0e5e:6622 (bugzilla #9027)

2008-02-13 Thread Marcel Holtmann
Hi, > >> This patch fix bugzilla #9027. > >> ``Syslog flooded with "hci_scodata_packet: hci0 SCO packet for unknown > >> connection handle 92" message" > >> > >> see http://bugzilla.kernel.org/show_bug.cgi?id=9027 > >> > > > > when we get the content of /proc/bus/usb/devices for this one. Do

Re: [Bluez-devel] [PATCH 14/14] net/bluetooth/hci_core.c: Use time_* macros

2008-02-14 Thread Marcel Holtmann
s on is acked by me. Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Bluetooth: Another vendor specific ID for BCM20702A0 [0a5c:21f1]

2012-07-27 Thread Marcel Holtmann
Hi Michael, > Bus 002 Device 003: ID 0a5c:21f1 Broadcom Corp. > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 255 Vendor Specific Class > bDeviceSubClass 1 > bDeviceProtocol 1 > bMaxPacke

Re: Unable to Detect Bluetooth Device on Macbook Pro 9,2 (Mid-2012 13")

2012-07-31 Thread Marcel Holtmann
Hi Shea, > Please CC me on response, I am not subscribed to the list. > > hcitool is unable to detect my laptop's bluetooth device: > > $ lsusb > Bus 004 Device 009: ID 05ac:821d Apple, Inc. > Bus 004 Device 008: ID 05ac:820b Apple, Inc. > Bus 004 Device 007: ID 05ac:820a Apple, Inc. > Bus 004 D

Re: Unable to Detect Bluetooth Device on Macbook Pro 9,2 (Mid-2012 13")

2012-07-31 Thread Marcel Holtmann
Hi Shea, > > include /sys/kernel/debug/usb/devices details for this device. > > Not sure, which device it is, so here's all of bus 4: > T: Bus=04 Lev=04 Prnt=04 Port=02 Cnt=03 Dev#= 9 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=05ac ProdID=821

Re: [PATCH] btusb: fix overflow return values

2013-07-08 Thread Marcel Holtmann
Hi Adam, > PTR_ERR() returns a long type value, but btusb_setup_intel() and > btusb_setup_intel_patching() should return an int type value. > > This bug makes the judgement "if (ret < 0)" not working on x86_64 > architecture systems, leading to failure as below, even panic. > > [ 12.958920] Bl

Re: 3.11-final plan: unpriviledged user can crash the kernel (using bluetooth rfcomm)

2013-09-01 Thread Marcel Holtmann
Hi Pavel, >> . Python sources for client/server are at >> >> http://tui.cvs.sourceforge.net/viewvc/tui/tui/liveview/ >> >> . My kernels like to warn about > System is debian stable with gnome2. And no, it is not fixed in 3.11-rc7. >>> >>> 2.6.32-5-686 from de

Re: [PATCH] drivers: bluetooth: btusb: Added support for Belkin F8065bf usb bluetooth device

2013-09-20 Thread Marcel Holtmann
Hi Ken, > Belkin bluetooth device's usb device id added to generic usb bluetooth driver. > > It's another instance of Broadcom's BCM20702A0. > > Relevant section from /sys/kernel/debug/usb/devices: > > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(ven

Re: [PATCH] drivers: bluetooth: btusb: Added support for Belkin F8065bf usb bluetooth device

2013-09-21 Thread Marcel Holtmann
Hi Ken, > Adding generic rule for broadcom devices to generic usb bluetooth driver on > encountering another instance of Broadcom's BCM20702A0. > > Relevant section from /sys/kernel/debug/usb/devices: > > T: Bus=03 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(

Re: [PATCH 2/5] Bluetooth: Fix assignment of 0/1 to bool variables

2013-09-22 Thread Marcel Holtmann
; > @@ > ( > -b = 0 > +b = false > | > -b = 1 > +b = true > ) > > Signed-off-by: Peter Senna Tschudin > > --- > net/bluetooth/l2cap_core.c | 16 ---- > 1 file changed, 8 insertions(+), 8 deletions(-) Acked-by: Marcel Holtmann Regards Marcel

Re: [PATCH 08/12] bluetooth: Remove extern from function prototypes

2013-09-23 Thread Marcel Holtmann
++-- > 3 files changed, 21 insertions(+), 22 deletions(-) Acked-by: Marcel Holtmann Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH 2/10] drivers/bluetooth/bluecard_cs.c: removes unnecessary semicolon

2012-09-07 Thread Marcel Holtmann
Hi Peter, > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/bluetooth/bluecard_cs.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marcel Holtman

Re: [PATCH 3/10] drivers/bluetooth/hci_ldisc.c: removes unnecessary semicolon

2012-09-07 Thread Marcel Holtmann
Hi Peter, > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/bluetooth/hci_ldisc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marcel Holtman

Re: [PATCH 4/10] drivers/bluetooth/hci_ll.c: removes unnecessary semicolon

2012-09-07 Thread Marcel Holtmann
Hi Peter, > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/bluetooth/hci_ll.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marcel Holtman

Re: [PATCH 5/10] drivers/bluetooth/hci_vhci.c: removes unnecessary semicolon

2012-09-07 Thread Marcel Holtmann
Hi Peter, > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/bluetooth/hci_vhci.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marcel Holtman

Re: [PATCH 10/10] drivers/bluetooth/btuart_cs.c: removes unnecessary semicolon

2012-09-07 Thread Marcel Holtmann
Hi Peter, > removes unnecessary semicolon > > Found by Coccinelle: http://coccinelle.lip6.fr/ > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/bluetooth/btuart_cs.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Marcel Holtman

Re: [PATCH 08/21] TTY: hci_ldisc, remove invalid check in open

2012-10-18 Thread Marcel Holtmann
at this is not an issue now, but n_tty will start using the > disc_data pointer and this invalid 'if' would trigger then rendering > TTYs over BT unusable. > > Signed-off-by: Jiri Slaby > Cc: Marcel Holtmann > Cc: Gustavo Padovan > Cc: Johan Hedberg > Cc: linux-bl

Re: [PATCH RESEND net-next] bluetooth: hci_core: Replace list_for_each with list_for_each_entry() helper

2012-10-22 Thread Marcel Holtmann
Hi Denis, > Replace list_for_each with list_for_each_entry() helper > > Signed-off-by: Denis Kirjanov > --- > include/net/bluetooth/hci_core.h | 20 > 1 files changed, 8 insertions(+), 12 deletions(-) Acked-by: Marcel Holtmann Regards Marcel -- T

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-17 Thread Marcel Holtmann
Hi Bing, > Add a "wireless/nl80211_iftype" entry in the net device sysfs > file structure to indicate the mode of the wireless device so > it can be discovered easily from userspace. I do question a little bit the usefulness for this one. It would only work on netdev and on wdev devices. Using n

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-17 Thread Marcel Holtmann
Hi Nicolas, >>> Add a "wireless/nl80211_iftype" entry in the net device sysfs >>> file structure to indicate the mode of the wireless device so >>> it can be discovered easily from userspace. >> >> What's wrong with "iw dev", i.e. netlink/nl80211? > > "Do NOT screenscrape this tool, we don't con

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Marcel Holtmann
Hi Paul, > The original reason to request this change was simple: to figure out > what type of interface we are looking at, since now some wireless > drivers can simultaneously create managed, p2p and ap interfaces. > Knowing that, from a simple front-end (let's even say a shell script) > we can d

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Marcel Holtmann
Hi Bing, >>> Add a "wireless/nl80211_iftype" entry in the net device sysfs >>> file structure to indicate the mode of the wireless device so >>> it can be discovered easily from userspace. >> >> I do question a little bit the usefulness for this one. >> It would only work on netdev and on wdev de

Re: pull request: bluetooth 2013-06-23

2013-06-25 Thread Marcel Holtmann
Hi Pavel, >> Jaganath Kanakkassery (1): >> Bluetooth: Fix invalid length check in l2cap_information_rsp() > > Could we add the "3.10 vs. thinkpad x60" patch that fixes regression? > It is from Johan Hedberg… that one went into net-next tree. It is scheduled for 3.11 right now. After 3.10 i

Re: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K

2013-07-29 Thread Marcel Holtmann
Hi Hector, > The Atheros firmware download driver is not dependent on HCI > USB driver. This driver is needed to complement any Atheros > driver like BT_HCIUART_ATH3K. > > Signed-off-by: Hector Palacios > CC: Suraj Sumangala > CC: Vikram Kandukuri > --- > drivers/bluetooth/Kconfig | 1 - > 1 fi

Re: linux-next: Tree for Apr 26 (nfc)

2013-04-26 Thread Marcel Holtmann
Hi Randy, >> Hi all, >> >> Changes since 20130424: >> > > > on i386: > > net/built-in.o: In function `nfc_unregister_device': > (.text+0x6a36d): undefined reference to `rfkill_unregister' > net/built-in.o: In function `nfc_unregister_device': > (.text+0x6a378): undefined reference to `rfkill_

Re: [PATCH] Bluetooth: Add support for Apple vendor-specific devices

2012-08-26 Thread Marcel Holtmann
10,1 (Retina). If you want, I can > follow-up with a patch for 3.7 which removes the specific entries. I > have verified the lsusb output of all of them, except MacMini5,1. > > Thanks, > Henrik > > drivers/bluetooth/btusb.c | 3 +++ > 1 file changed, 3 insertions(+) Ac

Re: [PATCH] add support bluetooth usb 0489:e046 Foxconn / Hon Hai

2012-08-12 Thread Marcel Holtmann
Hi, > $ usb-deveices > T: Bus=01 Lev=02 Prnt=02 Port=02 Cnt=03 Dev#= 5 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e046 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=C01885F67F9E > C: #Ifs= 4 Cfg#= 1 Atr=

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-19 Thread Marcel Holtmann
Hi Andi, If noone in the isdn community step up and take some responsibility for the current isdn drivers in Linux then we should just delete them. So you're saying anything that has no active maintainer should be immediately deleted? You do not recognize a provocation when you see it? I w

Re: Kernel oops with bluetooth usb dongle

2008-02-19 Thread Marcel Holtmann
Hi Thomas, Can you please enable CONFIG_SLUB_DEBUG=y and CONFIG_SLUB_DEBUG_ON=y and give it another try? If we can not catch it that way, I'll whip up a patch which points us to the code which added the offending timer. Hi, Note: I switched to 2.6.25-rc2. The only new thing I see is this

Re: [PATCH][BLUETOOTH] add HCI_BROKEN_ISOC for 0e5e:6622 (bugzilla #9027)

2008-02-19 Thread Marcel Holtmann
Hi, This patch fix bugzilla #9027. ``Syslog flooded with "hci_scodata_packet: hci0 SCO packet for unknown connection handle 92" message" see http://bugzilla.kernel.org/show_bug.cgi?id=9027 when we get the content of /proc/bus/usb/devices for this one. Do you have the manufacturer name o

Re: [PATCH 1/2] firmware: move firmware_class from Documentation/ to samples/

2008-02-20 Thread Marcel Holtmann
Hi Randy, Move the firmware_class sample drivers to samples/ so that they are buildable and can be maintained. Add Kconfig entry for firmware_class. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> this is a good idea. Acked-by: Marcel Holtmann <[EMAIL PROTECTED]> Regards M

Re: [PATCH 2/2] firmware: fix a few build errors

2008-02-20 Thread Marcel Holtmann
Hi Randy, Fix one typo (comma to semi-colon). Fix sysfs externs (just use sysfs.h for prototypes). Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file' include/linux/sysfs.h:100: error: previous declaration of 'sysfs_remove_b

Re: Plans for mISDN? Was: [PATCH 00/14] [ISDN] ...

2008-02-21 Thread Marcel Holtmann
Hi Simon, mISDN has two problems, which are of course interrelated: mISDN has one problem that is even bigger than these: the kernel oopses if modules aren't loaded in the right order. misdn-init works around that, but if it doesn't work for some reason (and I can think of multiple here)

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-05 Thread Marcel Holtmann
Hi David, > > I think you're missing my point: as long as the license stays the way > > it is now, you can never distribute proprietary code unless you've > > consulted a lawyer and even then you run the risk of being sued for > > infringement if the copyright holder thinks what you have is derive

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-05 Thread Marcel Holtmann
Hi David, > > if a new drivers is originally written for Linux, then you are breaking > > the GPL. > > Completely wrong. However if the driver is distributed as built-in, then it > would need to be licensed under GPL. This means that a driver can be > written and distributed as a module under

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-05 Thread Marcel Holtmann
Hi Chris, > > If the developers say that this symbol can only be used in GPL code (and > > with EXPORT_SYMBOL_GPL it is quite clear) then you have to obey to that > > license or don't use this symbol at all. > > > > If you use that symbol inside non-GPL (meaning you link at runtime) then > > you

Re: [PATCH][v4] ipwireless: driver for 3G PC Card

2008-02-05 Thread Marcel Holtmann
Hi Jiri, > > From: David Sterba <[EMAIL PROTECTED]> > > ipwireless: driver for PC Card, 3G internet connection > > Linus, as there is no PCMCIA maintainer and akpm apparently wants you to > merge this directly [1] -- what is your position on this one please? As > far as I can see all the major

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-06 Thread Marcel Holtmann
Hi Christer, > > while the HAL case of Atheros might be still true despite the fact > > that an OpenHAL has been around for a long time now. The Intel > > argument is out of the picture since quite some time. The regulatory > > daemon was an interim solution and has been replaced by a proper > > f

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-07 Thread Marcel Holtmann
Hi David, > > I disagree here. They either play by the roles or they really do pay > > Microsoft or go with BSD. I really couldn't care less. > Then you should keep away from the kernel. The last thing that Linux > needs is someone who doesn't care if Linux succeeds or fails. "I don't > care" wi

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-07 Thread Marcel Holtmann
Hi David, > >>> I think you're missing my point: as long as the license stays the way > >>> it is now, you can never distribute proprietary code unless you've > >>> consulted a lawyer and even then you run the risk of being sued for > >>> infringement if the copyright holder thinks what you have i

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-07 Thread Marcel Holtmann
Hi Diego, > > I think it is perfectly within their rights to do so. I think it's > > kind of silly to try to hide it, if someone wants to boost the maximum > > transmit power, they're going to hack the firmware anyway. But if it > > makes Intel happy, well... :-) > And break the HW :-) Actually,

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi David, > > I think you're missing my point: as long as the license stays the way > > it is now, you can never distribute proprietary code unless you've > > consulted a lawyer and even then you run the risk of being sued for > > infringement if the copyright holder thinks what yo

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi David, > > Anyway you are still under the impression that a Linux kernel module can > > be original work in the end. We keep telling you that could be a wrong > > assumption which is based on the view of many of the kernel developers > > and of most of the lawyers that looked at this specific t

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi Valdis, > > And while you are talking to a lawyer. Ask him/her if it is okay to > > create a binary only application that uses a GPL library. Tell him/her > > It's perfectly legal to create such an application. > > It only gets interesting if you *distribute* it... > > (And yes, this is wher

RE: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Marcel Holtmann
Hi David, > > Lets phrase this in better words as Valdis pointed out: You can't > > distribute an application (binary or source form) under anything else > > than GPL if it uses a GPL library. > > This simply cannot be correct. The only way it could be true is if the work > was a derivative work

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Marcel Holtmann
Hi Daniel, > > > > It makes no difference if you > > > > distribute the GPL library with it or not. > > > > > > If you do not distribute the GPL library, the library is simply being > > > used in the intended, ordinary way. You do not need to agree to, nor can > > > you violate, the GPL simply by

Re: [PATCH] Bluetooth: Add MacBookPro10,1 support

2012-07-10 Thread Marcel Holtmann
Hi Henrik, > > > > I believe the requirement is to always include a usb-devices output in > > > > the commit message (to let maintainers confirm that no typo has occurred > > > > in the patch itself). > > > > If you don't have access to the device I can take it without usb-devices, > > otherwise

Re: [PATCH v2] Bluetooth: Add MacBookPro10,1 support

2012-07-10 Thread Marcel Holtmann
Hi Henrik, > Add support for the 2012 15'' MacBook Pro Retina, also known as > MacBookPro10,1. The bluetooth device presents itself as > > Bus 002 Device 008: ID 05ac:8286 Apple, Inc. > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 2.00 >

Re: [PATCH] USB: add USB_VENDOR_AND_INTERFACE_INFO() macro

2012-07-10 Thread Marcel Holtmann
Hi Gustavo, > A lot of Broadcom Bluetooth devices provides vendor specific interface > class and we are getting flooded by patches adding new device support. > This change will help us enable support for any other Broadcom with vendor > specific device that arrives in the future. > > Only the pro

Re: [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in proper location

2013-01-19 Thread Marcel Holtmann
tas hardware, they're being moved into mrvl/ now. > > Signed-off-by: Lubomir Rintel > --- > drivers/bluetooth/btmrvl_sdio.c |8 > 1 files changed, 4 insertions(+), 4 deletions(-) Acked-by: Marcel Holtmann Regards Marcel -- To unsubscribe from this list: send th

Re: [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in proper location

2013-01-17 Thread Marcel Holtmann
Hi Lubumir, proper commit message with explanation here please. > Signed-off-by: Lubomir Rintel > --- > drivers/bluetooth/btmrvl_sdio.c |8 > drivers/bluetooth/btmrvl_sdio.h |6 -- > 2 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/bluetooth/btmrvl

Re: [PATCH] Add SDIO 'type' parameter to sysfs

2008-02-22 Thread Marcel Holtmann
Hi Andy, Add 'type' attribute of the SDIO device to represent Standard Function interface code in the human readable form. these kind of things should not be part of the Linux kernel. A userspace tool (call it lssdio if you want) should handle it. Regards Marcel -- To unsubscribe from th

Re: [Bluez-devel] forcing SCO connection patch

2008-02-25 Thread Marcel Holtmann
Hi Louis, I fixed all of errors except 80 characters warning. Thanks Louis JANG Signed-off-by: Louis JANG <[EMAIL PROTECTED]> --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25 17:17:11.0 +0900 +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25 17:30:23.0 +0900

Re: Kernel oops with bluetooth usb dongle

2008-02-25 Thread Marcel Holtmann
Hi Quel, -- Original message -- From: Thomas Gleixner <[EMAIL PROTECTED]> On Fri, 22 Feb 2008, David Woodhouse wrote: On Fri, 2008-02-22 at 08:23 +0100, Thomas Gleixner wrote: + del_timer(&conn->info_timer); + hcon->l2cap_data = NULL; kfre

Re: [PATCH] bluetooth: delete timer in l2cap_conn_del()

2008-02-26 Thread Marcel Holtmann
Hi Quel, Delete a possibly armed timer before kfree'ing the connection object. Solves: http://lkml.org/lkml/2008/2/15/514 Reported-by:Quel Qun <[EMAIL PROTECTED]> Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> --- net/bluetooth/l2cap.c |2 ++ 1 file changed, 2 insertions(+) Index: lin

Re: [Bluez-devel] forcing SCO connection patch

2008-02-26 Thread Marcel Holtmann
Hi Loius, --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25 17:17:11.0 +0900 +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25 17:30:23.0 +0900 @@ -1313,8 +1313,17 @@ hci_dev_lock(hdev); conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr); - if (!conn)

Re: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place

2013-01-08 Thread Marcel Holtmann
Hi Lubomir, > linux-firmware ships the sd8688* firmware images that are shared with > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both places > and so should we. > > Signed-off-by: Lubomir Rintel > --- > drivers/bluetooth/btmrvl_sdio.c | 24 ++-- > dr

Re: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place

2013-01-08 Thread Marcel Holtmann
Hi Lubomir, > > > > linux-firmware ships the sd8688* firmware images that are shared with > > > > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both > > > > places > > > > and so should we. > > > > > > > > Signed-off-by: Lubomir Rintel > > > > --- > > > > drivers/bluetooth/b

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > > > Mmm, probably that 2001 discussion about the keyspan firmware, right ? > > > > > > > > http://lists.debian.org/debian-legal/2001/04/msg00145.html > > > > > > > > Can you summarize the conclusion of the thread, or what you did get > > > > from it, > > > > please ? > > > > > >

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > I agree with Dmitry on this point. The IHEX parser should not be inside > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > That's what I had originally, actually called firmware_ihex.ko, since > the IHEX format parser is not in any way keyspan specific and there are

Re: debug: sleeping function...slab.c:2090

2005-04-05 Thread Marcel Holtmann
Hi Richard, > > I got the debug statement below during boot. > > > > Environment: > >Pentium M, Thinkpad R40 > >Debian unstable > >Linux 2.6.12-rc2 > >Gnu C 3.3.5 > >binutils 2.15 > > > > Debug: sleeping function called from invalid context at mm/slab.c:2090 > > in_atomic():1,

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Dmitry, > > People are also working on a replacement for the > > current request_firmware(), because the needs are changing. Try to keep > > it close with the usb-serial for now. > > > > Could you elaborate on what do you think is needed? I have some of > patches to firmware loader and wonder

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, > > > > I agree with Dmitry on this point. The IHEX parser should not be inside > > > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > > > > > That's what I had originally, actually called firmware_ihex.ko, since > > > the IHEX format parser is not in any way keyspan spe

Re: [2.4] "Fix" introduced in 2.4.27pre2 for bluetooth hci_usb race causes kernel hang

2005-04-09 Thread Marcel Holtmann
Hi Tomas, > I have noticed a problem with a race condition fix introduced in > 2.4.27-pre2 that causes the kernel to hang when disconnecting a > Bluetooth USB dongle or doing 'hciconfig hci0 down'. No message is > printed, the kernel just doesn't respond anymore. >

Re: [2.4] "Fix" introduced in 2.4.27pre2 for bluetooth hci_usb race causes kernel hang

2005-04-13 Thread Marcel Holtmann
ust doesn't respond anymore. > > > > > > Seen in Changelog: > > > Marcel Holtmann: > > > o [Bluetooth] Fix race in RX complete routine of the USB drivers > > > > > > Reversing the following patch to hci_usb_rx_complete() makes 2.4.27-pr

Re: [2.6 patch] net/bluetooth/: cleanups

2005-07-17 Thread Marcel Holtmann
Hi Adrian, > This patch contains the following cleanups: > - remove BT_DMP/bt_dump > - remove the following unneeded EXPORT_SYMBOL's: > - hci_core.c: hci_dev_get > - hci_core.c: hci_send_cmd > - hci_event.c: hci_si_event is this the same patch you sent me last time? I still have one of your

NULL pointer dereference at vt_ioctl()

2005-08-06 Thread Marcel Holtmann
Hi, with the latest 2.6.13-rc5-git kernel I see three weird oopses when I boot up my machine. All of refer to vt_ioctl(). Regards Marcel Unable to handle kernel NULL pointer dereference at virtual address printing eip: c022d1f5 *pde = Oops: [#1] SMP Modules linked in:

Re: [PATCH] spi

2005-08-08 Thread Marcel Holtmann
Hi Greg, > No spaces after ( or before ) please. You do this all over the place in > the code, please fix it up. > > > + if (NULL == dev || NULL == driver) { > > Put the variable on the left side, gcc will complain if you incorrectly > put a "=" instead of a "==" here, which is all that you a

Re: [PATCH ISDN] Fix capifs bug in initialization error path.

2005-08-27 Thread Marcel Holtmann
Hi Karsten, > > This patch fixes a bug in the capifs initialization code, where the > > filesystem is not unregistered if kern_mount() fails. > > > > Please apply. > > looks OK for me. and what about me idea to remove capifs completely? We have udev now and thus it is not needed anymore. I sto

Re: [GIT PATCH] W1 patches for 2.6.13

2005-09-08 Thread Marcel Holtmann
Hi Greg, > Here are some w1 patches that have been in the -mm tree for a while. > They add a new driver, and fix up the netlink logic a lot. They also > add a crc16 implementation that is needed. adding the CRC-16 is very cool. I was just about to submit one by my own, because it is also needed

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-06 Thread Marcel Holtmann
Hi David, might it not make more sense to put all of that into a new subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's more modular and it will keep that higher-level directory from potentially getting cluttered with even more drivers. and it would let you drop the point

Re: 2.6.24-rc4: bluetooth device gone after suspend to ram

2007-12-12 Thread Marcel Holtmann
Hi Oliver, > > I noticed that on my macbook pro1,1 the bluetooth device is gone after > > suspend to ram, i.e. > > Is this a regression? > Does it work if you unload hci_usb before you suspend? > If so, please recompile with CONFIG_USB_DEBUG and provide > dmesg. sometimes ACPI is involved and wi

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-21 Thread Marcel Holtmann
Hi Dave, > > Add people missed in cc-list. > > Thanks Dave for your continued efforts on Bluetooth bugs like this. > > Marcel, are you going to review/ACK/integrate/push-upstream/whatever > any of these Bluetooth patches? > > It hasn't been getting much love from you as of late, you are one of

Re: [PATCH] bluetooth : move children of connection device to NULL before connection down

2008-01-22 Thread Marcel Holtmann
Hi Dave, > could you tell something more about your coding style? > I would like to submit patches about bluetooth according to your sytle > later If I have. > > Maybe you could put it on the bluez web site or anywhere. it follows closely the kernel coding style as layout within the kernel docum

Re: [Bluez-users] Lost connections - mouse and keyboard

2007-11-29 Thread Marcel Holtmann
Hi Dave, apparently does manage bluetooth devices using bluetooth-input- service. I still have the problem of the devices disappearing if idle for too long such as when i lock the desktop or log out for a long period. Sometimes I can re-enable the devices, but sometimes I cannot. This is

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-01 Thread Marcel Holtmann
Hi David, > I'm submitting driver for IPWireless PC Card, used for 4G > internet connection. > The driver has been in -mm series as ipwireless_cs.git tree for > some time, is actively used and there are currently no > outstanding bugs. > > I'd like to let the driver pass through LKML and then let

Re: [Bluez-devel] 2.6.23.8: kernel panic

2007-11-27 Thread Marcel Holtmann
Hi Dave, > This problem is caused by the workqueue in hci_sysfs.c, the del_conn is > scheduled after the add_conn with same bluetooth address. > > Please try this patch: > > > The bluetooth hci conn sysfs add/del executed in the default workqueue. If > the conn del

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-30 Thread Marcel Holtmann
Hi Dave, > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > > If the del_conn is executed after the new add_conn with same target, > > add_conn will failed with warning of "same kobject name". > > > > Here add btaddconn & btdelconn workqueues, > > flush the btdelconn wo

Re: [2.6.24] bcm203x bluetooth dongle does not work

2008-01-30 Thread Marcel Holtmann
Hi Florian, > after trying around with my ancient bcm2033 bluetooth dongle i found it > not working in 2.6.24 - I debugged udev and found it loading the > firmware correctly but the device seems to have problems disconnecting. > > I found an Ubuntu bug which mentions a patch which supposed to be

Re: [PATCH] Add missing refrigerator calls

2005-03-15 Thread Marcel Holtmann
Hi Nigel, > There are a number of threads that currently have no refrigerator > handling in Linus' tree. This patch addresses part of that issue. The > remainder will be addressed in other patches, following soon. > > Signed-off-by: Nigel Cunningham <[EMAIL PROTECTED]> I am fine with the net/blu

Re: bcm203x broadcom dongle firmware upload fails...

2005-03-19 Thread Marcel Holtmann
Hi Soeren, > I don't see why, it used to work reliably at some point but now it does > not. It even won't work without hotplug and then manually typing: > > echo 1 > /sys/class/firmware/2-1/loading > cat /lib/firmware/BCM2033-FW.bin >/sys/class/firmware/2-1/data > echo 0 > /sys/class/firmware/2-1

Re: [2.6 patch] net/bluetooth/rfcomm/core.: make a variable static

2005-03-19 Thread Marcel Holtmann
Hi Adrian, > This patch makes a needlessly global variable static. the patch is in my tree now. Thanks. Regards Marcel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Re: How to read file in kernel module?

2005-02-07 Thread Marcel Holtmann
Hi, > > I have written one /proc file creation kernel > > module. This module creates /proc/file and defied > > operations on it. Also i have written user program > > that will read & write to /proc files from user space. > > Now what i want is to use same bufproc_read & > > bufproc_write

HID warning messages fills the logs

2005-01-28 Thread Marcel Holtmann
Hi, when running 2.6.11-rc2-bk6 with my USB HID v1.00 Mouse [Microsoft Microsoft Wheel Mouse Optical®] the logs get filled with this message: kernel: drivers/usb/input/hid-input.c: event field not found last message repeated 459 times last message repeated 1157 times Regards Marcel - To unsub

Re: recent 2.6.x USB HID input weirdness

2005-01-30 Thread Marcel Holtmann
Hi Dave, > On sparc64 I just started getting this in my kernel logs > on 2.6.x-BK from hidinput_input_event: > > warning: event field not found > > I added some debugging: > > hidinput_input_event: type[4] code [4] value[458759] > hidinput_input_event: type[4] code [4] value[458761] > > This i

Re: Patch to add usbmon

2005-02-01 Thread Marcel Holtmann
Hi Pete, today I just thought to give usbmon a try. Previously I used a hacked devio thing around usbfs_snoop to monitor the USB communication between a VMware and the Linux host. Greg, will such patch accepted for inclusion or will usbfs_snoop go away when usbmon is included? > > First off, why

Re: Patch to add usbmon

2005-02-01 Thread Marcel Holtmann
Hi Pete, > > By accident I removed the debugfs option from my kernel config and this > > makes usbmon totally useless. So I think the module approach is wrong > > from my point of view. Why not compile it always and if debugfs is > > available, then enable it when the usbcore gets loaded? > > Thi

Re: Patch to add usbmon

2005-02-02 Thread Marcel Holtmann
Hi Pete, > > I think if cat is the prefered tool for viewing this file then it should > > be more human readable. If not, then a binary format should be choosen. > > Maybe we can implement both. Is this possible? > > Yes. Now you know why files were split as they were. still no reason for me to

  1   2   3   4   5   6   7   8   9   10   >