Re: current git crashes on bootup with pci_iounmap()

2007-02-13 Thread Marcel Holtmann
Hi Kay, kernel BUG at lib/iomap.c:254! invalid opcode: [#1] ... The screen picture is here: http://vrfy.org/pci_iounmap.jpg It's a Thinkpad T43p. 2.6.20 was working fine. Commenting out: IO_COND(addr, /* nothing */, iounmap(addr)); in: lib/iomap.c:254 makes at least

Re: [PATCH] Optimize generic get_unaligned / put_unaligned implementations.

2007-02-15 Thread Marcel Holtmann
Hi Andrew, +#define get_unaligned(ptr) \ +({ \ + const struct { \ + union {

Re: Boot time Bluetooth BUG: warning: (value m) at hid-core.c:793

2007-02-18 Thread Marcel Holtmann
Hi Jiri, I m using a Logitech MX 5000 keyboard with an included MX 1000 mouse, both bluetooth using the same USB reciever. When the USB reciever is already plugged-in at boot-time and the Bluetooth service fires-up I get this message: === BUG: warning: (value m)

Re: unexpected continuation frame (len0)

2007-02-19 Thread Marcel Holtmann
Hi Yuiry, i'm using: bluez-* 3.9 kernel: 2.6.16 is error unexpected continuation frame (len0) is kind of bug? or may be bad bluetooth adapters? or i have missed something in my code? it is likely a bad adapter. What Bluetooth hardware are you using? Regards Marcel - To unsubscribe

Re: [Bluez-devel] 2.6.21-rc4-mm1

2007-03-21 Thread Marcel Holtmann
Hi Andrew, * Freezes immediately if I allow Bluetooth to configure. cc bluez-devel is the -mm specific or does this also happens with 2.6.21-rc4? Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: New format Intel microcode...

2007-03-23 Thread Marcel Holtmann
Hi Li, Is the tool you mentioned last June [1] available for splitting up the old firmware files to the new format (eg /lib/firmware/intel-ucode/06-0d-06), or are updates available from Intel (or otherwise) in this new format? Yes, we are preparing the new format data files and maybe put

Re: New format Intel microcode...

2007-03-26 Thread Marcel Holtmann
Hi Arjan, Is the tool you mentioned last June [1] available for splitting up the old firmware files to the new format (eg /lib/firmware/intel-ucode/06-0d-06), or are updates available from Intel (or otherwise) in this new format? Yes, we are preparing the new format data files

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-03-26 Thread Marcel Holtmann
Hi Li, -- HID bus design overview. -- A. Terms. The device of an driver: this mean the device that this driver matched. B. Design. As we discussed before, The entire HID subsystem is divided into

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Marcel Holtmann
Hi Dmitry, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. so do you think it would be better to create phys as a string of the source and destination address like src-dst for Bluetooth. And then keep the uniq empty like all

Re: Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Marcel Holtmann
Hi Dmitry, can anybody reply to this and share his/her opinion? Input core already exports uniq to udev and also via sysfs. so do you think it would be better to create phys as a string of the source and destination address like src-dst for Bluetooth. And then keep the uniq

Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Marcel Holtmann
Hi Michal, I need this for differing Option XkbModel in Xorg, so I can bind to each device it's model and has correct xev's scancodes based on model. So I prefer to have as Phis just only BDADDR, because for me this doesn't make sense to have there device to which keyboard connect. Then I

Re: Phis in /proc/bus/input/devices same for all devices?

2007-02-21 Thread Marcel Holtmann
Hi Michal, how can you differ what is src and what is dst, when device can connect first time from hub to keyboard and later keyboard to hub? the source is always the host (meaning the adapter) and the destination is always the device. Regards Marcel - To unsubscribe from this list: send

Re: 2.6.20-almost-rc1: usb oops during resume

2007-02-24 Thread Marcel Holtmann
Hi Pavel, ...is it use after free? Greg, could we reduce verbosity of driver model? PM: Adding info for No Bus:vcs* is not very useful. I have some patches in bluetooth, but nothing that should really matter. can you try to remove the hci_usb_close() in hci_usb_disconnect(), because

Re: [RFC][PATCH 6/7] Freezer: Remove PF_NOFREEZE from bluetooth threads

2007-02-25 Thread Marcel Holtmann
/bluetooth/hidp/core.c |4 +++- net/bluetooth/rfcomm/core.c |4 +++- 4 files changed, 13 insertions(+), 5 deletions(-) Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] for the Bluetooth part of this patch series. Regards Marcel - To unsubscribe from this list: send the line

Re: [Regression] Bluetooth RFComm: using it locks up the machine

2007-03-04 Thread Marcel Holtmann
) fixes it: | author Marcel Holtmann [EMAIL PROTECTED] | Sat, 17 Feb 2007 22:58:57 + (23:58 +0100) | committer David S. Miller [EMAIL PROTECTED] | Mon, 26 Feb 2007 19:42:41 + (11:42 -0800) | commit c1a3313698895d8ad4760f98642007bf236af2e8 | tree

Re: 2.6.21-rc2: bluetooth hardlocks [regression from -rc1]

2007-03-05 Thread Marcel Holtmann
Hi Pavel, As soon as I try to start bluetooth connection (gprs over nokia 6230) on thinkpad x60 (internal bluetooth dongle, connected over usb), machine hangs. It worked okay in -rc1 (modulo suspend issues). this might be the same issue that Mark Lord reported recently. It seems that the

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-05 Thread Marcel Holtmann
Hi Greg, Subject: Bluetooth RFComm locks up the machine (device_move() related) References : http://lkml.org/lkml/2007/3/4/64 Submitter : Mark Lord [EMAIL PROTECTED] Caused-By : Marcel Holtmann [EMAIL PROTECTED] commit c1a3313698895d8ad4760f98642007bf236af2e8

Re: [DOC] The documentation for HID Simple Driver Interface 0.5.0

2007-03-05 Thread Marcel Holtmann
Hi Li, == HID device simple driver interface == actually, I don't think we need a simple driver interface. We need a HID driver interface in general. For example that you can register a driver for one or multiple report ID and

[PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver

2007-03-06 Thread Marcel Holtmann
more than 512 bytes can overflow of the driver's read buffer, with the same effects as above. Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Harald Welte [EMAIL PROTECTED] --- commit 5be3f29dbb70cf7b3eaa5e1be6dfa553c98ea1ad tree 158eb27c16e372650d7bc8c6536b46f052932148 parent

Re: [DOC] The documentation for HID Simple Driver Interface 0.5.0

2007-03-06 Thread Marcel Holtmann
Hi Dmitry, This also means that the current keyboard and mouse input devices will become a HID driver. Are you talking about usbmouse and usbkbd? no, because if I recall correctly these are the boot mode drivers and actually not used at all in any modern distribution. For me the task of

Re: [DOC] The documentation for HID Simple Driver Interface 0.5.0

2007-03-06 Thread Marcel Holtmann
Hi Jiri, For me the task of converting HID reports into input events shouldn't be actually the job of the HID core layer. My understanding is that the HID core should support multiple transport layers. This is currently achieved through the hid_device abstraction and used by the USB

Re: question on tty open and close

2007-03-28 Thread Marcel Holtmann
Hi Alan, As long as the new behavior continues to call driver-close() if driver-open() succeeds then I see no problem. It breaks if any existing driver is doing no cleanup in -open() when it fails but relying upon -close() being called. That is what needs auditing first of all. I know

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-04-02 Thread Marcel Holtmann
Hi Dmitry, The crucial thing here is that all reports but the ones that the driver registered to will be processed in a standard way by the generic hid bus layer, and those reports that the driver registered to will be ignored by the layer, and passed for processing to the driver. I

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-04-02 Thread Marcel Holtmann
Hi Li, JFYI the preliminary version of the hidraw interface is now in the hid/usbhid git tree, and has also been in a few recent -mm kernels already. The shadow driver support works now. The most largest problem is HID/Bluetooth can not work now. And, I have no any bluetooth

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-04-02 Thread Marcel Holtmann
Hi Jiri, I like this idea, but it might not solve the case where you have parts of the driver in kernel space and other parts in user space. For example the control of a LCD display on the keyboard. However in most cases registering drivers for a report id should be enough. the

Re: MODULE_MAINTAINER

2007-04-04 Thread Marcel Holtmann
Hi Christoph, Can we have a MODULE_MAINTAINER to complement MODULE_AUTHOR? #define MODULE_MAINTAINER(x) MODULE_AUTHOR(x), please. MODULE_AUTHOR really has meant maintainer in practice for ages, and it's the only actually relevant for users information we should store. I agree. The actual

Re: [linux-usb-devel] [RFC] HID bus design overview.

2007-04-04 Thread Marcel Holtmann
Hi Jiri, What's the position of hidraw? It only is used when all other driver is not usable on some report? or, it should be stick every working device. Current implementation (as you can see it in -mm or in my hid.git tree) is creating hidraw interface for just every HID

Re: MODULE_MAINTAINER

2007-04-04 Thread Marcel Holtmann
Hi Alan, Given that people seem to agree that authorship information has no place in the binary, that might actually be best. Authorship information is very useful in the binary, especially when you have to get lawyers involved in explaining things to people. Company business and

Re: hci_sock.c build failure

2007-09-12 Thread Marcel Holtmann
Hi Dave, It's not even a randconfig issue, my build dies too (this is Linus's current tree.) Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. the patch looks absolutely fine to me. You can put an Acked-by line to it. Sorry

Re: hci_sock.c build failure

2007-09-13 Thread Marcel Holtmann
Hi Toralf, I'm wondering why the build failure wasn't fixed by a patch like this: diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c index 5ccea5f..85416bb 100644 --- a/net/bluetooth/hci_sock.c +++ b/net/bluetooth/hci_sock.c @@ -348,8 +348,6 @@ static inline void

Re: [Bluez-users] Lost connections - mouse and keyboard

2007-11-29 Thread Marcel Holtmann
Hi Dave, apparently does manage bluetooth devices using bluetooth-input- service. I still have the problem of the devices disappearing if idle for too long such as when i lock the desktop or log out for a long period. Sometimes I can re-enable the devices, but sometimes I cannot. This is

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-01 Thread Marcel Holtmann
Hi David, I'm submitting driver for IPWireless PC Card, used for 4G internet connection. The driver has been in -mm series as ipwireless_cs.git tree for some time, is actively used and there are currently no outstanding bugs. I'd like to let the driver pass through LKML and then let it

Re: [PATCH] ipwireless_cs driver for 4G PC Card

2007-12-06 Thread Marcel Holtmann
Hi David, might it not make more sense to put all of that into a new subdirectory, say, /drivers/char/pcmcia/ipwireless_cs? that way, it's more modular and it will keep that higher-level directory from potentially getting cluttered with even more drivers. and it would let you drop the

Re: [Bluez-devel] 2.6.23.8: kernel panic

2007-11-27 Thread Marcel Holtmann
Hi Dave, This problem is caused by the workqueue in hci_sysfs.c, the del_conn is scheduled after the add_conn with same bluetooth address. Please try this patch: The bluetooth hci conn sysfs add/del executed in the default workqueue. If the conn del

Re: 2.6.24-rc4: bluetooth device gone after suspend to ram

2007-12-12 Thread Marcel Holtmann
Hi Oliver, I noticed that on my macbook pro1,1 the bluetooth device is gone after suspend to ram, i.e. Is this a regression? Does it work if you unload hci_usb before you suspend? If so, please recompile with CONFIG_USB_DEBUG and provide dmesg. sometimes ACPI is involved and will

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Marcel Holtmann
Hi Dave, diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:55.0 +0800 @@ -302,7 +302,8 @@ void

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Marcel Holtmann
Hi Dave, diff -upr linux/net/bluetooth/hci_sysfs.c linux.new/net/bluetooth/hci_sysfs.c --- linux/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:00.0 +0800 +++ linux.new/net/bluetooth/hci_sysfs.c 2007-10-31 10:21:55.0 +0800 @@ -302,7 +302,8 @@ void

Re: [PATCH]bluetooth: hci_sysfs connection bus_id add support for diffrent hci device

2007-10-31 Thread Marcel Holtmann
Hi Dave, Maybe we can use this instead: snprintf(conn-dev.bus_id, BUS_ID_SIZE, - %s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X, + %s%s%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X, + hdev-name + 3, conn-type ==

Re: [PATCH] bluetooth: hidp core debug code wrong argument fix

2007-10-20 Thread Marcel Holtmann
Hi Dave, In the debug code of the hidp_queue_report function, the device variable does not exist, replace it with session-hid applied to my tree. Thanks. Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [Bluez-devel] [PATCH] bluetooth: Eliminate checks for impossible conditions in irq handler

2007-10-20 Thread Marcel Holtmann
Hi Jeff, [BLUETOOTH] Eliminate checks for impossible conditions in irq handler Our info structure and info-hdev is always passed to the irq handler, so we don't have to worry about these checks in every interrupt. Leave a BUG_ON() just to help unwary programmers,

Re: [BUG] rfcomm]

2007-10-23 Thread Marcel Holtmann
Hi Alon, I have this issue for long time (At least from linux-2.6.18). I think it is about time I report this... :) When coming out of suspend (uswsusp or suspend2) if rfcomm was active it creates this dump. If you need any more info I will be glad to provide. first of all, please check

Re: [BUG] rfcomm]

2007-10-23 Thread Marcel Holtmann
Hi Jiri, Second, can you try without uswsusp or suspend2. Both of them are not upstream and I can't tell how much these would effect this kind of behavior. Hi Marcel, actually uswsusp has been upstream for quite some time already. See Documentation/power/userland-swsusp.txt nice.

Re: [BUG] rfcomm]

2007-10-23 Thread Marcel Holtmann
Hi Alon, first of all, please check if this still happens with 2.6.23, because we had some patches in the area of the RFCOMM TTY code that might have fixed this. These messages are of 2.6.23. still another one to go :( Anyway since you have experience and you have a way to reproduce it,

Re: [BUG] rfcomm]

2007-10-23 Thread Marcel Holtmann
Hi Alon, nice. I've never used it. Currently I am using what comes with Ubuntu 7.10 and that seems to work. Have you tried to suspend while pppd is using rfcomm? The fact that it happens with suspend2 and uswsusp means that the issue is suspend blind. Do you need any more information

Re: [2.6 patch] drivers/bluetooth/bpa10x.c: fix memleak

2007-10-24 Thread Marcel Holtmann
Hi Adrian, This patch fixea a memleak spotted by the Coverity checker. good catch. Patch has been applied to me tree. Thanks. Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] drivers/bluetooth/btsdio.c: fix double-free

2007-10-24 Thread Marcel Holtmann
Hi Adrian, This patch fixes a double-free spotted by the Coverity checker. good catch. Patch has been applied to me tree. Thanks. Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Marcel Holtmann
Hi Daniel, It makes no difference if you distribute the GPL library with it or not. If you do not distribute the GPL library, the library is simply being used in the intended, ordinary way. You do not need to agree to, nor can you violate, the GPL simply by using a work in its

Re: [PATCH][BLUETOOTH] add HCI_BROKEN_ISOC for 0e5e:6622 (bugzilla #9027)

2008-02-13 Thread Marcel Holtmann
Hi, This patch fix bugzilla #9027. ``Syslog flooded with hci_scodata_packet: hci0 SCO packet for unknown connection handle 92 message see http://bugzilla.kernel.org/show_bug.cgi?id=9027 when we get the content of /proc/bus/usb/devices for this one. Do you have the manufacturer name of it

Re: [PATCH][BLUETOOTH] add HCI_BROKEN_ISOC for 0e5e:6622 (bugzilla #9027)

2008-02-13 Thread Marcel Holtmann
Hi, This patch fix bugzilla #9027. ``Syslog flooded with hci_scodata_packet: hci0 SCO packet for unknown connection handle 92 message see http://bugzilla.kernel.org/show_bug.cgi?id=9027 when we get the content of /proc/bus/usb/devices for this one. Do you have the

Re: [Bluez-devel] [PATCH 14/14] net/bluetooth/hci_core.c: Use time_* macros

2008-02-14 Thread Marcel Holtmann
] Signed-off-by: S.Çağlar Onur [EMAIL PROTECTED] since this is full serious of patches, I am not sure if it should go via the subsystem maintainers or better applied as whole. In case of Linus or Andrew decide to take them all at once and push them, this on is acked by me. Acked-by: Marcel Holtmann

Re: [PATCH RESEND net-next] bluetooth: hci_core: Replace list_for_each with list_for_each_entry() helper

2012-10-22 Thread Marcel Holtmann
Hi Denis, Replace list_for_each with list_for_each_entry() helper Signed-off-by: Denis Kirjanov kirja...@gmail.com --- include/net/bluetooth/hci_core.h | 20 1 files changed, 8 insertions(+), 12 deletions(-) Acked-by: Marcel Holtmann mar...@holtmann.org Regards

Re: [PATCH 08/21] TTY: hci_ldisc, remove invalid check in open

2012-10-18 Thread Marcel Holtmann
will start using the disc_data pointer and this invalid 'if' would trigger then rendering TTYs over BT unusable. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Marcel Holtmann mar...@holtmann.org Cc: Gustavo Padovan gust...@padovan.org Cc: Johan Hedberg johan.hedb...@gmail.com Cc: linux-blueto

Re: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-24 Thread Marcel Holtmann
Hi, This patch does the following things: - Make hidp_setup_input() return int to indicate errors. - Check its return value to handle errors. Signed-off-by: WANG Cong [EMAIL PROTECTED] --- net/bluetooth/hidp/core.c |7 --- 1 file changed, 4 insertions(+), 3

Re: What's in mmc.git for 2.6.24

2007-09-24 Thread Marcel Holtmann
Hi Pierre, There are currently three working drivers for this new stack: - sdio_uart: A driver for the standardised GPS and UART interfaces. Currently we only know how the GPS system works, so UART is only a future possibility. - libertas_sdio: Support for Marvell's 8686 Libertas wifi

Re: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-24 Thread Marcel Holtmann
Hi Wang, This patch: - makes hidp_setup_input() return int to indicate errors; - checks its return value to handle errors. And this time it is against -rc7-mm1 tree. Thanks to roel and Marcel Holtmann for comments. Signed-off-by: WANG Cong [EMAIL PROTECTED] Signed-off-by: Marcel

Re: [Bluez-devel] Warnings and Oops on 2.6.23-rc6 while activily using rfcomm links (mm/slab.c)

2007-09-26 Thread Marcel Holtmann
Hi Pierre-Yves, Putting the bluetooth system under load (opening and closing several rfcomm links off several USB adapters, and transmitting data over them), I got the Oops below. The computer hung completely, as you can see. Just before, I also got those warnings. I got another one

Re: [Bluez-devel] Warnings and Bug on 2.6.23-rc6 closing rfcomm links (device_move() API ?)

2007-09-27 Thread Marcel Holtmann
Hi Cornelia, Yet another report, once again while putting rfcomm system under load. Several USB adapters, several links. Is this a regression or does it happen with 2.6.22 too? I've not tested with 2.6.22, but have done it a few days ago with 2.6.21-2-486 (stock debian

Re: bluetooth: hci_sysfs work queue problem

2007-10-01 Thread Marcel Holtmann
Hi Dave, The hci_sysfs uses work queue to finish the sysfs add/del fuction. But when the same device connection failed, if another connection of same device come in before the delete work finish, sysfs will warn about duplicate filename creating. which kernel are we talking about. This

Re: net/bluetooth/rfcomm/tty.c: use-after-free

2007-07-23 Thread Marcel Holtmann
)) { list_del(dev-list); kfree(dev); return PTR_ERR(dev-tty_dev); } ... -- snip -- Spotted by the Coverity checker. really good catch. I fully overlooked that one. The attached patch should fix it. Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Regards

Re: [PATCH 1/4] fix endianness bug in l2cap_sock_listen()

2007-07-27 Thread Marcel Holtmann
in -psm are storing little-endian. Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Dave, all four patches are good and should go in sooner than later. If you want me to put them into my tree first, then I can do that or you can apply them directly. You choice

Re: [PATCH 2/4] l2cap: endianness annotations

2007-07-27 Thread Marcel Holtmann
Hi Al, no code changes, just documenting existing types Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/4] pass (host-endian) cmd length as explicit argument to l2cap_conf_req()

2007-07-27 Thread Marcel Holtmann
Hi All, Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 4/4] l2cap: don't mangle cmd.len

2007-07-27 Thread Marcel Holtmann
Hi Al, Since nobody uses it after we convert it to host-endian, no need to do that at all. At that point l2cap is endian-clean. Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line

Re: [PATCH] Reset current-pdeath_signal on SUID binary execution

2007-08-23 Thread Marcel Holtmann
Hi, the attached patch fixes a flaw in the parent process death signal when executing SUID binaries. An unprivileged user may send arbitrary signal to a child process even if it is running with higher privileges. The idea to fix this issue is to reset pdeath_signal not only on fork, but

Re: Linux 2.6.20.17

2007-08-26 Thread Marcel Holtmann
Hi Boris, I'm getting build errors: x86_64 allyesconfig, allmodconfig: drivers/ata/pata_atiixp.c:286: error: 'PCI_DEVICE_ID_ATI_IXP700_IDE' undeclared here (not in a function) net/bluetooth/rfcomm/tty.c:275: error: 'struct rfcomm_dev' has no member named 'tty_dev'

Re: [Bluez-devel] [PATCH] [96/2many] MAINTAINERS - BLUETOOTH SUBSYSTEM

2007-08-13 Thread Marcel Holtmann
Hi Joe, Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] Signed-off-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] Firmware class name collision

2007-08-13 Thread Marcel Holtmann
would prefer if we use firmware-%s since the fw might collide with the new Firewire stack. Please change that and I agree. Acked-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] Firmware class name collision

2007-08-13 Thread Marcel Holtmann
] Acked-by: Marcel Holtmann [EMAIL PROTECTED] Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] Reset current-pdeath_signal on SUID binary execution

2007-08-17 Thread Marcel Holtmann
Holtmann [EMAIL PROTECTED] --- commit 8542f23e44f591480ca53d215481cbec43b8cbed tree d72f29856adb306f20e828d4bab244685fe24bf2 parent 6adb31c90c47262c8a25bf5097de9b3426caf3ae author Marcel Holtmann [EMAIL PROTECTED] Fri, 17 Aug 2007 21:41:52 +0200 committer Marcel Holtmann [EMAIL PROTECTED] Fri, 17

Re: sdio: add linux/mmc/sdio_csr.h for CSR specific CCCR registers

2007-08-10 Thread Marcel Holtmann
Hi David, are these CSR extensions specific to Bluetooth or do they also apply to your WiFi and Ultra-Wideband products? If they are Bluetooth specific, we might simply keep them inside the Bluetooth SDIO driver. Regards Marcel - To unsubscribe from this list: send the line unsubscribe

Re: [ANNOUNCE] SDIO soon in mainline

2007-08-12 Thread Marcel Holtmann
Hi, I am happy to announce that SDIO support will soon be a standard feature in Linux. No more proprietary stacks with all the troubles (legal and technical) that go with them. The new code is written from scratch by yours truly and Nicolas Pitre. There were several stacks out there that

Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-29 Thread Marcel Holtmann
Hi Eugene, Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all the possible NULL dereferences. Besides hci_uart_close(), we also need to make sure that hdev is valid before calling hci_{unregister,free}_dev(). I don't see any issue. Without HCI_UART_PROTO_SET, the

Re: [PATCH] drivers/bluetooth/hci_ldisc.c: fix possible NULL dereferences

2007-07-30 Thread Marcel Holtmann
Hi Eugene, Commit 22ad42033b7d2b3d7928fba9f89d1c7f8a3c9581 did not completely fix all the possible NULL dereferences. Besides hci_uart_close(), we also need to make sure that hdev is valid before calling hci_{unregister,free}_dev(). I don't see any issue. Without HCI_UART_PROTO_SET,

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is not in any way keyspan specific and there

Re: [2.4] Fix introduced in 2.4.27pre2 for bluetooth hci_usb race causes kernel hang

2005-04-09 Thread Marcel Holtmann
Hi Tomas, I have noticed a problem with a race condition fix introduced in 2.4.27-pre2 that causes the kernel to hang when disconnecting a Bluetooth USB dongle or doing 'hciconfig hci0 down'. No message is printed, the kernel just doesn't respond anymore. Seen in Changelog: Marcel

Re: [2.4] Fix introduced in 2.4.27pre2 for bluetooth hci_usb race causes kernel hang

2005-04-13 Thread Marcel Holtmann
: Marcel Holtmann: o [Bluetooth] Fix race in RX complete routine of the USB drivers Reversing the following patch to hci_usb_rx_complete() makes 2.4.27-pre2 up until 2.4.30 happy and does not hang when removing the dongle anymore. (bfusb.c has the same patch applied) 2.6.11.7

Re: How to read file in kernel module?

2005-02-07 Thread Marcel Holtmann
Hi, I have written one /proc file creation kernel module. This module creates /proc/file and defied operations on it. Also i have written user program that will read write to /proc files from user space. Now what i want is to use same bufproc_read bufproc_write functions

Re: [2.6 patch] net/bluetooth/: cleanups

2005-07-17 Thread Marcel Holtmann
Hi Adrian, This patch contains the following cleanups: - remove BT_DMP/bt_dump - remove the following unneeded EXPORT_SYMBOL's: - hci_core.c: hci_dev_get - hci_core.c: hci_send_cmd - hci_event.c: hci_si_event is this the same patch you sent me last time? I still have one of your

Re: [PATCH] Add missing refrigerator calls

2005-03-15 Thread Marcel Holtmann
Hi Nigel, There are a number of threads that currently have no refrigerator handling in Linus' tree. This patch addresses part of that issue. The remainder will be addressed in other patches, following soon. Signed-off-by: Nigel Cunningham [EMAIL PROTECTED] I am fine with the

Re: bcm203x broadcom dongle firmware upload fails...

2005-03-19 Thread Marcel Holtmann
Hi Soeren, I don't see why, it used to work reliably at some point but now it does not. It even won't work without hotplug and then manually typing: echo 1 /sys/class/firmware/2-1/loading cat /lib/firmware/BCM2033-FW.bin /sys/class/firmware/2-1/data echo 0 /sys/class/firmware/2-1/loading

Re: [2.6 patch] net/bluetooth/rfcomm/core.: make a variable static

2005-03-19 Thread Marcel Holtmann
Hi Adrian, This patch makes a needlessly global variable static. the patch is in my tree now. Thanks. Regards Marcel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH][MMC] Secure Digital (SD) support

2005-03-04 Thread Marcel Holtmann
Hi Pierre, Here are the patches for Secure Digital support that I've been sitting on for a while. I tried to get some feedback on inclusion of this previously but since I didn't get any I'll just submit the thing. It was originally diffed against 2.6.10 but it applies to 2.6.11 just fine

Re: [PATCH][MMC] Secure Digital (SD) support

2005-03-04 Thread Marcel Holtmann
Hi Pierre, lately I got a request for the support of a Bluetooth SD card. These are using SDIO and I think at the moment only memory cards are handled. Do you have any plans for SDIO support? I would if I had some hardware to play with *hint* *hint* ;) I don't have one of these cards

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, Mmm, probably that 2001 discussion about the keyspan firmware, right ? http://lists.debian.org/debian-legal/2001/04/msg00145.html Can you summarize the conclusion of the thread, or what you did get from it, please ? That people didn't like the

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Jan, I agree with Dmitry on this point. The IHEX parser should not be inside firmware_class.c. What about using keyspan_ihex.[ch] for it? That's what I had originally, actually called firmware_ihex.ko, since the IHEX format parser is not in any way keyspan specific and there are

Re: debug: sleeping function...slab.c:2090

2005-04-05 Thread Marcel Holtmann
Hi Richard, I got the debug statement below during boot. Environment: Pentium M, Thinkpad R40 Debian unstable Linux 2.6.12-rc2 Gnu C 3.3.5 binutils 2.15 Debug: sleeping function called from invalid context at mm/slab.c:2090 in_atomic():1, irqs_disabled():0

Re: [PATCH 00/04] Load keyspan firmware with hotplug

2005-04-05 Thread Marcel Holtmann
Hi Dmitry, People are also working on a replacement for the current request_firmware(), because the needs are changing. Try to keep it close with the usb-serial for now. Could you elaborate on what do you think is needed? I have some of patches to firmware loader and wondering if we

Warning of redefined NR_OPEN

2005-02-22 Thread Marcel Holtmann
Hi, when compiling the latest 2.6 tree from the Bitkeeper repository, I get a lot of these: CC init/main.o In file included from include/linux/fs.h:202, from include/linux/proc_fs.h:6, from init/main.c:17: include/linux/limits.h:4:1: warning: NR_OPEN

Re: [PATCH] Modules: Allow sysfs module paramaters to be written to.

2005-01-25 Thread Marcel Holtmann
Hi Greg, Here's a patch that fixes this for me. It's as if the function was never implemented at all for some reason. Sorry for not catching this when tj's patches went in that changed all of this logic. Let me know if this fixes the problem for you or not. works fine for me. Please

HID warning messages fills the logs

2005-01-28 Thread Marcel Holtmann
Hi, when running 2.6.11-rc2-bk6 with my USB HID v1.00 Mouse [Microsoft Microsoft Wheel Mouse Optical®] the logs get filled with this message: kernel: drivers/usb/input/hid-input.c: event field not found last message repeated 459 times last message repeated 1157 times Regards Marcel - To

Re: recent 2.6.x USB HID input weirdness

2005-01-30 Thread Marcel Holtmann
Hi Dave, On sparc64 I just started getting this in my kernel logs on 2.6.x-BK from hidinput_input_event: warning: event field not found I added some debugging: hidinput_input_event: type[4] code [4] value[458759] hidinput_input_event: type[4] code [4] value[458761] This is on a Sun

Re: Patch to add usbmon

2005-02-01 Thread Marcel Holtmann
Hi Pete, today I just thought to give usbmon a try. Previously I used a hacked devio thing around usbfs_snoop to monitor the USB communication between a VMware and the Linux host. Greg, will such patch accepted for inclusion or will usbfs_snoop go away when usbmon is included? First off, why

Re: Patch to add usbmon

2005-02-01 Thread Marcel Holtmann
Hi Pete, By accident I removed the debugfs option from my kernel config and this makes usbmon totally useless. So I think the module approach is wrong from my point of view. Why not compile it always and if debugfs is available, then enable it when the usbcore gets loaded? This may be

Re: Patch to add usbmon

2005-02-02 Thread Marcel Holtmann
Hi Pete, I think if cat is the prefered tool for viewing this file then it should be more human readable. If not, then a binary format should be choosen. Maybe we can implement both. Is this possible? Yes. Now you know why files were split as they were. still no reason for me to split

Re: Patch to add usbmon

2005-02-04 Thread Marcel Holtmann
Hi Pete, While I am really thinking about starting usbdump, I may ask why you have choosen to use debugfs as interface. This will not be available in normal distribution kernels and I think a general USB monitoring ability would be great. For example like we have it for Ethernet,

Re: module's parameters could not be set via sysfs in 2.6.11-rc1?

2005-01-22 Thread Marcel Holtmann
Hi Greg, It looks like module parameters are not setable via sysfs in 2.6.11-rc1 E.g. arise parameters # echo -en Y /sys/module/usbcore/parameters/old_scheme_first -bash: /sys/module/usbcore/parameters/old_scheme_first: Permission denied arise parameters # id uid=0(root)

Re: 2.6.11-rc2 complains badly aboud badness in local_bh_enable

2005-01-23 Thread Marcel Holtmann
Hi Pavel, -rc1 worked fine here. -rc2 complains a lot: Jan 23 12:59:50 amd kernel: Badness in local_bh_enable at kernel/softirq.c:140 Jan 23 12:59:50 amd kernel: [local_bh_enable+137/144] local_bh_enable+0x89/0x90 Jan 23 12:59:50 amd kernel: [ppp_start_xmit+206/560]

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-17 Thread Marcel Holtmann
Hi Bing, Add a wireless/nl80211_iftype entry in the net device sysfs file structure to indicate the mode of the wireless device so it can be discovered easily from userspace. I do question a little bit the usefulness for this one. It would only work on netdev and on wdev devices. Using

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Marcel Holtmann
Hi Nicolas, Add a wireless/nl80211_iftype entry in the net device sysfs file structure to indicate the mode of the wireless device so it can be discovered easily from userspace. What's wrong with iw dev, i.e. netlink/nl80211? Do NOT screenscrape this tool, we don't consider its output

Re: [PATCH] net-sysfs: Add entry for nl80211 interface type

2013-04-18 Thread Marcel Holtmann
Hi Paul, The original reason to request this change was simple: to figure out what type of interface we are looking at, since now some wireless drivers can simultaneously create managed, p2p and ap interfaces. Knowing that, from a simple front-end (let's even say a shell script) we can

  1   2   3   4   5   6   7   8   9   10   >