Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Fri, Apr 13, 2007 at 10:15:24AM +1000, Nick Piggin wrote: Andrew Morton wrote: On Thu, 12 Apr 2007 16:10:50 -0700 William Lee Irwin III [EMAIL PROTECTED] wrote: + while (count 0) { + chunk = min_t(size_t, count, PAGE_SIZE); + i = 0; + +

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Fri, Apr 13, 2007 at 11:01:41AM +1000, Nick Piggin wrote: Basically: to show what the hell's going on in the VM. kprobes / systemtap isn't good enough? It's not really a good match to the kprobes model. I'm not interested in events, per se. I don't want to need to know about every single

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Fri, Apr 13, 2007 at 11:42:29AM +1000, Nick Piggin wrote: Instead, one says what pages are being used by my application, then, for That includes unmapped pagecache being used by my application, doesn't it? Maybe that's too hard to do via /proc so we forget about it... It'd be really nice

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Thu, Apr 12, 2007 at 06:57:23PM -0700, Andrew Morton wrote: I guess one could generate an answer to the static question with systemtap, by accumulating running counts across the application lifetime and then snapshotting them. Sounds hard though. You'd have to do it from boot onward to get

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-12 Thread Matt Mackall
On Fri, Apr 13, 2007 at 12:21:25PM +1000, Nick Piggin wrote: Matt Mackall wrote: On Fri, Apr 13, 2007 at 11:42:29AM +1000, Nick Piggin wrote: If kprobes is simply crappy and doesn't work properly for this, then I could accept that. I'm not someone trying to get this info. So why can't

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-13 Thread Matt Mackall
On Thu, Apr 12, 2007 at 05:42:01PM -0700, Andrew Morton wrote: On Fri, 13 Apr 2007 10:15:24 +1000 Nick Piggin [EMAIL PROTECTED] wrote: + ((char *)page)[1] = PAGE_SHIFT; OK. Shouldn't we just expose page size and endianness by other means? (another file

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-13 Thread Matt Mackall
On Fri, Apr 13, 2007 at 12:18:56PM +1000, Nick Piggin wrote: Can't you just traverse arbitrary kernel data structures at a given point in time, exactly like the /proc/ call is doing? Perhaps. My understanding is that you hook a kprobe to an event. An event is a particular instruction getting

Re: [PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-13 Thread Matt Mackall
On Fri, Apr 13, 2007 at 10:03:56AM -0700, Andrew Morton wrote: On Fri, 13 Apr 2007 11:24:36 -0500 Matt Mackall [EMAIL PROTECTED] wrote: It *will* be viable. If the application wants to know if a page is dirty, it looks up PG_dirty in /proc/pg_foo-to-bitnumber and uses PG_dirty's

Re: [PATCH UPDATE] deflate stack usage in lib/inflate.c

2007-04-13 Thread Matt Mackall
On Thu, Apr 12, 2007 at 01:50:54PM -0700, Jeremy Fitzhardinge wrote: Subject: deflate stack usage in lib/inflate.c inflate_fixed and huft_build together use around 2.7k of stack. When using 4k stacks, I saw stack overflows from interrupts arriving while unpacking the root initrd: do_IRQ:

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-15 Thread Matt Mackall
On Sun, Apr 15, 2007 at 05:05:36PM +0200, Ingo Molnar wrote: so the rejection was on these grounds, and i still very much stand by that position here and today: i didnt want to see the Linux scheduler landscape balkanized and i saw no technological reasons for the complication that external

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-15 Thread Matt Mackall
On Sun, Apr 15, 2007 at 10:48:24PM +0200, Ingo Molnar wrote: * Matt Mackall [EMAIL PROTECTED] wrote: Look at what happened with I/O scheduling. Opening things up to some new ideas by making it possible to select your I/O scheduler took us from 10 years of stagnation to healthy

Re: [PATCH 1/2] slab: introduce krealloc

2007-02-22 Thread Matt Mackall
non-optimized version for mm/slob.c for compatibility. Cc: Josef Sipek [EMAIL PROTECTED] Cc: Matt Mackall [EMAIL PROTECTED] Cc: Christoph Lameter [EMAIL PROTECTED] Signed-off-by: Pekka Enberg [EMAIL PROTECTED] Acked-by: Matt Mackall [EMAIL PROTECTED] -- Mathematics is the supreme nostalgia

Re: [patch] timer/hrtimer: take per cpu locks in sane order

2007-03-04 Thread Matt Mackall
On Fri, Mar 02, 2007 at 11:47:52PM +0100, Heiko Carstens wrote: /* + * Locks two spinlocks l1 and l2. + * l1_first indicates if spinlock l1 should be taken first. + */ +static inline void double_spin_lock(spinlock_t *l1, spinlock_t *l2, + bool l1_first) +

Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual iwconfig waits for 60s and then reports: Error for wireless request Set Encode (8B2A) : SET failed on device eth1 ; Operation

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: [adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: I don't think they are related actually

Re: [PATCH] [RSDL 5/6] sched: implement rsdl cpu scheduler

2007-03-05 Thread Matt Mackall
On Sun, Mar 04, 2007 at 06:06:22PM +1100, Con Kolivas wrote: + * This is the time all tasks within the same priority round robin. + * Set to a minimum of 6ms. */ +#define RR_INTERVAL ((6 * HZ / 1001) + 1) What happens with small HZ? Like 100? I suppose 10ms is a reasonable number

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 11:02:48PM -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 12:42:29AM -0600, Matt Mackall wrote: On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? - If you are using a distro that was released in 2006 or later, - it should be safe to say N here. + If you are using an OpenSuSE, Gentoo, Ubuntu, or

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For reference, I'm running both the latest releases of both hal (0.5.8.1-6.1) and network-manager (0.6.4-6). And there are people telling

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h ---

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: Wait, have confirmed that if you enable this config option, NetworkManager starts back up again and works properly? Yep, probably should have mentioned that. If so, can you disable the option and strace it to see what program is

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: If so, can you disable the option and strace it to see what program is trying to access what? That will put the HAL/NetworkManager/libsysfs/distro script finger pointing to rest pretty quickly :) Ok, I've got straces of both good and

Re: [SLUB 2/3] Large kmalloc pass through. Removal of large general slabs

2007-03-06 Thread Matt Mackall
On Tue, Mar 06, 2007 at 06:35:16PM -0800, Christoph Lameter wrote: Unlimited kmalloc size and removal of general caches =4. We can directly use the page allocator for all allocations 4K and larger. This means that no general slabs are necessary and the size of the allocation passed to

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: If so, can you disable the option and strace it to see what program is trying to access what? That will put

Re: [SLUB 2/3] Large kmalloc pass through. Removal of large general slabs

2007-03-07 Thread Matt Mackall
On Wed, Mar 07, 2007 at 07:34:38AM -0800, Christoph Lameter wrote: On Wed, 7 Mar 2007, Peter Zijlstra wrote: return -1; } Perhaps so something with PAGE_SIZE here, as you know there are platforms/configs where PAGE_SIZE != 4k :-) Any allocation 2k just uses a regular

Re: [RFC: net-2.6.20 patch] remove unused exports

2007-03-07 Thread Matt Mackall
On Wed, Mar 07, 2007 at 11:40:59PM +0100, Adrian Bunk wrote: This patch removes the following not or no longer used exports: - drivers/char/random.c: secure_tcp_sequence_number This part looks reasonable. Acked-by: Matt Mackall [EMAIL PROTECTED] -- Mathematics is the supreme nostalgia of our

Re: 2.6.21-rc5-mm1

2007-03-29 Thread Matt Mackall
On Thu, Mar 29, 2007 at 08:01:40PM +0200, Mariusz Kozłowski wrote: Hello, I run 2.6.21-rc4-mm1 with no hangs for a week. Then when 2.6.21-rc5-mm1 showed up so I switched to it. Unfortunately today my laptop hunged twice in a similar way as described here:

Re: 2.6.21-rc5-mm1

2007-03-29 Thread Matt Mackall
On Thu, Mar 29, 2007 at 09:02:56PM +0200, Mariusz Kozłowski wrote: This is verified and repeatable _every_ single time I tried. Unfortunately the last thing seen on the screen before system is frozen is 'eth0: link down'. So my guess is that when hunting for hangs I found

Re: 2.6.21-rc5-mm1

2007-03-29 Thread Matt Mackall
On Thu, Mar 29, 2007 at 08:55:25PM +0200, Mariusz Kozłowski wrote: I run 2.6.21-rc4-mm1 with no hangs for a week. Then when 2.6.21-rc5-mm1 showed up so I switched to it. Unfortunately today my laptop hunged twice in a similar way as described here:

Re: [PATCH] Cleanup: i386 separate hardware-defined TSS from Linux additions

2007-03-29 Thread Matt Mackall
On Fri, Mar 30, 2007 at 12:36:35PM +1000, Rusty Russell wrote: On Thu, 2007-03-29 at 13:16 +0200, Andi Kleen wrote: Please clean it up properly with two structs. Not sure about this, now I've done it. Running it here. If you like it, I can do x86-64 as well. == lguest defines its own

Re: [RFC] Reorganizing structs to save space

2007-04-03 Thread Matt Mackall
On Tue, Apr 03, 2007 at 09:28:48AM -0300, Arnaldo Carvalho de Melo wrote: module 16960 16848 112 That's huge. struct module_ref ref[255]; /* 480 16320 */ Huh. That's this: struct module_ref { local_t count; } cacheline_aligned;

[PATCH 0/13] maps: pagemap, kpagemap, and related cleanups

2007-04-03 Thread Matt Mackall
This patch series introduces /proc/pid/pagemap and /proc/kpagemap, which allow detailed run-time examination of process memory usage at a page granularity. The first several patches whip the page-walking code introduced for /proc/pid/smaps and clear_refs into a more generic form, the next couple

[PATCH 1/13] maps: Uninline some functions in the page walker

2007-04-03 Thread Matt Mackall
Uninline some functions in the page walker Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:42.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03-24

[PATCH 4/13] maps: Propagate errors from callback in page walker

2007-04-03 Thread Matt Mackall
Propagate errors from callback in page walker Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:52.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03

[PATCH 5/13] maps: Add callbacks for each level to page walker

2007-04-03 Thread Matt Mackall
. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:58.0 -0500 +++ mm/fs/proc/task_mmu.c 2007-03-24 21:34:07.0 -0500 @@ -280,10 +280,35

[PATCH 13/13] maps: Add /proc/kpagemap interface

2007-04-03 Thread Matt Mackall
Add /proc/kpagemap interface This makes physical page flags and counts available to userspace. Together with /proc/pid/pagemap and /proc/pid/clear_refs, this can be used to measure memory usage on a per-page basis. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/proc_misc.c

[PATCH 12/13] maps: Add /proc/pid/pagemap interface

2007-04-03 Thread Matt Mackall
Add /proc/pid/pagemap interface This interface provides a mapping for each page in an address space to its physical page frame number, allowing precise determination of what pages are mapped and what pages are shared between processes. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs

[PATCH 2/13] maps: Eliminate the pmd_walker struct in the page walker

2007-04-03 Thread Matt Mackall
Eliminate the pmd_walker struct in the page walker This slightly simplifies things for the next few cleanups. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24

[PATCH 11/13] maps: Make /proc/pid/clear_refs option under CONFIG_EMBEDDED

2007-04-03 Thread Matt Mackall
Make /proc/pid/clear_refs option under CONFIG_EMBEDDED This interface is primarily useful for doing memory profiling and not much use on deployed embedded boxes. Make it optional. Together with /proc/pid/smaps, this save a few K. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc

[PATCH 3/13] maps: Remove vma from args in the page walker

2007-04-03 Thread Matt Mackall
Remove vma from args in the page walker This makes the walker more generic. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-24 21:33:50.0 -0500 +++ mm

[PATCH 10/13] maps: Make /proc/pid/smaps optional under CONFIG_EMBEDDED

2007-04-03 Thread Matt Mackall
Make /proc/pid/smaps optional under CONFIG_EMBEDDED This interface is primarily useful for doing memory profiling and not much use on deployed embedded boxes. Make it optional. Together with /proc/pid/clear_refs, this save a few K. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc

[PATCH 8/13] maps: Move clear_refs code to task_mmu.c

2007-04-03 Thread Matt Mackall
Move clear_refs code to task_mmu.c This puts all the clear_refs code where it belongs and probably lets things compile on MMU-less systems as well. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/base.c

[PATCH 9/13] maps: Regroup task_mmu by interface

2007-04-03 Thread Matt Mackall
Regroup task_mmu by interface Reorder source so that all the code and data for each interface is together. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-28 00

[PATCH 7/13] maps: Simplify interdependence of /proc/pid/maps and smaps

2007-04-03 Thread Matt Mackall
Simplify interdependence of /proc/pid/maps and smaps This pulls the shared map display code out of show_map and puts it in show_smap where it belongs. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c

[PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Matt Mackall
Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. Signed-off-by: Matt Mackall [EMAIL PROTECTED] Index: mm/fs/proc/task_mmu.c === --- mm.orig/fs/proc/task_mmu.c 2007-03-27 22

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-03 Thread Matt Mackall
On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. I think it would be better in mm/. I originally was looking at putting it in mm/memory.c

Re: [PATCH 12/13] maps: Add /proc/pid/pagemap interface

2007-04-04 Thread Matt Mackall
On Wed, Apr 04, 2007 at 03:18:41PM +0400, Nikita Danilov wrote: This pushes binary data to the user space. Wasn't /proc supposed to be ascii-based to avoid compatibility problems (e.g., size of unsigned long changing, endianness, etc.)? Most of what's in /proc is ASCII, true. But there are

Re: [PATCH 6/13] maps: Move the page walker code to lib/

2007-04-04 Thread Matt Mackall
On Wed, Apr 04, 2007 at 03:50:56PM +1000, Nick Piggin wrote: Matt Mackall wrote: On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote: Matt Mackall wrote: Move the page walker code to lib/ This lets it get shared outside of proc/ and linked in only when needed. I think

Re: [PATCH 12/13] maps: Add /proc/pid/pagemap interface

2007-04-04 Thread Matt Mackall
On Wed, Apr 04, 2007 at 10:03:04PM +0400, Nikita Danilov wrote: Matt Mackall writes: [...] Now I could adjust these to only export u64s in some preferred endianness. But given I already need details like the page size to make any sense of it, it seems unnecessary. Also, the PFNs

Re: [patch 20/20] Add apply_to_page_range() which applies a function to a pte range.

2007-04-04 Thread Matt Mackall
On Wed, Apr 04, 2007 at 12:12:11PM -0700, Jeremy Fitzhardinge wrote: Add a new mm function apply_to_page_range() which applies a given function to every pte in a given virtual address range in a given mm structure. This is a generic alternative to cut-and-pasting the Linux idiomatic pagetable

Re: [PATCH] procfs: provide slub's /proc/slabinfo

2008-01-07 Thread Matt Mackall
On Mon, 2008-01-07 at 20:06 +0200, Pekka J Enberg wrote: Hi Matt, On Sun, 6 Jan 2008, Matt Mackall wrote: I don't have any particular terrible workloads for SLUB. But my attempts to simply boot with all three allocators to init=/bin/bash in, say, lguest show a fair margin for SLOB

Re: [PATCH] i386 : Make arch/x86/kernel/acpi/wakeup_32.S use a separate text section

2008-01-08 Thread Matt Mackall
On Sat, 2008-01-05 at 16:11 +0100, Ingo Molnar wrote: * Eric Dumazet [EMAIL PROTECTED] wrote: # size vmlinux.before vmlinux.after textdata bss dec hex filename 4619942 422838 458752 5501532 53f25c vmlinux.before 4610534 422838 458752 5492124 53cd9c

[RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-09 Thread Matt Mackall
On Mon, 2008-01-07 at 20:06 +0200, Pekka J Enberg wrote: Hi Matt, On Sun, 6 Jan 2008, Matt Mackall wrote: I don't have any particular terrible workloads for SLUB. But my attempts to simply boot with all three allocators to init=/bin/bash in, say, lguest show a fair margin for SLOB

Re: [JANITOR PROPOSAL] Switch ioctl functions to -unlocked_ioctl

2008-01-09 Thread Matt Mackall
On Tue, 2008-01-08 at 20:58 +0100, Paolo Ciarrocchi wrote: On Jan 8, 2008 5:40 PM, Andi Kleen [EMAIL PROTECTED] wrote: So I cooked up the following patch (probably mangled, just to give you a rough idea of what I did): diff --git a/arch/arm/common/rtctime.c b/arch/arm/common/rtctime.c index

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-09 Thread Matt Mackall
On Thu, 2008-01-10 at 00:43 +0200, Pekka J Enberg wrote: Hi Matt, On Wed, 9 Jan 2008, Matt Mackall wrote: I kicked this around for a while, slept on it, and then came up with this little hack first thing this morning: slob: split free list by size [snip

Re: Replacement for page fault notifiers?

2008-01-09 Thread Matt Mackall
On Wed, 2008-01-09 at 16:42 -0800, Arjan van de Ven wrote: On Wed, 9 Jan 2008 20:22:54 + Christoph Hellwig [EMAIL PROTECTED] wrote: On Thu, Jan 10, 2008 at 06:58:23AM +1100, Benjamin Herrenschmidt wrote: It's a sane thing to do, Christoph, I don't think it's a unreasonable

Re: Replacement for page fault notifiers?

2008-01-09 Thread Matt Mackall
On Wed, 2008-01-09 at 21:21 -0500, Pavel Roskin wrote: On Wed, 2008-01-09 at 20:03 -0600, Matt Mackall wrote: That makes it way too easy for drivers of questionable legality to just clear that bit. Also, we've got a shortage of page bits, etc. If we ever have this problem, the bit can

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-09 Thread Matt Mackall
On Thu, 2008-01-10 at 00:43 +0200, Pekka J Enberg wrote: Hi Matt, On Wed, 9 Jan 2008, Matt Mackall wrote: I kicked this around for a while, slept on it, and then came up with this little hack first thing this morning: slob: split free list by size [snip

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Matt Mackall
On Thu, 2008-01-10 at 12:54 +0200, Pekka J Enberg wrote: Hi Matt, On Thu, 10 Jan 2008, Pekka J Enberg wrote: I'll double check the results for SLUB next but it seems obvious that your patches are a net gain for SLOB and should be applied. One problem though with SLOB seems to be that

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Matt Mackall
On Thu, 2008-01-10 at 08:13 -0800, Linus Torvalds wrote: On Thu, 10 Jan 2008, Pekka J Enberg wrote: We probably don't have the same version of GCC which perhaps affects memory layout (struct sizes) and thus allocation patterns? No, struct sizes will not change with compiler versions

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Matt Mackall
On Thu, 2008-01-10 at 10:28 -0800, Linus Torvalds wrote: On Thu, 10 Jan 2008, Matt Mackall wrote: (I'm not a fan of slabs per se - I think all the constructor/destructor crap is just that: total crap - but the size/type binning is a big deal, and I think SLOB was naïve to think

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-10 Thread Matt Mackall
On Thu, 2008-01-10 at 11:16 -0800, Christoph Lameter wrote: On Thu, 10 Jan 2008, Matt Mackall wrote: Here I'm going to differ with you. The premises of the SLAB concept (from the original paper) are: a) fragmentation of conventional allocators gets worse over time Even

Re: [PATCH] Random number driver: make random_ioctl as an unlocked_ioctl function

2008-01-11 Thread Matt Mackall
On Fri, 2008-01-11 at 17:09 +0530, Nikanth Karthikesan wrote: The random_ioctl is registered as an ioctl function but it does not require BKL to be held when called. Changing it as an unlocked_ioctl function. Signed-off-by: Nikanth Karthikesan [EMAIL PROTECTED] Looks good, but I've already

Re: [PATCH -mm] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 10:15:37AM -0700, Randy Dunlap wrote: On Wed, 12 Sep 2007 11:31:22 +0200 Jiri Slaby wrote: randconfig [1] causes this link errors: ERROR: netpoll_cleanup [drivers/net/kgdboe.ko] undefined! ERROR: netpoll_setup [drivers/net/kgdboe.ko] undefined! ERROR:

Re: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Matt Mackall
On Wed, Sep 12, 2007 at 11:22:52AM -0700, Randy Dunlap wrote: On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote: NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my kconfig-addled brain. Correct. Patch corrected. Thanks. Looks good to me, but I'll leave the actual ack

Re: 2.6.24-rc2 slab vs slob tbench numbers

2007-11-12 Thread Matt Mackall
On Fri, Nov 09, 2007 at 11:36:56PM +1100, Nick Piggin wrote: Hi, Just ran some tbench numbers (from dbench-3.04), on a 2 socket, 8 core x86 system, with 1 NUMA node per socket. With kernel 2.6.24-rc2, comparing slab vs slub allocators. Damn your misleading subject! I thought this was going

Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

2007-11-13 Thread Matt Mackall
On Tue, Nov 13, 2007 at 01:46:46PM +0100, Peter Zijlstra wrote: On Tue, 2007-11-13 at 03:18 -0800, Andrew Morton wrote: On Tue, 13 Nov 2007 10:57:31 + David Howells [EMAIL PROTECTED] wrote: SL Baur [EMAIL PROTECTED] wrote: Please take the emacsism out of the file as it

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 12:20:01PM +0100, Ingo Molnar wrote: there's a new SLOB regression - the attached config crashes with: [ 61.245190] rc.sysinit used greatest stack depth: 1680 bytes left [ 61.386859] list_add corruption. prev-next should be next (407d973c), but was 418cf818.

Re: [PATCH] x86: fix locking and sync bugs in x86_64 RTC code in time_64.c

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 08:10:22AM -0500, David P. Reed wrote: Will make two patches and resend. I've already got a set of patches brewing to fix the UIP problem across all the affected arches (11+). -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 11:36:11AM -0600, Matt Mackall wrote: On Wed, Nov 14, 2007 at 12:20:01PM +0100, Ingo Molnar wrote: there's a new SLOB regression - the attached config crashes with: [ 61.245190] rc.sysinit used greatest stack depth: 1680 bytes left [ 61.386859] list_add

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 08:05:01PM +0100, Ingo Molnar wrote: * Matt Mackall [EMAIL PROTECTED] wrote: [ 61.245190] rc.sysinit used greatest stack depth: 1680 bytes left [ 61.386859] list_add corruption. prev-next should be next (407d973c), but was 418cf818. (prev=41877098

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 03:10:13PM -0800, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 16:53:36 -0600 He hit the bug using SLOB and there are no kmem (or any other) caches in SLOB. That's unfortunate, is there any user tracking facility at all

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 02:39:38PM -0800, David Miller wrote: From: Ingo Molnar [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 20:05:01 +0100 the bug went away - and the only thing i did was a networking config tweak. So maybe something in networking corrupts memory? This wouldn't surprise

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-14 Thread Matt Mackall
On Wed, Nov 14, 2007 at 03:41:43PM -0800, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to switch to another allocator with more extensive debugging facilities. Ok, so

Re: [patch] slob: fix memory corruption

2007-11-15 Thread Matt Mackall
the following crash: http://bugzilla.kernel.org/show_bug.cgi?id=9379 Signed-off-by: Nick Piggin [EMAIL PROTECTED] Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Signed-off-by: Matt Mackall [EMAIL PROTECTED] Andrew, please cue this for 2.6.24 and -stable. --- mm/slob.c |3 ++- 1 file

Re: [PATCH] Clustering indirect blocks in Ext3

2007-11-15 Thread Matt Mackall
On Thu, Nov 15, 2007 at 11:02:19PM -0800, Andrew Morton wrote: On Thu, 15 Nov 2007 21:02:46 -0800 Abhishek Rai [EMAIL PROTECTED] wrote: ... 3. e2fsck speedup with metaclustering varies from disk to disk with most benefit coming from disks which have a large number of indirect blocks. For

Re: Linux 2.6.23.2

2007-11-16 Thread Matt Mackall
On Fri, Nov 16, 2007 at 09:39:58PM +0200, Matti Aarnio wrote: On Fri, Nov 16, 2007 at 02:35:29PM -0500, Mark Lord wrote: Greg Kroah-Hartman wrote: We (the -stable team) are announcing the release of the 2.6.23.2 kernel. It contains a number of bugfixes for the core kernel code. I'll also

Re: [PATCH] Clustering indirect blocks in Ext3

2007-11-18 Thread Matt Mackall
On Sun, Nov 18, 2007 at 07:52:36AM -0800, Abhishek Rai wrote: Thanks for the suggestion Matt. It took me some time to get compilebench working due to the known issue with drop_caches due to circular lock dependency between j_list_lock and inode_lock (compilebench triggers drop_caches quite

Re: [RANDOM] Move two variables to read_mostly section to save memory

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 07:38:14PM +0100, Eric Dumazet wrote: Adrian Bunk a ??crit : On Sun, Dec 16, 2007 at 06:42:57PM +0100, Eric Dumazet wrote: Adrian Bunk a ??crit : ... And even more funny, with gcc 4.2 and CONFIG_CC_OPTIMIZE_FOR_SIZE=y your patch doesn't seem to make any space

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 08:10:10PM +0100, Mariusz Kozlowski wrote: Can you change line 710 of fs/proc/proc_misc.c to: ppage = NULL; Sure. ..and see if it still breaks? Yes it does - the same way as eariler. Box is locked, processes stuck in D state and after a

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-17 Thread Matt Mackall
On Sun, Dec 16, 2007 at 10:39:17PM -0800, Andrew Morton wrote: On Sun, 16 Dec 2007 20:26:11 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Sun, 16 Dec 2007 20:11:49 -0600 But as the function doesn't actually show up in your stack trace

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-17 Thread Matt Mackall
On Mon, Dec 17, 2007 at 11:24:57AM -0800, Randy Dunlap wrote: On Sun, 16 Dec 2007 21:55:20 + Mel Gorman wrote: Just using cp to read the file is enough to cause problems but I included a very basic program below that produces the BUG_ON checks. Is this a known issue or

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
On Mon, Dec 17, 2007 at 01:36:31PM -0800, Arjan van de Ven wrote: On Mon, 17 Dec 2007 18:23:31 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: * Arjan van de Ven [EMAIL PROTECTED] wrote: The http://www.kerneloops.org website collects kernel oops and warning reports from various

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
; just universally unique. Code on the other hand should be readable. :-) Linus' suggested... improvement should either be done in all 3 places or none ;) Since you're the maintainer... what's your suggestion? For the record: RANDOM NUMBER DRIVER P: Matt Mackall M: [EMAIL PROTECTED

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
On Tue, Dec 18, 2007 at 10:06:14AM -0800, Arjan van de Ven wrote: Linus Torvalds wrote: On Mon, 17 Dec 2007, Arjan van de Ven wrote: +char *get_boot_uuid(void) +{ + static char target[38]; + unsigned char *uuid; + + if (sysctl_bootid[8] == 0) +

Re: [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h

2007-12-18 Thread Matt Mackall
On Tue, Dec 18, 2007 at 10:25:50PM +0100, Eric Dumazet wrote: Some 'extern struct seq_operations' are wrongly defined in fs/proc/proc_misc.c (they miss a const qualifier) In order to fix this correctly, move the extern ... declaration from .c file to an appropriate include file, as

Re: a problem with NETPOLL/KGDBoE

2007-12-19 Thread Matt Mackall
On Wed, Dec 19, 2007 at 06:22:55PM +0200, Ramagudi Naziir wrote: On 12/6/07, Matt Mackall [EMAIL PROTECTED] wrote: netpoll will ignore incoming UDP -from- the wrong port/ip/mac, since it's otherwise bypassing the firewall layer. ... I forget how to deal with the source address issue

Re: [rfc][patch] mm: madvise(WILLNEED) for anonymous memory

2007-12-20 Thread Matt Mackall
On Thu, Dec 20, 2007 at 05:53:41PM +0100, Peter Zijlstra wrote: On Thu, 2007-12-20 at 15:26 +, Hugh Dickins wrote: The asynch code: perhaps not worth doing for MADV_WILLNEED alone, but might prove useful for more general use when swapping in. Not really the same as Con's swap

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-20 Thread Matt Mackall
On Thu, Dec 20, 2007 at 04:53:59AM -0800, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Mon, 17 Dec 2007 08:55:54 -0600 On Sun, Dec 16, 2007 at 10:39:17PM -0800, Andrew Morton wrote: Actually, you may only need these two: maps4-add-proc-kpagecount-interface.patch

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-20 Thread Matt Mackall
On Thu, Dec 20, 2007 at 04:17:26PM -0800, David Miller wrote: From: Mariusz Kozlowski [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 20:47:55 +0100 [ 145.128915] TSTATE: 004411009603 TPC: 005119ac TNPC: 005119b0 Y: Not tainted [ 145.128940] TPC:

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-21 Thread Matt Mackall
On Sat, 2007-12-22 at 01:28 +0100, Andi Kleen wrote: Ingo Molnar [EMAIL PROTECTED] writes: Christoph, /proc/slabinfo is an _ABI_. You HAVE to provide it. slabtop relies on it, people use it every day to monitor memory consumption. It's definitely not a stable ABI. slabtop tends to exit

ACPI or radeon: spontaneous reboot regression

2007-12-22 Thread Matt Mackall
With 2.6.24-rc2, plugging and unplugging power results in a sudden reboot. After the reboot, the machine boots normally until it switches to graphics mode, at which point the screen is scrambled. It may hang or repeatedly reboot at this point. Easily repeatable after just a few plug cycles.

Re: [bug] SLOB, tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52 kmap_atomic_prot()

2007-11-29 Thread Matt Mackall
On Thu, Nov 29, 2007 at 03:39:20PM +0100, Ingo Molnar wrote: * Ingo Molnar [EMAIL PROTECTED] wrote: i'm getting this on 32-bit (with the kmap-atomic debugging patch applied): Calling initcall 0x78b67c00: tipc_init+0x0/0xc0() TIPC: Activated (version 1.6.2

Re: [bug] SLOB, tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52 kmap_atomic_prot()

2007-11-30 Thread Matt Mackall
On Fri, Nov 30, 2007 at 10:14:18AM +0100, Ingo Molnar wrote: * Matt Mackall [EMAIL PROTECTED] wrote: plus, and this is a slob question i guess, how come we drop into clear_highpage() for a kzalloc()?? Good question. Looks like kzalloc switched from doing a memset to passing

Re: [1/4] dst: Distributed storage documentation.

2007-12-02 Thread Matt Mackall
On Thu, Nov 29, 2007 at 03:53:23PM +0300, Evgeniy Polyakov wrote: Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Can you give us a summary of how this differs from using

Re: drivers/char/random.c:write_pool() -- cond_resched needed?

2007-12-03 Thread Matt Mackall
latency for large writes to /dev/[u]random Signed-off-by: Matt Mackall [EMAIL PROTECTED] diff -r c60016ba6237 drivers/char/random.c --- a/drivers/char/random.c Tue Nov 13 09:09:36 2007 -0800 +++ b/drivers/char/random.c Mon Dec 03 12:48:30 2007 -0600 @@ -1041,6 +1041,7 @@ write_pool(struct

Re: [PATCH] Add EXPORT_SYMBOL(ksize);

2007-12-03 Thread Matt Mackall
On Mon, Dec 03, 2007 at 04:07:33PM +0200, Pekka Enberg wrote: Hi, On Mon, Dec 03, 2007 at 08:41:44PM +0900, Tetsuo Handa wrote: We couldn't know how much memory was allocated by kmalloc() in 2.4 era, and we can know it 2.6 era. But are we going back to 2.4 era for out-of-tree kernel

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-04 Thread Matt Mackall
On Tue, Dec 04, 2007 at 08:54:52AM -0800, Ray Lee wrote: (Why hasn't anyone been cc:ing Matt on this?) On Dec 4, 2007 8:18 AM, Adrian Bunk [EMAIL PROTECTED] wrote: On Tue, Dec 04, 2007 at 12:41:25PM +0100, Marc Haber wrote: While debugging Exim4's GnuTLS interface, I recently found out

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-04 Thread Matt Mackall
On Tue, Dec 04, 2007 at 04:55:02PM +, Alan Cox wrote: cryptographically strong stream it'll provide when /dev/random is tapped? In principle, this'd leave more entropy available for applications that really need it, especially on platforms that don't generate a lot of entropy in the

<    1   2   3   4   5   6   7   8   9   10   >