Re: [PATCH 2/9]: Reduce Log I/O latency

2007-11-22 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:09:22AM +1100, David Chinner wrote: > On Fri, Nov 23, 2007 at 09:29:09AM +1100, David Chinner wrote: > > On Thu, Nov 22, 2007 at 12:10:29PM -0600, Matt Mackall wrote: > > > If I've got XFS on filesystems A and B on the same spindle (or volume >

Re: [PATCH 2/9]: Reduce Log I/O latency

2007-11-22 Thread Matt Mackall
On Fri, Nov 23, 2007 at 09:29:09AM +1100, David Chinner wrote: > On Thu, Nov 22, 2007 at 12:10:29PM -0600, Matt Mackall wrote: > > On Thu, Nov 22, 2007 at 09:31:59PM +1100, David Chinner wrote: > > [...] > > > > In other words, I/O priority is per-spindle and not per-

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:15:24PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > So I'd be surprised if that was a problem. But I can imagine having > > problems for skbs without destructors which r

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:54:11PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, the

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:32:22PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evg

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 12:21:57AM -0800,

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > > > kernel/softirq.c:139 local_bh_enable() > > > [2059664.620535] [<8

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > Stop, we are trying to free skb without d

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-24 Thread Matt Mackall
Simon, can you test this patch? I think it's the most straightforward 2.6.24 fix. diff -r c60016ba6237 net/core/netpoll.c --- a/net/core/netpoll.cTue Nov 13 09:09:36 2007 -0800 +++ b/net/core/netpoll.cFri Nov 23 13:10:28 2007 -0600 @@ -203,6 +203,12 @@ static void refill_skbs(void)

Re: [PATCH 2/9]: Reduce Log I/O latency

2007-11-24 Thread Matt Mackall
On Fri, Nov 23, 2007 at 01:01:15PM +0100, Andi Kleen wrote: > On Fri, Nov 23, 2007 at 03:03:29PM +1100, David Chinner wrote: > > On Fri, Nov 23, 2007 at 03:53:17AM +0100, Andi Kleen wrote: > > > On Fri, Nov 23, 2007 at 12:15:39AM +1100, David Chinner wrote: > > > > On Thu, Nov 22, 2007 at 01:06:11P

Re: [PATCH] Random number driver: make random_ioctl as an unlocked_ioctl function

2008-01-11 Thread Matt Mackall
On Fri, 2008-01-11 at 17:09 +0530, Nikanth Karthikesan wrote: > The random_ioctl is registered as an ioctl function but it does not > require BKL to be held when called. Changing it as an unlocked_ioctl > function. > > Signed-off-by: Nikanth Karthikesan <[EMAIL PROTECTED]> Looks good, but I've a

Re: [PATCH 0/7] Create and populate toplevel tests/ directory

2008-01-15 Thread Matt Mackall
On Thu, 2008-01-10 at 17:24 +0530, Ananth N Mavinakayanahalli wrote: > The following series of patches create and populate the toplevel tests/ > directory. This will henceforth be the place where all in-kernel tests > live. > > All patches against 2.6.24-rc6-mm1 There's a small test I stuck at t

Re: [PATCH 1/2] Massive code cleanup of sys_msync()

2008-01-15 Thread Matt Mackall
On Tue, 2008-01-15 at 11:10 -0800, Randy Dunlap wrote: > On Tue, 15 Jan 2008 22:02:54 +0300 Anton Salikhmetov wrote: > > > 2008/1/15, Christoph Hellwig <[EMAIL PROTECTED]>: > > > On Tue, Jan 15, 2008 at 07:02:44PM +0300, Anton Salikhmetov wrote: > > > > > @@ -33,71 +34,65 @@ asmlinkage long sys_

Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 16:43 +0100, Michael Opdenacker wrote: > [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling > > Applies to 2.6.24-rc8-git1 > > This patch results from Linux Tiny's efforts to hunt for unnecessary > code added unconditionally with "obj-y +=" > > This patch

Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 18:05 +0100, Michael Opdenacker wrote: > Hi Matt, > > Thanks for your feedback! > > On 01/17/2008 05:36 PM, Matt Mackall wrote: > > On Thu, 2008-01-17 at 16:43 +0100, Michael Opdenacker wrote: > > > >> diff -Naur linux-2.6.24-

[PATCH 1 of 3] slob: fix free block merging at head of subpage

2008-01-17 Thread Matt Mackall
We weren't merging freed blocks at the beginning of the free list. Fixing this showed a 2.5% efficiency improvement in a userspace test harness. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 408d4beddb6c -r 771a5ab2c6b7 mm/slob.c --- a/mm/slob.c Wed Jan 16 19:00:27 2008 +00

[PATCH 0 of 3] SLOB patches for 2.6.25

2008-01-17 Thread Matt Mackall
Here are some SLOB fragmentation reduction patches for 2.6.25, please apply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www

[PATCH 3 of 3] slob: correct Kconfig description

2008-01-17 Thread Matt Mackall
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r eff994add207 -r db1f4e74c5ab init/Kconfig --- a/init/Kconfig Wed Jan 16 18:14:29 2008 -0600 +++ b/init/Kconfig Wed Jan 16 18:14:29 2008 -0600 @@ -648,11 +648,9 @@ depends on EMBEDDED bool "SLOB (Simpl

[PATCH 2 of 3] slob: reduce external fragmentation by using three free lists

2008-01-17 Thread Matt Mackall
By putting smaller objects on their own list, we greatly reduce overall external fragmentation and increase repeatability. This reduces total SLOB overhead from > 50% to ~6% on a simple boot test. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 771a5ab2c6b7 -r eff994add207

Re: 2.6.24-rc8-mm1

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 02:35 -0800, Andrew Morton wrote: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ Hmm. On my Thinkpad R51, this gives me: Uncompressing linux... Ok, booting kernel. ..and nothing more with the attached .config. -- Mathematics is

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 14:51 -0800, Andrew Morton wrote: > > proc_loop: /proc/3731/task/3731/pagemap > > kernel: BUG: sleeping function called from invalid context at > > fs/proc/task_mmu.c:554 > > kernel: in_atomic():1, irqs_disabled():0 > > kernel: Call Trace: > > kernel: [cf1cddf0] [c000840c] s

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 16:29 -0800, Andrew Morton wrote: > Do we need `offset' at all? Looks like no. I wonder if there's a good argument for adding a pte_offset_val() which would let us do: pteval = pte_offset_val(pmd, addr); and shrink the map/unmap window and overhead here and possibly elsew

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 16:05 -0800, Andrew Morton wrote: > On Thu, 17 Jan 2008 17:39:54 -0600 > Matt Mackall <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 2008-01-17 at 14:51 -0800, Andrew Morton wrote: > > > > proc_loop: /proc/3731/task/3731/pagemap > &

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 17:07 -0800, Andrew Morton wrote: > That worked out nicely. Cool, feel free to add: Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> > Wasn't the old code potentially pte_unmap()ping the wrong address? If we > enter with addr==end? Yes, that was bust

Re: 2.6.24-rc8-mm1

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 15:10 -0600, Matt Mackall wrote: > On Thu, 2008-01-17 at 02:35 -0800, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > > Hmm. On my Thinkpad R51, this gives me: > > Uncompressing linux.

[PATCH 00 of 12] random cleanups for 2.6.25

2008-01-17 Thread Matt Mackall
This is a collection of drivers/char/random.c cleanups and fixes for 2.6.25. Please apply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH 01 of 12] random: clean up checkpatch complaints

2008-01-17 Thread Matt Mackall
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 5595adaea70f -r 905475c480bd drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 13:26:54 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 @@ -272,7 +272,7 @@ static int trickle_thresh __read_

[PATCH 02 of 12] random: consolidate wakeup logic

2008-01-17 Thread Matt Mackall
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 905475c480bd -r f814137b0bfc drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 @@ -540,6 +540,10 @@ nb

[PATCH 04 of 12] random: reuse rand_initialize

2008-01-17 Thread Matt Mackall
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 6f8bed9c59f7 -r 3e0b0226df90 drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 @@ -900,7 +900,7 @@ sizeof(*(u

[PATCH 05 of 12] random: improve variable naming, clear extract buffer

2008-01-17 Thread Matt Mackall
- split the SHA variables apart into hash and workspace - rename data to extract - wipe extract and workspace after hashing Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 3e0b0226df90 -r 42aa9f950f97 drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:23 2008

[PATCH 06 of 12] random: make backtracking attacks harder

2008-01-17 Thread Matt Mackall
, hash the entire pool in one go, then feedback the whole hash (160 bits) in one go. This will make backtracking at least as hard as inverting the hash. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 42aa9f950f97 -r 9569d3011032 drivers/char/random.c --- a/drivers/char/random.c T

[PATCH 07 of 12] random: remove cacheline alignment for locks

2008-01-17 Thread Matt Mackall
Earlier changes greatly reduce the number of times we grab the lock per output byte, so we shouldn't need this particular hack any more. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 9569d3011032 -r 70f981257057 drivers/char/random.c --- a/drivers/char/random.c Thu Jan

[PATCH 08 of 12] random: eliminate redundant new_rotate variable

2008-01-17 Thread Matt Mackall
- eliminate new_rotate - move input_rotate masking - simplify input_rotate update - move input_rotate update to end of inner loop for readability Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r 70f981257057 -r f06a2e1b4d58 drivers/char/random.c --- a/drivers/char/random.c Thu

[PATCH 09 of 12] random: remove some prefetch logic

2008-01-17 Thread Matt Mackall
!) Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r f06a2e1b4d58 -r bc31fa097d34 drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 @@ -457,7 +457,7 @@ unsigned long i, add_ptr, tap1

[PATCH 03 of 12] random: use unlocked_ioctl

2008-01-17 Thread Matt Mackall
No locking actually needed. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r f814137b0bfc -r 6f8bed9c59f7 drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:23 2008 -0600 @@ -1063,8 +

[PATCH 10 of 12] random: simplify add_ptr logic

2008-01-17 Thread Matt Mackall
The add_ptr variable wasn't used in a sensible way, use only i instead. i got reused later for a different purpose, use j instead. While we're here, put tap0 first in the tap list and add a comment. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> diff -r bc31fa097d34 -r 8f28

[PATCH 11 of 12] random: make mixing interface byte-oriented

2008-01-17 Thread Matt Mackall
Switch add_entropy_words to a byte-oriented interface, eliminating numerous casts and byte/word size rounding issues. This also reduces the overall bit/byte/word confusion in this code. We now mix a byte at a time into the word-based pool. This takes four times as many iterations, but should be ne

[PATCH 12 of 12] random: simplify and rename credit_entropy_store

2008-01-17 Thread Matt Mackall
- emphasize bits in the name - make zero bits lock-free - simplify logic diff -r a0689714301a -r 218e9dac90b1 drivers/char/random.c --- a/drivers/char/random.c Thu Jan 17 20:25:24 2008 -0600 +++ b/drivers/char/random.c Thu Jan 17 20:25:24 2008 -0600 @@ -441,7 +441,7 @@ /* * This functio

Re: [PATCH] ramdisk driver: make rd_size non-static

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 18:28 -0800, Andrew Morton wrote: > On Fri, 18 Jan 2008 02:02:17 + Byron Bradley <[EMAIL PROTECTED]> wrote: > > > In arch/arm/kernel/setup.c:setup_ramdisk(), rd_size is set from the > > boot tags. The replacement ramdisk driver has rd_size as static > > which causes link

Re: RFC: remove __read_mostly

2007-12-14 Thread Matt Mackall
On Thu, Dec 13, 2007 at 11:20:44PM +0100, Adrian Bunk wrote: > I tried the following patch with a full x86 .config [1]: > > --- a/include/asm-x86/cache.h > +++ b/include/asm-x86/cache.h > -#define __read_mostly __attribute__((__section__(".data.read_mostly"))) > +/* #define __read_mostly __attribu

Re: Print taint info in more places.

2007-12-14 Thread Matt Mackall
On Thu, Dec 13, 2007 at 08:30:41PM -0500, Dave Jones wrote: > #ifndef HAVE_ARCH_BUG > #define BUG() do { \ > - printk("BUG: failure at %s:%d/%s()!\n", __FILE__, __LINE__, > __FUNCTION__); \ > + printk(KERN_ERR "BUG: failure at %s:%d/%s()! (%s)\n", > + __FILE__, __LINE__, __FU

Re: RFC: remove __read_mostly

2007-12-14 Thread Matt Mackall
On Fri, Dec 14, 2007 at 04:38:04PM +0100, Eric Dumazet wrote: > Matt Mackall a ?crit : > >On Thu, Dec 13, 2007 at 11:20:44PM +0100, Adrian Bunk wrote: > > > >>I tried the following patch with a full x86 .config [1]: > >> > >>--- a/include/asm-x86

Re: [PATCH] printk_ratelimit functions should use CONFIG_PRINTK

2007-12-14 Thread Matt Mackall
On Fri, Dec 14, 2007 at 11:00:35AM -0800, Joe Perches wrote: > Makes an embedded image a bit smaller Looks good to me. This should probably go to Andrew first though. And it wouldn't hurt to see some size(1) results. Acked-by: Matt Mackall <[EMAIL PROTECTED]> > > Signed

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

2007-12-14 Thread Matt Mackall
On Fri, Dec 14, 2007 at 09:27:55PM +0800, Herbert Xu wrote: > Hi: > > [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off > > The description of CONFIG_BUG clearly states that both BUG and > WARN_ON may be skipped. However, our actual implementation still > checks the condition on WA

Re: /dev/urandom uses uninit bytes, leaks user data

2007-12-14 Thread Matt Mackall
On Fri, Dec 14, 2007 at 11:34:09AM -0800, John Reiser wrote: > xfer_secondary_pool() in drivers/char/random.c tells add_entropy_words() > to use uninitialized tmp[] whenever bytes is not a multiple of 4. > Besides being unfriendly to automated dynamic checkers, this is a > potential leak of user da

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

2007-12-14 Thread Matt Mackall
On Sat, Dec 15, 2007 at 12:16:59PM +0800, Herbert Xu wrote: > On Fri, Dec 14, 2007 at 12:02:46PM -0600, Matt Mackall wrote: > > > > I added CONFIG_BUG, and I think the current behavior is correct. As > > you've noticed, we have to evaluate condition, it may have > >

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-14 Thread Matt Mackall
On Fri, Dec 14, 2007 at 06:02:06PM -0800, Andrew Morton wrote: > On Sat, 15 Dec 2007 01:09:41 + Mel Gorman <[EMAIL PROTECTED]> wrote: > > > On (13/12/07 14:29), Andrew Morton didst pronounce: > > > > The simple way seems to be to malloc a large area, touch every page and > > > > then look at t

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

2007-12-14 Thread Matt Mackall
On Sat, Dec 15, 2007 at 02:04:49PM +0800, Herbert Xu wrote: > On Fri, Dec 14, 2007 at 11:52:18PM -0600, Matt Mackall wrote: > > > > No. The code as written above should reduce to: > > > > if (val == NULL) > > return -EFAULT; > > > >

Re: /dev/urandom uses uninit bytes, leaks user data

2007-12-15 Thread Matt Mackall
On Sat, Dec 15, 2007 at 03:13:19PM +0800, Herbert Xu wrote: > John Reiser <[EMAIL PROTECTED]> wrote: > > > > If speed matters that much, then please recoup 33 cycles on x86 > > by using shifts instead of three divides, such as (gcc 4.1.2): > > > >add_entropy_words(r, tmp, (bytes +

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

2007-12-15 Thread Matt Mackall
and add a new primitive. > > [PATCH] Added BARF_ON/BARF_ON_ONCE > > The description of CONFIG_BUG clearly states that both BUG and > WARN_ON may be skipped. However, our actual implementation still > checks the condition on WARN_ON if it's used as part of an if > stat

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

2007-12-15 Thread Matt Mackall
On Sat, Dec 15, 2007 at 02:34:42PM +0800, Herbert Xu wrote: > On Sat, Dec 15, 2007 at 05:31:30PM +1100, Benjamin Herrenschmidt wrote: > > > > That's something I've actually never quite liked... the fact that we > > evaluate the expression anyway. I'm pretty happy with -not- evaluating > > the expre

Re: [RANDOM] Move two variables to read_mostly section to save memory

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 12:45:01PM +0100, Eric Dumazet wrote: > While examining vmlinux namelist on i686, I noticed : > > c0581300 D random_table > c0581480 d input_pool > c0581580 d random_read_wakeup_thresh > c0581584 d random_write_wakeup_thresh > c0581600 d blocking_pool > > That means that t

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 12:40:53PM +0100, Mariusz Kozlowski wrote: > > cat /proc/kpageflags on sparc64 causes the box to lock. > > I can not write on any terminal - but I can issue sysrqs and switch > > between consoles. > > > > cat process hangs in read(3, ... > > cat /proc/kpagecount pr

Re: [RANDOM] Move two variables to read_mostly section to save memory

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 07:38:14PM +0100, Eric Dumazet wrote: > Adrian Bunk a ??crit : > >On Sun, Dec 16, 2007 at 06:42:57PM +0100, Eric Dumazet wrote: > >>Adrian Bunk a ??crit : > >>... > >>>And even more funny, with gcc 4.2 and CONFIG_CC_OPTIMIZE_FOR_SIZE=y your > >>>patch doesn't seem to make a

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-16 Thread Matt Mackall
On Sun, Dec 16, 2007 at 08:10:10PM +0100, Mariusz Kozlowski wrote: > > > Can you change line 710 of fs/proc/proc_misc.c to: > > > > > > ppage = NULL; > > > > Sure. > > > > > ..and see if it still breaks? > > > > Yes it does - the same way as eariler. Box is locked, processes stuck in D > > s

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-17 Thread Matt Mackall
On Sun, Dec 16, 2007 at 10:39:17PM -0800, Andrew Morton wrote: > On Sun, 16 Dec 2007 20:26:11 -0800 (PST) David Miller <[EMAIL PROTECTED]> > wrote: > > > From: Matt Mackall <[EMAIL PROTECTED]> > > Date: Sun, 16 Dec 2007 20:11:49 -0600 > > > > >

Re: QUEUE_FLAG_CLUSTER: not working in 2.6.24 ?

2007-12-17 Thread Matt Mackall
On Mon, Dec 17, 2007 at 11:24:57AM -0800, Randy Dunlap wrote: > On Sun, 16 Dec 2007 21:55:20 + Mel Gorman wrote: > > > > > Just using cp to read the file is enough to cause problems but I > > > > included > > > > a very basic program below that produces the BUG_ON checks. Is this a > > > > k

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
On Mon, Dec 17, 2007 at 01:36:31PM -0800, Arjan van de Ven wrote: > On Mon, 17 Dec 2007 18:23:31 +0100 > Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > > The http://www.kerneloops.org website collects kernel oops and > > > warning reports f

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
> > >Heh. UUID's don't have to be readable; just universally unique. Code > >on the other hand should be readable. :-) > > Linus' suggested... improvement should either be done in all 3 places or > none ;) > Since you're the maintainer... wha

Re: Top kernel oopses/warnings this week

2007-12-18 Thread Matt Mackall
On Tue, Dec 18, 2007 at 10:06:14AM -0800, Arjan van de Ven wrote: > Linus Torvalds wrote: > > > >On Mon, 17 Dec 2007, Arjan van de Ven wrote: > >>+char *get_boot_uuid(void) > >>+{ > >>+ static char target[38]; > >>+ unsigned char *uuid; > >>+ > >>+ if (sysctl_bootid[8] == 0) > >>+ g

Re: [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h

2007-12-18 Thread Matt Mackall
On Tue, Dec 18, 2007 at 10:25:50PM +0100, Eric Dumazet wrote: > Some 'extern struct seq_operations' are wrongly defined in > fs/proc/proc_misc.c (they miss a const qualifier) > > In order to fix this correctly, move the "extern ... " declaration from .c > file to an appropriate include file, as

Re: a problem with NETPOLL/KGDBoE

2007-12-19 Thread Matt Mackall
On Wed, Dec 19, 2007 at 06:22:55PM +0200, Ramagudi Naziir wrote: > On 12/6/07, Matt Mackall <[EMAIL PROTECTED]> wrote: > > netpoll will ignore incoming UDP -from- the wrong port/ip/mac, since > > it's otherwise bypassing the firewall layer. > ... > > I for

Re: [rfc][patch] mm: madvise(WILLNEED) for anonymous memory

2007-12-20 Thread Matt Mackall
On Thu, Dec 20, 2007 at 05:53:41PM +0100, Peter Zijlstra wrote: > > On Thu, 2007-12-20 at 15:26 +, Hugh Dickins wrote: > > > The asynch code: perhaps not worth doing for MADV_WILLNEED alone, > > but might prove useful for more general use when swapping in. > > Not really the same as Con's swa

Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

2007-12-20 Thread Matt Mackall
On Thu, Dec 20, 2007 at 04:53:59AM -0800, David Miller wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Mon, 17 Dec 2007 08:55:54 -0600 > > > On Sun, Dec 16, 2007 at 10:39:17PM -0800, Andrew Morton wrote: > > Actually, you may only need these two: > >

Re: [PATCH] mm: MADV_WILLNEED implementation for anonymous memory

2008-01-30 Thread Matt Mackall
On Wed, 2008-01-30 at 18:28 +0100, Peter Zijlstra wrote: > Subject: mm: MADV_WILLNEED implementation for anonymous memory > > Implement MADV_WILLNEED for anonymous pages by walking the page tables and > starting asynchonous swap cache reads for all encountered swap pages. > > Doing so required a

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt

2008-01-30 Thread Matt Mackall
On Tue, 2008-01-29 at 16:14 +0200, Heikki Orsila wrote: > > > Imo, > > > "same exact C compiler" is just bad language, because C compilers are > > > always "exact". "exactly same C compiler" would do. > > > > No, "exactly same C compiler" doesn't parse well in English. > > "Same exact C compil

Re: [2.6 patch] unexport add_disk_randomness

2008-01-30 Thread Matt Mackall
On Wed, 2008-01-30 at 22:02 +0200, Adrian Bunk wrote: > This patch removes the no longer used EXPORT_SYMBOL(add_disk_randomness). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Matt Mackall <[EMAIL PROTECTED]> > --- > f1a195a30248eae541ba006633aa7

Serious problems with HFS+

2005-03-13 Thread Matt Mackall
I've noticed a few problems with HFS+ support in recent kernels on another user's machine running Ubuntu (Warty) running 2.6.8.1-3-powerpc. I'm not in a position to extensively test or fix either of these problem because of the fs tools situation so I'm just passing this on. First, it reports inap

Re: [RFC][PATCH] new timeofday core subsystem (v. A3)

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 10:42:45AM -0800, john stultz wrote: > > > > +static inline cycle_t read_timesource(struct timesource_t* ts) > > > +{ > > > + switch (ts->type) { > > > + case TIMESOURCE_MMIO_32: > > > + return (cycle_t)readl(ts->mmio_ptr); > > > + case TIMESOURCE_MMIO_64: > > > +

Re: [RFC][PATCH] new timeofday core subsystem (v. A3)

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 11:43:21AM -0800, john stultz wrote: > On Mon, 2005-03-14 at 11:29 -0800, Matt Mackall wrote: > > On Mon, Mar 14, 2005 at 10:42:45AM -0800, john stultz wrote: > > > > > > > > +static inline cycle_t read_t

Re: [RFC][PATCH] new timeofday core subsystem (v. A3)

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 12:04:07PM -0800, john stultz wrote: > > > > > > > +static inline cycle_t read_timesource(struct timesource_t* ts) > > > > > > > +{ > > > > > > > + switch (ts->type) { > > > > > > > + case TIMESOURCE_MMIO_32: > > > > > > > + return (cycle_t)readl(ts->mmio_ptr); > > >

Re: [PATCH] "PREEMPT" in UTS_VERSION

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 09:49:17PM +0100, Sam Ravnborg wrote: > On Wed, Feb 09, 2005 at 10:40:11AM -0800, Matt Mackall wrote: > > Add PREEMPT to UTS_VERSION where enabled as is done for SMP to make > > preempt kernels easily identifiable. > I have the following patch in my tr

Re: pam and nice-rt-prio-rlimits

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 10:14:17AM +0100, Vegard Lima wrote: > Hello, > > in the long thread on "[request for inclusion] Realtime LSM" there > doesn't appear to be too many people who has actually tested the > nice-and-rt-prio-rlimits.patch. Well, it works for me... > > However, the patch to pam_

Re: [PATCH][1/2] SquashFS

2005-03-14 Thread Matt Mackall
A quick skim... > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. > + * > + * inode.c > + */ > + > +#include > +#include > +#include

Re: [PATCH][1/2] SquashFS

2005-03-14 Thread Matt Mackall
On Tue, Mar 15, 2005 at 12:47:23PM +1100, Nick Piggin wrote: > Matt Mackall wrote: > > >>+ for (;;) { > > > >while (1) > > I always thought for (;;) was preferred. Or at least acceptable? The for (;;) form has always struck me as needlessly clever and I'

Re: Serious problems with HFS+

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 11:18:49AM +0100, Roman Zippel wrote: > Hi, > > On Sun, 13 Mar 2005, Matt Mackall wrote: > > > I've noticed a few problems with HFS+ support in recent kernels on > > another user's machine running Ubuntu (Warty) running > > 2.6

Re: [PATCH][2/2] SquashFS

2005-03-14 Thread Matt Mackall
On Mon, Mar 14, 2005 at 04:30:33PM +, Phillip Lougher wrote: > +config SQUASHFS_1_0_COMPATIBILITY > + bool "Include support for mounting SquashFS 1.x filesystems" How common are these? It would be nice not to bring in legacy code. > +#define SERROR(s, args...) do { \ > +

[PATCH] reduce __deprecated spew

2005-03-14 Thread Matt Mackall
campaigns. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> Index: bk/include/linux/pm.h === --- bk.orig/include/linux/pm.h 2005-03-14 22:14:59.0 -0800 +++ bk/include/linux/pm.h 2005-03-14 22:17:48.0 -0800 @@ -

Re: [PATCH][1/2] SquashFS

2005-03-15 Thread Matt Mackall
On Tue, Mar 15, 2005 at 03:50:26PM +, Phillip Lougher wrote: > Paul Jackson wrote: > >In the overall kernel (Linus's bk tree) I count: > > > > 733 lines matching 'for *( *; *; *)' > > 718 lines matching 'while *( *1 *)' > > > >In the kernel/*.c files, I count 15 of the 'for(;;)' style a

Re: [BUG] Re: [PATCH] scripts/patch-kernel: use EXTRAVERSION

2005-03-15 Thread Matt Mackall
On Tue, Mar 15, 2005 at 09:44:24AM -0800, Greg KH wrote: > On Tue, Mar 15, 2005 at 08:25:46AM -0800, Greg KH wrote: > > On Tue, Mar 15, 2005 at 04:15:54PM +, David Greaves wrote: > > > Old thread (!) but this is the last time I could find patch-kernel > > > updated. > > > > Why not just use k

Re: [PATCH][2/2] SquashFS

2005-03-15 Thread Matt Mackall
On Tue, Mar 15, 2005 at 11:25:07PM +, Phillip Lougher wrote: > Matt Mackall wrote: > > > >>+config SQUASHFS_1_0_COMPATIBILITY > >>+ bool "Include support for mounting SquashFS 1.x filesystems" > > > >How common are these? It would be ni

Re: [PATCH][2/2] SquashFS

2005-03-15 Thread Matt Mackall
On Tue, Mar 15, 2005 at 05:04:32PM -0800, Matt Mackall wrote: > On Tue, Mar 15, 2005 at 11:25:07PM +, Phillip Lougher wrote: > > >>+ unsigned ints_major:16; > > >>+ unsigned ints_minor:16; > > > > > >What's going

2.6.11-tiny1 released

2005-03-15 Thread Matt Mackall
This is a resync of the -tiny tree against 2.6.11. The latest patch can be found at: http://selenic.com/tiny/2.6.11-tiny1.patch.bz2 http://selenic.com/tiny/2.6.11-tiny1-broken-out.tar.bz2 There's a mailing list for linux-tiny development at: linux-tiny at selenic.com http://selenic.com/mai

Re: KGDB question

2005-03-17 Thread Matt Mackall
On Thu, Mar 17, 2005 at 02:29:58PM -0800, Andrew Morton wrote: > Jesse Barnes <[EMAIL PROTECTED]> wrote: > > > > > kgdb patches are maintained in -mm kernels. > > > > > > Patches are in > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11 > > >-mm1/broken-out/*kgdb* > >

Re: 2.6.11-rc3: APM resume problems with USB

2005-03-19 Thread Matt Mackall
On Sat, Mar 19, 2005 at 01:44:24AM -0800, Jeremy Fitzhardinge wrote: > On my IBM ThinkPad X31, I can only do one successful APM resume. After > the resume, there's a stream of messages on the console: > > uhci_hcd :00:1d.0: host controller process error, something bad > happened! > uhci_hcd

[PATCH] "PREEMPT" in UTS_VERSION

2005-02-09 Thread Matt Mackall
Add PREEMPT to UTS_VERSION where enabled as is done for SMP to make preempt kernels easily identifiable. Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> Index: mm1/scripts/mkcompile_h === --- mm1.orig/scripts/mkcompile_h

Re: [PATCH] BSD Secure Levels: printk overhaul, 2.6.11-rc2-mm1 (1/8)

2005-02-10 Thread Matt Mackall
On Mon, Feb 07, 2005 at 01:21:08PM -0600, Michael Halcrow wrote: > This is the first in a series of eight patches to the BSD Secure > Levels LSM. It overhauls the printk mechanism in order to reduce the > unnecessary usage of the .text area. Thanks to Brad Spengler for the > suggestion. > > Sign

Re: 2.6.11-rc3-mm2

2005-02-10 Thread Matt Mackall
On Thu, Feb 10, 2005 at 02:51:44PM -0600, Jack O'Quin wrote: > [direct reply bounced, resending via gmail] > > Andrew Morton <[EMAIL PROTECTED]> writes: > > > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > > On Thu, Feb 10, 2005 at 02:35:08AM -0800, Andrew Morton wrote: > > > > > > > >

Re: 2.6.11-rc3-mm2

2005-02-10 Thread Matt Mackall
On Thu, Feb 10, 2005 at 04:47:27PM -0800, Chris Wright wrote: > * Matt Mackall ([EMAIL PROTECTED]) wrote: > > What happened to the RT rlimit code from Chris? > > I still have it, but I had the impression Ingo didn't like it as a long > term solution/hack (albeit small) to

Re: 2.6.11-rc3-mm2

2005-02-10 Thread Matt Mackall
On Thu, Feb 10, 2005 at 10:41:28PM -0500, Paul Davis wrote: > [ the best solution is ] > > [ my preferred solution is ... ] > > [ it would be better if ... ] > > [ this is a kludge and it should be done instead like ... ] > > did nobody read what andrew wrote and what JOQ pointed o

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 08:54:17AM +0100, Ingo Molnar wrote: > > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > Eh? Chris Wright's original rlimits patch was very straightforward > > [...] > > the problem is that it didnt solve the problem (unprivileged

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 09:14:22AM +0100, Ingo Molnar wrote: > > > I think it's important to recognize that we're trying to address an > > issue that has a much wider potential audience than pro audio users, > > and not very far off - what is high end audio performance today will > > be expected d

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 09:48:43AM +0100, Ingo Molnar wrote: > > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > Here's Chris' patch for reference: > > > > http://groups-beta.google.com/group/linux.kernel/msg/6408569e13ed6e80 > > how does

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 10:04:19AM +0100, Ingo Molnar wrote: > > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > So the comparison boils down to putting a magic gid in a sysfs > > file/module parameter or setting an rlimit with standard tools (PAM, > > etc). I&#

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 09:59:42AM +0100, Ingo Molnar wrote: > > think of SCHED_FIFO on the desktop as an ugly wart, a hammer, that > destroys the careful balance of priorities of SCHED_OTHER tasks. Yes, it > can be useful if you _need_ a scheduling guarantee due to physical > constraints, and it

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 10:53:27AM +0100, Ingo Molnar wrote: > > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > On Fri, Feb 11, 2005 at 09:59:42AM +0100, Ingo Molnar wrote: > > > > > > think of SCHED_FIFO on the desktop as an ugly wart, a hammer, tha

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 12:49:04PM -0500, Paul Davis wrote: > >RT-LSM introduces architectural problems in the form of bogus API. And > > that may be true of LSM, but not RT-LSM in particular. RT-LSM doesn't > introduce *any* API whatsoever - it simply allows software to call > various existing AP

Re: 2.6.11-rc3-mm2

2005-02-11 Thread Matt Mackall
On Fri, Feb 11, 2005 at 06:49:05PM +0100, Ingo Molnar wrote: > > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > > > Yes. There's also the whole soft limit thing. > > > > > > i'm curious, how does this 'per-app' rlimit t

Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm

2005-02-11 Thread Matt Mackall
On Thu, Feb 10, 2005 at 12:17:24PM +0100, Fruhwirth Clemens wrote: > On Thu, 2005-02-10 at 02:33 -0800, Andrew Morton wrote: > > Fruhwirth Clemens <[EMAIL PROTECTED]> wrote: > > > > > > On Wed, 2005-02-09 at 17:19 -0800, Andrew Morton wrote: > > > > Fruhwirth Clemens <[EMAIL PROTECTED]> wrote: > >

Radeon FB troubles with recent kernels

2005-02-14 Thread Matt Mackall
On my Thinkpad T30 with a Radeon Mobility M7 LW, I get interesting console video corruption if I start GDM, switch back to text mode, then stop it again. X is Xfree86 from Debian/unstable or X.org 6.8.2. The corruption shows up whenever the console scrolls after X has been shut down and manifests

<    1   2   3   4   5   6   7   8   9   10   >