It was mistakenly defined to be 24 instead of the next higher number 25.
Reported-by: Alexander Shishkin
Cc: Stephen Hurd
Signed-off-by: Michael Chan
---
include/uapi/linux/serial_core.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/uapi/linux/serial_core.h
nt
>
> This patch moves the code that asserts the TSO_CAPABLE flag closer
> to
> where the TSO capabilities flags are set. There isn't a good
> enough
> reason for the code to be separated.
>
> Signed-off-by: Matt Carlson
> Reviewed-by: M
On Tue, 2012-10-02 at 18:49 +0200, Ferenc Wagner wrote:
> Going into the opposite direction: I found that Linux 3.6 does not
> permanently break the SoL console on upping eth0! I'll try to find
> the
> commit which (sort of) fixed it.
These are the likely fixes:
>
commit cf9ecf4b631f649a964fa611
On Wed, 2013-05-29 at 17:00 +0800, Yijing Wang wrote:
> Pci_enable_device() will set device pm state to D0, so
> it's no need to do it again in tg3_init_one().
>
> Signed-off-by: Yijing Wang
Acked-by: Michael Chan
> ---
> drivers/net/ethernet/broadcom/tg3.c | 20 +-
On Mon, 2008-02-18 at 16:35 -0800, David Miller wrote:
> One consequence of Herbert's change is that the chip will see a
> different datastream. The initial skb->data linear area will be
> smaller, and the transition to the fragmented area of pages will be
> quicker.
>
I see. Perhaps when we g
On Mon, 2008-02-18 at 17:41 -0500, Tony Battersby wrote:
> I am experiencing network data corruption with a 3Com 3C996B-T NIC
> (Broadcom NetXtreme BCM5701; driver tg3.ko). I have identified the
> following patch as the trigger:
Assuming this problem is unique to the 5701, I'm not sure how it is
On Tue, 2008-02-19 at 11:16 -0500, Tony Battersby wrote:
> iSCSI
> performance drops to 6 - 15 MB/s when the 3Com NIC is doing heavy rx
> with light tx,
That's strange. The patch should only affect TX performance slightly
since we are just turning off SG for TX. Please take an ethereal trace
to
On Tue, 2008-02-19 at 17:14 -0500, Tony Battersby wrote:
>
> Update: when I revert Herbert's patch in addition to applying your
> patch, the iSCSI performance goes back up to 115 MB/s again in both
> directions. So it looks like turning off SG for TX didn't itself cause
> the performance drop, b
On Wed, 2008-02-20 at 15:08 -0800, David Miller wrote:
> From: Tony Battersby <[EMAIL PROTECTED]>
> Date: Wed, 20 Feb 2008 18:04:09 -0500
>
> > The following patch fixes the problem for me. Do we want to accept this
> > patch and call it a day or continue investigating the source of the problem?
On Thu, 2012-08-16 at 11:21 -0700, Jiang Wang wrote:
> The initialization state of bnx2 driver is wrong. It does not turn
> of the Linux network stack using netif_carrier_off. This may lead to
> inconsistent report from ethtool as the link is up but speed is
> unknown when the cable is not plugged
before bnx2_open() is called. Can you please
elborate? Thanks.
> Regards,
>
> Jiang
>
> -
> Jiang Wang
> Member of Technical Staff
> Riverbed Technology
> Tel: (408) 522-5109
> Email: jiang.w...@riverbed.com
> www.riverbed.com
On Thu, 2012-08-16 at 20:28 +, Jiang Wang wrote:
> Also, I have another comment related to link state.
>
> Right now, the bnx2 driver powers up the device in bnx2_init_board(),
> regardless the netif_carrier is on or off.
We actually don't power up the device. bnx2_init_board() just probes
t
On Thu, 2012-08-16 at 21:48 +, Jiang Wang wrote:
> I see. I was confused by the name of bnx2_set_power_state() and
> I think the PHY is actually powered up by bnx2_reset_nic, right?
bnx2_init_phy() in bnx2_init_nic() will bring up the PHY if it is down.
>
>
--
To unsubscribe from th
On Sat, 2013-02-16 at 13:20 -0800, Joe Perches wrote:
> It's the same value as tp->pci_chip_rev_id so use that
> instead. This makes all CHIPREV_ID_ tests the same.
>
> Signed-off-by: Joe Perches
Acked-by: Michael Chan
--
To unsubscribe from this list: send the lin
ev and tg3_chip_rev.
>
> These macros are not converted to static inline functions
> because gcc (tested with 4.7.2) is currently unable to
> optimize the object code it produces the same way and code
> is otherwise larger.
>
> Signed-off-by: Joe Perches
Acked-by: Michae
On Wed, 2013-01-09 at 08:03 +0100, Marcin Miotk wrote:
> 03:04.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5715
> Gigabit Ethernet (rev a3)
> 03:04.1 Ethernet controller: Broadcom Corporation NetXtreme BCM5715
> Gigabit Ethernet (rev a3)
I tested on 3.7 kernel and it seemed to work.
On Fri, 2012-09-28 at 22:45 +0200, Ferenc Wagner wrote:
> Hi,
>
> Upgrading the kernel on our HS20 blades resulted in their SoL (serial
> over LAN) connection being broken. The disconnection happens when eth0
> (the interface involved in SoL) is brought up during the boot sequence.
> If I later
On Thu, 2013-01-17 at 17:59 +0100, Marcin Miotk wrote:
> root@XX ~ # cat miitool_non_working_3.4.11
> Using SIOCGMIIPHY=0x8947
> eth1: 100 Mbit, full duplex, no link
> registers for MII PHY 1:
> 2100 7949 0020 6340 0041 0004 2001
> 3000
> 00
to track this. It continues to reload the THR as long
as the THRE and TSRE bits are set in the LSR up to a specified limit (1024
is used here).
Signed-off-by: Stephen Hurd
Signed-off-by: Michael Chan
---
drivers/tty/serial/8250/8250.c | 11 ++
drivers/tty/serial/8250/8250.h
Please tell us what tg3 device you're using. You can provide lspci
output or tg3 probing dmesg output. Thanks.
On Wed, 2013-01-09 at 11:20 +0800, 王金浦 wrote:
> For this kind of driver related question, I suggest you send mail to
> tg3 driver developers, who I already cced.
>
>
> I think they s
[EMAIL PROTECTED] wrote:
> (a) the Dell factory default is WOL disabled and (b)
> if it wasn't
> the default, I'd have *set* it to disabled, and (c) I even
> went back and
> rebooted and checked the BIOS setting - disabled. Nonetheless:
>
> # ethtool eth0 | grep Wake
> Supports Wake-on:
On Tue, 2007-11-27 at 01:35 -0800, [EMAIL PROTECTED] wrote:
>
> Issue:
>
> I (for unrelated reasons) run powertop, and it suggests I conserve power
> by doing 'ethtool -s eth0 wol d'. I look at it, and think that it's daft,
> because (a) the Dell factory default is WOL disabled and (b) if it wa
SE bit for 1000Base-X twice instead
checking for both the 1000Base-X bit and the 10/100/1000Base-T bit.
The purpose of the logic is to tell the firmware that ASYM_PAUSE is
set on either the Serdes or Copper interface.
Problem was discovered by Roel Kluin <[EMAIL PROTECTED]>
Signed-off-by:
properly validating the sram contents.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
tg3_cap_cpling.patch
Description: tg3_cap_cpling.patch
On Tue, 2007-11-13 at 18:04 -0800, Joe Perches wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
Thanks.
-
On Thu, 2007-11-15 at 10:47 +0100, Jarek Poplawski wrote:
> On 13-11-2007 19:57, Jon Nelson wrote:
> > The best info I've got is this:
It looks like the card is being reset periodically. Every time the card
gets reset, you'll see those PM messages in the version of the driver
you're using. Do yo
On Thu, 2007-11-15 at 13:17 -0600, Jon Nelson wrote:
> Is this what you mean? I pulled this from the quoted text:
>
> Nov 10 22:45:52 frank kernel: NETDEV WATCHDOG: eth0: transmit timed out
>
Right. This explains the reset at 22:45:52, but not the earlier reset
at 22:24:40. Link never came up
On Thu, 2007-08-02 at 15:06 -0700, David Miller wrote:
> From: "Michael Chan" <[EMAIL PROTECTED]>
> Date: Thu, 02 Aug 2007 12:10:29 -0700
>
> > Alternatively, we can also fix it by calling pci_enable_device() again
> > in tg3_open(). But I think it is better t
On Tue, 2007-07-31 at 17:45 -0700, Andrew Morton wrote:
> On Tue, 31 Jul 2007 11:28:32 +0200 "Joachim Deguara"
> <[EMAIL PROTECTED]> wrote:
>
> > On my Acer Ferrari 1000 the tg3 ethernet no longer is available
> after a
> > suspend to ram with the latet 2.6.23-rc1-git9.
It seems to work for me on
On Wed, 2007-08-01 at 10:01 +0200, Joachim Deguara wrote:
> Here are the lspci outputs for the tg3
You have 2 Broadcom devices in your system. 07:00.0 is a wireless
device, I think. 8:4.0 is the tg3 device.
It's clear that the tg3 device is still in D3 state after resume and
that explains why
On Wed, 2007-08-01 at 10:47 -0700, Michael Chan wrote:
> You have 2 Broadcom devices in your system. 07:00.0 is a wireless
> device, I think. 8:4.0 is the tg3 device.
>
> It's clear that the tg3 device is still in D3 state after resume and
> that explains why all re
able bit
and bus master enable bit would be lost.
We fix this by always saving and restoring the PCI state in
tg3_suspend() and tg3_resume() regardless of netif_running() state.
Signed-off-by: Michael Chan <[EMAIL PROTECTED]>
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index dc41c05.
PCI_DEVICE_ID_TIGON3_5714S,
> + quirk_msi_intx_disable_bug);
> +
Please add PCI_DEVICE_ID_TIGON3_5715 and
PCI_DEVICE_ID_TIGON3_5715S as well.
Other than that,
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscrib
X2]: Fix VLAN on ASF
> >
> > Always set up the device to strip incoming VLAN tags when ASF is
> > enabled. ASF firmware will not parse packets correctly if VLAN tags
> > are not stripped.
> >
> > Signed-off-by: Michael Chan <[
Adrian Bunk wrote:
> This patch adds a missing error check spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel
On Tue, 2006-12-12 at 21:10 +0200, Yan Burman wrote:
> Replace kmalloc+memset with kzalloc
>
> Signed-off-by: Yan Burman <[EMAIL PROTECTED]>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
On Mon, 2 Apr 2007 11:43:19 +1000 CaT <[EMAIL PROTECTED]> wrote:
>
> I take minute by minute snapshots of network traffic by sampling
> /proc/net/dev and most of the time everything works fine. Occasionally
> though I get petabyte byte traffic and corresponding packet traffic.
We were able to re
On Mon, 2007-04-02 at 17:41 +1000, CaT wrote:
> On Mon, Apr 02, 2007 at 12:13:00AM -0700, Andrew Morton wrote:
> > On Mon, 2 Apr 2007 11:43:19 +1000 CaT <[EMAIL PROTECTED]> wrote:
> >
> > > I take minute by minute snapshots of network traffic by sampling
> > > /proc/net/dev and most of the time ev
On Sat, 2007-04-14 at 17:20 -0700, Michael Chan wrote:
> I also like Andi's idea of using change_page_attr() to isolate the
> problem. I'll try to send you a debug patch in the next few days to try
> that out. Thanks.
>
Here's the debug patch for x86 only that will c
On Thu, 2007-03-22 at 21:46 +0100, Bernhard Walle wrote:
>
> This patch makes sure that even the tr32() instruction in the interrupt
> handler
> is not executed which accesses PCI memory. Accessing PCI memory when
> pci_restore_state() is called is a bad idea because that function modifies
> the
driver will crash when the chip has been initialized by EFI before
tg3_init_one(). In this case, the driver will call tg3_chip_reset()
before allocating consistent memory.
The bug is fixed by checking for tp->hw_status before accessing it
during tg3_chip_reset().
Signed-off-by: Michael Chan &l
On Sun, Sep 25, 2016 at 2:31 PM, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes
Looks good to me. Thanks.
Acked-by: Michael Chan
On Tue, Jul 24, 2018 at 9:01 AM, Vasundhara Volam
wrote:
> On Tue, Jul 24, 2018 at 1:01 PM, Michael Chan
> wrote:
>>
>> On Mon, Jul 23, 2018 at 10:24 PM, YueHaibing wrote:
>> > Based on the comments,req->l2addr must match the VF MAC address
>> > if fir
On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote:
> From: Colin Ian King
>
> In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the
> exit return path is via label next_rx_no_prod and cpr->rx_bytes
> is being updated by an uninitialized value from len. Fix this by
> initializing len to z
upt
> moderation")
>
> Signed-off-by: Colin Ian King
Thanks.
Acked-by: Michael Chan
On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote:
> Code includes wmb() followed by writel(). writel() already has a barrier on
> some architectures like arm64.
>
> This ends up CPU observing two barriers back to back before executing the
> register write.
>
> Create a new wrapper function with r
line in the patch description is not needed anymore. Other than that,
Acked-by: Michael Chan
Thanks.
>
> Signed-off-by: Sinan Kaya
if the udelay should be 20
> instead of 10, due to any timing changes introduced by the offending
> patch.
Thanks. 10 us is correct.
As a future improvement, we might want to see if we can release the
spinlock and go back to usleep_range(). The wait time is potentially
up to 20 msec which is quite long.
Acked-by: Michael Chan
The issue is this message means nothing to
> anyone except Broadcom. Remove the message to not confuse users as this
> message is really not very informative.
>
> Signed-off-by: Jonathan Toppins
> ---
>
> Notes:
> v2:
> include changes recommended by Michael Chan
>
Acked-by: Michael Chan
On Thu, 2007-09-13 at 14:11 -0700, Roland Dreier wrote:
>
> I've been meaning to track down the bnx2 iscsi offload patch to look
> and see if this issue is addressed, since the same problem seems to
> exist: it seems an iscsi connection and a main stack tcp connection
> might share the same 4-tup
On Fri, 2007-09-14 at 09:18 -0700, Roland Dreier wrote:
> However, do you have any plans to support iSCSI offload for targets?
> Also, looking at the first CNIC patch, I can't help but notice that
> you seem to have at least some support for iWARP there. How does the
> CNIC look? Does it share t
On Tue, 2007-09-18 at 18:23 +0100, Denys Vlasenko wrote:
> Hi Michael,
>
> In bnx2_fw.h I see the following:
>
> static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 };
>
> static struct fw_info bnx2_rxp_fw_06 = {
> ...
> .bss= bnx2_RXP_b06FwBss,
> ...
> };
>
On Tue, 2007-09-18 at 18:55 +0100, Denys Vlasenko wrote:
> On Tuesday 18 September 2007 19:45, Michael Chan wrote:
> > We can compress all the different sections of the firmware. Currently,
> > we only compress the biggest chunks and the rest are uncompressed.
>
> > The
On Tue, 2007-09-18 at 11:23 -0700, David Miller wrote:
> I don't like it because it means people have to setup full initrd's
> in order to do network booting with such network cards.
>
> But the days of my opinion mattering on that issue are long gone,
> the momentum is just too greatly behind us
On Tue, 2007-09-18 at 23:37 +0200, Willy Tarreau wrote:
> > > Michael, doesn't a functional-yet-suboptimal firmware exist ? I mean,
> > > just the same principle as we all have kernels, boot CDs, statically
> > > built tools, etc... which run everywhere. If you have such a beast,
> > > maybe it wo
On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote:
+ /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename)
+* is stripped, 32-bit unpacked size (LE) is prepended instead */
+ sz = *zbuf++;
+ sz = (sz << 8) + *zbuf++;
+ sz = (sz << 8) + *zbuf++;
On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote:
> Are you saying that you successfully run-tested it?
I've only reviewed the code. Let's resolve these issues first before
testing the code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a messag
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote:
>
>
> Please test these two patches.
> I updated them according to your comments.
>
>
I've only tested patch #1. It worked after some minor modifications
below.
>
>
>
>
>
> plain text
> document
> attachment
> (linux-2.6.23-
> rc6
ook and I'll try to do so as well
> tonight.
>
I've already reviewed the earlier versions of the patch and have made
some suggestions. This latest one looks ok to me and tested ok.
I'll follow up later with another patch to remove all the zeros in other
firmware sections, an
On Tue, 2015-01-13 at 07:47 -0500, Peter Hurley wrote:
> > tp->lock is held in this code path. If synchronize_irq() sleeps in
> > wait_event(desc->wait_for_threads, ...), we'll get the warning.
> >
> > The synchronize_irq() call is to wait for any tg3 irq handler to finish
> > so that it is guar
On Mon, 2015-01-12 at 19:59 -0500, Peter Hurley wrote:
> [ 17.203009] BUG: sleeping function called from invalid context at
> /home/peter/src/kernels/mainline/kernel/irq/manage.c:104
> [ 17.203067] in_atomic(): 1, irqs_disabled(): 0, pid: 1106, name: ip
> [ 17.203092] 2 locks held by ip/110
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote:
> Is there a more automatic method than going through the source for each
> configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the
> relevant firmwares? Is there any way to give the kernel the location of
> linux-firmware and h
On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.h
> b/drivers/net/ethernet/broadcom/tg3.h
> index 3b5e98e..6727d93 100644
> --- a/drivers/net/ethernet/broadcom/tg3.h
> +++ b/drivers/net/ethernet/broadcom/tg3.h
> @@ -3352,6 +3352,7 @@ struct tg
On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.h
> b/drivers/net/ethernet/broadcom/tg3.h
> index 3b5e98e..c61d83c 100644
> --- a/drivers/net/ethernet/broadcom/tg3.h
> +++ b/drivers/net/ethernet/broadcom/tg3.h
> @@ -3102,6 +3102,7 @@ enum TG3_F
On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote:
> On 2018年05月02日 13:12, Michael Chan wrote:
>>
>> On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote:
>>
>>> diff --git a/drivers/net/ethernet/broadcom/tg3.h
>>> b/drivers/net/ethernet/broadcom/tg3.h
>
On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote:
> On 2018年05月03日 01:32, Michael Chan wrote:
>>
>> On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote:
>>>
>>> On 2018年05月02日 13:12, Michael Chan wrote:
>>>>
>>>> On Tue, May 1, 2018 at
On Thu, Nov 19, 2020 at 9:53 PM Jakub Kicinski wrote:
>
> On Thu, 19 Nov 2020 10:53:23 -0800 Edwin Peer wrote:
> > > Fix to return a negative error code from the error handling
> > > case instead of 0, as done elsewhere in this function.
> > >
> > > Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethe
On Sun, 2013-12-01 at 02:34 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki
>
> Modify tg3_chip_reset() and tg3_close() to check if the PCI network
> adapter device is accessible at all in order to skip poking it or
> trying to handle a carrier loss in vain when that's not the case.
> I
On Mon, 2013-12-02 at 13:48 -0500, David Miller wrote:
> From: "Michael Chan"
> Date: Sun, 1 Dec 2013 12:39:19 -0800
>
> > I'm not familiar with the DS1. Does the tg3 device get removed through
> > tg3_remove_one() in this case? What happens when you
On Thu, 2014-01-30 at 19:08 +, Zoltan Kiss wrote:
> I've experienced some queue timeout problems mentioned in the subject
> with igb and bnx2 cards.
Please provide the full tx timeout dmesg. bnx2 dumps some diagnostic
information during tx timeout that may be useful. Thanks.
--
To unsubsc
On Fri, 2014-01-31 at 14:29 +0100, Zoltan Kiss wrote:
> [ 5417.275472] WARNING: at net/sched/sch_generic.c:255
> dev_watchdog+0x156/0x1f0()
> [ 5417.275474] NETDEV WATCHDOG: eth1 (bnx2): transmit queue 2 timed out
The dump shows an internal IRQ pending on MSIX vector 2 which matches
the the que
On Mon, 2013-12-09 at 10:43 -0800, Nat Gurumoorthy wrote:
> The new tg3 driver leaves REG_BASE_ADDR (PCI config offset 120)
> uninitialized. From power on reset this register may have garbage in it. The
> Register Base Address register defines the device local address of a
> register. The data poi
On Tue, 2013-12-10 at 00:18 +0300, Sergei Shtylyov wrote:
> >We had crashes when the PCI config space got scanned via
> > /sys/devices/pci/../config.
>
> > I agree that this fix will not help if the scan happens before the tg3
> > driver gets loaded.
>
> Then perhaps a better
On Mon, 2013-12-09 at 13:07 -0800, Michael Chan wrote:
> On Tue, 2013-12-10 at 00:18 +0300, Sergei Shtylyov wrote:
> > >We had crashes when the PCI config space got scanned via
> > > /sys/devices/pci/../config.
> >
> > > I agree that this f
On Tue, 2013-12-10 at 07:01 -0800, Natarajan Gurumoorthy wrote:
> The only time I see crashes is after the tg3 driver has been
> loaded into the system. I our use case we are poking around
> /sys/devices/pci//config.
David, please apply this first patch.
Acked-by: Mic
On Tue, 2013-12-10 at 13:43 -0500, David Miller wrote:
> What if the kernel is booted via kexec, and the driver in the kernel
> we are kexec'ing from left indirect access enabled in MISC_HOST_CTRL?
That should be ok. The driver will only use valid register offsets in
indirect mode during run tim
On Tue, 2013-12-10 at 22:23 -0500, David Miller wrote:
> Ok, that may be true, but I'd like to consider the much larger issue
> at hand.
>
> If the indirect mechanism is enabled, some of the offsets that may be
> in there might be value, but would be entirely undesirable to be read
> because the r
On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote:
> On 2014/08/19 15:00, Michael Chan wrote:
> > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> > > diff --git a/drivers/net/ethernet/broadcom/tg3.c
> > > b/drivers/net/ethernet/broadcom/tg3.c
&
On Thu, 2014-08-21 at 16:06 -0700, Benjamin Poirier wrote:
> On 2014/08/21 15:32, Michael Chan wrote:
> > On Thu, 2014-08-21 at 15:04 -0700, Benjamin Poirier wrote:
> > > On 2014/08/19 15:00, Michael Chan wrote:
> > > > On Tue, 2014-08-19 at 11:52 -0700, Benjamin
On Tue, 2014-09-09 at 20:24 +, Anish Bhatt wrote:
> This is caused by c99d667e8527 ("cnic : Cleanup CONFIG_IPV6 & VLAN check")
>
> So I'm not really sure what the fix for this is. CNIC will properly only
> support
> [m] or [n] when IPV6 is compiled as a module, but if you set SCSI_BNX2X_FC
On Tue, 2014-09-09 at 23:16 +, Anish Bhatt wrote:
> > It would be really good if SCSI_NETLINK depended on NET instead of selected
> > NET.
> > We shouldn't have kconfig symbols that use 'select' on entire subsystems.
>
> As a test, I was able to fix this by this approach : change SCSI_NETLIN
..
> - rcu_dereference
> + rcu_access_pointer
> (...)
> ...+>)) {...}
> )
>
> Signed-off-by: Andreea-Cristina Bernat
Acked-by: Michael Chan
> ---
> v2: Modified subject line from
> "rcu: Replace rcu_dereference() with rcu_access_pointer()"
> to
>
On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> diff --git a/drivers/net/ethernet/broadcom/tg3.c
> b/drivers/net/ethernet/broadcom/tg3.c
> index 3ac5d23..b11c0fd 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -202,7 +202,8 @@ stati
On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct
> tg3_napi *tnapi,
>struct netdev_queue *txq, struct sk_buff *skb)
> {
> struct sk_buff *segs, *nskb;
> - u32 frag_cnt_est = sk
On Wed, 2014-08-20 at 18:23 -0700, Benjamin Poirier wrote:
> On 2014/08/19 16:10, Michael Chan wrote:
> > On Tue, 2014-08-19 at 11:52 -0700, Benjamin Poirier wrote:
> > > @@ -7838,11 +7838,14 @@ static int tg3_tso_bug(struct tg3 *tp, struct
>
l done as no other work can be handled
> internally in the function tg3_test_loopback.
>
> Signed-off-by: Nicholas Krause
Acked-by: Michael Chan
> ---
> drivers/net/ethernet/broadcom/tg3.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff -
On Thu, 2015-07-16 at 12:18 -0700, Michael Chan wrote:
> On Thu, 2015-07-16 at 14:51 -0400, Nicholas Krause wrote:
> > This adds proper error handling for if the calls to the function
> > tg3_phy_lpbk_set fail by returning -EIO by assigning the return
> > value to the v
defined reference to
> `vxlan_get_rx_port'
>
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
>
> Signed-off-b
On Wed, Jul 31, 2019 at 9:06 AM Willem de Bruijn
wrote:
>
> On Wed, Jul 31, 2019 at 8:22 AM Chuhong Yuan wrote:
> >
> > refcount_t is better for reference counters since its
> > implementation can prevent overflows.
> > So convert atomic_t ref counters to refcount_t.
> >
> > Signed-off-by: Chuhon
On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote:
> static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 val)
> @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct
> cnic_ulp_ops *ulp_ops)
> }
> read_unlock(&cnic_dev_lock);
>
> - atomic_
On Wed, Jul 31, 2019 at 7:22 PM Chuhong Yuan wrote:
>
> Michael Chan 于2019年8月1日周四 上午1:58写道：
> >
> > On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote:
> >
> > > static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32
> &g
On Tue, Sep 11, 2018 at 1:14 PM, Ben Hutchings
wrote:
> On Thu, 2018-08-23 at 09:53 +0200, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch. If anyone has any objections, please let me know.
>>
>> --
>>
>> From: Vikas Gupta
>>
>> [ Upstream commit c58387ab1614f6d7fb9e244f214b
On Fri, Jul 15, 2016 at 11:20 PM, David Miller wrote:
> From: Florian Fainelli
> Date: Fri, 15 Jul 2016 16:42:01 -0700
>
>> @@ -4599,7 +4599,9 @@ static void bnxt_tx_enable(struct bnxt *bp)
>> for (i = 0; i < bp->tx_nr_rings; i++) {
>> txr = &bp->tx_ring[i];
>> t
orted-by: coverity (CID 1339583)
> Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
> Signed-off-by: Florian Fainelli
Thanks Florian.
Acked-by: Michael Chan
On Fri, Nov 11, 2016 at 6:02 AM, Baoquan He wrote:
> On 11/11/16 at 09:46pm, Baoquan He wrote:
>> Hi bnx2 experts,
>>
>> In commit 3e1be7a ("bnx2: Reset device during driver initialization"),
>> firmware requesting code was moved from open stage to probe stage.
>> The reason is in kdump kernel har
y created io-page table at probe stage.
>
> Suggested-by: Michael Chan
> Signed-off-by: Baoquan He
Acked-by: Michael Chan
rg/show_bug.cgi?id=188661
>
> Signed-off-by: Pan Bian
Acked-by: Michael Chan
lin Ian King
Thanks.
Acked-by: Michael Chan
covery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: Michael Chan
> Cc: Luis Chamberlain
> Acked-by: Rafael Aquini
> Signed-off-by: Vasundhara Volam
> Signed
On Fri, May 8, 2020 at 3:53 PM Colin King wrote:
>
> From: Colin Ian King
>
> Currently the value for 'off' is computed using a multiplication and
> a couple of statements later off is being incremented by len and
> this value is never read. Clean up the code by removing the
> multiplication and
1 - 100 of 122 matches
Mail list logo
