Re: [PATCH 5/7] clk: tegra: don't warn for PLL defaults unnecessarily

2017-02-23 Thread Mikko Perttunen
Reviewed-by: Mikko Perttunen On 22.02.2017 17:14, Peter De Schrijver wrote: If the PLL is on, only warn if the defaults are not yet set. Otherwise be silent. Signed-off-by: Peter De Schrijver --- drivers/clk/tegra/clk-tegra210.c | 18 -- 1 file changed, 12 insertions(+), 6

Re: [PATCH 6/7] clk: tegra: correct tegra210_pll_fixed_mdiv_cfg rate calculation

2017-02-23 Thread Mikko Perttunen
Reviewed-by: Mikko Perttunen On 22.02.2017 17:14, Peter De Schrijver wrote: Return the actually achieved rate in cfg->output_rate rather than just the requested rate. This is important to make clk_round_rate return the correct result. Signed-off-by: Peter De Schrijver --- drivers/clk/te

Re: [PATCH 7/7] clk: tegra: fix type for m field

2017-02-23 Thread Mikko Perttunen
Reviewed-by: Mikko Perttunen On 22.02.2017 17:14, Peter De Schrijver wrote: When used as part of fractional ndiv calculations, the current range is not enough because the denominator of the fraction is multiplied with m. Signed-off-by: Peter De Schrijver --- drivers/clk/tegra/clk.h | 2

Re: [PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

2017-02-27 Thread Mikko Perttunen
gt;plat->force_thresh_dma_mode) priv->hw->dma->dma_mode(priv->ioaddr, tc, tc, rxfifosz); else if (priv->plat->force_sf_dma_mode || priv->plat->tx_coe) { Reviewed-by: Mikko Perttunen

Re: [PATCH 3/7] net: stmmac: Check for DMA mapping errors

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding When DMA mapping an SKB fragment, the mapping must be checked for errors, otherwise the DMA debug code will complain upon unmap. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file

Re: [PATCH 2/7] net: stmmac: Balance PTP reference clock enable/disable

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding clk_prepare_enable() and clk_disable_unprepare() for this clock aren't properly balanced, which can trigger a WARN_ON() in the common clock framework. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/stmmac_

Re: [PATCH 6/7] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

2017-02-27 Thread Mikko Perttunen
move platform: %d\n", err); + + err = data->remove(pdev); + if (err < 0) + dev_err(&pdev->dev, "failed to remove subdriver: %d\n", err); + + stmmac_remove_config_dt(pdev, priv->plat); + + return err; } static const struct of_device_id dwc_eth_dwmac_match[] = { - { .compatible = "snps,dwc-qos-ethernet-4.10", }, + { .compatible = "snps,dwc-qos-ethernet-4.10", .data = &dwc_qos_data }, { } }; MODULE_DEVICE_TABLE(of, dwc_eth_dwmac_match); Reviewed-by: Mikko Perttunen

Re: [PATCH 5/7] net: stmmac: Program RX queue size and flow control

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding Program the receive queue size based on the RX FIFO size and enable hardware flow control for large FIFOs. Signed-off-by: Thierry Reding --- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 12 +++ drivers/net/ethernet/stm

Re: [PATCH 7/7] net: stmmac: dwc-qos: Add Tegra186 support

2017-02-27 Thread Mikko Perttunen
On 23.02.2017 19:24, Thierry Reding wrote: From: Thierry Reding The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC ethernet QOS IP core. The binding that it uses is slightly different from existing ones because of the integration (clocks, resets, ...). Signed-off-by: Thierry Redi

Re: [PATCH 2/5] clk: tegra: define Tegra210 DMIC sync clocks

2017-02-27 Thread Mikko Perttunen
;i2s1_sync", "i2s2_sync", "i2s3_sync", "i2s4_sync", "pll_a_out0", + "vimclk_sync", }; My GCC spews a bunch of warnings because these are "const char * const" and are passed to tegra_audio_sync_clk_init which takes "const

Re: [PATCH v2 0/7] Tegra210 clock bug fixes

2017-02-27 Thread Mikko Perttunen
Series, Reviewed-by: Mikko Perttunen Tested-by: Mikko Perttunen On 02/23/2017 12:44 PM, Peter De Schrijver wrote: A number of bug fixes for the Tegra210 clock implementation. Changelog: v2: add better description for 'remove non-existing pll_m_out1 clock' Peter De Schrijver

Re: [PATCH] soc/tegra: Add Tegra Soc Version support

2020-06-26 Thread Mikko Perttunen
On 6/26/20 1:29 PM, Sandipan Patra wrote: Add the chip IDs for NVIDIA Tegra186, Tegra194 and Tegra234 SoC family. families Signed-off-by: Sandipan Patra --- include/soc/tegra/fuse.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/soc/tegra/fuse.h b/include

Re: [PATCH -next] gpu: host1x: simplify the return expression of host1x_cdma_init()

2020-09-21 Thread Mikko Perttunen
On 9/21/20 4:10 PM, Qinglang Miao wrote: Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/gpu/host1x/cdma.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c index e8d3fda91..08a0f9e10 1006

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Mikko Perttunen
Not sure which boards this issue is happening on, but looking at my hobby kernel's git history (from a couple of years ago, memory is a bit hazy), the commit labeled "Add support for TX2" adds code to drop from EL2 to EL1 at boot. Mikko On 9/16/20 10:06 PM, Jon Hunter wrote: On 16/09/2020 17

Re: [PATCH v2 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

2017-04-19 Thread Mikko Perttunen
Rob, Mark, could you review this and the 3/3 in the series (which I'm sending to you momentarily)? Thanks, Mikko. On 04.04.2017 16:43, Mikko Perttunen wrote: The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-o

Re: [PATCH v2 3/3] arm64: tegra: Add CCPLEX_CLUSTER area in Tegra186

2017-04-19 Thread Mikko Perttunen
On 04.04.2017 16:43, Mikko Perttunen wrote: The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- v2: - Only one regs entry arch/arm64/boot/dts/nvidia/tegra186.dtsi | 7 +++ 1 file changed, 7

Re: [PATCH] gpu: host1x: select IOMMU_IOVA

2017-04-19 Thread Mikko Perttunen
Ah, had to forget something :) Reviewed-by: Mikko Perttunen On 19.04.2017 21:24, Arnd Bergmann wrote: When IOMMU_IOVA is not built-in but host1x is, we get a link error: drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text.host1x_remove+0x50): undefined referen

Re: [PATCH] [RFC] gpu: host1x: shut up warning about DMA API misuse

2017-04-20 Thread Mikko Perttunen
On 19.04.2017 21:24, Arnd Bergmann wrote: When dma_addr_t and phys_addr_t are not the same size, we get a warning from the dma_alloc_wc function: drivers/gpu/host1x/cdma.c: In function 'host1x_pushbuffer_init': drivers/gpu/host1x/cdma.c:94:48: error: passing argument 3 of 'dma_alloc_wc' from in

Re: [PATCH] [RFC] gpu: host1x: shut up warning about DMA API misuse

2017-04-20 Thread Mikko Perttunen
On 20.04.2017 11:25, Arnd Bergmann wrote: On Thu, Apr 20, 2017 at 9:02 AM, Mikko Perttunen wrote: On 19.04.2017 21:24, Arnd Bergmann wrote: When dma_addr_t and phys_addr_t are not the same size, we get a warning from the dma_alloc_wc function: drivers/gpu/host1x/cdma.c: In function

Re: [PATCH] [RFC] gpu: host1x: shut up warning about DMA API misuse

2017-04-20 Thread Mikko Perttunen
On 20.04.2017 13:02, Arnd Bergmann wrote: On Thu, Apr 20, 2017 at 11:44 AM, Mikko Perttunen wrote: On 20.04.2017 11:25, Arnd Bergmann wrote: On Thu, Apr 20, 2017 at 9:02 AM, Mikko Perttunen wrote: On 19.04.2017 21:24, Arnd Bergmann wrote: I don't think this can be a per-platform p

[PATCH 1/3] cpufreq: Add Tegra186 cpufreq driver

2017-04-03 Thread Mikko Perttunen
can be set individually; however, this is just a hint as all CPUs in a cluster will run at the maximum rate of non-idle CPUs in the cluster. Signed-off-by: Mikko Perttunen --- drivers/cpufreq/Kconfig.arm| 7 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/tegra186

[PATCH 3/3] arm64: tegra: Add CCPLEX_CLUSTER area in Tegra186

2017-04-03 Thread Mikko Perttunen
The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b

[PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

2017-04-03 Thread Mikko Perttunen
The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644

Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

2017-04-03 Thread Mikko Perttunen
On 04/03/2017 05:06 PM, Thierry Reding wrote: On Mon, Apr 03, 2017 at 03:42:24PM +0300, Mikko Perttunen wrote: The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- .../arm/tegra/nvidia,tegra186

Re: [PATCH 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

2017-04-03 Thread Mikko Perttunen
On 04/03/2017 05:24 PM, Jon Hunter wrote: On 03/04/17 13:42, Mikko Perttunen wrote: The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt | 22

Re: [PATCH 1/3] cpufreq: Add Tegra186 cpufreq driver

2017-04-03 Thread Mikko Perttunen
On 04/03/2017 05:47 PM, Thierry Reding wrote: On Mon, Apr 03, 2017 at 03:42:23PM +0300, Mikko Perttunen wrote: Add a new cpufreq driver for Tegra186 (and likely later). The CPUs are organized into two clusters, Denver and A57, with two and four cores respectively. CPU frequency can be adjusted

[PATCH v2 2/3] dt-bindings: Add bindings for nvidia,tegra186-ccplex-cluster

2017-04-04 Thread Mikko Perttunen
The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- v2: - Only one regs entry. - s/Phandle/phandle/ .../arm/tegra/nvidia,tegra186-ccplex-cluster.txt| 17 + 1 file changed

[PATCH v2 3/3] arm64: tegra: Add CCPLEX_CLUSTER area in Tegra186

2017-04-04 Thread Mikko Perttunen
The Tegra186 CCPLEX_CLUSTER area contains memory-mapped registers that initiate CPU frequency/voltage transitions. Signed-off-by: Mikko Perttunen --- v2: - Only one regs entry arch/arm64/boot/dts/nvidia/tegra186.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot

[PATCH v2 1/3] cpufreq: Add Tegra186 cpufreq driver

2017-04-04 Thread Mikko Perttunen
can be set individually; however, this is just a hint as all CPUs in a cluster will run at the maximum rate of non-idle CPUs in the cluster. Signed-off-by: Mikko Perttunen --- v2: - Many cosmetic / restructuring changes - Only one aperture read from DT now, with a new structure containing the

Re: linux-next: build failure after merge of the tip tree

2017-04-05 Thread Mikko Perttunen
On 05.04.2017 06:36, Stephen Rothwell wrote: Hi all, After merging the tip tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/gpu/built-in.o:(__tracepoints+0x64): multiple definition of `__tracepoint_remove_device_from_group' drivers/iommu/built-in.o:(__tracepoin

[PATCH] fixup! gpu: host1x: Add IOMMU support

2017-04-05 Thread Mikko Perttunen
Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c index f8fda446a6a6..f05ebb14fa63 100644 --- a/drivers/gpu/host1x/dev.c +++ b/drivers/gpu/host1x/dev.c @@ -27,6 +27,7 @@ #define

[PATCH] irqchip/gic: Don't write to GICD_ICFGR0

2017-04-06 Thread Mikko Perttunen
From: Matt Craighead According to the GICv2 specification, the GICD_ICFGR0, or GIC_DIST_CONFIG[0] register is read-only. Therefore avoid writing to it. Signed-off-by: Matt Craighead [mperttu...@nvidia.com: commit message rewritten] Signed-off-by: Mikko Perttunen --- drivers/irqchip/irq-gic.c

Re: [PATCH] irqchip/gic: Don't write to GICD_ICFGR0

2017-04-06 Thread Mikko Perttunen
On 06.04.2017 12:26, Marc Zyngier wrote: On 06/04/17 09:17, Mikko Perttunen wrote: From: Matt Craighead According to the GICv2 specification, the GICD_ICFGR0, or GIC_DIST_CONFIG[0] register is read-only. Therefore avoid writing to it. Have you verified that this also applies to pre-v2 GICs

Re: [PATCH] irqchip/gic: Don't write to GICD_ICFGR0

2017-04-10 Thread Mikko Perttunen
On 07.04.2017 10:32, Marc Zyngier wrote: On 07/04/17 07:49, Mikko Perttunen wrote: On 06.04.2017 12:26, Marc Zyngier wrote: On 06/04/17 09:17, Mikko Perttunen wrote: From: Matt Craighead According to the GICv2 specification, the GICD_ICFGR0, or GIC_DIST_CONFIG[0] register is read-only

Re: [PATCH v2 1/3] cpufreq: Add Tegra186 cpufreq driver

2017-04-10 Thread Mikko Perttunen
On 04/11/2017 09:35 AM, Viresh Kumar wrote: On 04-04-17, 16:43, Mikko Perttunen wrote: Add a new cpufreq driver for Tegra186 (and likely later). The CPUs are organized into two clusters, Denver and A57, with two and four cores respectively. CPU frequency can be adjusted by writing the desired

[PATCH v3 1/3] cpufreq: Add Tegra186 cpufreq driver

2017-04-11 Thread Mikko Perttunen
can be set individually; however, this is just a hint as all CPUs in a cluster will run at the maximum rate of non-idle CPUs in the cluster. Signed-off-by: Mikko Perttunen Acked-by: Viresh Kumar --- v3: - Fixed size parameter of dma_free_coherent drivers/cpufreq/Kconfig.arm| 6

Re: [PATCH] gpu: host1x: Fix error handling

2017-04-11 Thread Mikko Perttunen
v_err(&pdev->dev, "failed to get reset: %d\n", err); return err; } Reviewed-by: Mikko Perttunen

Re: [PATCH 4/4] thermal: Add Tegra BPMP thermal sensor driver

2017-07-10 Thread Mikko Perttunen
On 01.07.2017 05:53, Eduardo Valentin wrote: Hey Mikko, Sorry for the late answer, Likewise, On Fri, Jun 16, 2017 at 02:28:25PM +0300, Mikko Perttunen wrote: On Tegra186, the BPMP (Boot and Power Management Processor) exposes an interface to thermal sensors on the system-on-chip. This

Re: [PATCH 1/4] arm64: tegra: Add BPMP thermal sensor to Tegra186

2017-07-10 Thread Mikko Perttunen
On 01.07.2017 02:56, Eduardo Valentin wrote: On Fri, Jun 16, 2017 at 02:28:22PM +0300, Mikko Perttunen wrote: This adds the thermal sensor device provided by the BPMP, and the relevant thermal sensors to the Tegra186 device tree. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia

Re: [PATCH] gpu: host1x: Free the IOMMU domain when there is no device to attach

2017-07-10 Thread Mikko Perttunen
Thanks for the patch, didn't consider this case. I really need to get together some system to automatically test on multiple platforms.. :) Reviewed-by: Mikko Perttunen On 10.07.2017 22:33, Paul Kocialkowski wrote: When there is no device to attach to the IOMMU domain, as may be the

Re: [PATCH] gpu: host1x: Free the IOMMU domain when there is no device to attach

2017-07-11 Thread Mikko Perttunen
On 07/11/2017 05:44 PM, Paul Kocialkowski wrote: On Tue, 2017-07-11 at 14:37 +, Marcel Ziswiler wrote: On Tue, 2017-07-11 at 11:49 +0300, Paul Kocialkowski wrote: On Mon, 2017-07-10 at 21:33 +0200, Paul Kocialkowski wrote: When there is no device to attach to the IOMMU domain, as may be th

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-02-20 Thread Mikko Perttunen
AIUI, the PWM framework already exposes a sysfs node with period information. We should just use that instead of adding a new driver for this. In any case, we cannot add something like this to device tree since it's not a hardware device. Mikko On 21.02.2018 08:58, Rajkumar Rampelli wrote:

Re: [PATCH 05/10] hwmon: generic-pwm-tachometer: Add generic PWM based tachometer

2018-02-21 Thread Mikko Perttunen
On 21.02.2018 16:46, Guenter Roeck wrote: On 02/20/2018 11:15 PM, Mikko Perttunen wrote: AIUI, the PWM framework already exposes a sysfs node with period information. We should just use that instead of adding a new driver for this. I am kind of lost. Please explain. Are you saying that we

Re: [PATCH] cpufreq: tegra186: Break after initialization is done for policy->cpu

2018-02-22 Thread Mikko Perttunen
->driver_data = data->regs + info->offset + EDVD_CORE_VOLT_FREQ(core); cpufreq_table_validate_and_show(policy, cluster->table); + break; } policy->cpuinfo.transition_latency = 300 * 1000; Reviewed-by: Mikko Perttunen

Re: [PATCH v2 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-14 Thread Mikko Perttunen
On 07.02.2018 12:21, Marc Zyngier wrote: Hi Mikko, On 06/02/18 07:22, Mikko Perttunen wrote: Add the chip-level device tree, including binding headers, for the NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices are initially available, enough to boot to UA

Re: [PATCH v2 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-14 Thread Mikko Perttunen
On 10.02.2018 00:54, Rob Herring wrote: On Tue, Feb 06, 2018 at 09:22:36AM +0200, Mikko Perttunen wrote: ... index ..dcc6eea52684 --- /dev/null +++ b/include/dt-bindings/clock/tegra194-clock.h @@ -0,0 +1,664 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2018

[PATCH v3 3/7] soc/tegra: pmc: Add Tegra194 compatibility string

2018-02-15 Thread Mikko Perttunen
The Tegra194 PMC is mostly compatible with Tegra186, including in all currently supported features. As such, add a new compatibility string but point to the existing Tegra186 SoC data for now. Signed-off-by: Mikko Perttunen --- drivers/soc/tegra/pmc.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v3 7/7] arm64: tegra: Add device tree for the Tegra194 P2972-0000 board

2018-02-15 Thread Mikko Perttunen
Add device tree files for the Tegra194 P2972- development board. The board consists of the P2888 compute module and the P2822 baseboard. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/Makefile| 1 + arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 248

[PATCH v3 5/7] dt-bindings: tegra: Add documentation for nvidia,tegra194-pmc

2018-02-15 Thread Mikko Perttunen
The Tegra194 power management controller has one additional register aperture to be specified in the device tree node. Signed-off-by: Mikko Perttunen Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-15 Thread Mikko Perttunen
Add the chip-level device tree, including binding headers, for the NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices are initially available, enough to boot to UART console. Signed-off-by: Mikko Perttunen --- Notes: v3: - added hypervisor-related apertu

[PATCH v3 0/7] Initial support for NVIDIA Tegra194

2018-02-15 Thread Mikko Perttunen
red in the BPMP driver to support the new channel layout in Tegra194. The series has been tested on Tegra186 (Jetson TX2) and Tegra194 (P2972). Cheers, Mikko Mikko Perttunen (7): firmware: tegra: Simplify channel management soc/tegra: Add Tegra194 SoC configuration option soc/tegra: pmc: Ad

[PATCH v3 1/7] firmware: tegra: Simplify channel management

2018-02-15 Thread Mikko Perttunen
channel are supported, and channels are not required to be placed contiguously in memory. The same configuration also works on T186 so we end up with less code. Signed-off-by: Mikko Perttunen --- drivers/firmware/tegra/bpmp.c | 142 +++--- include/soc/tegra

[PATCH v3 4/7] dt-bindings: tegra: Add missing chips and NVIDIA boards

2018-02-15 Thread Mikko Perttunen
Add compatibility strings for supported but undocumented Tegra chips (Tegra114/124/132/210/186/194) and reference boards. Signed-off-by: Mikko Perttunen Reviewed-by: Rob Herring --- Notes: v2: - add patch Documentation/devicetree/bindings/arm/tegra.txt | 16 1 file

[PATCH v3 2/7] soc/tegra: Add Tegra194 SoC configuration option

2018-02-15 Thread Mikko Perttunen
Add the configuration option to enable support for the Tegra194 system-on-chip, and enable it by default in the arm64 defconfig. Signed-off-by: Mikko Perttunen --- arch/arm64/configs/defconfig | 1 + drivers/soc/tegra/Kconfig| 10 ++ 2 files changed, 11 insertions(+) diff --git a

Re: [PATCH v2 4/7] dt-bindings: tegra: Add missing chips and NVIDIA boards

2018-02-10 Thread Mikko Perttunen
On 02/10/2018 12:49 AM, Rob Herring wrote: On Tue, Feb 06, 2018 at 09:22:34AM +0200, Mikko Perttunen wrote: Add compatibility strings for supported but undocumented Tegra chips (Tegra114/124/132/210/186/194) and reference boards. Signed-off-by: Mikko Perttunen --- Notes: v2: - add

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-19 Thread Mikko Perttunen
On 16.02.2018 14:33, Philippe Ombredanne wrote: Mikko, On Thu, Feb 15, 2018 at 3:52 PM, Mikko Perttunen wrote: Add the chip-level device tree, including binding headers, for the NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices are initially available, enough

[PATCH v4 1/7] firmware: tegra: Simplify channel management

2018-02-20 Thread Mikko Perttunen
channel are supported, and channels are not required to be placed contiguously in memory. The same configuration also works on T186 so we end up with less code. Signed-off-by: Mikko Perttunen --- drivers/firmware/tegra/bpmp.c | 142 +++--- include/soc/tegra

[PATCH v4 0/7] Initial support for NVIDIA Tegra194

2018-02-20 Thread Mikko Perttunen
red in the BPMP driver to support the new channel layout in Tegra194. The series has been tested on Tegra186 (Jetson TX2) and Tegra194 (P2972). Cheers, Mikko Mikko Perttunen (7): firmware: tegra: Simplify channel management soc/tegra: Add Tegra194 SoC configuration option soc/tegra: pmc: Ad

[PATCH v4 7/7] arm64: tegra: Add device tree for the Tegra194 P2972-0000 board

2018-02-20 Thread Mikko Perttunen
Add device tree files for the Tegra194 P2972- development board. The board consists of the P2888 compute module and the P2822 baseboard. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/Makefile| 1 + arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 248

[PATCH v4 3/7] soc/tegra: pmc: Add Tegra194 compatibility string

2018-02-20 Thread Mikko Perttunen
The Tegra194 PMC is mostly compatible with Tegra186, including in all currently supported features. As such, add a new compatibility string but point to the existing Tegra186 SoC data for now. Signed-off-by: Mikko Perttunen --- drivers/soc/tegra/pmc.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v4 5/7] dt-bindings: tegra: Add documentation for nvidia,tegra194-pmc

2018-02-20 Thread Mikko Perttunen
The Tegra194 power management controller has one additional register aperture to be specified in the device tree node. Signed-off-by: Mikko Perttunen Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v4 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-20 Thread Mikko Perttunen
Add the chip-level device tree, including binding headers, for the NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices are initially available, enough to boot to UART console. Signed-off-by: Mikko Perttunen --- Notes: v4: - fixed copyright headers ac

[PATCH v4 4/7] dt-bindings: tegra: Add missing chips and NVIDIA boards

2018-02-20 Thread Mikko Perttunen
Add compatibility strings for supported but undocumented Tegra chips (Tegra114/124/132/210/186/194) and reference boards. Signed-off-by: Mikko Perttunen Reviewed-by: Rob Herring --- Notes: v2: - add patch Documentation/devicetree/bindings/arm/tegra.txt | 16 1 file

[PATCH v4 2/7] soc/tegra: Add Tegra194 SoC configuration option

2018-02-20 Thread Mikko Perttunen
Add the configuration option to enable support for the Tegra194 system-on-chip, and enable it by default in the arm64 defconfig. Signed-off-by: Mikko Perttunen --- arch/arm64/configs/defconfig | 1 + drivers/soc/tegra/Kconfig| 10 ++ 2 files changed, 11 insertions(+) diff --git a

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-30 Thread Mikko Perttunen
FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can instead implement the determine_rate callback.

[PATCH v2 2/7] soc/tegra: Add Tegra194 SoC configuration option

2018-02-05 Thread Mikko Perttunen
Add the configuration option to enable support for the Tegra194 system-on-chip, and enable it by default in the arm64 defconfig. Signed-off-by: Mikko Perttunen --- arch/arm64/configs/defconfig | 1 + drivers/soc/tegra/Kconfig| 10 ++ 2 files changed, 11 insertions(+) diff --git a

[PATCH v2 0/7] Initial support for NVIDIA Tegra194

2018-02-05 Thread Mikko Perttunen
red in the BPMP driver to support the new channel layout in Tegra194. The series has been tested on Tegra186 (Jetson TX2) and Tegra194 (P2972). Cheers, Mikko Mikko Perttunen (7): firmware: tegra: Simplify channel management soc/tegra: Add Tegra194 SoC configuration option soc/tegra: pmc: Ad

[PATCH v2 4/7] dt-bindings: tegra: Add missing chips and NVIDIA boards

2018-02-05 Thread Mikko Perttunen
Add compatibility strings for supported but undocumented Tegra chips (Tegra114/124/132/210/186/194) and reference boards. Signed-off-by: Mikko Perttunen --- Notes: v2: - add patch Documentation/devicetree/bindings/arm/tegra.txt | 16 1 file changed, 16 insertions

[PATCH v2 7/7] arm64: tegra: Add device tree for the Tegra194 P2972-0000 board

2018-02-05 Thread Mikko Perttunen
Add device tree files for the Tegra194 P2972- development board. The board consists of the P2888 compute module and the P2822 baseboard. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/Makefile| 1 + arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 248

[PATCH v2 3/7] soc/tegra: pmc: Add Tegra194 compatibility string

2018-02-05 Thread Mikko Perttunen
The Tegra194 PMC is mostly compatible with Tegra186, including in all currently supported features. As such, add a new compatibility string but point to the existing Tegra186 SoC data for now. Signed-off-by: Mikko Perttunen --- drivers/soc/tegra/pmc.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 1/7] firmware: tegra: Simplify channel management

2018-02-05 Thread Mikko Perttunen
channel are supported, and channels are not required to be placed contiguously in memory. The same configuration also works on T186 so we end up with less code. Signed-off-by: Mikko Perttunen --- drivers/firmware/tegra/bpmp.c | 142 +++--- include/soc/tegra

[PATCH v2 5/7] dt-bindings: tegra: Add documentation for nvidia,tegra194-pmc

2018-02-05 Thread Mikko Perttunen
The Tegra194 power management controller has one additional register aperture to be specified in the device tree node. Signed-off-by: Mikko Perttunen Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v2 6/7] arm64: tegra: Add Tegra194 chip device tree

2018-02-05 Thread Mikko Perttunen
Add the chip-level device tree, including binding headers, for the NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices are initially available, enough to boot to UART console. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra194.dtsi

Re: [PATCH] soc/tegra: pmc: fix child-node lookup

2017-11-16 Thread Mikko Perttunen
of_find_node_by_name() drops a reference to its first argument. Fixes: 3568df3d31d6 ("soc: tegra: Add thermal reset (thermtrip) support to PMC") Cc: stable # 4.0 Cc: Mikko Perttunen Signed-off-by: Johan Hovold --- drivers/soc/tegra/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 1/2] arm64: defconfig: Enable CONFIG_ARM_TEGRA186_CPUFREQ

2017-11-16 Thread Mikko Perttunen
Enable Tegra186 CPU frequency scaling support by default. Signed-off-by: Mikko Perttunen --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 6356c6da34ea..42711031a72d 100644 --- a/arch/arm64

[PATCH 2/2] arm64: defconfig: Enable CONFIG_TEGRA_BPMP_THERMAL

2017-11-16 Thread Mikko Perttunen
Enable Tegra BPMP thermal sensor support by default, built as a module. Signed-off-by: Mikko Perttunen --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 42711031a72d..d0f05da8baf9 100644 --- a

Re: [PATCH 04/10] gpu: host1x: Lock classes during job submission

2017-12-05 Thread Mikko Perttunen
On 07.11.2017 23:23, Dmitry Osipenko wrote: On 07.11.2017 15:28, Mikko Perttunen wrote: On 05.11.2017 18:46, Dmitry Osipenko wrote: On 05.11.2017 14:01, Mikko Perttunen wrote: ... +static int mlock_id_for_class(unsigned int class) +{ +#if HOST1X_HW >= 6 +switch (class) +{ +c

Re: [tegra186]: emmc resume failing after booting from snapshot image

2017-11-22 Thread Mikko Perttunen
The upstream kernel currently has no core rail suspend support (LP0/SC7) on Tegras - in general the downstream kernel (used e.g. in L4T) is the reference that has the most functionality on Tegra. IIRC the MMC subsystem and Tegra MMC driver between upstream and downstream are currently quite di

[PATCH v2 0/6] Miscellaneous improvements to Host1x and TegraDRM

2017-09-05 Thread Mikko Perttunen
tested on TX1 and TX2 and should be applied on the previously posted Tegra186 support series. Cheers, Mikko Mikko Perttunen (6): gpu: host1x: Enable Tegra186 syncpoint protection gpu: host1x: Enable gather filter gpu: host1x: Improve debug disassembly formatting gpu: host1x: Disassemble more

[PATCH v2 6/6] drm/tegra: Use u64_to_user_ptr helper

2017-09-05 Thread Mikko Perttunen
Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values to user pointers instead of writing out the cast manually. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu

[PATCH v2 5/6] gpu: host1x: Fix incorrect comment for channel_request

2017-09-05 Thread Mikko Perttunen
This function actually doesn't sleep in the version that was merged. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c index db9b91d1384c..2fb93c2

[PATCH v2 2/6] gpu: host1x: Enable gather filter

2017-09-05 Thread Mikko Perttunen
-off-by: Mikko Perttunen Reviewed-by: Dmitry Osipenko --- drivers/gpu/host1x/hw/channel_hw.c | 22 ++ drivers/gpu/host1x/hw/hw_host1x04_channel.h | 12 drivers/gpu/host1x/hw/hw_host1x05_channel.h | 12 3 files changed, 46 insertions(+) diff

[PATCH v2 4/6] gpu: host1x: Disassemble more instructions

2017-09-05 Thread Mikko Perttunen
The disassembler for debug dumps was missing some newer host1x opcodes. Add disassembly support for these. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/hw/debug_hw.c | 57 --- drivers/gpu/host1x/hw/debug_hw_1x01.c | 3 +- drivers/gpu/host1x/hw

[PATCH v2 1/6] gpu: host1x: Enable Tegra186 syncpoint protection

2017-09-05 Thread Mikko Perttunen
since that would require extra work and is unnecessary with the current channel allocation model. Signed-off-by: Mikko Perttunen --- Notes: v2: - Changed from set_protection(bool) to enable_protection - Added some comments - Added missing check for hv_regs being NULL in

[PATCH v2 3/6] gpu: host1x: Improve debug disassembly formatting

2017-09-05 Thread Mikko Perttunen
y newlines and by fixing other small issues. Signed-off-by: Mikko Perttunen Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- This uses pr_cont, which there are currently talks of being replaced with something better. I kept using it here for now until there is some conclusion of what&

[PATCH v2 5/6] gpu: host1x: Add Tegra186 support

2017-09-05 Thread Mikko Perttunen
this commit. Signed-off-by: Mikko Perttunen Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/gpu/host1x/Makefile| 3 +- drivers/gpu/host1x/dev.c | 60 +++- drivers/gpu/host1x/dev.h | 4 + drivers/gpu/host1x

[PATCH v2 4/6] dt-bindings: host1x: Add Tegra186 information

2017-09-05 Thread Mikko Perttunen
Add the Tegra186-specific hypervisor-related register range properties. Signed-off-by: Mikko Perttunen --- v2: - Dropped incorrect note about cells properties. .../devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt | 4 1 file changed, 4 insertions(+) diff --git a

[PATCH v2 2/6] arm64: tegra: Add host1x on Tegra186

2017-09-05 Thread Mikko Perttunen
Add the node for Host1x on the Tegra186, without any subdevices for now. Signed-off-by: Mikko Perttunen --- v2: - Changed address-cells and size-cells to 1 and fixed the ranges property correspondingly. arch/arm64/boot/dts/nvidia/tegra186.dtsi | 18 ++ 1 file changed, 18

[PATCH v2 6/6] drm/tegra: Add Tegra186 support for VIC

2017-09-05 Thread Mikko Perttunen
Add Tegra186 support for VIC - no changes are required except for new firmware and compatibility string. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 1 + drivers/gpu/drm/tegra/vic.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/tegra

[PATCH v2 1/6] arm64: tegra: Add #power-domain-cells for BPMP

2017-09-05 Thread Mikko Perttunen
Add #power-domain-cells for the BPMP node on Tegra186 so that the power domain provider may be used. Signed-off-by: Mikko Perttunen --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts

[PATCH v2 3/6] arm64: tegra: Add VIC on Tegra186

2017-09-05 Thread Mikko Perttunen
Add a node for the Video Image Compositor on the Tegra186. Signed-off-by: Mikko Perttunen --- v2: - Fixed reg property in accordance with changed parent cells. arch/arm64/boot/dts/nvidia/tegra186.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/nvidia

[PATCH v2 0/6] Host1x and VIC support for Tegra186

2017-09-05 Thread Mikko Perttunen
. The series has been tested on the Jetson TX1 (T210) and TX2 (T186) using the host1x_test test suite available at http://github.com/cyndis/host1x_test The series itself is available at http://github.com/cyndis/linux, branch host1x-t186-1 Cheers, Mikko Mikko Perttunen (6): arm64: tegra: Add

Re: [PATCH v2 0/6] Host1x and VIC support for Tegra186

2017-09-05 Thread Mikko Perttunen
On 05.09.2017 14:10, Daniel Vetter wrote: Since this is new hw support, is there also open source userspace using all this? The VIC HW in Tegra186 is backwards compatible with the one in Tegra210, which has open userspace (https://github.com/cyndis/vaapi-tegra-driver), so that userspace shou

[PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-18 Thread Mikko Perttunen
since that would require extra work and is unnecessary with the current channel allocation model. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.h | 16 drivers/gpu/host1x/hw/channel_hw.c | 3 +++ drivers/gpu/host1x/hw/syncpt_hw.c | 26

[PATCH 0/4] Miscellaneous improvements to Host1x and TegraDRM

2017-08-18 Thread Mikko Perttunen
to the TegraDRM submit path. Everything was tested on TX1 and TX2 and should be applied on the previously posted Tegra186 support series. Cheers, Mikko *** BLURB HERE *** Mikko Perttunen (4): gpu: host1x: Enable Tegra186 syncpoint protection gpu: host1x: Enable gather filter gpu: host1x

[PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper

2017-08-18 Thread Mikko Perttunen
Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values to user pointers instead of writing out the cast manually. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra

[PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-18 Thread Mikko Perttunen
-off-by: Mikko Perttunen --- drivers/gpu/host1x/hw/channel_hw.c | 22 ++ drivers/gpu/host1x/hw/hw_host1x04_channel.h | 12 drivers/gpu/host1x/hw/hw_host1x05_channel.h | 12 3 files changed, 46 insertions(+) diff --git a/drivers/gpu/host1x/hw

[PATCH 3/4] gpu: host1x: Improve debug disassembly formatting

2017-08-18 Thread Mikko Perttunen
y newlines and by fixing other small issues. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/debug.c| 14 ++- drivers/gpu/host1x/debug.h| 14 --- drivers/gpu/host1x/hw/debug_hw.c | 46 ++- drivers/gpu/host1x/hw/debug

Re: [PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper

2017-08-19 Thread Mikko Perttunen
On 08/19/2017 01:05 AM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values to user pointers instead of writing out the cast manually. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 9

Re: [PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-19 Thread Mikko Perttunen
On 08/19/2017 01:36 AM, Dmitry Osipenko wrote: On 18.08.2017 19:15, Mikko Perttunen wrote: Since Tegra186 the Host1x hardware allows syncpoints to be assigned to specific channels, preventing any other channels from incrementing them. Enable this feature where available and assign syncpoints

<    1   2   3   4   5   6   7   >