Hi Thomas,
Thanks you very much for your time and reply.
On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
On Wed, 30 May 2018, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode.
rtc_resume() injects
from the structure and its usage.
Signed-off-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
---
kernel/cpu.c | 25 -
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index ed44d7d..c544baf 100644
--- a/kernel/cpu.c
+++ b
Hi All,
This is about one of field in struct cpuhp_step
* @skip_onerr: Do not invoke the functions on error rollback
* Will go away once the notifiers are gone
bool skip_onerr;
Why this field was introduced, can anyone explain the history behind ?
As i
On 8/21/2018 7:27 PM, Thomas Gleixner wrote:
On Tue, 21 Aug 2018, Mukesh Ojha wrote:
Hi All,
This is about one of field in struct cpuhp_step
* @skip_onerr: Do not invoke the functions on error rollback
* Will go away once the notifiers are gone
bool
When notifier converted to state-machine in hotplug, we missed to
remove header file from some of the files.
So, Remove it with this.
Signed-off-by: Mukesh Ojha
---
fs/buffer.c| 1 -
kernel/printk/printk.c | 1 -
lib/percpu_counter.c | 1 -
mm/page-writeback.c| 1 -
mm
Hi All,
Can i get input on this ?
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
On 7/30/2018 5:49 PM, Thomas Gleixner wrote:
Mukesh,
On Thu, 26 Jul 2018, Mukesh Ojha wrote:
Hi All,
Can i get input on this ?
Sure.
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
The input you get is that it's unprofessional to poke people after TWO days
about a patch
Adding stable and lkml.
Sorry for spam others.
-Mukesh
On 7/23/2018 1:57 PM, Mukesh Ojha wrote:
Hi All,
I wanted to discuss about one of the corner case exists in 4.9 kernel
(4.9.x) where
If hotplug of one of the CPU fails due to failure in one of the callback,
which is to be called after
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to invalid. So, better to name it as
"timers:prepare".
Signed-o
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead"
for timer looks to be invalid. So, better to name it as
"timers:prepare".
Hi All,
Please review V2 where i will be updating(minor) commit text.
Thanks.
Mukesh
On 7/24/2018 8:07 PM, Mukesh Ojha wrote:
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases
on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE
instead of CPUHP_TIMERS_DEAD the
Hi John,
Thanks for your response
Please find my comments inline.
On 7/11/2018 1:43 AM, John Stultz wrote:
On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote:
Currently, there exists a corner case assuming when there is
only one clocksource e.g RTC, and system failed to go to
suspend mode
Sparse reports the current declaration of percpu variable with
below warning
warning: incorrect type in initializer (different address spaces)
expected void const [noderef] *__vpp_verify
got struct perf_cpu_context *
Fix it by declaring it properly.
Signed-off-by: Mukesh Ojha
Hi All,
Can you please review the change ?
Thanks,
Mukesh
On 11/27/2018 2:43 PM, Mukesh Ojha wrote:
Sparse reports the current declaration of percpu variable with
below warning
warning: incorrect type in initializer (different address spaces)
expected void const [noderef
Hi John,
On 5/30/2018 7:50 AM, John Stultz wrote:
On Tue, May 29, 2018 at 2:49 AM, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode
rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume
=>
rtc_resume()
Failure case:
{failure in sleep path} {sleeptime_injected=false}
rtc_suspend() =>rtc_resume()
Signed-off-by: Mukesh Ojha
---
Changes in v2:
* Updated the commit text.
* Removed extra variable and used the earl
Hi Thomas,
Could you raise a formal patch on this as you are the author now?
Thanks,
Mukesh
On 6/25/2018 8:34 PM, Thomas Gleixner wrote:
On Mon, 25 Jun 2018, Mukesh Ojha wrote:
On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
@@ -1671,7 +1685,6 @@ void timekeeping_resume(void)
struct
nd failed)
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in v3:
* Updated commit subject and description.
* Updated the patch as per the fix given by Thomas Gleixner.
Changes in v2:
* Updated the commit text.
* Removed extra variable and used the earl
Any input on this ?
Thanks,
Mukesh
On 5/30/2018 5:14 PM, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode.
rtc_resume() injects the sleeptime as timekeeping_rtc_skipresume()
returned '
Hi Al Viro,
Is there is reason we have kept data->found++, if the dentry already
there in shrink list ?
static enum d_walk_ret select_collect(
...
if (dentry->d_flags & DCACHE_SHRINK_LIST) {
data->found++;
} else {
..
If the dentry is already there on shrink
On 8/17/2018 6:28 PM, Al Viro wrote:
On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
Hi Al Viro,
Is there is reason we have kept data->found++, if the dentry already there
in shrink list ?
static enum d_walk_ret select_collect(
...
if (dentry->d
On 12/14/2018 12:34 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyung Kim
---
block/partitions/osf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index 4b87
Please read the guideline as well before sending patch.
you need to maintain patchset version as well, e.g: in which patchset
what is changed on whose comments.
-Mukesh
On 12/14/2018 3:49 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyu
On 7/13/2018 10:50 PM, John Stultz wrote:
On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha wrote:
Hi John,
Thanks for your response
Please find my comments inline.
On 7/11/2018 1:43 AM, John Stultz wrote:
On Fri, Jul 6, 2018 at 6:17 AM, Mukesh Ojha wrote:
Currently, there exists a corner
On 7/16/2018 10:44 PM, John Stultz wrote:
On Mon, Jul 16, 2018 at 9:30 AM, John Stultz wrote:
On Mon, Jul 16, 2018 at 9:17 AM, Mukesh Ojha wrote:
On 7/13/2018 10:50 PM, John Stultz wrote:
On Fri, Jul 13, 2018 at 12:13 AM, Mukesh Ojha
On 7/11/2018 1:43 AM, John Stultz wrote:
I worry
nd failed)
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in V4:
* Changes as suggested by John
- Changed the variable name from sleeptime_injected to suspend_timing_needed
- Changed the boolean logic.
Changes in v3:
* Updated commit subject and description.
* Up
On 7/17/2018 2:20 AM, Thomas Gleixner wrote:
On Tue, 17 Jul 2018, Mukesh Ojha wrote:
@@ -102,7 +102,7 @@ static int rtc_resume(struct device *dev)
struct timespec64 sleep_time;
int err;
- if (timekeeping_rtc_skipresume())
+ if (!timekeeping_rtc_skipresume
On 7/17/2018 2:31 AM, John Stultz wrote:
On Mon, Jul 16, 2018 at 1:40 PM, Mukesh Ojha wrote:
Currently, there exists a corner case assuming when there is
only one clocksource e.g RTC, and system failed to go to
suspend mode. While resume rtc_resume() injects the sleeptime
as
operly.
Originally-by: Thomas Gleixner
Signed-off-by: Mukesh Ojha
---
Changes in V5:
* Took extra variable `inject_sleeptime` to take care of injecting sleeptime
inside timekeeping_resume().
* Inverted the return logic inside timekeeping_skipresume() instead of doing
it in rtc_resume().
* Upda
= &sm8550_cdsp_resource},
{ .compatible = "qcom,sm8550-mpss-pas", .data = &sm8550_mpss_resource},
+ { .compatible = "qcom,sm8650-adsp-pas", .data = &sm8550_adsp_resource},
Same as sm8550;
+ { .compatible = "qcom,sm8650-cdsp-pas", .data = &sm8650_cdsp_resource},
+ { .compatible = "qcom,sm8650-mpss-pas", .data = &sm8650_mpss_resource},
LGTM,
Acked-by: Mukesh Ojha
-Mukesh
{ },
};
MODULE_DEVICE_TABLE(of, adsp_of_match);
On 1/23/2024 2:21 PM, Neil Armstrong wrote:
The qlink_logging memory region is also used by the modem firmware,
add it to the reserved memories and add it to the MPSS memory regions.
Signed-off-by: Neil Armstrong
LGTM,
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/arm64/boot/dts/qcom
idump() functionality from
driver/remoteproc/qcom_common.c into a separate file under
qcom_rproc_minidump().
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Added source file driver/remoteproc/qcom_common.c copyright
to qcom_rproc_minidump.c
- Dissociated it from minidump series as this can go separ
s use qcom_rproc_minidump() and
we will be removing qcom_minidump() and minidump related stuff
from driver/remoteproc/qcom_common.c .
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Change in patch order from its last version.
- Rebased it.
v8: https://lore.kernel.org/lkml/20240131105734.13090-1-qu
As minidump specific data structure and functions move under
config QCOM_RPROC_MINIDUMP, so remove minidump specific data
from driver/remoteproc/qcom_common.c .
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Change in patch order.
- rebased it.
v8: https://lore.kernel.org/lkml
Gentle ping..
-Mukesh
On 3/26/2024 7:43 PM, Mukesh Ojha wrote:
Add qcom_rproc_minidump module in a preparation to remove
minidump specific code from driver/remoteproc/qcom_common.c
and provide needed exported API, this as well helps to
abstract minidump specific data layout from qualcomm&#
. Guards the qcom_minidump() with CONFIG_QCOM_RPROC_MINIDUMP.
3. Selects this QCOM_RPROC_MINIDUMP config when QCOM_RPROC_COMMON
enabled.
4. Added new header qcom_minidump.h .
Signed-off-by: Mukesh Ojha
---
Changes in v10:
- Converted all 3 changes sent in v9 to a single to properly
reflect
On 4/30/2024 7:08 PM, Bjorn Andersson wrote:
On Tue, Mar 26, 2024 at 07:43:12PM +0530, Mukesh Ojha wrote:
Add qcom_rproc_minidump module in a preparation to remove
minidump specific code from driver/remoteproc/qcom_common.c
and provide needed exported API, this as well helps to
abstract
ize - len);
Although, it does not make any difference apart from a write of len
bytes, still a good improvement to do ..
Acked-by: Mukesh Ojha
-Mukesh
handler(scp->share_buf, len, ipi_desc[id].priv);
scp_ipi_unlock(scp, id);
eptdev'
drivers/rpmsg/rpmsg_char.c:75: warning: Function parameter or struct member
'remote_flow_updated' not described in 'rpmsg_eptdev'
Fixes: 5550201c0fe2 ("rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support")
Signed-off-by: Arnaud Pouliquen
Reviewed-by: Mukesh Ojha
-Mukesh
c-95f-1117-706c2c22...@inria.fr/
Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reported-by: Julia Lawall
Signed-off-by: Steven Rostedt (Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 3 ++-
1 file changed, 2 inser
=6939
Signed-off-by: Jiapeng Chong
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 1ccd100bc565..ba9d1cb0d24c 100644
--- a/fs/tracefs/event_inode.c
n., Thanks.
Reviewed-by: Mukesh ojha
-Mukesh
-
if (file) {
call = file->event_call;
system = call->class->system;
ostedt (Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 298d3ecaf621..64fde9490f52 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -37,7
ctions")
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202310190437.pai6lyjf-...@intel.com/
Signed-off-by: Yujie Liu
Not related to this patch, but I see order of the argument as well is
not proper in the document of the __kprobe_event_gen_cmd_start(),
if you c
On 10/27/2023 7:50 PM, Luca Weiss wrote:
Add the node for the ADSP found on the SC7280 SoC, using standard
Qualcomm firmware.
The memory region for sc7280-chrome-common.dtsi is taken from msm-5.4
yupik.dtsi since the other areas also seem to match that file there,
though I cannot be sure ther
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports a single
memory region.
But new platforms introduces more regions to make the
memory requirements more flexible for various use cases.
Those new platforms also shares the memory region between the
DSP
eventfs: Remove eventfs_file and just use
eventfs_inode");
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202310052216.4sgqaswo-...@intel.com/
Signed-off-by: Steven Rostedt (Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 6 --
On 10/30/2023 8:33 PM, Doug Anderson wrote:
Hi,
On Mon, Oct 30, 2023 at 7:43 AM Luca Weiss wrote:
On Mon Oct 30, 2023 at 3:11 PM CET, Doug Anderson wrote:
Hi,
On Mon, Oct 30, 2023 at 2:12 AM Luca Weiss wrote:
On Mon Oct 30, 2023 at 10:04 AM CET, Mukesh Ojha wrote:
On 10/27/2023 7
const char *name, const char *loc, ...)
Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
Suggested-by: Mukesh Ojha
Signed-off-by: Yujie Liu
Thanks.
Reviewed-by: Mukesh Ojha
-Mukesh
---
kernel/trace/trace_kprobe.c | 2 +-
1 file changed, 1 insertion(+),
On 10/31/2023 10:36 PM, Neil Armstrong wrote:
Hi,
On 30/10/2023 14:10, Mukesh Ojha wrote:
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports a single
memory region.
But new platforms introduces more regions to make the
memory requirements more
On 11/2/2023 1:30 AM, Steven Rostedt wrote:
On Mon, 30 Oct 2023 21:57:13 +0530
Mukesh Ojha wrote:
On 10/30/2023 9:45 PM, Steven Rostedt wrote:
From: "Steven Rostedt (Google)"
The eventfs_remove_rec() had some missing parameters in the kerneldoc
comment above it. Also, re
On 11/2/2023 3:56 PM, neil.armstr...@linaro.org wrote:
On 01/11/2023 15:42, Mukesh Ojha wrote:
On 10/31/2023 10:36 PM, Neil Armstrong wrote:
Hi,
On 30/10/2023 14:10, Mukesh Ojha wrote:
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports a
ms[offset],
+ &perm, 1);
+ if (ret < 0)
+ dev_err(adsp->dev, "unassign memory failed\n");
In case you are going to send another version,
you can print offset similar to the assign call failure.,
Othe
On 12/18/2023 11:40 AM, Vignesh Viswanathan wrote:
q6v5 fatal and watchdog IRQ handlers always retrieves the crash reason
information from SMEM global partition (QCOM_SMEM_HOST_ANY).
For some targets like IPQ9574 and IPQ5332, crash reason information is
present in target specific partition du
tc_resume()
Change-Id: I98928761c98cec21a3033a55d3e10fb34138f38c
Signed-off-by: Mukesh Ojha
---
kernel/time/timekeeping.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 427e33d..c022d82 100644
--- a/kernel/time/timekeeping.c
+++ b/ker
On 5/29/2018 2:18 PM, Vinod Koul wrote:
On 29-05-18, 13:45, Mukesh Ojha wrote:
Currently, for both non-stop clocksource and persistent clock
there is a corner case, when a driver failed to go suspend mode
rtc_resume injects the sleeptime as timekeeping_rtc_skipresume
returned 'false&#x
esume()
Signed-off-by: Mukesh Ojha
---
Changes from Resend:
* updated commit text.
kernel/time/timekeeping.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 427e33d..c022d82 100644
--- a/kernel/ti
On 4/15/2019 4:07 PM, Colin King wrote:
From: Colin Ian King
Fix spelling mistakes in rx stats text. I missed these from an earlier
round of fixing the same spelling mistake.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/net/wireless/intel
On 4/15/2019 11:19 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a dev_error message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/comedi/drivers/adv_pci1710.c | 2 +-
1 file changed, 1 insertion
On 4/16/2019 4:42 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a FAIL message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
scripts/dtc/checks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On 4/16/2019 4:55 PM, Colin King wrote:
From: Colin Ian King
There are a couple of spelling mistakes, fix these.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
fs/reiserfs/lbalance.c | 2 +-
fs/reiserfs/namei.c| 2 +-
2 files changed, 2 insertions
On 4/16/2019 5:26 PM, Colin King wrote:
From: Colin Ian King
There are a few spelling mistakes in comments and a pr_err
error message. Fix these.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/clk/mvebu/common.c | 2 +-
drivers
On 4/16/2019 7:03 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/watchdog/intel_scu_watchdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 4/17/2019 4:25 PM, Colin King wrote:
From: Colin Ian King
There are a couple of spelling mistakes in test assert messages. Fix them.
Signed-off-by: Colin Ian King
Well, how are you shooting these mistakes one after the other?
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
tools
On 4/17/2019 5:38 PM, Colin King wrote:
From: Colin Ian King
There are two spelling mistake in RT_TRACE messages. Fix them.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 ++--
1 file changed, 2
On 4/17/2019 5:30 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in an RT_TRACE message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
1 file changed, 1 insertion
ssue in the function
stm_source_register_device. This patch fixes these issues.
Signed-off-by: Pan Bian
Looks good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/hwtracing/stm/core.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hwtrac
On 4/18/2019 3:45 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in the documentation. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
Documentation/ABI/testing/sysfs-devices-platform-ipmi | 2 +-
1 file changed, 1 insertion
On 4/18/2019 5:50 PM, Colin King wrote:
From: Colin Ian King
There are multiple spelling mistakes in variable names, fix these.
Signed-off-by: Colin Ian King
Well, this one a bit sensitive to touch.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/hal
On 4/24/2019 8:20 AM, YueHaibing wrote:
Remove duplicated include.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c
On 4/23/2019 4:36 PM, Al Viro wrote:
On Tue, Apr 23, 2019 at 08:49:44AM +, dmitry.torok...@gmail.com wrote:
On Tue, Apr 23, 2019 at 12:51:13PM +0530, Mukesh Ojha wrote:
I have taken care this case from ioctl and release point of view.
Even if the release gets called first it will make
On 4/24/2019 6:37 PM, Al Viro wrote:
On Wed, Apr 24, 2019 at 05:40:40PM +0530, Mukesh Ojha wrote:
Al,
i tried to put traceprintk inside ioctl after fdget and fdput on a simple
call of open => ioctl => close
in a loop, and multithreaded, presumably?
on /dev/uinput.
uinp
On 3/25/2019 11:07 PM, Steven Price wrote:
of_parse_phandle_with_args() requires the caller to call of_node_put() on
the returned args->np pointer. Otherwise the reference count will remain
incremented.
However, in this case, since we don't actually use the returned pointer,
we can simply pass
On 3/27/2019 5:23 AM, Huang Zijiang wrote:
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
Signed-off-by: Huang Zijiang
---
arch/arm/mach-socfpga/pm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Sparse complains yama_task_prctl can be static. Fix it by making
it static.
Signed-off-by: Mukesh Ojha
---
security/yama/yama_lsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 57cc607..9c5a15b 100644
--- a
On 3/23/2019 2:32 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
---
arch/sh/boards/mach-dreamcast/irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch
On 3/9/2019 10:49 AM, Kangjie Lu wrote:
get_skb may fail and return NULL. The fix returns "ENOMEM"
when it fails to avoid NULL dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
di
On 3/9/2019 10:49 AM, Kangjie Lu wrote:
get_skb may fail and return NULL. The fix returns "ENOMEM"
when it fails to avoid NULL dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh OJha
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
di
On 3/27/2019 4:38 AM, Jann Horn wrote:
sparse complains that Yama defines functions and a variable as non-static
even though they don't exist in any header. Fix it by making them static.
Signed-off-by: Jann Horn
Reviewed-by: Mukesh Ojha
---
security/yama/yama_lsm.c | 6 +++--
")
Signed-off-by: Fabrice Gasnier
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/iio/adc/Kconfig | 1 +
drivers/iio/adc/stm32-adc.c | 32 ++--
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kc
On 3/27/2019 6:21 PM, Mukesh Ojha wrote:
On 3/26/2019 6:14 PM, Fabrice Gasnier wrote:
Enabling CONFIG_DEBUG_ATOMIC_SLEEP=y triggers this BUG message:
BUG: sleeping function called from invalid context at
kernel/irq/chip.c...
Call stack is as follows:
- __might_sleep
- handle_nested_irq
On 3/26/2019 3:49 AM, Kangjie Lu wrote:
If __get_free_pages() fails, the patch returns -ENOMEM to avoid
NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
v3: remove "unlikely", as suggested by Bjorn Helgaas.
v2: caller is redefined to
ooks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..d2c5852a3c8d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2007,7 +2007,7 @@ F:drivers/i2c/busses/i2c-qup.c
F:d
On 3/26/2019 7:43 AM, Masahiro Yamada wrote:
The pattern drivers/dmaengine/uniphier-mdmac.c has no match in the
source tree.
The correct path is drivers/dma/uniphier-mdmac.c
Reported-by: Joe Perches
Signed-off-by: Masahiro Yamada
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS
ks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e17ebf7..403247d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7175,7 +7175,7 @@ F:drivers/net/hyperv/
F:drivers/sc
dereferences.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
removed "unlikely"
---
drivers/usb/host/u132-hcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index 934584f0a20a..6d5b532b03f8 100644
--- a/d
On 3/26/2019 11:58 AM, lantianyu1...@gmail.com wrote:
From: Lan Tianyu
The Hyperv vIOMMU file name should be "hyperv-iommu.c" rather
s/vIOMMU /IOMMU
than "hyperv_iommu.c". This patch is to fix it.
Signed-off-by: Lan Tianyu
Othewise looks fine.
Reviewed-by: M
Signed-off-by: Aditya Pakki
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: Move the signed by above the version change log
v1: A check is unnecessary as match is never used.
---
sound/soc/codecs/sirf-audio-codec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/codecs/
On 3/26/2019 2:55 AM, Aditya Pakki wrote:
uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error and cleans up the allocated memory for switch.
Signed-off-by: Aditya Pakki
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: replace WARN_ONCE with tb_sw_warn, as
or the return value of kzalloc,
which may lead to NULL-pointer dereference.
The patch fixes the two issues.
Signed-off-by: Kangjie Lu
Otherwise looks good.
Reviewed-by: Mukesh Ojha
-Mukesh
---
drivers/thunderbolt/property.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
uot;Add virtio gpu driver.")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: fix patch prefix
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c
b/drivers/gpu/drm/virtio/virtgpu_ttm.c
i
On 3/25/2019 4:13 AM, Kangjie Lu wrote:
When kzalloc fails, "platform_state->inited = 1" is a NULL pointer
dereference. The fix returns VCHIQ_ERROR in case it failed to
avoid NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Mukesh Ojha
-Mukesh
---
nused-but-set-parameter]
It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
asoc_simple_debug_info()"), so can be removed.
Signed-off-by: YueHaibing
Acked-by: Kuninori Morimoto
Reviewed-by: Mukesh Ojha
-Mukesh
---
v2: fix patch title
---
sound/soc/generic/
On 3/22/2019 7:34 PM, Yue Haibing wrote:
From: YueHaibing
Fix sparse warning:
security/selinux/hooks.c:3389:5: warning:
symbol 'selinux_kernfs_init_security' was not declared. Should it be static?
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
-Mukesh
---
securi
On 3/28/2019 12:41 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/arm/mach-sa1100/hackkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
utla Chandrasekhar
Please fix the commit text minor comments.
otherwise , looks good.
Reviewed-by: Mukesh Ojha
-Mukesh
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index edfcf8d982e4..1739d7e1952a 100644
--- a/drivers/base/arch_topology.c
+++ b/driver
On 3/28/2019 3:49 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
kernel/trace/trace.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel
On 3/28/2019 8:47 AM, Hariprasad Kelam wrote:
fix spelling mistake "overriden" -> "overridden"
This fix resolves warning reported by checkpatch tool.
Signed-off-by: Hariprasad Kelam
Reviewed-by: Mukesh Ojha
-Mukesh
---
Changes in V2:
-Make co
On 3/28/2019 3:19 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Reviewed-by: Mukesh Ojha
-Mukesh
---
tools/testing/selftests/powerpc/tm/tm-vmx-unavail.c | 1 -
1 file changed, 1 deletion
On 3/28/2019 2:58 AM, jagdsh.li...@gmail.com wrote:
From: Jagadeesh Pagadala
Remove duplicate header which is included twice.
Signed-off-by: Jagadeesh Pagadala
Looks good to me. but did you tested at least the compilation with these
patches ?
Reviewed-by: Mukesh Ojha
-Mukesh
1 - 100 of 366 matches
Mail list logo
