Some devices might not provide an interrupt line for the touchscreen.
In that case the driver defaults to using a polled interface.
Signed-off-by: Nicolas Saenz Julienne
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 8 ++--
1 file changed, 6 insertions(+), 2 deletions
the new runtime calculated min_mask*.
That's all.
Regards,
Nicolas
* These solutions where already discussed on the previous RFC (see link
above).
---
Nicolas Saenz Julienne (8):
arm64: mm: use arm64_dma_phys_limit instead of calling
max_zone_dma_phys()
arm64: rename variables used to c
By the time we call zones_sizes_init() arm64_dma_phys_limit already
contains the result of max_zone_dma_phys(). We use the variable instead
of calling the function directly to save some precious cpu time.
Signed-off-by: Nicolas Saenz Julienne
---
arch/arm64/mm/init.c | 2 +-
1 file changed, 1
On Tue, 2019-06-11 at 14:13 +0200, Nicolas Saenz Julienne wrote:
> Some a4tech mice use the 'GenericDesktop.00b8' usage to inform whether
> the previous wheel report was horizontal or vertical. Before
> c01908a14bf73 ("HID: input: add mapping for "Toggle Display&
nnect.
[1] https://www.spinics.net/lists/arm-kernel/msg742120.html
[2] https://www.spinics.net/lists/arm-kernel/msg742736.html
Signed-off-by: Nicolas Saenz Julienne
---
arch/arm/mach-bcm/Kconfig | 1 +
arch/arm/mach-bcm/board_bcm2835.c | 29 +
2 files changed,
t;type.
The patch reverts the handling of the usage id back to it's previous
behavior.
Fixes: c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/hid/hid-input.c | 2 +-
1 file changed, 1 insertion
On Tue, 2019-06-11 at 10:43 +0200, Benjamin Tissoires wrote:
> Hi Nicolas,
>
> On Mon, Jun 10, 2019 at 8:54 PM Nicolas Saenz Julienne
> wrote:
> > Some a4tech mice use the 'GenericDesktop.00b8' usage id to inform
> > whether the previous wheel report
t event. So we bypass the mapping and make
sure the custom event handling properly handles both reports.
Fixes: c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key")
Signed-off-by: Nicolas Saenz Julienne
---
NOTE: I CC'd Wolfgang as he's the one who can te
r
- raspberrypi-cpufreq device now registered by clk driver
- Reimplemented clk rounding unsing determine_rate()
- Enabled in configs for arm and arm64
Changes since RFC:
- Move firmware clk device into own driver
Nicolas Saenz Julienne (7):
clk: bcm2835: remove pllb
clk: bcm283x: add driv
Raspberry Pi's firmware controls this pll, we should use the firmware
interface to access it.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v1:
- Add comment to explain why pllb isn't there anymore
drivers/clk/bcm/clk-bcm2
#x27;ve had to factor out 'pllb' as the firmware 'owns' it.
+ * We're not allowed to change it directly as we might race with the
+ * over-temperature and under-voltage protections provided by the firmware.
+ *
+ * Copyright (C) 2019 Nicolas Saenz Julienne
+
Since clk-raspberrypi is tied to the VC4 firmware instead of particular
hardware it's registration should be performed by the firmware driver.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
drivers/firmware/raspberrypi.c | 10 ++
1 file changed, 10 insertions(+)
uring init, this implements a full fledged
driver, as opposed to most drivers registering cpufreq-dt, which only
make use of an init routine.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
Reviewed-by: Stephen Boyd
---
Changes since v1:
- Remove compatible checks
- Add module su
ceeds.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v2:
- Use raspberrypi_clk struct to store cpufreq platform_device
drivers/clk/bcm/clk-raspberrypi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspbe
frequency transition latency.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Change default governor to conservative in bcm2835_defconfig
- Set all as builtin in bcm2835_defconfig
arch/arm/configs/bcm2835_defconfig | 9 +
arch/arm/configs/multi_v7_defconfig | 2
This enables both the new firmware clock driver and cpufreq driver
available for the RPi3 family of boards.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Build both drivers as modules
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch
PORT_CONNECT state. Making sure the above mentioned situation
doesn't trigger a PM busyloop.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Do not trigger clear based on PLS_MASK != XDEV_RESUME to avoid a
potential race condition between the irq handler and hub t
evice now registered by firmware driver
- raspberrypi-cpufreq device now registered by clk driver
- Reimplemented clk rounding unsing determine_rate()
- Enabled in configs for arm and arm64
Changes since RFC:
- Move firmware clk device into own driver
Nicolas Saenz Julienne (7):
clk: bcm2
Raspberry Pi's firmware controls this pll, we should use the firmware
interface to access it.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v1:
- Add comment to explain why pllb isn't there anymore
drivers/clk/bcm/clk-bcm2
rectly as we might race with the
+ * over-temperature and under-voltage protections provided by the firmware.
+ *
+ * Copyright (C) 2019 Nicolas Saenz Julienne
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#define RPI_FIRMWARE_ARM_CLK_ID0x3
+
Since clk-raspberrypi is tied to the VC4 firmware instead of particular
hardware it's registration should be performed by the firmware driver.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
drivers/firmware/raspberrypi.c | 10 ++
1 file changed, 10 insertions(+)
uring init, this implements a full fledged
driver, as opposed to most drivers registering cpufreq-dt, which only
make use of an init routine.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v1:
- Remove compatible checks
- Add module support, now full fledged driv
ceeds.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
drivers/clk/bcm/clk-raspberrypi.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c
b/drivers/clk/bcm/clk-raspberrypi.c
index b1365cf19f3a..052296b5fbe4 100644
--- a/dri
, statistics, etc...).
Signed-off-by: Nicolas Saenz Julienne
---
arch/arm/configs/bcm2835_defconfig | 9 +
arch/arm/configs/multi_v7_defconfig | 2 ++
2 files changed, 11 insertions(+)
diff --git a/arch/arm/configs/bcm2835_defconfig
b/arch/arm/configs/bcm2835_defconfig
index dcf7610cfe55
This enables both the new firmware clock driver and cpufreq driver
available for the RPi3 family of boards.
Signed-off-by: Nicolas Saenz Julienne
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
On Thu, 2019-06-06 at 16:22 +0200, Nicolas Saenz Julienne wrote:
> Raspberry Pi's firmware offers an interface though which update it's
> clock's frequencies. This is specially useful in order to change the CPU
> clock (pllb_arm) which is 'owned' by the firmware
On Thu, 2019-06-06 at 10:05 -0700, Stephen Boyd wrote:
> Quoting Nicolas Saenz Julienne (2019-06-06 07:22:58)
> > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-
> > raspberrypi.c
> > index b1365cf19f3a..052296b5fbe4 100644
> > --- a/driver
Hi Stephen,
Thanks for the review.
On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote:
> Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56)
> > diff --git a/drivers/cpufreq/raspberrypi-cpufreq.c
> > b/drivers/cpufreq/raspberrypi-cpufreq.c
> > new file mode 100644
&
On Thu, 2019-06-06 at 10:36 -0700, Stephen Boyd wrote:
> Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16)
> > Hi Stephen,
> > Thanks for the review.
> >
> > On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote:
> > > Quoting Nicolas Saenz Julienne (2019-
On Thu, 2019-06-06 at 11:23 -0700, Stephen Boyd wrote:
> Quoting Nicolas Saenz Julienne (2019-06-06 11:10:04)
> > On Thu, 2019-06-06 at 10:36 -0700, Stephen Boyd wrote:
> > > Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16)
> > > > Hi Stephen,
> > > >
On Fri, 2019-06-07 at 11:26 +0200, Stefan Wahren wrote:
> Hi Nicolas,
>
> Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne:
> > Raspberry Pi's firmware offers an interface though which update it's
> > clock's frequencies. This is specially useful in order t
On Fri, 2019-06-07 at 12:19 +0200, Stefan Wahren wrote:
> Hi Nicolas,
>
> Am 06.06.19 um 16:23 schrieb Nicolas Saenz Julienne:
> > This enables both the new firmware clock driver and cpufreq driver
> > available for the RPi3 family of boards.
> >
> > Sign
On Fri, 2019-06-07 at 13:42 +0200, Stefan Wahren wrote:
> Hi Nicolas,
>
> Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne:
> > Raspberry Pi's firmware offers and interface though which update it's
> > performance requirements. It allows us to request for s
On Tue, 2019-06-04 at 16:53 +0300, Mathias Nyman wrote:
> On 27.5.2019 14.28, Nicolas Saenz Julienne wrote:
> > Hi Matthias,
> > thanks for the review.
> >
> > On Mon, 2019-05-27 at 14:16 +0300, Mathias Nyman wrote:
> > > On 24.5.2019 17.52, Nicolas Saenz Juli
On Fri, 2019-06-14 at 16:25 +0200, Nicolas Saenz Julienne wrote:
> On Fri, 2019-06-14 at 15:36 +0200, Benjamin Tissoires wrote:
> > Hi Wolfgang,
> >
> > On Thu, Jun 13, 2019 at 1:49 PM Wolfgang Bauer wrote:
> > > On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoi
ected.
As some USB subsystems already take care of this issue, the
implementation was inspired from usbhid/hid_core.c's.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Oliver Neukum
---
v4:
- Add Oliver's Reviewed-by
- Make timeout calculation simpler
v3: As per Oliver&#x
Hi Benjamin, Thanks for the review!
On Mon, 2019-03-25 at 16:08 +0100, Benjamin Tissoires wrote:
> On Mon, Mar 25, 2019 at 11:39 AM Benjamin Tissoires
> wrote:
> > Hi Nicolas,
> >
> > On Tue, Mar 12, 2019 at 10:37 AM Nicolas Saenz Julienne
> > wrote:
>
RMWARE=n &&
> COMPILE_TEST)
> + select INPUT_POLLDEV
> help
> Say Y here if you have the official Raspberry Pi 7 inch screen on
> your system.
Thanks!
Looks good to me.
Reviewed-by: Nicolas Saenz Julienne
signature.asc
Description: This is a digitally signed message part
On Fri, 2019-03-01 at 10:48 +0100, Benjamin Tissoires wrote:
> On Thu, Feb 28, 2019 at 7:01 PM Nicolas Saenz Julienne
> wrote:
> > On Thu, 2019-02-28 at 17:02 +, Junge, Terry wrote:
> > > This could also be a parser error. In the HID specification section
> > >
Hi Sebastian,
sorry I wasn't aware of that feature, I'll have a look at the whole
thing and rework the patch.
Regards,
Nicolas
On 22/11/16 16:23, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Nov 21, 2016 at 07:04:50PM +0100, Nicola Saenz Julienne wrote:
>> The current device name for sbs-battery i
Adds device tree documentation for SBS charger compilant devices as defined
here: http://sbs-forum.org/specs/sbc110.pdf
Signed-off-by: Nicolas Saenz Julienne
---
.../bindings/power/supply/sbs_sbs-charger.txt | 22 ++
1 file changed, 22 insertions(+)
create mode 100644
driver.
Regards,
Nicolas
changes since v1:
- added dt bindings
- updated driver with Sebastian's comments
- s/Nicola/Nicolas/ in commits
Nicolas Saenz Julienne (2):
power: supply: add sbs-charger driver
dt-bindings: power: add bindings for sbs-charger
.../bindings/power/supply/sb
This adds support for sbs-charger compilant chips as defined here:
http://sbs-forum.org/specs/sbc110.pdf
This was tested on a arm board connected to an LTC41000 battery charger
chip.
Signed-off-by: Nicolas Saenz Julienne
---
v1 -> v2:
- add spec link in header
- use proper gpio/interr
driver.
Regards,
Nicolas
changes since v2:
- updated driver and dt-binding with Sebatian's comments
changes since v1:
- added dt bindings
- updated driver with Sebastian's comments
- s/Nicola/Nicolas/ in commits
Nicolas Saenz Julienne (2):
power: supply: add sbs-charger driver
d
Adds device tree documentation for SBS charger compilant devices as defined
here: http://sbs-forum.org/specs/sbc110.pdf
Signed-off-by: Nicolas Saenz Julienne
---
v2 -> v3:
- add part number as compatible
.../bindings/power/supply/sbs_sbs-charger.txt | 24 ++
1 f
This adds support for sbs-charger compilant chips as defined here:
http://sbs-forum.org/specs/sbc110.pdf
This was tested on a arm board connected to an LTC41000 battery charger
chip.
Signed-off-by: Nicolas Saenz Julienne
---
v2 -> v3:
- add readable_reg() function to regmap config
- upd
ments
changes since v1:
- added dt bindings
- updated driver with Sebastian's comments
- s/Nicola/Nicolas/ in commits
Nicolas Saenz Julienne (2):
power: supply: add sbs-charger driver
dt-bindings: power: add bindings for sbs-charger
.../bindings/power/supply/sbs_sbs-charger.txt | 23 +
This adds support for sbs-charger compilant chips as defined here:
http://sbs-forum.org/specs/sbc110.pdf
This was tested on a arm board connected to an LTC4100 battery charger
chip.
Signed-off-by: Nicolas Saenz Julienne
---
v3 -> v4
- drop "lltc,ltc4100" compatible string for n
Adds device tree documentation for SBS charger compilant devices as defined
here: http://sbs-forum.org/specs/sbc110.pdf
Signed-off-by: Nicolas Saenz Julienne
---
v3 -> v4:
- use part-number/fallback compatible string structure
v2 -> v3:
- add part number as compatible
.../bindings/power/
Hi Manish, thanks for the interest.
On 20/12/16 17:54, Manish Badarkhe wrote:
> Hi Nicola
>
[...]
>
> Just some general comment, Can you add some more properties here to
> know voltage and current?
I assume you are mentioning reading current and voltage values. These
properties are not supported
On 24/11/16 13:33, Nicolas Saenz Julienne wrote:
> Hi,
>
> This series adds support for all SBS compatible battery chargers, as defined
> here: http://sbs-forum.org/specs/sbc110.pdf.
>
> The first patch changes the sbs-battery device name in order to be able to
> cre
Signed-off-by: Nicolas Saenz Julienne
---
drivers/usb/class/cdc-acm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index fa4e239..9831607 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1681,6
The chip is also an 8 bit shift register which works out of the box as a GPO
expander with this patch
Signed-off-by: Nicolas Saenz Julienne
---
Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 4 +++-
drivers/gpio/gpio-74x164.c | 1 +
2 files changed, 4
On Sat, Mar 12, 2016 at 04:27:29PM -0800, Greg KH wrote:
> On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote:
> > Signed-off-by: Nicolas Saenz Julienne
> > ---
> > drivers/usb/class/cdc-acm.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
&
Hi sorry for the late response but I was on vacation.
>
> Why did you choose the "lvc" variant?
Well to be honest the HW people did and it's all I could test with. I don't
know much about these naming schemes, apart from the intuition it has to do
with frequency and line levels.
> Ideally, you w
Hi Geert, thanks for your reply.
On Tue, Mar 22, 2016 at 11:56:51AM +0100, Geert Uytterhoeven wrote:
[..]
> For DT bindings, it doesn't matter who manufactured the part, or which
> technology was used (TTL, HC, LVC, ...).
>
> Logically, the shiny new parts are compatible with the old ones, from a
that evaluates the fw config flags and removed module
owner
v3: Added .direction_input() routine, and took care of all Linus Walleij
suggestions (clamp to bool, use proper include)
Signed-off-by: Nicolas Saenz Julienne
---
drivers/gpio/Kconfig | 7 ++
drivers/gpio/Makefile
Signed-off-by: Nicolas Saenz Julienne
---
Documentation/kernel-parameters.txt | 6 ++
drivers/tty/serial/meson_uart.c | 22 ++
2 files changed, 28 insertions(+)
diff --git a/Documentation/kernel-parameters.txt
b/Documentation/kernel-parameters.txt
index 551ecf0
Hi Florian, thanks for the review :)
On Tue, 2020-06-09 at 11:07 -0700, Florian Fainelli wrote:
>
> On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote:
> > The firmware running on the RPi VideoCore can be used to reset and
> > initialize HW controlled by the firmware.
>
On Tue, 2020-06-09 at 11:14 -0700, Florian Fainelli wrote:
>
> On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote:
> > Raspberry Pi 4's co-processor controls some of the board's HW
> > initialization process, but it's up to Linux to trigger it when
> >
Hi Florian,
On Tue, 2020-06-09 at 11:13 -0700, Florian Fainelli wrote:
>
> On 6/9/2020 10:49 AM, Nicolas Saenz Julienne wrote:
> > Some atypical users of xhci-pci might need to manually reset their xHCI
> > controller before starting the HCD setup. Check if a reset contro
Hi Andy,
Thanks for the review.
On Tue, 2020-06-09 at 21:43 +0300, Andy Shevchenko wrote:
> On Tue, Jun 9, 2020 at 8:50 PM Nicolas Saenz Julienne
> wrote:
> > The board doesn't need the quirks to be run, and takes care of its own
> > initialization trough a reset cont
tatic struct clk_hw *bcm2835_register_pll(struct
> bcm2835_cprman *cprman,
> init.num_parents = 1;
> init.name = pll_data->name;
> init.ops = &bcm2835_pll_clk_ops;
> - init.flags = CLK_IGNORE_UNUSED;
> + init.flags = data->flags | CLK_IGNORE_UNUSED;
Thi
tephen Boyd
> Cc: linux-...@vger.kernel.org
> Reviewed-by: Stephen Boyd
> Signed-off-by: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
tree properly, so having that clock in the MMIO driver will allow that.
>
> Signed-off-by: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
On Thu, 2020-06-11 at 09:32 +0200, Maxime Ripard wrote:
> The PLLB rate will be changed through the firmware clocks drivers and will
> change behind this drivers' back, so we don't want to cache the rate.
>
> Signed-off-by: Maxime Ripard
> ---
Thanks!
Acked-by: Nicolas
: Maxime Ripard
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
e
>
With patch #25 manually fixed, the series is:
Tested-by: Nicolas Saenz Julienne
Regards,
Nicolas
signature.asc
Description: This is a digitally signed message part
They are neither produced nor expected, so just delete them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 40 ++-
1 file changed, 3 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
For messages with a reason different from VCHIQ_MESSAGE_AVAILABLE the
responsibility for releasing them is kept in vchi, in other words,
services don't need to worry about it. As we're trying to unify vchi and
vchiq, move the release code into vchiq.
Signed-off-by: Nicolas Saen
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 12
.../interface/vchiq_arm/vchiq_shim.c | 64 ---
.../interface/vchiq_arm/vchiq_util.c | 12
.../interface/vchiq_arm/vchiq_util.h | 1 -
.../vc04_ser
vchi has a set of transfer flags which almost map 1:1 to vchiq's own
transfer modes. For the sake of simplicity let's use the later and
delete vchi's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-
struct shim_service into struvt vchi_service, which is more consistent
with the rest of the exposed API.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 24 +++
.../vc04_services/interface/vchi/vchi.h | 27
.../interface/vchiq_arm
Nobody uses it and it's routinely discarded in vchi.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 9 -
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 4
2 files changed, 13 deletions(-)
diff --git a/dr
Nobody uses it. Get rid of it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 7
.../interface/vchiq_arm/vchiq_shim.c | 39 ---
2 files changed, 46 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
They don't exist, they have no users, get rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/st
vchiq consumer drivers may need to use this function in order to get the
benefits of vchiq's per service message queueing mechanism.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/dr
The function is being exported although there is no use for it outside
of vchiq's core code. Keep it local then.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +--
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
For initialization, vchi has its own params structure, which is then
translated to vchiq's params structure. They are essentially the same,
so lets directly use vchiq's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 9 +
.../vc0
The structure only contains a single parameter, which is the underlying
vchiq handle. Get rid of the struct and directly pass the handle around.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 23 ++---
.../vc04_services/interface/vchi/vchi.h | 25
Its vchiq counterpart, vchiq_bulk_receive() is only used by vchi. We can
then merge both functions by moving vchi_bulk_queue_receive()'s retry
mechanism into vchiq_bulk_receive() and let services call the later.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/v
There is already enough duplication with regard to fourcc generation in
the kernel. Let's at least use the same macro all over the vchiq
ecosystem.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-
Linux coding style says to avoid typdefs.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/vchi.h| 5 -
.../vc04_services/interface/vchiq_arm/vchiq_if.h | 14 --
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers
This used to be vchiq_if.h but vchiq.h is more concise for an include
file that will hopefully be in the future in the includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/bcm2835-audio/bcm2835.h | 2 +-
.../vc04_services/interface/vchiq_arm/vchiq.h | 107
igned-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile| 1 -
.../bcm2835-audio/bcm2835-vchiq.c | 24 +--
.../vc04_services/bcm2835-audio/bcm2835.h | 1 -
.../vc04_services/interface/{vchi => }/TODO | 0
.../vc04_services/interface/vch
The barrier is only used by core code. So keep the barrier definition in
the core header.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h| 11 ---
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 12
2 files changed, 12
This is for service's callbacks to get their private data.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
b/dr
, which
makes for simpler code in the end.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 20 ++---
.../vc04_services/interface/vchi/vchi.h | 9 +-
.../interface/vchi/vchi_common.h | 12 ---
.../interface/vchiq_arm/v
Those functions don't actually exist, nor have any use, nor the macros.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_if.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if
This file is internal to vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
b/drivers/staging/vc04_services/interface
The services have access to struct vchiq_header's internals, so we can
let them get the data pointer. This pretty much makes both functions
exactly the same, which will allow us to make a switch to
vchiq_msg_hold() further down the road.
Signed-off-by: Nicolas Saenz Julienne
---
.../st
We can't really merge it with vchiq_queue_message() as it has internal
users that will not benefit from the retry mechanism
vchiq_queue_kernel_message() uses. So, for the sake of getting rid of
vchi, move it into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vc
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile
vchiq_if.h is used by service consumers and only the exported API should
be present. Move the rest of definitions, which were not exported by the
way, to vchiq_core.h where they belong.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.h | 22
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We
can then merge both functions by moving vchi_bulk_queue_transmit()'s
retry mechanism into vchiq_bulk_transmit() and let services call the
later.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vc
This will make further changes easier. The struct will ultimately
disappear.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 10 +++---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 7 ---
2 files changed, 7 insertions
It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_ser
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_com
The header file only provides other includes. Move the relevant includes
to their respective C files and delete it for good.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h | 1 -
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 +
.../interface
ne to match vchiq's user_service message
queue, which could be merged with this one in the future.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile| 1 -
.../interface/vchiq_arm/vchiq_core.c | 46
.../interface/vchiq_arm/vc
501 - 600 of 1064 matches
Mail list logo
