Registers clk-raspberrypi as a platform device as part of the driver's
probe sequence.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/clk/bcm/clk-bcm2835.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk
are configurable in the firmware
there is no way to know in advance their values. So the Raspberry Pi
cpufreq driver queries them, builds an opp frequency table to then
launch cpufreq-dt.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since RFC:
- Alphabetically ordered relevant stuff
On Fri, 2019-06-14 at 16:25 +0200, Nicolas Saenz Julienne wrote:
> On Fri, 2019-06-14 at 15:36 +0200, Benjamin Tissoires wrote:
> > Hi Wolfgang,
> >
> > On Thu, Jun 13, 2019 at 1:49 PM Wolfgang Bauer wrote:
> > > On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoi
On Tue, 2019-06-11 at 10:43 +0200, Benjamin Tissoires wrote:
> Hi Nicolas,
>
> On Mon, Jun 10, 2019 at 8:54 PM Nicolas Saenz Julienne
> wrote:
> > Some a4tech mice use the 'GenericDesktop.00b8' usage id to inform
> > whether the previous wheel report was horizo
ke
sure the custom event handling properly handles both reports.
Fixes: c01908a14bf73 ("HID: input: add mapping for "Toggle Display" key")
Signed-off-by: Nicolas Saenz Julienne
---
NOTE: I CC'd Wolfgang as he's the one who can test this.
Changes since v1:
- new approach, move
clk driver
- Reimplemented clk rounding unsing determine_rate()
- Enabled in configs for arm and arm64
Changes since RFC:
- Move firmware clk device into own driver
Nicolas Saenz Julienne (7):
clk: bcm2835: remove pllb
clk: bcm283x: add driver interfacing with Raspberry Pi's firmware
firm
Raspberry Pi's firmware controls this pll, we should use the firmware
interface to access it.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v1:
- Add comment to explain why pllb isn't there anymore
drivers/clk/bcm/clk-bcm2835.c | 28
the firmware 'owns' it.
+ * We're not allowed to change it directly as we might race with the
+ * over-temperature and under-voltage protections provided by the firmware.
+ *
+ * Copyright (C) 2019 Nicolas Saenz Julienne
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#i
Since clk-raspberrypi is tied to the VC4 firmware instead of particular
hardware it's registration should be performed by the firmware driver.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
drivers/firmware/raspberrypi.c | 10 ++
1 file changed, 10 insertions(+)
diff
, this implements a full fledged
driver, as opposed to most drivers registering cpufreq-dt, which only
make use of an init routine.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
Reviewed-by: Stephen Boyd
---
Changes since v1:
- Remove compatible checks
- Add module support, now
Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v2:
- Use raspberrypi_clk struct to store cpufreq platform_device
drivers/clk/bcm/clk-raspberrypi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c
b/drivers/clk/bcm/clk
frequency transition latency.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Change default governor to conservative in bcm2835_defconfig
- Set all as builtin in bcm2835_defconfig
arch/arm/configs/bcm2835_defconfig | 9 +
arch/arm/configs/multi_v7_defconfig | 2
This enables both the new firmware clock driver and cpufreq driver
available for the RPi3 family of boards.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Build both drivers as modules
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch
On Tue, 2019-06-11 at 19:58 +0200, Nicolas Saenz Julienne wrote:
> Raspberry Pi's firmware offers and interface though which update it's
> performance requirements. It allows us to request for specific runtime
> frequencies, which the firmware might or might not respect,
On Tue, 2019-04-30 at 20:58 +0200, Nicolas Saenz Julienne wrote:
> Some hardware configurations might pass on providing an interrupt line.
> In that case there is always the option to use a polled input approach.
> This patch adapts the driver for it.
>
> The polled approach is
The w5X00 chip provides an SPI to Ethernet inteface. This patch allows
platform devices to be defined through the device tree.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/net/ethernet/wiznet/w5100-spi.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff
Add bindings for Wiznet's w5x00 series of SPI interfaced Ethernet chips.
Based on the bindings for microchip,enc28j60.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- one compatible sting per line
- use correct 'ethenet@0' phandle name
.../devicetree/bindings/net/wiznet
On Wed, 2019-06-12 at 09:52 -0700, David Miller wrote:
> From: Nicolas Saenz Julienne
> Date: Wed, 12 Jun 2019 14:25:25 +0200
>
> > The w5X00 chip provides an SPI to Ethernet inteface. This patch allows
> > platform devices to be defined through the device tree.
> >
now registered by firmware driver
- raspberrypi-cpufreq device now registered by clk driver
- Reimplemented clk rounding unsing determine_rate()
- Enabled in configs for arm and arm64
Changes since RFC:
- Move firmware clk device into own driver
Nicolas Saenz Julienne (7):
clk: bcm2835: re
Raspberry Pi's firmware controls this pll, we should use the firmware
interface to access it.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v1:
- Add comment to explain why pllb isn't there anymore
drivers/clk/bcm/clk-bcm2835.c | 28
This enables both the new firmware clock driver and cpufreq driver
available for the RPi3 family of boards.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Stefan Wahren
---
Changes since v2:
- Build both drivers as modules
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions
+ *
+ * Copyright (C) 2019 Nicolas Saenz Julienne
+ */
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#define RPI_FIRMWARE_ARM_CLK_ID0x0003
+
+#define RPI_FIRMWARE_STATE_ENABLE_BIT BIT(0)
+#define RPI_FIRMWARE_STATE_WAIT_BITBIT(1)
+
+/*
+ * Even t
frequency transition latency.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Stefan Wahren
---
Changes since v2:
- Change default governor to conservative in bcm2835_defconfig
- Set all as builtin in bcm2835_defconfig
arch/arm/configs/bcm2835_defconfig | 9 +
arch/arm/configs
Since clk-raspberrypi is tied to the VC4 firmware instead of particular
hardware it's registration should be performed by the firmware driver.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
---
drivers/firmware/raspberrypi.c | 10 ++
1 file changed, 10 insertions(+)
diff
Saenz Julienne
Acked-by: Eric Anholt
---
Changes since v2:
- Use raspberrypi_clk struct to store cpufreq platform_device
drivers/clk/bcm/clk-raspberrypi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/clk/bcm/clk-raspberrypi.c
b/drivers/clk/bcm/clk
, this implements a full fledged
driver, as opposed to most drivers registering cpufreq-dt, which only
make use of an init routine.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Eric Anholt
Reviewed-by: Stephen Boyd
---
Changes since v3:
- Fix spelling error in commit's subject
Changes since v2
Hi Matthias,
On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote:
>
> On 30/04/2020 15:04, Nicolas Saenz Julienne wrote:
> > When needed, RPi4's co-processor (called VideoCore) has to be instructed
> > to load VL805's firmware (the chip providing xHCI support). VideoC
On Fri, 2020-05-01 at 10:28 -0400, Jim Quinlan wrote:
> From: Jim Quinlan
>
> clk_put() was being invoked on a clock obtained by
> devm_clk_get_optional().
>
> Signed-off-by: Jim Quinlan
> Acked-by: Florian Fainelli
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
t; Signed-off-by: Jim Quinlan
> Acked-by: Florian Fainelli
>
> Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller
> driver")
> ---
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
> drivers/pci/controller/pcie-brcmstb.c | 4 ++--
> 1 file chan
e new generic dt property:
Acked-by: Nicolas Saenz Julienne
Regards,
Nicolas
> ---
> drivers/pci/controller/pcie-brcmstb.c | 14 +-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c
> b/drivers/pci/controller/pcie-
On Tue, 2020-05-05 at 15:39 +0200, Matthias Brugger wrote:
>
> On 05/05/2020 14:53, Nicolas Saenz Julienne wrote:
> > Hi Matthias,
> >
> > On Tue, 2020-05-05 at 14:15 +0200, Matthias Brugger wrote:
> > > On 30/04/2020 15:04, Nicolas Saenz Julienne wrote:
> &g
On Tue, 2020-05-05 at 16:59 +0200, Matthias Brugger wrote:
[...]
> > > > > > +#ifdef CONFIG_BCM2711
> > > > >
> > > > > This won't work with rpi_arm64_defconfig.
> > > > > Can't we just evaluate at runtime if we need to do anything in
> > > > > xhci_pci_fixup.
> > > >
> > > > I can't see why,
The property is needed in order to trigger VL805's firmware load. Note
that gap between the property introduced and the previous one is due to
the properties not being defined.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
include/soc/bcm2835/raspberrypi-firmware.h
since v5:
- Fix issues reported by Kbuild test robot
Changes since v4:
- Addressed Sergei's comments
- Fix potential warning in patch #2
Changes since v3:
- Addressed Greg's comments
There was no v2, my bad.
Changes since v1:
- Addressed Floarians comments
Nicolas Saenz Julienne (4):
soc
logic and the VL805 firmware blob. The function this patch
introduces triggers the aforementioned process.
Signed-off-by: Nicolas Saenz Julienne
---
Change since v7:
- Use usleep_delay()
- Add comment about PCI errors
- Don't wait on error
- Typos
Change since v6:
- Add test to avoid loading
xHCI's PCI fixup, run at the end of pcie-brcmstb's probe, depends on
RPi4's VideoCore firmware interface to be up and running. It's possible
for both initializations to race, so make sure it's available prior to
starting.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
can't be set as a module neither
this can. Reflect that on the firmware interface Kconfg.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v5:
- Fix Kconfig issue with allmodconfig
Changes since v4:
- Do not split up error message
Changes since v3:
- Add more complete error message
in between the PCIe configuration and xHCI startup.
Introduce a callback in xhci_pci_probe() to run this platform specific
routine.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v2:
- Get rid of #ifdef CONFIG_BCM2711
- Get rid of redundant error message
Changes since v1:
- Create
ename function
- Use callback in xhci-pci.c
Nicolas Saenz Julienne (2):
arm: rpi: Add function to trigger VL805's firmware load
usb: xhci: Load Raspberry Pi 4 VL805's firmware
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x/include/mach/msg.h | 7
arch/ar
Saenz Julienne
---
Changes since v2:
- Correct wrong function name in comment
- Add better comment on rpi_firmware_init_vl805()
Changes since v1:
- Rename function so it's not mistaken with regular firmware loading
arch/arm/mach-bcm283x/include/mach/mbox.h | 13 +++
arch/arm/mach-bcm283x
On Sat, 2020-05-09 at 12:02 +0200, Stefan Wahren wrote:
> Hi Nicolas,
>
> Am 07.05.20 um 23:48 schrieb Rob Herring:
> > On Tue, 5 May 2020 18:13:15 +0200, Nicolas Saenz Julienne wrote:
> > > The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip
> >
Eric Anholt's repo isn't used anymore. List current one.
Signed-off-by: Nicolas Saenz Julienne
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 091ec22c1a23..60908ace8d31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3320,7
On Wed, 2020-05-13 at 12:17 +0100, Lorenzo Pieralisi wrote:
> On Tue, May 05, 2020 at 06:13:13PM +0200, Nicolas Saenz Julienne wrote:
> > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
> > loaded directly from an EEPROM or, if not present, by the SoC's
&
On Tue, 2020-05-05 at 18:26 +0200, Nicolas Saenz Julienne wrote:
> Newer revisions of the RPi4 need their xHCI chip, VL805, firmware to be
> loaded explicitly. Earlier versions didn't need that as they where using
> an EEPROM for that purpose. This series takes care of setting up the
&
On Mon, 2019-10-21 at 10:15 -0400, Qian Cai wrote:
> > On Sep 11, 2019, at 2:25 PM, Nicolas Saenz Julienne
> > wrote:
> >
> > So far all arm64 devices have supported 32 bit DMA masks for their
> > peripherals. This is not true anymore for the Raspberry Pi 4 as mo
On Mon, 2019-10-21 at 10:46 -0400, Qian Cai wrote:
> > On Oct 21, 2019, at 10:34 AM, Nicolas Saenz Julienne > > wrote:
> >
> > On Mon, 2019-10-21 at 10:15 -0400, Qian Cai wrote:
> > > > On Sep 11, 2019, at 2:25 PM, Nicolas Saenz Julienne <
> &
On Mon, 2019-10-21 at 13:25 -0400, Qian Cai wrote:
> > On Oct 21, 2019, at 1:01 PM, Nicolas Saenz Julienne
> > wrote:
> >
> > Could you enable CMA debugging to see if anything interesting comes out of
> > it.
>
> I did but nothing interesting came out. Did
Hi Bin,
On Wed, 2020-05-06 at 13:33 +0800, Bin Meng wrote:
> Hi Nicolas,
>
> On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne
> wrote:
> > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware
> > may either be loaded directly from an E
: Add Broadcom STB PCIe host controller
driver")
Signed-off-by: Nicolas Saenz Julienne
---
drivers/pci/controller/pcie-brcmstb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/pcie-brcmstb.c
b/drivers/pci/controller/pcie-brcmstb.c
index 0b97b94c4a9a..795a03be4
code in the end.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 20 ++---
.../vc04_services/interface/vchi/vchi.h | 9 +-
.../interface/vchi/vchi_common.h | 12 ---
.../interface/vchiq_arm/vchiq_shim.c | 42
It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/vc04_services
-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/Makefile| 1 -
.../bcm2835-audio/bcm2835-vchiq.c | 24 +--
.../vc04_services/bcm2835-audio/bcm2835.h | 1 -
.../vc04_services/interface/{vchi => }/TODO | 0
.../vc04_services/interface/vchi/vch
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 28
When adding a new service validate the configuration parameters
provided, and remove unnecessary checks in vchi, now that we have
validated service's config.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.c | 15 +++
.../interface/vchiq_arm
Those are only used in the core vchiq code, while present in vchiq's
'public' API header. Move them into the right place.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq.h| 5 -
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.h
We can't really merge it with vchiq_queue_message() as it has internal
users that will not benefit from the retry mechanism
vchiq_queue_kernel_message() uses. So, for the sake of getting rid of
vchi, move it into vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c
Those functions don't actually exist, nor have any use, nor the macros.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_if.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
b
To make the separation clear between vchiq's header files and vchiq.h,
which is to be used by services and is the 'public' API, move it into a
dedicated includes directory.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Remove unwarranted include
drivers/staging/vc04_services
The header file only provides other includes. Move the relevant includes
to their respective C files and delete it for good.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h | 1 -
.../interface/vchiq_arm/vchiq_2835_arm.c | 1 +
.../interface
From: Dave Stevenson
The timeout period for VPU communications is a useful thing
to extend when debugging.
Set it via a define, rather than a magic number buried in the code.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging
From: Naushir Patuck
No functional changes in this commit.
- Remove erroneous whitespace.
- Remove _t postfix label on structs and enums.
Signed-off-by: Naushir Patuck
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 2
enum vchi_callback_reason maps 1:1 to enum vchiq_reason, in an effort to
simplify things, let's use the later, and get rid of the extra
indirection.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 5 +--
.../interface/vchi/vchi_common.h
are already held in an array per VCHI
instance, so use the array index as the client_component handle
to avoid having to create a new IDR for this purpose.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal
This reverts commit c65822fef4adc0ba40c37a47337376ce75f7a7bc.
The initialization of Raspberry Pi 4's USB chip is now handled through a
reset controller. No need to directly call the firmware routine through a
PCI quirk.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
On Fri, 2020-06-26 at 12:43 +0200, Philipp Zabel wrote:
> On Wed, 2020-06-17 at 12:44 +0200, Nicolas Saenz Julienne wrote:
> > On Wed, 2020-06-17 at 12:02 +0200, Philipp Zabel wrote:
> > > Hi Nicolas,
> > >
> > > On Fri, 2020-06-12 at 19:13 +0200, Nicolas Sae
The chip is hardwired to the board's PCIe bus and needs to be properly
setup trough a firmware routine after a PCI fundamental reset. Pass the
reset controller phandle that takes care of triggering the
initialization to the relevant PCI device.
Signed-off-by: Nicolas Saenz Julienne
---
Changes
This reverts commit fbbc5ff3f7f9f4cad562e530ae2cf5d8964fe6d3.
The vl805 init routine has moved into drivers/reset/reset-raspberrypi.c
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
drivers/firmware/raspberrypi.c | 61 --
include/soc
This reverts commit 44331189f9082c7e659697bbac1747db3def73e7.
Now that the VL805 init routine is run through a reset controller driver
the device dependencies are being taken care of by the device core. No
need to do it manually here.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian
less USB centric
- Use correct reset controller API in xhci-pci
- Correct typos
Nicolas Saenz Julienne (9):
dt-bindings: reset: Add a binding for the RPi Firmware reset
controller
reset: Add Raspberry Pi 4 firmware reset controller
ARM: dts: bcm2711: Add firmware usb reset node
ARM: dts
Now that the reset driver exposing Raspberry Pi 4's firmware based USB
reset routine is available, let's add the device tree node exposing it.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v1:
- Update cell nr to match new bindings
---
arch/arm/boot
-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
Reviewed-by: Philipp Zabel
---
Changes since v4:
- use np instead of fw_node, to explicitly mark this as OF centric
Changes since v2:
- Get ids from dt-binding
Changes since v1:
- Make the whole driver less USB centric as per Florian's
The firmware running on the RPi VideoCore can be used to reset and
initialize HW controlled by the firmware.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Add include file for reset IDs
Changes since v1:
- Correct cells binding as per Florian's
The board doesn't need the quirks to be run, and takes care of its own
initialization through a reset controller device. So let's bypass them.
Signed-off-by: Nicolas Saenz Julienne
Reviewed-by: Florian Fainelli
---
Changes since v2:
- Correct reference counting on parent device node
Changes
Some atypical users of xhci-pci might need to manually reset their xHCI
controller before starting the HCD setup. Check if a reset controller
device is available to the PCI bus and trigger a reset.
Signed-off-by: Nicolas Saenz Julienne
Acked-by: Mathias Nyman
Reviewed-by: Philipp Zabel
for the struct,
and pass the appropriate members.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-camera/bcm2835-camera.c | 64 +++
.../vc04_services/vchiq-mmal/mmal-common.h| 5 ++
.../vc04_services/vchiq
The barrier is only used by core code. So keep the barrier definition in
the core header.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchiq_arm/vchiq.h| 11 ---
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 12
2 files changed, 12
.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers
() instead.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 25 +++
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
b/drivers/staging/vc04_services/bcm2835-audio/bcm2835
-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
Nothing in it is being used.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 1 -
.../vc04_services/interface/vchi/vchi_cfg.h | 238 --
2 files changed, 239 deletions(-)
delete mode 100644 drivers/staging/vc04_services/interface
This will make further changes easier. The struct will ultimately
disappear.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h| 10 +++---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 7 ---
2 files changed, 7 insertions
For initialization, vchi has its own params structure, which is then
translated to vchiq's params structure. They are essentially the same,
so lets directly use vchiq's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 9 +
.../vc04_services
From: Dave Stevenson
There were dependencies on including the headers in the correct
order. Fix up the headers so that they include the other
headers that they depend on themselves.
Signed-off-by: Dave Stevenson
Signed-off-by: Jacopo Mondi
Signed-off-by: Nicolas Saenz Julienne
---
drivers
Linux coding style says to avoid typdefs.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging/vc04_services/interface/vchi/vchi.h| 5 -
.../vc04_services/interface/vchiq_arm/vchiq_if.h | 14 --
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers
ays return the param size from param_get
staging: mmal-vchiq: If the VPU returns an error, don't negate it
Naushir Patuck (1):
staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h
Nicolas Saenz Julienne (39):
staging: vchi: Get rid of all useless callback reasons
st
vchiq consumer drivers may need to use this function in order to get the
benefits of vchiq's per service message queueing mechanism.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
vchi has a set of transfer flags which almost map 1:1 to vchiq's own
transfer modes. For the sake of simplicity let's use the later and
delete vchi's.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-audio/bcm2835.h
There is a series of structures and enums defined but never used. Get
rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 65 ---
1 file changed, 65 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
The services have access to struct vchiq_header's internals, so we can
let them get the data pointer. This pretty much makes both functions
exactly the same, which will allow us to make a switch to
vchiq_msg_hold() further down the road.
Signed-off-by: Nicolas Saenz Julienne
---
.../staging
Those defines aren't used by anyone. Get rid of them.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 11 ---
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 1 -
2 files changed, 12 deletions(-)
diff --git a/drivers/staging
and directly pass struct
vchiq_header, which is what ultimately vchiq consumes when handling
callback messages.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 14 ++-
.../interface/vchiq_arm/vchiq_shim.c | 25 ++-
2 files
Nobody uses it. Get rid of it.
Signed-off-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 7
.../interface/vchiq_arm/vchiq_shim.c | 39 ---
2 files changed, 46 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
Its vchiq counterpart, vchiq_bulk_transmit() is only used by vchi. We
can then merge both functions by moving vchi_bulk_queue_transmit()'s
retry mechanism into vchiq_bulk_transmit() and let services call the
later.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c
The structure only contains a single parameter, which is the underlying
vchiq handle. Get rid of the struct and directly pass the handle around.
Signed-off-by: Nicolas Saenz Julienne
---
.../bcm2835-audio/bcm2835-vchiq.c | 23 ++---
.../vc04_services/interface/vchi/vchi.h | 25
This file is internal to vchiq.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
b/drivers/staging/vc04_services/interface
struct shim_service into struvt vchi_service, which is more consistent
with the rest of the exposed API.
Signed-off-by: Nicolas Saenz Julienne
---
Changes since v1:
- Open service only if allocation was successful
.../bcm2835-audio/bcm2835-vchiq.c | 24 +++
.../vc04_services
vchiq_if.h is used by service consumers and only the exported API should
be present. Move the rest of definitions, which were not exported by the
way, to vchiq_core.h where they belong.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchiq_arm/vchiq_core.h | 22
-by: Nicolas Saenz Julienne
---
.../vc04_services/interface/vchi/vchi.h | 12
.../interface/vchiq_arm/vchiq_shim.c | 64 ---
.../interface/vchiq_arm/vchiq_util.c | 12
.../interface/vchiq_arm/vchiq_util.h | 1 -
4 files changed, 89 deletions
They are neither produced nor expected, so just delete them.
Signed-off-by: Nicolas Saenz Julienne
---
.../interface/vchi/vchi_common.h | 40 ++-
1 file changed, 3 insertions(+), 37 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
There is already enough duplication with regard to fourcc generation in
the kernel. Let's at least use the same macro all over the vchiq
ecosystem.
Signed-off-by: Nicolas Saenz Julienne
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
.../vc04_services/bcm2835-audio
601 - 700 of 1177 matches
Mail list logo
