On Tuesday 03 January 2017 12:21:21 Bastien Nocera wrote:
> On Mon, 2017-01-02 at 18:09 +0100, Pali Rohár wrote:
> > On Monday 02 January 2017 16:27:05 Bastien Nocera wrote:
> > > On Sun, 2016-12-25 at 11:04 +0100, Pali Rohár wrote:
> > > > This patch allows user to
On Tuesday 03 January 2017 12:21:21 Bastien Nocera wrote:
> On Mon, 2017-01-02 at 18:09 +0100, Pali Rohár wrote:
> > On Monday 02 January 2017 16:27:05 Bastien Nocera wrote:
> > > On Sun, 2016-12-25 at 11:04 +0100, Pali Rohár wrote:
> > > > This patch allows user to
On Friday 10 November 2017 00:38:22 Pali Rohár wrote:
> This patch series fix processing MAC address for wl1251 chip found in Nokia
> N900.
>
> Changes since v1:
> * Added Acked-by for Pavel Machek
> * Fixed grammar
> * Magic numbers for NVS offsets are replaced by defines
&
On Friday 10 November 2017 00:38:22 Pali Rohár wrote:
> This patch series fix processing MAC address for wl1251 chip found in Nokia
> N900.
>
> Changes since v1:
> * Added Acked-by for Pavel Machek
> * Fixed grammar
> * Magic numbers for NVS offsets are replaced by defines
&
other
process can exchange files.
--
Pali Rohár
pali.ro...@gmail.com
other
process can exchange files.
--
Pali Rohár
pali.ro...@gmail.com
On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> So from all tests and discussion I would propose new unification:
>
> 1. Read label only from the root directory. If label in root directory
>is missing then disk would be treated as without label. Label from
>bo
On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> So from all tests and discussion I would propose new unification:
>
> 1. Read label only from the root directory. If label in root directory
>is missing then disk would be treated as without label. Label from
>bo
need more
comments. Part "either version 2 of the License, or (at your option) any
later version." expresses what it exactly mean and it is standard
license also used by other projects.
--
Pali Rohár
pali.ro...@gmail.com
need more
comments. Part "either version 2 of the License, or (at your option) any
later version." expresses what it exactly mean and it is standard
license also used by other projects.
--
Pali Rohár
pali.ro...@gmail.com
ate device data\n");
Hi! Any particular reason for removing error message?
> + if (!smo8800)
> return -ENOMEM;
> - }
>
> smo8800->dev = >dev;
> smo8800->miscdev.minor = MISC_DYNAMIC_MINOR;
--
Pali Rohár
pali.ro...@gmail.com
! Any particular reason for removing error message?
> + if (!smo8800)
> return -ENOMEM;
> - }
>
> smo8800->dev = >dev;
> smo8800->miscdev.minor = MISC_DYNAMIC_MINOR;
--
Pali Rohár
pali.ro...@gmail.com
On Monday 04 December 2017 13:08:18 Oleksandr Natalenko wrote:
> Hi.
>
> 04.12.2017 11:35, Pali Rohár wrote:
> > On Friday 24 November 2017 13:28:59 Oleksandr Natalenko wrote:
> > > On pátek 24. listopadu 2017 12:25:43 CET Pali Rohár wrote:
> > > > On Friday
On Monday 04 December 2017 13:08:18 Oleksandr Natalenko wrote:
> Hi.
>
> 04.12.2017 11:35, Pali Rohár wrote:
> > On Friday 24 November 2017 13:28:59 Oleksandr Natalenko wrote:
> > > On pátek 24. listopadu 2017 12:25:43 CET Pali Rohár wrote:
> > > > On Friday
On Friday 24 November 2017 13:28:59 Oleksandr Natalenko wrote:
> On pátek 24. listopadu 2017 12:25:43 CET Pali Rohár wrote:
> > On Friday 24 November 2017 12:17:30 Oleksandr Natalenko wrote:
> > > > There are two patches waiting to be tested in
> > > > https://bu
On Friday 24 November 2017 13:28:59 Oleksandr Natalenko wrote:
> On pátek 24. listopadu 2017 12:25:43 CET Pali Rohár wrote:
> > On Friday 24 November 2017 12:17:30 Oleksandr Natalenko wrote:
> > > > There are two patches waiting to be tested in
> > > > https://bu
ad code is a bad idea. When we see something like
this, we should at least stop and ask question "why is this code pattern
used?".
> Best Regards,
> Masaki Ota
> -Original Message-
> From: Pali Rohár [mailto:pali.ro...@gmail.com]
> Sent: Monday, December 04, 2
ad code is a bad idea. When we see something like
this, we should at least stop and ask question "why is this code pattern
used?".
> Best Regards,
> Masaki Ota
> -Original Message-
> From: Pali Rohár [mailto:pali.ro...@gmail.com]
> Sent: Monday, December 04, 2017
On Monday 04 December 2017 04:48:43 Masaki Ota wrote:
> Hi, Pali,
>
> I don't get your point.
> Please modify the code if you have an idea.
See below
> Best Regards,
> Masaki Ota
> -Original Message-----
> From: Pali Rohár [mailto:pali.ro...@gmail.com]
> Sent: Sa
On Monday 04 December 2017 04:48:43 Masaki Ota wrote:
> Hi, Pali,
>
> I don't get your point.
> Please modify the code if you have an idea.
See below
> Best Regards,
> Masaki Ota
> -Original Message-----
> From: Pali Rohár [mailto:pali.ro...@gmail.com]
> Sent: Sa
; 4.15-rc1 seems to work ok on the box.
>
> Any ideas?
twl4030_bci is not available on Nokia N900, so we should not try to read
its registers.
--
Pali Rohár
pali.ro...@gmail.com
; 4.15-rc1 seems to work ok on the box.
>
> Any ideas?
twl4030_bci is not available on Nokia N900, so we should not try to read
its registers.
--
Pali Rohár
pali.ro...@gmail.com
p, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
Now looking at this change... Is there reason why you are passing
psmouse parameter there? Because struct alps_data contains psmouse
member.
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
ALPS_DUALPOINT_WITH_PRESSURE;
> @@ -2570,7 +2588,7 @@ static int alps_set_defaults_ss4_v2(struct psmouse
> *psmouse,
>
> alps_update_btn_info_ss4_v2(otp, priv);
>
> - alps_update_dual_info_ss4_v2(otp, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
Now looking at this change... Is there reason why you are passing
psmouse parameter there? Because struct alps_data contains psmouse
member.
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
On Monday 20 November 2017 12:12:56 Karel Zak wrote:
> On Sun, Nov 19, 2017 at 01:44:40PM +0100, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> > > So from all tests and discussion I would propose new unification:
> > >
> > &
On Monday 20 November 2017 12:12:56 Karel Zak wrote:
> On Sun, Nov 19, 2017 at 01:44:40PM +0100, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> > > So from all tests and discussion I would propose new unification:
> > >
> > &
+
> if (is_dual)
> priv->flags |= ALPS_DUALPOINT |
> ALPS_DUALPOINT_WITH_PRESSURE;
> @@ -2570,7 +2588,7 @@ static int alps_set_defaults_ss4_v2(struct psmouse
> *psmouse,
>
> alps_update_btn_info_ss4_v2(otp, priv);
>
> - alps_update_dual_info_ss4_v2(otp, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
priv->flags |= ALPS_DUALPOINT |
> ALPS_DUALPOINT_WITH_PRESSURE;
> @@ -2570,7 +2588,7 @@ static int alps_set_defaults_ss4_v2(struct psmouse
> *psmouse,
>
> alps_update_btn_info_ss4_v2(otp, priv);
>
> - alps_update_dual_info_ss4_v2(otp, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
yet as Andreas have
not decided yet about dosfstools/fatlabel...
--
Pali Rohár
pali.ro...@gmail.com
yet as Andreas have
not decided yet about dosfstools/fatlabel...
--
Pali Rohár
pali.ro...@gmail.com
only approach here, I can confirm that this
> works.
Hi! Please figure out which SMM call (they are identified by eax and ebx
registers) cause this freeze. So we would now what needs to be
blacklisted.
--
Pali Rohár
pali.ro...@gmail.com
only approach here, I can confirm that this
> works.
Hi! Please figure out which SMM call (they are identified by eax and ebx
registers) cause this freeze. So we would now what needs to be
blacklisted.
--
Pali Rohár
pali.ro...@gmail.com
7 * Call the System Management Mode BIOS. Code provided by Jonathan
> Buzzard.
> ===
>
> This was also reported in various places before, for instance, [1], but
> unfortunately, without any solution.
>
> Thanks.
>
> Regards,
> Oleksandr
>
> [1] https://bugs.launchpad.net/ubuntu/+source/acpi/+bug/10490
--
Pali Rohár
pali.ro...@gmail.com
7 * Call the System Management Mode BIOS. Code provided by Jonathan
> Buzzard.
> ===
>
> This was also reported in various places before, for instance, [1], but
> unfortunately, without any solution.
>
> Thanks.
>
> Regards,
> Oleksandr
>
> [1] https://bugs.launchpad.net/ubuntu/+source/acpi/+bug/10490
--
Pali Rohár
pali.ro...@gmail.com
On Tuesday 04 July 2017 15:28:19 Pali Rohár wrote:
> On Tuesday 06 June 2017 22:50:52 Pali Rohár wrote:
> > On Tuesday 06 June 2017 19:02:01 Darren Hart wrote:
> > > On Tue, Jun 06, 2017 at 12:04:40PM +0200, Pali Rohár wrote:
> > > > On Monday 05 June 2017
On Tuesday 04 July 2017 15:28:19 Pali Rohár wrote:
> On Tuesday 06 June 2017 22:50:52 Pali Rohár wrote:
> > On Tuesday 06 June 2017 19:02:01 Darren Hart wrote:
> > > On Tue, Jun 06, 2017 at 12:04:40PM +0200, Pali Rohár wrote:
> > > > On Monday 05 June 2017
On Wednesday 22 November 2017 12:03:52 Karel Zak wrote:
> On Wed, Nov 22, 2017 at 09:52:03AM +0100, Pali Rohár wrote:
> > I can prepare patches for blkid (util-linux), but I do not like idea to
> > have different algorithm how is read label in fatlabel and blkid. Both
>
On Wednesday 22 November 2017 12:03:52 Karel Zak wrote:
> On Wed, Nov 22, 2017 at 09:52:03AM +0100, Pali Rohár wrote:
> > I can prepare patches for blkid (util-linux), but I do not like idea to
> > have different algorithm how is read label in fatlabel and blkid. Both
>
On Monday 20 November 2017 12:12:56 Karel Zak wrote:
> On Sun, Nov 19, 2017 at 01:44:40PM +0100, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> > > So from all tests and discussion I would propose new unification:
> > >
> > &
On Monday 20 November 2017 12:12:56 Karel Zak wrote:
> On Sun, Nov 19, 2017 at 01:44:40PM +0100, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> > > So from all tests and discussion I would propose new unification:
> > >
> > &
Hi!
On Tuesday 21 November 2017 15:52:28 Oleksandr Natalenko wrote:
> Hi, Pali et al.
>
> Answers go inline.
>
> On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote:
> > What would happen if you enable wmi_requires_smbios_request?
> > Nothing? And situatio
Hi!
On Tuesday 21 November 2017 15:52:28 Oleksandr Natalenko wrote:
> Hi, Pali et al.
>
> Answers go inline.
>
> On úterý 21. listopadu 2017 14:51:10 CET Pali Rohár wrote:
> > What would happen if you enable wmi_requires_smbios_request?
> > Nothing? And situatio
hecking it in buffer/event
handling.
> Also, I've noticed this remark:
>
> ===
> /* Other entries could contain additional information */
> ===
>
> As you may see, they indeed do. Any unimplemented idea behind this statement?
If you look into dell_wmi_keymap_type_[] arr
d this remark:
>
> ===
> /* Other entries could contain additional information */
> ===
>
> As you may see, they indeed do. Any unimplemented idea behind this statement?
If you look into dell_wmi_keymap_type_[] array there are comments
what is after some key codes. E.g. after
ut.
>
> Here is acpidump output: [2]
> Here is decompiled DSDT: [3]
>
> Also, I've raised this question before a couple of times (for instance, [4]),
> but unfortunately got no result :(.
>
> Could you please help me in fixing multimedia keys?
I Hope that this email helps you.
> Thanks.
>
> [1] http://beta.hstor.org/files/c3b/a26/628/
> c3ba26628409486f8b9ae16d97be7d21.jpg
> [2] https://gist.github.com/7c04035ba2a3f0e5501af83efdb1456d
> [3] https://gist.github.com/83687126c46417b5bc0b48529de52460
> [4] https://www.spinics.net/lists/platform-driver-x86/msg05251.html
--
Pali Rohár
pali.ro...@gmail.com
ut.
>
> Here is acpidump output: [2]
> Here is decompiled DSDT: [3]
>
> Also, I've raised this question before a couple of times (for instance, [4]),
> but unfortunately got no result :(.
>
> Could you please help me in fixing multimedia keys?
I Hope that this email helps you.
> Thanks.
>
> [1] http://beta.hstor.org/files/c3b/a26/628/
> c3ba26628409486f8b9ae16d97be7d21.jpg
> [2] https://gist.github.com/7c04035ba2a3f0e5501af83efdb1456d
> [3] https://gist.github.com/83687126c46417b5bc0b48529de52460
> [4] https://www.spinics.net/lists/platform-driver-x86/msg05251.html
--
Pali Rohár
pali.ro...@gmail.com
_PRESSURE;
> @@ -2570,7 +2585,7 @@ static int alps_set_defaults_ss4_v2(struct psmouse
> *psmouse,
>
> alps_update_btn_info_ss4_v2(otp, priv);
>
> - alps_update_dual_info_ss4_v2(otp, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
; *psmouse,
>
> alps_update_btn_info_ss4_v2(otp, priv);
>
> - alps_update_dual_info_ss4_v2(otp, priv);
> + alps_update_dual_info_ss4_v2(otp, priv, psmouse);
>
> return 0;
> }
--
Pali Rohár
pali.ro...@gmail.com
On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> On Sunday 05 November 2017 14:06:08 Pali Rohár wrote:
> > On Wednesday 11 October 2017 23:24:35 Pali Rohár wrote:
> > > On Wednesday 04 October 2017 17:33:32 Pali Rohár wrote:
> > > > Hi! There is a big inco
On Thursday 09 November 2017 22:21:31 Pali Rohár wrote:
> On Sunday 05 November 2017 14:06:08 Pali Rohár wrote:
> > On Wednesday 11 October 2017 23:24:35 Pali Rohár wrote:
> > > On Wednesday 04 October 2017 17:33:32 Pali Rohár wrote:
> > > > Hi! There is a big inco
ease look at this patch as it partially revert your commit
4a646580f793 ("Input: ALPS - fix two-finger scroll breakage"). Something
smells here.
--
Pali Rohár
pali.ro...@gmail.com
, [0][0]))
> + if (alps_get_otp_values_ss4_v2(psmouse, 0, [0][0]) ||
> + alps_get_otp_values_ss4_v2(psmouse, 1, [1][0]))
> return -1;
>
> alps_update_device_area_ss4_v2(otp, priv);
Masaki Ota, please look at this patch as it partially revert your commit
4a646580f793 ("Input: ALPS - fix two-finger scroll breakage"). Something
smells here.
--
Pali Rohár
pali.ro...@gmail.com
a-rx51) -- lots of
> fun, but still a lot of work to do
>
> Best regards,
> Pavel
--
Pali Rohár
pali.ro...@gmail.com
a-rx51) -- lots of
> fun, but still a lot of work to do
>
> Best regards,
> Pavel
--
Pali Rohár
pali.ro...@gmail.com
s bug go
> bye-bye!
--
Pali Rohár
pali.ro...@gmail.com
s bug go
> bye-bye!
--
Pali Rohár
pali.ro...@gmail.com
On Sunday 12 November 2017 12:25:29 Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek <pa...@ucw.cz>
Acked-by: Pali Rohár <pali.ro...@gmail.com>
> diff --git a/ar
On Sunday 12 November 2017 12:25:29 Pavel Machek wrote:
>
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
>
> Signed-off-by: Pavel Machek
Acked-by: Pali Rohár
> diff --git a/arch/arm/boot/dts/omap3-n900.dts
> b/arch/ar
In struct quirk_entry some boolean fields used int, some u8 type. Change
them all to bool type.
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
---
drivers/platform/x86/dell-laptop.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x8
In struct quirk_entry some boolean fields used int, some u8 type. Change
them all to bool type.
Signed-off-by: Pali Rohár
---
drivers/platform/x86/dell-laptop.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c
b/drivers
On Thursday 02 November 2017 18:18:43 Darren Hart wrote:
> On Thu, Nov 02, 2017 at 09:25:24PM +0100, Pali Rohár wrote:
> > This machine reports number of keyboard backlight led levels, instead of
> > value of the last led level index. Therefore max_brightness properly needs
>
On Thursday 02 November 2017 18:18:43 Darren Hart wrote:
> On Thu, Nov 02, 2017 at 09:25:24PM +0100, Pali Rohár wrote:
> > This machine reports number of keyboard backlight led levels, instead of
> > value of the last led level index. Therefore max_brightness properly needs
>
On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote:
> On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote:
> > This function works pretty much like request_firmware(), but it prefer
> > usermode helper. If usermode helper fails then it fallback to direct
>
On Friday 10 November 2017 21:26:01 Luis R. Rodriguez wrote:
> On Fri, Nov 10, 2017 at 12:38:27AM +0100, Pali Rohár wrote:
> > This function works pretty much like request_firmware(), but it prefer
> > usermode helper. If usermode helper fails then it fallback to direct
>
front webcam to work? IIRC there was
problem that it was not possible to describe in DT that back and front
cameras.
And what happened with ramp mode for camera autofocus?
--
Pali Rohár
pali.ro...@gmail.com
front webcam to work? IIRC there was
problem that it was not possible to describe in DT that back and front
cameras.
And what happened with ramp mode for camera autofocus?
--
Pali Rohár
pali.ro...@gmail.com
+++ b/drivers/platform/x86/dell-wmi.c
> @@ -655,9 +655,11 @@ static int dell_wmi_events_set_enabled(bool enable)
> static int dell_wmi_probe(struct wmi_device *wdev)
> {
> struct dell_wmi_priv *priv;
> + int ret;
>
> - if (!wmi_has_guid(DELL_WMI_DESCRIPTOR_GUID))
> - return -ENODEV;
> + ret = dell_wmi_get_descriptor_valid();
> + if (ret)
> + return ret;
>
> priv = devm_kzalloc(
> >dev, sizeof(struct dell_wmi_priv), GFP_KERNEL);
Looks good,
Reviewed-by: Pali Rohár <pali.ro...@gmail.com>
--
Pali Rohár
pali.ro...@gmail.com
id);
>
> bool dell_wmi_get_interface_version(u32 *version);
> bool dell_wmi_get_size(u32 *size);
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 54321080a30d..39d2f4518483 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell
.
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
Acked-by: Pavel Machek <pa...@ucw.cz>
---
drivers/net/wireless/ti/wl1251/main.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/ti/wl1251/main.c
b/drivers/net/wirele
.
Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
---
drivers/net/wireless/ti/wl1251/main.c | 27 ++-
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/ti/wl1251/main.c
b/drivers/net/wireless/ti/wl1251/main.c
index 8929bb3..9106c20 100644
This function works pretty much like request_firmware(), but it prefer
usermode helper. If usermode helper fails then it fallback to direct
access. Useful for dynamic or model specific firmware data.
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
---
drivers/base/firmware_class.c
This function works pretty much like request_firmware(), but it prefer
usermode helper. If usermode helper fails then it fallback to direct
access. Useful for dynamic or model specific firmware data.
Signed-off-by: Pali Rohár
---
drivers/base/firmware_class.c | 45
wl1251
correct mac address since beginning of chip usage.
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
---
drivers/net/wireless/ti/wl1251/main.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/wireless/ti/wl1251/main.c
b/drivers/net/wireless/ti/wl1251/
wl1251
correct mac address since beginning of chip usage.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/ti/wl1251/main.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/wireless/ti/wl1251/main.c
b/drivers/net/wireless/ti/wl1251/main.c
index d497ba5..1f423be
If kmemdup fails, then wl->nvs_len will contain invalid non-zero size.
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
Acked-by: Pavel Machek <pa...@ucw.cz>
---
drivers/net/wireless/ti/wl1251/main.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drive
If kmemdup fails, then wl->nvs_len will contain invalid non-zero size.
Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
---
drivers/net/wireless/ti/wl1251/main.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ti/wl1251/main.c
b/drivers/
-firmware repository,
contains MAC address 00:00:20:07:03:09. So this MAC address is marked as
invalid as it is not real device specific address, just example one.
Format of calibration NVS data can be found at:
http://notaz.gp2x.de/misc/pnd/wl1251/nvs_map.txt
Signed-off-by: Pali Rohár <pali
Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
---
drivers/net/wireless/ti/wl1251/Kconfig |1 +
drivers/net/wireless/ti/wl1251/main.c |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/Kconfig
b/drivers/net/wireless/ti/wl1251/Kconfig
index
-firmware repository,
contains MAC address 00:00:20:07:03:09. So this MAC address is marked as
invalid as it is not real device specific address, just example one.
Format of calibration NVS data can be found at:
http://notaz.gp2x.de/misc/pnd/wl1251/nvs_map.txt
Signed-off-by: Pali Rohár
Signed-off-by: Pali Rohár
---
drivers/net/wireless/ti/wl1251/Kconfig |1 +
drivers/net/wireless/ti/wl1251/main.c |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/Kconfig
b/drivers/net/wireless/ti/wl1251/Kconfig
index 7142ccf..affe154 100644
---
of patches as Pavel requested
Pali Rohár (6):
wl1251: Update wl->nvs_len after wl->nvs is valid
wl1251: Generate random MAC address only if driver does not have
valid
wl1251: Parse and use MAC address from supplied NVS data
wl1251: Set generated MAC address back to NVS data
firmwar
of patches as Pavel requested
Pali Rohár (6):
wl1251: Update wl->nvs_len after wl->nvs is valid
wl1251: Generate random MAC address only if driver does not have
valid
wl1251: Parse and use MAC address from supplied NVS data
wl1251: Set generated MAC address back to NVS data
firmwar
On Thursday 09 November 2017 22:45:40 Pavel Machek wrote:
> On Thu 2017-11-09 22:29:45, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:06:15 Pavel Machek wrote:
> > > diff --git a/drivers/power/supply/bq27xxx_battery.c
> > > b/drivers/power/supply/bq27xxx_ba
On Thursday 09 November 2017 22:45:40 Pavel Machek wrote:
> On Thu 2017-11-09 22:29:45, Pali Rohár wrote:
> > On Thursday 09 November 2017 22:06:15 Pavel Machek wrote:
> > > diff --git a/drivers/power/supply/bq27xxx_battery.c
> > > b/drivers/power/supply/bq27xxx_ba
> [BQ27XXX_REG_CTRL] = 0x00,
> [BQ27XXX_REG_TEMP] = 0x06,
Hi! IIRC those registers are valid only for sn27521 chip in revision 14
(or new). For older revision is used different register map. And
detection of chip revision is somehow possible via some registers.
--
Pali Rohár
pali.ro...@gmail.com
> [BQ27XXX_REG_CTRL] = 0x00,
> [BQ27XXX_REG_TEMP] = 0x06,
Hi! IIRC those registers are valid only for sn27521 chip in revision 14
(or new). For older revision is used different register map. And
detection of chip revision is somehow possible via some registers.
--
Pali Rohár
pali.ro...@gmail.com
On Sunday 05 November 2017 14:06:08 Pali Rohár wrote:
> On Wednesday 11 October 2017 23:24:35 Pali Rohár wrote:
> > On Wednesday 04 October 2017 17:33:32 Pali Rohár wrote:
> > > Hi! There is a big inconsistency in Linux tools which read or write
> > > FAT32 label in
On Sunday 05 November 2017 14:06:08 Pali Rohár wrote:
> On Wednesday 11 October 2017 23:24:35 Pali Rohár wrote:
> > On Wednesday 04 October 2017 17:33:32 Pali Rohár wrote:
> > > Hi! There is a big inconsistency in Linux tools which read or write
> > > FAT32 label in
On Thursday 09 November 2017 11:21:25 Theodore Ts'o wrote:
> On Thu, Nov 09, 2017 at 10:01:45AM +0100, Pali Rohár wrote:
> > > > You would have stored LABEL42 in boot sector and no label in root
> > > > directory. Windows handle this situation as there is no label.
>
On Thursday 09 November 2017 11:21:25 Theodore Ts'o wrote:
> On Thu, Nov 09, 2017 at 10:01:45AM +0100, Pali Rohár wrote:
> > > > You would have stored LABEL42 in boot sector and no label in root
> > > > directory. Windows handle this situation as there is no label.
>
On Thursday 09 November 2017 16:13:52 mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Pali Rohár [mailto:pali.ro...@gmail.com]
> > Sent: Thursday, November 9, 2017 10:03 AM
> > To: Limonciello, Mario <mario_limoncie...@dell.com>
>
On Thursday 09 November 2017 16:13:52 mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: Pali Rohár [mailto:pali.ro...@gmail.com]
> > Sent: Thursday, November 9, 2017 10:03 AM
> > To: Limonciello, Mario
> > Cc: dvh...@infradead.org; Andy Sh
static int dell_wmi_events_set_enabled(bool enable)
> static int dell_wmi_probe(struct wmi_device *wdev)
> {
> struct dell_wmi_priv *priv;
> + int ret;
>
> if (!wmi_has_guid(DELL_WMI_DESCRIPTOR_GUID))
> return -ENODEV;
Just one suggestion, is above check still needed in dell-wmi.c code?
I think that now it should be job of dell_wmi_get_descriptor_valid()
function to fully validate if dell wmi descriptor driver is able to
provide all needed information for dell-wmi driver.
> + ret = dell_wmi_get_descriptor_valid();
> + if (ret)
> + return ret;
> +
> priv = devm_kzalloc(
> >dev, sizeof(struct dell_wmi_priv), GFP_KERNEL);
> if (!priv)
--
Pali Rohár
pali.ro...@gmail.com
set_enabled(bool enable)
> static int dell_wmi_probe(struct wmi_device *wdev)
> {
> struct dell_wmi_priv *priv;
> + int ret;
>
> if (!wmi_has_guid(DELL_WMI_DESCRIPTOR_GUID))
> return -ENODEV;
Just one suggestion, is above check still needed in dell-wmi.c code?
I think that now it should be job of dell_wmi_get_descriptor_valid()
function to fully validate if dell wmi descriptor driver is able to
provide all needed information for dell-wmi driver.
> + ret = dell_wmi_get_descriptor_valid();
> + if (ret)
> + return ret;
> +
> priv = devm_kzalloc(
> >dev, sizeof(struct dell_wmi_priv), GFP_KERNEL);
> if (!priv)
--
Pali Rohár
pali.ro...@gmail.com
it on
all places to let it consistent. Because your change introduces just
inconsistency.
--
Pali Rohár
pali.ro...@gmail.com
it on
all places to let it consistent. Because your change introduces just
inconsistency.
--
Pali Rohár
pali.ro...@gmail.com
ell.com>
Reviewed-by: Pali Rohár <pali.ro...@gmail.com>
> ---
> drivers/platform/x86/dell-wmi-descriptor.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi-descriptor.c
> b/drivers/platform/x86/dell-wmi-descriptor.c
> index 3
On Friday 03 November 2017 11:27:21 Mario Limonciello wrote:
> devm_kzalloc will return NULL pointer if no memory was allocated.
> This should be checked. This problem also existed when the driver
> was dell-wmi.c.
>
> Signed-off-by: Mario Limonciello
Reviewed-by: Pali Rohár
&
On Tuesday 07 November 2017 12:28:41 Theodore Ts'o wrote:
> On Sun, Nov 05, 2017 at 10:12:49PM +0100, Pali Rohár wrote:
> > Easy way how to achieve this situation:
> >
> > 1. use mkdosfs to format hard disk to FAT32 with label LABEL42
> >
> > 2. boot
On Tuesday 07 November 2017 12:28:41 Theodore Ts'o wrote:
> On Sun, Nov 05, 2017 at 10:12:49PM +0100, Pali Rohár wrote:
> > Easy way how to achieve this situation:
> >
> > 1. use mkdosfs to format hard disk to FAT32 with label LABEL42
> >
> > 2. boot
801 - 900 of 4324 matches
Mail list logo
