On 28/02/14 19:00, Boris Ostrovsky wrote:
> On 02/28/2014 12:46 PM, Roger Pau Monné wrote:
>> On 28/02/14 18:20, Boris Ostrovsky wrote:
>>> On 02/27/2014 01:45 PM, Boris Ostrovsky wrote:
>>>> On 02/27/2014 01:15 PM, Roger Pau Monne wrote:
>>>>> Add supp
aitqueue_head+0x60/0x60
>>> [ 438.029913] [] ? trace_hardirqs_on+0xd/0x10
>>> [ 438.029919] [] ? _raw_spin_unlock_irqrestore+0x81/0x90
>>> [ 438.029925] [] ? xen_blkif_be_int+0x40/0x40
>>> [ 438.029932] [] kthread+0xe4/0x100
>>> [ 438.029938] [] ? _ra
On 11/02/14 18:52, David Vrabel wrote:
> On 11/02/14 17:40, Roger Pau Monné wrote:
>> On 11/02/14 17:07, Sander Eikelenboom wrote:
>>>
>>> Tuesday, February 11, 2014, 4:56:50 PM, you wrote:
>>>
>>>> On Tue, Feb 11, 2014 at 04:52:15PM
down.
Good catch.
> Cc: Konrad Rzeszutek Wilk
> Cc: "Roger Pau Monné"
> Cc: Ian Campbell
> Cc: David Vrabel
> Cc: linux-kernel@vger.kernel.org
> Cc: xen-de...@lists.xen.org
> Cc: Anthony Liguori
> Signed-off-by: Matt Rushton
> Signed-off-by: Matt Wils
some checks in xen_blkif_free to make sure we are cleaning
everything.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc: Boris Ostrovsky
Cc: Matt Rushton
Cc: Matt Wilson
Cc: Ian Campbell
---
This should be applied after the patch:
xen-blkback: fix memory leak when pe
Blkback cannot work properly on auto-translated guests if Xen doesn't
update the IOMMU when performing grant maps/unmaps, so only attach if
the newly introduced XENFEAT_hvm_gntmap_supports_iommu is found.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc:
On 04/04/14 17:01, David Vrabel wrote:
> On 04/04/14 15:41, Roger Pau Monne wrote:
>> Blkback cannot work properly on auto-translated guests if Xen doesn't
>> update the IOMMU when performing grant maps/unmaps, so only attach if
>> the newly introduced XENFEAT_hvm_gntm
On 09/01/14 16:30, Wei Liu wrote:
> On Wed, Jan 08, 2014 at 12:10:10AM +, Zoltan Kiss wrote:
>> This patch contains the new definitions necessary for grant mapping.
>>
>> v2:
>> - move unmapping to separate thread. The NAPI instance has to be scheduled
>> even from thread context, which can c
On 09/11/13 16:36, Felipe Pena wrote:
> In the blkif_release function the bdget_disk() call might returns
> a NULL ptr which might be dereferenced on bdev->bd_openers checking
>
> Signed-off-by: Felipe Pena
> ---
> drivers/block/xen-blkfront.c |4
> 1 file changed, 4 insertions(+)
>
>
when it is not actually needed.
Signed-off-by: Roger Pau Monné
Reported-by: Felipe Franciosi
Cc: Felipe Franciosi
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
---
drivers/block/xen-blkfront.c | 124 ++
1 files changed, 100 insertions(+), 24 deletions(-
was
incorrectly using the X86_32 protocol ABI. This patch fixes it, but
also breaks compatibility, so an ARM DomU kernel compiled with
this patch will fail to communicate with PV disk devices unless the
Dom0 also has this patch.
Signed-off-by: Roger Pau Monné
Reported-by: Julien Grall
Cc: Julien
On 03/12/13 12:01, David Vrabel wrote:
> On 03/12/13 10:57, Roger Pau Monne wrote:
>> Using __packed__ on the public interface is not correct, this
>> structures should be compiled using the native ABI, and __packed__
>> should only be used in the backend counterpart of those
On 03/12/13 12:05, Ian Campbell wrote:
> On Tue, 2013-12-03 at 11:57 +0100, Roger Pau Monne wrote:
>> Using __packed__ on the public interface is not correct, this
>> structures should be compiled using the native ABI, and __packed__
>> should only be used in the backend
On 03/12/13 12:14, Jan Beulich wrote:
>>>> On 03.12.13 at 11:57, Roger Pau Monne wrote:
>> struct blkif_request_rw {
>> uint8_tnr_segments; /* number of segments */
>> blkif_vdev_t handle; /* only for read/write
On 04/12/13 10:28, Ian Campbell wrote:
> On Tue, 2013-12-03 at 15:11 -0500, Konrad Rzeszutek Wilk wrote:
If Konrad and Boris agree that breaking the kernel's ABI in this way is
acceptable in this specific case, I'll defer to them.
>>>
>>> My opinion as Xen on ARM hypervisor maintainer is
freezed.
>>
>> Only one architecture (x86_32) doesn't have 64-bit ABI for the block
>> interface.
>> Don't add padding if Linux is compiled for this architecture.
>
> Konrad asked for confirmation that this didn't change x86.
I've also tested this u
El 22/08/14 a les 13.20, Arianna Avanzini ha escrit:
> Hello,
[...]
> The patchset implements in the backend driver the retrieval of information
> about the currently-in-use block layer API for a certain device and about
> the number of available submission queues, if the API turns out to be the
>
On 20/05/14 11:54, Vitaly Kuznetsov wrote:
> Vitaly Kuznetsov writes:
>
>> 1) ramdisks (/dev/ram*) (persistent grants and indirect descriptors
>> disabled)
>
> sorry, there was a typo. persistent grants and indirect descriptors are
> enabled with ramdisks, otherwise such testing won't make any s
On 08/04/14 19:25, kon...@kernel.org wrote:
> From: Konrad Rzeszutek Wilk
>
> When we migrate an HVM guest, by default our shared_info can
> only hold up to 32 CPUs. As such the hypercall
> VCPUOP_register_vcpu_info was introduced which allowed us to
> setup per-page areas for VCPUs. This means w
On 08/04/14 20:53, Konrad Rzeszutek Wilk wrote:
> On Tue, Apr 08, 2014 at 08:18:48PM +0200, Roger Pau Monné wrote:
>> On 08/04/14 19:25, kon...@kernel.org wrote:
>>> From: Konrad Rzeszutek Wilk
>>>
>>> When we migrate an HVM guest, by default our shared_info
On 09/04/14 10:33, Ian Campbell wrote:
> On Tue, 2014-04-08 at 14:53 -0400, Konrad Rzeszutek Wilk wrote:
>> On Tue, Apr 08, 2014 at 08:18:48PM +0200, Roger Pau Monné wrote:
>>> On 08/04/14 19:25, kon...@kernel.org wrote:
>>>> From: Konrad Rzeszutek Wilk
>>>
On 10/06/14 15:19, Vitaly Kuznetsov wrote:
> Vitaly Kuznetsov writes:
>
>> Jiri Slaby writes:
>>
>>> On 06/04/2014 07:48 AM, Greg KH wrote:
On Wed, May 14, 2014 at 03:11:22PM -0400, Konrad Rzeszutek Wilk wrote:
> Hey Greg
>
> This email is in regards to backporting two patches t
Ping?
On 23/05/14 20:08, Roger Pau Monné wrote:
> On 23/05/14 19:51, Konrad Rzeszutek Wilk wrote:
>> On Thu, May 22, 2014 at 04:40:07PM +0200, Roger Pau Monne wrote:
>>> We are missing a check to see if the backend supports persistent
>>> grants on resume, meaning
ou are OK with the backport, I am volunteering Roger and Felipe to assist
>> in jamming^H^H^H^Hbackporting the patches into earlier kernels.
>
> Sure, can you provide backported patches? As-is, they don't apply to
> the 3.10-stable kernel.
Here are the backported patches to 3
We are missing a check to see if the backend supports persistent
grants on resume, meaning we will always run with the value fetched
from the firsts host on which we run on.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
---
drivers/block/xen-blkfront.c | 23
On 23/05/14 19:51, Konrad Rzeszutek Wilk wrote:
> On Thu, May 22, 2014 at 04:40:07PM +0200, Roger Pau Monne wrote:
>> We are missing a check to see if the backend supports persistent
>> grants on resume, meaning we will always run with the value fetched
>> from the firsts ho
On 24/05/14 03:33, Mukesh Rathor wrote:
> When running as dom0 in pvh mode, foreign pfns that are accessed must be
> added to our p2m which is managed by xen. This is done via
> XENMEM_add_to_physmap_range hypercall. This is needed for toolstack
> building guests and mapping guest memory, xentrace
On 27/01/14 17:09, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote:
>> I've at least identified two possible memory leaks in blkback, both
>> related to the shutdown path of a VBD:
>>
>> - We don't wait for an
On 27/01/14 22:21, Konrad Rzeszutek Wilk wrote:
> On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote:
>> I've at least identified two possible memory leaks in blkback, both
>> related to the shutdown path of a VBD:
>>
>> - We don't wait for an
On 28/01/14 16:37, Konrad Rzeszutek Wilk wrote:
> On Tue, Jan 28, 2014 at 01:44:37PM +0100, Roger Pau Monné wrote:
>> On 27/01/14 22:21, Konrad Rzeszutek Wilk wrote:
>>> On Mon, Jan 27, 2014 at 11:13:41AM +0100, Roger Pau Monne wrote:
>>>> @@ -976,17 +983,19 @@ static
From: Matt Rushton
Currently shrink_free_pagepool() is called before the pages used for
persistent grants are released via free_persistent_gnts(). This
results in a memory leak when a VBD that uses persistent grants is
torn down.
Cc: Konrad Rzeszutek Wilk
Cc: "Roger Pau Monné"
Move the call to xen_blkif_put after we have freed the request,
otherwise we have a race between the release of the request and the
cleanup done in xen_blkif_free.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc: Boris Ostrovsky
Cc: Matt Rushton
Cc: Matt Wilson
cleaning
everything.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc: Boris Ostrovsky
Cc: Matt Rushton
Cc: Matt Wilson
Cc: Ian Campbell
---
drivers/block/xen-blkback/blkback.c | 27 ++-
drivers/block/xen-blkback/common.h |1
blkback bug fixes for memory leaks (patches 1 and 2) and a race
(patch 3).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at htt
On 29/01/14 08:52, Jan Beulich wrote:
>>>> On 28.01.14 at 18:43, Roger Pau Monne wrote:
>> --- a/drivers/block/xen-blkback/blkback.c
>> +++ b/drivers/block/xen-blkback/blkback.c
>> @@ -985,17 +985,31 @@ static void __end_block_io_op(struct pending_req
>> *pe
On 30/01/14 00:15, Mukesh Rathor wrote:
> Konrad,
>
> The CR4 settings were dropped from my earlier patch because you didn't
> wanna enable them. But since you do now, we need to set them in the APs
> also. If you decide not too again, please apply my prev patch
> "pvh: disable pse feature for now
On 29/01/14 09:52, Jan Beulich wrote:
>>>> On 28.01.14 at 18:43, Roger Pau Monne wrote:
>> --- a/drivers/block/xen-blkback/blkback.c
>> +++ b/drivers/block/xen-blkback/blkback.c
>> @@ -985,17 +985,31 @@ static void __end_block_io_op(struct pending_req
>> *pe
On 04/02/14 09:02, Jan Beulich wrote:
>>>> On 03.02.14 at 17:58, Roger Pau Monné wrote:
>> On 29/01/14 09:52, Jan Beulich wrote:
>>>>>> On 28.01.14 at 18:43, Roger Pau Monne wrote:
>>>> + free_req(blkif, pending_req);
>>>> +
On 04/02/14 09:31, Jan Beulich wrote:
>>>> On 04.02.14 at 09:16, Roger Pau Monné wrote:
>> On 04/02/14 09:02, Jan Beulich wrote:
>>>>>> On 03.02.14 at 17:58, Roger Pau Monné wrote:
>>>> On 29/01/14 09:52, Jan Beulich wrote:
>&
This series contain blkback bug fixes for memory leaks (patches 1 and
2) and a race (patch 3). Patch 4 removes blkif_request_segment_aligned
since its memory layout is exactly the same as blkif_request_segment
and should introduce no functional change.
All patches should be backported to stable
cleaning
everything.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc: Boris Ostrovsky
Cc: Matt Rushton
Cc: Matt Wilson
Cc: Ian Campbell
---
drivers/block/xen-blkback/blkback.c | 27 ++-
drivers/block/xen-blkback/common.h |1
assume PAGE_SIZE == 4096.
Signed-off-by: Roger Pau Monné
[Description fix by Jan Beulich]
Signed-off-by: Jan Beulich
Reported-by: Jan Beulich
Cc: Konrad Rzeszutek Wilk
Cc: David Vrabel
Cc: Boris Ostrovsky
Cc: Matt Rushton
Cc: Matt Wilson
---
drivers/block/xen-blkback/blkback.c |2
From: Matt Rushton
Currently shrink_free_pagepool() is called before the pages used for
persistent grants are released via free_persistent_gnts(). This
results in a memory leak when a VBD that uses persistent grants is
torn down.
Cc: Konrad Rzeszutek Wilk
Cc: "Roger Pau Monné"
Introduce a new variable to keep track of the number of in-flight
requests. We need to make sure that when xen_blkif_put is called the
request has already been freed and we can safely free xen_blkif, which
was not the case before.
Signed-off-by: Roger Pau Monné
Cc: Konrad Rzeszutek Wilk
Cc
On 11/12/13 17:18, Stefano Stabellini wrote:
> On Tue, 3 Dec 2013, Konrad Rzeszutek Wilk wrote:
If Konrad and Boris agree that breaking the kernel's ABI in this way is
acceptable in this specific case, I'll defer to them.
>>>
>>> My opinion as Xen on ARM hypervisor maintainer is that this
gt;>^
>> drivers/block/xen-blkfront.c:492:19: note: 'pfn' was declared here
>> unsigned long pfn;
>>
>> Cc: Konrad Rzeszutek Wilk
>> Cc: Boris Ostrovsky
>> Cc: David Vrabel
>> Signed-off-by: Tim Gardner
Acked-by: Rog
On 07/02/14 05:24, Matt Wilson wrote:
> Just in case the various mailing list software ate Matt's messages, he
> sent the following:
>
> [PATCH v2 2/4] xen-blkback: fix memory leaks
> Tested-by: Matt Rushton
> Reviewed-by: Matt Rushton
>
> [PATCH v2 3/4] xen-blkback: fix shutdown race
> Tested-
ed-off-by: Bob Liu
Thanks, this looks correct indeed. If we are using persistent grants the
indirect_pages list should always be empty because blkfront has
pre-allocated enough persistent pages to fill all requests on the ring.
Acked-by: Roger Pau Monné
Should be backported to stable branc
sted, we can split the part of blkfront_connect that checks for
> optional features, like persistent grants, indirect descriptors and
> flush/barrier features to a separate function and call it from both
> blkfront_connect and blkif_recover
>
> Signed-off-by: Bob Liu
Acked-by: Rog
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
Should be backported to stable branches.
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordo
indirect grant, the other for bio page.
>
> Signed-off-by: Julien Grall
Thanks, this looks fine:
Acked-by: Roger Pau Monné
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo in
^first ^in
> This could be improved by share the page with multiple grants.
^sharing
>
> Signed-off-by: Julien Grall
LGTM:
Acked-by: Roger Pau Monné
Just one question.
[...]
> @@ -559,73 +669,30 @@ static int blkif_queue_r
could be improved by sharing the page between
> multiple grants.
>
> Signed-off-by: Julien Grall
LGTM:
Acked-by: Roger Pau Monné
> ---
>
> Cc: Konrad Rzeszutek Wilk
> Cc: "Roger Pau Monné"
> Cc: Boris Ostrovsky
> Cc: David Vrabel
>
> Improvem
El 20/08/15 a les 2.40, Julien Grall ha escrit:
> Hi,
>
> Ping? I'm missing some reviews on block and netfront code.
Sorry, I didn't realize some of the patches were changed and the Ack
dropped. I think I've reviewed everything related to block.
Roger.
--
To unsubscribe from this list: send the
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-by: J
El 12/11/15 a les 18.30, Julien Grall ha escrit:
> Hi,
>
> On 12/11/15 16:40, Roger Pau Monné wrote:
>>> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>>>
>>> Signed-off-by: Julien Grall
>>
>> LGTM, only a couple of typos
El 12/11/15 a les 19.04, Julien Grall ha escrit:
> On 12/11/15 17:51, Roger Pau Monné wrote:
>> El 12/11/15 a les 18.30, Julien Grall ha escrit:
>>> Hi,
>>>
>>> On 12/11/15 16:40, Roger Pau Monné wrote:
>>>>> [1] http://lists.xen.org/archives/html
ted.
> The block code will set the mimimum size supported and we may be able
> to support directly any change in the block framework that lower down
> the minimal size of a request.
>
> [1] http://lists.xen.org/archives/html/xen-devel/2015-08/msg02200.html
>
> Signed-off-by:
El 14/12/15 a les 16.27, Konrad Rzeszutek Wilk ha escrit:
> On Sat, Dec 12, 2015 at 07:25:55PM -0500, Boris Ostrovsky wrote:
>> Using MMUEXT_TLB_FLUSH_MULTI doesn't buy us much since the hypervisor
>> will likely perform same IPIs as would have the guest.
>>
>
> But if the VCPU is asleep, doing it
El 10/09/15 a les 13.48, Julien Grall ha escrit:
> On 10/09/15 12:32, Andrew Turner wrote:
>> On Thu, 10 Sep 2015 16:41:56 +0800
>> Shannon Zhao wrote:
>>
>>> From: Shannon Zhao
>>>
>>> These EFI stub parameters are used to internal communication between
>>> EFI stub and Linux kernel and EFI stub
El 07/09/15 a les 17.33, Julien Grall ha escrit:
> Hi all,
>
> ARM64 Linux is supporting both 4KB and 64KB page granularity. Although, Xen
> hypercall interface and PV protocol are always based on 4KB page granularity.
>
> Any attempt to boot a Linux guest with 64KB pages enabled will result to a
Hello,
El 14/09/15 a les 12.40, Julien Grall ha escrit:
> Hi Roger,
>
> On 14/09/15 09:56, Roger Pau Monné wrote:
>> El 07/09/15 a les 17.33, Julien Grall ha escrit:
>>> Hi all,
>>>
>>> ARM64 Linux is supporting both 4KB and 64KB page granularity. Al
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> This BUG_ON() will be triggered when previous purge work haven't finished.
> It's reasonable under pretty extreme load and should not panic the system.
>
> Signed-off-by: Bob Liu
> ---
> drivers/block/xen-blkback/blkback.c |4 +++-
> 1 file change
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> This BUG_ON() in blkif_free() is incorrect, because indirect page can be added
> to list info->indirect_pages in blkif_completion() no matter
> feature_persistent
> is true or false.
>
> Signed-off-by: Bob Liu
Acked-by: Roger
El 21/07/15 a les 5.30, Bob Liu ha escrit:
> There is a bug when migrate from !feature-persistent host to
> feature-persistent
> host, because domU still think new host/backend don't support persistent.
> Dmesg like:
> backed has not unmapped grant: 839
> backed has not unmapped grant: 773
> backe
only used for read/write request.
>
> Rather than having a function with 2 distinct execution path, separate
> the function in 2. This will also remove one level of tabulation.
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris O
Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris Ostrovsky
> Cc: David Vrabel
Acked-by: Roger Pau Monné
With one style fix.
[...]
> static struct grant *get_grant(grant_ref_t *gref_head,
> - unsigned long pfn,
>
indirect grant, the other for bio page.
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc: Boris Ostrovsky
> Cc: David Vrabel
> ---
> Changes in v2:
> - Patch added
> ---
> drivers/block/xen-blkfront.c | 85
&g
^ initial^ used.
> This could be improved by share the page with multiple grants.
^ sharing the page between
>
> Signed-off-by: Julien Grall
> Cc: Konrad Rzeszutek Wilk
> Cc: Roger Pau Monné
> Cc:
El 20/01/16 a les 22.33, Luis R. Rodriguez ha escrit:
> On Wed, Jan 20, 2016 at 1:00 PM, Konrad Rzeszutek Wilk
> wrote:
>>> +static bool x86_init_fn_supports_subarch(struct x86_init_fn *fn)
>>> +{
>>> + if (!fn->supp_hardware_subarch) {
>>> + pr_err("Init sequence fails to declares
El 22/01/16 a les 13.34, Wei Liu ha escrit:
> The comment at the beginning of the file is the canonical source of
> licenses for this module. Currently it contains GPL and MIT license.
> Fix the code to reflect the reality.
>
> Signed-off-by: Wei Liu
Acked-by: Roger Pau Monné
Thanks.
El 26/2/16 a les 16:10, Boris Ostrovsky ha escrit:
> On 02/26/2016 09:42 AM, Brian Gerst wrote:
>> On Fri, Feb 26, 2016 at 8:51 AM, Boris Ostrovsky
>> wrote:
>>> On 02/26/2016 05:53 AM, Roger Pau Monné wrote:
>>>> El 25/2/16 a les 16:16, Boris Ostrovsky ha
El 25/2/16 a les 16:16, Boris Ostrovsky ha escrit:
> PV guests need to have their .bss zeroed out since it is not guaranteed
> to be cleared by Xen's domain builder
I guess I'm missing something, but elf_load_image (in libelf-loader.c)
seems to be able to clear segments (it will zero the memory be
El 14/05/15 a les 19.00, Julien Grall ha escrit:
> From: Julien Grall
>
> Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
Note that Bob multipage ring patches also remove this.
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
gt; Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
El 14/05/15 a les 19.00, Julien Grall ha escrit:
> From: Julien Grall
>
> Make the code less confusing to read now that Linux may not have the
> same page size as Xen.
>
> Signed-off-by: Julien Grall
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the
El 20/05/15 a les 15.21, Julien Grall ha escrit:
> Hi,
>
> On 20/05/15 14:10, Bob Liu wrote:
>> ---
>> drivers/block/xen-blkback/blkback.c | 12
>> drivers/block/xen-blkback/common.h | 3 +-
>> drivers/block/xen-blkback/xenbus.c | 85 +---
>> drivers/block/xen-b
' and
> 'multi-queue' features.
>
> Changes in v2:
> - Re-write the commit message to be more clear.
>
> Signed-off-by: Bob Liu
With that fixed:
Acked-by: Roger Pau Monné
Roger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&
El 20/05/15 a les 15.10, Bob Liu ha escrit:
> Extend xen/block to support multi-page ring, so that more requests can be
> issued
> by using more than one pages as the request ring between blkfront and backend.
> As a result, the performance can get improved significantly.
>
> We got some impressi
El 21/05/15 a les 15.03, Bob Liu ha escrit:
> On 05/21/2015 07:22 PM, Roger Pau Monné wrote:
>> El 20/05/15 a les 15.10, Bob Liu ha escrit:
>>> + err = xenbus_scanf(XBT_NIL, dev->otherend,
>>> + ring_ref_name,
El 12/05/15 a les 13.01, Bob Liu ha escrit:
> The right place for talk_to_blkback() to query backend features and transport
> parameters is after backend entered XenbusStateInitWait. There is no problem
talk_to_blkback doesn't gather any backend features, it just publishes
the features supported b
El 12/05/15 a les 13.01, Bob Liu ha escrit:
> Extend xen/block to support multi-page ring, so that more requests can be
> issued
> by using more than one pages as the request ring between blkfront and backend.
> As a result, the performance can get improved significantly.
El 15/05/15 a les 13.03, Bob Liu ha escrit:
>
> On 05/15/2015 06:01 PM, Roger Pau Monné wrote:
>> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>>> The right place for talk_to_blkback() to query backend features and
>>> transport
>>> parameters is after bac
El 15/05/15 a les 13.35, Bob Liu ha escrit:
>
> On 05/15/2015 07:14 PM, Roger Pau Monné wrote:
>> El 15/05/15 a les 13.03, Bob Liu ha escrit:
>>>
>>> On 05/15/2015 06:01 PM, Roger Pau Monné wrote:
>>>> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>
El 15/05/15 a les 14.06, Bob Liu ha escrit:
>
> On 05/15/2015 07:13 PM, Roger Pau Monné wrote:
>> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>>> Extend xen/block to support multi-page ring, so that more requests can be
>>> issued
>>> by using more tha
Hello,
El 25/03/15 a les 11.02, Bob Liu ha escrit:
> + gnttab_unmap_refs_async(&unmap_data);
> + wait_for_completion(&unmap_completion);
I think David had a comment about putting this into some kind of common
helper since it's used widely (at least in blkback). Could you l
El 13/03/15 a les 16.52, Tao Chen ha escrit:
> The blkback name is like blkback.domid.xvd[a-z], if domid has three digits
> (means larger than 100), then the backmost xvd wouldn't be fully shown.
>
> Define a BLKBACK_NAME_LEN macro which is (TASK_COMM_LEN * 2), enlarge the
> array size of blkback
nt
> case.
> Purge persistent pages can't be unmapped either unless no longer in use.
>
> Signed-off-by: Bob Liu
AFAICT since this is basically the same patch as what I've sent:
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe li
El 26/03/15 a les 13.16, Bob Liu ha escrit:
> There are several place using gnttab async unmap and wait for
> completion, so move the common code to a function
> gnttab_unmap_refs_async_wait_completion().
>
> Signed-off-by: Bob Liu
For the blkback parts:
Acked-by: Roger Pau M
name, so it will be fully shown in any case.
>
> Signed-off-by: Tao Chen
Acked-by: Roger Pau Monné
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/maj
xen-blkback: default to X86_32 ABI on x86
Roger Pau Monne (2):
xen-blkback,xen-blkfront: add myself as maintainer
xen-blkfront: fix accounting of reqs when migrating
MAINTAINERS| 1 +
drivers/block/xen-blkback/common.h | 9 +
drivers/block/xen-bl
El 23/01/15 a les 10.14, Bob Liu ha escrit:
> Extend xen/block to support multi-page ring.
> * xen-blkback notify blkfront with feature-multi-ring-pages
> * xen-blkfront write to xenstore about how many pages are used as the ring
>
> If using 4 pages as the ring, inflight requests inscreased fro
Current migration code uses blk_put_request in order to finish a request
before requeuing it. This function doesn't update the statistics of the
queue, which completely screws accounting. Use blk_end_request_all instead
which properly updates the statistics of the queue.
Signed-off-by: Roge
Hello,
El 12/02/15 a les 9.54, Sander Eikelenboom ha escrit:
> Hi,
>
> With a 3.19 kernel + xen-devel tree pulled on top i run into this splat below.
> It's on a Xen PV-guest running a postgres database and doing a pg_dump at that
> moment in time, after running for a while (within 2 days or so).
El 16/12/14 a les 11.11, Bob Liu ha escrit:
> The default maximum value of segments in indirect requests was 32, IO
> operations with bigger block size(>32*4k) would be split and performance start
> to drop.
>
> Nowadays backend device usually support 512k max_sectors_kb on desktop, and
> may larg
El 21/01/15 a les 8.56, Bob Liu ha escrit:
> The default max-segments of indirect requests was 32, so IO operations with
> bigger block size(>32*4k) would be split and make performance drop.
>
> Nowadays backend device usually support 512k max_sectors_kb on desktop,
> and usually larger on server
El 19/02/15 a les 3.05, Bob Liu ha escrit:
>
>
> On 02/19/2015 02:08 AM, Felipe Franciosi wrote:
>>> -Original Message-
>>> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
>>> Sent: 18 February 2015 17:38
>>> To: Roger Pau Monne
&g
El 19/02/15 a les 13.06, Felipe Franciosi ha escrit:
>
>
>> -Original Message-
>> From: David Vrabel
>> Sent: 19 February 2015 11:15
>> To: Roger Pau Monne; Bob Liu; Felipe Franciosi
>> Cc: 'Konrad Rzeszutek Wilk'; xen-de...@lists.xen.org;
El 15/02/15 a les 9.18, Bob Liu ha escrit:
> A ring is the representation of a hardware queue, this patch separate ring
> information from blkfront_info to an new struct blkfront_ring_info to make
> preparation for real multi hardware queues supporting.
>
> Signed-off-by: Arianna Avanzini
> Signe
301 - 400 of 553 matches
Mail list logo
