[PATCH 1/2] i2c: pmcmsp: return message count on master_xfer success

Returning zero is wrong in this case. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/i2c/busses/i2c-pmcmsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 2aa0e83174c5..ec27e27e8d06

[PATCH 1/2] i2c: pmcmsp: return message count on master_xfer success

Returning zero is wrong in this case. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-pmcmsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 2aa0e83174c5..ec27e27e8d06 100644 --- a/drivers/i2c

[PATCH 2/2] i2c: robotfuzz-osif: drop pointless test

In the for-loop test, ret will be either 0 or 1. So, the comparison is pointless. Drop it, and drop the initializer which is then also pointless. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/i2c/busses/i2c-robotfuzz-osif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH 2/2] i2c: robotfuzz-osif: drop pointless test

In the for-loop test, ret will be either 0 or 1. So, the comparison is pointless. Drop it, and drop the initializer which is then also pointless. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-robotfuzz-osif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] i2c: exynos5: remove pointless initializers

The variables are always assigned before use anyway. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/i2c/busses/i2c-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c index a2cbc7

[PATCH 2/2] i2c: exynos5: remove pointless initializers

The variables are always assigned before use anyway. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-exynos5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c index a2cbc779c33a..185fba37e830 100644

[PATCH] i2c: hix5hd2: remove some dead code

The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/i2c/busses/i2c-hix5hd2.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-hix5h

[PATCH] i2c: hix5hd2: remove some dead code

The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-hix5hd2.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c

[PATCH 1/2] i2c: exynos5: remove some dead code

The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/i2c/busses/i2c-exynos5.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-exyno

[PATCH 1/2] i2c: exynos5: remove some dead code

The else branch cannot be taken as i will always equal num. Get rid of the whole construct. Signed-off-by: Peter Rosin --- drivers/i2c/busses/i2c-exynos5.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

On 2018-05-09 17:08, Andrzej Hajda wrote: > On 04.05.2018 15:51, Peter Rosin wrote: >> Bridge drivers can now (temporarily, in a transition phase) select if >> they want to provide a full owner device or keep just providing an >> of_node. >> >> By providing a full

Re: [PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

On 2018-05-09 17:08, Andrzej Hajda wrote: > On 04.05.2018 15:51, Peter Rosin wrote: >> Bridge drivers can now (temporarily, in a transition phase) select if >> they want to provide a full owner device or keep just providing an >> of_node. >> >> By providing a full

Re: I2C PM overhaul needed? (Re: [PATCH 1/2] i2c: sprd: Prevent i2c accesses after suspend is called)

On 2018-05-08 18:32, Wolfram Sang wrote: > Grygorii, > > thanks a lot for your input. Much appreciated! > >> That would be great, but note: >> 1) only i2c_transfer() operations are locked, so if driver is doing >> i2c_transfer(1) >> i2c_transfer(2) <- suspend in the middle >> <- suspend in

Re: I2C PM overhaul needed? (Re: [PATCH 1/2] i2c: sprd: Prevent i2c accesses after suspend is called)

On 2018-05-08 18:32, Wolfram Sang wrote: > Grygorii, > > thanks a lot for your input. Much appreciated! > >> That would be great, but note: >> 1) only i2c_transfer() operations are locked, so if driver is doing >> i2c_transfer(1) >> i2c_transfer(2) <- suspend in the middle >> <- suspend in

Re: [PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

On 2018-05-08 08:51, Jyri Sarha wrote: > On 05/04/18 16:51, Peter Rosin wrote: >> It gets rid of an #ifdef and the .of_node member is going away. >> >> Signed-off-by: Peter Rosin <p...@axentia.se> >> --- >> drivers/gpu/drm/bridge/panel.c | 4 +--- >>

Re: [PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

On 2018-05-08 08:51, Jyri Sarha wrote: > On 05/04/18 16:51, Peter Rosin wrote: >> It gets rid of an #ifdef and the .of_node member is going away. >> >> Signed-off-by: Peter Rosin >> --- >> drivers/gpu/drm/bridge/panel.c | 4 +--- >> 1 file changed, 1 insert

Re: [PATCH] i2c-mux-pca954x: Force reset on probe if available

On 2018-05-01 13:42, Mike Looijmans wrote: > Instead of just hogging the reset GPIO into deactivated state, activate and > then de-activate the reset. This allows for better recovery if the CPU was > reset halfway through an I2C transaction for example. I can't see any problems with this, and a

Re: [PATCH] i2c-mux-pca954x: Force reset on probe if available

On 2018-05-01 13:42, Mike Looijmans wrote: > Instead of just hogging the reset GPIO into deactivated state, activate and > then de-activate the reset. This allows for better recovery if the CPU was > reset halfway through an I2C transaction for example. I can't see any problems with this, and a

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-07 15:59, Peter Rosin wrote: > On 2018-05-07 15:39, Daniel Vetter wrote: >> On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >>> On 2018-05-03 11:06, Daniel Vetter wrote: >>>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-07 15:59, Peter Rosin wrote: > On 2018-05-07 15:39, Daniel Vetter wrote: >> On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >>> On 2018-05-03 11:06, Daniel Vetter wrote: >>>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>

Re: [PATCH v2 00/26] device link, bridge supplier <-> drm device

On 2018-05-07 15:56, Daniel Vetter wrote: > On Fri, May 04, 2018 at 03:51:46PM +0200, Peter Rosin wrote: >> Hi! >> >> It was noted by Russel King [1] that bridges (not using components) >> might disappear unexpectedly if the owner of the bridge was unbound. >>

Re: [PATCH v2 00/26] device link, bridge supplier <-> drm device

On 2018-05-07 15:56, Daniel Vetter wrote: > On Fri, May 04, 2018 at 03:51:46PM +0200, Peter Rosin wrote: >> Hi! >> >> It was noted by Russel King [1] that bridges (not using components) >> might disappear unexpectedly if the owner of the bridge was unbound. >>

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-07 15:39, Daniel Vetter wrote: > On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >> On 2018-05-03 11:06, Daniel Vetter wrote: >>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>>> The more natural approach would perha

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-07 15:39, Daniel Vetter wrote: > On Thu, May 03, 2018 at 11:12:21PM +0200, Peter Rosin wrote: >> On 2018-05-03 11:06, Daniel Vetter wrote: >>> On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >>>> The more natural approach would perha

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

On 2018-05-07 14:59, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (th

Re: [PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

On 2018-05-07 14:59, Andrzej Hajda wrote: > On 04.05.2018 15:52, Peter Rosin wrote: >> If the bridge supplier is unbound, this will bring the bridge consumer >> down along with the bridge. Thus, there will no longer linger any >> dangling pointers from the bridge consumer (th

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-05 03:43, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast,

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-05 03:43, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast,

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 16:59, Wenwen Wang wrote: > On Fri, May 4, 2018 at 2:27 AM, Peter Rosin <p...@axentia.se> wrote: >> On 2018-05-04 09:17, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 1:49 AM, Peter Rosin <p...@axentia.se> wrote: >>>> On 2018-05-04 07:28, We

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 16:59, Wenwen Wang wrote: > On Fri, May 4, 2018 at 2:27 AM, Peter Rosin wrote: >> On 2018-05-04 09:17, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 1:49 AM, Peter Rosin wrote: >>>> On 2018-05-04 07:28, Wenwen Wang wrote: >>>>> On Fri

[PATCH v2 03/26] drm/bridge/analogix: core: specify the owner .odev of the bridge

This will become mandatory. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

[PATCH v2 03/26] drm/bridge/analogix: core: specify the owner .odev of the bridge

This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 2bcbfadb6ac5

[PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

bridge drivers provide an owner device, that will become mandatory and the .of_node member will be removed. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/drm_bridge.c | 3 ++- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 +++- include/drm/drm_br

[PATCH v2 01/26] drm/bridge: allow optionally specifying an owner .odev device

bridge drivers provide an owner device, that will become mandatory and the .of_node member will be removed. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 ++- drivers/gpu/drm/rockchip/rockchip_lvds.c | 4 +++- include/drm/drm_bridge.h | 2 ++ 3 files

[PATCH v2 04/26] drm/bridge: analogix-anx78xx: provide an owner .odev device

It gets rid of an #if and the .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/

[PATCH v2 04/26] drm/bridge: analogix-anx78xx: provide an owner .odev device

It gets rid of an #if and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/analogix-anx78xx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/drm/bridge/analogix-anx78xx.c

[PATCH v2 00/26] device link, bridge supplier <-> drm device

this series removes) does not identify the port, so that problem seems orthogonal to me. Cheers, Peter [1] https://lkml.org/lkml/2018/4/23/769 [2] https://www.spinics.net/lists/dri-devel/msg174275.html Peter Rosin (26): drm/bridge: allow optionally specifying an owner .odev device drm/bridge

[PATCH v2 00/26] device link, bridge supplier <-> drm device

this series removes) does not identify the port, so that problem seems orthogonal to me. Cheers, Peter [1] https://lkml.org/lkml/2018/4/23/769 [2] https://www.spinics.net/lists/dri-devel/msg174275.html Peter Rosin (26): drm/bridge: allow optionally specifying an owner .odev device drm/bridge

[PATCH v2 02/26] drm/bridge: adv7511: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH v2 05/26] drm/bridge: cdns-dsi: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..e9be5c3f0284

[PATCH v2 02/26] drm/bridge: adv7511: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 2614cea538e2

[PATCH v2 05/26] drm/bridge: cdns-dsi: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/cdns-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index c255fc3e1be5..e9be5c3f0284 100644 --- a/drivers

[PATCH v2 08/26] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/gpu/drm/

[PATCH v2 08/26] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdp-ge

[PATCH v2 06/26] drm/bridge: vga-dac: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 9837c8

[PATCH v2 06/26] drm/bridge: vga-dac: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 9837c8d69e69..95cce18e8943 100644

[PATCH v2 07/26] drm/bridge: lvds-encoder: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/lvds-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index 75b0d3

[PATCH v2 07/26] drm/bridge: lvds-encoder: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/lvds-encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index 75b0d3f6e4de..a80eec17b13b 100644

[PATCH v2 12/26] drm/bridge: sii902x: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/sii902x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 60373d7eb220..894525b05985

[PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

It gets rid of an #ifdef and the .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c

[PATCH v2 12/26] drm/bridge: sii902x: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii902x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 60373d7eb220..894525b05985 100644 --- a/drivers/gpu

[PATCH v2 10/26] drm/bridge: panel: provide an owner .odev device

It gets rid of an #ifdef and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/panel.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index 6d99d4a3beb3..f43d77b5ed20

[PATCH v2 13/26] drm/bridge: sii9234: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/sii9234.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index c77000626c22..54326357b2ee

[PATCH v2 13/26] drm/bridge: sii9234: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sii9234.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index c77000626c22..54326357b2ee 100644 --- a/drivers/gpu

[PATCH v2 15/26] drm/bridge: synopsys: provide an owner .odev device for the bridges

It gets rid of two #ifdefs and the .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff

[PATCH v2 15/26] drm/bridge: synopsys: provide an owner .odev device for the bridges

It gets rid of two #ifdefs and the .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge

[PATCH v2 14/26] drm/bridge: sii8620: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 7ab360

[PATCH v2 14/26] drm/bridge: sii8620: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/sil-sii8620.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 7ab36042a822..8e35578b0488 100644

[PATCH v2 17/26] drm/bridge: thc63lvd1024: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index c8b9ed

[PATCH v2 17/26] drm/bridge: thc63lvd1024: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/thc63lvd1024.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index c8b9edd5a7f4..4765c9c45aef 100644

[PATCH v2 19/26] drm/exynos: mic: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 217481

[PATCH v2 19/26] drm/exynos: mic: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 2174814273e2..f9ff8d3ec937

[PATCH v2 22/26] drm/rcar-du: lvds: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3d2d3bbd1342..efda02

[PATCH v2 20/26] drm/mediatek: hdmi: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 59a11026dceb..d8c7d9

[PATCH v2 22/26] drm/rcar-du: lvds: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 3d2d3bbd1342..efda02f55c95 100644

[PATCH v2 20/26] drm/mediatek: hdmi: provide an owner .odev device for the bridge

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 59a11026dceb..d8c7d93d0a87 100644

[PATCH v2 23/26] drm/sti: provide an owner .odev device for the bridges

The .of_node member is going away and providing an .odev will become mandatory. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 1 + 3 files changed, 3 insertions(+), 1 de

[PATCH v2 23/26] drm/sti: provide an owner .odev device for the bridges

The .of_node member is going away and providing an .odev will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 1 + drivers/gpu/drm/sti/sti_hdmi.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach

The .odev owner device will be handy to have around. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/drm_bridge.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index df084db33494..78d186b6831b

[PATCH v2 25/26] drm/bridge: require the owner .odev to be filled in on drm_bridge_add/attach

The .odev owner device will be handy to have around. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index df084db33494..78d186b6831b 100644 --- a/drivers/gpu/drm

[PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

If the bridge supplier is unbound, this will bring the bridge consumer down along with the bridge. Thus, there will no longer linger any dangling pointers from the bridge consumer (the drm_device) to some non-existent bridge supplier. Signed-off-by: Peter Rosin <p...@axentia.se> --- drive

[PATCH v2 26/26] drm/bridge: establish a link between the bridge supplier and consumer

If the bridge supplier is unbound, this will bring the bridge consumer down along with the bridge. Thus, there will no longer linger any dangling pointers from the bridge consumer (the drm_device) to some non-existent bridge supplier. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c

[PATCH v2 24/26] drm/bridge: remove the .of_node member

It is unused. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/drm_bridge.c | 3 +-- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- include/drm/drm_bridge.h | 4 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/g

[PATCH v2 24/26] drm/bridge: remove the .of_node member

It is unused. Signed-off-by: Peter Rosin --- drivers/gpu/drm/drm_bridge.c | 3 +-- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- include/drm/drm_bridge.h | 4 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers

[PATCH v2 18/26] drm/bridge: ti-tfp410: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index acb857030951..474583

[PATCH v2 21/26] drm/msm: specify the owner .odev of the bridges

This will become mandatory. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 + drivers/gpu/drm/msm/edp/edp_bridge.c | 1 + drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/m

[PATCH v2 16/26] drm/bridge: tc358767: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0fd9cf27542c..75f93e1d0bf5

[PATCH v2 18/26] drm/bridge: ti-tfp410: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/ti-tfp410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index acb857030951..4745838fdf0e 100644 --- a/drivers

[PATCH v2 21/26] drm/msm: specify the owner .odev of the bridges

This will become mandatory. Signed-off-by: Peter Rosin --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 1 + drivers/gpu/drm/msm/edp/edp_bridge.c | 1 + drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers

[PATCH v2 16/26] drm/bridge: tc358767: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/tc358767.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 0fd9cf27542c..75f93e1d0bf5 100644 --- a/drivers

[PATCH v2 11/26] drm/bridge: ps8622: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/parade-ps8622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index 81198f

[PATCH v2 11/26] drm/bridge: ps8622: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/parade-ps8622.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index 81198f5e9afa..957420a1c924 100644

[PATCH v2 09/26] drm/bridge: nxp-ptn3460: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index d64a32

[PATCH v2 09/26] drm/bridge: nxp-ptn3460: provide an owner .odev device

The .of_node member is going away. Signed-off-by: Peter Rosin --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index d64a3283822a..fa832f32b518 100644

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 09:17, Wenwen Wang wrote: > On Fri, May 4, 2018 at 1:49 AM, Peter Rosin <p...@axentia.se> wrote: >> On 2018-05-04 07:28, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 12:04 AM, Peter Rosin <p...@axentia.se> wrote: >>>> On 2018-05-04 06:08, We

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 09:17, Wenwen Wang wrote: > On Fri, May 4, 2018 at 1:49 AM, Peter Rosin wrote: >> On 2018-05-04 07:28, Wenwen Wang wrote: >>> On Fri, May 4, 2018 at 12:04 AM, Peter Rosin wrote: >>>> On 2018-05-04 06:08, Wenwen Wang wrote: >>>>> On Th

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 07:28, Wenwen Wang wrote: > On Fri, May 4, 2018 at 12:04 AM, Peter Rosin <p...@axentia.se> wrote: >> On 2018-05-04 06:08, Wenwen Wang wrote: >>> On Thu, May 3, 2018 at 3:34 PM, Peter Rosin <p...@axentia.se> wrote: >>>&

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 07:28, Wenwen Wang wrote: > On Fri, May 4, 2018 at 12:04 AM, Peter Rosin wrote: >> On 2018-05-04 06:08, Wenwen Wang wrote: >>> On Thu, May 3, 2018 at 3:34 PM, Peter Rosin wrote: >>>> On 2018-05-03 00:36, Wenwen Wang wrote: >>>>> In i2c

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 06:08, Wenwen Wang wrote: > On Thu, May 3, 2018 at 3:34 PM, Peter Rosin <p...@axentia.se> wrote: >> On 2018-05-03 00:36, Wenwen Wang wrote: >>> In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, >>> which are used to save a

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-04 06:08, Wenwen Wang wrote: > On Thu, May 3, 2018 at 3:34 PM, Peter Rosin wrote: >> On 2018-05-03 00:36, Wenwen Wang wrote: >>> In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, >>> which are used to save a series of messages,

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-03 11:06, Daniel Vetter wrote: > On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >> The more natural approach would perhaps be to add an drm_bridge_add, >> but there are several other bridges that never call drm_bridge_add. >> Just removing

Re: [PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

On 2018-05-03 11:06, Daniel Vetter wrote: > On Wed, May 02, 2018 at 09:40:23AM +0200, Peter Rosin wrote: >> The more natural approach would perhaps be to add an drm_bridge_add, >> but there are several other bridges that never call drm_bridge_add. >> Just removing

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-03 00:36, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast,

Re: [PATCH] i2c: core-smbus: fix a potential uninitialization bug

On 2018-05-03 00:36, Wenwen Wang wrote: > In i2c_smbus_xfer_emulated(), there are two buffers: msgbuf0 and msgbuf1, > which are used to save a series of messages, as mentioned in the comment. > According to the value of the variable "size", msgbuf0 is initialized to > various values. In contrast,

[PATCH 2/3] drm/rockchip: lvds: avoid duplicating drm_bridge_attach

drm_bridge_attach takes care of these assignments, so there is no need to open-code them a second time. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvd

[PATCH 2/3] drm/rockchip: lvds: avoid duplicating drm_bridge_attach

drm_bridge_attach takes care of these assignments, so there is no need to open-code them a second time. Signed-off-by: Peter Rosin --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm

[PATCH 3/3] drm/exynos: hdmi: avoid duplicating drm_bridge_attach

drm_bridge_attach takes care of these assignments, so there is no need to open-code them a second time. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drive

[PATCH 3/3] drm/exynos: hdmi: avoid duplicating drm_bridge_attach

drm_bridge_attach takes care of these assignments, so there is no need to open-code them a second time. Signed-off-by: Peter Rosin --- drivers/gpu/drm/exynos/exynos_hdmi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos

[PATCH 1/3] drm/sti: do not remove the drm_bridge that was never added

The more natural approach would perhaps be to add an drm_bridge_add, but there are several other bridges that never call drm_bridge_add. Just removing the drm_bridge_remove is the easier fix. Signed-off-by: Peter Rosin <p...@axentia.se> --- drivers/gpu/drm/sti/sti_hda.c | 1 - drivers/g

[PATCH 0/3] drm: fix some bridge api misunderstandings

Hi! While looking at various drm bridge users, I came across these issues. Cheers, Peter Peter Rosin (3): drm/sti: do not remove the drm_bridge that was never added drm/rockchip: lvds: avoid duplicating drm_bridge_attach drm/exynos: hdmi: avoid duplicating drm_bridge_attach drivers/gpu

<    2   3   4   5   6   7   8   9   10   11   >