[PATCH v6 1/4] genalloc: add a global pool list, allow to find pools by phys address

This patch keeps all created pools in a global list and adds two functions that allow to retrieve the gen_pool pointer from a known physical address and from a device tree node. Signed-off-by: Philipp Zabel Reviewed-by: Shawn Guo --- include/linux/genalloc.h | 14 ++ lib/genalloc.c

[PATCH v6 0/4] Add generic driver for on-chip SRAM

rter's patch for now. Whether or not this should be configured in the device tree could use further discussion. - Added a coda driver patch to use the genalloc API and, again, the i.MX53/i.MX6 device tree patch to show the whole picture. regards Philipp --- Documentation/devicetree/bindings

[PATCH v6 2/4] misc: Generic on-chip SRAM allocation driver

tree. Signed-off-by: Philipp Zabel Reviewed-by: Shawn Guo --- Documentation/devicetree/bindings/misc/sram.txt | 17 drivers/misc/Kconfig|9 ++ drivers/misc/Makefile |1 + drivers/misc/sram.c |

[PATCH v6 3/4] media: coda: use genalloc API

This patch depends on "genalloc: add a global pool list, allow to find pools by phys address", which provides the of_get_named_gen_pool function. Signed-off-by: Philipp Zabel --- drivers/media/platform/Kconfig |3 +-- drivers/media/platform/coda

[PATCH v6 4/4] ARM: dts: add sram for imx53 and imx6q

Signed-off-by: Philipp Zabel Reviewed-by: Shawn Guo --- arch/arm/boot/dts/imx53.dtsi |5 + arch/arm/boot/dts/imx6q.dtsi |6 ++ 2 files changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index 76ebb1a..7677218 100644 --- a/arch/arm

Re: [PATCH v6 3/4] media: coda: use genalloc API

Am Freitag, den 16.11.2012, 10:08 -0500 schrieb Paul Gortmaker: > On 12-11-16 05:30 AM, Philipp Zabel wrote: > > This patch depends on "genalloc: add a global pool list, > > allow to find pools by phys address", which provides the > > of_get_named_gen_pool function.

Re: [PATCH v5 4/4] misc: sram: add support for configurable allocation order

Am Freitag, den 16.11.2012, 09:09 -0500 schrieb Matt Porter: > On Thu, Nov 15, 2012 at 02:11:35PM +0100, Philipp Zabel wrote: > > Am Mittwoch, den 14.11.2012, 19:15 + schrieb Grant Likely: > > > On Thu, 18 Oct 2012 16:27:33 +0200, Philipp Zabel > > > wrote

Re: [PATCH v6 3/4] media: coda: use genalloc API

Am Freitag, den 16.11.2012, 11:00 -0500 schrieb Paul Gortmaker: > On 12-11-16 10:21 AM, Philipp Zabel wrote: > > Am Freitag, den 16.11.2012, 10:08 -0500 schrieb Paul Gortmaker: > >> On 12-11-16 05:30 AM, Philipp Zabel wrote: > >>> This patch depends on &qu

[PATCH 5/6] drbd: Constants should be UPPERCASE

Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_int.h |7 ++- drivers/block/drbd/drbd_nl.c | 20 ++-- drivers/block/drbd/drbd_receiver.c |6 +++--- 3 files changed, 19 insertions(+), 14 deletions(-) diff

[PATCH 4/6] drbd: Ignore the exit code of a fence-peer handler if it returns too late

In case the connection was established and lost again before the a fence-peer handler returns, ignore the exit code of this instance. (And use the exit code of the later started instance) Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_int.h

[PATCH 3/6] drbd: Fix rcu_read_lock balance on error path

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_nl.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 9e3f441

[PATCH 2/6] drbd: fix error return code in drbd_init()

From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun Signed-off-by: Lars Ellenberg Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd

[PATCH 6/6] drbd: Allow online change of al-stripes and al-stripe-size

). Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_actlog.c | 21 ++ drivers/block/drbd/drbd_int.h |7 +- drivers/block/drbd/drbd_main.c | 57 --- drivers/block/drbd/drbd_nl.c | 137

[PATCH 0/6] RFC: DRBD fixes and one functional enhancemet

The first 4 patches are obvious fixes. The last patch adds the capability to change the activity log layout online. (al-stripes and al-stripe-size) Andreas Gruenbacher (2): drbd: Do not sleep inside rcu drbd: Fix rcu_read_lock balance on error path Philipp Reisner (3): drbd: Ignore the

[PATCH 1/6] drbd: Do not sleep inside rcu

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_receiver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 4222aff

Re: [PATCH v2 1/6] misc: sram: fix error path in sram_probe

f (sram->clk) > + clk_disable_unprepare(sram->clk); > return ret; > } > In light of the following patch, I'd rather move the clk_prepare_enable() call after gen_pool_add_virt() and its error path. regards Philipp -- To unsubscribe

Re: [PATCH v2 2/6] misc: sram: add ability to mark sram sections as reserved

rstart = size; } /* current start is in a reserved block */ if (rstart <= cur_start) { cur_start = rstart + rsize; continue; } /*

[PATCH 2/6] drbd: fix error return code in drbd_init()

From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun Signed-off-by: Lars Ellenberg Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd

[PATCH 1/6] drbd: Do not sleep inside rcu

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher --- drivers/block/drbd/drbd_receiver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 4222aff..adee58e 100644 --- a/drivers/blo

[PATCH 0/6] DRBD fixes and one functional enhancemet

Gruenbacher (2): drbd: Do not sleep inside rcu drbd: Fix rcu_read_lock balance on error path Philipp Reisner (3): drbd: Ignore the exit code of a fence-peer handler if it returns too late drbd: Constants should be UPPERCASE drbd: Allow online change of al-stripes and al-stripe-size Wei

[PATCH 3/6] drbd: Fix rcu_read_lock balance on error path

From: Andreas Gruenbacher Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_nl.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 9e3f441

[PATCH 6/6] drbd: Allow online change of al-stripes and al-stripe-size

). Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_actlog.c | 21 ++ drivers/block/drbd/drbd_int.h |7 +- drivers/block/drbd/drbd_main.c | 57 --- drivers/block/drbd/drbd_nl.c | 137

[PATCH 5/6] drbd: Constants should be UPPERCASE

Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_int.h |7 ++- drivers/block/drbd/drbd_nl.c | 20 ++-- drivers/block/drbd/drbd_receiver.c |6 +++--- 3 files changed, 19 insertions(+), 14 deletions(-) diff

[PATCH 4/6] drbd: Ignore the exit code of a fence-peer handler if it returns too late

In case the connection was established and lost again before the a fence-peer handler returns, ignore the exit code of this instance. (And use the exit code of the later started instance) Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner --- drivers/block/drbd/drbd_int.h

Re: [PATCH v2 1/6] misc: sram: fix error path in sram_probe

Hi Heiko, Am Donnerstag, den 04.07.2013, 16:34 +0200 schrieb Heiko Stübner: > Hi Philipp, > > Am Dienstag, 25. Juni 2013, 11:04:34 schrieb Philipp Zabel: > > Hi Heiko, > > > > Am Dienstag, den 25.06.2013, 10:46 +0200 schrieb Heiko Stübner: > > > The pool is c

Re: [PATCH v3 1/6] misc: sram: fix error path in sram_probe

rich Prinz Acked-by: Philipp Zabel > --- > drivers/misc/sram.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c > index d87cc91..afe66571 100644 > --- a/drivers/misc/sram.c > +++ b/drivers/misc/sram.c

Re: [PATCH v3 2/6] misc: sram: add ability to mark sram sections as reserved

portions of the > sram from being part of the pool. > > Suggested-by: Rob Herring > Signed-off-by: Heiko Stuebner > Tested-by: Ulrich Prinz Acked-by: Philipp Zabel > --- > Documentation/devicetree/bindings/misc/sram.txt |8 +++ > drivers/misc/sram.

Re: [PATCH v2 2/6] misc: sram: add ability to mark sram sections as reserved

Am Mittwoch, den 26.06.2013, 11:18 +0200 schrieb Heiko Stübner: > Hi Philipp, > > Am Dienstag, 25. Juni 2013, 12:17:05 schrieb Philipp Zabel: > > Hi Heiko, > > > > Am Dienstag, den 25.06.2013, 10:47 +0200 schrieb Heiko Stübner: > > > Some SoCs need parts of

Re: [PATCH 5/5] imx-drm: ipu-dp: Adjust the maximum number of flows

f (flow > IPUV3_NUM_FLOWS << 1) If (flow == IPUV3_NUM_FLOWS << 1), this will continue and try to access &priv->flow[3] below, which is invalid. How about + if ((flow >> 1) >= IPUV3_NUM_FLOWS) instead? > return ERR_PTR(-EINVAL); > >

Re: [PATCH v2 1/4] imx-drm: imx-drm-core: Export imx_drm_encoder_get_mux_id

OL_GPL(imx_drm_encoder_get_mux_id); > > /* > * imx_drm_remove_encoder - remove an encoder All four Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators support.

Hi Mark, Am Sonntag, den 28.07.2013, 13:51 +0100 schrieb Mark Brown: > On Thu, Jul 25, 2013 at 07:39:03PM +0200, Philipp Zabel wrote: > > > - 1x power switch to switch on/off 32 KHz oscilator output (32K_OUT). > > The driver looks good except this should be implemented usi

Re: [PATCH v4 2/6] misc: sram: add ability to mark sram sections as reserved

ep arbitrary portions of the > sram from being part of the pool. > > Suggested-by: Rob Herring > Signed-off-by: Heiko Stuebner > Tested-by: Ulrich Prinz > --- > Philipp: I didn't carry the ack, because the loop changed significantly again. > So if it looks ok, co

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

Hi Lee, Am Montag, den 29.07.2013, 16:46 +0100 schrieb Lee Jones: > > > > > Signed-off-by: Krystian Garbaciak > > > > > Signed-off-by: Philipp Zabel > > > > > --- > > > > > drivers/mfd/Kconfig | 12 + > > >

[PATCH v3 0/6] Add Dialog DA9063 core and regulator drivers

driver - Added device tree binding documentation - Added 32k clock output to mfd driver using clock API The regmap irq patch depends on regmap changes available at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/regmap-irq-ack-mask regards Philipp .../devicetree

[PATCH v3 6/6] mfd: da9063: add 32 kHz output clock to clock tree

Signed-off-by: Philipp Zabel --- drivers/mfd/da9063-core.c | 76 +++ 1 file changed, 76 insertions(+) diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c index c9cf8d9..adcdc50 100644 --- a/drivers/mfd/da9063-core.c +++ b/drivers/mfd

[PATCH v3 4/6] regulator: da9063: Add Dialog DA9063 voltage regulators support.

voltage change. This driver requires MFD core driver for operation. Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel --- drivers/regulator/Kconfig| 10 + drivers/regulator/Makefile | 1 + drivers/regulator/da9063-regulator.c | 941

[PATCH v3 5/6] Documentation: Add device tree bindings for DA9063 PMIC

This patch adds device tree binding documentation for the Dialog Semiconductors DA9063 PMIC and its regulator nodes. Signed-off-by: Philipp Zabel Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/mfd/da9063-i2c.txt | 68 ++ 1 file changed, 68 insertions

[PATCH v3 2/6] mfd: da9063: Add Dialog DA9063 core driver.

second page is used during initialisation. This module provides support to following functional cells: - Regulators - RTC - HWMON - OnKey (power key misc input device) - Vibration (force-feedback input device) - Watchdog - LEDs Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel

[PATCH v3 1/6] mfd: da9063: Add register definitions for DA9063 driver

From: Krystian Garbaciak This patch adds register definitions for the DA9063 PMIC. They will be used by the following DA9063 mfd core driver and functional module drivers. Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel Reviewed-by: Mark Brown --- include/linux/mfd/da9063

[PATCH v3 3/6] mfd: da9063: Add IRQ support

From: Krystian Garbaciak This patch adds a regmap irqchip for DA9063 IRQs. It depends on git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/regmap-irq-ack-mask Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel Reviewed-by: Mark Brown --- drivers/mfd

[PATCH 5/5] drbd: avoid to shrink max_bio_size due to peer re-configuration

o allow it a bit earlier during the handshake. Also consider max_hw_sectors in our merge bvec function, just in case. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_nl.c |4 ++-- drivers/block/drbd/drbd_req.c |3 +++ 2 files changed, 5 insertio

[PATCH 1/5] drbd: fix NULL pointer deref in module init error path

From: Lars Ellenberg If we want to iterate over the (as of yet still empty) list in the cleanup path, we need to initialize the list before the first goto fail. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_main.c | 19 +-- 1 file

[PATCH 2/5] drbd: Fix an connection drop issue after enabling allow-two-primaries

always tracking the sequence number, but only waiting for it if allow-two-primaries is set. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_receiver.c | 39 +++- 1 file changed, 16 insertions(+), 23 deletions(-) diff

[PATCH 3/5] drbd: Fix adding of new minors with freshly created meta data

wrongly got into the code path for resyncing new storage that was added while the disk was detached. Fixed that by making the GREW from ZERO a special case. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_int.h |3 ++- drivers/block/drbd/drbd_nl.c |2

[PATCH 4/5] drbd: fix decoding of bitmap vli rle for device sizes > 64 TB

ult of which is "undefined" :( (only "sometimes" the result is the desired 0) Fix: don't do any bit shift magic for shift == 64, just assign. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_receiver.c |6 +- 1 file chang

[PATCH 0/5] RFC: DRBD Fixes

Ellenberg (3): drbd: fix NULL pointer deref in module init error path drbd: fix decoding of bitmap vli rle for device sizes > 64 TB drbd: avoid to shrink max_bio_size due to peer re-configuration Philipp Reisner (2): drbd: Fix an connection drop issue after enabling allow-two-primar

Re: [PATCH v3 6/6] mfd: da9063: add 32 kHz output clock to clock tree

Am Montag, den 29.07.2013, 19:15 +0100 schrieb Mark Brown: > On Mon, Jul 29, 2013 at 07:00:47PM +0200, Philipp Zabel wrote: > > > + clk = devm_clk_register(da9063->dev, &out_32k->clk_hw); > > + if (IS_ERR(clk)) > > + return PTR_ERR(clk); > >

Re: [PATCH 0/3] refactor some ldb related clocks

der and configurable 1/1,1/2 divder clocks to describe this fractional divider for the reasons you state, I think the correct solution would be to improve the table divider to support fractional values and get rid of the virtual ldb_di_div_3_5 clocks, not introduce more virtual clocks. regards Philip

Re: [PATCH] imx-drm: imx-tve: Remove unneeded check for platform_get_resource()

mp;pdev->dev, "failed to get memory region\n"); > - return -ENOENT; > - } > - > base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(base)) > return PTR_ERR(base); Acked-by: Philipp Zabel regards Philipp -

[PATCH] regmap: irq: Acknowledge also interrupts that are masked

In case the hardware interrupt mask register does not prevent the chip level irq from being asserted by the corresponding interrupt status bit, stray masked interrupts should to be acknowledged, too. Signed-off-by: Philipp Zabel --- I have seen GPI interrupts trigger on DA9063 trigger after

Re: [PATCH] regmap: irq: Acknowledge also interrupts that are masked

Hi Mark, Am Montag, den 22.07.2013, 11:08 +0100 schrieb Mark Brown: > On Mon, Jul 22, 2013 at 11:24:52AM +0200, Philipp Zabel wrote: > > In case the hardware interrupt mask register does not prevent the chip level > > irq from being asserted by the corresponding interrupt st

[PATCH 2/2] regmap: irq: document mask/wake_invert, make them bool for consistency

Signed-off-by: Philipp Zabel --- include/linux/regmap.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 34ebe77..5a29fff 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -471,6 +471,8 @@ struct

[PATCH 1/2] regmap: irq: Allow to acknowledge masked interrupts during initialization

-by: Philipp Zabel --- drivers/base/regmap/regmap-irq.c | 25 + include/linux/regmap.h | 2 ++ 2 files changed, 27 insertions(+) diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c index 1643e88..d10456f 100644 --- a/drivers/base

[RFC] regmap: core: allow a virtual range to cover its own data window

space directly when connected via SPI, this allows to avoid acrobatics with the register ranges by simply mapping the I2C ranges over the data window beginning at 0x0, and then using linear access for the SPI variant. Signed-off-by: Philipp Zabel --- I am looking at DA9063, which could use the foll

[PATCH] regmap: irq: document mask/wake_invert flags

Signed-off-by: Philipp Zabel --- include/linux/regmap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/regmap.h b/include/linux/regmap.h index 99b211a..53c5d80 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h @@ -471,6 +471,8 @@ struct regmap_irq

[PATCH] regmap: irq: make flags bool and put them in a bitfield

This patch makes mask/wake_invert bool and puts all flags into a bitfield for consistency and to save some space. Signed-off-by: Philipp Zabel --- include/linux/regmap.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/regmap.h b/include/linux/regmap.h

[PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support.

each regulator. The driver switches between those on suspend/wake-up to provide quick and fluent output voltage change. This driver requires MFD core driver for operation. Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel --- drivers/regulator/Kconfig| 10 + drivers

[PATCH 0/2] Add Dialog DA9063 core and regulator drivers

river depends on a patch I've sent earlier: "[RFC] regmap: core: allow a virtual range to cover its own data window" (https://lkml.org/lkml/2013/7/23/165). regards Philipp drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile |3 + drive

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

Am Mittwoch, den 24.07.2013, 18:07 +0100 schrieb Mark Brown: > On Wed, Jul 24, 2013 at 06:34:42PM +0200, Philipp Zabel wrote: > > > + ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model); > > + if (ret < 0) { > > + dev_err(da9063-&

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

Hi Lee, Am Donnerstag, den 25.07.2013, 09:08 +0100 schrieb Lee Jones: > > > Signed-off-by: Krystian Garbaciak > > > Signed-off-by: Philipp Zabel > > > --- > > > drivers/mfd/Kconfig | 12 + > > > drivers/mfd/Makefile

Re: [PATCH 2/2] regulator: Add Dialog DA9063 voltage regulators support.

Hi Mark, thank you for the comments. Am Mittwoch, den 24.07.2013, 18:29 +0100 schrieb Mark Brown: > On Wed, Jul 24, 2013 at 06:34:43PM +0200, Philipp Zabel wrote: > > > +/* Definition for registering bit fields */ > > +struct bfield { > > + unsigned short addr; >

[PATCH v2 0/2] Add Dialog DA9063 core and regulator drivers

a virtual range to cover its own data window" (https://lkml.org/lkml/2013/7/23/165). regards Philipp drivers/mfd/Kconfig | 12 + drivers/mfd/Makefile |3 + drivers/mfd/da9063-core.c| 185 ++ drivers/mfd/da9063-i2c.c | 182

[PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulators support.

each regulator. The driver switches between those on suspend/wake-up to provide quick and fluent output voltage change. This driver requires MFD core driver for operation. Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel --- drivers/regulator/Kconfig| 10 + drivers

[PATCH v2 1/2] mfd: Add Dialog DA9063 core driver.

second page is used during initialisation. This module provides support to following functional cells: - Regulators - RTC - HWMON - OnKey (power key misc input device) - Vibration (force-feedback input device) - Watchdog - LEDs Signed-off-by: Krystian Garbaciak Signed-off-by: Philipp Zabel

Re: [PATCH 4/9] PCI: mvebu: add support for reset on GPIO

eset-delay-us" should be fine? > > I can also remove the delay property for now, as I cannot find a final > conclusion about the configurable delay. Yes, I'm in favor of using 'reset-gpios'. If we can agree on this binding, I'll add support to the res

Re: [PATCH] drbd: add module_put() on error path in drbd_proc_open()

Hi Alexey, Thanks a lot! I have put it into our tree. http://git.drbd.org/gitweb.cgi?p=drbd-8.4.git I intend to get it into the 3.10 merge window. Best, Phil > If single_open() fails in drbd_proc_open(), module refcount is left > incremented. The patch adds module_put() on the error path. > >

Re: [ 052/153] idr: idr_for_each_entry() macro

Sure, here it is: -- From: Philipp Reisner commit 9749f30f1a387070e6e8351f35aeb829eacc3ab6 upstream. Inspired by the list_for_each_entry() macro Signed-off-by: Ben Hutchings Signed-off-by: Philipp Reisner --- include/linux/idr.h | 11 +++ 1 file changed, 11 insertions

Re: drbd: kernels 3.7 => 3.8 broken userspace compatibility

Am Montag, 6. Mai 2013, 09:59:08 schrieb Chris Boot: > Hi all, > > I upgraded from a 3.7.x kernel to a 3.8.x kernel on a test machine > running DRBD, and found myself unable to bring up my DRBD devices. I'm > using the 8.3.13 userspace tools as shipped in Debian Wheezy, which work > fine on the 3.

Re: [PATCH 3.9-stable] drbd: fix memory leak

for each attach/detach cycle we leaked 336 bytes. > > Signed-off-by: Philipp Reisner > Signed-off-by: Lars Ellenberg > Signed-off-by: Jens Axboe > Signed-off-by: Jonghwan Choi > --- > drivers/block/drbd/drbd_main.c |1 + > 1 file changed, 1 insertion(+) &g

Re: [PATCH 3.9-stable] drbd: Fix build error when CONFIG_CRYPTO_HMAC is not set

Yes, please. > This patch looks like it should be in the 3.9-stable tree, should we apply > it? > > -- > > From: "Philipp Reisner " > > commit ef57f9e6bb9278720c8a5278728f252ab85d7ac6 upstream > > Signed-off-by: Philipp Reisner > Sig

Re: [PATCH 3.9-stable ]drbd: fix for deadlock when using automatic split-brain-recovery

Yes, please. > This patch looks like it should be in the 3.9-stable tree, should we apply > it? > > -- > > From: "Philipp Reisner " > > commit 7c689e63a847316c1b2500f86891b0a574ce7e69 upstream > > With an automatic after split-brain reco

[PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

__setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields. Reported-by: Michael Olbrich Signed-off-by: Philipp Zabel --- drivers/media

Re: [PATCH v9 RESEND 0/4] Add generic driver for on-chip SRAM

Am Mittwoch, den 20.03.2013, 11:52 +0100 schrieb Philipp Zabel: > Hi, last time I posted was a bit close to the merge window, so I'm > reposting now. Greg, Arnd, could you take the first two patches? Ping, can I do anything to help move this along? regards Philipp > These patch

[PATCH 16/17] drbd: use sched_setscheduler()

It was unnoticed for some time that assigning to current->policy is no longer sufficient to set a real time priority for a kernel thread. Reported-by: Charlie Suffin Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_receiver.c |6 -- incl

[PATCH 15/17] drbd: fix for deadlock when using automatic split-brain-recovery

very when both nodes are" replacing drbd_set_role() with drbd_change_state() in that code-path, but the first hunk of that patch forgets to remove the drbd_set_role(). We apparently only ever tested the "two primaries" case. Signed-off-by: Philipp Reisner Signed-off-by: Lars Elle

[PATCH 02/17] drbd: reset ap_in_flight counter for new connections

Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_receiver.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 1921871..cd172b4 100644 --- a/drivers/block/drbd

[PATCH 17/17] drbd: fix if(); found by kbuild test robot

From: Lars Ellenberg Recently introduced al_begin_io_nonblock() was returning -EBUSY, even when it should return -EWOULDBLOCK. Impact: A few spurious wake_up() calls in prepare_al_transaction_nonblock(). Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd

[PATCH 14/17] drbd: add module_put() on error path in drbd_proc_open()

From: Alexey Khoroshilov If single_open() fails in drbd_proc_open(), module refcount is left incremented. The patch adds module_put() on the error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: Philipp Reisner Signed-off

[PATCH 03/17] drbd: abort start of resync early, if it raced with connection breakage

quest that state change, if we had connection or IO problems. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_worker.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_work

[PATCH 13/17] drbd: fix drbd epoch write count for ahead/behind mode

an off-by-one in the sanity check, and further to a "Protocol Error". Fix: move the call to maybe_pull_ahead() a few lines up, and assign req->epoch only after that. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_req.c | 14 +++---

[PATCH 12/17] drbd: Fix build error when CONFIG_CRYPTO_HMAC is not set

Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_receiver.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index cd172b4..7af0cc7 100644 --- a/drivers

[PATCH 10/17] drbd: fix memory leak

From: Lars Ellenberg We forgot to free the disk_conf, so for each attach/detach cycle we leaked 336 bytes. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/block/drbd/drbd_main.c b

[PATCH 09/17] drbd: only fail empty flushes if no good data is reachable

-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_req.c | 12 drivers/block/drbd/drbd_req.h |8 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 9f7ff1c

[PATCH 08/17] drbd: Fix disconnect to keep the peer disk state if connection breaks during operation

a new error code (SS_OUTDATE_WO_CONN). This one should never reach back into user space. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_nl.c |7 +-- drivers/block/drbd/drbd_state.c | 14 +++--- drivers/block/drbd/drbd_strings.c

[PATCH 00/17] RFC: Pile of DRBD fixes

count for ahead/behind mode drbd: fix if(); found by kbuild test robot Philipp Reisner (10): drbd: reset ap_in_flight counter for new connections drbd: abort start of resync early, if it raced with connection breakage drbd: move invalidating the whole bitmap out of after_state ch() drbd

[PATCH 11/17] drbd: validate resync_after dependency on attach already

allowed and equivalent to no dependency. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_nl.c |6 ++ drivers/block/drbd/drbd_worker.c | 15 --- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/block/drbd

[PATCH 06/17] drbd: drop now useless duplicate state request from invalidate

Patch best viewed with git diff --ignore-space-change. Now that we attempt the fallback to local bitmap operation only when disconnected, we can safely drop the extra "silent" state request from both invalidate and invalidate-remote. Signed-off-by: Philipp Reisner Signed-off-by: Lars

[PATCH 07/17] drbd: fix spurious warning about bitmap being locked from detach

Introduced in drbd: always write bitmap on detach, the bitmap bulk writeout on detach was indicating it expected exclusive bitmap access. Where I meant to say: expect no more modifications, but testing/counting is still allowed. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg

[PATCH 05/17] drbd: fix effective error returned when refusing an invalidate

alid_state(), changing that to "Need access to UpToDate data", respectively "Need a connection to start verify or resync". Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_state.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/dri

[PATCH 01/17] idr: document exit conditions on idr_for_each_entry better

From: George Spelvin And some manual common subexpression elimination which may help the compiler produce smaller code. Signed-off-by: George Spelvin Signed-off-by: Philipp Reisner --- include/linux/idr.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a

[PATCH 04/17] drbd: move invalidating the whole bitmap out of after_state ch()

stablished replication link, or really be disconnected). Also mention that in the documentation. Signed-off-by: Philipp Reisner Signed-off-by: Lars Ellenberg --- drivers/block/drbd/drbd_nl.c| 36 drivers/block/drbd/drbd_state.c |7 --- 2 files c

Re: [PATCH v9 RESEND 4/4] ARM: dts: add sram for imx53 and imx6q

Am Donnerstag, den 28.03.2013, 10:54 +0800 schrieb Shawn Guo: > On Wed, Mar 20, 2013 at 11:52:47AM +0100, Philipp Zabel wrote: > > Signed-off-by: Philipp Zabel > > Reviewed-by: Shawn Guo > > Acked-by: Grant Likely > > --- > > Changes since v8: > > - C

Re: [PATCH v9 RESEND 2/4] misc: Generic on-chip SRAM allocation driver

Hi Andrew, thanks for taking care of these patches. Am Mittwoch, den 27.03.2013, 15:27 -0700 schrieb Andrew Morton: > On Wed, 20 Mar 2013 11:52:45 +0100 Philipp Zabel > wrote: > > > This driver requests and remaps a memory region as configured in the > > device tree.

Re: [PATCH v9 RESEND 4/4] ARM: dts: add sram for imx53 and imx6q

Am Donnerstag, den 28.03.2013, 22:22 +0800 schrieb Shawn Guo: > On Thu, Mar 28, 2013 at 10:05:18AM +0100, Philipp Zabel wrote: > > > > + > > > > + ocram: ocram@f800 { > > > > + compatible = "fsl,imx-ocram",

[PATCH 2/5] ARM i.MX53, i.MX6q: Add IRAM to device tree

Signed-off-by: Philipp Zabel --- arch/arm/boot/dts/imx53.dtsi |5 + arch/arm/boot/dts/imx6q.dtsi |5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index e3e8694..6d99d8a 100644 --- a/arch/arm/boot/dts/imx53.dtsi

[PATCH 1/5] ARM i.MX: Switch IRAM allocator to device tree initialization

Signed-off-by: Philipp Zabel --- arch/arm/plat-mxc/include/mach/iram.h |6 - arch/arm/plat-mxc/iram_alloc.c| 44 ++--- 2 files changed, 41 insertions(+), 9 deletions(-) diff --git a/arch/arm/plat-mxc/include/mach/iram.h b/arch/arm/plat-mxc/include

[PATCH 0/5] Add device tree support for on-chip SRAM

These patches add support to configure the on-chip SRAM via device-tree node and to obtain the resulting genalloc pool from a phandle pointing at the node. This allows drivers to allocate SRAM with the genalloc API without hard-coding the genalloc pool address. regards Philipp --- arch/arm

[PATCH 4/5] genalloc: add a global pool list, allow to find pools by phys address

This patch keeps all created pools in a global list and adds two functions that allow to retrieve the gen_pool pointer from a known physical address and from a device tree node. Signed-off-by: Philipp Zabel --- include/linux/genalloc.h | 14 + lib/genalloc.c | 77

[PATCH 5/5] ARM i.MX: Remove iram_alloc/free, as they are unused in-tree

pool, virt, SIZE); Signed-off-by: Philipp Zabel --- arch/arm/plat-mxc/include/mach/iram.h | 35 - arch/arm/plat-mxc/iram_alloc.c| 26 2 files changed, 61 deletions(-) delete mode 100644 arch/arm/plat-mxc/include/mach/iram.h diff -

[PATCH 3/5] iram_alloc: store the virt and phys mem address in gen_pool chunks

This improves the symmetry of iram_alloc and iram_free in that iram_free has to be called with the virtual address now. Also, gen_pool_virt_to_phys is now functional. Signed-off-by: Philipp Zabel --- arch/arm/plat-mxc/iram_alloc.c | 39 ++- 1 file changed

<    1   2   3   4   5   6   7   8   9   10   >