From: "Lad, Prabhakar"
Both synchronous and asynchronous adv7343 subdevice probing is supported by
this patch.
Signed-off-by: Lad, Prabhakar
Cc: Guennadi Liakhovetski
Cc: Laurent Pinchart
Cc: Hans Verkuil
Cc: Sakari Ailus
Cc: Mauro Carvalho Chehab
---
drivers/media/i2c/adv7343.c | 15
From: "Lad, Prabhakar"
Both synchronous and asynchronous tvp514x subdevice probing is supported by
this patch.
Signed-off-by: Prabhakar Lad
Cc: Guennadi Liakhovetski
Cc: Laurent Pinchart
Cc: Hans Verkuil
Cc: Sakari Ailus
Cc: Mauro Carvalho Chehab
---
drivers/media/i2c/tvp514
From: "Lad, Prabhakar"
This patch adds video sync properties as part of endpoint
properties and also support to parse them in the parser.
Signed-off-by: Lad, Prabhakar
Cc: Hans Verkuil
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski
Cc: Sylwester Nawrocki
Cc:
From: "Lad, Prabhakar"
The first patch of the series add support for asynchronous probing
and the second patch adds OF support to tvp7002 driver.
Lad, Prabhakar (2):
media: i2c: tvp7002: add support for asynchronous probing
media: i2c: tvp7002: add OF support
From: "Lad, Prabhakar"
Both synchronous and asynchronous tvp7002 subdevice probing
is supported by this patch.
Signed-off-by: Lad, Prabhakar
Cc: Hans Verkuil
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski
Cc: Sylwester Nawrocki
Cc: Sakari Ailus
Cc:
From: "Lad, Prabhakar"
add OF support for the tvp7002 driver.
Signed-off-by: Lad, Prabhakar
Cc: Hans Verkuil
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski
Cc: Sylwester Nawrocki
Cc: Sakari Ailus
Cc: Grant Likely
Cc: Rob Herring
Cc: Rob Landley
Cc:
From: "Lad, Prabhakar"
Add mdio device tree node information to da850 by
providing register details and bus frequency of mdio.
Signed-off-by: Lad, Prabhakar
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-sou...@linux.davincidsp.com
Cc:
From: "Lad, Prabhakar"
This patch set enables Ethernet support through device tree model.
This patch set enables mii interface only and is being tested to boot via
rootfs. The rmii phy is present on the i2c gpio expander chip (UI board)
for which yet support needs to be added, once the DT
From: "Lad, Prabhakar"
Add OF_DEV_AUXDATA for mdio driver in da850 board dt
file to use mdio clock.
Signed-off-by: Lad, Prabhakar
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-sou...@linux.davincidsp.com
Cc: net...@vger.kernel.org
Cc:
From: "Lad, Prabhakar"
This patch removes the clock alias for mdio device and adds a entry
in clock lookup table, this entry can now be used by both DT and NON
DT case.
Signed-off-by: Lad, Prabhakar
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc:
From: "Lad, Prabhakar"
Add eth0 device tree node information and pinmux for mii to da850 by
providing interrupt details and local mac address of eth0.
Signed-off-by: Lad, Prabhakar
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc:
From: "Lad, Prabhakar"
This patch makes a common function for to configure emac and calls
it appropriately in DT and non DT boot mode. The system configuration
chip CFGCHIP3, controls the emac module. This patch appropriately
configures this register for emac and sets DA850_MII_MDIO_CLKEN_PIN
From: "Lad, Prabhakar"
Add OF_DEV_AUXDATA for eth0 driver in da850 board dt
file to use emac clock.
Signed-off-by: Lad, Prabhakar
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-sou...@linux.davincidsp.com
Cc: net...@vger.kernel.org
Cc:
Hi Guennadi,
Thanks for the review.
On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski
wrote:
> On Sat, 22 Jun 2013, Prabhakar Lad wrote:
>
>> From: "Lad, Prabhakar"
>>
>> Both synchronous and asynchronous tvp514x subdevice probing is supported
Hi Hans,
On Mon, Jun 24, 2013 at 12:44 PM, Hans Verkuil wrote:
> On Sat June 22 2013 19:44:14 Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> Both synchronous and asynchronous tvp7002 subdevice probing
>> is supported by this patch.
>
> Can I merg
Hi Hans,
On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
> On Sun June 23 2013 17:48:20 Prabhakar Lad wrote:
>> Hi Guennadi,
>>
>> Thanks for the review.
>>
>> On Sun, Jun 23, 2013 at 8:49 PM, Guennadi Liakhovetski
>> wrote:
>> > On Sat, 2
Hi Hans,
On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote:
> On Mon June 24 2013 10:24:02 Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
>> > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote:
>> >> Hi G
From: "Lad, Prabhakar"
This patch series removes manual setting of subdev names, as
ideally the subdev names must be unique and this would not be
the case if there are two devices.
Lad, Prabhakar (2):
media: i2c: tvp7002: remove manual setting of subdev name
media: i2c: tvp514x: remove
From: "Lad, Prabhakar"
This patch removes manual setting of subdev name in the
probe, ideally subdev names must be unique.
Signed-off-by: Lad, Prabhakar
Cc: Hans Verkuil
---
drivers/media/i2c/tvp7002.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tvp7002.c
From: "Lad, Prabhakar"
This patch removes manual setting of subdev name in the
probe, ideally subdev names must be unique.
Signed-off-by: Lad, Prabhakar
Cc: Hans Verkuil
---
drivers/media/i2c/tvp514x.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tvp514x.c
From: "Lad, Prabhakar"
Both synchronous and asynchronous tvp514x subdevice probing
is supported by this patch.
This patch also fixes the error path by calling
media_entity_cleanup() on failure in probe when
CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Prabhakar Lad
Cc
Hi Hans,
Thanks for the review.
On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> On Sat June 22 2013 17:03:03 Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> This patch adds video sync properties as part of endpoint
>>
Hi Hans,
On Mon, Jun 24, 2013 at 1:21 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> On Sat June 22 2013 17:03:03 Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
[snip]
>> +#ifndef _DT_BINDINGS_VIDEO_INTERFACES_H
>> +#define _DT_B
From: "Lad, Prabhakar"
Add support for asynchronous subdevice probing, using the v4l2-async API.
The legacy synchronous mode is still supported too, which allows to
gradually update drivers and platforms.
Signed-off-by: Prabhakar Lad
Cc: Guennadi Liakhovetski
Cc: Hans Verkuil
C
Hi grygorii,
Thanks for the review.
On Mon, Nov 4, 2013 at 11:57 PM, Grygorii Strashko
wrote:
> Hi Prabhakar Lad,
>
> On 11/02/2013 05:39 PM, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar"
>>
>> This patch converts the davinci gpio driver to use irqdo
Hi Grygorii,
Thanks for the review.
On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko
wrote:
> Hi Prabhakar Lad,
>
>
> On 11/02/2013 05:39 PM, Lad, Prabhakar wrote:
>>
>> From: KV Sujith
>>
>> This patch adds OF parser support for davinci gpio
>>
nction.
>>
>> Signed-off-by: Lad, Prabhakar
>
> Is this a regression that should go in right now?
>
Yes it needs too.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordo
Hi Grygorii,
On Tue, Nov 5, 2013 at 10:29 PM, Grygorii Strashko
wrote:
> On 11/05/2013 10:53 AM, Prabhakar Lad wrote:> Hi Grygorii,
>
>>
>> Thanks for the review.
>>
>> On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko
>> wrote:
>>> Hi Prabha
Hi Linus,
On Wed, Nov 6, 2013 at 3:26 PM, Linus Walleij wrote:
> On Wed, Nov 6, 2013 at 10:33 AM, Prabhakar Lad
> wrote:
>> On Tue, Nov 5, 2013 at 6:09 PM, Linus Walleij
>> wrote:
>>> On Sat, Nov 2, 2013 at 4:39 PM, Lad, Prabhakar
>>> w
rning: no previous prototype for
> ‘ths7303_setval’ [-Wmissing-prototypes]
>int ths7303_setval(struct v4l2_subdev *sd, enum ths7303_filter_mode mode)
> ^
>
> Signed-off-by: Ricardo Ribalda Delgado
> Acked-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar
From: "Lad, Prabhakar"
This patch series fixes gpio driver regestration
and offset check for unbanked gpio.
Lad, Prabhakar (2):
gpio: davinci: Fix a check for unbanked gpio
ARM: davinci: Fix number of resources passed to
davinci_gpio_register() call
arch/arm/mach-davinci/dm355.c |
From: "Lad, Prabhakar"
The davinci_gpio_register() function expects the number of
resources as the second parameter, but size of resources
was passed to it due to which it was causing unexpected
behaviour. This patch fixes the same by passing the
ARRAY_SIZE of resources.
Reported-by: Grygorii
From: "Lad, Prabhakar"
This patch fixes a check for offset in gpio_to_irq_unbanked()
and also assigns gpio_irq, gpio_unbanked of chips[0] to
appropriate values which is used in gpio_to_irq_unbanked()
function.
Reported-by: Grygorii Strashko
Signed-off-by: Lad, Prabhakar
---
From: KV Sujith
This patch series does the following
1> Ports the driver to use irqdomain.
2> Adds dt binding support for gpio-davinci.
3> Adds DA850 dt support goio.
Changes for v5:
1: Fixed review comments pointed by Grygorii.
2: Dropped the fixup patch
This patch series is based on
From: "Lad, Prabhakar"
the devm_*() helper prints error messages in case of
errors no need to do the same in the driver.
Signed-off-by: Lad, Prabhakar
---
drivers/gpio/gpio-davinci.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-davinci.c
From: "Lad, Prabhakar"
As the davinci-gpio driver is migrated to use irqdomain
there is no need to pass the irq base for the gpio driver.
This patch removes this variable from davinci_gpio_platform_data
and also the references from the machine file.
Signed-off-by: Lad, Prabhakar
---
From: KV Sujith
This patch adds OF parser support for davinci gpio
driver and also appropriate documentation in gpio-davinci.txt
located at Documentation/devicetree/bindings/gpio/.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
[prabhakar.cse...@gmail.com: simplified the OF code,
From: "Lad, Prabhakar"
This patch replaces the __raw_readl/writel with
readl and writel, Although the code runs on ARMv5
based SOCs, changing this will help copying the code
for other uses.
Signed-off-by: Lad, Prabhakar
---
drivers/gpio/gpio-davinci.c | 36
From: "Lad, Prabhakar"
This patch converts the davinci gpio driver to use irqdomain
support.
Signed-off-by: Lad, Prabhakar
---
drivers/gpio/gpio-davinci.c| 74 +++-
include/linux/platform_data/gpio-davinci.h |2 +-
2 files changed, 41
From: KV Sujith
Add DT node for Davinci GPIO driver.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
Signed-off-by: Lad, Prabhakar
---
arch/arm/boot/dts/da850.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/da850.dtsi
From: KV Sujith
Add GPIO DT node and pinmux entries for DA850 EVM. GPIO is
configurable differently on different boards. So add GPIO
pinmuxing in dts file.
Signed-off-by: KV Sujith
Signed-off-by: Philip Avinash
Signed-off-by: Lad, Prabhakar
---
arch/arm/boot/dts/da850-evm.dts | 20
Hi Taras,
On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk
wrote:
> On 21 November 2013 20:15, Prabhakar Lad wrote:
>> From: "Lad, Prabhakar"
>>
>> This patch replaces the __raw_readl/writel with
>> readl and writel, Altough the code runs on ARMv5
&
Hi Sekhar,
Thanks for the review.
On Mon, Nov 25, 2013 at 4:30 PM, Sekhar Nori wrote:
> On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote:
>> From: KV Sujith
>>
>> This patch adds OF parser support for davinci gpio
>> driver and also appropriate docume
Hi Sekhar,
On Mon, Nov 25, 2013 at 4:04 PM, Sekhar Nori wrote:
> Prabhakar,
>
> On Monday 25 November 2013 09:42 AM, Prabhakar Lad wrote:
>> Hi Taras,
>>
>> On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk
>> wrote:
>>> On 21 November 2013 20
m.
>
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
er for Keystone SoCs when needed. At same time, kept
> Davinci GPIO driver enabled for Davinci SoCs by default.
>
> Signed-off-by: Grygorii Strashko
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Hi Linus,
On Fri, Nov 29, 2013 at 1:17 PM, Linus Walleij wrote:
> On Thu, Nov 21, 2013 at 7:15 PM, Prabhakar Lad
> wrote:
>
>> From: "Lad, Prabhakar"
>>
>> This patch series does the following
>> 1> Ports the driver to use irqdomain.
>> 2&g
Hi Grygorii,
Thanks for the review.
On Mon, Nov 11, 2013 at 8:48 PM, Grygorii Strashko
wrote:
> On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
[Snip]
>> @@ -134,6 +137,40 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned
>> offset, int value)
>> writel((1 <<
Hi Grygorii,
Thanks for the review.
On Fri, Nov 8, 2013 at 9:09 PM, Grygorii Strashko
wrote:
> On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
>>
>> From: "Lad, Prabhakar"
>>
>> the devm_*() helper prints error messages in case of
>> errors no need to
Hi Grygorii,
On Mon, Oct 14, 2013 at 5:55 PM, Grygorii Strashko
wrote:
> Hi Prabhakar Lad,
>
> On 10/11/2013 07:18 PM, Prabhakar Lad wrote:
>> Hi Linus,
>>
>> On 10/11/13, Linus Walleij wrote:
>>> On Fri, Oct 11, 2013 at 4:59 PM, Prabhakar Lad
>>>
From: "Lad, Prabhakar"
This patch replaces the __raw_readl/writel with
{readl|writel}_relaxed(), Altough the code runs on ARMv5
based SOCs, changing this will help copying the code
for other uses.
Signed-off-by: Lad, Prabhakar
---
This patch is part of series [1] rest of the patches
are
2 GPIO lines;
> - only unbanked irqs;
>
> See Documentation:
> Keystone - http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf
>
> [1] Depends on patch:
> "[PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio"
> https://lkml.org/lkml/2013/11/8/22
>
> [2] and de
Hi Linus,
On Fri, Dec 13, 2013 at 2:01 AM, Linus Walleij wrote:
> On Wed, Dec 11, 2013 at 6:52 PM, Prabhakar Lad
> wrote:
>
>> From: "Lad, Prabhakar"
>>
>> This patch replaces the __raw_readl/writel with
>> {readl|writel}_relaxed(), Altough the
From: Lad, Prabhakar
This patch series enables VPBE display driver on DM365.
This patch is work on on following pull request from Hans
http://davinci-linux-open-source.1494791.n2.nabble.com/GIT-PULL-FOR-v3-10-tvp7002-davinci-blackfin-legacy-cleanups-td7582451.html
Changes for v6:
1: Fixed
From: Lad, Prabhakar
Create platform devices for various video modules like venc,osd,
vpbe and v4l2 driver for dm365.
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/board-dm365-evm.c |4 +-
arch/arm/mach-davinci/davinci.h |2 +-
arch/arm/mach-davinci/dm365.c
From: Lad, Prabhakar
add support for V4L2 video display to DM365 EVM.
Support for SD and ED modes is provided, along with Composite
and Component outputs.
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/board-dm365-evm.c | 164 ++-
1 files changed, 163
From: Lad, Prabhakar
This patch series enables VPBE display driver on DM355.
Changes for v5:
1: Rebased on 3.9, fix review comments pointed by Sekhar for DM365 series.
Changes for v4:
1: pass different platform names to handle different ip's.
Changes for v3:
1: Replaced obsolete preset API by
From: Lad, Prabhakar
Create platform devices for various video modules like venc,osd,
vpbe and v4l2 driver for dm355.
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/board-dm355-evm.c |4 +-
arch/arm/mach-davinci/davinci.h |2 +-
arch/arm/mach-davinci/dm355.c
From: Lad, Prabhakar
add support for V4L2 video display to DM355 EVM.
Support for SD modes is provided, along with Composite
output
Signed-off-by: Lad, Prabhakar
---
arch/arm/mach-davinci/board-dm355-evm.c | 69 ++-
1 files changed, 68 insertions(+), 1
vinci_vpfe/dm365_isif.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
@@ -19,6 +19,8 @@
* Prabhakar Lad
*/
+#include
+
#include "dm365_isif.h"
#include "vpfe_mc_capture.h"
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe lin
44
> --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> @@ -19,6 +19,8 @@
> * Prabhakar Lad
> */
>
> +#include
> +
> #include "dm365_isif.h"
> #include "vpfe_mc_capture.h&quo
Sekhar,
On Mon, Mar 18, 2013 at 2:11 PM, Sekhar Nori wrote:
> On 3/16/2013 3:47 PM, Prabhakar lad wrote:
>> From: Lad, Prabhakar
>>
>> Create platform devices for various video modules like venc,osd,
>> vpbe and v4l2 driver for dm355.
>>
>> Sign
Sekhar,
On Mon, Mar 18, 2013 at 1:48 PM, Sekhar Nori wrote:
> On 3/15/2013 8:41 PM, Prabhakar lad wrote:
>> From: Lad, Prabhakar
>>
>> Create platform devices for various video modules like venc,osd,
>> vpbe and v4l2 driver for dm365.
>>
>> Signed-off-
Hi Wei,
Thanks for the patch! I'll queue it up for v3.10
On Tue, Mar 19, 2013 at 12:36 AM, Silviu-Mihai Popescu
wrote:
> This uses the resource_size() function instead of explicit computation.
>
> Signed-off-by: Silviu-Mihai Popescu
Acked-by: Lad, Prabhakar
Regards,
--Prab
Hi Mauro,
On Wed, Mar 20, 2013 at 12:00 AM, Mauro Carvalho Chehab
wrote:
> Em Fri, 8 Mar 2013 16:19:07 +0530
> Prabhakar lad escreveu:
>
>> From: Lad, Prabhakar
>>
>> export the symbols which are used by two modules vpif_capture and
>> vpif_display.
>&
From: Lad, Prabhakar
export the symbols which are used by two modules vpif_capture and
vpif_display. renamed "ch_params" to "vpif_ch_params" so as to avoid
name collision.
This patch fixes following error:
ERROR: "ch_params" [drivers/media/platform/davinci/vpif_display.ko] undefined!
ERROR:
his patch on [1]
so that slab.h can also be removed.
[1] https://patchwork.kernel.org/patch/2539411/
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
> +- ti,tvp7002-sog-polarity: Sync on Green output polarity of the endpoint.
>
> Would it make sense to define field-active and sog-active properties in the
> V4L2 bindings instead of having per-chip properties ?
>
yes you are right these properties need to be in the device node
ra
3 pdata as it is no longer exists.
>
> You should move this before 1/6, otherwise you will break bisection.
>
OK I'll fix it in next version.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ma
or not pointing you to it earlier.
>
I had looked at it earlier it only means "field signal level during the even
field data transmission" it only speaks of even filed. Ideally the field ID
output is set to logic 1 for odd field and set to 0 for even field, what I
want is to invert the FID
Hi Sylwester,
On Thu, May 16, 2013 at 4:13 PM, Sylwester Nawrocki
wrote:
> Hi,
>
>
> On 05/16/2013 06:53 AM, Prabhakar Lad wrote:
>>>>
[Snip]
>> May be we rename "field-active" to "fid-pol" ?
>
>
> I guess we failed to clearly
S_FIELD_EVEN_LOW (1<< 11)
>> +#define V4L2_MBUS_FIELD_ACTIVE (1<< 12)
>> +#define V4L2_MBUS_SOG (1<< 13)
>
>
> How about V4L2_MBUS_SYNC_ON_GREEN ?
>
OK makes it more readable.
Regards,
--Prabhakar Lad
--
To
Hi Laurent,
On Wed, May 15, 2013 at 5:41 PM, Prabhakar Lad
wrote:
> Hi Laurent,
>
> Thanks for the review.
>
> On Wed, May 15, 2013 at 5:35 PM, Laurent Pinchart
> wrote:
>> Hi Prabhakar,
>>
>> Thank you for the patch.
>>
>> On Wednesday 15 May
gt; + if (flags & V4L2_MBUS_PCLK_SAMPLE_RISING)
>> + pdata->clk_polarity = 1;
>> +
>
> As well as here. Maybe a
>
> done:
> of_node_put(endpoint);
> return pdata;
>
> with a goto done in the devm_kzalloc error path would be bett
Hi Laurent,
On Thu, May 16, 2013 at 6:20 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Thursday 16 May 2013 18:13:38 Prabhakar Lad wrote:
>> On Thu, May 16, 2013 at 5:40 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> &g
s/the/them/.
OK
>
>
>> also guard the davinci_mdio_of_mtable table and davinci_mdio_probe_dt()
>> with CONFIG_OF.
>
>
>Saying "also" in the changelog is often a good sign there should be one
> more patch -- as in this case.
>
OK I'll split the patch.
Regards,
--Prabhakar L
s.
>> and sorts them alphabetically
>
>
>In the subject you typed "the" instead of "them".
>
Hmm carry forwarded this copy paste error every where will fix it in V2.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsub
pdata->init_enable;
>> -
>> - mask = state->stream_on ? 0xff : 0xf8;
>> + mask = 0xf8;
>
> You can assign mask in declaration. It'd be nice to have a human-readable
> name for the mask, too.
>
This function gets removed in the preceding patch of this series.
Reg
t; status = -EBUSY;
>
>
>And you call that "more consistent error values"? Why not:
>
> status = PTR_ERR(edmacc_regs_base[j]);
>
Yes missed it will fix it in v2.
>
>> edma_cc[j] = kzalloc(sizeo
izes the kernel headers
> internal includes then the driver might break. As a general rule of good
> practice you should include headers for all the APIs you use.
>
OK, do you want me too drop the similar patches from this series ?
Regards,
--Prabhakar Lad
--
To unsubscribe from this
Hi Mauro,
On Tue, Feb 5, 2013 at 9:54 PM, Mauro Carvalho Chehab
wrote:
> Em Wed, 2 Jan 2013 17:23:50 +0530
> "Lad, Prabhakar" escreveu:
>
>> while the effect is harmless this patch
>
> I disagree that this is a harmless warning. It is here for a reason:
> you should not be relying on the enum
From: Lad, Prabhakar
The patch adds support for THS7353 video amplifier.
The the THS7353 amplifier is very much similar to the
existing THS7303 video amplifier driver.
This patch appropriately makes changes to the existing
ths7303 driver and adds support for the THS7353.
This patch also adds
Hi Hans,
Thanks for the review.
On Wed, Feb 6, 2013 at 2:33 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> Here is my review. There are a few things that need to be fixed before I
> can Ack it.
>
OK
> On Tue 5 February 2013 20:20:21 Prabhakar Lad wrote:
>> From: Lad, Pr
From: Lad, Prabhakar
The patch adds support for THS7353 video amplifier.
The the THS7353 amplifier is very much similar to the
existing THS7303 video amplifier driver.
This patch appropriately makes changes to the existing
ths7303 driver and adds support for the THS7353.
This patch also adds
Hi Sylwester,
On Thu, Feb 7, 2013 at 5:18 PM, Sylwester Nawrocki
wrote:
> Hi Prabhakar,
>
> On 01/28/2013 12:50 PM, Prabhakar Lad wrote:
>> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
>> index 0ef8833..dac06d7 100644
>> --- a/include/uapi/lin
From: Manjunath Hadli
A lot of SOCs including Texas Instruments Davinci family mainly use
video decoders as input devices. This patch adds a flag
'MEDIA_ENT_T_V4L2_SUBDEV_DECODER' media entity type for decoder's.
Along side updates the documentation for this media entity type.
Signed-off-by:
Hi Sylwester,
Thanks for the review.
On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki
wrote:
> Hi Prabhakar,
>
> On 01/29/2013 02:07 PM, Prabhakar Lad wrote:
> [...]
>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp514x.txt
>> b/Documentation/de
Sekhar,
On Sun, Feb 3, 2013 at 4:44 PM, Sekhar Nori wrote:
> On 1/28/2013 7:17 PM, Prabhakar Lad wrote:
>> From: Lad, Prabhakar
>>
>> This patch removes the clock alias for mdio device and adds a entry
>> in clock lookup table, this entry can now be used by
Sekhar,
On Sun, Feb 3, 2013 at 5:23 PM, Sekhar Nori wrote:
> On 1/28/2013 7:17 PM, Prabhakar Lad wrote:
>> From: Lad, Prabhakar
>>
>> Add mdio device tree node information to da850 by
>> providing register details and bus frequency of mdio.
>>
>> Signed-o
Sekhar,
On Sun, Feb 3, 2013 at 6:40 PM, Sekhar Nori wrote:
> On 2/3/2013 3:43 PM, Prabhakar Lad wrote:
>> Hi Sylwester,
>>
>> Thanks for the review.
>>
>> On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki
>> wrote:
>>> Hi Prabhakar,
>
Hi Laurent,
On Sun, Feb 3, 2013 at 6:44 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Sunday 03 February 2013 15:43:49 Prabhakar Lad wrote:
>> On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki wrote:
>> > On 01/29/2013 02:07 PM, Prabhakar Lad wrote:
>>
Hi Sylwester,
On Sun, Feb 3, 2013 at 6:57 PM, Sylwester Nawrocki
wrote:
> Hi Prabhakar,
>
> On 02/03/2013 11:13 AM, Prabhakar Lad wrote:
> [...]
>
>>>> +Required Properties :
>>>> +- compatible: Must be "ti,tvp514x-decoder"
>>>
>
Sekhar ,
On Sun, Feb 3, 2013 at 6:15 PM, Sekhar Nori wrote:
> On 1/28/2013 7:17 PM, Prabhakar Lad wrote:
>> From: Lad, Prabhakar
>>
>> The system configuration chip CFGCHIP3, controls the emac module.
>> This patch appropriately configures this re
Sekhar ,
On Sun, Feb 3, 2013 at 5:33 PM, Sekhar Nori wrote:
> On 1/28/2013 7:17 PM, Prabhakar Lad wrote:
>> From: Lad, Prabhakar
>>
>> Add eth0 device tree node information and pinmux for mii to da850 by
>> providing interrupt details and local mac address of eth
Hi Marek,
On Tue, Apr 16, 2013 at 4:48 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> (CC'ing Marek)
>
> On Tuesday 16 April 2013 16:24:30 Prabhakar lad wrote:
>> From: Lad, Prabhakar
>>
>> with recent commit with id 068a0df76023926af958a336a78bef60468d20
From: Lad, Prabhakar
>From commit 068a0df76023926af958a336a78bef60468d2033
"[media] media: vb2: add length check for mmap"
patch verifies that the mmap() size requested by userspace
doesn't exceed the buffer size.
As the mmap() size is rounded up to the next page boundary
the check will fail
From: Lad, Prabhakar
The first patch of the series cleanups the header file inclusion,
and second patch fixes displaying of error when there is actual
failure of request_irq().
Lad, Prabhakar (2):
media: davinci: vpif: remove unwanted header file inclusion
media: davinci: vpif_display: move
From: Lad, Prabhakar
this patch removes unwanted header file inclusion and sorts
header alphabetically.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpif_capture.c | 19 ---
drivers/media/platform/davinci/vpif_capture.h |5 +
From: Lad, Prabhakar
this patch moves the displaying out error case "VPIF IRQ request failed\n"
when there is actual request_irq() fail.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/davinci/vpif_display.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
On Fri, Apr 19, 2013 at 4:48 PM, Mauro Carvalho Chehab
wrote:
> Em Fri, 19 Apr 2013 15:16:56 +0530
> Prabhakar lad escreveu:
>
>> From: Lad, Prabhakar
>>
>> From commit 068a0df76023926af958a336a78bef60468d2033
>> "[media] media: vb2: add length check for
701 - 800 of 1285 matches
Mail list logo
