Chao Xie writes:
Hi Chao Xie,
First of all, could you please send patches from rtc-pxa to me also, as I'm
maintaining that driver ?
Second point, the original design of the driver relies on the special case of
writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
21.4
Chao Xie writes:
> The original pxa_rtc_open/pxa_rtc_release will be called
> when the /dev/rtc0 is opened or closed.
> In fact, these two functions will register/unregister the irqs.
> User application will use /dev/rtc0 to read the rtc time or set
> the alarm. The rtc should still run indepent
>
>> Signed-off-by: Michael Opdenacker
>
> This clean up looks good to me.
>
> Acked-by: Kees Cook
Yes, a consequence of the beheading in the commit "mtd: doc: remove support for
DoC 2000/2001/2001+", excellent.
Acked-by: Robert Jarzmik
--
Robert
--
To unsubscribe f
/lib/libc.so) to see the eviction
cycles, and find out if frequently used code is
rather spread across many pages (bad) or coallesced
(good).
Signed-off-by: Robert Jarzmik
---
include/trace/events/filemap.h | 79
mm/filemap.c |5
/lib/libc.so) to see the eviction
cycles, and find out if frequently used code is
rather spread across many pages (bad) or coallesced
(good).
Signed-off-by: Robert Jarzmik
---
include/trace/events/filemap.h | 79
mm/filemap.c |5
Julia Lawall writes:
> From: Julia Lawall
>
> Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the
> arity of the called function.
Acked-by: Robert Jarzmik
As a side I'm curious why this change didn't touch also :
sound/soc/pxa/mioa701_wm9713.c
Chao Xie writes:
> This patch have something wrong.
> 1.The pxa_sync_time API is not needed. The RTC sync can be done
> by user space applications, so in kernel this API is not needed.
> 2.The pxa_rtc_open can not be deleted. This change has been
> declined during review at the mail list
> 3.Base
Andrew Morton writes:
>> +TP_STRUCT__entry(
>> +__field(struct page *, page)
>> +__field(unsigned long, i_no)
>
> May as well call this i_ino - there's little benefit in using a
> different identifier.
Agreed for patch V2.
>
>> +__field(unsigned long, pageof
Dave Chinner writes:
> We actually have an informal convention for formating filesystem
> trace events, and that is to use the device number
>
>>
>> > + ),
>> > +
>> > + TP_printk("page=%p pfn=%lu blk=%d:%d inode+ofs=%lu+%lu",
>
> ... and to prefix messages like:
>
> TP_printk("dev %d
Hugh Dickins writes:
> On Thu, 8 Nov 2012, Robert Jarzmik wrote:
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -467,6 +471,7 @@ int add_to_page_cache_locked(struct page *page, struct
>> address_space *mapping,
>> } else {
>>
Dave Chinner writes:
> We actually have an informal convention for formating filesystem
> trace events, and that is to use the device number
>
>>
>> > + ),
>> > +
>> > + TP_printk("page=%p pfn=%lu blk=%d:%d inode+ofs=%lu+%lu",
>
> ... and to prefix messages like:
>
> TP_printk("dev %
/lib/libc.so) to see the eviction
cycles, and find out if frequently used code is
rather spread across many pages (bad) or coallesced
(good).
Signed-off-by: Robert Jarzmik
---
Since V1:
- included Andrew's comments
- included Dave's comment
- fixed according to Hugh's comment
---
/lib/libc.so) to see the eviction
cycles, and find out if frequently used code is
rather spread across many pages (bad) or coallesced
(good).
Signed-off-by: Robert Jarzmik
---
Since V1:
- included Andrew's comments
- included Dave's comment
- fixed according to Hugh's c
scription.
But anyway :
Acked-by: Robert Jarzmik
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
8310171d8794f2a793ec5d4d Mon Sep 17 00:00:00 2001
From: Robert Jarzmik
Date: Mon, 9 Apr 2012 13:19:08 +0200
Subject: [PATCH] mtd: docg3 fix missing bitreverse lib
Fix missing dependency which can cause a build error such
as: ERROR: "byte_rev_table" [drivers/mtd/devices/docg3.ko]
undefined!
Guennadi Liakhovetski writes:
> (adding Robert to CC)
> I don't think any data is freed by pxa_free_dma(), it only disables DMA on
> a certain channel. Theoretically there could be a different problem:
> pxa_free_dma() deactivates DMA, whereas pxa_dma_start_channels() activates
> it. But I thi
Peter Ujfalusi writes:
> On 07/18/16 13:34, Russell King - ARM Linux wrote:
>> On Thu, Jul 14, 2016 at 03:42:37PM +0300, Peter Ujfalusi wrote:
>>> Before looking for the next descriptor to start, complete the just finished
>>> cookie.
>>
>> This change will reduce performance as we no longer hav
Cc: Alexandre Courbot
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Linus Walleij
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org
> Cc: linux-o...@vger.kernel.org
> Cc: Robert Jarzmik
> Cc: Russell King
> Cc: Tony Lindgren
>
> P
r the clocksource part
- Wim for sa1100_wdt.c
If the review converges, I'd also like to take it through the pxa/for-next tree,
or alternatively Russell's tree if there is a dependency I'm not seeing, for
v4.10 cycle.
Cheers.
Robert Jarzmik (3):
ARM: sa11x0/pxa: acquire timer rate
As both pxa and sa1100 provide a clock to the timer, the rate can be
inferred from the clock rather than hard encoded in a functional call.
This patch changes the pxa timer to have a mandatory clock which is used
as the timer rate.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/generic.c
From: Russell King - ARM Linux
The OSTIMER0 clock ticks at the main oscillator rate, not the 32kHz
oscillator rate. Ensure that it is parented to the main oscillator.
Signed-off-by: Russell King
Acked-by: Robert Jarzmik
Tested-by: Robert Jarzmik
---
drivers/clk/pxa/clk-pxa25x.c | 2 +-
1
The last user of this function is gone, so remove it. The clock API
should now be used to get clock rates.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/generic.c | 15 ---
arch/arm/mach-pxa/include/mach/hardware.h| 2 --
arch/arm/mach-sa1100/include/mach
The OS timer rate used for the watchdog can now be fetched from the
standard clock API. This will remove the last user of
get_clock_tick_rate() in both pxa and sa11x0 architectures.
Signed-off-by: Robert Jarzmik
---
drivers/watchdog/sa1100_wdt.c | 24 +++-
1 file changed, 23
Guenter Roeck writes:
> On 09/19/2016 03:36 PM, Russell King - ARM Linux wrote:
>> On Mon, Sep 19, 2016 at 01:08:16PM -0700, Guenter Roeck wrote:
>>> On Mon, Sep 19, 2016 at 09:12:14PM +0200, Robert Jarzmik wrote:
>>>> The OS timer rate used for the watchd
b2_core_streamon+0x1b4): undefined reference to
> `v4l_vb2q_enable_media_source'
> drivers/media/v4l2-core/videobuf2-v4l2.o: In function `vb2_ioctl_reqbufs':
> videobuf2-v4l2.c:(.text.vb2_ioctl_reqbufs+0xc): undefined reference to
> `video_devdata'
>
> This adds back an explicit dependency.
That looks right to me.
Acked-by: Robert Jarzmik
Cheers.
--
Robert
During sensors binding, there is a window where the sensor is switched
off, while there is a call it to set a new format, which can end up in
an access to the sensor, especially an I2C based sensor.
Remove this window by activating the sensor.
Signed-off-by: Robert Jarzmik
---
drivers/media
plug in a
gpio based or ldo regulator, mimicking their former soc_camera power
hook.
Fixes: 5c10113cc668 ("media: mt9m111: make a standalone v4l2 subdevice")
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/mt9m111.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
pxa_camera has transitioned from a soc_camera driver to a standalone
v4l2 driver. Amend the device declaration accordingly.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/mioa701.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm/mach-pxa/mioa701.c
pxa_camera has transitioned from a soc_camera driver to a standalone
v4l2 driver. Amend the device declaration accordingly.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/em-x270.c | 85 ++---
1 file changed, 27 insertions(+), 58 deletions(-)
diff
pxa_camera has transitioned from a soc_camera driver to a standalone
v4l2 driver. Amend the device declaration accordingly.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/ezx.c | 176
1 file changed, 72 insertions(+), 104 deletions(-)
diff
Russell King - ARM Linux writes:
> On Mon, Sep 05, 2016 at 10:58:03AM +1000, Stephen Rothwell wrote:
>> I fixed it up (I deleted the file) and can carry the fix as
>> necessary. This is now fixed as far as linux-next is concerned, but any
>> non trivial conflicts should be mentioned to your upstr
This aligns smc91x with its cousin, namely smc911x.c.
This also allows the driver to run also in a device-tree based lubbock
board build, on which it was tested.
Signed-off-by: Robert Jarzmik
---
drivers/net/ethernet/smsc/smc91x.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
, platform_get_irq()
doesn't honor the irq type IO resource (ie. edge rising for example),
and it must be passed again at irq request in a not device-tree build,
hence the irq_get_trigger_type() call.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/pxa_cplds_irqs.c | 11 ---
1 file chang
In the device-tree case, the root interrupt controller cannot be
accessed through the 6th coprocessor, contrary to pxa27x and pxa3xx
architectures.
Fix it to behave as in non-devicetree builds.
Fixes: 32f17997c130 ("ARM: pxa: remove irq init from dt machines")
Signed-off-by: Robe
multiplexed on pxa_cplds for ethernet, sa, usb udc, and other
devices.
Signed-off-by: Robert Jarzmik
---
arch/arm/boot/dts/pxa2xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/pxa2xx.dtsi b/arch/arm/boot/dts/pxa2xx.dtsi
index 3ff077ca4400
Robert Jarzmik writes:
> Hi,
>
> This serie aims at killing get_clock_tick_rate() from pxa and sa1100 and
> replace
> it by clock API calls.
>
> I'd like to have this reviewed and acked afterwards at least by :
> - Russell for the mach-sa1100 and sa1100_wdt.c
&g
Robert Jarzmik writes:
>>> If so, great, get the platform maintainer to sign off on this please and
>>> then resend it.
>
> If you're talking about the PXA maintainer, then :
> Acked-by: Robert Jarzmik
>
> I'm happy with the patch, all pxa board
.
Signed-off-by: Sergei Ianovich
CC: Heikki Krogerus
CC: James Cameron
CC: Greg Kroah-Hartman
CC: Robert Jarzmik
CC: Russell King
Reviewed-by: Heikki Krogerus
[rebased on v4.8]
Tested-by: Robert Jarzmik
Signed-off-by: Robert Jarzmik
---
drivers/tty/serial/8250/8250_pxa.c | 177
Greg Kroah-Hartman writes:
> On Tue, Sep 27, 2016 at 05:47:54PM +0200, Robert Jarzmik wrote:
>> If you're overburdened and feel there won't be a merge conflict in your
>> serial
>> tree, I can take it through pxa tree provided you ack it, or you can take it,
&
Joe Perches writes:
> Use the more common logging mechanism.
>
> Miscellanea:
>
> o Realign multiline statements
> o Coalesce format
>
> Signed-off-by: Joe Perches
For pxa25x_udc.h:
Acked-by: Robert Jarzmik
Cheers.
--
Robert
Robert Jarzmik writes:
>> Hi,
>>
>> This serie aims at killing get_clock_tick_rate() from pxa and sa1100 and
>> replace
>> it by clock API calls.
>>
>> I'd like to have this reviewed and acked afterwards at least by :
>> - Russell for the
cause it is used as a boolean value to
check a gpio activation.
Fixes: 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of
gpio register")
Reported-by: Dan Carpenter
Signed-off-by: Robert Jarzmik
---
Since v1: replaced binary ORs with logical ORs after assembly comparison
Joe Perches writes:
> On Sat, 2016-07-30 at 13:22 +0200, Robert Jarzmik wrote:
...zip...
> $ git grep -w charger_wakeup
> arch/arm/mach-pxa/corgi_pm.c: .charger_wakeup = corgi_charger_wakeup,
> arch/arm/mach-pxa/sharpsl_pm.c: if
> (sharpsl_pm.machinfo->cha
tion instead of
gpio register")
Reported-by: Dan Carpenter
Cc: Joe Perches
Signed-off-by: Robert Jarzmik
---
Since v1: replaced binary ORs with logical ORs after assembly comparison
Since v2: changed charger_wakeup prototype to bool foo()
---
arch/arm/mach-pxa/corgi_pm.c | 12 +
Hi Hans,
Hans Verkuil writes:
> On 04/02/2016 04:26 PM, Robert Jarzmik wrote:
>> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
>> b/drivers/media/platform/soc_camera/pxa_camera.c
>> index b8dd878e98d6..30d266bbab55 100644
>> --- a/drivers/media/platf
Hi Joe,
Joe Perches writes:
> trivially:
>> diff --git a/arch/arm/mach-pxa/corgi_pm.c b/arch/arm/mach-pxa/corgi_pm.c
> []
>> @@ -131,15 +131,13 @@ static int corgi_should_wakeup(unsigned int
>> resume_on_alarm)
>> return is_resume;
>> }
>>
>> -static unsigned long corgi_charger_wakeup(vo
Propagate board initialization return code upwards, so that
pcmcia_probe() can report a failure if occurs down the call chain.
Signed-off-by: Robert Jarzmik
---
drivers/pcmcia/sa_generic.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pcmcia
Lars-Peter Clausen writes:
> On 08/04/2016 06:08 PM, Sinan Kaya wrote:
> [...]
>> The other way is I can feed this information to what Dave just introduced
>> as part of the callback mechanism and not touch this.
>
> Use the callback mechanism. It is a lot easier to implement correctly than
> the
In a very tight timeframe, the debug message in the transfer completion
handler can be misleading, as the completion test report can change just
after the message, and the code flow cannot be deduced from the debug
message.
This is just a cleanup to make debugging easier.
Signed-off-by: Robert
-chaining several "small transfers"
to a running "big transfer", not in a real-life usecase but by testing
the robustness of the driver.
Signed-off-by: Robert Jarzmik
---
drivers/dma/pxa_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/pxa
: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera/mt9m111.c
index a7efaa5964d1..ea5b5e709402 100644
--- a/drivers/media/i2c/soc_camera
Add sequence numbers to completed buffers.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media/platform/soc_camera/pxa_camera.c
index
This is to be seen as a regression as the set_crop function is
removed. This is a temporary situation in the v4l2 porting, and will
have to be added later.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 76 --
1 file changed, 76
Add pxa_camera registers access through advanced video debugging.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 57 ++
1 file changed, 57 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media
Introduce sensor_call(), which will be used for all sensor invocations.
This is a preparation move to v4l2 device conversion, ie. soc_camera
adherence removal.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 27 ++
1 file changed, 15
mt9m111 being a camera sensor, its colorspace should always be SRGB, for
both RGB based formats or YCbCr based ones.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/soc_camera
Make all print consistent by always using :
- dev_xxx(pcdev_to_dev(pcdev), )
This prepares the soc_camera adherence removal by making these call rely
on only pcdev, and not the soc_camera icd structure.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 70
doesn't modify a single line of code.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 475 +
1 file changed, 242 insertions(+), 233 deletions(-)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media/platform/soc_c
As the conversion to a v4l2 standalone device is finished, move
pxa_camera one directory up and finish severing any dependency to
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/Kconfig |8 +
drivers/media/platform/Makefile|1
As the mt9m111 is now working as a standalone v4l2 subdevice sensor,
move it out of soc_camera directory and severe its dependency on
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/Kconfig |7 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c
-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 51 ++
1 file changed, 15 insertions(+), 36 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera/mt9m111.c
index 6dfaead6aaa8..a7efaa5964d1 100644
--- a
defconfig + platform data).
I've also put the whole serie here if you want to fetch and review from git
directly :
- git fetch https://github.com/rjarzmik/linux.git work/v4l2
Happy review.
--
Robert
Robert Jarzmik (14):
media: mt9m111: make a standalone v4l2 subdevice
media: mt9m11
sing.
In a subsequence patch pxa_camera_mclk_ops should be used, and
platform data MCLK ignored. It will be the sensor's duty to request
the clock and enable it, which will end in pxa_camera_mclk_ops.
Signed-off-by: Robert Jarzmik
---
Since v1:
- function namings were cleaned into pxac_XXX_Y
a "cancel capture" than a "wait for end
of capture" semantic.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/soc_camera/pxa_camer
ned-off-by: Robert Jarzmik
---
Since v1: took into account Hans's comments
renamed all vb2 functions to pxac_vb2_*()
Since v2: spit queue_buffer() and start_streaming()
---
drivers/media/platform/soc_camera/Kconfig | 4 +-
drivers/media/platform/soc_camera/pxa
Arnd Bergmann writes:
> On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote:
>> drivers/net/ethernet/smsc/smc91x.h | 50
>> +++---
>> 1 file changed, 30 insertions(+), 20 deletions(-)
>>
>> While this patch fixes one bug on Neponset, it probably doe
Hi Kees,
Today my linux-next build broke for the pxa architecture.
My specific setup is :
- ARCH=arm make pxa_defconfig; ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- make
- my compiler is:
rj@belgarion:~/mio_linux/kernel$ arm-linux-gnueabi-gcc --version
arm-linux-gnueabi-gcc (Debian
When the old AC97 is not used, CONFIG_SND_SOC_AC97_BUS is not
defined. As a consequence, in the error path, snd_soc_free_ac97_codec()
is not defined and triggers a compilation error.
Fix it for wm9705 and wm9712, as wm9713 is correctly written.
Signed-off-by: Robert Jarzmik
---
sound/soc
As the clock settings have been introduced into the clock pxa drivers,
which are now available to change the CPU clock by themselves, remove
the clock handling from this driver, and rely on pxa clock drivers.
Signed-off-by: Robert Jarzmik
Acked-by: Viresh Kumar
---
This is a resend of a
Kees Cook writes:
> If the compiler didn't support a build mode, the second empty test would
> still trip. This moves it to an "else" test for the non-AUTO modes.
>
> Reported-by: Robert Jarzmik
> Signed-off-by: Kees Cook
> ---
> Robert, can you test
nter.
>
> Cc: Daniel Mack
> Cc: Haojian Zhuang
> Cc: Robert Jarzmik
> Cc: Russell King
> Cc: linux-arm-ker...@lists.infradead.org
> Signed-off-by: Kees Cook
Applied to pxa/for-next tree, thanks.
--
Robert
Wolfram Sang writes:
Hi Wolfram,
> Wouldn't it be even cleaner if patch 1 & 2 above would be swapped? First
> move the chunk, then rename the file?
Yeah sure.
> And is there a branch I should base this on? Currently, I am thinking of
> basing this patch on for-next and then submit it around rc1
Philipp Zabel writes:
> On Sun, Oct 4, 2015 at 12:31 PM, Robert Jarzmik
> wrote:
>> + lcd-controller@4050 {
>> + compatible = "marvell,pxa2xx-lcdc";
>> + reg = <0x4400 0x1>;
>> + interru
Rob Herring writes:
> On Sun, Oct 4, 2015 at 5:31 AM, Robert Jarzmik wrote:
>> Add documentation for the PXA frambuffer devicetree binding.
>
> Strictly speaking this is a binding for PXA display controller, not a
> Linux FB driver. There are lots of "framebuffer" an
Philipp Zabel writes:
> Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek:
>> This patch optimizes initial values of the EGPIO chip driver.
>>
>> GSM and sound should be powered off during boot. A weak accumulator
>> and
>> a powered GSM sometimes cause a system reboot. A charging current
Philipp Zabel writes:
> Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek:
>> This patch adds support for an OV9640 camera to the HTC Magician
>> machine.
>>
>> Signed-off-by: Petr Cvek
>
> Still untested, but looks good to me.
I'm still reluctant to have the reset with the timings handl
Ezequiel Garcia writes:
> Robert,
>
> On 24 Aug 08:41 PM, Robert Jarzmik wrote:
>> Now pxa architecture has a dmaengine driver, remove the access to direct
>> dma registers in favor of the more generic dmaengine code.
>>
>> This should be also applicable for mmp
Ezequiel Garcia writes:
> Robert,
>
> On 24 August 2015 at 15:24, Robert Jarzmik wrote:
>> Ezequiel Garcia writes:
>>
>>> Should we worry about having two definitions for the same bit?
>>> Would it be too ugly to mix the two meaning? Something like this
From: Robert Jarzmik
In preparation for dmaengine conversion, move the camera interrupt
handling into a tasklet. This won't change the global flow, as this
interrupt is only used to detect the end of frame and activate DMA fifos
handling.
Signed-off-by: Robert Jarzmik
---
drivers/
Hi Guennadi,
This is the forth round.
This time sg_split() was a consequence of (a) and (b), ie. sg_split() move into
kernel's lib/ directory, and following dmaengine "reuse" flag introduction,
change pxa_camera accordingly.
Happy review.
Cheers.
Robert Jarzmik (4):
media:
. This
effectively prevents a lockup on zylonite when removing pxa3xx-nand
module, and using ethernet afterwards.
Signed-off-by: Robert Jarzmik
---
Since v1: add comment, switch to NFCV1/NCFV2 registers naming
---
drivers/mtd/nand/pxa3xx_nand.c | 17 +++--
1 file changed, 15 insertions
planes captures (Y, U, V).
Signed-off-by: Robert Jarzmik
---
Since v1: Guennadi's fixes
dma tasklet functions prototypes change (trivial move)
Since v2: sglist cut revamped with Guennadi's comments
Since v3: sglist split removed after Andrew's merge in -mm tree in lib/
From: Robert Jarzmik
Fix the error path where the video buffer wasn't allocated nor
mapped. In this case, in the driver free path don't try to unmap memory
which was not mapped in the first place.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 6
From: Robert Jarzmik
This moves the dma irq handling functions up in the source file, so that
they are available before DMA preparation functions. It prepares the
conversion to DMA engine, where the descriptors are populated with these
functions as callbacks.
Signed-off-by: Robert Jarzmik
Guennadi Liakhovetski writes:
> This still seems to break compilation to me. Could you compile-test after
> each your patch, please?
Ah yes. Ill timing, I had sent the v4 before having these comments, so I'll have
to fix it in v5.
Cheers.
--
Robert
--
To unsubscribe from this list: send the l
Guennadi Liakhovetski writes:
>> +last_buf = list_entry(pcdev->capture.prev,
>> + struct pxa_buffer, vb.queue);
>
> You can use list_last_entry()
Ok.
>> +last_status = dma_async_is_tx_complete(pcdev->dma_chans[chan],
>> +
The PXA architecture provides a DMA to pump data from the nand
controller to memory and the other way around. Add it to the binding
description.
Signed-off-by: Robert Jarzmik
---
Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a
Add documentation for the PXA LCD controller devicetree binding.
Signed-off-by: Robert Jarzmik
---
Since v1: Philipp's review on the whole binding
Since v2: moved to display/, Philipp's and Rob's review
dropped panel description, should be a simple panel with a
kups on startup")
> ---
> We merged the patch that introduced this as a fix for 4.3, so we should
> probably add this one too.
Oh yes, didn't see that ifdef, and all my non-regression defconfigs have
CONFIG_PM ...
Acked-by: Robert Jarzmik
So do you want to take it direc
Arnd Bergmann writes:
> The z2 machine calls pxa27x_set_pwrmode() in order to power off
> the machine, but this function gets discarded early at boot because
> it is marked __init, as pointed out by kbuild:
>
> WARNING: vmlinux.o(.text+0x145c4): Section mismatch in reference from the
> function
Robert Jarzmik writes:
> Arnd Bergmann writes:
>
>> The z2 machine calls pxa27x_set_pwrmode() in order to power off
>> the machine, but this function gets discarded early at boot because
>> it is marked __init, as pointed out by kbuild:
>>
>> WARNING: vmlinu
Arnd Bergmann writes:
>> It looks to me the powermode should be initialized once and for all in the
>> machine init code. So unless I've overseen something, I'll keep Thierry's
>> patch.
>
> Ah, sorry. I should have looked at the link you sent.
>
> Thierry's patch indeed looks much nicer if that
In order to prepare the transition to a mixed platform data and
device-tree initialization, remove all the platform data references all
over the driver.
Copy the platform data into the internal structure of the pxafb, and
only use this afterward.
Signed-off-by: Robert Jarzmik
---
drivers/video
uffer configurations with different bits per
pixel, only the LCD hardware bus width is used.
The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely
lubbock, mainstone and zylonite).
Signed-off-by: Robert Jarzmik
---
Since v1: Philipp's review: of_graph usage
---
drivers/v
As this driver provides a mechanism to reuse transfers, declare it in
its probe function.
Signed-off-by: Robert Jarzmik
---
drivers/dma/pxa_dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
index fc4156afa070..f2a0310ae771 100644
--- a
: Add DMA_CTRL_REUSE")
Signed-off-by: Robert Jarzmik
---
drivers/dma/dmaengine.c | 1 +
include/linux/dmaengine.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 09479d4be4db..0d64dc8627a8 100644
--- a/drivers/dma/dmaengine.c
+++ b/d
set in the
transfer.
This patch is a respin of the former DMA_CTRL_ACK approach, which was
reverted due to a regression in audio drivers.
Signed-off-by: Robert Jarzmik
---
Since v1: added doxygen commit to vchan_tx_desc_free
---
drivers/dma/virt-dma.
Philipp Zabel writes:
> Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek:
>> This patch changes the comments in the HTC Magician machine source
>> code
>> to better describe used devices and interfaces.
>>
>> Signed-off-by: Petr Cvek
Queued to pxa/for-next with Philipp's comments taken
Petr Cvek writes:
> Dne 3.10.2015 v 14:30 Philipp Zabel napsal(a):
>> Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek:
>>> This patch fixes a pin mux for the HTC Magician machine. Wrong and
>>> missing
>>> definitions caused a bad LCD operation and an unavailability of
>>> several
>>> pe
Philipp Zabel writes:
>> +static struct regulator_init_data magician_max1587a_v3_info = {
>> +.constraints = {
>> +.name = "vcc_core range",
>> +.min_uV = 70,
>> +.max_uV = 150,
>
> Wouldn't that be 1475000 for MAX1587A wit
1 - 100 of 1327 matches
Mail list logo
