Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface

2015-07-05 Thread Robert Jarzmik
interface for, I'll just hope it's the intended purpose. The code does look equivalent to me anyway. Apart from the cosmetic comment, once it is fixed : Acked-by: Robert Jarzmik robert.jarz...@free.fr Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v3 1/6] ARM: dts: pxa: add dma controller

2015-07-05 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: Applied to pxa/dt, thanks. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-05 Thread Robert Jarzmik
planes captures (Y, U, V). Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: Guennadi's fixes dma tasklet functions prototypes change (trivial move) --- drivers/media/platform/soc_camera/pxa_camera.c | 438 - 1 file changed, 215 insertions(+), 223

[PATCH v2 1/4] media: pxa_camera: fix the buffer free path

2015-07-05 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/media

[PATCH v2 2/4] media: pxa_camera: move interrupt to tasklet

2015-07-05 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik

[PATCH v2 0/4] media: pxa_camera conversion to dmaengine

2015-07-05 Thread Robert Jarzmik
tree and merged, as well as the dma buffer reusability stuff. This begins round 2 of dmaengine conversion of pxa_camera, happy review. Cheers. -- Robert Robert Jarzmik (4): media: pxa_camera: fix the buffer free path media: pxa_camera: move interrupt to tasklet media: pxa_camera: trivial

[PATCH v2 3/4] media: pxa_camera: trivial move of dma irq functions

2015-07-05 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off

Re: [PATCH 16/41] clocksource: pxa: Migrate to new 'set-state' interface

2015-07-06 Thread Robert Jarzmik
Viresh Kumar viresh.ku...@linaro.org writes: Hi Robert, On 04-07-15, 17:42, Robert Jarzmik wrote: + /* initializing, released, or preparing for suspend */ + timer_writel(timer_readl(OIER) ~OIER_E0, OIER); + timer_writel(OSSR_M0, OSSR); + return 0; For consistency, please leave

Re: [PATCH v3 1/6] Documentation: dmaengine: pxa-dma design

2015-05-25 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: Robert Jarzmik robert.jarz...@free.fr writes: Robert Jarzmik robert.jarz...@free.fr writes: Hi Vinod, ... removed most of the people as this is a non-technical mail ... I hope to land this in the upcoming merge window. We're at -rc3, so time

Re: [PATCH v3 3/6] dmaengine: pxa: add pxa dmaengine driver

2015-05-25 Thread Robert Jarzmik
Vinod Koul vinod.k...@intel.com writes: +#define DCSR_RUNBIT(31) /* Run Bit (read / write) */ +#define DCSR_NODESC BIT(30) /* No-Descriptor Fetch (read / write) */ +#define DCSR_STOPIRQEN BIT(29) /* Stop Interrupt Enable (read / write) */ +#define DCSR_REQPENDBIT(8) /*

Re: [PATCH v3 6/6] Documentation: dmaengine: document DMA_CTRL_ACK

2015-05-25 Thread Robert Jarzmik
Vinod Koul vinod.k...@intel.com writes: Also, we should still mention that it's !slave API only. Certainly not, it's fully slave API, that's the purpose of this patch. Its is not dependent on slave, it cna be used by slave as well as other users You're right Vinod. I will rephrase that :

[PATCH v4 5/5] dmaengine: pxa_dma: add support for legacy transition

2015-05-25 Thread Robert Jarzmik
-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/dma/pxa_dma.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c index 7da79d0..ddcbbf5 100644 --- a/drivers/dma/pxa_dma.c +++ b/drivers/dma/pxa_dma.c @@ -410,6 +410,15

[PATCH v4 2/5] MAINTAINERS: add pxa dma driver to pxa architecture

2015-05-25 Thread Robert Jarzmik
Add the pxa dma driver as maintained by the pxa architecture maintainers, as it is part of the core IP. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a76a40..35062a7 100644

[PATCH v4 3/5] dmaengine: pxa: add pxa dmaengine driver

2015-05-25 Thread Robert Jarzmik
and pxamci. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: 1) fixed muxed interrupt requesting Since v2: Vinod's review - dev_* instead of chan_* - pxad_config() dma direction change - residue calculation simplification - dcmd

[PATCH v4 1/5] Documentation: dmaengine: pxa-dma design

2015-05-25 Thread Robert Jarzmik
Document the new design of the pxa dma driver. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v2: Vinod's review --- Documentation/dmaengine/pxa_dma.txt | 153 1 file changed, 153 insertions(+) create mode 100644 Documentation/dmaengine

[PATCH v4 4/5] dmaengine: pxa_dma: add debug information

2015-05-25 Thread Robert Jarzmik
(d294948c2ce4e1c85f452154469752cc9b8e876d). Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v2: bissectability Since v3: PXA_DCSR_ prefix --- drivers/dma/pxa_dma.c | 244 ++ 1 file changed, 244 insertions(+) diff --git a/drivers/dma/pxa_dma.c b/drivers/dma

Re: [PATCH v4 1/5] Documentation: dmaengine: pxa-dma design

2015-05-26 Thread Robert Jarzmik
Vinod Koul vinod.k...@intel.com writes: On Mon, May 25, 2015 at 11:29:18PM +0200, Robert Jarzmik wrote: Document the new design of the pxa dma driver. Applied all, Thanks Thanks so much Vinod. This really helps me moving forward. Cheers. -- Robert -- To unsubscribe from this list: send

[PATCH RESEND 2/2] Documentation: dmaengine: document DMA_CTRL_ACK

2015-05-26 Thread Robert Jarzmik
Add documentation about acking the transfers, and their reusability. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: Maxime Ripard maxime.rip...@free-electrons.com --- Documentation/dmaengine/provider.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH RESEND 0/2] dmaengine: make transfers reusable

2015-05-26 Thread Robert Jarzmik
according to Maxime's first 2 comments. Cheers. -- Robert [1] https://lkml.org/lkml/2015/3/21/230 Robert Jarzmik (2): dmaengine: virt-dma: don't always free descriptor upon completion Documentation: dmaengine: document DMA_CTRL_ACK Documentation/dmaengine/provider.txt | 11

[PATCH RESEND 1/2] dmaengine: virt-dma: don't always free descriptor upon completion

2015-05-26 Thread Robert Jarzmik
in the transfer. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Cc: Lars-Peter Clausen l...@metafoo.de Cc: Maxime Ripard maxime.rip...@free-electrons.com --- drivers/dma/virt-dma.c | 19 +-- drivers/dma/virt-dma.h | 13 - 2 files changed, 25 insertions(+), 7 deletions

Re: [PATCH v2 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-08-02 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Just tested linux-next (hence *without* the patchset) and I see the same Wait time out. In other words, pxa3xx-nand is broken on PXA :/ Interestingly, the culprit doesn't seem to be in pxa3xx-nand itself. Reverting the recent commits on

Re: [PATCH v2] clk: pxa: pxa3xx: fix CKEN register access

2015-08-08 Thread Robert Jarzmik
Stephen Boyd sb...@codeaurora.org writes: On 08/04, Robert Jarzmik wrote: Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names were inadequately inverted. As a consequence, all clock operations were happening on CKENB, because almost all but 2 clocks are on CKENA

[PATCH] lib: scatterlist: add sg splitting function

2015-08-08 Thread Robert Jarzmik
kfree() on the resulting scatterlists. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since RFC: Russell's review - address both the sg_phys case and sg_dma_address case (aka mapped case) = this should take care of IOMMU coalescing - add a way to return the new mapped lengths

[PATCH] dmaengine: pxa_dma: fix debug information

2015-08-18 Thread Robert Jarzmik
as it ought to be !!(drcmr DRCMR_MAPVLD)); ^ scripts/Makefile.build:258: recipe for target 'drivers/dma/pxa_dma.o' failed Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/dma/pxa_dma.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-18 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. I really don't see why we want this patch. It's

[PATCH RESEND 2/2] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-19 Thread Robert Jarzmik
-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index d1a4c336de1d..d6c696798811 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c

[PATCH RESEND 1/2] mtd: nand: pxa3xx_nand: fix early spurious interrupt

2015-08-19 Thread Robert Jarzmik
, blocking the good behavior of the nand. The same would happen if in pxa3xx_nand code flow a status bit is left, and then a command is started. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH RESEND 0/2] mtd: nand: pxa3xx-nand: fixes

2015-08-19 Thread Robert Jarzmik
Hi Brian, As promised, here are the remaining fixes I have on pxa3xx-nand I'd like you to queue up. The other changes I have submitted are under review and not of fixes type. Cheers. -- Robert Robert Jarzmik (2): mtd: nand: pxa3xx_nand: fix early spurious interrupt mtd: nand: pxa3xx-nand

[PATCH] ARM: pxa: fix DFI bus lockups on startup

2015-08-23 Thread Robert Jarzmik
before the clock is disabled. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- arch/arm/mach-pxa/include/mach/addr-map.h | 7 +++ arch/arm/mach-pxa/pxa3xx.c| 21 - 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-pxa/include

[PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-23 Thread Robert Jarzmik
. This effectively prevents a lockup on zylonite when removing pxa3xx-nand module, and using ethernet afterwards. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Ezequiel, this deserves a test on Armada, as the bit has another meaning there I think. --- drivers/mtd/nand/pxa3xx_nand.c | 7

Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-23 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. I

Re: [PATCH] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal

2015-08-24 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Should we worry about having two definitions for the same bit? Would it be too ugly to mix the two meaning? Something like this: /* This bit has two different meanings on NFCv1 and NFCv2 */ #define NDCR_STOP_ON_UNCOR_ARB_CNTL (0x1 19) I

[PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

2015-08-24 Thread Robert Jarzmik
to make the driver work in a devicetree environment. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 223 - 1 file changed, 109 insertions(+), 114 deletions(-) diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-19 Thread Robert Jarzmik
Brian Norris computersforpe...@gmail.com writes: Hi Robert, On Mon, Aug 17, 2015 at 09:15:48PM +0200, Robert Jarzmik wrote: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: So unless I'm completely off, the current patch is right, and a comment would be helpful. Ok Ezequiel, I'll

Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config

2015-08-17 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 16 August 2015 at 19:22, Robert Jarzmik robert.jarz...@free.fr wrote: Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: The cases of READID detection are broken on pxa3xx. The reason

Re: [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config

2015-08-16 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 11 Aug 09:57 PM, Robert Jarzmik wrote: The cases of READID detection are broken on pxa3xx. The reason is that in the early stages of nand probing, ie. at pxa3xx_nand_scan(), we always have : - info-use_dma = 0 (regardless of dma

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-16 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: On 12 Aug 06:22 PM, Robert Jarzmik wrote: This fix looks correct. Thanks! Couple questions: 1. In which platform are you seeing this bug? zylonite with a pxa310 (ie. internal stacked NAND). 2. Is this a regression? (i.e. should we

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-17 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: In other words, it seems that we must wake the IRQ thread handler _before_ we clear RDDREQ, not after. So unless I'm completely off, the current patch is right, and a comment would be helpful. Ok Ezequiel, I'll wait for your Tested-by,

Re: [PATCH] lib: scatterlist: add sg splitting function

2015-08-22 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: ...zip... top posting in [1] ... zip ... Hi Andrew, There was no review for a couple of weeks I'm afraid on this patch. Could I know what I can do to push it up ? And another question : do you want another patch to add a MAINTAINERS entry

[PATCH v3 4/4] media: pxa_camera: conversion to dmaengine

2015-07-29 Thread Robert Jarzmik
planes captures (Y, U, V). Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: Guennadi's fixes dma tasklet functions prototypes change (trivial move) Since v2: sglist cut revamped with Guennadi's comments --- drivers/media/platform/soc_camera/pxa_camera.c | 492

[PATCH v3 3/4] media: pxa_camera: trivial move of dma irq functions

2015-07-29 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com This moves the dma irq handling functions up in the source file, so that they are available before DMA preparation functions. It prepares the conversion to DMA engine, where the descriptors are populated with these functions as callbacks. Signed-off

[PATCH v3 0/4] media: pxa_camera conversion to dmaengine

2015-07-29 Thread Robert Jarzmik
) Guennadi: I think you had comments about free_buffer() I never received by mail, so there might be something to rework in this area. (d) Guennadi+Robert: continue review of the serie Happy review. Cheers. -- Robert Robert Jarzmik (4): media: pxa_camera: fix the buffer free path

[PATCH v3 1/4] media: pxa_camera: fix the buffer free path

2015-07-29 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com Fix the error path where the video buffer wasn't allocated nor mapped. In this case, in the driver free path don't try to unmap memory which was not mapped in the first place. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/media

[PATCH v3 2/4] media: pxa_camera: move interrupt to tasklet

2015-07-29 Thread Robert Jarzmik
From: Robert Jarzmik robert.jarz...@intel.com In preparation for dmaengine conversion, move the camera interrupt handling into a tasklet. This won't change the global flow, as this interrupt is only used to detect the end of frame and activate DMA fifos handling. Signed-off-by: Robert Jarzmik

[RFC PATCH v2] lib: scatterlist: add sg splitting function

2015-08-01 Thread Robert Jarzmik
() on the resulting scatterlists Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1: Russell's review - address both the sg_phys case and sg_dma_address case (aka mapped case) = this should take care of IOMMU coalescing - add a way to return the new mapped lengths of resulting

[PATCH v2] clk: pxa: pxa3xx: fix CKEN register access

2015-08-04 Thread Robert Jarzmik
that the wrong clock gate was manipulated. The error was revealed by changing the pxa3xx-and driver to a module, where tupon unloading the wrong clock was disabled in CKENB. Fixes: 9bbb8a338fb2 (clk: pxa: add pxa3xx clock driver) Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- Since v1

Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access

2015-08-04 Thread Robert Jarzmik
Stephen Boyd sb...@codeaurora.org writes: On 08/03/2015 12:58 PM, Robert Jarzmik wrote: Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names were inadequately inverted. As a consequence, all clock operations were happening on CKENB, because almost all but 2 clocks are on CKENA

Re: [RFC PATCH] lib: scatterlist: add sg splitting function

2015-07-30 Thread Robert Jarzmik
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Thu, Jul 30, 2015 at 09:02:15PM +0200, Robert Jarzmik wrote: Hmm. What happens if... n = dma_map_sg(dev, sg, nents, dir); where n nents (which can happen if you have an IOMMU and it coalesces the entries)? That's something

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow tHigh) configuration support

2015-08-05 Thread Robert Jarzmik
Vaibhav Hiremath vaibhav.hirem...@linaro.org writes: Robert, It would be helpful if you can test this patch-series and confirm that it now fixes the NULL pointer deference issue. Thanks, Vaibhav Hi Vaibhav, My next slot is probably this comming Sunday. I'll do the test and report.

[PATCH] video: fbdev: pxa3xx_gcu: prepare the clocks

2015-08-03 Thread Robert Jarzmik
) [c02d30dc] (clk_core_enable) from [c02d3118] (clk_enable+0x20/0x34) [c02d3118] (clk_enable) from [c0200dfc] (pxa3xx_gcu_probe+0x148/0x338) [c0200dfc] (pxa3xx_gcu_probe) from [c022eccc] (platform_drv_probe+0x30/0x94) Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/video/fbdev

[PATCH] clk: pxa: pxa3xx: fix CKEN register access

2015-08-03 Thread Robert Jarzmik
that the wrong clock gate was manipulated. The error was revealed by changing the pxa3xx-and driver to a module, where tupon unloading the wrong clock was disabled in CKENB. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/clk/pxa/clk-pxa3xx.c | 2 +- 1 file changed, 1 insertion

[RFC PATCH] lib: scatterlist: add sg splitting function

2015-07-30 Thread Robert Jarzmik
() on the resulting scatterlists Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- The sg_split() function is an attempt to address the splitting in a generic way. If it is judged unsuitable, it will remain as a specialized function in the depths of a media driver. Memo of people to ask

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow tHigh) configuration support

2015-08-09 Thread Robert Jarzmik
-by: Robert Jarzmik robert.jarz...@free.fr Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config

2015-08-11 Thread Robert Jarzmik
() will therefore end up in handle_data_pio(), and do_bytes will be 0, leading to not reading the nand id, and blocking detection. This doesn't happen if keep_config is used, which is probably the most tested case. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr Fixes: 70ed85232a93 (mtd: nand: pxa3xx

[PATCH 2/3] mtd: nand: pxa3xx_nand: fix early spurious interrupt

2015-08-11 Thread Robert Jarzmik
, blocking the good behavior of the nand. The same would happen if in pxa3xx_nand code flow a status bit is left, and then a command is started. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug

2015-08-11 Thread Robert Jarzmik
Add verbose debug for register accesses. This enables easier debugging by following where and how hardware is stimulated, and how it answers. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 22 +- 1 file changed, 17 insertions(+), 5

[PATCH] dma: pxa_dma: don't use config direction parameter

2015-08-11 Thread Robert Jarzmik
From: Robert Jarzmik r...@valbob.noip.me Don't use the direction passed in the configuration, and rely on each transfer's direction to prepare the transfers. This will enable future removal of direction parameter from dma_slave_config. Signed-off-by: Robert Jarzmik robert.jarz...@free.fr

Re: [PATCH v2 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-08-04 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: The issue I see is that : - there is a bug in the clk driver for pxa3xx I introduced (CKEN_AB) - and shutting down the GCU clock prevents the NAND from working (I can't explain that one yet) Ah actually it's even trickier, but it has

Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function

2015-08-04 Thread Robert Jarzmik
Andrew Morton a...@linux-foundation.org writes: include/linux/scatterlist.h | 5 ++ lib/scatterlist.c | 189 2 files changed, 194 insertions(+) It's quite a bit of code for a fairly specialised thing. How ugly would it be to put

Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access

2015-08-04 Thread Robert Jarzmik
Stephen Boyd sb...@codeaurora.org writes: On 08/03/2015 11:22 PM, Robert Jarzmik wrote: Stephen Boyd sb...@codeaurora.org writes: On 08/03/2015 12:58 PM, Robert Jarzmik wrote: Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names were inadequately inverted. As a consequence

Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access

2015-08-04 Thread Robert Jarzmik
Stephen Boyd sb...@codeaurora.org writes: On 08/04/2015 11:33 AM, Robert Jarzmik wrote: Stephen Boyd sb...@codeaurora.org writes: On 08/03/2015 11:22 PM, Robert Jarzmik wrote: Stephen Boyd sb...@codeaurora.org writes: On 08/03/2015 12:58 PM, Robert Jarzmik wrote: Clocks 0 to 31

Re: [PATCH] video: fbdev: pxa3xx_gcu: prepare the clocks

2015-08-10 Thread Robert Jarzmik
Tomi Valkeinen tomi.valkei...@ti.com writes: On 03/08/15 23:15, Robert Jarzmik wrote: Thanks, I've queued this for 4.2 fixes. Thanks Tomi. Cheers. -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] arm: mainstone_defconfig: disable IDE subsystem

2015-08-14 Thread Robert Jarzmik
haojian.zhu...@gmail.com Cc: Robert Jarzmik robert.jarz...@free.fr Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Robert Jarzmik robert.jarz...@free.fr -- Robert -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

2015-08-12 Thread Robert Jarzmik
-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/mtd/nand/pxa3xx_nand.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index b0737aec7caf..718097414b9c 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c

Re: [PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-26 Thread Robert Jarzmik
Guennadi Liakhovetski g.liakhovet...@gmx.de writes: Hi Robert, On Sun, 19 Jul 2015, Robert Jarzmik wrote: In principle, yes, it doesn't look all that horrible to me. You first split the global SG list into up to 3 per-channel ones, then you initialise your channels, what's wrong

Re: [PATCH] ARM: pxa: Use setup_timer

2015-07-14 Thread Robert Jarzmik
Vaishali Thakkar vthakkar1...@gmail.com writes: Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, a; @@

Re: [PATCH v2 01/13] ARM: kill off set_irq_flags usage

2015-07-14 Thread Robert Jarzmik
been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. As this works for several pxa boards : Acked-by: Robert Jarzmik robert.jarz...@free.fr -- Robert -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] ARM: pxa: fix dm9000 platform data regression

2015-07-16 Thread Robert Jarzmik
Igor Grinberg grinb...@compulab.co.il writes: Hi Robert, On 07/12/15 02:32, Robert Jarzmik wrote: Since dm9000 driver added support for a vcc regulator, platform data based platforms have their ethernet broken, as the regulator claiming returns -EPROBE_DEFER and prevents dm9000 loading

Re: [PATCH v2 06/13] irqchip: kill off set_irq_flags usage

2015-07-16 Thread Robert Jarzmik
Russell King - ARM Linux li...@arm.linux.org.uk writes: drivers/net/ethernet/smsc/smc911x.c drivers/net/ethernet/smsc/smc9194.c drivers/net/ethernet/smsc/smc91x.c Those might still be, but on the DT based boards the probing should be completely irrelevant SA11x0 stuff uses smc91x.c PXA

Re: [PATCH v2 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-07-17 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Hi Antoine, On 07/17/2015 10:41 AM, Antoine Tenart wrote: Hi guys, On Tue, Jul 07, 2015 at 05:08:23PM +0200, Antoine Tenart wrote: This series was part of a bigger one[1], which was split into smaller ones as asked by Ezequiel[2].

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-17 Thread Robert Jarzmik
Vaibhav Hiremath vaibhav.hirem...@linaro.org writes: So, I applied patches 1-6 to for-next to make some progress. The others need more thought because of the bindings which shall be discussed replying to the patches in question. Thanks for the updated work with lots of proper references.

[PATCH] scripts: decode_stacktrace: fix ARM architecture decoding

2015-07-18 Thread Robert Jarzmik
it by chopping starting and ending parenthesis from the each symbol name. As a side note, this probably comes from the function dump_backtrace_entry(), which is implemented differently for each architecture. That makes a single decoding script a bit a challenge. Signed-off-by: Robert Jarzmik robert.jarz

Re: [PATCH v2 4/4] media: pxa_camera: conversion to dmaengine

2015-07-18 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: Guennadi Liakhovetski g.liakhovet...@gmx.de writes: /* init DMA for Y channel */ How about taking the loop over the sg list out of pxa_init_dma_channel() to avoid having to iterate it from the beginning each time? Then you would

[PATCH] clk: pxa: fix core frequency reporting unit

2015-07-12 Thread Robert Jarzmik
clock drivers) Fixes: d40670dc6169 (clk: add pxa27x clock drivers) Fixes: 9bbb8a338fb2 (clk: pxa: add pxa3xx clock driver) Signed-off-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/clk/pxa/clk-pxa25x.c | 2 +- drivers/clk/pxa/clk-pxa27x.c | 2 +- drivers/clk/pxa/clk-pxa3xx.c | 2 +- 3 files

Re: [PATCH] mmc: host: pxamci: switch over to dmaengine use

2015-07-20 Thread Robert Jarzmik
Ulf Hansson ulf.hans...@linaro.org writes: On 6 June 2015 at 23:15, Robert Jarzmik robert.jarz...@free.fr wrote: From: Daniel Mack zon...@gmail.com Switch over pxamci to dmaengine. This prepares the devicetree full support of pxamci. This was successfully tested on a PXA3xx board, as well

Re: [PATCH v2 0/4] mtd: pxa3xx_nand: rework the timing setup

2015-07-20 Thread Robert Jarzmik
Ezequiel Garcia ezequ...@vanguardiasur.com.ar writes: Here you go: http://git.infradead.org/users/ezequielg/linux/shortlog/refs/heads/pxa3xx-nand-timing-rework-v2 Okay, I've tested this on cm-x300. The result is not bright : nand: device found, Manufacturer ID: 0xec, Chip ID: 0xdc

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-20 Thread Robert Jarzmik
Vaibhav Hiremath vaibhav.hirem...@linaro.org writes: On Monday 20 July 2015 12:39 PM, Vaibhav Hiremath wrote: On Monday 20 July 2015 12:36 PM, Vaibhav Hiremath wrote: On Saturday 18 July 2015 01:19 AM, Robert Jarzmik wrote: Vaibhav Hiremath vaibhav.hirem...@linaro.org writes: So, I

Re: [PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > This patch attempts to enhance the case of a transfer submitted multiple > times, and where the cost of creating the descriptors chain is not > negligible. > > This happens with big video buffers (several megabytes, ie

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-24 Thread Robert Jarzmik
Robert Jarzmik <robert.jarz...@free.fr> writes: > Fix the error path where the video buffer wasn't allocated nor > mapped. In this case, in the driver free path don't try to unmap memory > which was not mapped in the first place. > > Signed-off-by: Robert Jarzmik &l

[PATCH] ASoC: wm9713: convert to regmap

2015-10-24 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/K

[PATCH v2] ASoC: wm9713: convert to regmap

2015-10-24 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: fix suspend/

Re: [PATCH v2 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-10-22 Thread Robert Jarzmik
kbuild test robot writes: > Hi Robert, > > [auto build test ERROR on v4.3-rc5 -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] ... >>> FATAL: drivers/video/fbdev/pxafb: struct of_device_id is not terminated >>> with a NULL entry! Ah

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-29 Thread Robert Jarzmik
Charles Keepax writes: > Yeah that solution looks a lot more like what I was expecting. Okay, so I'm ready to fire the v4. I'll wait a couple of days for others reviews and if none I'll send the v4. Cheers. -- Robert -- To unsubscribe from this list: send

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-29 Thread Robert Jarzmik
Boris Brezillon writes: > On Thu, 29 Oct 2015 18:23:47 +0100 > Marek Vasut wrote: > Except it's now how devices supporting 16 bits data bus are supposed to > work, which means your NAND controller will probably not be able to > send the

[PATCH v3 2/2] ASoC: wm9713: use snd_soc_*() calls to update ac97 registers

2015-10-27 Thread Robert Jarzmik
Convert wm9713 to use the more modern registers manipulation functions, such as snd_soc_read(), snd_soc_write() and snd_soc_update_bits(). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/wm9713.c | 140 +- 1 file chang

[PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-27 Thread Robert Jarzmik
Convert the Wolfson WM9713 to regmap API. This will leverage all the regmap functions (debug, registers update, etc ...). As a bonus, this will pave the path to gpio chip introduction, and devicetree support. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: fix suspend/

Re: [PATCH v5 1/4] media: pxa_camera: fix the buffer free path

2015-10-27 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Hi Robert, > > Didn't you tell me, that your dmaengine patch got rejected and therefore > these your patches were on hold? They were reverted, and then revamped into DMA_CTRL_REUSE, upstreamed and merged, as in the commit 272420214d26

Re: [PATCH v2 1/3] dmaengine: virt-dma: don't always free descriptor upon completion

2015-10-29 Thread Robert Jarzmik
Vinod Koul writes: >> Hi Vinod, >> >> Is this serie good for you or do you have remaining comments to be addressed >> ? > > Hi Robert, > > This series looks good, but I am afraid we are very close to merge window I > would like this to be deffered to next one for more

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-29 Thread Robert Jarzmik
Marek Vasut writes: >> Isn't there the case of a single NAND controller with 2 identical chips, >> each a 8 bit NAND chip, and the controller aggregating them to offer the >> OS a single 16-bit NAND chip ? > > Is that using 1 or 2 physical chipselect lines on the CPU (controller)

Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node

2015-10-28 Thread Robert Jarzmik
Brian Norris writes: >> > >> > Do some sorts of chipselects come into play here ? Ie. you can have one >> > master >> > with multiple NAND chips connected to it. >> >> Most NAND controllers support interacting with several chips (or >> dies in case your chip

Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

2015-10-28 Thread Robert Jarzmik
Charles Keepax writes: >> @@ -1158,6 +1199,9 @@ static int wm9713_soc_suspend(struct snd_soc_codec >> *codec) >> { >> u16 reg; >> >> +snd_soc_cache_sync(codec); > > There doesn't seem to be much point in syncing the cache at the > start of a

Re: [PATCH v4 0/5] mtd: pxa3xx_nand: rework the timing setup

2015-10-25 Thread Robert Jarzmik
Antoine Tenart writes: > Hello, > > Let's try one more time to get this merged. > > This series was part of a bigger one[1], which was split into smaller > ones as asked by Ezequiel[2]. When we take this into account this is > v9; with a v1 sent in January, 9

Re: [PATCH v2] ASoC: wm9713: convert to regmap

2015-10-26 Thread Robert Jarzmik
Charles Keepax <ckee...@opensource.wolfsonmicro.com> writes: > On Sat, Oct 24, 2015 at 11:37:07PM +0200, Robert Jarzmik wrote: >> Convert the Wolfson WM9713 to regmap API. This will leverage all the >> regmap functions (debug, registers update, etc ...). >> >> As

Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap

2015-10-26 Thread Robert Jarzmik
Lars-Peter Clausen <l...@metafoo.de> writes: > On 10/24/2015 11:37 PM, Robert Jarzmik wrote: > [...] >> -static unsigned int ac97_read(struct snd_soc_codec *codec, >> -unsigned int reg); >> -static int ac97_write(struct snd_soc_codec *codec, >> -

[PATCH] ASoC: ac97: add gpio chip

2015-11-11 Thread Robert Jarzmik
The AC97 specification provides a guide for 16 GPIOs in the codecs. If the gpiolib is compiled in the kernel, declare a gpio chip. This was tested with a pxa27x board (mioa701) and a wm9713 codec. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- include/sound/ac97_codec.h

[PATCH] gpio: pxa: change initcall level second attempt

2015-11-13 Thread Robert Jarzmik
will be available and no machine code => device initcall In order to fullfill all these constraints, the initcall level is either postcore for non devicetree platforms, and device for devicetree platforms. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- drivers/gpio/gpio-pxa.c | 1

[PATCH v4 2/2] video: fbdev: pxafb: initial devicetree conversion

2015-11-16 Thread Robert Jarzmik
configurations with different bits per pixel, only the LCD hardware bus width is used. The patch was tested on both pxa25x, pxa27x and pxa3xx platform (namely lubbock, mainstone and zylonite). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: Philipp's review: of_graph

[PATCH v4 1/2] video: fbdev: pxafb: loosen the platform data bond

2015-11-16 Thread Robert Jarzmik
In order to prepare the transition to a mixed platform data and device-tree initialization, remove all the platform data references all over the driver. Copy the platform data into the internal structure of the pxafb, and only use this afterward. Signed-off-by: Robert Jarzmik <robert.j

[PATCH v4 2/2] ASoC: wm9713: use snd_soc_*() calls to update ac97 registers

2015-11-01 Thread Robert Jarzmik
Convert wm9713 to use the more modern registers manipulation functions, such as snd_soc_read(), snd_soc_write() and snd_soc_update_bits(). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- sound/soc/codecs/wm9713.c | 140 +- 1 file chang

[PATCH v4 1/2] ASoC: wm9713: convert to regmap

2015-11-01 Thread Robert Jarzmik
/resume. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> --- Since v1: fix suspend/resume (that specific part is not tested yet) Since v2: split out the snd_soc_*() from regmap support Since v3: remove suspend/resume regmap cache operations, rely on regmap volatile reg

<    1   2   3   4   5   6   7   8   9   10   >