Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-09 Thread Russell King - ARM Linux
On Sat, Feb 09, 2013 at 09:35:53PM +0530, Sekhar Nori wrote: On 2/1/2013 11:52 PM, Matt Porter wrote: + ret = of_address_to_resource(node, 1, res); of_address_to_resource() needs linux/of_address.h + if (IS_ERR_VALUE(ret)) This needs linux/err.h More importantly, is this the

Re: [PATCH 08/33] gpio: Convert to devm_ioremap_resource()

2013-02-11 Thread Russell King - ARM Linux
On Mon, Feb 11, 2013 at 02:53:47PM +0100, Linus Walleij wrote: NB: among the error codes people want to propagate from consumer interfaces such as say, clk_get(), regulator_get() and pinctrl_get() is -EPROBE_DEFER. So just something failed (return NULL) isn't enough. We then obviously need

Re: [PATCH 06/16] ARM idle: delete pm_idle

2013-02-11 Thread Russell King - ARM Linux
On Mon, Feb 11, 2013 at 04:02:30PM +, Catalin Marinas wrote: On Sun, Feb 10, 2013 at 05:58:13AM +, Len Brown wrote: pm_idle() on ARM was a synonym for default_idle(), so simply invoke default_idle() directly. The clean-up looks fine as we already have an arm_pm_idle but longer

Re: [tip:x86/mm] x86, mm: Use a bitfield to mask nuisance get_user() warnings

2013-02-12 Thread Russell King - ARM Linux
On Tue, Feb 12, 2013 at 09:32:54AM -0800, Linus Torvalds wrote: On Tue, Feb 12, 2013 at 9:14 AM, H. Peter Anvin h...@zytor.com wrote: No, I think what he is talking about it this bit: Ok, I agree that the bitfield code actually looks cleaner. That said, maybe gcc has an easier time

Re: [tip:x86/mm] x86, mm: Redesign get_user with a __builtin_choose_expr hack

2013-02-12 Thread Russell King - ARM Linux
On Tue, Feb 12, 2013 at 03:06:51PM -0800, Linus Torvalds wrote: So this looks clean, but I noticed something (that was true even of the old 64-bit accesses) On Tue, Feb 12, 2013 at 12:55 PM, tip-bot for H. Peter Anvin h...@linux.intel.com wrote: + register __inttype(*(ptr)) __val_gu

[PATCH] Remove obsolete email address for Zwane Mwaikambo

2013-02-13 Thread Russell King - ARM Linux
Zwane's arm.linux.org.uk email address has not been functional for a number of years now. It's time that all references to it were removed. I no longer have a forwarding address for Zwane, as I had assumed that my repeated requests over a number of years to Zwane to avoid use of this address had

Re: [PATCH v2 3/4] mtd: devices: elm: Low power transition support

2013-02-13 Thread Russell King - ARM Linux
On Wed, Feb 13, 2013 at 11:42:01AM +, Philip, Avinash wrote: On Sat, Feb 09, 2013 at 15:52:44, Russell King - ARM Linux wrote: On Thu, Feb 07, 2013 at 06:06:57PM +0530, Philip Avinash wrote: +static int elm_suspend(struct device *dev) +{ + struct elm_info *info = dev_get_drvdata

Re: [PATCH v2 00/13] drivers: mailbox: framework creation

2013-02-13 Thread Russell King - ARM Linux
On Wed, Feb 13, 2013 at 02:36:32PM +0100, Linus Walleij wrote: On Tue, Feb 12, 2013 at 5:56 AM, Suman Anna s-a...@ti.com wrote: I have hosted the series at [3]. [3] https://github.com/sumananna/mailbox/commits/dbx500-prcmu-mailbox Suman, I suggest you ask Stepgen Rothwell to include this

Re: [RFC PATCH 0/4] Add support for LZ4-compressed kernels

2013-02-04 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 03:02:49AM +0100, Markus F.X.J. Oberhumer wrote: At least akpm did approve the LZO update for inclusion into 3.7, but the code still has not been merged into the main tree. On 2012-10-09 21:26, Andrew Morton wrote: [...] The changes look OK to me. Please ask

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 05:41:53PM +0200, Felipe Balbi wrote: Hi, On Fri, Feb 01, 2013 at 09:30:03PM +, Russell King - ARM Linux wrote: I guess to make the MUSB side simpler we would need musb-dma-engine glue to map dmaengine to the private MUSB API. Then we would have some

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-04 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 06:47:12PM +0200, Felipe Balbi wrote: Hi, On Mon, Feb 04, 2013 at 08:36:38PM +0300, Sergei Shtylyov wrote: In my eyes, getting rid of the mess doesn't justify breaking the rules that Russell formulated above. MUSB is no PCI, there is no single, standard

Re: [PATCH V2] clk: Add composite clock type

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 11:22:52AM +0100, Hiroshi Doyu wrote: diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index f30fb4b..8f88805 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c @@ -27,6 +27,9 @@ static u8 clk_composite_get_parent(struct

Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 06:36:34AM +, Vishwanathrao Badarkhe, Manish wrote: I made following changes, in order to update dip-p pointer with correct value: - if (!dpi-p) { + if (IS_ERR_OR_NULL(dpi-p)) { dpi-p = devm_pinctrl_get(dev); - if

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 09:47:38PM +, Arnd Bergmann wrote: On Monday 04 February 2013, Linus Walleij wrote: So I think the above concerns are moot. The callback we can set on cookies is entirely optional, and it's even implemented by each DMA engine, and some may not even support it but

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Mon, Feb 04, 2013 at 04:54:45PM -0500, Cyril Chemparathy wrote: You're assuming that cookies complete in order. That is not necessarily true. Under what circumstances is that not true? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:47:05PM +, Mark Brown wrote: On Tue, Feb 05, 2013 at 05:21:48PM +0100, Linus Walleij wrote: For IRQ mode, use the completion callback to push each cookie to NAPI, and thus let the IRQ drive the traffic. The whole purpose of NAPI is to avoid taking

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-05 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 04:30:45PM +0100, Linus Walleij wrote: On Mon, Feb 4, 2013 at 10:54 PM, Cyril Chemparathy cy...@ti.com wrote: On 02/04/2013 04:11 PM, Linus Walleij wrote: Cyril, just stack up the cookies and take a sweep over them to see which ones are baked when the NAPI poll

Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

2013-02-06 Thread Russell King - ARM Linux
On Wed, Feb 06, 2013 at 11:28:11AM +0530, Kishon Vijay Abraham I wrote: Added has_mailbox to the musb platform data to specify that omap uses an external mailbox (in control module) to communicate with the musb core during device connect and disconnect. So, I've been through your five patches

Re: [PATCH 3/5] ARM: OMAP2: MUSB: Specify omap4 has mailbox

2013-02-06 Thread Russell King - ARM Linux
On Wed, Feb 06, 2013 at 01:22:31PM +0200, Felipe Balbi wrote: there's a little more to it. When running allmodconfig, CONFIG_ARCH_MULTIPLATFORM is set but none of the other ARCHes (ARCH_OMAP, ARCH_AT91, ARCH_VERSATILE, etc) are set, so it turned out that the driver wasn't even included on my

Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init

2013-02-06 Thread Russell King - ARM Linux
On Tue, Feb 05, 2013 at 09:41:48PM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding

Re: [PATCH RESEND] ARM: sched: correct update_sched_clock()

2013-02-06 Thread Russell King - ARM Linux
On Wed, Feb 06, 2013 at 10:33:53AM +0100, Linus Walleij wrote: On Wed, Feb 6, 2013 at 6:21 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: If we want load epoch_cyc and epoch_ns atomically, we should update epoch_cyc_copy first of all. This notify reader that updating is in progress. If

Re: [PATCH] arm: Preserve TPIDRURW on context switch

2013-02-06 Thread Russell King - ARM Linux
On Wed, Feb 06, 2013 at 11:43:10PM +0100, André Hentschel wrote: There are more and more applications coming to WinRT, Wine could support them, but mostly they expect to have the thread environment block (TEB) in TPIDRURW. This register must be preserved per thread instead of being cleared.

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 12:13:46PM +0530, Santosh Shilimkar wrote: To avoid the server latency, we didn't do continuous sync. The time was synced in the beginning and after 62.5 hours (#ntpd -qg) and the drift of about 174 ms was observed. As you said this could be because of server sync

Re: [RFC PATCH 0/4] Add support for LZ4-compressed kernels

2013-01-29 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 02:25:10PM -0800, Andrew Morton wrote: What's this with enabled unaligned memory access thing? You mean if the arch supports CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS? If so, that's only x86, which isn't really in the target market for this patch, yes? It's a lot of

Re: [RFC PATCH 0/4] Add support for LZ4-compressed kernels

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 12:43:20PM +0100, Egon Alter wrote: Am Dienstag, 29. Januar 2013, 10:15:49 schrieb Russell King - ARM Linux: On Mon, Jan 28, 2013 at 02:25:10PM -0800, Andrew Morton wrote: What's this with enabled unaligned memory access thing? You mean if the arch supports

Re: [RFC] arm: use built-in byte swap function

2013-01-29 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 07:30:33PM -0600, Kim Phillips wrote: AFAICT, arm gcc got __builtin_bswap{32,64} support in 4.6, and for the 16-bit version in 4.8. Hmm. $ /usr/local/aeabi/bin/arm-linux-gcc --version arm-linux-gcc (GCC) 4.5.4 Copyright (C) 2010 Free Software Foundation, Inc. This is

Re: [PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 10:34:53AM -0500, Alan Stern wrote: On Mon, 28 Jan 2013, Russell King - ARM Linux wrote: On Mon, Jan 28, 2013 at 10:17:33AM -0500, Alan Stern wrote: On Mon, 28 Jan 2013, Roger Quadros wrote: Make use of devm_request_and_ioremap() and correct comment

Re: [RFC PATCH 1/2] ARM: kernel: update cpuinfo to print CPU model name

2013-01-29 Thread Russell King - ARM Linux
On Tue, Jan 29, 2013 at 05:54:24PM +0200, Ruslan Bilovol wrote: CPU implementer : 0x41 CPU name: OMAP4470 ES1.0 HS Sigh. No. Look at what you're doing - look carefully at the above. CPU implementer - 0x41. That's A. For ARM Ltd. ARM Ltd implemented this CPU. Did ARM Ltd really

Re: coccinelle and bitmask arithmetic

2013-01-30 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 09:21:28AM +0100, walter harms wrote: Great hit Joe :) Sometimes i am really surprised what code can be found in the kernal and it is still working. Having no clue of the code i suspect somebody tries to check is mask outside the range it should read PHYS_OFFSET |(

Re: coccinelle and bitmask arithmetic

2013-01-30 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 12:21:21PM +0100, Julia Lawall wrote: On Wed, 30 Jan 2013, Russell King - ARM Linux wrote: On Wed, Jan 30, 2013 at 09:21:28AM +0100, walter harms wrote: Great hit Joe :) Sometimes i am really surprised what code can be found in the kernal

Re: [RFC PATCH v3 2/2] ARM: OMAP4: setup SoC model name during ID initialisation

2013-01-30 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 05:01:31PM +0200, Ruslan Bilovol wrote: Set up the SoC model name during OMAP ID initialisation so it will be displayed in /proc/cpuinfo: / # cat proc/cpuinfo [...] CPU variant : 0x2 CPU part: 0xc09 CPU revision: 10 SoC name: OMAP4470

Re: coccinelle and bitmask arithmetic

2013-01-30 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 08:53:29AM -0800, Joe Perches wrote: On Wed, 2013-01-30 at 11:35 +, Russell King - ARM Linux wrote: On Wed, Jan 30, 2013 at 12:21:21PM +0100, Julia Lawall wrote: On Wed, 30 Jan 2013, Russell King - ARM Linux wrote: So, _either_ logical OR or addition works

Re: [RFC PATCH v3 1/2] ARM: kernel: update cpuinfo to print SoC model name

2013-01-30 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 02:07:53PM -0500, Nicolas Pitre wrote: On Wed, 30 Jan 2013, Ruslan Bilovol wrote: Currently, reading /proc/cpuinfo provides userspace with CPU ID of the CPU carrying out the read from the file. Userspace using this information may decide what module to load or

Re: [RFC] arm: use built-in byte swap function

2013-01-31 Thread Russell King - ARM Linux
On Wed, Jan 30, 2013 at 08:09:00PM -0600, Kim Phillips wrote: The savings come mostly from device-tree related code, and some from drivers. You forget that IP networking is all big endian, so these will be using the byte swapping too (search it for htons/ntohs/htonl/ntohl). v2: - at91 and

Re: [RFC] arm: use built-in byte swap function

2013-01-31 Thread Russell King - ARM Linux
On Thu, Jan 31, 2013 at 02:59:47PM -0600, Kim Phillips wrote: On Thu, 31 Jan 2013 09:28:01 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 30, 2013 at 08:09:00PM -0600, Kim Phillips wrote: v2: - at91 and lpd270 builds fixed by limiting to ARMv6 and above

Re: [PATCH v4] arm: use built-in byte swap function

2013-02-01 Thread Russell King - ARM Linux
On Thu, Jan 31, 2013 at 06:37:47PM -0600, Kim Phillips wrote: +#if GCC_VERSION = 40600 +#define __HAVE_BUILTIN_BSWAP32__ +#define __HAVE_BUILTIN_BSWAP64__ You really aren't listening to anything that's been said to you. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] zsmalloc: Fix TLB coherency and build problem

2013-02-01 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 10:00:08AM +0900, Minchan Kim wrote: @@ -663,7 +661,7 @@ static inline void __zs_unmap_object(struct mapping_area *area, flush_cache_vunmap(addr, end); unmap_kernel_range_noflush(addr, PAGE_SIZE * 2); - local_flush_tlb_kernel_range(addr, end); +

Re: [PATCH v4 00/13] ARM LPAE Fixes - Part 1

2013-02-01 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 10:10:37AM -0500, Cyril Chemparathy wrote: With this, I ran simple network and filesystem performance tests to compare the code-patching vs. non-code-patching variants. These tests didn't yield any significant performance difference between the two on an ARMv7

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 10:56:00PM +0200, Felipe Balbi wrote: hi, On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: good point, do you wanna send some patches ? I have already sent them countless times and even stuck CPPI 4.1 support (in arch/arm/common/cppi41.c)

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 04:07:59AM +0400, Sergei Shtylyov wrote: Hello. On 02-02-2013 1:30, Russell King - ARM Linux wrote: On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: good point, do you wanna send some patches ? I have already sent them countless times and even

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 06:09:24AM +0400, Sergei Shtylyov wrote: Hello. On 02-02-2013 4:44, Russell King - ARM Linux wrote: On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: good point, do you wanna send some patches ? I have already sent them countless times and even

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 10:18:51AM +, Russell King - ARM Linux wrote: On Sat, Feb 02, 2013 at 06:09:24AM +0400, Sergei Shtylyov wrote: Hello. On 02-02-2013 4:44, Russell King - ARM Linux wrote: On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: good point, do you

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 01:59:59PM -0500, Matt Porter wrote: On Fri, Feb 01, 2013 at 07:52:46PM +, Sergei Shtylyov wrote: Hello. On 02/01/2013 09:49 PM, Matt Porter wrote: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx) as well. I

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Fri, Feb 01, 2013 at 10:41:08AM -0800, Tony Lindgren wrote: * Matt Porter mpor...@ti.com [130201 10:25]: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx) as well. I think this should rather go to drivers/dma/? Yes, it should, but just like OMAP,

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-02 Thread Russell King - ARM Linux
On Sat, Feb 02, 2013 at 08:27:42PM +0400, Sergei Shtylyov wrote: There are two people on this thread CC list who were also involved or CC'd on the mails from the thread in 2010... Tony and Felipe. Unfortunately, the person who agreed to do the work is no longer in the land of the living. Yes

Re: [PATCH] ARM: vfp: fix fpsid register subarchitecture field mask width

2013-02-26 Thread Russell King - ARM Linux
On Mon, Feb 25, 2013 at 07:01:11PM -0800, Stephen Boyd wrote: On 02/25/13 03:18, Will Deacon wrote: On Fri, Feb 22, 2013 at 11:46:18PM +, Stephen Boyd wrote: On 2/22/2013 10:27 AM, Will Deacon wrote: What value do you have in fpsid? As far as I can tell, the subarchitecture bits 6:0

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-26 Thread Russell King - ARM Linux
On Tue, Feb 26, 2013 at 10:58:02PM +0100, Peter Korsgaard wrote: Nicolas == Nicolas Pitre n...@fluxnic.net writes: Hi, Did you actually *try* the new LZO version and the patch (which is attached once again) as explained in https://lkml.org/lkml/2013/2/3/367 ? Because the new

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-27 Thread Russell King - ARM Linux
On Wed, Feb 27, 2013 at 04:36:47PM +0900, Kyungsik Lee wrote: Compiler: Linaro ARM gcc 4.6.2 2. ARMv7, 1.7GHz based board Kernel: linux 3.7 Uncompressed Kernel Size: 14MB Compressed Size Decompression Speed LZO 6.0MB34.1MB/sOld

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-27 Thread Russell King - ARM Linux
On Tue, Feb 26, 2013 at 05:40:34PM -0800, Joe Perches wrote: On Tue, 2013-02-26 at 22:10 +, Russell King - ARM Linux wrote: So... for a selected kernel version of a particular size, can we please have a comparison between the new LZO code and this LZ4 code, so that we can see whether

Re: [PATCH 0/4] time: dynamic irq affinity

2013-02-27 Thread Russell King - ARM Linux
On Wed, Feb 27, 2013 at 11:30:11AM +0530, Santosh Shilimkar wrote: P.S: Time and again it proves that making the local timer wakeup capable solves the issue. Slightly different take: it proves that hardware people don't talk to software people about what they require to make an operating system

Re: [PATCH] ARM: vfp: fix fpsid register subarchitecture field mask width

2013-02-27 Thread Russell King - ARM Linux
On Tue, Feb 26, 2013 at 05:37:17PM -0800, Stephen Boyd wrote: On 02/25/13 12:02, Russell King - ARM Linux wrote: This can of worms is getting bigger. We have more problems with our handling of the different VFP versions, specifically the handling of the EX=0 DEX=0 case. VFP common

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-27 Thread Russell King - ARM Linux
On Wed, Feb 27, 2013 at 07:49:12AM -0800, Joe Perches wrote: On Wed, 2013-02-27 at 09:56 +, Russell King - ARM Linux wrote: On Tue, Feb 26, 2013 at 05:40:34PM -0800, Joe Perches wrote: On Tue, 2013-02-26 at 22:10 +, Russell King - ARM Linux wrote: So... for a selected kernel

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-27 Thread Russell King - ARM Linux
On Wed, Feb 27, 2013 at 09:04:48AM -0800, Joe Perches wrote: On Wed, 2013-02-27 at 16:31 +, Russell King - ARM Linux wrote: On Wed, Feb 27, 2013 at 07:49:12AM -0800, Joe Perches wrote: On Wed, 2013-02-27 at 09:56 +, Russell King - ARM Linux wrote: On Tue, Feb 26, 2013 at 05:40

Re: [RFC PATCH v2 0/4] Add support for LZ4-compressed kernel

2013-02-27 Thread Russell King - ARM Linux
On Wed, Feb 27, 2013 at 09:39:47AM -0800, Joe Perches wrote: On Wed, 2013-02-27 at 12:16 -0500, Nicolas Pitre wrote: On Wed, 27 Feb 2013, Joe Perches wrote: On Wed, 2013-02-27 at 16:31 +, Russell King - ARM Linux wrote: On Wed, Feb 27, 2013 at 07:49:12AM -0800, Joe Perches wrote

Re: [BUG] panda board locks up on boot

2013-01-25 Thread Russell King - ARM Linux
On Thu, Jan 24, 2013 at 10:01:26PM -0500, Steven Rostedt wrote: I've recently started testing my work on arm boards and have found that they both don't boot under the latest kernel anymore. I already posted about my snowball board, but my panda board also locks up. You need to enable DMA

Re: [PATCH v2] ARM: PL011: Add support for Rx DMA buffer polling

2013-01-25 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 12:25:07PM -0800, Greg Kroah-Hartman wrote: On Wed, Jan 23, 2013 at 02:07:57PM +0900, Chanho Min wrote: On Tue, Jan 22, 2013 at 10:18 PM, Linus Walleij linus.wall...@linaro.org wrote: - If poll timer is activated, We use consistent DMA mappings to avoid from

Re: [PATCH 1/4 v11] arm: use device tree to get smp_twd clock

2013-01-25 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 10:03:05PM +0100, Rafael J. Wysocki wrote: On Friday, January 25, 2013 01:46:42 PM Mark Langsdorf wrote: From: Rob Herring rob.herr...@calxeda.com Move clk setup to twd_local_timer_common_register and rely on twd_timer_rate being 0 to force calibration if there is

Re: [PATCH 11/19] regmap: avoid undefined return from regmap_read_debugfs

2013-01-26 Thread Russell King - ARM Linux
On Sat, Jan 26, 2013 at 05:49:29PM +0800, Mark Brown wrote: Oh, ffs. This is a false positive from the compiler - there is no case where it can actually do this as we will bail out before the walk if the list is empty so we'll always take at least one trip through our list_for_each_entry()

Re: [PATCHv2 00/19] ARM: common warning fixes

2013-01-26 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 10:43:59PM +, Arnd Bergmann wrote: I will get to those once this series is sorted out. Since there are no interdepencies between the patches, my preference is to have them applied by the individual subsystem maintainers. Anything that has not at least made it into

Re: [PATCH 11/19] regmap: avoid undefined return from regmap_read_debugfs

2013-01-26 Thread Russell King - ARM Linux
On Sat, Jan 26, 2013 at 06:03:28PM +0800, Mark Brown wrote: On Sat, Jan 26, 2013 at 09:59:16AM +, Russell King - ARM Linux wrote: Why not code the function in a way that avoids the problem altogether? That'd do the trick too; feel free to submit a patch... Sorry, got other things

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-26 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: On Friday 25 January 2013, Myklebust, Trond wrote: -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Marking it as __maybe_unused avoids a harmless gcc warning. Alternatively, just declare it using

Re: [v3 2/2] ARM: tegra: Skip scu_enable(scu_base) if not Cortex A9

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 09:18:55AM +0200, Hiroshi Doyu wrote: Hi Russell, On Tue, 22 Jan 2013 18:04:46 +0100 Olof Johansson o...@lixom.net wrote: Since Russell had comments on it earlier, I'd like him to give a nod that he's happy with it too. Is this ok for you? The original

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: Hello, Le 28/01/2013 09:45, Peter Ujfalusi a écrit : hi Thierry, On 01/26/2013 06:40 AM, Thierry Reding wrote: +{ + return pwm-chip-can_sleep; +} +EXPORT_SYMBOL_GPL(pwm_cansleep); Would it make sense to check for NULL

Re: [PATCH 2/2] gpio: pca953x: use managed resources

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 11:17:48AM +0100, Linus Walleij wrote: On Fri, Jan 25, 2013 at 5:59 PM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: From: Linus Walleij linus.wall...@linaro.org Using the devm_* managed resources the pca driver can be simplified and cut down on

Re: [PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 10:17:33AM -0500, Alan Stern wrote: On Mon, 28 Jan 2013, Roger Quadros wrote: Make use of devm_request_and_ioremap() and correct comment. Didn't a big patch come through recently converting all usages of devm_request_and_ioremap() to another function (I forget the

Re: Compilation problem with drivers/staging/zsmalloc when !SMP on ARM

2013-01-21 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 11:37:25PM -0500, Konrad Rzeszutek Wilk wrote: On Fri, Jan 18, 2013 at 01:45:27PM -0800, Greg Kroah-Hartman wrote: On Fri, Jan 18, 2013 at 09:08:59PM +, Russell King - ARM Linux wrote: On Fri, Jan 18, 2013 at 02:24:15PM -0600, Matt Sealey wrote: Hello all

Re: [PATCH v2 06/10] spi/pxa2xx: add support for DMA engine

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 11:31:59AM +0200, Mika Westerberg wrote: +bool dma_is_possible(size_t len) +int map_dma_buffers(struct driver_data *drv_data) +irqreturn_t dma_transfer(struct driver_data *drv_data) +int dma_prepare(struct driver_data *drv_data, u32 dma_burst) +void dma_start(struct

Re: [PATCH 02/33] ARM: Convert to devm_ioremap_resource()

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 11:08:55AM +0100, Thierry Reding wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. Does this include the resource part of the handling too? -- To unsubscribe from this

Re: [PATCH v9 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 01:04:46PM +0200, Roger Quadros wrote: Every channel has a functional clock that is similarly named. It makes sense to use a for loop to manage these clocks as OMAPs can come with up to 3 channels. Dynamically allocate and get channel clocks depending on the number

Re: [PATCH 02/33] ARM: Convert to devm_ioremap_resource()

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 05:05:47PM +0100, Thierry Reding wrote: On Mon, Jan 21, 2013 at 03:58:46PM +, Russell King - ARM Linux wrote: On Mon, Jan 21, 2013 at 11:08:55AM +0100, Thierry Reding wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced

Re: Compilation problem with drivers/staging/zsmalloc when !SMP on ARM

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 10:20:38AM -0600, Matt Sealey wrote: See previous mail to Minchan; local_tlb_flush_kernel_range calls cpu_tlb.flush_kernel_range on SMP, but a direct function call (glue(_TLB, flush_kernel_range) which resolves to v7wbi_flush_kernel_range etc. etc.) without CONFIG_SMP.

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 08:41:17PM +, Arnd Bergmann wrote: On Monday 21 January 2013, Matt Sealey wrote: ARM seems to be the only major platform not using the kernel/Kconfig.hz definitions, instead rolling it's own and setting what could be described as both reasonable and

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 01:00:15PM -0800, John Stultz wrote: So if you can not get actual timer ticks any faster then 200 HZ on that hardware, setting HZ higher could cause some jiffies related timer trouble Err, no John. It's the other way around - especially on some platforms which are

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 02:18:20PM -0800, John Stultz wrote: So we used to have the ACTHZ code to handle error from the HZ rate requested and the HZ rate possible given the underlying hardware. That's been moved to the register_refined_jiffies(), but do you have a sense if there a reason

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 10:30:07PM +, Arnd Bergmann wrote: On Monday 21 January 2013, Matt Sealey wrote: So is that a bug in that it is not available to ARM right now, a bug in that it would be impossible for anyone on ARM to have ever tested this code, or a bug in that it should NEVER

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 04:20:14PM -0600, Matt Sealey wrote: I am sorry it sounded if I was being high and mighty about not being able to select my own HZ (or being forced by Exynos to be 200 or by not being able to test an Exynos board, forced to default to 100). My real grievance here is we

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 02:36:13PM -0800, John Stultz wrote: Well, Russell brought up a case that doesn't handle this. If a system *can't* do HZ=100, but can do HZ=200. Though there are hacks, of course, that might get around this (skip every other interrupt at 200HZ). Note: in the early

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 04:54:31PM -0600, Matt Sealey wrote: Hmm, I think it might be appreciated for people looking at this stuff (same as I stumbled into it) for a little comment on WHY the default is 200. That way you don't wonder even if you know why EBSA110 has a HZ=200 default, why

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 05:23:33PM -0600, Matt Sealey wrote: On Mon, Jan 21, 2013 at 4:42 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Jan 21, 2013 at 04:20:14PM -0600, Matt Sealey wrote: I am sorry it sounded if I was being high and mighty about not being able

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 05:30:31PM -0600, Matt Sealey wrote: But it would effectively stop users drinking kool-aid.. if you set your HZ to something stupid, you don't even get a kernel to build, and certainly don't get to boot past the first 40 lines of boot messages.. I think most people

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-21 Thread Russell King - ARM Linux
On Mon, Jan 21, 2013 at 07:06:59PM -0600, Matt Sealey wrote: On Mon, Jan 21, 2013 at 6:51 PM, John Stultz john.stu...@linaro.org wrote: On 01/21/2013 02:54 PM, Matt Sealey wrote: On Mon, Jan 21, 2013 at 4:36 PM, John Stultz john.stu...@linaro.org wrote: On 01/21/2013 01:14 PM, Matt

Re: One of these things (CONFIG_HZ) is not like the others..

2013-01-22 Thread Russell King - ARM Linux
On Tue, Jan 22, 2013 at 03:44:03PM +0530, Santosh Shilimkar wrote: Sorry for not being clear enough. On OMAP, 32KHz is the only clock which is always running(even during low power states) and hence the clock source and clock event have been clocked using 32KHz clock. As mentioned by RMK, with

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-23 Thread Russell King - ARM Linux
On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote: I think I read somewhere at some point that ioread{8,16,32} is preferred over write{b,h,l} in new code. But... there's *no* point using ioread*() if you don't only use the ioremap() interface. ioread*() is there to allow PC IO

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-23 Thread Russell King - ARM Linux
On Wed, Jan 23, 2013 at 11:49:16AM +0100, Lars-Peter Clausen wrote: On 01/23/2013 11:27 AM, Russell King - ARM Linux wrote: On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote: I think I read somewhere at some point that ioread{8,16,32} is preferred over write{b,h,l} in new

Re: [PATCH 05/14] lib: Add I/O map cache implementation

2013-01-16 Thread Russell King - ARM Linux
On Wed, Jan 16, 2013 at 11:18:22AM +0100, Thierry Reding wrote: err = ioremap_page_range(virt, virt + SZ_64K - 1, phys, Why -1 here? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v6 04/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-16 Thread Russell King - ARM Linux
On Wed, Jan 16, 2013 at 04:43:35PM +0200, Roger Quadros wrote: + spin_lock_irqsave(tll-lock, flags); + + for (i = 0; i tll-nch; i++) { + char clkname[] = usb_tll_hs_usb_chx_clk; + struct clk *fck; + + snprintf(clkname, sizeof(clkname), +

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-16 Thread Russell King - ARM Linux
On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote: On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote: Now consider this call stack from MMC block driver (this is on the ARmv7 based board): [ 98.918174] [c001b50c] (v7_dma_inv_range+0x30/0x48) from

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread Russell King - ARM Linux
On Thu, Jan 17, 2013 at 09:11:20AM +, James Bottomley wrote: On Wed, 2013-01-16 at 15:18 -0800, Tejun Heo wrote: On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote: diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index 6b2fb87..ab88c5b 100644 ---

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread Russell King - ARM Linux
On Thu, Jan 17, 2013 at 10:37:42AM +, Russell King - ARM Linux wrote: On Thu, Jan 17, 2013 at 09:11:20AM +, James Bottomley wrote: I'd actually prefer page = pfn_to_page(page_to_pfn(page) + 1); because it makes the code look like the hack it is. The preferred form for all iterators

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread Russell King - ARM Linux
On Thu, Jan 17, 2013 at 11:01:47AM +, James Bottomley wrote: On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote: Also, couldn't the addition of the scatterlist offset to the page also be buggy too? No, fortunately, offset must be within the first page from the point

Re: [PATCH v2 1/1] block: blk-merge: don't merge the pages with non-contiguous descriptors

2013-01-17 Thread Russell King - ARM Linux
On Thu, Jan 17, 2013 at 11:19:21AM +, James Bottomley wrote: On Thu, 2013-01-17 at 11:04 +, Russell King - ARM Linux wrote: On Thu, Jan 17, 2013 at 11:01:47AM +, James Bottomley wrote: On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote: Also, couldn't

Re: [PATCH RFC 2/2] Improve bios32 support for DT PCI host bridge controllers

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 11:40:19AM +, Andrew Murray wrote: static void __init pcibios_init_hw(struct hw_pci *hw, struct list_head *head) { struct pci_sys_data *sys = NULL; + static int busnr; int ret; - int nr, busnr; - - for (nr = busnr = 0; nr

Re: [PATCH v8 05/22] mfd: omap-usb-tll: Clean up clock handling

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 02:17:08PM +0200, Roger Quadros wrote: + tll-ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll-nch]), + GFP_KERNEL); + if (!tll-ch_clk) { + ret = -ENOMEM; + dev_err(dev, Couldn't allocate

Re: [PATCH v8 06/22] mfd: omap-usb-tll: introduce and use mode_needs_tll()

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 02:17:09PM +0200, Roger Quadros wrote: +/* only PHY and UNUSED modes don't need TLL */ +#define omap_usb_mode_needs_tll(x) ((x != OMAP_USBHS_PORT_MODE_UNUSED) \ + (x != OMAP_EHCI_PORT_MODE_PHY)) Growl. These parens do not make

Re: [PATCH v3] drivers/pinctrl: grab default handles from device core

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 04:08:48PM +0100, Linus Walleij wrote: - Abstain from using IS_ERR_OR_NULL() in the driver core, Russell recently sent a patch to remove it. Handle the NULL case explicitly even though it's a bogus case. H... I assume you're talking about this: + p =

Re: Compilation problem with drivers/staging/zsmalloc when !SMP on ARM

2013-01-18 Thread Russell King - ARM Linux
On Fri, Jan 18, 2013 at 02:24:15PM -0600, Matt Sealey wrote: Hello all, I wonder if anyone can shed some light on this linking problem I have right now. If I configure my kernel without SMP support (it is a very lean config for i.MX51 with device tree support only) I hit this error on

Re: [PATCH] driver core: add wait event for deferred probe

2013-02-14 Thread Russell King - ARM Linux
On Thu, Feb 14, 2013 at 09:56:36AM +, Arnd Bergmann wrote: I would put it this way: With the introduction of deferred probing, the rules for the use of __init sections have changed slightly for some corner cases. While normal device drivers can, as before, not call __init functions from

Re: [PATCH] ARM: net: bpf_jit: fix emit_swap16() for non ARMv6+.

2013-02-14 Thread Russell King - ARM Linux
On Thu, Feb 14, 2013 at 02:40:09PM +0100, Nicolas Schichan wrote: On 02/13/2013 10:32 PM, Mircea Gherzan wrote: [...] Acked-by: Mircea Gherzan mgher...@gmail.com Hi, Thanks Mircea. Russel, David, do you have any preference as to which path this patch should take (net tree or ARM tree) ?

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Thu, Feb 14, 2013 at 11:47:50PM +0100, Arnd Bergmann wrote: Patch c08e20d24 arm: Add v7_invalidate_l1 to cache-v7.S moves the v7_invalidate_l1 symbol out of imx/headsmp.S, which seems to cause a link error because it is now too far away from v7_cpu_resume when building an allyesconfig

Re: [PATCH 8/9] [HACK] ARM: imx: work around v7_cpu_resume link error

2013-02-15 Thread Russell King - ARM Linux
On Fri, Feb 15, 2013 at 11:05:14AM +, Arnd Bergmann wrote: $ size obj-tmp/vmlinux -A obj-tmp/vmlinux : section size addr .head.text504 3221258240 .text32707336 3221258752 .text.head 8 3253966088

<    1   2   3   4   5   6   7   8   9   10   >