Re: [PATCH V3 11/11] ARM: delete struct sys_timer

2012-11-26 Thread Stephen Warren
On 11/20/2012 09:43 PM, Haojian Zhuang wrote: > On Tue, Nov 20, 2012 at 2:31 AM, Stephen Warren wrote: >> From: Stephen Warren >> >> Now that the only field in struct sys_timer is .init, delete the struct, >> and replace the machine descriptor .timer field with the

Re: [PATCH V3 10/11] ARM: remove struct sys_timer suspend and resume fields

2012-11-26 Thread Stephen Warren
On 11/21/2012 01:28 AM, Linus Walleij wrote: > Oh and there was this comment/TODO: > > On Mon, Nov 19, 2012 at 7:31 PM, Stephen Warren wrote: > >> @@ -17,15 +17,6 @@ >> * Initialise the kernels jiffy timer source, claim interrupt >> * using setup_irq.

Re: [PATCH 1/1] memory: tegra30: Fix warning w/o PM_SLEEP

2012-11-26 Thread Stephen Warren
On 11/21/2012 05:42 AM, Hiroshi Doyu wrote: > Fix build warning w/o PM_SLEEP. Reviewed-by: Stephen Warren I assume Greg will take this through his tree. > Change-Id: I713f7dd697f1ad9fb1fee56b389b0d6c45bb540c But that shouldn't be there though... -- To unsubscribe from this list: se

Re: [PATCH 1/1] arm: tegra: select correct parent clk for pll_p

2012-11-26 Thread Stephen Warren
On 11/20/2012 12:29 AM, Sivaram Nair wrote: > For Tegra30, pll_p clk's parent is wrongly specified as clk_m instead of > pll_ref in the tegra30_clk_init_table and this is resulting in a > boot-time warning. This patch fixes this by correcting the clk init > table. Thanks, applied. -- To unsubscri

Re: [PATCH 1/1] arm: tegra: fix comment in dsib clk set_parent

2012-11-26 Thread Stephen Warren
On 11/21/2012 04:42 AM, Sivaram Nair wrote: > Since the clk framework has already taken necessary locks before calling > into the arch clk ops code, no further locks are needed while setting > the parent of dsib clk. This patch removes a comment that indicated > otherwise, and yet did not take any

Re: [PATCH 1/1] amba: tegra-ahb: Fix warning w/o PM_SLEEP

2012-11-26 Thread Stephen Warren
On 11/21/2012 05:41 AM, Hiroshi Doyu wrote: > Fix build warning w/o PM_SLEEP. > > Change-Id: Id5b7d089de835025b5708fa345a75990fd976363 Thanks, applied, with commit description fixed up to remove the Change-Id. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH V2] ARM: dt: tegra: cardhu: Add drm components

2012-11-26 Thread Stephen Warren
On 11/20/2012 12:27 AM, Mark Zhang wrote: > This patch adds the rgb node which is needed by > tegra drm driver. This doesn't seem to include all the GPIOs/regulators/... required to enable the panel and backlight. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [RFC v2 5/8] ARM: tegra: Add auxiliary data for nvhost

2012-11-26 Thread Stephen Warren
On 11/26/2012 06:19 AM, Terje Bergstrom wrote: > Add SoC specific auxiliary data to host1x and gr2d. nvhost uses > this data. > > Signed-off-by: Terje Bergstrom > Signed-off-by: Arto Merilainen Arto's S-o-b really should be first and yours last since you're (Terje) the one who touched the patch

Re: [RFC v2 5/8] ARM: tegra: Add auxiliary data for nvhost

2012-11-27 Thread Stephen Warren
On 11/26/2012 11:33 PM, Terje Bergström wrote: > On 27.11.2012 01:39, Stephen Warren wrote: >> Clock names shouldn't be passed in platform data; instead, clk_get() >> should be passed the device object and device-relative (i.e. not global) >> clock name. I expect if t

[PATCH V7 3/7] arm64: use new common dtc rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren The current rules have the .dtb files build in a different directory from the .dts files. This patch changes arm64 to use the generic dtb rule which builds .dtb files in the same directory as the source .dts. This requires moving parts of arch/arm64/boot/Makefile into newly

[PATCH V7 6/7] microblaze: use new common dtc rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren The current rules have the .dtb files build in a different directory from the .dts files. This patch changes microblaze to use the generic dtb rule which builds .dtb files in the same directory as the source .dts. This requires moving parts of arch/microblaze/boot/Makefile

[PATCH V7 5/7] c6x: use new common dtc rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren The current rules have the .dtb files build in a different directory from the .dts files. This patch changes c6x to use the generic dtb rule which builds .dtb files in the same directory as the source .dts. This requires moving parts of arch/c6x/boot/Makefile into newly

[PATCH V7 7/7] xtensa: use new common dtc rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren The current rules have the .dtb files build in a different directory from the .dts files. This patch changes xtensa to use the generic dtb rule which builds .dtb files in the same directory as the source .dts. This requires moving parts of arch/xtensa/boot/Makefile into

[PATCH V7 4/7] openrisc: use new common dtc rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren The current rules have the .dtb files build in a different directory from the .dts files. This patch changes openrisc to use the generic dtb rule which builds .dtb files in the same directory as the source .dts. This requires renaming arch/openrisc/boot/Makefile to arch

[PATCH V7 1/7] kbuild: centralize .dts->.dtb rule

2012-11-27 Thread Stephen Warren
From: Stephen Warren All architectures that use cmd_dtc do so in almost the same way. Create a central build rule to avoid duplication. The one difference is that most current uses of dtc build $(obj)/%.dtb from $(src)/dts/%.dts rather than building the .dtb in the same directory as the .dts

[PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory

2012-11-27 Thread Stephen Warren
.dts. Cc: Russell King Cc: Arnd Bergmann Cc: Olof Johansson Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Grant Likely [swarren: added rm command for old stale .dtb files] Signed-off-by: Stephen Warren --- v7: New patch. --- arch/arm/Makefile |4 ++-- arch/arm/boot

Re: [RFC v2 8/8] drm: tegra: Add gr2d device

2012-11-28 Thread Stephen Warren
On 11/28/2012 07:45 AM, Terje Bergström wrote: > On 28.11.2012 16:06, Lucas Stach wrote: >> Why do even need/use dma-buf for this use case? This is all one DRM >> device, even if we separate host1x and gr2d as implementation modules. > > I didn't want to implement dependency to drm gem objects in

Re: [PATCH 1/1] ARM: tegra: bus_notifier registers IOMMU devices(was: How to specify IOMMU'able devices in DT)

2012-11-28 Thread Stephen Warren
On 11/28/2012 06:48 AM, Hiroshi Doyu wrote: > Hiroshi Doyu wrote @ Mon, 24 Sep 2012 14:50:14 +0300 > (EEST): > ... > On Mon, 2012-09-24 at 12:04 +0300, Hiroshi Doyu wrote: >> diff --git a/drivers/base/platform.c b/drivers/base/platform.c >> index a1a7225..9eae3be 100644 >> --- a/d

Re: [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule

2012-11-28 Thread Stephen Warren
On 11/27/2012 04:29 PM, Stephen Warren wrote: > All architectures that use cmd_dtc do so in almost the same way. Create > a central build rule to avoid duplication. The one difference is that > most current uses of dtc build $(obj)/%.dtb from $(src)/dts/%.dts rather > than building the

Re: [PATCH v2] drm: tegra: Add maintainers entry

2012-11-28 Thread Stephen Warren
On 11/28/2012 12:18 PM, Thierry Reding wrote: > Add myself as the maintainer of the NVIDIA Tegra DRM driver. Aside from one comment below, Acked-by: Stephen Warren > +L: dri-de...@lists.freedesktop.org Should linux-te...@vger.kernel.org also be CC'd so that everything Tegra-rela

Re: [PATCH 2/2] ARM: tegra: moving stuff away from mach/clk.h

2012-11-29 Thread Stephen Warren
On 11/28/2012 11:12 PM, Prashant Gaikwad wrote: > On Tuesday 27 November 2012 12:29 PM, Sivaram Nair wrote: >> This patch moves some stuff away from mach/clk.h to other mach-tegra >> files. This is part of the efforts to get rid of mach/clk.h which in >> turn will help to enable single zImage. >> >

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-11-29 Thread Stephen Warren
On 11/29/2012 03:21 AM, Terje Bergström wrote: > On 28.11.2012 23:23, Thierry Reding wrote: ... >>> + regs = platform_get_resource(dev, IORESOURCE_MEM, 0); >>> + intr0 = platform_get_resource(dev, IORESOURCE_IRQ, 0); >>> + intr1 = platform_get_resource(dev, IORESOURCE_IRQ, 1); >>> + >>>

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-11-29 Thread Stephen Warren
On 11/29/2012 04:47 AM, Thierry Reding wrote: > On Thu, Nov 29, 2012 at 12:21:04PM +0200, Terje Bergström wrote: >> On 28.11.2012 23:23, Thierry Reding wrote: >>> This could be problematic. Since drivers/video and >>> drivers/gpu/drm are separate trees, this would entail a >>> continuous burden on

Re: [RFC v2 2/8] video: tegra: Add syncpoint wait and interrupts

2012-11-29 Thread Stephen Warren
On 11/29/2012 01:44 AM, Thierry Reding wrote: > On Mon, Nov 26, 2012 at 03:19:08PM +0200, Terje Bergstrom wrote: >> diff --git a/drivers/video/tegra/host/host1x/host1x_intr.c >> b/drivers/video/tegra/host/host1x/host1x_intr.c > [...] >> +/* Spacing between sync registers */ +#define REGISTER_STRID

Re: linux-next: manual merge of the bcm2835 tree with the arm-soc tree

2013-03-18 Thread Stephen Warren
On 03/17/2013 10:04 PM, Stephen Rothwell wrote: > Hi Stephen, > > Today's linux-next merge of the bcm2835 tree got a conflict in > arch/arm/Kconfig between commit 15bc1fe67f66 ("ARM: cns3xxx: > enable multiplatform support") from the arm-soc tree and commit > f1ac922dec7e ("ARM: bcm2835: convert

Re: linux-next: manual merge of the tegra tree with the arm-soc tree

2013-03-18 Thread Stephen Warren
On 03/17/2013 10:31 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tegra tree got a conflict in > drivers/clocksource/tegra20_timer.c between commit 1d16cfb3aeba > ("clocksource: tegra20: use the device_node pointer passed to > init") from the arm-soc tree and commit 6

Re: [PATCH 1/7] kbuild: create an "include chroot" for DT bindings

2013-03-18 Thread Stephen Warren
On 03/18/2013 09:13 AM, Shawn Guo wrote: > On Wed, Mar 06, 2013 at 11:22:57AM -0700, Stephen Warren wrote: >> From: Stephen Warren >> >> The recent dtc+cpp support allows header files and C pre-processor >> defines/macros to be used when compiling device tree f

Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-18 Thread Stephen Warren
On 03/03/2013 06:14 PM, Mark Brown wrote: > Currently the value parsing operations both return the parsed value and > modify the passed buffer. This precludes their use in places like the cache > code so split out the in place modification into a new parse_inplace() > operation. Mark, This change

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Stephen Warren
On 03/19/2013 02:58 AM, Laxman Dewangan wrote: > Palmas device have three different i2c addresses. The device creates > the two new dummy i2c clients for accessing the register by using > primary client adapter. This new dummy i2c client have their of_node > as NULL. > > The dummy i2c client is us

Re: [PATCH] mfd: palmas: initialise client->of_node for dummy created client

2013-03-19 Thread Stephen Warren
On 03/19/2013 10:52 AM, Mark Brown wrote: > On Tue, Mar 19, 2013 at 09:44:24AM -0600, Stephen Warren wrote: > >> It seems like part of the solution here is to modify the >> i2c_client object itself so that it can directly support devices >> that have multiple I2C

Re: [PATCH] Doc: dt: i2c: tegra: add dt binding for i2c-tegra

2013-03-19 Thread Stephen Warren
On 03/18/2013 03:35 AM, Laxman Dewangan wrote: > Add documentation for device tree binding of NVIDIA's Tegra i2c > controller driver. > > Describing all compatible values used for diffenent Tegra SoCs > in details in this documentation. I have applied this to Tegra's for-3.10/dt branch. I fixed a

Re: [PATCH v2] ARM: tegra114: add speedo-based process identification

2013-03-19 Thread Stephen Warren
On 03/18/2013 05:17 AM, Danny Huang wrote: > Add speedo-based process identifictaion for Tegra114. I have applied this to Tegra's for-3.10/soc branch, with one addition below: > diff --git a/arch/arm/mach-tegra/tegra114_speedo.c > b/arch/arm/mach-tegra/tegra114_speedo.c > +#include Here, I al

Re: [ 12/75] USB: EHCI: work around silicon bug in Intels EHCI controllers

2013-03-19 Thread Stephen Warren
On 03/18/2013 03:06 PM, Greg Kroah-Hartman wrote: > 3.8-stable review patch. If anyone has any objections, please let me know. This patch causes reboot/shutdown to fail on Tegra-based systems in 3.9-rc3. I reported this at: http://www.spinics.net/lists/linux-usb/msg82518.html although there's

Re: [PATCH] ARM: tegra: fuse: add fuctions to read speedo id and process id

2013-03-19 Thread Stephen Warren
On 03/18/2013 08:33 PM, Danny Huang wrote: > Add functions to read the speedo and process id of both cpu and soc. > There might be some drivers need the information as well. What code wants to use these functions? It'd be best to submit this patch with that code, so that something actually uses th

Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. Patches 6 and 7 each fail checkpatch with "WARNING: line over 80 characters". -- To unsubscribe from this list: send the li

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > As part of this series, apart from patch containing changes to register TEGRA > USB PHY driver as platform driver, prepared below patches: > 1. Re-arranging & adding new DT properties. > 2. Getting various params from DT properties added. > 3. code c

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > This patch updates all Tegra board files so that they contain all the > properties required by the updated USB DT binding. Note that this patch > only adds the new properties and does not yet remove the old properties, > in order to maintain bisectab

Re: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Added a new PHY mode to support OTG. > Obtained Tegra USB PHY mode using DT property. > diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c > @@ -713,6 +712,16 @@ struct tegra_usb_phy *tegra_usb_phy_open(struct device >

Re: [PATCH 5/7] usb: phy: tegra: get ULPI reset GPIO info using DT.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > As GPIO information is avail through DT, used it to get Tegra ULPI > reset GPIO number. Added a new member to tegra_usb_phy structure to > store this number. > diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c > - g

Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up.

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly. > Remove clk_disable_unprepare which is no more needed. The call to clk_disable_unprepare is incorrect in the current code. The way you worded that, it sounds like it's no longer

Re: [PATCH 7/7] usb: phy: registering tegra USB PHY as platform driver

2013-03-19 Thread Stephen Warren
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Registered tegra USB PHY as a separate platform driver. > > To synchronize host controller and PHY initialization, used deferred > probe mechanism. As PHY should be initialized before EHCI starts running, > deferred probe of Tegra EHCI driver till P

Re: [PATCH] clk: add table lookup to mux

2013-03-19 Thread Stephen Warren
On 03/19/2013 03:33 PM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-03-12 11:42:23) >> Add a table lookup feature to the mux clock. Also allow arbitrary masks >> instead of the width. This will be used by some clocks on Tegra114. Also >> adapt the tegra periph clk because it uses struc

Re: [PATCH] clk: add table lookup to mux

2013-03-19 Thread Stephen Warren
On 03/19/2013 03:37 PM, Mike Turquette wrote: > Quoting Stephen Warren (2013-03-12 11:53:46) >> On 03/12/2013 12:42 PM, Peter De Schrijver wrote: >>> Add a table lookup feature to the mux clock. Also allow arbitrary masks >>> instead of the width. This will be used by so

Re: [Regression] process hangs due to "USB: EHCI: work around silicon bug in Intels EHCI controllers"

2013-03-19 Thread Stephen Warren
On 03/19/2013 06:03 PM, Andreas Bombe wrote: > The named commit (6402c796d3) causes a process to hang indefinitely in > usb_kill_urb(). Reverting it fixes the problem. The bug also prevents > suspend/shutdown/reboot from completing, presumably due to the hanging > process. > &g

Re: [PATCH v2] ARM: tegra114: add speedo-based process identification

2013-03-19 Thread Stephen Warren
On 03/19/2013 07:42 PM, Danny Huang wrote: > On Wed, 2013-03-20 at 01:54 +0800, Stephen Warren wrote: >> On 03/18/2013 05:17 AM, Danny Huang wrote: >>> Add speedo-based process identifictaion for Tegra114. >> >> I have applied this to Tegra's for-3.10/

Re: [PATCH] ARM: tegra: fuse: add fuctions to read speedo id and process id

2013-03-19 Thread Stephen Warren
On 03/19/2013 07:39 PM, Danny Huang wrote: > On Wed, 2013-03-20 at 02:05 +0800, Stephen Warren wrote: >> On 03/18/2013 08:33 PM, Danny Huang wrote: >>> Add functions to read the speedo and process id of both cpu and soc. >>> There might be some drivers need the informati

Re: [PATCH 2/2] regulator: palmas: add input supply names

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:54 AM, Laxman Dewangan wrote: > On Wednesday 20 March 2013 06:01 PM, Mark Brown wrote: >> * PGP Signed by an unknown key >> >> On Mon, Mar 18, 2013 at 02:59:48PM +0530, Laxman Dewangan wrote: >> >> There's something odd about several recent patch serieses you've posted, >> they end

Re: [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX

2013-03-20 Thread Stephen Warren
On 03/20/2013 05:31 AM, Richard Genoud wrote: > If pin_free is called on a pin already freed, mux_usecount is set to > UINT_MAX which is really a bad idea. > This will silently ignore a double call to pin_free Shouldn't we WARN_ON(this case)? > diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinc

Re: [PATCH] BUG: [RFC] pinctrl: pins are freed 2 times in pinctrl_bind_pins

2013-03-20 Thread Stephen Warren
On 03/20/2013 05:31 AM, Richard Genoud wrote: > If the function pinctrl_select_state() fails because one pin is already > taken elsewhere, pinmux_enable_setting makes all the necessary pin_free > calls (and not more than necessary). > The problem here is that devm_pinctrl_put() will be called on th

Re: [PATCH 2/2] regulator: palmas: add input supply names

2013-03-20 Thread Stephen Warren
On 03/20/2013 10:38 AM, Mark Brown wrote: > On Wed, Mar 20, 2013 at 10:07:17AM -0600, Stephen Warren wrote: >> On 03/20/2013 06:54 AM, Laxman Dewangan wrote: > >>> I generally send a patches on single git-send command git >>> send-emal --to=ldewan...@nvidia.com 000

Re: [PATCH 2/2] regulator: palmas: add input supply names

2013-03-20 Thread Stephen Warren
On 03/20/2013 10:52 AM, Mark Brown wrote: > On Wed, Mar 20, 2013 at 10:42:26AM -0600, Stephen Warren wrote: >> On 03/20/2013 10:38 AM, Mark Brown wrote: >>> On Wed, Mar 20, 2013 at 10:07:17AM -0600, Stephen Warren >>> wrote: >>>> On 03/20/2013 06:54 AM, Laxm

Re: [PATCH] BUG: pinmux: forbid mux_usecount to be set at UINT_MAX

2013-03-20 Thread Stephen Warren
On 03/20/2013 10:59 AM, Richard Genoud wrote: > 2013/3/20 Stephen Warren : >> On 03/20/2013 05:31 AM, Richard Genoud wrote: >>> If pin_free is called on a pin already freed, mux_usecount is set to >>> UINT_MAX which is really a bad idea. >>> This will silen

Re: [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:15 AM, Venu Byravarasu wrote: >> -Original Message- >> From: kishon [mailto:kis...@ti.com] >> Sent: Wednesday, March 20, 2013 4:49 PM >> To: Venu Byravarasu >> Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; >> ba...@ti.com; linux-...@vger.kernel.org; linux-kerne

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-20 Thread Stephen Warren
On 03/20/2013 05:23 AM, kishon wrote: > Hi, > > On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote: >> This patch updates all Tegra board files so that they contain all the >> properties required by the updated USB DT binding. Note that this patch >> only adds the new properties and does not

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:12 AM, Venu Byravarasu wrote: >> -Original Message- >> From: Venu Byravarasu >> Sent: Wednesday, March 20, 2013 11:30 AM >> To: 'Stephen Warren' >> Cc: gre...@linuxfoundation.org; st...@rowland.harvard.edu; >> ba...@t

Re: [PATCH 7/7] usb: phy: registering tegra USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 06:43 AM, Venu Byravarasu wrote: > Stephen Warren wrote at Wednesday, March 20, 2013 1:51 AM: >> On 03/18/2013 06:29 AM, Venu Byravarasu wrote: >>> Registered tegra USB PHY as a separate platform driver. >>> diff --git a/drivers/usb/phy/tegra_usb_p

Re: [PATCH 0/7] USB: PHY: Tegra: registering TEGRA USB PHY as platform driver

2013-03-20 Thread Stephen Warren
On 03/20/2013 11:36 AM, Stephen Warren wrote: > On 03/20/2013 06:12 AM, Venu Byravarasu wrote: >> Venu Byravarasu wrote at Wednesday, March 20, 2013 11:30 AM: >>> Stephen Warren wrote at Wednesday, March 20, 2013 1:22 AM: >>>> On 03/18/2013 06:29 AM, Venu Byravaras

Re: [PATCH 3/4] ARM: tegra: dalmore: add dt node for TPS65090's regulators

2013-03-20 Thread Stephen Warren
On 03/20/2013 07:44 AM, Laxman Dewangan wrote: > NVIDIA's Tegra114 platform, Dalmore, uses the TPS65090 as > secondary PMICs which mainly act as voltage switch controlled > by I2C communication. > diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts > b/arch/arm/boot/dts/tegra114-dalmore.dts > @@

Re: [PATCH 1/4] ARM: tegra: enable Tegra114 based platform PMICs

2013-03-20 Thread Stephen Warren
On 03/20/2013 07:44 AM, Laxman Dewangan wrote: > NVIDIA's Tegra114 have two reference platform, Dalmore and Pluto. > Dalmore uses the following PMICs: > - TPS65913 as primary PMIC. > - TPS65090 as secondary PMIC used for switch regulators and battery charging. > - TPS51632 for cpu regulator. > > P

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-20 Thread Stephen Warren
On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: > Updated the usb_otg_hs dt data to include the *phy* and *phy-names* > binding in order for the driver to use the new generic PHY framework. > Also updated the Documentation to include the binding information. > diff --git a/Documentation/devi

Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-20 Thread Stephen Warren
On 03/19/2013 10:50 AM, Mark Brown wrote: > On Mon, Mar 18, 2013 at 05:41:49PM -0600, Stephen Warren wrote: > >> It took a very quick look at the patch and couldn't see anything >> actively wrong. I wonder if one of the existing unconverted users >> of .parse

Re: [PATCH 1/2] regmap: core: Split out in place value parsing

2013-03-20 Thread Stephen Warren
On 03/20/2013 04:19 PM, Stephen Warren wrote: > On 03/19/2013 10:50 AM, Mark Brown wrote: >> On Mon, Mar 18, 2013 at 05:41:49PM -0600, Stephen Warren wrote: >> >>> It took a very quick look at the patch and couldn't see anything >>> actively wrong. I won

[PATCH] regmap: don't corrupt work buffer in _regmap_raw_write()

2013-03-20 Thread Stephen Warren
From: Stephen Warren _regmap_raw_write() contains code to call regcache_write() to write values to the cache. That code calls memcpy() to copy the value data to the start of the work_buf. However, at least when _regmap_raw_write() is called from _regmap_bus_raw_write(), the value data is in the

[PATCH] regmap: include linux/sched.h to fix build

2013-02-02 Thread Stephen Warren
From: Stephen Warren This fixes: drivers/base/regmap/regmap.c: In function 'regmap_async_complete_cb': drivers/base/regmap/regmap.c:1656:3: error: 'TASK_NORMAL' undeclared (first use in this function) drivers/base/regmap/regmap.c:1656:3: note: each undeclared identifier is

Re: [PATCH 1/3] cpufreq: TEGRA: Set policy->cpus from driver->init()

2013-02-04 Thread Stephen Warren
ls only ->related_cpus and not ->cpus, which looks to > be > incorrect. Lets fix it. Joseph Lo reviewed/tested this and it looks fine, so, Acked-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: CPU hotplug hang due to "swap: make each swap partition have one address_space"

2013-02-04 Thread Stephen Warren
On 02/03/2013 07:36 PM, Shaohua Li wrote: > On Fri, Feb 01, 2013 at 10:02:33PM -0700, Stephen Warren wrote: >> Shaohua, >> >> In next-20130128, commit 174f064 "swap: make each swap partition have >> one address_space" (from the mm/akpm tree) appears cause

Re: [PATCH 1/2] ARM: tegra: Fix build error for gic update

2013-02-04 Thread Stephen Warren
On 02/04/2013 04:08 AM, Hiroshi Doyu wrote: > Fix build error in board-dt-tegra114.c(next-20130204) Hiroshi, which tree should this patch be applied to? I assume it needs to go through arm-soc since that's where the Tegra and GIC patches meet? -- To unsubscribe from this list: send the line "unsub

Re: [PATCHv5,RESEND 7/8] ARM: tegra: Add board data and 2D clocks

2013-02-04 Thread Stephen Warren
On 02/04/2013 04:26 AM, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 01:44:03PM +0200, Terje Bergstrom wrote: >> Add a driver alias gr2d for Tegra 2D device, and assign a >> duplicate of 2D clock to that driver alias. >> >> Signed-off-by: Terje Bergstrom --- >> arch/arm/mach-tegra/board-dt-te

Re: next-20130204 - bisected slab problem to "slab: Common constants for kmalloc boundaries"

2013-02-04 Thread Stephen Warren
On 02/04/2013 09:22 AM, James Hogan wrote: > Hi, > > I've hit boot problems in next-20130204 on Meta: > > META213-Thread0 DSP [LogF] kobject (4fc03980): tried to init an initialized > object, something is seriously wrong. > META213-Thread0 DSP [LogF] > META213-Thread0 DSP [LogF] Call trace: >

Re: CPU hotplug hang due to "swap: make each swap partition have one address_space"

2013-02-04 Thread Stephen Warren
On 02/04/2013 09:57 AM, Stephen Warren wrote: > On 02/03/2013 07:36 PM, Shaohua Li wrote: >> On Fri, Feb 01, 2013 at 10:02:33PM -0700, Stephen Warren wrote: >>> Shaohua, >>> >>> In next-20130128, commit 174f064 "swap: make each swap partition have >

Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114

2013-02-04 Thread Stephen Warren
On 02/04/2013 03:45 AM, Peter De Schrijver wrote: > On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote: >>> + /* xusb_hs_src */ >>> + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC); >>> + val |= BIT(25); /* always select PLLU_60M */ >>> + writel(val, clk_base

Re: [PATCH v5 07/10] ARM: tegra: Define Tegra114 CAR binding

2013-02-04 Thread Stephen Warren
On 02/01/2013 03:18 AM, Peter De Schrijver wrote: > The device tree binding models Tegra114 CAR (Clock And Reset) as a single > monolithic clock provider. ... > +- #clock-cells : Should be 1. > + In clock consumers, this cell represents the clock ID exposed by the CAR. ... > + 222pll_u >

Re: [PATCH v5 01/10] clk: tegra: Refactor PLL programming code

2013-02-04 Thread Stephen Warren
by: Stephen Warren Also, I briefly reviewed the code and aside from comments that have already been made, so the series, Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] clocksource: tegra: move to of_clk_get

2013-02-04 Thread Stephen Warren
On 02/04/2013 06:40 AM, Peter De Schrijver wrote: > The new clockframework introduced DT IDs for each clock. To be able to remove > the device registrations, this driver needs to be updated to use the DT IDs. > Note that the actual removal of the clk_register_clkdev() calls will be done > in a late

Re: next-20130204 - bisected slab problem to "slab: Common constants for kmalloc boundaries"

2013-02-05 Thread Stephen Warren
with higher alignment > requirements. > > Determine KMALLOC_SHIFT_LOW from ARCH_DMA_MINALIGN instead. Tested-by: Stephen Warren > +/* > + * Some archs want to perform DMA into kmalloc caches and need a guaranteed > + * alignment larger than the alignment of a 64-bit integer. > + * Set

[PATCH V8] kbuild: create a rule to run the pre-processor on *.dts files

2013-02-05 Thread Stephen Warren
From: Stephen Warren Create cmd_dtc_cpp to run the C pre-processor on *.dts file before passing them to dtc for final compilation. This allows the use of #define and #include within the .dts file. Acked-by: Simon Glass Acked-by: Jean-Christophe PLAGNIOL-VILLARD Acked-by: Michal Marek Acked

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
n 02/05/2013 04:42 PM, Sean Paul wrote: > Use the compatible string in the device tree to determine which > registers/functions to use in the HDMI driver. Also changes the > references from v13 to 4210 and v14 to 4212 to reflect the IP > block version instead of the HDMI version. > diff --git a/Do

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
On 02/05/2013 05:37 PM, Sean Paul wrote: > On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren wrote: >> n 02/05/2013 04:42 PM, Sean Paul wrote: >>> Use the compatible string in the device tree to determine which >>> registers/functions to use in the HDMI driver. Also chan

Re: [PATCH v3 1/3] drm/exynos: Get HDMI version from device tree

2013-02-05 Thread Stephen Warren
On 02/05/2013 05:56 PM, Sean Paul wrote: > On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren wrote: >> On 02/05/2013 05:37 PM, Sean Paul wrote: >>> On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren >>> wrote: >>>> n 02/05/2013 04:42 PM, Sean Paul wrote: >&g

Re: [PATCH] clk: tegra: initialise parent of uart clocks

2013-02-06 Thread Stephen Warren
On 02/06/2013 05:22 AM, Peter De Schrijver wrote: > On Wed, Feb 06, 2013 at 11:47:41AM +0100, Laxman Dewangan wrote: >> Initialise the parent of UARTs to PLLP and disabling clock by >> default. >> > > I wonder if we should move the parent definitions to DT at some point. I think that's what Prash

Re: [PATCH] clk: tegra: initialise parent of uart clocks

2013-02-06 Thread Stephen Warren
On 02/06/2013 03:47 AM, Laxman Dewangan wrote: > Initialise the parent of UARTs to PLLP OK > and disabling clock by default. Hmm. Only the clocks initialized by the new entries you added are marked disabled (or rather, not actively enabled; if they're enabled already, they won't be disabled). We

Re: [PATCH 1/1] ARM: tegra: Fix build error w/ ARCH_TEGRA_114_SOC w/o ARCH_TEGRA_3x_SOC

2013-02-06 Thread Stephen Warren
On 02/06/2013 09:10 AM, Hiroshi Doyu wrote: > This patch fixes the build error when ARCH_TEGRA_114_SOC is enabled > and ARCH_TEGRA_3x_SOC is disabled. > > This provides Tegra114 with its own tegra114_init_early() instead of > making use of tegra30_init_early() so that T114 build doesn't depend > o

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread Stephen Warren
On 02/06/2013 06:00 AM, Haojian Zhuang wrote: > On Wed, Feb 6, 2013 at 8:43 PM, wrote: >> On 2013년 02월 06일 20:42, Venu Byravarasu wrote: >>> By definition, leap year is one, which is a divisible by 4 & 400, excluding >>> multiples of 100s. >>> Hence I feel this patch is not correct. >> >> No, I

Re: [PATCH 1/1] memory: tegra_ahb_enable_smmu() depends on TEGRA_IOMMU_SMMU

2013-02-06 Thread Stephen Warren
ich this patch fixes. > > CONFIG_ARCH_TEGRA_2x_SOC=y > \# CONFIG_ARCH_TEGRA_3x_SOC is not set > CONFIG_ARCH_TEGRA_114_SOC=y > > drivers/iommu/tegra-smmu.c:485: undefined reference to 'tegra_ahb_enable_smmu' Tested-by: Stephen Warren Russell, I assume Hiroshi should upload

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-06 Thread Stephen Warren
On 01/14/2013 10:05 AM, Mark Rutland wrote: > Implement timer_broadcast for the arm architecture, allowing for the use > of clock_event_device_drivers decoupled from the timer tick broadcast > mechanism. Mark, this patch is now in next-20130206 and causes a crash during boot on Tegra. The reason a

Re: [PATCH 02/14] mfd: ab8500: provide a irq_set_type() function

2013-02-06 Thread Stephen Warren
On 02/05/2013 12:48 PM, Linus Walleij wrote: > From: Lee Jones > > In the AB8500 IRQ mask and unmask functions, we rely on testing for > IRQ_TYPE_EDGE_RISING and IRQ_TYPE_EDGE_FALLING interrupts to > physically mask and unmask the correct interrupt lines. In order > for us to do that, the trigger

Re: [PATCH 03/14] mfd: ab8500: ensure new AB8500 pinctrl driver is probed correctly

2013-02-06 Thread Stephen Warren
On 02/05/2013 12:48 PM, Linus Walleij wrote: > From: Lee Jones > > The old, BROKEN AB8500 GPIO driver has been revamped as a shiny > new pinctrl driver and has been renamed as such. So, if we would > like to make use of it, we need to register it via its new name. > diff --git a/drivers/mfd/ab85

Re: [PATCH 09/14] pinctrl/abx500: use direct IRQ defines

2013-02-06 Thread Stephen Warren
On 02/05/2013 12:48 PM, Linus Walleij wrote: > From: Linus Walleij > > Make it harder to do mistakes by introducing the actual > defined ABx500 IRQ number into the IRQ cluster definitions. > Deduct cluster offset from the GPIO offset to make each > cluster coherent. Shouldn't this patch be squas

Re: [PATCH 13/14] ARM: ux500: enable AB8500 GPIO for HREF

2013-02-06 Thread Stephen Warren
On 02/05/2013 12:48 PM, Linus Walleij wrote: > From: Lee Jones > > The AB8500 GPIO driver has been un-BROKEN and rewritten as a pinctrl > driver. Now that it's back in use, let's ensure that it's available > when booting HREF with Device Tree enabled. > diff --git a/arch/arm/boot/dts/hrefprev60.

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Stephen Warren
On 02/07/2013 03:04 AM, Mark Rutland wrote: > Hi Stephen, > > Sorry about this; I'm to blame for the bug. > > On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wrote: >> On 01/14/2013 10:05 AM, Mark Rutland wrote: >>> Implement timer_broadcast for the

Re: [PATCHv3 4/4] arm: Add generic timer broadcast support

2013-02-07 Thread Stephen Warren
On 02/07/2013 04:40 AM, Santosh Shilimkar wrote: > Mark, > > On Thursday 07 February 2013 03:34 PM, Mark Rutland wrote: >> Hi Stephen, >> >> Sorry about this; I'm to blame for the bug. >> >> On Wed, Feb 06, 2013 at 08:51:43PM +, Stephen Warren wro

Re: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy directory

2013-02-07 Thread Stephen Warren
On 02/07/2013 06:38 AM, kishon wrote: > On Thursday 07 February 2013 05:02 PM, Venu Byravarasu wrote: >> As drivers/usb/otg/otg.c contains most of the PHY related APIs which >> are not OTG specific, moving them to more logical place under >> drivers/usb/phy. >> diff --git a/drivers/usb/phy/Makefil

Re: [PATCH 09/14] pinctrl/abx500: use direct IRQ defines

2013-02-07 Thread Stephen Warren
t; > (not to say there is one, but just in case.) > > Sent from my mobile Linux device. > > On Feb 7, 2013 12:14 AM, "Stephen Warren" <mailto:swar...@wwwdotorg.org>> wrote: > > On 02/05/2013 12:48 PM, Linus Walleij wrote: > > From

Re: [PATCH 09/10] USB: EHCI: make ehci-msm a separate driver

2013-02-07 Thread Stephen Warren
On 02/07/2013 10:34 AM, manjunath.gou...@linaro.org wrote: > Separate the Qualcomm On-Chip host controller driver from ehci-hcd host code > into its own driver module. > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > @@ -209,7 +210,7 @@ config USB_EHCI_TEGRA > boolean

Re: [PATCH] clk: tegra: Implement locking for super clock

2013-02-07 Thread Stephen Warren
On 02/07/2013 11:57 AM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-02-07 08:24:14) >> Although tegra_clk_register_super_mux() has a lock parameter, the lock is not >> actually used by the code. Fixed with this patch. >> >> Signed-off-by: Peter De Schrijver >> --- >> drivers/clk/tegr

Re: [PATCH] clk: tegra: local arrays should be static

2013-02-07 Thread Stephen Warren
On 02/07/2013 10:49 AM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-02-07 08:30:36) >> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from >> within >> clk-tegra30.c. Declare them static to avoid namespace polution. >> >> Signed-off-by: Peter De Schrijver > > Ack

Re: [PATCH] clk: tegra: Add missing spinlock for hclk and pclk

2013-02-07 Thread Stephen Warren
On 02/07/2013 10:49 AM, Mike Turquette wrote: > Quoting Peter De Schrijver (2013-02-07 08:37:35) >> The hclk and pclk clocks are controlled by the same register. Hence a lock is >> required to avoid corruption. >> >> Signed-off-by: Peter De Schrijver > > I assume this is going through the tegra t

Re: [PATCH 4/4] clocksource: tegra20: use the device_node pointer passed to init

2013-02-07 Thread Stephen Warren
On 02/07/2013 12:09 PM, Rob Herring wrote: > From: Rob Herring > > We've already matched the node, so use the node pointer passed in. The rtc > init was intermingled with the timer init, so split this out to a separate > init function. The series, Reviewed-by: Stephen

Re: [PATCH 09/14] pinctrl/abx500: use direct IRQ defines

2013-02-08 Thread Stephen Warren
On 02/08/2013 01:25 AM, Lee Jones wrote: > On Thu, 07 Feb 2013, Stephen Warren wrote: > >> On 02/07/2013 02:01 AM, Lee Jones wrote: >>> I don't see myself on cc. Was that intentional? >> >> The original patch was that way; I assume git send-email only

Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()

2013-02-08 Thread Stephen Warren
On 02/08/2013 05:29 AM, Marc Dietrich wrote: > Hiroshi, > > Am Freitag, 8. Februar 2013, 09:29:31 schrieb Hiroshi Doyu: >> Refactored tegra{20,30,114}_init_early() so that we have the unified >> tegra_init_early(). >> diff --git a/arch/arm/mach-tegra/hotplug.c b/arch/arm/mach-tegra/hotplug.c >>

  1   2   3   4   5   6   7   8   9   10   >