[PATCH] perf: x86 filter_events() - use hw event id ?

2012-10-31 Thread Sukadev Bhattiprolu
From c3b53a5733fdea35807f4513255bca05e3aee5c5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 30 Oct 2012 23:05:05 -0700 Subject: [PATCH] perf: x86 filter_events() - use hw event id ? The -event_map() operation expects to index through the _hardware event

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-31 Thread Sukadev Bhattiprolu
Peter Zijlstra [pet...@infradead.org] wrote: | On Tue, 2012-10-16 at 11:31 -0700, Sukadev Bhattiprolu wrote: | On a side note, how does the kernel on x86 use the 'config' information in | say /sys/bus/event_source/devices/cpu/format/cccr ? On Power7, the raw | code encodes the information

[PATCH] perf: powerpc: Use uapi/unistd.h to fix build error

2012-11-02 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 31 Oct 2012 11:21:28 -0700 Subject: [PATCH] perf: powerpc: Use uapi/unistd.h to fix build error Use the 'unistd.h' from arch/powerpc/include/uapi to build the perf tool. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com

[PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error

2012-11-07 Thread Sukadev Bhattiprolu
From b8beef080260c1625c8f801105504a82005295e5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 31 Oct 2012 11:21:28 -0700 Subject: [PATCH 1/4] perf/powerpc: Use uapi/unistd.h to fix build error Use the 'unistd.h' from arch/powerpc/include/uapi to build

[PATCH 2/4] perf/Power7: Use macros to identify perf events

2012-11-07 Thread Sukadev Bhattiprolu
From 8a0dbd8f3fce2834292efa50c15ca64d4f6a6536 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Wed, 7 Nov 2012 09:36:14 -0800 Subject: [PATCH 2/4] perf/Power7: Use macros to identify perf events Define and use macros to identify perf events codes This would

[PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-07 Thread Sukadev Bhattiprolu
From d05d1ce6d55bf339eee6230ded9f5dd1351f60e5 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 6 Nov 2012 14:07:36 -0800 Subject: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs Make the perf events supported by POWER7 available via

[PATCH 4/4] perf: Create a sysfs entry for Power event format

2012-11-07 Thread Sukadev Bhattiprolu
From bafc551c31ce23c1cba0b75d23de6c46aba90f26 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 6 Nov 2012 16:30:28 -0800 Subject: [PATCH 4/4] perf: Create a sysfs entry for Power event format Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format

perf: POWER-event translation questions

2012-11-07 Thread Sukadev Bhattiprolu
Looking for feedback on this prototype for making POWER-specific event translations available in sysfs. It is based on the patchset: https://lkml.org/lkml/2012/11/7/402 which makes the translations for _generic_ events in POWER available in sysfs: Since this is in POWER7 specific code

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-19 Thread Sukadev Bhattiprolu
Stephane Eranian [eran...@google.com] wrote: | So all in all, I think this is not a very good idea. You have to put | this into the tool or a library that auto-detects the | host CPU and programs the right set of events. | | We've had that discussion many times. Just reiterating my personal |

[RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-11 Thread Sukadev Bhattiprolu
From 89cb6a25b9f714e55a379467a832ee015014ed11 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 18 Sep 2012 10:59:01 -0700 Subject: [PATCH] perf: Add a few generic stalled-cycles events The existing generic event 'stalled-cycles-backend' corresponds

Re: [RFC][PATCH] perf: Add a few generic stalled-cycles events

2012-10-16 Thread Sukadev Bhattiprolu
Robert Richter [robert.rich...@amd.com] wrote: | Sukadev, | | On 15.10.12 17:55:34, Robert Richter wrote: | On 11.10.12 18:28:39, Sukadev Bhattiprolu wrote: | + { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_STALLED_CYCLES_FIXED_POINT }, | + { .type = PERF_TYPE_HARDWARE, .config

Re: [PATCH] sigqueue_free: fix the race with collect_signal()

2007-08-23 Thread Sukadev Bhattiprolu
Oleg Nesterov wrote: Spotted by taoyue [EMAIL PROTECTED] and Jeremy Katz [EMAIL PROTECTED]. collect_signal: sigqueue_free: list_del_init(first-list); if (!list_empty(q-list)) {

Re: [PATCH] sigqueue_free: fix the race with collect_signal()

2007-08-24 Thread Sukadev Bhattiprolu
Oleg Nesterov wrote: On 08/24, taoyue wrote: Oleg Nesterov wrote: collect_signal: sigqueue_free: list_del_init(first-list); spin_lock_irqsave(lock, flags);

Re: [PATCH] sigqueue_free: fix the race with collect_signal()

2007-08-25 Thread Sukadev Bhattiprolu
Oleg Nesterov wrote: On 08/24, Sukadev Bhattiprolu wrote: Oleg Nesterov wrote: On 08/24, taoyue wrote: Oleg Nesterov wrote: collect_signal: sigqueue_free: list_del_init(first-list

[PATCH] perf: Power7: Make CPI stack events available in sysfs

2013-04-06 Thread Sukadev Bhattiprolu
From bdeacf7175241f6c79b5b2be0fa6b20b0d0b7d1c Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Sat, 6 Apr 2013 08:48:26 -0700 Subject: [PATCH] perf: Power7: Make CPI stack events available in sysfs A set of Power7 events are often used for Cycles Per Instruction

[PATCH] perf: Power7 Update testing ABI to list CPI-stack events

2013-04-06 Thread Sukadev Bhattiprolu
From 03a785f9d19249d2e524f31d8ead539f15d28a9f Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Sat, 6 Apr 2013 09:52:05 -0700 Subject: [PATCH] perf: Power7 Update testing ABI to list CPI-stack events Following patch added several Power7 events into /sys/devices

perf --version inconsistency

2013-04-09 Thread Sukadev Bhattiprolu
Following commit replaced 'git describe' with 'git tag -l | tail -1' to speed up the build: commit acddedfba0df1e47fa99035a04661082b679ee9c Author: Ingo Molnar mi...@kernel.org Date: Tue Oct 30 09:46:00 2012 +0100 perf tools: Speed up the perf build time by

perf test failures on Power

2013-03-28 Thread Sukadev Bhattiprolu
The 'perf' tool has some built-in test cases and one of them checks to see if the symbols in vmlinux match those in /proc/kallsyms. This test is failing on Power for several reasons. I fixed a couple of them (described briefly at the end of the mail) and these fixes take the test further. One

Re: [PATCH v2] perf: add callgrind conversion tool

2013-03-28 Thread Sukadev Bhattiprolu
Roberto Vitillo [raviti...@lbl.gov] wrote: | The proposed patch adds the convert tool to perf which allows to convert a | perf.data file to a set of callgrind data files which can subsequently be | displayed with kcachegrind. Sounds interesting and useful. My only comment is that 'convert' is a

[PATCH] perf: fix bug in isupper() and islower()

2013-03-29 Thread Sukadev Bhattiprolu
From fd349681226bf7b27c9d0f72b0f3941b5aa94f78 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 29 Mar 2013 12:14:43 -0700 Subject: [PATCH] perf: fix bug in isupper() and islower() One of the reasons 'perf test' is failing on Power appears to be due to a bug

Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-03-05 Thread Sukadev Bhattiprolu
from one place ? Sukadev --- From 50c7a46f14083c0ed10d66b7aed66ba76e798550 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 5 Mar 2013 21:20:56 -0800 Subject: [PATCH] [PATCH 5/6][v4]: perf Create a sysfs format entry for Power7 events Create a sysfs entry

[PATCH] perf/powerpc: Fix compile warnings

2013-02-05 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 5 Feb 2013 15:04:49 -0800 Subject: [PATCH] perf/powerpc: Fix compile warnings Fix compile errors like those below: CC arch/powerpc/perf/power7-pmu.o /home/git/linux/arch/powerpc/perf/power7-pmu.c:397:2: error: initialization

Re: [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-02-26 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Jan 22, 2013 at 10:26:13PM -0800, Sukadev Bhattiprolu wrote: | | [PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format | | Create a sysfs entry, '/sys/bus/event_source/devices/cpu/format/event' | which describes

[PATCH 0/6][v4]: perf: Make POWER7 events available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
PMU_FORMAT_ATTR() rather than duplicating code. Sukadev Bhattiprolu (6): perf/Power7: Use macros to identify perf events perf: Make EVENT_ATTR global perf/POWER7: Make generic event translations available in sysfs perf/POWER7: Make some POWER7 events available in sysfs perf: Create a sysfs

[PATCH 1/6][v4]: perf/Power7: Use macros to identify perf events

2013-01-22 Thread Sukadev Bhattiprolu
[PATCH 1/6][v4]: perf/Power7: Use macros to identify perf events Define and use macros to identify perf events codes This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked

[PATCH 2/6][v4]: perf: Make EVENT_ATTR global

2013-01-22 Thread Sukadev Bhattiprolu
] No need to define PMU_EVENT_PTR() Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Jiri Olsa jo...@redhat.com --- arch/x86/kernel/cpu/perf_event.c | 13 +++-- include/linux/perf_event.h | 11 +++ 2 files changed, 14 insertions(+), 10 deletions(-) diff

[PATCH 3/6][v4]: perf/POWER7: Make generic event translations available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
a47473939db20e3961b200eb00acf5fcf084d755 Author: Jiri Olsa jo...@redhat.com Date: Wed Oct 10 14:53:11 2012 +0200 perf/x86: Make hardware event translations available in sysfs Changelog:[v2] [Jiri Osla] Drop EVENT_ID() macro since it is only used once. Signed-off-by: Sukadev

[PATCH 4/6][v4]: perf/POWER7: Make some POWER7 events available in sysfs

2013-01-22 Thread Sukadev Bhattiprolu
specific and the others are the generic events. This will enable users to specify these events with their symbolic names rather than with their raw code. perf stat -e 'cpu/PM_CYC' ... Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm

[PATCH 5/6][v4]: perf: Create a sysfs entry for Power event format

2013-01-22 Thread Sukadev Bhattiprolu
is common in the code common to POWER cpus. This code is based on corresponding code in x86. Changelog[v2]: [Jiri Osla] Use PMU_FORMAT_ATTR() rather than duplicating it. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h |6 ++ arch

[PATCH 6/6][v4]: perf: Document the ABI of perf sysfs entries

2013-01-22 Thread Sukadev Bhattiprolu
documentation. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Acked-by: Jiri Olsa jo...@redhat.com --- .../testing/sysfs-bus-event_source-devices-events | 62 1 files changed, 62 insertions(+), 0 deletions(-) delete mode 100644 Documentation/ABI/stable/sysfs

Re: [PATCH] perf: Fix compile warnings in tests/attr.c

2013-01-23 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | | make: *** [tests/attr.o] Error 1 | | | | i386 compiles fine | | __u64 is 'unsigned long long' on x86 and PRIu64 is 'llu' which is fine. | | __u64 is 'unsigned long' on Power and PRIu64 is 'lu' which is again fine. | | But __u64 is

[PATCH][v2] perf tools, powerpc: Fix compile warnings in tests/attr.c

2013-01-23 Thread Sukadev Bhattiprolu
-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- tools/perf/tests/attr.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tools/perf/tests/attr.c b/tools/perf/tests/attr.c index f61dd3f..bdcceb8 100644 --- a/tools/perf/tests/attr.c +++ b/tools/perf/tests/attr.c @@ -19,6

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

2013-01-16 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Jan 15, 2013 at 03:57:59PM -0300, Arnaldo Carvalho de Melo wrote: | Em Wed, Jan 09, 2013 at 05:07:03PM -0800, Sukadev Bhattiprolu escreveu: | [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries | | This patchset addes two new sets

[PATCH] perf: Fix PMU format parsing test failure

2013-01-17 Thread Sukadev Bhattiprolu
From 776e6d7942754f139c27753213c9cf4617536618 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Thu, 17 Jan 2013 09:11:30 -0800 Subject: [PATCH] perf; Fix PMU format parsing test failure On POWER, the 'perf format parsing' test always fails. Looks like

Re: [PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

2013-01-18 Thread Sukadev Bhattiprolu
1e3cc6b3ef87f533985b10574af472361e39eecd Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 8 Jan 2013 22:31:49 -0800 Subject: [PATCH] perf: Document the ABI of perf sysfs entries This patchset addes two new sets of files to sysfs for POWER architecture. - perf event config format

[PATCH] perf: Fix compile warnings in tests/attr.c

2013-01-18 Thread Sukadev Bhattiprolu
From 4d266e5040c33103f5d226b0d16b89f8ef79e3ad Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 18 Jan 2013 11:14:28 -0800 Subject: [PATCH] perf: Fix compile warnings in tests/attr.c Replace '%llu' in printf()s with 'PRIu64' in 'tools/perf/tests/attr.c

Re: [PATCH v7 07/18] perf: add generic memory sampling interface

2013-02-15 Thread Sukadev Bhattiprolu
* Stephane Eranian eran...@google.com wrote: This patch adds PERF_SAMPLE_DSRC. PERF_SAMPLE_DSRC collects the data source, i.e., where did the data associated with the sampled instruction come from. Information is stored in a perf_mem_dsrc structure. It contains opcode, mem level,

[PATCH] Rename attach_pid() to find_attach_pid()

2007-01-11 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu [EMAIL PROTECTED] attach_pid() currently takes a pid_t parameter and uses find_pid() to find the struct pid associated with the pid_t. With containers, we sometimes already have the struct pid and could skip the find_pid() - if we have a version of attach_pid

[PATCH] attach_pid() with struct pid parameter

2007-01-11 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu [EMAIL PROTECTED] Implement a new version of attach_pid() with a struct pid parameter and wrap find_attach_pid() around it. attach_pid() would also be used in subsequent container patches. Signed-off-by: Sukadev Bhattiprolu [EMAIL PROTECTED] Cc: Cedric Le Goater

[PATCH] Remove find_attach_pid()

2007-01-11 Thread Sukadev Bhattiprolu
As Eric Biederman pointed out, find_attach_pid() is not really necessary. --- From: Sukadev Bhattiprolu [EMAIL PROTECTED] Remove find_attach_pid() interface and have callers of attach_pid() pass in a struct pid. Signed-off-by: Sukadev Bhattiprolu [EMAIL PROTECTED] Cc: Cedric Le Goater [EMAIL

[BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()

2007-01-18 Thread Sukadev Bhattiprolu
I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. Same basic config file seems to work with 2.6.20-rc2-mm1 on this same system. Have not tried -rc3-mm1 yet. Attached are config file and lspci -vv output. Let me know if you need more info. Suka --- [ 168.925840] Freeing

Re: [BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()

2007-01-18 Thread Sukadev Bhattiprolu
Auke Kok [EMAIL PROTECTED] wrote: | Sukadev Bhattiprolu wrote: | I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. | | Same basic config file seems to work with 2.6.20-rc2-mm1 on this same | system. Have not tried -rc3-mm1 yet. | | Attached are config file and lspci -vv

[PATCH] Statically initialize struct pid for swapper

2007-01-19 Thread Sukadev Bhattiprolu
From: Sukadev Bhattiprolu [EMAIL PROTECTED] Subject: [PATCH] Statically initialize struct pid for swapper Statically initialize a struct pid for the swapper process (pid_t == 0) and attach it to init_task. This is needed so task_pid(), task_pgrp() and task_session() interfaces work

[PATCH 2/2] Explicitly set pgid/sid of init

2007-01-20 Thread Sukadev Bhattiprolu
Pls treat this patch as Patch 2/2 where Patch 1/2 is http://lkml.org/lkml/2007/1/19/159 --- From: Sukadev Bhattiprolu [EMAIL PROTECTED] Explicitly set pgid and sid of init process to 1. Signed-off-by: Sukadev Bhattiprolu [EMAIL PROTECTED] Cc: Cedric Le Goater [EMAIL PROTECTED] Cc

Re: PID namespaces break initrd+hibernate combination?

2007-11-05 Thread Sukadev Bhattiprolu
Nigel Cunningham wrote: Hi all. Please excuse me if this has already been answered. I'm not currently subscribed to LKML. I've just been preparing a new tux-on-ice release against Linus' current tree, and encountered a failure to freeze pid 1 when seeking to resume, using an initrd: [

[PATCH 1/5] perf/Power7: Use macros to identify perf events

2012-12-18 Thread Sukadev Bhattiprolu
Define and use macros to identify perf events codes This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/perf/power7-pmu.c | 28 1

[PATCH 2/5] perf: Make EVENT_ATTR and EVENT_PTR global

2012-12-18 Thread Sukadev Bhattiprolu
Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR(). Make them global so they are available to all architectures. Further to allow architectures flexibility, have PMU_EVENT_PTR() pass in the variable name as a parameter. Signed-off-by: Sukadev Bhattiprolu suka

[PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs

2012-12-18 Thread Sukadev Bhattiprolu
a47473939db20e3961b200eb00acf5fcf084d755 Author: Jiri Olsa jo...@redhat.com Date: Wed Oct 10 14:53:11 2012 +0200 perf/x86: Make hardware event translations available in sysfs Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h

[PATCH 4/5] perf/POWER7: Make some POWER7 events available in sysfs

2012-12-18 Thread Sukadev Bhattiprolu
to specify these events with their symbolic names rather than with their raw code. perf stat -e 'cpu/PM_CYC' ... Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h |2 ++ arch/powerpc/perf/power7-pmu.c | 18

[PATCH 5/5] perf: Create a sysfs entry for Power event format

2012-12-18 Thread Sukadev Bhattiprolu
on corresponding code in x86. Changelog[v2]: [Jiri Osla] Use PMU_FORMAT_ATTR() rather than duplicating it. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h |6 ++ arch/powerpc/perf/core-book3s.c | 12 arch

Re: [PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs

2012-12-19 Thread Sukadev Bhattiprolu
Greg KH [g...@kroah.com] wrote: | On Tue, Dec 18, 2012 at 11:28:49PM -0800, Sukadev Bhattiprolu wrote: | | [PATCH 3/5] perf/POWER7: Make generic event translations available in sysfs | | As you are adding new sysfs files, you must also add new | Documentation/ABI entries at the same time

Re: [PATCH 2/5] perf: Make EVENT_ATTR and EVENT_PTR global

2013-01-04 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Tue, Dec 18, 2012 at 11:28:02PM -0800, Sukadev Bhattiprolu wrote: | | Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR(). | Make them global so they are available to all architectures. | | Further to allow architectures

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-14 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote: | | SNIP | | +struct perf_pmu_events_attr { | + struct device_attribute attr; | + u64 id; | +}; | + | +extern ssize_t power_events_sysfs_show(struct device *dev

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-16 Thread Sukadev Bhattiprolu
Jiri Olsa [jo...@redhat.com] wrote: | | Can we remove the assumption that the event id is a generic event that | has PERF_COUNT_HW_ prefix and also let the architectures pass in a show | function ? This would allow architectures to display any arch specific | events that don't yet have a

[PATCH 1/6][v3] perf/Power7: Use macros to identify perf events

2013-01-09 Thread Sukadev Bhattiprolu
[PATCH 1/6][v3] perf/Power7: Use macros to identify perf events Define and use macros to identify perf events codes. This would make it easier and more readable when these event codes need to be used in more than one place. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch

[PATCH 2/6][v3] perf: Make EVENT_ATTR global

2013-01-09 Thread Sukadev Bhattiprolu
] No need to define PMU_EVENT_PTR() Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/x86/kernel/cpu/perf_event.c | 13 +++-- include/linux/perf_event.h | 11 +++ 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu

[PATCH 3/6][v3] perf/POWER7: Make generic event translations available in sysfs

2013-01-09 Thread Sukadev Bhattiprolu
a47473939db20e3961b200eb00acf5fcf084d755 Author: Jiri Olsa jo...@redhat.com Date: Wed Oct 10 14:53:11 2012 +0200 perf/x86: Make hardware event translations available in sysfs Changelog:[v3] [Jiri Olsa] Drop EVENT_ID() macro since it is only used once. Signed-off-by: Sukadev

[PATCH 4/6][v3] perf/POWER7: Make some POWER7 events available in sysfs

2013-01-09 Thread Sukadev Bhattiprolu
specific and the others are the generic events. This will enable users to specify these events with their symbolic names rather than with their raw code. perf stat -e 'cpu/PM_CYC/' ... Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm

[PATCH 5/6][v3] perf: Create a sysfs entry for Power event format

2013-01-09 Thread Sukadev Bhattiprolu
is common in the code common to POWER cpus. This code is based on corresponding code in x86. Changelog[v2]: [Jiri Olsa] Use PMU_FORMAT_ATTR() rather than duplicating it. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h |6 ++ arch

[PATCH 6/6][v3] perf: Document the ABI of perf sysfs entries

2013-01-09 Thread Sukadev Bhattiprolu
which would become part of the ABI. Changelog[v3]: [Greg KH] Include ABI documentation. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Documentation/ABI/stable/sysfs-devices-cpu-events | 54 + Documentation/ABI/stable/sysfs-devices-cpu-format | 27

Re: [PATCH 1/2] perf/Power7: Save dcache_src fields in sample record.

2013-06-18 Thread Sukadev Bhattiprolu
Michael Neuling [mi...@neuling.org] wrote: | Suka, | | One of these two patches breaks pmac32_defconfig and I suspect all other | 32 bit configs (against mainline) | | arch/powerpc/perf/core-book3s.c: In function 'record_and_restart': | arch/powerpc/perf/core-book3s.c:1632:4: error: passing

Re: [PATCH 2/2] perf tools: Make Power7 events available for perf

2013-06-19 Thread Sukadev Bhattiprolu
| 14451 31112 0 45563b1fb arch/powerpc/perf/power7-pmu.o | | Signed-off-by: Runzhen Wang runz...@linux.vnet.ibm.com Reviewed-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

2013-06-19 Thread Sukadev Bhattiprolu
and | documentation accordingly. | | Signed-off-by: Runzhen Wang runz...@linux.vnet.ibm.com Reviewed-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/2] perf tools: fix a typo of a Power7 event name

2013-06-19 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Wed, 2013-06-19 at 17:15 +0800, Runzhen Wang wrote: | In the Power7 PMU guide: | https://www.power.org/documentation/commonly-used-metrics-for-performance-analysis/ | PM_BRU_MPRED is referred to as PM_BR_MPRED. | | This patch fix the

[RFC][PATCH] Fix inhert with perf record --pid

2013-11-08 Thread Sukadev Bhattiprolu
A gently tested RFC patch... --- From 38554891fc41082b767f24ce3293658f7329a691 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Fri, 8 Nov 2013 17:14:06 -0800 Subject: [PATCH] Fix inhert with perf record --pid If a target process is identified by its pid

[PATCH 4/9][v5] powerpc: Rename branch_opcode() to instr_opcode()

2013-10-01 Thread Sukadev Bhattiprolu
The logic used in branch_opcode() to extract the opcode for an instruction applies to non branch instructions also. So rename to instr_opcode(). Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com --- arch/powerpc/lib/code

[no subject]

2013-10-01 Thread Sukadev Bhattiprolu
. Thanks to input from Stephane Eranian, Michael Ellerman, Michael Neuling and Anshuman Khandual. Sukadev Bhattiprolu (9): powerpc/perf: Rename Power8 macros to start with PME powerpc/perf: Export Power8 generic events in sysfs powerpc/perf: Add Power8 event PM_MRK_GRP_CMPL to sysfs. powerpc

[PATCH 1/9][v5] powerpc/perf: Rename Power8 macros to start with PME

2013-10-01 Thread Sukadev Bhattiprolu
We use helpers like GENERIC_EVENT_ATTR() to list the generic events in sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf event macros to start with PME. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com

[PATCH 3/9][v5] powerpc/perf: Add Power8 event PM_MRK_GRP_CMPL to sysfs.

2013-10-01 Thread Sukadev Bhattiprolu
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy of applications. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com --- arch/powerpc/perf/power8-pmu.c |5 + 1 file changed, 5 insertions(+) diff

[PATCH 7/9][v5] powerpc/perf: Export Power8 memory hierarchy info to user space.

2013-10-01 Thread Sukadev Bhattiprolu
for now. Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian eran...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com

[PATCH 9/9][v5] powerpc/perf: Update perf-mem man page for Power

2013-10-01 Thread Sukadev Bhattiprolu
Add a few lines to the perf-mem man page to indicate: - its dependence on the mem-loads and mem-stores events - how to use the feature on Power architecture. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- tools/perf/Documentation/perf-mem.txt | 11

[PATCH 2/9][v5] powerpc/perf: Export Power8 generic events in sysfs

2013-10-01 Thread Sukadev Bhattiprolu
Export generic perf events for Power8 in sysfs. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com --- arch/powerpc/perf/power8-pmu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/powerpc

[PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-01 Thread Sukadev Bhattiprolu
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com --- Changelog [v5]: - include endian.h in local byteorder.h Changelog [v4]: - perf_event.h includes byteorder.h which pulls in the local byteorder.h when

[PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-01 Thread Sukadev Bhattiprolu
Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information of the load/store. Signed-off-by: Sukadev Bhattiprolu suka

[PATCH 8/9][v5] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-10-01 Thread Sukadev Bhattiprolu
...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Reviewed-by: Anshuman Khandual khand...@linux.vnet.ibm.com --- Changelog[v4]: Drop support for 'perf mem' for Power (use perf-record and perf-report directly) Changelog[v3

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | perf_mem_data_src is an union that is initialized via the -val field | and accessed via the bitmap fields. For this to work on big endian | platforms, we also need a big

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | perf_mem_data_src is an union that is initialized via the -val field | and accessed via the bitmap fields. For this to work on big endian | platforms, we also need a big

Re: [PATCH 2/9][v5] powerpc/perf: Export Power8 generic events in sysfs

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:03PM -0700, Sukadev Bhattiprolu wrote: | Export generic perf events for Power8 in sysfs. | | Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com | Reviewed-by: Anshuman Khandual khand

Re: [PATCH 5/9][v5] powerpc: implement is_instr_load_store().

2013-10-03 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:06PM -0700, Sukadev Bhattiprolu wrote: | Implement is_instr_load_store() to detect whether a given instruction | is one of the fixed-point or floating-point load/store instructions. | This function will be used

Re: [PATCH 6/9][v5] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-04 Thread Sukadev Bhattiprolu
Michael Ellerman [mich...@ellerman.id.au] wrote: | On Tue, Oct 01, 2013 at 05:15:07PM -0700, Sukadev Bhattiprolu wrote: | perf_mem_data_src is an union that is initialized via the -val field | and accessed via the bitmap fields. For this to work on big endian | platforms, we also need a big

[PATCH 2/8][v4] powerpc/perf: Export Power8 generic events in sysfs

2013-09-13 Thread Sukadev Bhattiprolu
Export generic perf events for Power8 in sysfs. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/perf/power8-pmu.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf/power8-pmu.c index

[PATCH 5/8][v4] powerpc/perf: Export Power8 memory hierarchy info to user space.

2013-09-13 Thread Sukadev Bhattiprolu
for now. Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian eran...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v4]: Drop support for 'perf mem' for Power (use

[PATCH 4/8][v4] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-09-13 Thread Sukadev Bhattiprolu
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog [v2]: - [Vince Weaver, Michael Ellerman] No __KERNEL__ in uapi headers. include/uapi/linux/perf_event.h | 58 +++ 1 file changed, 58 insertions(+) diff --git a/include/uapi/linux

[PATCH 8/8][v4] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-09-13 Thread Sukadev Bhattiprolu
...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v4]: Drop support for 'perf mem' for Power (use perf-record and perf-report directly) Changelog[v3]: [Michael Ellerman] If newer levels that we defined

[PATCH 7/8][v4] power: implement is_instr_load_store().

2013-09-13 Thread Sukadev Bhattiprolu
Implement is_instr_load_store() to detect whether a given instruction is one of the fixed-point or floating-point load/store instructions. This function will be used in a follow-on patch to save memory hierarchy information of the load/store. Signed-off-by: Sukadev Bhattiprolu suka

[PATCH 3/8][v4] powerpc/perf: Add PM_MRK_GRP_CMPL event to sysfs.

2013-09-13 Thread Sukadev Bhattiprolu
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy of applications. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/perf/power8-pmu.c |5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/perf/power8-pmu.c b/arch/powerpc/perf

[PATCH 6/8][v4] powerpc: Rename branch_opcode() to instr_opcode()

2013-09-13 Thread Sukadev Bhattiprolu
The logic used in branch_opcode() to extract the opcode for an instruction applies to non branch instructions also. So rename to instr_opcode(). Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/lib/code-patching.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 0/8][v4] powerpc/perf: Export memory hierarchy level in Power7/8.

2013-09-13 Thread Sukadev Bhattiprolu
Power7 and Power8 processors save the memory hierarchy level (eg: L2, L3) from which a load or store instruction was satisfied. Export this hierarchy information to the user via the perf_mem_data_src object. Thanks to input from Stephane Eranian, Michael Ellerman, Michael Neuling. Sukadev

[PATCH 1/8][v4] powerpc/perf: Rename Power8 macros to start with PME

2013-09-13 Thread Sukadev Bhattiprolu
We use helpers like GENERIC_EVENT_ATTR() to list the generic events in sysfs. To avoid name collisions, GENERIC_EVENT_ATTR() requires the perf event macros to start with PME. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/perf/power8-pmu.c | 24

[PATCH 02/10][v6] powerpc/Power7: detect load/store instructions

2013-10-15 Thread Sukadev Bhattiprolu
on a Power7 system. (Power8 systems set some bits in the SIER to identify load/store operations and hence don't need a similar functionality). Based on optimized code from Michael Ellerman and comments from Tom Musta. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v6

[PATCH 09/10][v6] powerpc/perf: Export Power8 memory hierarchy info to user space.

2013-10-15 Thread Sukadev Bhattiprolu
for now. Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling. Cc: Stephane Eranian eran...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v2]: Drop support for 'perf mem' for Power (use

[PATCH 07/10][v6] powerpc/perf: Add Power8 event PM_MRK_GRP_CMPL to sysfs.

2013-10-15 Thread Sukadev Bhattiprolu
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy of applications. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v6]: - [Michael Ellerman]: Drop redundant PME_ prefix from event name. arch/powerpc/perf/power8-events-list.h |1 + 1

[PATCH 08/10][v6] powerpc/perf: Define big-endian version of perf_mem_data_src

2013-10-15 Thread Sukadev Bhattiprolu
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog [v6] - [Michael Ellerman] Use __BIG_ENDIAN_BITFIELD to simplify the endian check. Changelog [v5]: - perf_event.h includes byteorder.h which pulls in the local byteorder.h when building

[PATCH 10/10][v6] powerpc/perf: Export Power7 memory hierarchy info to user space.

2013-10-15 Thread Sukadev Bhattiprolu
...@google.com Cc: Michael Ellerman mich...@ellerman.id.au Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v4]: Drop support for 'perf mem' for Power (use perf-record and perf-report directly) Changelog[v3]: [Michael Ellerman] If newer levels that we defined

[PATCH 06/10][v6] powerpc/perf: Export Power8 generic events in sysfs

2013-10-15 Thread Sukadev Bhattiprolu
Export generic perf events for Power8 in sysfs. Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- Changelog[v6]: [Michael Ellerman] Drop PME_ prefix in macros arch/powerpc/perf/power8-events-list.h | 20 +++ arch/powerpc/perf/power8-pmu.c | 44

[PATCH 05/10][v6] powerpc/perf: Remove PME_ prefix for power7 events

2013-10-15 Thread Sukadev Bhattiprolu
eller...@au1.ibm.com Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/include/asm/perf_event_server.h |2 +- arch/powerpc/perf/power7-pmu.c | 18 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/include

[PATCH 04/10][v6] tools/perf: Remove local byteorder.h.

2013-10-15 Thread Sukadev Bhattiprolu
-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- tools/perf/Makefile |1 - tools/perf/util/include/asm/byteorder.h |2 -- tools/perf/util/include/linux/types.h | 20 3 files changed, 20 insertions(+), 3 deletions(-) delete mode 100644

[PATCH 01/10][v6] powerpc: Rename branch_opcode() to instr_opcode()

2013-10-15 Thread Sukadev Bhattiprolu
The logic used in branch_opcode() to extract the opcode for an instruction applies to non branch instructions also. So rename to instr_opcode(). Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- arch/powerpc/lib/code-patching.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 00/10][v6] powerpc/perf: Export memory hierarchy level in Power7/8.

2013-10-15 Thread Sukadev Bhattiprolu
Khandual. Sukadev Bhattiprolu (10): powerpc: Rename branch_opcode() to instr_opcode() powerpc/Power7: detect load/store instructions tools/perf: silence compiler warnings tools/perf: Remove local byteorder.h. powerpc/perf: Remove PME_ prefix for power7 events powerpc/perf: Export Power8

[PATCH 03/10][v6] tools/perf: silence compiler warnings

2013-10-15 Thread Sukadev Bhattiprolu
The uninitialized variables cause warnings which are treated as errors during build (without WERROR=0). Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com --- tools/perf/util/srcline.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/srcline.c

  1   2   3   4   5   6   7   8   9   10   >