Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > I don't care either way, but being different from the documentation > is less bad than crashing which is what your patch does. Please > be more careful in the future. > > regards, > dan carpenter Critism accepted. Given that the driver d

Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL

2012-12-18 Thread Tony Prisk
On Wed, 2012-12-19 at 08:11 +1300, Tony Prisk wrote: > On Tue, 2012-12-18 at 22:03 +0300, Dan Carpenter wrote: > > I don't care either way, but being different from the documentation > > is less bad than crashing which is what your patch does. Please > > be

Inconsistency in clk framework

2012-12-18 Thread Tony Prisk
pear to be defined in clk.h when HAVE_CLK is undefined - is this correct? Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > > Hi Mike, > > > > In attempting to remove some IS_ERR_OR_NULL references, it was pointed > > out that clk_get() can return NULL if CON

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > > On Wed, Dec 19, 2012 at 05:10:33PM +1300, Tony Prisk wrote: > > > Hi Mike, > > > > > > In attempting to remove some IS_ERR_OR_NULL

Re: Inconsistency in clk framework

2012-12-19 Thread Tony Prisk
On Wed, 2012-12-19 at 19:08 +, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 08:00:49AM +1300, Tony Prisk wrote: > > On Thu, 2012-12-20 at 06:34 +1300, Tony Prisk wrote: > > > On Wed, 2012-12-19 at 09:26 +, Russell King - ARM Linux wrote: > > > >

pwm_backlight/general pwm issue.

2012-11-16 Thread Tony Prisk
e during driver unload. Looking for your thoughts (or anyone else that wants to chime in). Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/m

[PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs

2013-06-14 Thread Tony Prisk
This patch adds support for the I2C bus controllers found on Wondermedia 8xxx-series SoCs. Only master-mode is supported. Signed-off-by: Tony Prisk --- v3 changes: Included the v2 changes for clarity. Tidy up the I2C_NO_START code properly. Remove the alias handling and allow the core to do it

Re: [PATCH v3] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs

2013-06-15 Thread Tony Prisk
On 15/06/13 23:18, Wolfram Sang wrote: On Sat, Jun 15, 2013 at 09:52:16AM +1200, Tony Prisk wrote: This patch adds support for the I2C bus controllers found on Wondermedia 8xxx-series SoCs. Only master-mode is supported. Signed-off-by: Tony Prisk --- ... +/* REG_TR */ +#define SCL_TIMEOUT

Re: [PATCH] pinctrl: establish pull-up/pull-down terminology

2013-06-16 Thread Tony Prisk
On 16/06/13 22:45, Linus Walleij wrote: From: Linus Walleij It is counter-intuitive to have "0" mean disable in a boolean manner for electronic properties of pins such as pull-up and pull-down. Therefore, define that a pull-up/pull-down argument of 0 to such a generic option means that the pin

Re: [PATCH 4/4] MAINTAINERS: vt8500: Add clk-vt8500.c to MAINTAINERS file

2013-05-29 Thread Tony Prisk
On 30/05/13 11:16, Mike Turquette wrote: Quoting Tony Prisk (2013-05-18 01:30:21) On 18/05/13 18:40, Alexey Charkov wrote: On 18 May 2013 01:18, "Tony Prisk" wrote: This file has missed being added under ARM/VT8500 ARM ARCHITECTURE, and is maintained along with the rest of the v

Re: [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl_probe()

2013-06-25 Thread Tony Prisk
return PTR_ERR(data->base); - } wmt_desc.pins = data->pins; wmt_desc.npins = data->npins; Acked-by: Tony Prisk Regards Tony P -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

[PATCH v2] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs

2013-06-12 Thread Tony Prisk
This patch adds support for the I2C bus controllers found on Wondermedia 8xxx-series SoCs. Only master-mode is supported. Signed-off-by: Tony Prisk --- .../devicetree/bindings/i2c/i2c-vt8500.txt | 24 + MAINTAINERS|1 + drivers/i2c/busses

Re: [PATCH] irqchip: vt8500: Staticize local symbols

2013-07-04 Thread Tony Prisk
are lined up, rather than aligning with the (. Can you move the 'struct device_node *parent' across one more space? Otherwise: Acked-by: Tony Prisk { int irq, i; struct device_node *np = node; Regards Tony P -- To unsubscribe from this list: send the line &q

Submitting fbdev tree patches

2013-03-24 Thread Tony Prisk
Is anyone taking patches for fbdev at the moment? I sent in some patches for 3.9 but didn't hear back - checking the lists it doesn't appear Florian has posted much since the end of Oct 2012. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux

[PATCH] arm: vt8500: Add wm8850 config options to multi_v7_defconfig

2013-03-25 Thread Tony Prisk
This patch finally adds the WM8850 SoC to the multi_v7_defconfig. We don't have a seperate defconfig for this SoC as it is only available as a multiplatform option. Signed-off-by: Tony Prisk --- arch/arm/configs/multi_v7_defconfig |8 1 file changed, 8 insertions(+) diff --

Re: Submitting fbdev tree patches

2013-03-25 Thread Tony Prisk
On Mon, 2013-03-25 at 05:27 +, Jingoo Han wrote: > On Monday, March 25, 2013 2:11 PM, Tony Prisk wrote: > > > > Is anyone taking patches for fbdev at the moment? > > > > I sent in some patches for 3.9 but didn't hear back - checking the lists > > it

[PATCH] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM

2013-03-26 Thread Tony Prisk
Compiling with !CONFIG_PM generates an unused function warning on unlink_empty_async_suspended(). Enclose the function and its forward declaration in a #ifdef CONFIG_PM Signed-off-by: Tony Prisk --- drivers/usb/host/ehci-q.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCHv2] usb: ehci: unlink_empty_async_suspended() only used with CONFIG_PM

2013-03-26 Thread Tony Prisk
Compiling with !CONFIG_PM generates an unused function warning on unlink_empty_async_suspended(). Enclose the function in a #ifdef CONFIG_PM Signed-off-by: Tony Prisk --- Fixed up the commit message. drivers/usb/host/ehci-q.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] dts: wandboard: Add support for SDIO bcm4329

2013-07-27 Thread Tony Prisk
The wandboard has a Broadcom 4329 WiFi connected via SDIO. This patch sets the required pins to enable the wifi module. Signed-off-by: Tony Prisk --- arch/arm/boot/dts/imx6qdl-wandboard.dtsi | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Tony Prisk
>dev, res); > - if (!gpio_base) { > - dev_err(&pdev->dev, "Unable to map GPIO registers\n"); > - return -ENOMEM; > - } > + gpio_base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(gpio_base)) > +

[PATCH] i2c: vt8500: Add support for I2C bus on Wondermedia SoCs

2013-05-12 Thread Tony Prisk
This patch adds support for the I2C bus controllers found on Wondermedia 8xxx-series SoCs. Only master-mode is supported. Signed-off-by: Tony Prisk --- .../devicetree/bindings/i2c/i2c-vt8500.txt | 24 + MAINTAINERS|1 + drivers/i2c/busses

[PATCHv6 0/3] Add support for velocity network driver on platform devices

2013-05-12 Thread Tony Prisk
t they should introduce any problems as it is all renames and function swapping. Patch #3 adds support for the velocity driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to

[PATCHv6 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-12 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv6 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-12 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCHv6 2/3] net: velocity: Convert to generic dma functions

2013-05-12 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCH 0/2] clk: vt8500: updates for 3.11

2013-05-13 Thread Tony Prisk
Hi Mike, Two updates for the arch-vt8500 clock code: #1: Add support for the WM8850 PLL. #2: Remove a second divisor check in vt8500_dclk_set_rate() which causes the divisor to be round-down too low. Regards Tony Prisk Tony Prisk (2): clk: vt8500: Add support for clocks on the WM8850 SoCs

[PATCH 1/2] clk: vt8500: Add support for clocks on the WM8850 SoCs

2013-05-13 Thread Tony Prisk
The WM8850 has a different PLL clock to the previous versions. This patch adds support for the WM8850-style PLL clocks. Signed-off-by: Tony Prisk --- Documentation/devicetree/bindings/clock/vt8500.txt |2 + drivers/clk/clk-vt8500.c | 71 2

[PATCH 2/2] clk: vt8500: Remove unnecessary divisor adjustment in vtwm_dclk_set_rate()

2013-05-13 Thread Tony Prisk
. Signed-off-by: Tony Prisk --- drivers/clk/clk-vt8500.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index 6d5b6e9..d8fd085 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -157,10 +157,6 @@ static int

Re: [PATCH] drivers: pinctrl: vt8500: use devm_ioremap_resource()

2013-05-14 Thread Tony Prisk
in my world..? Found with coccicheck and this semantic patch: scripts/coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Laurent Navet Seems OK if the deprecation is ongoing. Tony can I have your ACK? Acked-by: Tony Prisk -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 20/20] ARM: vt8500: Remove init_irq declaration in machine description

2013-05-15 Thread Tony Prisk
o, - .init_irq = irqchip_init, .init_machine = vt8500_init, .init_time = clocksource_of_init, .restart= vt8500_restart, I don't have any plans to touch this driver, so please send direct to arm-soc as Arnd requested. Acked-by: Tony Prisk

PWM backlight build warning

2013-04-06 Thread Tony Prisk
Hi Thierry, Sorry it's taken so long to report this but I've been tied up with other patches recently. I noticed a build warning on the pwm_bl driver in 3.9-rcX but I'm not sure what the correct resolution would be. This patch: commit e2c17bc6f717a8847df2a867caec6ba4fe85f3fc backlight: conver

Re: PWM backlight build warning

2013-04-06 Thread Tony Prisk
On 07/04/13 09:10, Thierry Reding wrote: On Sat, Apr 06, 2013 at 09:02:51PM +0100, Mark Brown wrote: On Sun, Apr 07, 2013 at 06:33:35AM +1200, Tony Prisk wrote: The problem occurs because when CONFIG_PM=y but CONFIG_PM_SLEEP=n: I guess this would be a problem on every driver that has been

Re: linux-next: manual merge of the arm-soc tree with the gpio-lw tree

2013-04-09 Thread Tony Prisk
On 09/04/13 19:47, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the arm-soc tree got a conflict in drivers/gpio/gpio-vt8500.c between commit 808c513ee64b ("gpio/vt8500: Convert to devm_ioremap_resource()") from the gpio-lw tree and commit dc1010860b03 ("gpio: vt8500: Remove arch-v

Re: [PATCH] pinctrl: vt8500: wmt: Fix checking return value of pinctrl_register()

2013-04-09 Thread Tony Prisk
On 10/04/13 03:59, Axel Lin wrote: pinctrl_register() returns NULL on error. Signed-off-by: Axel Lin --- drivers/pinctrl/vt8500/pinctrl-wmt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c in

Re: [PATCHv4 0/3] Add support for velocity network driver on platform devices

2013-05-01 Thread Tony Prisk
On 02/05/13 06:52, David Miller wrote: From: Tony Prisk Date: Tue, 30 Apr 2013 18:16:57 +1200 I think it would be pertinent to get some tested-by's for PCI users. Tony, this came in a bit late, and there hasn't been any PCI test reports so I have to defer this to the next merge win

[PATCH 29/30] rtc: rtc-vt8500: use devm_rtc_device_register()

2013-05-02 Thread Tony Prisk
I realise this is a rather trivial series but it would be nice if the listed maintainers for the drivers had been notified as well. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

[PATCHv5 0/3] Add support for velocity network driver on platform devices

2013-05-02 Thread Tony Prisk
t see that they should introduce any problems as it is all renames and function swapping. Patch #3 adds support for the velocity driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to

[PATCHv5 2/3] net: velocity: Convert to generic dma functions

2013-05-02 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv5 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-02 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv5 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-02 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

Re: [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()

2013-05-03 Thread Tony Prisk
@@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev) /* Disable alarm matching */ writel(0, vt8500_rtc->regbase + VT8500_RTC_IS); - platform_set_drvdata(pdev, NULL); - return 0; } Acked-by: Tony Prisk -- To unsubscribe from this list: s

[PATCH] pinctrl: vt8500: Fix incorrect data in WM8750 pinctrl table

2013-05-10 Thread Tony Prisk
WMT_PIN_WAKEUP1 should be declared as WMT_PIN(0, 17) rather than WMT_PIN(0, 16). This currently generates a runtime warning because WMT_PIN_WAKEUP0 is already defined as WMT_PIN(0, 16). Signed-off-by: Tony Prisk --- drivers/pinctrl/vt8500/pinctrl-wm8750.c |2 +- 1 file changed, 1 insertion

VIA velocity network driver

2013-04-26 Thread Tony Prisk
work fine on the APC8750. Could it be avoided with a vptr->has_no_eeprom that defaults to 0 to avoid breaking existing support? Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

[PATCH 1/4] net: velocity: Alphabetize #includes

2013-04-27 Thread Tony Prisk
Due to number of #includes, alphabetize them to help avoid duplicates. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-velocity.c | 48 +++ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers

[PATCH 2/4] net: velocity: Rename vptr->dev to vptr->netdev

2013-04-27 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCH 4/4] net: velocity: Add platform device support to VIA velocity driver

2013-04-27 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCH 0/4] Add support for velocity network driver on platform devices

2013-04-27 Thread Tony Prisk
boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (4): net: velocity: Alphabetize #includes net: velocity: Rename vptr->dev to vptr->netdev net: velocity: Convert to generic dma functions net: ve

[PATCH 3/4] net: velocity: Convert to generic dma functions

2013-04-27 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

Re: [PATCH 3/4] net: velocity: Convert to generic dma functions

2013-04-27 Thread Tony Prisk
On 28/04/13 15:16, Tony Prisk wrote: Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk

Re: [PATCH 1/4] net: velocity: Alphabetize #includes

2013-04-28 Thread Tony Prisk
On 28/04/13 17:21, David Miller wrote: From: Tony Prisk Date: Sun, 28 Apr 2013 15:16:43 +1200 Due to number of #includes, alphabetize them to help avoid duplicates. Signed-off-by: Tony Prisk Needless churn, I refuse to apply this. No problem - I'll drop it. Tony Prisk -- To unsubs

[PATCHv2 0/3] Add support for velocity network driver on platform devices

2013-04-29 Thread Tony Prisk
devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (3): net: velocity: Rename vptr->dev to vptr->netdev net:

[PATCHv2 2/3] net: velocity: Convert to generic dma functions

2013-04-29 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv2 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-04-29 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv2 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-04-29 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

Re: [PATCHv2 0/3] Add support for velocity network driver on platform devices

2013-04-29 Thread Tony Prisk
On 30/04/13 07:15, David Miller wrote: You prepared these patches against a net-next tree which is at least a week old, I know this because that's when the NETIF_F_* flags for VLAN offloading changed their names which causes your third patch to fail to apply. Do not do this, net-next changes eve

[PATCHv3 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-04-29 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv3 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-04-29 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCHv3 2/3] net: velocity: Convert to generic dma functions

2013-04-29 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv3 0/3] Add support for velocity network driver on platform devices

2013-04-29 Thread Tony Prisk
pping. Patch #3 adds support for the velocity driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (3):

[PATCHv4 2/3] net: velocity: Convert to generic dma functions

2013-04-29 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv4 0/3] Add support for velocity network driver on platform devices

2013-04-29 Thread Tony Prisk
t tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (3): net: velocity: Rename vptr->dev to vptr->netdev net: velocity: Convert to generic dma functions net: velocity: Add platform device support to VIA velo

[PATCHv4 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-04-29 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv4 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-04-29 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCH] arm: vt8500: Add SDHC support to WM8505 DT

2013-04-11 Thread Tony Prisk
This patch adds the required node for the SDHC controller on WM8505 SoCs. Signed-off-by: Tony Prisk --- Arnd, Any chance you can apply this for 3.10 Regards Ton yP arch/arm/boot/dts/wm8505.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm

[v3] Support Elan Touchscreen eKTF product.

2013-04-12 Thread Tony Prisk
compiled without CONFIG_PM. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] clk: vt8500: Missing breaks in vtwm_pll_round_rate/_set_rate.

2013-04-13 Thread Tony Prisk
The case of PLL_TYPE_WM8750 in both these functions is missing a break statement causing a fall-through to the default: case. Insert the missing break statements. Signed-off-by: Tony Prisk --- Mike, Any chance this can still go in as a fix for 3.9 The fault makes it impossible to set the PLL

[PATCHv6 0/3] Add support for velocity network driver on platform devices

2013-05-16 Thread Tony Prisk
t they should introduce any problems as it is all renames and function swapping. Patch #3 adds support for the velocity driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to g

[PATCHv6 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-16 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv6 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-16 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCHv6 2/3] net: velocity: Convert to generic dma functions

2013-05-16 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

Re: [PATCH] ARM: vt8500: Add missing NULL terminator in dt_compat

2013-05-17 Thread Tony Prisk
DT_MACHINE_START(WMT_DT, "VIA/Wondermedia SoC (Device Tree Support)") My bad. Thanks for the fix. Acked-by: Tony Prisk Arnd, Olof: Can you apply this directly please. Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

[PATCH 4/4] MAINTAINERS: vt8500: Add clk-vt8500.c to MAINTAINERS file

2013-05-17 Thread Tony Prisk
This file has missed being added under ARM/VT8500 ARM ARCHITECTURE, and is maintained along with the rest of the vt8500 arch code. Signed-off-by: Tony Prisk --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d7782b..5ab8ccb 100644 --- a

[PATCH 3/4] clk: vt8500: Remove unnecessary divisor adjustment in vtwm_dclk_set_rate()

2013-05-17 Thread Tony Prisk
. Signed-off-by: Tony Prisk --- drivers/clk/clk-vt8500.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index ce401cf..82306f5 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -157,10 +157,6 @@ static int

[PATCH 1/4] clk: vt8500: Fix unbalanced spinlock in vt8500_dclk_set_rate()

2013-05-17 Thread Tony Prisk
vt8500_dclk_set_rate(). Replace the second call to spin_lock_irqsave() with spin_unlock_irqrestore(). Signed-off-by: Tony Prisk --- drivers/clk/clk-vt8500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index debf688..553ac35 100644 --- a

[PATCH 2/4] clk: vt8500: Add support for clocks on the WM8850 SoCs

2013-05-17 Thread Tony Prisk
The WM8850 has a different PLL clock to the previous versions. This patch adds support for the WM8850-style PLL clocks. Signed-off-by: Tony Prisk --- Documentation/devicetree/bindings/clock/vt8500.txt |2 + drivers/clk/clk-vt8500.c | 71 2

[PATCH 0/4] VT8500 clock for 3.10/3.11

2013-05-17 Thread Tony Prisk
nt so I have dropped it. Patch #4 is to add clk-vt8500.c to MAINTAINERS Regards Tony Prisk Tony Prisk (4): clk: vt8500: Fix unbalanced spinlock in vt8500_dclk_set_rate() clk: vt8500: Add support for clocks on the WM8850 SoCs clk: vt8500: Remove unnecessary divisor adjustme

Re: [PATCHv6 0/3] Add support for velocity network driver on platform devices

2013-05-17 Thread Tony Prisk
On 18/05/13 12:36, David Miller wrote: From: David Miller Date: Fri, 17 May 2013 14:19:38 -0700 (PDT) Series applied, thanks. I'm reverting this, you're not using the correct types for the PM functions you're hooking up. drivers/net/ethernet/via/via-velocity.c:3238:8: warning: initialization

[PATCHv7 0/3] Add support for velocity network driver on platform devices

2013-05-17 Thread Tony Prisk
le-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (3): net: velocity: Rename vptr->dev to vptr->netdev net: velocity: Convert to generic dma functions net: velocity: Add

[PATCHv7 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-17 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv7 2/3] net: velocity: Convert to generic dma functions

2013-05-17 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv7 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-17 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

Re: [PATCHv7 0/3] Add support for velocity network driver on platform devices

2013-05-17 Thread Tony Prisk
On 18/05/13 14:23, Tony Prisk wrote: v7 changes: Forgot to merge a patch to fix an error with the pm ops changes. Apologies Dave. v6 changes: Remove more bus specific code from velocity_probe() Make velocity_(suspend/resume) accept a struct device * Simplify PM code to use velocity_(suspend

[PATCHv8 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-17 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

[PATCHv8 0/3] Add support for velocity network driver on platform devices

2013-05-17 Thread Tony Prisk
driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony Prisk (3): net: velocity: Rename vptr->dev to vptr->netde

[PATCHv8 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-17 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv8 2/3] net: velocity: Convert to generic dma functions

2013-05-17 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

Re: [PATCH 4/4] MAINTAINERS: vt8500: Add clk-vt8500.c to MAINTAINERS file

2013-05-18 Thread Tony Prisk
On 18/05/13 18:40, Alexey Charkov wrote: On 18 May 2013 01:18, "Tony Prisk" wrote: This file has missed being added under ARM/VT8500 ARM ARCHITECTURE, and is maintained along with the rest of the vt8500 arch code. Signed-off-by: Tony Prisk --- MAINTAINERS |1 + 1 file

[PATCH 0/4] FB updates for 3.11

2013-05-18 Thread Tony Prisk
found on the APC8750 board. Tony Prisk (4): fb: vt8500: Move register defines inside driver fb: vt8500: Convert to use vendor register names fb: vt8500: Require a device clock for wm8505fb driver fb: vt8500: Add VGA output support to wm8505fb driver. .../devicetree/bindings/video/wm,wm8505

[PATCH 2/4] fb: vt8500: Convert to use vendor register names

2013-05-18 Thread Tony Prisk
Change all the #defines to match the vendor defined names, and change the references in wm8505fb.c and wmt_ge_rops.c. Add all the missing register offsets as well to prevent churn in the future. Signed-off-by: Tony Prisk --- drivers/video/wm8505fb.c| 159 drivers

[PATCH 4/4] fb: vt8500: Add VGA output support to wm8505fb driver.

2013-05-18 Thread Tony Prisk
The APC8750 does not support an LCD panel, but provides a VGA connector. This patch adds support for the VGA interface, and defines an optional devicetree property to specify the output interface. The default if not specified is LCD for backward compatibility. Signed-off-by: Tony Prisk

[PATCH 3/4] fb: vt8500: Require a device clock for wm8505fb driver

2013-05-18 Thread Tony Prisk
-by: Tony Prisk --- .../devicetree/bindings/video/wm,wm8505-fb.txt |4 ++- drivers/video/wm8505fb.c | 30 +--- 2 files changed, 29 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/video/wm,wm8505-fb.txt b/Documentation

[PATCH 1/4] fb: vt8500: Move register defines inside driver

2013-05-18 Thread Tony Prisk
The #defines in wm8505fb_regs.h are only used in the wm8505fb driver, and don't need to be visible outside. Move the defines into the driver and remove the header. Signed-off-by: Tony Prisk --- drivers/video/wm8505fb.c | 25 +- drivers/video/wm8505fb_regs.h |

[PATCHv9 2/3] net: velocity: Convert to generic dma functions

2013-05-18 Thread Tony Prisk
Remove the pci_* dma functions and replace with the more generic versions. In preparation of adding platform support, a new struct device *dev is added to struct velocity_info which can be used by both the pci and platform code. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via

[PATCHv9 0/3] Add support for velocity network driver on platform devices

2013-05-18 Thread Tony Prisk
d function swapping. Patch #3 adds support for the velocity driver on devicetree platform devices. Binding document included. This patch is compile-tested for PCI, and boot tested on a VIA APC8750. I think it would be pertinent to get some tested-by's for PCI users. Regards Tony Prisk Tony P

[PATCHv9 1/3] net: velocity: Rename vptr->dev to vptr->netdev

2013-05-18 Thread Tony Prisk
Improve the clarity of the code in preparation for converting the dma functions to generic versions, which require a struct device *. This makes it possible to store a 'struct device *dev' in the velocity_info structure. Signed-off-by: Tony Prisk --- drivers/net/ethernet/via/via-

[PATCHv9 3/3] net: velocity: Add platform device support to VIA velocity driver

2013-05-18 Thread Tony Prisk
Add support for the VIA Velocity network driver to be bound to a OF created platform device. Signed-off-by: Tony Prisk --- .../devicetree/bindings/net/via-velocity.txt | 20 + drivers/net/ethernet/via/Kconfig |3 +- drivers/net/ethernet/via/via-velocity.c

Re: [PATCH 4/4] fb: vt8500: Add VGA output support to wm8505fb driver.

2013-05-18 Thread Tony Prisk
On 19/05/13 01:28, Alexey Charkov wrote: 2013/5/18 Tony Prisk : The APC8750 does not support an LCD panel, but provides a VGA connector. This patch adds support for the VGA interface, and defines an optional devicetree property to specify the output interface. The default if not specified is

Re: [PATCH 1/2] pinctrl: Don't override the error code in probe error handling

2013-05-19 Thread Tony Prisk
On 19/05/13 17:58, Axel Lin wrote: Otherwise, we return 0 in probe error paths when gpiochip_remove() returns 0. Also show error message if gpiochip_remove() fails. Signed-off-by: Axel Lin Cc: Linus Walleij Cc: Maxime Ripard Cc: Tony Prisk --- drivers/pinctrl/pinctrl-coh901.c | 3

Re: [PATCH 0/4] FB updates for 3.11

2013-05-19 Thread Tony Prisk
On 18/05/13 21:15, Tony Prisk wrote: Patch #1 - Move register defines inside the driver and drop the header. Patch #2 - Convert the register defines to use the vendor preferred names. Patch #3 - Add a device clock to wm8505fb. Without it, only the uboot initialized resolution is supported. Patch

<    1   2   3   4   >