Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

2014-03-26 Thread Vijay Subramanian
esulted in this explanation. http://www.spinics.net/lists/netdev/msg256410.html Vijay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [PATCH] arm64: kgdb: fix single stepping

2014-10-27 Thread Vijay Kilari
ct irq_work *work) >> { >> kgdb_nmicallback(raw_smp_processor_id(), get_irq_regs()); >> } >> >> void kgdb_roundup_cpus(unsigned long flags) >> { >> - local_irq_enable(); >> - smp_call_function(kgdb_call_nmi_hook, NULL, 0); >> - local

Re: [PATCH] arm64: kgdb: fix single stepping

2014-11-07 Thread Vijay Kilari
Hi Akashil, On Tue, Oct 28, 2014 at 5:48 AM, AKASHI Takahiro wrote: > Vijay, > > On 10/27/2014 09:45 PM, Vijay Kilari wrote: >> >> Hi Akashi, >> >> I could not reproduce this with my simulator. >> It would be good if you could post result of KGD

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Vijay Pandurangan
[oops – resending this because I was using gmail in HTML mode before by accident] There was a discussion on a separate thread about this. I agree with Sabrina fully. I believe veth should provide an abstraction layer that correctly emulates a physical network in all ways. Consider an environment

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Vijay Pandurangan
On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: > > > On 04/30/2016 12:54 PM, Tom Herbert wrote: >> >> We've put considerable effort into cleaning up the checksum interface >> to make it as unambiguous as possible, please be very careful to >> follow it. Broken checksum processing is really har

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Vijay Pandurangan
On Sat, Apr 30, 2016 at 5:29 PM, Ben Greear wrote: > > > On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: >> >> On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear >> wrote: >>> >>> >>> >>> On 04/30/2016 12:54 PM, Tom Herbert wrote: &g

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-04-30 Thread Vijay Pandurangan
On Sat, Apr 30, 2016 at 5:52 PM, Ben Greear wrote: >> >> Good point, so if you had: >> >> eth0 <-> raw <-> user space-bridge <-> raw <-> vethA <-> veth B <-> >> userspace-stub <->eth1 >> >> and user-space hub enabled this elide flag, things would work, right? >> Then, it seems like what we need is

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-02-11 Thread Vijay Khemka
On 2/10/19, 9:22 PM, "Andrew Jeffery" wrote: On Fri, 25 Jan 2019, at 05:59, Vijay Khemka wrote: > > > On 1/24/19, 12:16 AM, "Greg Kroah-Hartman" wrote: > > On Wed, Jan 23, 2019 at 03:06:34PM -0800, Vijay Khemka wrote:

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-18 Thread Vijay Khemka
Hi Joel, Can you please apply this patch as " Documentation/devicetree/bindings/mfd/aspeed-lpc.txt" has already been applied Regards -Vijay On 3/5/19, 4:15 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Joel, Did this patch apply upstream. Somehow I can&

Re: [Potential Spoof] Re: [PATCH] ARM: dts: aspeed: tiogapass: Enable VUART

2019-03-18 Thread Vijay Khemka
Hi Joel, Please apply this patch. Regards -Vijay On 3/5/19, 12:06 PM, "openbmc on behalf of Vijay Khemka" wrote: Please review below patch. Regards -Vijay On 1/30/19, 10:14 AM, "Vijay Khemka" wrote: Enabling vuart fo

Re: [PATCH] net/ncsi: Fix the payload copying for the request coming from Netlink

2019-08-22 Thread Vijay Khemka
request is coming from Netlink. Signed-off-by: Justin Lee Reviewed-by: Vijay Khemka --- net/ncsi/ncsi-cmd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index eab4346..0187e65 100644

Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver

2019-08-16 Thread Vijay Khemka
On 8/16/19, 3:20 AM, "openbmc on behalf of John Wang" wrote: Add the driver to monitor Inspur Power System power supplies with hwmon over pmbus. This driver adds sysfs attributes for additional power supply data, including vendor, model, part_number, serial number, fi

Re: [PATCH v2 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-10 Thread Vijay Khemka
incorrect). Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta Reviewed-by: Vijay Khemka --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpi

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfe

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling this > it works perfe

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-10 Thread Vijay Khemka
On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/19 2:37 PM, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with IPV6

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 7:49 AM, "Joel Stanley" wrote: Hi Ben, On Tue, 10 Sep 2019 at 22:05, Florian Fainelli wrote: > > On 9/10/19 2:37 PM, Vijay Khemka wrote: > > HW checksum generation is not working for AST2500, specially with IPV6 > > ove

Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-11 Thread Vijay Khemka
On 9/11/19, 5:16 AM, "Linux-aspeed on behalf of Rashmica Gupta" wrote: Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/g

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:50 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 9/10/19, 3:05 PM, "Florian Fainelli" wrote: On 9/10/

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-09-11 Thread Vijay Khemka
On 9/11/19, 11:34 AM, "Florian Fainelli" wrote: On 9/11/19 11:30 AM, Vijay Khemka wrote: > > > On 9/10/19, 4:08 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: > > > > On 9/10/19, 3:50 PM, "L

[PATCH] net/ncsi: Disable global multicast filter

2019-09-12 Thread Vijay Khemka
then let it disabled for every other types as well. As we are seeing issues with LLDP not working with this enabled filtering. And there are other issues with IPV6. By Disabling this multicast completely, it is working for both IPV6 as well as LLDP. Signed-off-by: Vijay Khemka --- net/ncsi

Re: [PATCH] net/ncsi: Disable global multicast filter

2019-09-16 Thread Vijay Khemka
On 9/15/19, 7:39 PM, "Samuel Mendoza-Jonas" wrote: On Thu, 2019-09-12 at 12:04 -0700, Vijay Khemka wrote: > Disabling multicast filtering from NCSI if it is supported. As it > should not filter any multicast packets. In current code, multicast > filter is

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-17 Thread Vijay Khemka
Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-09-24 Thread Vijay Khemka
Florian/Joel, Can you please look into below patch and let me know who can apply this. Regards -Vijay On 9/17/19, 12:34 PM, "Vijay Khemka" wrote: Please review below patch and provide your valuable feedback. Regards -Vijay On 9/11/19, 1:05 PM, "Vijay

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
On 10/8/19, 9:37 PM, "Benjamin Herrenschmidt" wrote: On Wed, 2019-09-11 at 14:48 +, Joel Stanley wrote: > Hi Ben, > > On Tue, 10 Sep 2019 at 22:05, Florian Fainelli > wrote: > > > > On 9/10/19 2:37 PM, Vijay Khemka wrote:

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-10 Thread Vijay Khemka
Resending this patch again. On 9/11/19, 1:05 PM, "Vijay Khemka" wrote: HW checksum generation is not working for AST2500, specially with IPV6 over NCSI. All TCP packets with IPv6 get dropped. By disabling this it works perfectly fine with IPV6. As it works for IPV4

Re: [PATCH] ftgmac100: Disable HW checksum generation on AST2500

2019-10-11 Thread Vijay Khemka
On 10/10/19, 8:11 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-10 at 19:15 +0000, Vijay Khemka wrote: > Any news on this ? AST2400 has no HW checksum logic in HW, AST2500 > should work for IPV4 fine, we should only selectively disable it fo

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: > HW checksum generation is not working for AST2500, specially with > IPV6 > over NCSI. All TCP packets with IPv6 get dropped. By disabling

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-17 Thread Vijay Khemka
On 10/17/19, 4:15 PM, "Benjamin Herrenschmidt" wrote: On Thu, 2019-10-17 at 22:01 +0000, Vijay Khemka wrote: > > On 10/16/19, 6:29 PM, "Benjamin Herrenschmidt" wrote: > > On Fri, 2019-10-11 at 14:30 -0700, Vijay Khemka wrote: &

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/17/19, 5:33 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 00:06 +0000, Vijay Khemka wrote: > > > This is not a matter of unsupported csum, it is broken hw csum. > > That's why we disable hw checksum. My guess is

Re: [PATCH v2] ftgmac100: Disable HW checksum generation on AST2500

2019-10-18 Thread Vijay Khemka
On 10/18/19, 5:03 PM, "Benjamin Herrenschmidt" wrote: On Fri, 2019-10-18 at 22:50 +0000, Vijay Khemka wrote: > I don't have much understanding of IP Stack but I went through code details and > you are right and found that it should fallback to SW calcula

[PATCH v3] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-29 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-29 Thread Vijay Khemka
Thanks Lee, On 1/29/19, 4:30 AM, "Lee Jones" wrote: On Fri, 18 Jan 2019, Vijay Khemka wrote: > Memory-region and flash phandle is not a required parameter, it is > optional to describe in device tree and needed only use basis. > > Signe

Re: [PATCH] misc: aspeed-lpc-ctrl: make memory-region optional

2019-01-16 Thread Vijay Khemka
Sure Joel, I will do v2 and submit for review today. Regards -Vijay On 1/15/19, 4:11 PM, "Joel Stanley" wrote: Hi Vijay, On Tue, 15 Jan 2019 at 12:51, Vijay Khemka wrote: > > Makiing memory-region as optional parameter in device tree if > user

[PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-16 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 58 +- 1 file changed, 36 insertions(+), 22

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-17 Thread Vijay Khemka
On 1/16/19, 10:17 PM, "Joel Stanley" wrote: On Thu, 17 Jan 2019 at 09:02, Vijay Khemka wrote: > > Makiing memory-region and flash as optional parameter in device > tree if user needs to use these parameter through ioctl then > need t

Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-17 Thread Vijay Khemka
On 1/16/19, 6:49 PM, "Joel Stanley" wrote: On Fri, 21 Dec 2018 at 05:06, Vijay Khemka wrote: > > On 12/17/18, 12:04 PM, "Vijay Khemka" wrote: > > Added lpc ctrl device to enable LPC clock in Facebook > Tiogapass device

[PATCH] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-17 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-14 Thread Vijay Khemka
On 1/13/19, 2:39 PM, "Andrew Jeffery" wrote: Hi Vijay, Sorry for providing an opinion so late, however: On Sat, 12 Jan 2019, at 11:03, Vijay Khemka wrote: > Joel, > Please merge these patches as it is required by facebook platform.

[PATCH] misc: aspeed-lpc-ctrl: make memory-region optional

2019-01-14 Thread Vijay Khemka
Makiing memory-region as optional parameter in device tree if user needs to use memory-region then define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-01-18 Thread Vijay Khemka
Hi Andrew, Thanks for this review, I will have a follow up patch for this return values. Regards -Vijay On 1/17/19, 8:58 PM, "Andrew Jeffery" wrote: Hi Vijay, Thanks for doing the work to fix the driver. Some minor queries/points below. On Thu, 17 Jan 2019

[PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

2019-01-18 Thread Vijay Khemka
Memory-region and flash phandle is not a required parameter, it is optional to describe in device tree and needed only use basis. Signed-off-by: Vijay Khemka --- Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree

[PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-01-23 Thread Vijay Khemka
Corrected some of return values with appropriate meanings. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c index 332210e06e98

[PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook

2019-01-23 Thread Vijay Khemka
Added lpc control for enabling lpc clock, peci for cpu sensors and lpc snoop devices to Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/aspeed

[PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook

2019-01-23 Thread Vijay Khemka
Added uart2 and uart3 in Facebook Tiogapass for routing serial input from Host to BMC for SoL via LPC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-01-24 Thread Vijay Khemka
On 1/24/19, 12:16 AM, "Greg Kroah-Hartman" wrote: On Wed, Jan 23, 2019 at 03:06:34PM -0800, Vijay Khemka wrote: > Corrected some of return values with appropriate meanings. > > Signed-off-by: Vijay Khemka > --- > drivers/mi

Re: [PATCH v2] misc: aspeed-lpc-ctrl: Correct return values

2019-05-06 Thread Vijay Khemka
On 5/5/19, 9:24 PM, "Andrew Jeffery" wrote: On Sat, 4 May 2019, at 03:43, Vijay Khemka wrote: > Corrected some of return values with appropriate meanings and reported > relevant messages as debug information. > > Signed-off-by: Vijay Khemk

Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Vijay Khemka
Let me send both patches. On 4/30/19, 11:45 PM, "Greg Kroah-Hartman" wrote: On Wed, May 01, 2019 at 05:55:07AM +, Joel Stanley wrote: > On Fri, 18 Jan 2019 at 20:12, Vijay Khemka wrote: > > > > Hi Andrew, > > Thanks for this review, I

[PATCH] misc: aspeed-lpc-ctrl: make parameter optional

2019-05-01 Thread Vijay Khemka
Makiing memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 58 +- 1 file changed, 36 insertions(+), 22

[PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-05-01 Thread Vijay Khemka
Corrected some of return values with appropriate meanings. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c index 332210e06e98

Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

2019-05-03 Thread Vijay Khemka
On 5/1/19, 11:49 PM, "Andrew Jeffery" wrote: On Thu, 2 May 2019, at 16:10, Greg Kroah-Hartman wrote: > On Wed, May 01, 2019 at 03:38:36PM -0700, Vijay Khemka wrote: > > Corrected some of return values with appropriate meanings. > >

[PATCH v2] misc: aspeed-lpc-ctrl: Correct return values

2019-05-03 Thread Vijay Khemka
Corrected some of return values with appropriate meanings and reported relevant messages as debug information. Signed-off-by: Vijay Khemka --- drivers/misc/aspeed-lpc-ctrl.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/misc/aspeed-lpc-ctrl.c b

Re: [Potential Spoof] Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-09 Thread Vijay Khemka
On 8/8/19, 3:27 PM, "openbmc on behalf of Tao Ren" wrote: On 8/8/19 2:16 PM, Andrew Lunn wrote: > On Thu, Aug 08, 2019 at 07:02:54PM +, Tao Ren wrote: >> Hi Andrew, >> >> On 8/8/19 6:32 AM, Andrew Lunn wrote: Let me prepare patch v2 using device tree. I'm not

Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device

2019-08-06 Thread Vijay Khemka
Joel, I have added all 3 id in the documentation patch and I am not sure if that patch has been applied or not. Regards -Vijay On 8/1/19, 11:31 PM, "Joel Stanley" wrote: Add pxe1610 as a trivial device On Tue, 23 Jul 2019 at 17:14, Vijay Khemka wrote: &g

Re:[PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset

2019-08-07 Thread Vijay Khemka
Lgtm except one small comment below. On 8/6/19, 5:22 PM, "openbmc on behalf of Tao Ren" wrote: Currently BMC's MAC address is calculated by adding 1 to NCSI NIC's base MAC address when CONFIG_NCSI_OEM_CMD_GET_MAC option is enabled. The logic doesn't work for platforms with differen

Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device

2019-07-23 Thread Vijay Khemka
On 7/23/19, 7:53 AM, "Rob Herring" wrote: On Tue, Jul 23, 2019 at 8:50 AM Rob Herring wrote: > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka wrote: > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > >

Re: [PATCH v2 1/2] hwmon: pmbus: Add Infineon PXE1610 VR driver

2019-06-06 Thread Vijay Khemka
On 6/5/19, 1:47 PM, "Guenter Roeck" wrote: On Thu, May 30, 2019 at 04:11:56PM -0700, Vijay Khemka wrote: > Added pmbus driver for the new device Infineon pxe1610 > voltage regulator. It also supports similar family device > PXE1110 and PXM1310. >

Re: [PATCH v2] soc: aspeed: lpc-ctrl: make parameter optional

2019-06-06 Thread Vijay Khemka
Please update on this patch. On 5/30/19, 1:37 PM, "Vijay Khemka" wrote: Making memory-region and flash as optional parameter in device tree if user needs to use these parameter through ioctl then need to define in devicetree. Signed-off-by: Vijay Khemka R

Re: [PATCH] ARM: dts: aspeed: tiogapass: Enable VUART

2019-03-05 Thread Vijay Khemka
Please review below patch. Regards -Vijay On 1/30/19, 10:14 AM, "Vijay Khemka" wrote: Enabling vuart for Facebook tiogapass Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 5 + 1 file changed, 5 insertions(+)

Re: [Potential Spoof] Re: [PATCH v2] misc: aspeed-lpc-ctrl: make parameter optional

2019-03-05 Thread Vijay Khemka
Joel, Did this patch apply upstream. Somehow I can't find this patch in linux or linux-next or our obmc dev4.19. Regards -Vijay On 1/17/19, 10:53 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 1/16/19, 10:17 PM, "Joel Stanley" wrote:

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-11 Thread Vijay Khemka
Joel, Please merge these patches as it is required by facebook platform. Regards -Vijay On 1/7/19, 11:25 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Please merge these patches in upstream kernel. Regards -Vijay On 12/20/18, 10:06 AM, "Linux-a

Re: [PATCH] ARM: dts: aspeed: Adding Facebook TioagaPass BMC

2018-09-14 Thread Vijay Khemka
Thanks Andrew, I have revised patch as I found some more changes. Sent a new version. Regards -Vijay On 9/13/18, 1:18 PM, "Andrew Lunn" wrote: > +++ b/arch/arm/boot/dts/Makefile > @@ -1206,4 +1206,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-

[PATCH 1/2] ARM: dt-bindings: aspeed: Facebook TiogaPass BMC

2018-09-19 Thread Vijay Khemka
Initial introduction of Facebook TiogaPass family equipped with Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit with a ASPEED ast2500 BMC manufactured by Facebook. This adds an entry of Facebook in Documentation for vendor prefix --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH v2 1/2] ARM: dt-bindings: Add vendor prefix for Facebook

2018-09-19 Thread Vijay Khemka
Initial introduction of Facebook TiogaPass family equipped with Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit with a ASPEED ast2500 BMC manufactured by Facebook. This adds an entry of Facebook in Documentation for vendor prefix Signed-off-by: Vijay Khemka --- Documentation

Re: [PATCH V4 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-01 Thread Vijay Viswanath
On 3/29/2018 4:22 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath wrote: During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay

Re: [PATCH V2 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-03-19 Thread Vijay Viswanath
On 3/7/2018 9:42 PM, Doug Anderson wrote: Hi, On Tue, Mar 6, 2018 at 11:13 PM, Vijay Viswanath wrote: Hi Dough, Jeremy, On 3/3/2018 4:38 AM, Jeremy McNicoll wrote: On 2018-03-02 10:23 AM, Doug Anderson wrote: Hi, On Sun, Feb 11, 2018 at 10:01 PM, Vijay Viswanath wrote: During

Re: [PATCH RFC 1/4] mmc: host: Register changes for sdcc V5

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 1:58 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath wrote: From: Sayali Lokhande For SDCC version 5.0.0, MCI registers are removed from SDCC interface and some registers are moved to HC. This change is to support MCI register removal for msmfalcon. New

Re: [PATCH RFC 2/4] mmc: sdhci-msm: Add and use voltage regulator related APIs

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 2:19 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath wrote: From: Asutosh Das Some platforms require that the voltage switching happen only after the register write occurs and controller is ready for the switch. When the controller is ready, it will inform

[PATCH V5 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-04-20 Thread Vijay Viswanath
v4: Removed unnecessary mb() within sdhci_msm_handle_pwr_irq() since wakeup calls have implicit write barriers. Krishna Konda (1): mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1): mmc: sdhci-msm: Add support to store supported vdd-io voltages drivers/mmc/host/sdhci-ms

[PATCH V5 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-20 Thread Vijay Viswanath
power irq is triggered for io high or io low, the driver should check the voltages supported and set the pad accordingly. Signed-off-by: Krishna Konda Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Vijay Viswanath Reviewed-by: Douglas Anderson --- drivers/mmc/host/sdhci-msm.c | 57

[PATCH V5 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-20 Thread Vijay Viswanath
During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay Viswanath Reviewed-by: Douglas Anderson --- drivers/mmc/host/sdhci-msm.c | 29 - 1

Re: [PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-18 Thread Vijay Viswanath
On 4/13/2018 10:38 PM, Doug Anderson wrote: Hi, On Fri, Apr 6, 2018 at 2:48 AM, Vijay Viswanath wrote: On 3/29/2018 4:23 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath wrote: From: Krishna Konda The PADs for SD card are dual-voltage that support 3v

[PATCH v3 0/4] sparc64: Jump to boot prom from console on panic

2017-02-01 Thread Vijay Kumar
V3 changes: - patch 02/04: Added SERIAL_SUNHV conditional group for sunhv_migrate_hvcons_irq in smp_send_stop(). V2 changes: - Added cover letter patch Hi, Currently Stop-A (L1A) does not make the kernel switch to OBP on panic. This patchset addresses this issue. Also, now we can cause a

[PATCH v3 3/4] sparc64: Send break twice from console to return to boot prom

2017-02-01 Thread Vijay Kumar
Now we can also jump to boot prom from sunhv console by sending break twice on console for both running and panicked kernel cases. Signed-off-by: Vijay Kumar --- drivers/tty/serial/sunhv.c |6 +- kernel/panic.c |3 ++- 2 files changed, 7 insertions(+), 2 deletions

[PATCH v3 1/4] sparc64: Set cpu state to offline when stopped

2017-02-01 Thread Vijay Kumar
CPU needs to be marked offline before stopping it. When not marked offline, the xcall receives HV_EWOULDBLOCK and so assumes that not all CPUs received the message, and retries. After 1 retries, it finally fails with fatal mondo timeout. Signed-off-by: Vijay Kumar --- arch/sparc/kernel

[PATCH v3 4/4] Documentation/sparc: Steps for sending break on sunhv console

2017-02-01 Thread Vijay Kumar
Documented the steps for sending break on sunhv console. Signed-off-by: Vijay Kumar --- Documentation/sparc/console.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/Documentation/sparc/console.txt b/Documentation/sparc/console.txt new file mode 100644 index

[PATCH v3 2/4] sparc64: Migrate hvcons irq to panicked cpu

2017-02-01 Thread Vijay Kumar
On panic, all other CPUs are stopped except the one which had hit panic. To keep console alive, we need to migrate hvcons irq to panicked CPU. Signed-off-by: Vijay Kumar --- v2->v3: Added SERIAL_SUNHV conditional group for sunhv_migrate_hvcons_irq(). --- arch/sparc/include/asm/setu

Re: [PATCH v3 0/4] sparc64: Jump to boot prom from console on panic

2017-02-01 Thread Vijay Kumar
On 2/1/2017 1:50 PM, David Miller wrote: From: Vijay Kumar Date: Wed, 1 Feb 2017 11:34:36 -0800 Currently Stop-A (L1A) does not make the kernel switch to OBP on panic. This is intentional, the kernel prints a message telling the user to press break (L1-A) if they want to drop out of the

[PATCH v2 2/2] Documentation/ABI: Added ABI information for devspec and obppath.

2016-10-06 Thread Vijay Kumar
Updated Documentation/ABI for devspec and obppath sysfs entries. Signed-off-by: Vijay Kumar --- Documentation/ABI/stable/sysfs-devices | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/Documentation/ABI/stable/sysfs-devices b/Documentation/ABI/stable/sysfs

[PATCH v2 1/2] usb/core: Added devspec sysfs entry for devices behind the usb hub

2016-10-06 Thread Vijay Kumar
Grub finds incorrect of_node path for devices behind usb hub. Added devspec sysfs entry for devices behind usb hub so that right of_node path is returned during grub sysfs walk for these devices. Signed-off-by: Vijay Kumar --- drivers/usb/core/sysfs.c | 15 +++ 1 files changed, 15

[PATCH 1/4] sparc64: Set cpu state to offline when stopped

2016-11-10 Thread Vijay Kumar
CPU needs to be marked offline before stopping it. When not marked offline, the xcall receives HV_EWOULDBLOCK and so assumes that not all CPUs received the message, and retries. After 1 retries, it finally fails with fatal mondo timeout. Signed-off-by: Vijay Kumar --- arch/sparc/kernel

[PATCH 4/4] Documentation/sparc: Steps for sending break on sunhv console

2016-11-10 Thread Vijay Kumar
Documented the steps for sending break on sunhv console. Signed-off-by: Vijay Kumar --- Documentation/sparc/console.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/Documentation/sparc/console.txt b/Documentation/sparc/console.txt new file mode 100644 index

[PATCH 3/4] sparc64: Send break twice from console to return to boot prom

2016-11-10 Thread Vijay Kumar
Now we can also jump to boot prom from sunhv console by sending break twice on console for both running and panicked kernel cases. Signed-off-by: Vijay Kumar --- drivers/tty/serial/sunhv.c |6 +- kernel/panic.c |3 ++- 2 files changed, 7 insertions(+), 2 deletions

[PATCH 2/4] sparc64: Migrate hvcons irq to panicked cpu

2016-11-10 Thread Vijay Kumar
On panic, all other CPUs are stopped except the one which had hit panic. To keep console alive, we need to migrate hvcons irq to panicked CPU. Signed-off-by: Vijay Kumar --- arch/sparc/include/asm/setup.h |1 + arch/sparc/kernel/smp_64.c |6 +- drivers/tty/serial/sunhv.c

[PATCH 0/4] sparc64: Jump to boot prom from console on panic

2016-11-11 Thread Vijay Kumar
Here is the cover posting for the patches. I did not send cover patch initially as I thought that patch descriptions were self explanatory. But I agree, this would help in overall understanding of the patch. Currently Stop-A (L1A) does not make the kernel switch to OBP on panic. This patchset a

[PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu

2016-11-11 Thread Vijay Kumar
On panic, all other CPUs are stopped except the one which had hit panic. To keep console alive, we need to migrate hvcons irq to panicked CPU. Signed-off-by: Vijay Kumar --- arch/sparc/include/asm/setup.h |1 + arch/sparc/kernel/smp_64.c |6 +- drivers/tty/serial/sunhv.c

[PATCH v2 4/4] Documentation/sparc: Steps for sending break on sunhv console

2016-11-11 Thread Vijay Kumar
Documented the steps for sending break on sunhv console. Signed-off-by: Vijay Kumar --- Documentation/sparc/console.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/Documentation/sparc/console.txt b/Documentation/sparc/console.txt new file mode 100644 index

[PATCH v2 1/4] sparc64: Set cpu state to offline when stopped

2016-11-11 Thread Vijay Kumar
CPU needs to be marked offline before stopping it. When not marked offline, the xcall receives HV_EWOULDBLOCK and so assumes that not all CPUs received the message, and retries. After 1 retries, it finally fails with fatal mondo timeout. Signed-off-by: Vijay Kumar --- arch/sparc/kernel

[PATCH v2 0/4] sparc64: Jump to boot prom from console on panic

2016-11-11 Thread Vijay Kumar
Currently Stop-A (L1A) does not make the kernel switch to OBP on panic. This patchset addresses this issue. Also, now we can cause a jump to OBP by sending 'break' twice from sunhv console. On bare metal, one can send a break by typing Esc + 'B' + Sysrq (or whatever). On LDOM, press Ctrl + ] in tel

[PATCH v2 3/4] sparc64: Send break twice from console to return to boot prom

2016-11-11 Thread Vijay Kumar
Now we can also jump to boot prom from sunhv console by sending break twice on console for both running and panicked kernel cases. Signed-off-by: Vijay Kumar --- drivers/tty/serial/sunhv.c |6 +- kernel/panic.c |3 ++- 2 files changed, 7 insertions(+), 2 deletions

Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu

2016-11-28 Thread Vijay Kumar
On 11/19/2016 9:48 AM, David Miller wrote: From: Vijay Kumar Date: Fri, 11 Nov 2016 10:11:57 -0800 @@ -1444,8 +1444,12 @@ void smp_send_stop(void) int cpu; if (tlb_type == hypervisor) { + int this_cpu = smp_processor_id

Re: [PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-02-11 Thread Vijay Pandurangan
Just as a followup, I wrote a short blog detailing the bug and our resolution: (https://twitter.com/vijayp/status/697837808417779716) Thanks again for your help in guiding us through our first kernel patch. This was a great experience! direct link: https://medium.com/vijay-pandurangan/linux

[PATCH] tty/serial: Skip 'NULL' char after console break when sysrq enabled

2015-12-23 Thread Vijay Kumar
ked. This fix skips calling uart sysrq handler when 'NULL' is received while sysrq is enabled. Signed-off-by: Vijay Kumar Acked-by: Karl Volz --- drivers/tty/serial/sunhv.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/sunhv.c b/driver

[PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Co-authored-by: Evan Jones Signed-off-by: Evan Jones Cc: Nicolas Dichtel Cc: Phil Sutter Cc: Toshiaki Makita Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Vijay Pandurangan --- drivers/net/veth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/v

[PATCH] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
Co-authored-by: Evan Jones Signed-off-by: Evan Jones Cc: Nicolas Dichtel Cc: Phil Sutter Cc: Toshiaki Makita Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Vijay Pandurangan --- drivers/net/veth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/v

Re: [PATCH] veth: don't modify ip-summed; doing so treats packets with bad checksums as good.

2015-12-18 Thread Vijay Pandurangan
through the TX path again to see if we missed something, but I'd love input from anyone else! -- Vijay Pandurangan https://www.twitter.com/vijayp http://www.vijayp.ca On Fri, Dec 18, 2015 at 2:00 PM, Cong Wang wrote: > (Cc'ing Eric B and Tom) > > On Fri, Dec 18, 2015 at

Re: [PATCH][RFC] kdump: append kernel build-id string to VMCOREINFO

2020-06-10 Thread Vijay Balakrishna
Thanks Baoquan. See inline. On 6/9/2020 7:20 PM, Baoquan He wrote: On 06/04/20 at 05:01pm, Vijay Balakrishna wrote: Make kernel GNU build-id available in VMCOREINFO. Having build-id in VMCOREINFO facilitates presenting appropriate kernel namelist image with debug information file to kernel

[PATCH v2][RFC] kdump: append kernel build-id string to VMCOREINFO

2020-06-10 Thread Vijay Balakrishna
methods for file types such as user mode crash dumps, shared libraries, loadable kernel modules etc., This is an exception for linux kernel dump. Having build-id in VMCOREINFO brings some uniformity for automation tools. Signed-off-by: Vijay Balakrishna --- Changes since v2: - - v1 was

Re: [v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-30 Thread Vijay Balakrishna
On 9/30/2020 11:20 AM, Mike Kravetz wrote: On 9/29/20 9:49 AM, Vijay Balakrishna wrote: When memory is hotplug added or removed the min_free_kbytes should be recalculated based on what is expected by khugepaged. Currently after hotplug, min_free_kbytes will be set to a lower default and

[v5] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged

2020-09-29 Thread Vijay Balakrishna
for THP consumers. Fixes: f000565adb77 ("thp: set recommended min free kbytes") Signed-off-by: Vijay Balakrishna Cc: sta...@vger.kernel.org Reviewed-by: Pavel Tatashin Acked-by: Michal Hocko --- v4 -> v5 - changelog: must -> should [Michal Hocko] v3 -> v4 - m

<    1   2   3   4   5   6   7   8   9   10   >