Re: [PATCH] I2C: i2c-pxa - remove incorrect __exit annotations

2013-02-21 Thread Wolfram Sang
On Wed, Feb 20, 2013 at 12:50:10AM -0800, Dmitry Torokhov wrote: The remove() methods should not be marked __exit unless we are using platform_driver_probe() which disables unbinding device from driver via sysfs. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Eeks, I broke this

[PULL REQUEST] i2c for 3.9

2013-02-25 Thread Wolfram Sang
: Remove err_cpufreq label Wolfram Sang (1): i2c: nomadik: drop superfluous variable initialization .../devicetree/bindings/i2c/brcm,bcm2835-i2c.txt | 20 + .../devicetree/bindings/i2c/i2c-s3c2410.txt|2 + Documentation/i2c/busses/i2c-i801 |2

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-20 Thread Wolfram Sang
On Wed, Sep 19, 2012 at 11:08:13PM +0300, Aaro Koskinen wrote: On Fri, Sep 14, 2012 at 12:08:06PM +0200, Wolfram Sang wrote: On Mon, Sep 03, 2012 at 11:23:22PM +0300, Aaro Koskinen wrote: Add i2c driver to enable access to devices behind CBUS on Nokia Internet Tablets. The patch

Re: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver

2012-09-11 Thread Wolfram Sang
patches from Ludovic in 3.7-final? Yes. I'd need your ack since it touches mach-specific stuff. Reviewed-by would be even better since you know the HW better than me :) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH 12/19] i2c-nomadik: Register sub-devices when passed via Device Tree

2012-09-12 Thread Wolfram Sang
(). After this patch, each sub-device can be registered directly from Device Tree instead, removing the requirement for the aforementioned calls from platform code. CC: linux-...@vger.kernel.org CC: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Lee Jones lee.jo...@linaro.org The patch

[PATCH] MAINTAINERS: fix tree for current i2c-embedded development

2012-09-12 Thread Wolfram Sang
Guide people to where their patches can be found these days. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fdc0119..53cc13c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: i2c:clk: preparation for switch to common clock framework

2012-09-13 Thread Wolfram Sang
...@ti.com Subject had i2c:clk where i2c: davinci would be more precise. Fixed that and pushed to -next. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-13 Thread Wolfram Sang
much like I2C, neither. There is no ACK/NACK/START/STOP, so I wonder if it should be in i2c after all... Jean, maybe you want to have a glimpse on this as well? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 12/19] i2c-nomadik: Register sub-devices when passed via Device Tree

2012-09-14 Thread Wolfram Sang
] in another series to scan the child nodes. That's all the infos I got. Some more context would have been helpful. Is there a branch somewhere with all the things collected? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 12/19] i2c-nomadik: Register sub-devices when passed via Device Tree

2012-09-14 Thread Wolfram Sang
reason to have those go via arm-soc (like prevented build-failures or easier merges), if I missed such a reason, please let me know. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH 1/4] i2c: introduce i2c-cbus driver

2012-09-14 Thread Wolfram Sang
); +MODULE_AUTHOR(Juha Yrjölä); +MODULE_AUTHOR(David Weinehall); +MODULE_AUTHOR(Mikko Ylinen); +MODULE_AUTHOR(Felipe Balbi); +MODULE_AUTHOR(Aaro Koskinen aaro.koski...@iki.fi); +MODULE_LICENSE(GPL); So much for now. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 12/19] i2c-nomadik: Register sub-devices when passed via Device Tree

2012-09-14 Thread Wolfram Sang
reference to. It makes reviewing a lot easier if the documentation what is supposed to be coded and the actual code are in one place. It also prevents what happened in this case where the documentation never showed up on the i2c-list. -- Pengutronix e.K. | Wolfram Sang

[PULL REQUEST] i2c-embedded for 3.6

2012-09-14 Thread Wolfram Sang
) Roland Stigge (2): i2c: pnx: Fix bit definitions i2c: pnx: Fix read transactions of = 2 bytes Thomas Kavanagh (1): i2c: algo: pca: Fix mode selection for PCA9665 Wolfram Sang (2): i2c: mxs: correctly setup

[PULL REQUEST] i2c-embedded for 3.6

2012-07-28 Thread Wolfram Sang
): i2c-nomadik: Add 10-bit addressing support Wolfram Sang (4): devicetree: bindings: gpio-i2c belongs to i2c not gpio i2c: imx: make bitrate an u32 type i2c: mv64: remove EXPERIMENTAL tag Revert i2c: tegra: convert normal suspend/resume to *_noirq .../{gpio

Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver

2012-08-31 Thread Wolfram Sang
(np, pdata); + } + if (!pdata) /* No i2c configuration found, using the default. */ pdata = u8500_i2c; -- 1.7.9.5 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH 3/3] i2c: nomadik: Add Device Tree support to the Nomadik I2C driver

2012-09-03 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions

2012-09-04 Thread Wolfram Sang
On Mon, Sep 03, 2012 at 10:16:22PM +0200, Roland Stigge wrote: Hi Wolfram, On 20/08/12 19:55, Wolfram Sang wrote: I've never had my hands on a PNX4008 chip at NXP, but I do believe they are the same IP. That specific I2C IP was used in a number of NXP/Phillips chips besides the PNX4008

Re: [PATCH 0/4] i2c: tegra: required clock support for controller

2012-08-16 Thread Wolfram Sang
, but since the I2C driver patch is pretty trivial, and pretty much has to go through the Tegra tree due to dependencies on other Tegra patches, I went ahead and applied this series to Tegra's for-3.7/clock branch. For the I2C subsystem: Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K

[PULL REQUEST] i2c-embedded for 3.6-rc

2012-08-22 Thread Wolfram Sang
/i2c-tegra.c |2 +- 4 files changed, 21 insertions(+), 12 deletions(-) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 1/1 v4] i2c: Add default configuration into the Nomadik I2C driver.

2012-08-17 Thread Wolfram Sang
I2C driver Wolfram are you taking this v4 patch into the i2c tree for the -rc:s? Right now this is causing boot regressions so we need it badly... I am collecting patches for rc3 this weekend. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux

Re: [PATCH] i2c: tegra: Fix ifdefs for suspend mode

2012-08-18 Thread Wolfram Sang
*i2c_dev = dev_get_drvdata(dev); -- 1.7.1.1 Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 1/1 v4] i2c: Add default configuration into the Nomadik I2C driver.

2012-08-18 Thread Wolfram Sang
! I added a note from Linus that it is needed because of boot regressions. That is also useful in commit messages. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description

Re: [PATCH] i2c-i801: Add device tree support

2012-08-18 Thread Wolfram Sang
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions

2012-08-18 Thread Wolfram Sang
seem to be not easily available, can you please check? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH RESEND 2/2] i2c: pnx: Fix read transactions of = 2 bytes

2012-08-18 Thread Wolfram Sang
and LPC32xx (and LPC31xx, not yet in mainline). Can you please test? Thanks in advance! I assume you checked this on LPC32xx? I'll wait a bit more but tend to take the patch anyhow, even if there is no explicit ACK from PNX. -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] i2c: tegra: Fix ifdefs for suspend mode

2012-08-18 Thread Wolfram Sang
On Sat, Aug 18, 2012 at 01:01:38PM +0100, Mark Brown wrote: On Sat, Aug 18, 2012 at 09:07:32AM +0200, Wolfram Sang wrote: On Mon, Jul 30, 2012 at 07:03:07PM +0530, Laxman Dewangan wrote: CONFIG_PM covers runtime only PM. I am a bit confused by this description. CONFIG_PM_RUNTIME covers

Re: [PATCH] i2c-i801: Add device tree support

2012-08-18 Thread Wolfram Sang
On Sat, Aug 18, 2012 at 01:17:45PM +0200, Thierry Reding wrote: On Sat, Aug 18, 2012 at 11:48:46AM +0200, Wolfram Sang wrote: On Wed, Aug 08, 2012 at 09:06:47AM +0200, Thierry Reding wrote: This commit adds support for probing slave devices parsed from the device tree. Signed-off

Re: [PATCH REBASE 1/2] i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20

2012-08-18 Thread Wolfram Sang
), Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH REBASE 1/2] i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20

2012-08-18 Thread Wolfram Sang
shifted, otherwise it is not a new code. It used to be -div_clk and now it is -clk? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH V2] i2c: tegra: protect suspend/resume callbacks with CONFIG_PM_SLEEP

2012-08-18 Thread Wolfram Sang
if only runtime PM is enabled. Hence protecting sleep callbacks with CONFIG_PM_SLEEP. Signed-off-by: Laxman Dewangan ldewan...@nvidia.com Applied to -current, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH REBASE 2/2] i2c: tegra: dynamically control fast clk

2012-08-18 Thread Wolfram Sang
; If that is fixed, you can add Reviewed-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] i2c-i801: Add device tree support

2012-08-18 Thread Wolfram Sang
device tree nodes. Do you intend to send a dts file mainline which needs the patch you sent? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description

Re: [PATCH V2 1/2] i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20

2012-08-19 Thread Wolfram Sang
tree to avoid conflicts. Looks good to me regarding the I2C part: Reviewed-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description

Re: [PATCH RESEND 1/2] i2c: pnx: Fix bit definitions

2012-08-20 Thread Wolfram Sang
-marketing reference material for that part (including the user manual). Thanks for the heads up. I'll apply both patches, then. Roland, this looks like 3.6-material? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH] i2c-i801: Add device tree support

2012-08-21 Thread Wolfram Sang
On Wed, Aug 08, 2012 at 09:06:47AM +0200, Thierry Reding wrote: This commit adds support for probing slave devices parsed from the device tree. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de Acked-by: Wolfram Sang w.s...@pengutronix.de Jean, this one is for you, I guess

Re: [PATCH V3 0/3] i2c-nomadik changes

2012-07-09 Thread Wolfram Sang
with this version, Wolfram if it looks OK to you, can you please merge this into the I2C tree? Done now, thanks. Is the latest version of Lee's patches for DT sent on 20/06 suitable to go on top of that? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] i2c_dw: deadlock happening when system is trying to suspend

2012-07-09 Thread Wolfram Sang
); INIT_COMPLETION(dev-cmd_complete); dev-msgs = msgs; Don't you need to place the mutex_unlock() before pm_runtime_put then? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: linux-next: manual merge of the arm-soc tree with the i2c-embedded tree

2012-07-10 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH V2 1/5] i2c: tegra: remove unused member variable

2012-07-12 Thread Wolfram Sang
-off-by: Laxman Dewangan ldewan...@nvidia.com Applied to next, thanks. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 2/5] i2c: tegra: use clk_disable_unprepare in place of clk_disable

2012-07-12 Thread Wolfram Sang
, as per the previous discussion, I applied it to my next-branch. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 3/5] i2c: tegra: use of_match_ptr() for match_table initialization

2012-07-12 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 4/5] i2c: tegra: Use struct dev_pm_ops for power management

2012-07-12 Thread Wolfram Sang
); struct tegra_i2c_dev *i2c_dev = platform_get_drvdata(pdev); I like Rafael's patch better because of dev_get_drvdata. I'll pick his and add your 5/5 on top of that. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH 0/7] PM / I2C: Convert platform I2C drivers to PM handling based on struct dev_pm_ops

2012-07-12 Thread Wolfram Sang
I have other patches in the pile and I'd like to see the conflicts myself. Is that okay? They'd be in linux-next tomorrow. Or is there a dependency I missed? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq

2012-07-12 Thread Wolfram Sang
of Rafael's patches. Please have a look if I did the fixup right. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq

2012-07-12 Thread Wolfram Sang
Can you please point me your git path so that I can verify it? git://git.pengutronix.de/git/wsa/linux.git i2c-embedded/for-next or http://git.pengutronix.de/?p=wsa/linux.git;a=shortlog;h=refs/heads/i2c-embedded/for-next -- Pengutronix e.K. | Wolfram Sang

Re: linux-next: manual merge of the arm-soc tree with the i2c-embedded tree

2012-07-12 Thread Wolfram Sang
= __devexit_p(nmk_i2c_remove), +.remove = nmk_i2c_remove, }; static int __init nmk_i2c_init(void) -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital

Re: [PATCH 5/5] i2c: tegra: convert normal suspend/resume to *_noirq

2012-07-24 Thread Wolfram Sang
to request reverting it. I will drop it from my tree and exclude it from my pull request. Please resend if it should go in later. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: [PATCH RFC] misc/at24: distinguish between eeprom and fram chips

2012-12-05 Thread Wolfram Sang
a glimpse, will apply it later. No one knows all chips out there. For the fm24c04 I use page_size != chip_size. It does not buffer but it has two pages, 256 bytes each. Yup, it uses two I2C adresses... Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH v3 2/5] mfd: add viperboard driver

2012-11-20 Thread Wolfram Sang
name? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

[PULL REQUEST] i2c-embedded for 3.7

2012-11-23 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] add hardware I2C support for ARM IMX23

2012-11-28 Thread Wolfram Sang
problems reported when using i2cdetect... -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] add hardware I2C support for ARM IMX23

2012-11-28 Thread Wolfram Sang
'i2cdetect -r ...' would be more interesting to see communication with slaves happening :) Also, what kernel did you test? Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH] add hardware I2C support for ARM IMX23

2012-11-28 Thread Wolfram Sang
might want to try my for-next branch or wait for 3.8-rc1, maybe the DMA termination patch helps? Also enabling I2C debug messages is probably worth it. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions

Re: [PATCH] driver i2c-nforce2: fix pointer CodingStyle issues

2012-12-18 Thread Wolfram Sang
i have planned fixing these too, do you prefer one patch fixing all or multiple patches (one per error/warning type )? One patch, definately. You can skip the 80 char thing. Are you also able to build-test the changes? -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH] driver i2c-nforce2: fix pointer CodingStyle issues

2012-12-18 Thread Wolfram Sang
of us. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH] at24: make module parameters changeable via sysfs

2012-12-18 Thread Wolfram Sang
I reviewed this patch 3 months ago and did not hear back. Are you going to update this patch and resubmit, or should I just drop it? Uwe is on holiday. I'll take care about it if the need is still there... -- Pengutronix e.K. | Wolfram Sang

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

2012-12-18 Thread Wolfram Sang
-- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

[PULL REQUEST] i2c-embedded for 3.8

2012-12-18 Thread Wolfram Sang
(1): i2c: ocores: Use devm_request_and_ioremap() Tomasz Figa (1): i2c: s3c2410: Add support for pinctrl Wolfram Sang (2): i2c: rcar: fix section mismatch i2c: omap: don't save a value only needed for read-clearing .../devicetree/bindings/i2c/i2c-cbus-gpio.txt | 27

[PULL REQUEST] i2c for 3.8

2012-12-22 Thread Wolfram Sang
. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
variable in the case of timeout. Looking at the patch context, such code comes later. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

2012-11-15 Thread Wolfram Sang
On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote: On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote: - if (timeout 0) { - dev_err(dev-adev-dev, - wait_for_completion_timeout - returned %d

Re: [PATCH] gpio: gpio-max710x: Support device tree probing

2012-11-15 Thread Wolfram Sang
configuration, top? Besides that: Acked-by: Wolfram Sang w.s...@pengutronix.de -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver

2012-11-16 Thread Wolfram Sang
Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Cc: Wolfram Sang w.s...@pengutronix.de Mostly good, but the devicetree binding description is missing. Please add a proper file with the same name as the driver to Documentation/devicetree

Re: [PATCH v6 0/2] i2c: i2c-ocores: Add support for sparc, custom set and get functions, and the GRLIB port of the controller

2012-11-16 Thread Wolfram Sang
to Peter as well. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v4 1/4] i2c: introduce i2c-cbus-gpio driver

2012-11-19 Thread Wolfram Sang
Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi Applied to for-next, thanks! -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Wolfram Sang
want to create implicit knowledge here. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature

Re: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation

2013-01-15 Thread Wolfram Sang
in doing that but my resources don't allow me to even think about it at the moment, sadly. Regards, Wolfram [1] http://lkml.org/lkml/2011/10/24/278 -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http

Re: [PATCH] drivers: i2c-nforce2: fix coding style issues

2013-01-10 Thread Wolfram Sang
Wolfram, it would be great if you could update your tree to avoid that kind of issue. Done now. Sorry for the inconvenience. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

Re: [PATCH] i2c: Fix Kontron PLD prescaler calculation

2013-08-05 Thread Wolfram Sang
On Fri, Jul 26, 2013 at 02:04:55PM +0200, Michael Brunner wrote: Add some necessary braces that have been removed during driver cleanup. This fixes the I2C prescaler calculation. Signed-off-by: Michael Brunner michael.brun...@kontron.com Applied to for-current, thanks! signature.asc

Re: [PATCH] i2c: add sanity check to i2c_put_adapter

2013-08-05 Thread Wolfram Sang
about using WARN for the NULL case to point out the ref-counting imbalance? Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Wolfram Sang w...@the-dreams.de Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/i2c/i2c-core.c |3 ++- 1

Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-08-05 Thread Wolfram Sang
Would it make sense to add generic I2C device tree properties for those parameters? These parameters are independent of the actual bus driver, rather a PCB property... And as such the correct place would be device tree or ACPI or similar. If there are other bus drivers that make use

Re: [PATCH] i2c: add sanity check to i2c_put_adapter

2013-08-05 Thread Wolfram Sang
On Mon, Aug 05, 2013 at 11:31:42AM +0200, Sebastian Hesselbarth wrote: On 08/05/13 11:00, Wolfram Sang wrote: On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote: i2c_put_adapter dereferences i2c_adapter pointer passed without check for NULL. This adds a check for non-NULL

Re: [PATCH] i2c-designware: Manually set RESTART bit between messages

2013-08-07 Thread Wolfram Sang
On Fri, Jun 21, 2013 at 03:05:28PM +0800, Chew Chiau Ee wrote: From: Chew, Chiau Ee chiau.ee.c...@intel.com If both IC_EMPTYFIFO_HOLD_MASTER_EN and IC_RESTART_EN are set to 1, the Designware I2C controller doesn't generate RESTART unless user specifically requests it by setting RESTART bit

Re: [PATCH] i2c: mv64xxx: Document the newly introduced allwinner compatible

2013-08-07 Thread Wolfram Sang
On Wed, Jul 24, 2013 at 09:14:35AM +0200, Maxime Ripard wrote: Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com Applied to for-current, thanks! And please, always send to the I2C list. I work heavily with patchwork monitoring the I2C list; everything not there will easily be

Re: [PATCH] i2c: add sanity check to i2c_put_adapter

2013-08-07 Thread Wolfram Sang
On Thu, Aug 01, 2013 at 02:10:46PM +0200, Sebastian Hesselbarth wrote: i2c_put_adapter dereferences i2c_adapter pointer passed without check for NULL. This adds a check for non-NULL pointer to allow i2c_put_adapter called with NULL and behave the same way i2c_release_client does already.

Re: [PATCH v2 1/1 resend] i2c: rcar: modify I2C driver

2013-08-07 Thread Wolfram Sang
On Mon, Aug 05, 2013 at 04:19:34PM +0900, Nguyen Viet Dung wrote: This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2. Signed-off-by: Nguyen Viet Dung nv-d...@jinso.co.jp Isn't it possible to distinguish between H1 and H2 somewhere in hardware? Then we could skip the

Re: [PATCH 02/12] drivers/i2c/busses: don't use devm_pinctrl_get_select_default() in probe

2013-08-07 Thread Wolfram Sang
On Wed, Jul 10, 2013 at 04:57:37PM +0100, Wolfram Sang wrote: Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Compile tested only. Acked-by: Linus Walleij linus.wall...@linaro.org (personally at LCE13

Re: [PATCH 06/27] drivers/i2c/busses: don't check resource with devm_ioremap_resource

2013-08-07 Thread Wolfram Sang
On Tue, Jul 23, 2013 at 08:01:39PM +0200, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Applied to for-next, thanks! signature.asc Description: Digital signature

Re: [PATCH v2] i2c: move ACPI helpers into the core

2013-08-23 Thread Wolfram Sang
On Wed, Aug 21, 2013 at 05:28:23PM +0300, Mika Westerberg wrote: This follows what has already been done for the DeviceTree helpers. Move the ACPI helpers from drivers/acpi/acpi_i2c.c to the I2C core and update documentation accordingly. This also solves a problem reported by Jerry

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-23 Thread Wolfram Sang
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular dependency between the helpers and the core, and so we can finally register child

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Wolfram Sang
On Fri, Aug 23, 2013 at 02:38:20PM -0400, Vivien Didelot wrote: This patch moves the at24.h header from include/linux/i2c to include/linux/platform_data and updates existing support accordingly. This message explains what the patch does but not why the change is wanted. I'd be surprised if we

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Wolfram Sang
This message explains what the patch does but not why the change is wanted. I'd be surprised if we really want *all* platform_data in one single directory? IMHO it makes sense. Why wouldn't we want all platform_data in include/linux/platform_data/? For the same reason we don't want all

Re: [PATCH v5] gpio: pcf857x: Add OF support

2013-08-27 Thread Wolfram Sang
The driver should support the same chip models reardless of whether it's used with or without DT. If an entry in the OF table has no corresponding entry in the I2C table I would consider that as a driver bug. Linus Walleij posted a patch to support DT only probing, but too many side-effects

Re: [PATCH v3 1/1 resend] i2c: rcar: modify I2C driver

2013-08-28 Thread Wolfram Sang
On Tue, Aug 27, 2013 at 04:55:22PM +0900, Nguyen Viet Dung wrote: This patch modify I2C driver of rcar-H1 to usable on both rcar-H1 and rcar-H2. Signed-off-by: Nguyen Viet Dung nv-d...@jinso.co.jp Yes, this is much better. Only minor things... + switch (priv-devtype) { + default:

Re: [PATCH v2 2/2] i2c-designware: get SDA hold time, HCNT and LCNT configuration from ACPI

2013-08-28 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 03:07:54PM +0300, Mika Westerberg wrote: Some Intel LPSS I2C devices make the SDA hold time and *CNT parameters available via SSCN (standard mode) and FMCN (fast mode) ACPI methods. Implement support for this so that we check whether an ACPI method exists and if it

Re: [PATCH v2 1/2] i2c-designware: make HCNT/LCNT values configurable

2013-08-28 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 03:07:53PM +0300, Mika Westerberg wrote: The DesignWare I2C controller has high count (HCNT) and low count (LCNT) registers for each of the I2C speed modes (standard and fast). These registers are programmed based on the input clock speed in the driver. The current

Re: [RFC PATCH 1/2] i2c: prepare runtime PM support for I2C client devices

2013-08-28 Thread Wolfram Sang
On Tue, Aug 20, 2013 at 05:03:35PM +0300, Mika Westerberg wrote: From: Aaron Lu aaron...@intel.com This patch adds runtime PM support for the I2C bus in a similar way that has been done for PCI bus already. This means that the I2C bus core prepares runtime PM for a client device just before

Re: [PATCH 05/35] i2c: use dev_get_platdata()

2013-08-19 Thread Wolfram Sang
Now it's convincing, thanks! signature.asc Description: Digital signature

Re: [PATCH 04/27] drivers/dma: don't check resource with devm_ioremap_resource

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 02:28:57PM +0530, Vinod Koul wrote: On Tue, Jul 23, 2013 at 08:01:37PM +0200, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Sorry looks

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I mean. Yup, that is fine. I applied the old patch with Acks from Hein and Felipe to -next. Thanks! It looks like TI's i2c-davinci

Re: [PATCH] i2c-omap: always send stop after nack

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 08:57:02AM -0500, Felipe Balbi wrote: On Mon, Aug 19, 2013 at 02:11:23PM +0200, Wolfram Sang wrote: Hi, Which means your original patch starts to make a lot more sense. I wonder is this is really what we should be doing though - breaking out of the loop, I

[PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Sigh, hitting the CC threshold on vger again. So resending to the lists only. BTW this patch is based on -rc4 and was tested on an AT91 board. More tests very welcome. Thanks! Documentation/acpi

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6: Argh, did not drop the MPC patch before rebasing :( So either pick the patch i2c: powermac: fix return path on error before, pull the branch [1], or force me to resend ;) Thanks! [1]

Re: [PATCH RESEND] i2c: move of helpers into the core

2013-08-19 Thread Wolfram Sang
On Mon, Aug 19, 2013 at 09:46:04PM +0200, Thierry Reding wrote: On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: [...] diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c [...] +#if IS_ENABLED(CONFIG_OF) +static void of_i2c_register_devices(struct i2c_adapter *adap

Re: [PATCH] i2c: move of helpers into the core

2013-08-20 Thread Wolfram Sang
Warren wrote: On 08/19/2013 05:04 PM, Rafael J. Wysocki wrote: On Monday, August 19, 2013 03:19:18 PM Wolfram Sang wrote: I2C of helpers used to live in of_i2c.c but experience (from SPI) shows that it is much cleaner to have this in the core. This also removes a circular

[PATCH V2] i2c: move of helpers into the core

2013-08-21 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Acked-by: Sylwester Nawrocki s.nawro...@amsung.com Acked-by: Rob Herring rob.herr...@calxeda.com Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Wolfram Sang w...@the-dreams.de --- V1 - V2

[PATCH V3] i2c: move of helpers into the core

2013-08-22 Thread Wolfram Sang
. So, fix the drivers and documentation, too. Acked-by: Rob Herring rob.herr...@calxeda.com Reviewed-by: Felipe Balbi ba...@ti.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Tested-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de --- V2-V3

Re: [PATCH] i2c: mxs: Better error handling

2013-08-15 Thread Wolfram Sang
On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote: This patch fixes two error handling cases in mxs_i2c_xfer_msg(): - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c-cmd_err will not be set so mxs_i2c_xfer_msg() fails silently. - in DMA mode,

[PATCH] scripts/coccinelle/api: remove devm_request_and_ioremap.cocci

2013-08-15 Thread Wolfram Sang
Use of this function is discouraged in favour of devm_ioremap_resource(). Don't advertise it. Signed-off-by: Wolfram Sang w...@the-dreams.de --- .../coccinelle/api/devm_request_and_ioremap.cocci | 105 1 file changed, 105 deletions(-) delete mode 100644 scripts/coccinelle

Re: [PATCH v10] i2c: exynos5: add High Speed I2C controller driver

2013-08-15 Thread Wolfram Sang
On Mon, Jul 01, 2013 at 12:25:19PM +0200, Tomasz Figa wrote: Hi Naveen, Looks mostly good, but see some comments inline. Ping? signature.asc Description: Digital signature

<    1   2   3   4   5   6   7   8   9   10   >