Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

2016-09-13 Thread jbrunet
On Mon, 2016-09-12 at 13:38 -0700, Kevin Hilman wrote: > Jerome Brunet writes: > > > > > This patch series adds the necessary pins, clocks and device tree > > nodes to > > enable the spifc controller on the GXBB family. I had to add the > > nand pins > > in pintctrl as the pinmux setting left by

Re: [PATCH 14/15] ASoC: meson: add axg sound card DT binding documentation

2018-07-26 Thread jbrunet
On Wed, 2018-07-25 at 13:06 -0600, Rob Herring wrote: > > +- amlogic,aux-devs : List of phandles pointing to auxiliary devices > > +- amlogic,widgets : Please refer to widgets.txt. > > +- amlogic,routing : A list of the connections between audio components. > > audio-routing IIRC Wouldn't it make

Re: [PATCH 3/3] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-07-26 Thread jbrunet
On Sat, 2018-07-21 at 23:34 +0200, Martin Blumenstingl wrote: > On Sat, Jul 21, 2018 at 10:46 PM Jerome Brunet wrote: > > > > On Sat, 2018-07-21 at 22:16 +0200, Martin Blumenstingl wrote: > > > > We could even add ranges instead of table when we know the PLL supports > > > > a well-known continu

Re: [PATCH] ASoC: meson: axg-spdifout: select SND_PCM_IEC958

2018-07-24 Thread jbrunet
On Tue, 2018-07-24 at 11:36 +0200, Arnd Bergmann wrote: > When CONFIG_SND_PCM_IEC958 is disabled, we get a link error for the > new driver: > > sound/soc/meson/axg-spdifout.o: In function `axg_spdifout_hw_params': > axg-spdifout.c:(.text+0x650): undefined reference to > `snd_pcm_create_iec958_cons

Re: [PATCH 14/15] ASoC: meson: add axg sound card DT binding documentation

2018-07-25 Thread jbrunet
On Wed, 2018-07-25 at 13:06 -0600, Rob Herring wrote: > On Tue, Jul 17, 2018 at 05:36:41PM +0200, Jerome Brunet wrote: > > Add the DT binding documentation for axg sound card > > I see Mark already applied, but... It's very recent, no DT using it yet. I can easily have your 3 comments fixed if i

Re: [PATCH 00/14] arm64: dts: meson-axg: add audio support

2018-07-25 Thread jbrunet
On Wed, 2018-07-25 at 21:11 +0200, Martin Blumenstingl wrote: > nit-pick: one patch uses "arm64: dts: meson-axg: s400" in the subject > while other patches that are touching the s400 board aren't > if you have to re-send this series: can you please use the "arm64: > dts: meson-axg: s400:" prefix fo

Re: [PATCH 10/14] arm64: dts: meson-axg: add linein codec

2018-07-25 Thread jbrunet
On Wed, 2018-07-25 at 21:18 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 24, 2018 at 3:09 PM Jerome Brunet wrote: > > > > Add the es7241 analog to digital converter which is fed by the > > lienin jack of the s400 > > > > Signed-off-by: Jerome Brunet > > --- > > arch/arm64/bo

Re: [PATCH 0/4] nvmem: meson: efuse updates

2018-11-12 Thread jbrunet
On Mon, 2018-11-12 at 13:08 +, Srinivas Kandagatla wrote: > > On 30/10/18 10:22, Jerome Brunet wrote: > > The first change of this patchset just adds add error message in case > > of failure. If there is problem with the secure monitor, the > > SM_EFUSE_USER_MAX call will be first one to fail

Re: [PATCH v2 0/4] clk: meson: Add video clocks path

2018-11-13 Thread jbrunet
On Tue, 2018-11-06 at 15:57 +0100, Neil Armstrong wrote: > This patchset is an attempt to handle the Amlogic Meson GX Video clock > in the Common Clock Framework in order to move the video pipeline and > HDMI controller clock management out of the Meson DRM Driver. > > In order : > - Add support t

Re: [PATCH v3 3/3] ARM64: dts: meson-gxl: Add support for the Smartlabs SML-5442TW

2018-11-09 Thread jbrunet
On Thu, 2018-11-08 at 23:43 +0400, Christian Hewitt wrote: > +/* This will enable the bluetooth module */ > +&gpio { > + bt-en { > + gpio-hog; > + gpios = ; > + output-high; > + line-name = "bt-en"; > + }; > +}; Instead of this, i

Re: [PATCH v2] clk: meson-gxbb: set fclk_div3 as CLK_IS_CRITICAL

2018-11-06 Thread jbrunet
On Tue, 2018-11-06 at 10:43 -0800, Stephen Boyd wrote: > Quoting Jerome Brunet (2018-11-05 15:08:20) > > From: Christian Hewitt > > > > On the Khadas VIM2 (GXM) and LePotato (GXL) board there are problems > > with reboot; e.g. a ~60 second delay between issuing reboot and the > > board power cycl

Re: [PATCH v4 0/2] clk: meson-g12a: Add EE clock controller driver

2018-11-08 Thread jbrunet
On Thu, 2018-11-08 at 21:15 +0800, Jian Hu wrote: > Changes since v3 at[4] > -add fixed clocks clk_regmap definition Jian, When replying to the v1 of your clk_ao patchset : https://patchwork.kernel.org/patch/10562563/#22177627 I have explained that I would like to stop taking clock (such as xta

Re: [PATCH 3/3] ARM64: dts: meson-gxl: Add support for the Smartlabs SML-5442TW

2018-11-08 Thread jbrunet
On Thu, 2018-11-08 at 19:33 +0400, Christian Hewitt wrote: > > +&audio { > + status = "okay"; > +}; > + > +&aiu_i2s_dma { > + status = "okay"; > +}; > + > +&i2s_dai { > + status = "okay"; > +}; The audio stuff has not made it's way upstream (yet) please drop this > + > +&cvbs_vdac_po

Re: [PATCH 3/4] Documentation: bindings: Add missing Amlogic SCPI sensor bindings

2018-11-08 Thread jbrunet
On Thu, 2018-11-08 at 16:04 +, Sudeep Holla wrote: > On Thu, Nov 08, 2018 at 02:53:51PM +0100, Jerome Brunet wrote: > > amlogic,meson-gxbb-scpi-sensors is both the driver and DT but is not > > documented. Just add it to amlogic's scpi documentation > > > > Signed-off-by: Jerome Brunet > > ---

Re: [PATCH v2 3/3] ARM64: dts: meson-gxl: Add support for the Smartlabs SML-5442TW

2018-11-08 Thread jbrunet
On Thu, 2018-11-08 at 21:01 +0400, Christian Hewitt wrote: > The Smartlabs SML-5442TW is broadly similar to the P231 reference design > but with the following differences: > > - Yellow and Blue front-panel LEDs are available but disabled > - Red/Green LED is used to signal off/on status > - GPIOX_

Re: [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver

2018-11-02 Thread jbrunet
On Fri, 2018-11-02 at 00:30 +0800, Jianxin Pan wrote: > +struct meson_sclk_div_data mmc_clkc_div_data = { > + .div = { > + .reg_off = SD_EMMC_CLOCK, > + .shift = (0), > + .width = (6), > + }, > + .hi = { > + .reg_off = 0

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-11-05 Thread jbrunet
On Sun, 2018-11-04 at 02:01 +0800, Jianxin Pan wrote: > Hi Jerome, > > Thanks for the review, we really appreciate your time. > > I'm very sorry maybe I don't catch all your meaning very well. > > Please see my comments below. > > On 2018/10/29 3:16, Jerome Brunet wrote: > > On Thu, 2018-10-25

Re: [PATCH v3 1/4] pwm: Add support for Meson PWM Controller

2016-09-06 Thread jbrunet
On Tue, 2016-09-06 at 12:04 +0200, Thierry Reding wrote: > On Tue, Sep 06, 2016 at 11:14:45AM +0200, Neil Armstrong wrote: > > > > On 09/06/2016 11:07 AM, Thierry Reding wrote: > > > > > > On Tue, Sep 06, 2016 at 10:36:49AM +0200, Neil Armstrong wrote: > > > > > > > > Hi Thierry, > > > > > > [.