Re: [RFC PATCH v3.1 00/27] Add support UHS-II for GL9755

2020-12-07 Thread AKASHI Takahiro
Adrian, On Thu, Dec 03, 2020 at 11:55:23AM +0200, Adrian Hunter wrote: > On 1/12/20 5:09 am, AKASHI Takahiro wrote: > > Adrian, > > > > Thank you for your review comments. > > > > On Thu, Nov 26, 2020 at 10:18:55AM +0200, Adrian Hunter wrote: > >>

Re: [RFC PATCH v3.1 22/27] mmc: sdhci-uhs2: add add_host() and others to set up the driver

2020-12-07 Thread AKASHI Takahiro
On Thu, Dec 03, 2020 at 11:42:34AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a UHS-II version of sdhci's add_host/remove_host operation. > > Any sdhci drivers which are capable of handling UHS-II cards must > > call th

Re: [RFC PATCH v3.1 21/27] mmc: sdhci-uhs2: add irq() and others

2020-12-07 Thread AKASHI Takahiro
On Tue, Dec 01, 2020 at 06:46:39PM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a UHS-II version of sdhci's request() operation. > > It handles UHS-II related command interrupts and errors. > > > > Signed-off-by: Ben Chuang

Re: [RFC PATCH v3.1 00/27] Add support UHS-II for GL9755

2020-11-30 Thread AKASHI Takahiro
Adrian, Thank you for your review comments. On Thu, Nov 26, 2020 at 10:18:55AM +0200, Adrian Hunter wrote: > On 25/11/20 9:41 am, AKASHI Takahiro wrote: > > Gentle ping; > > > > On Fri, Nov 06, 2020 at 11:26:59AM +0900, AKASHI Takahiro wrote: > >> This is an interi

Re: [RFC PATCH v3.1 20/27] mmc: sdhci-uhs2: add request() and others

2020-11-30 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:18:44AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a sdhci version of mmc's request operation. > > It covers both UHS-I and UHS-II. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI T

Re: [RFC PATCH v3.1 19/27] mmc: sdhci-uhs2: add set_reg() to initialise the interface

2020-11-30 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:18:26AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a sdhci version of mmc's uhs2_set_reg operation. > > UHS-II interface (related registers) will be initialised here. > > > > Signed-off-by: Ben Chuang

Re: [RFC PATCH v3.1 18/27] mmc: sdhci-uhs2: add clock operations

2020-11-30 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:17:59AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a sdhci version of mmc's uhs2_[enable|disable]_clk operations. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI Takahiro > > --- &

Re: [RFC PATCH v3.1 17/27] mmc: sdhci-uhs2: add detect_init() to detect the interface

2020-11-30 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:17:38AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > Sdhci_uhs2_do_detect_init() is a sdhci version of mmc's uhs2_detect_init > > operation. After detected, the host's UHS-II capabilities will be set up > > here and

Re: [RFC PATCH v3.1 16/27] mmc: sdhci-uhs2: add set_ios()

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:17:11AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a sdhci version of mmc's set_ios operation. > > It covers both UHS-I and UHS-II. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI T

Re: [RFC PATCH v3.1 14/27] mmc: sdhci-uhs2: skip signal_voltage_switch()

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:16:44AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > For UHS2, the signal voltage is supplied by vdd2 which is already 1.8v, > > so no voltage switch required. > > > > Signed-off-by: Ben Chuang > &g

Re: [RFC PATCH v3.1 13/27] mmc: sdhci-uhs2: add set_power() to support vdd2

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:16:27AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This is a UHS-II version of sdhci's set_power operation. > > VDD2, as well as VDD, is handled here. > > > > Signed-off-by: Ben Chuang > &g

Re: [RFC PATCH v3.1 12/27] mmc: sdhci-uhs2: add reset function

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:16:11AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > Sdhci_uhs2_reset() does a UHS-II specific reset operation. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI Takahiro > > --- > &

Re: [RFC PATCH v3.1 09/27] mmc: sdhci: add UHS-II related definitions in headers

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:15:29AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > Add UHS-II related definitions in shdci.h and sdhci-uhs2.h. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI Takahiro > > --- > &g

Re: [RFC PATCH v3.1 08/27] mmc: sdhci: add a kernel configuration for enabling UHS-II support

2020-11-29 Thread AKASHI Takahiro
On Thu, Nov 26, 2020 at 10:14:36AM +0200, Adrian Hunter wrote: > On 6/11/20 4:27 am, AKASHI Takahiro wrote: > > This kernel configuration, CONFIG_MMC_SDHCI_UHS2, will be used > > in the following commits to indicate UHS-II specific code in sdhci > > controllers.

Re: [RFC PATCH v3.1 00/27] Add support UHS-II for GL9755

2020-11-25 Thread AKASHI Takahiro
On Wed, Nov 25, 2020 at 11:43:18AM +0100, Ulf Hansson wrote: > On Wed, 25 Nov 2020 at 08:41, AKASHI Takahiro > wrote: > > > > Gentle ping; > > > > On Fri, Nov 06, 2020 at 11:26:59AM +0900, AKASHI Takahiro wrote: > > > This is an interim snapshot of our next

Re: [RFC PATCH v3.1 00/27] Add support UHS-II for GL9755

2020-11-24 Thread AKASHI Takahiro
Gentle ping; On Fri, Nov 06, 2020 at 11:26:59AM +0900, AKASHI Takahiro wrote: > This is an interim snapshot of our next version, v4, for enabling > UHS-II on MMC/SD. > > It is focused on 'sdhci' side to address Adrian's comments regarding > "modularising" sdhc

[RFC PATCH v3.1 06/27] mmc: core: UHS-II support, generate UHS-II SD command packet

2020-11-05 Thread AKASHI Takahiro
In SD-TRAN protocol, legacy SD commands should be "encapsulated" in SD packets as described in SD specification. Please see section 7.1 and 7.2.1 in "UHS-II Simplified Addendum." Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/core/core.c | 18

[RFC PATCH v3.1 21/27] mmc: sdhci-uhs2: add irq() and others

2020-11-05 Thread AKASHI Takahiro
This is a UHS-II version of sdhci's request() operation. It handles UHS-II related command interrupts and errors. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 247 ++ drivers/mmc/host/sdhci-uhs2.h | 3 + drivers

[RFC PATCH v3.1 13/27] mmc: sdhci-uhs2: add set_power() to support vdd2

2020-11-05 Thread AKASHI Takahiro
This is a UHS-II version of sdhci's set_power operation. VDD2, as well as VDD, is handled here. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 80 +++ drivers/mmc/host/sdhci-uhs2.h | 2 + drivers/mmc/host/sdhci.c

[RFC PATCH v3.1 18/27] mmc: sdhci-uhs2: add clock operations

2020-11-05 Thread AKASHI Takahiro
This is a sdhci version of mmc's uhs2_[enable|disable]_clk operations. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/drivers/mmc/host/sdhci-uhs2.c b/drivers/mmc

[RFC PATCH v3.1 23/27] mmc: sdhci-uhs2: add pre-detect_init hook

2020-11-05 Thread AKASHI Takahiro
From: Ben Chuang This "pre" hook for detect_init(), uhs2_pre_detect_init, will be required to enable UHS-II support, at least, on GL9755. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 3 +++ drivers/mmc/host/sdhci.h | 1 + 2 fil

[RFC PATCH v3.1 11/27] mmc: sdhci-uhs2: dump UHS-II registers

2020-11-05 Thread AKASHI Takahiro
Dump UHS-II specific registers, if available, in sdhci_dumpregs() for informative/debugging use. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 30 ++ drivers/mmc/host/sdhci-uhs2.h | 4 drivers/mmc/host/sdhci.c

[RFC PATCH v3.1 25/27] mmc: sdhci-uhs2: add post-mmc_attach_sd hook

2020-11-05 Thread AKASHI Takahiro
From: Ben Chuang This "post" hook for mmc_attach_sd(), uhs2_post_attach_sd, will be required to enable UHS-II support, at least, on GL9755. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci.h | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[RFC PATCH v3.1 27/27] mmc: sdhci-pci-gli: enable UHS-II mode for GL9755

2020-11-05 Thread AKASHI Takahiro
mode. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/Kconfig | 1 + drivers/mmc/host/sdhci-pci-gli.c | 318 ++- 2 files changed, 318 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig

[RFC PATCH v3.1 20/27] mmc: sdhci-uhs2: add request() and others

2020-11-05 Thread AKASHI Takahiro
This is a sdhci version of mmc's request operation. It covers both UHS-I and UHS-II. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 529 ++ drivers/mmc/host/sdhci.c | 93 +++--- drivers/mmc/host/sdhci.h

[RFC PATCH v3.1 19/27] mmc: sdhci-uhs2: add set_reg() to initialise the interface

2020-11-05 Thread AKASHI Takahiro
This is a sdhci version of mmc's uhs2_set_reg operation. UHS-II interface (related registers) will be initialised here. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 103 ++ 1 file changed, 103 insertions(+) diff

[RFC PATCH v3.1 12/27] mmc: sdhci-uhs2: add reset function

2020-11-05 Thread AKASHI Takahiro
Sdhci_uhs2_reset() does a UHS-II specific reset operation. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 49 +++ drivers/mmc/host/sdhci-uhs2.h | 1 + drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h

[RFC PATCH v3.1 17/27] mmc: sdhci-uhs2: add detect_init() to detect the interface

2020-11-05 Thread AKASHI Takahiro
Sdhci_uhs2_do_detect_init() is a sdhci version of mmc's uhs2_detect_init operation. After detected, the host's UHS-II capabilities will be set up here and interrupts will also be enabled. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 160

[RFC PATCH v3.1 24/27] mmc: core: add post-mmc_attach_sd hook

2020-11-05 Thread AKASHI Takahiro
This "post" hook for mmc_attach_sd() will be required to enable UHS-II support, at least, on GL9755. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/core/sd.c| 6 ++ include/linux/mmc/host.h | 1 + 2 files changed, 7 insertions(+) diff --git a/driver

[RFC PATCH v3.1 26/27] mmc: sdhci-pci: add UHS-II support framework

2020-11-05 Thread AKASHI Takahiro
This patch prepares for adding UHS-II support at a specific UHS-II capable sdhci-pci controller, GL9755 for now. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-pci-core.c | 16 +++- drivers/mmc/host/sdhci-pci.h | 3 +++ 2 files changed, 18

[RFC PATCH v3.1 04/27] mmc: core: UHS-II support, try to select UHS-II interface

2020-11-05 Thread AKASHI Takahiro
From: Ben Chuang The flow of "interface selection and initialization" was a bit modified for UHS-II card. This commit follows the sequence defined in SD specification (Part 1). See section 7.2.3 in "UHS-II Simplified Addendum." Signed-off-by: Ben Chuang Signed-off

[RFC PATCH v3.1 05/27] mmc: core: UHS-II support, skip TMODE setup in some cases

2020-11-05 Thread AKASHI Takahiro
in the next commit.) Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/core/block.c | 7 ++- drivers/mmc/core/sd_ops.c | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 8d3df0be0355

[RFC PATCH v3.1 22/27] mmc: sdhci-uhs2: add add_host() and others to set up the driver

2020-11-05 Thread AKASHI Takahiro
This is a UHS-II version of sdhci's add_host/remove_host operation. Any sdhci drivers which are capable of handling UHS-II cards must call those functions instead of the corresponding sdhci's. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 198

[RFC PATCH v3.1 09/27] mmc: sdhci: add UHS-II related definitions in headers

2020-11-05 Thread AKASHI Takahiro
Add UHS-II related definitions in shdci.h and sdhci-uhs2.h. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.h | 210 ++ drivers/mmc/host/sdhci.h | 73 +++- 2 files changed, 282 insertions(+), 1 deletion

[RFC PATCH v3.1 16/27] mmc: sdhci-uhs2: add set_ios()

2020-11-05 Thread AKASHI Takahiro
This is a sdhci version of mmc's set_ios operation. It covers both UHS-I and UHS-II. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 100 ++ drivers/mmc/host/sdhci-uhs2.h | 1 + drivers/mmc/host/sdhci.c | 40

[RFC PATCH v3.1 15/27] mmc: sdhci-uhs2: add set_timeout()

2020-11-05 Thread AKASHI Takahiro
This is a UHS-II version of sdhci's set_timeout() operation. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 85 +++ drivers/mmc/host/sdhci-uhs2.h | 1 + 2 files changed, 86 insertions(+) diff --git a/drivers/mmc

[RFC PATCH v3.1 14/27] mmc: sdhci-uhs2: skip signal_voltage_switch()

2020-11-05 Thread AKASHI Takahiro
For UHS2, the signal voltage is supplied by vdd2 which is already 1.8v, so no voltage switch required. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/sdhci-uhs2.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/mmc/host

[RFC PATCH v3.1 10/27] mmc: sdhci: add UHS-II module

2020-11-05 Thread AKASHI Takahiro
This patch adds sdhci-uhs2.c as a module for UHS-II support. This is a skelton for further development in this patch series. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-uhs2.c | 46

[RFC PATCH v3.1 08/27] mmc: sdhci: add a kernel configuration for enabling UHS-II support

2020-11-05 Thread AKASHI Takahiro
This kernel configuration, CONFIG_MMC_SDHCI_UHS2, will be used in the following commits to indicate UHS-II specific code in sdhci controllers. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/host/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git

[RFC PATCH v3.1 03/27] mmc: core: UHS-II support, skip set_chip_select()

2020-11-05 Thread AKASHI Takahiro
mmc_set_chip_select() should be called only in UHS-II mode, and not for UHS-II mode. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/core/core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c

[RFC PATCH v3.1 07/27] mmc: core: UHS-II support, set APP_CMD bit if necessary

2020-11-05 Thread AKASHI Takahiro
In UHS-II mode, MMC_APP_CMD command need not to be sent. Instead, APP_CMD bit in a packet should be set. Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/core/sd_ops.c | 9 + drivers/mmc/core/uhs2.c | 4 2 files changed, 13 insertions(+) diff --git

[RFC PATCH v3.1 02/27] mmc: core: UHS-II support, modify power-up sequence

2020-11-05 Thread AKASHI Takahiro
According to Fig. 3-35 in "SD Host Controller Simplified Spec. Ver4.20": - Prepare vdd1, vdd2 and ios.timing for using after/in step (2) - chip_select is not used in UHS-II, used to return to the legacy flow Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- drivers/mmc/c

[RFC PATCH v3.1 01/27] mmc: add UHS-II related definitions in public headers

2020-11-05 Thread AKASHI Takahiro
From: Ben Chuang Add UHS-II support in public headers Signed-off-by: Ben Chuang Signed-off-by: AKASHI Takahiro --- include/linux/mmc/card.h | 1 + include/linux/mmc/core.h | 6 + include/linux/mmc/host.h | 30 + include/linux/mmc/uhs2.h | 268

[RFC PATCH v3.1 00/27] Add support UHS-II for GL9755

2020-11-05 Thread AKASHI Takahiro
- remove flag_uhs2 from mmc_attach_sd() - add function descriptions to EXPORT'ed functions - other minor code optimization Changes in v2 (Jan. 9, 2020) * rebased to v5.5-rc5 AKASHI Takahiro (23): mmc: core: UHS-II support, modify power-up sequence mmc: core: UHS-II support, skip set_chip_select()

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-24 Thread AKASHI Takahiro
Ben, On Fri, Sep 18, 2020 at 06:50:24PM +0800, Ben Chuang wrote: > On Fri, Sep 18, 2020 at 2:38 PM AKASHI Takahiro > wrote: > > > > Adrian, Ben, > > > > Regarding _set_ios() function, > > > > On Fri, Aug 21, 2020 at 05:08:32PM +0300, Adrian Hunter wr

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-24 Thread AKASHI Takahiro
Ben, On Fri, Sep 18, 2020 at 06:27:01PM +0800, Ben Chuang wrote: > On Fri, Sep 18, 2020 at 9:15 AM AKASHI Takahiro > wrote: > > > > Ben, > > > > On Thu, Sep 17, 2020 at 06:12:27PM +0800, Ben Chuang wrote: > > > Hi Takahiro, > > > > > > On

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-24 Thread AKASHI Takahiro
Adrian, This is, hopefully, my last reply to your comments on this patch#12. Regarding _request() and _send_command() (and more), On Fri, Aug 21, 2020 at 05:08:32PM +0300, Adrian Hunter wrote: > On 10/07/20 2:10 pm, Ben Chuang wrote: > > From: Ben Chuang > > > > In this commit, UHS-II related

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-18 Thread AKASHI Takahiro
y, sdhci_uhs2_ops, in order to make UHS-II support as > > a kernel module. > > This array will be initialized only if CONFIG_MMC_SDHCI_UHS2 is enabled > > and when the UHS-II module is loaded. Otherwise, all the functions > > stay void. > > > > Signed-o

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-17 Thread AKASHI Takahiro
Ben, On Thu, Sep 17, 2020 at 06:12:27PM +0800, Ben Chuang wrote: > Hi Takahiro, > > On Thu, Sep 17, 2020 at 1:12 PM AKASHI Takahiro > wrote: > > > > Adrian, Ben, > > > > Regarding _reset() function, > > > > On Fri, Aug 21, 2020 at 05:08:32PM +0300

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-16 Thread AKASHI Takahiro
On Thu, Sep 17, 2020 at 07:52:03AM +0300, Adrian Hunter wrote: > On 17/09/20 5:31 am, AKASHI Takahiro wrote: > > Adrian, > > > > On Wed, Sep 16, 2020 at 01:00:35PM +0300, Adrian Hunter wrote: > >> On 16/09/20 11:05 am, AKASHI Takahiro wrote: > >>> Adria

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-16 Thread AKASHI Takahiro
y, sdhci_uhs2_ops, in order to make UHS-II support as > > a kernel module. > > This array will be initialized only if CONFIG_MMC_SDHCI_UHS2 is enabled > > and when the UHS-II module is loaded. Otherwise, all the functions > > stay void. > > > > Signed-off-by: Ben C

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-16 Thread AKASHI Takahiro
Adrian, On Wed, Sep 16, 2020 at 01:00:35PM +0300, Adrian Hunter wrote: > On 16/09/20 11:05 am, AKASHI Takahiro wrote: > > Adrian, > > > > Your comments are scattered over various functions, and so > > I would like to address them in separate replies. > > >

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-09-16 Thread AKASHI Takahiro
Ben, On Wed, Sep 16, 2020 at 05:42:07PM +0800, Ben Chuang wrote: > On Wed, Sep 16, 2020 at 8:52 AM AKASHI Takahiro > wrote: > > > > On Tue, Sep 15, 2020 at 07:36:14PM +0800, Ben Chuang wrote: > > > Hi Takahiro, > > > > > > On Tue, Sep 15,

Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations

2020-09-16 Thread AKASHI Takahiro
gt; > and when the UHS-II module is loaded. Otherwise, all the functions > > stay void. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI Takahiro > > --- (snip) > > if (intmask & (SDHCI_INT_CARD_INSERT | SDHCI_INT_CARD_R

Re: [RFC PATCH V3 15/21] mmc: sdhci: UHS-II support, modify set_power() to handle vdd2

2020-09-16 Thread AKASHI Takahiro
Adrian, On Wed, Sep 16, 2020 at 09:42:28AM +0300, Adrian Hunter wrote: > On 15/09/20 9:24 am, AKASHI Takahiro wrote: > > Adrain, > > > > On Mon, Sep 14, 2020 at 09:36:02AM +0300, Adrian Hunter wrote: > >> On 14/09/20 8:45 am, AKASHI Takahiro wrote: > >>>

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-09-16 Thread AKASHI Takahiro
On Wed, Sep 16, 2020 at 09:01:20AM +0300, Adrian Hunter wrote: > On 15/09/20 9:03 am, AKASHI Takahiro wrote: > > Ben, Adrian, > > > > On Mon, Sep 14, 2020 at 11:08:14AM +0300, Adrian Hunter wrote: > >> On 14/09/20 9:40 am, AKASHI Takahiro wrote: > >>>

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-09-15 Thread AKASHI Takahiro
On Tue, Sep 15, 2020 at 07:36:14PM +0800, Ben Chuang wrote: > Hi Takahiro, > > On Tue, Sep 15, 2020 at 2:03 PM AKASHI Takahiro > wrote: > > > > Ben, Adrian, > > > > On Mon, Sep 14, 2020 at 11:08:14AM +0300, Adrian Hunter wrote: > > > On 14/09/20 9

Re: [RFC PATCH V3 14/21] mmc: sdhci: UHS-II support, handle vdd2 in case of power-off

2020-09-15 Thread AKASHI Takahiro
On Fri, Aug 21, 2020 at 05:09:55PM +0300, Adrian Hunter wrote: > On 10/07/20 2:11 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > Configure a regulator for VDD2 in case of power-off. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI

Re: [RFC PATCH V3 11/21] mmc: sdhci: UHS-II support, export host operations to core

2020-09-15 Thread AKASHI Takahiro
On Fri, Aug 21, 2020 at 05:05:44PM +0300, Adrian Hunter wrote: > On 10/07/20 2:10 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > Export sdhci-specific UHS-II operations to core. > > > > Signed-off-by: Ben Chuang > > Signed-off-by: AKASHI Takahiro

Re: [RFC PATCH V3 10/21] mmc: sdhci: UHS-II support, dump UHS-II registers

2020-09-15 Thread AKASHI Takahiro
On Fri, Aug 21, 2020 at 05:04:54PM +0300, Adrian Hunter wrote: > On 10/07/20 2:10 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > Dump UHS-II specific registers, if available, in sdhci_dumpregs() > > for informative/debugging use. > > > > Si

Re: [RFC PATCH V3 09/21] mmc: sdhci: add UHS-II related definitions in headers

2020-09-15 Thread AKASHI Takahiro
Adrian, On Fri, Aug 21, 2020 at 05:04:16PM +0300, Adrian Hunter wrote: > On 10/07/20 2:10 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > Add UHS-II related definitions in shdci.h and sdhci-uhs2.h. > > > > Signed-off-by: Ben Chuang &

Re: [RFC PATCH V3 15/21] mmc: sdhci: UHS-II support, modify set_power() to handle vdd2

2020-09-15 Thread AKASHI Takahiro
Adrain, On Mon, Sep 14, 2020 at 09:36:02AM +0300, Adrian Hunter wrote: > On 14/09/20 8:45 am, AKASHI Takahiro wrote: > > Adrian, > > > > On Fri, Aug 21, 2020 at 05:11:18PM +0300, Adrian Hunter wrote: > >> On 10/07/20 2:11 pm, Ben Chuang wrote: > >>&g

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-09-15 Thread AKASHI Takahiro
Ben, Adrian, On Mon, Sep 14, 2020 at 11:08:14AM +0300, Adrian Hunter wrote: > On 14/09/20 9:40 am, AKASHI Takahiro wrote: > > Adrian, > > > > On Fri, Aug 21, 2020 at 05:09:01PM +0300, Adrian Hunter wrote: > >> On 10/07/20 2:11 pm, Ben Chuang wrot

Re: [RFC PATCH V3 13/21] mmc: sdhci: UHS-II support, skip signal_voltage_switch()

2020-09-14 Thread AKASHI Takahiro
Adrian, On Fri, Aug 21, 2020 at 05:09:01PM +0300, Adrian Hunter wrote: > On 10/07/20 2:11 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > sdhci_start_signal_voltage_switch() should be called only in UHS-I mode, > > and not for UHS-II mode. > > > >

Re: [RFC PATCH V3 15/21] mmc: sdhci: UHS-II support, modify set_power() to handle vdd2

2020-09-13 Thread AKASHI Takahiro
Adrian, On Fri, Aug 21, 2020 at 05:11:18PM +0300, Adrian Hunter wrote: > On 10/07/20 2:11 pm, Ben Chuang wrote: > > From: AKASHI Takahiro > > > > VDD2 is used for powering UHS-II interface. > > Modify sdhci_set_power_and_bus_voltage(), sdhci_set_power_noreg() &g

Re: [RFC patch 17/41] tracing: Make stack_trace_print() static and rename it

2019-04-10 Thread AKASHI Takahiro
On Wed, Apr 10, 2019 at 08:47:03AM -0400, Steven Rostedt wrote: > On Wed, 10 Apr 2019 12:28:11 +0200 > Thomas Gleixner wrote: > > > It's only used in the source file where it is defined and it's using the > > stack_trace_ namespace. Rename it to free it up for stack trace related > > functions.

Re: [PATCH v16 06/16] lib: fdt: add a helper function for handling memory range property

2018-12-11 Thread AKASHI, Takahiro
On Tue, Dec 11, 2018 at 10:09:07AM +, James Morse wrote: > Hi Akashi, > > On 11/12/2018 06:17, AKASHI, Takahiro wrote: > > On Fri, Dec 07, 2018 at 10:12:47AM +, James Morse wrote: > >> On 06/12/2018 15:54, Will Deacon wrote: > >>> On Thu, Dec 06, 2

Re: [PATCH v16 16/16] arm64: kexec_file: add kaslr support

2018-12-10 Thread AKASHI Takahiro
On Tue, Dec 11, 2018 at 02:50:02PM +0900, AKASHI Takahiro wrote: > On Fri, Nov 30, 2018 at 01:19:44PM +, Will Deacon wrote: > > On Thu, Nov 15, 2018 at 02:52:55PM +0900, AKASHI Takahiro wrote: > > > Adding "kaslr-seed" to dtb enables triggering kaslr, or

Re: [PATCH v16 06/16] lib: fdt: add a helper function for handling memory range property

2018-12-10 Thread AKASHI, Takahiro
James, On Fri, Dec 07, 2018 at 10:12:47AM +, James Morse wrote: > Hi Akashi, Will, > > On 06/12/2018 15:54, Will Deacon wrote: > > On Thu, Dec 06, 2018 at 08:47:04AM -0600, Rob Herring wrote: > >> On Wed, Nov 14, 2018 at 11:52 PM AKASHI Takahiro > >>

Re: [PATCH v16 16/16] arm64: kexec_file: add kaslr support

2018-12-10 Thread AKASHI Takahiro
On Fri, Nov 30, 2018 at 01:19:44PM +, Will Deacon wrote: > On Thu, Nov 15, 2018 at 02:52:55PM +0900, AKASHI Takahiro wrote: > > Adding "kaslr-seed" to dtb enables triggering kaslr, or kernel virtual > > address randomization, at secondary kernel boot. We always do

Re: [PATCH v16 15/16] arm64: kexec_file: add kernel signature verification support

2018-12-10 Thread AKASHI Takahiro
On Fri, Nov 30, 2018 at 01:21:14PM +, Will Deacon wrote: > On Thu, Nov 15, 2018 at 02:52:54PM +0900, AKASHI Takahiro wrote: > > With this patch, kernel verification can be done without IMA security > > subsystem enabled. Turn on CONFIG_KEXEC_VERIFY_SIG instead. > > &g

[PATCH v14 12/16] arm64: kexec_file: add crash dump support

2018-09-07 Thread AKASHI Takahiro
y range to be used by crash dump kernel and the header's location Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon Reviewed-by: James Morse --- arch/arm64/include/asm/kexec.h | 4 + arch/arm64/kernel/machine_kexec_file.c | 113 - 2 files cha

[PATCH v14 11/16] arm64: kexec_file: allow for loading Image-format kernel

2018-09-07 Thread AKASHI Takahiro
, you must have IMA enforced with, at least, the following security policy: "appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig" See more details about IMA here: https://sourceforge.net/p/linux-ima/wiki/Home/ Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon

[PATCH v14 08/16] arm64: cpufeature: add MMFR0 helper functions

2018-09-07 Thread AKASHI Takahiro
Those helper functions for MMFR0 register will be used later by kexec_file loader. Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon Reviewed-by: James Morse --- arch/arm64/include/asm/cpufeature.h | 48 + 1 file changed, 48 insertions(+) diff

[PATCH v14 12/16] arm64: kexec_file: add crash dump support

2018-09-07 Thread AKASHI Takahiro
y range to be used by crash dump kernel and the header's location Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon Reviewed-by: James Morse --- arch/arm64/include/asm/kexec.h | 4 + arch/arm64/kernel/machine_kexec_file.c | 113 - 2 files cha

[PATCH v14 11/16] arm64: kexec_file: allow for loading Image-format kernel

2018-09-07 Thread AKASHI Takahiro
, you must have IMA enforced with, at least, the following security policy: "appraise func=KEXEC_KERNEL_CHECK appraise_type=imasig" See more details about IMA here: https://sourceforge.net/p/linux-ima/wiki/Home/ Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon

[PATCH v14 08/16] arm64: cpufeature: add MMFR0 helper functions

2018-09-07 Thread AKASHI Takahiro
Those helper functions for MMFR0 register will be used later by kexec_file loader. Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon Reviewed-by: James Morse --- arch/arm64/include/asm/cpufeature.h | 48 + 1 file changed, 48 insertions(+) diff

Re: [PATCH v2 1/3] arm64: implement ftrace with regs

2018-08-29 Thread AKASHI Takahiro
On Fri, Aug 17, 2018 at 12:27:24PM +0200, Torsten Duwe wrote: > Check for compiler support of -fpatchable-function-entry and use it > to intercept functions immediately on entry, saving the LR in x9. > Disable ftracing in efi/libstub, because this triggers cross-section > linker errors now (-pg is

Re: [PATCH v2 1/3] arm64: implement ftrace with regs

2018-08-29 Thread AKASHI Takahiro
On Fri, Aug 17, 2018 at 12:27:24PM +0200, Torsten Duwe wrote: > Check for compiler support of -fpatchable-function-entry and use it > to intercept functions immediately on entry, saving the LR in x9. > Disable ftracing in efi/libstub, because this triggers cross-section > linker errors now (-pg is

[PATCH v13 16/16] arm64: kexec_file: add kaslr support

2018-08-01 Thread AKASHI Takahiro
by passing "nokaslr" as a kernel boot argument. Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon --- arch/arm64/kernel/machine_kexec_file.c | 45 ++ 1 file changed, 45 insertions(+) diff --git a/arch/arm64/kernel/machine_kex

[PATCH v13 16/16] arm64: kexec_file: add kaslr support

2018-08-01 Thread AKASHI Takahiro
by passing "nokaslr" as a kernel boot argument. Signed-off-by: AKASHI Takahiro Cc: Catalin Marinas Cc: Will Deacon --- arch/arm64/kernel/machine_kexec_file.c | 45 ++ 1 file changed, 45 insertions(+) diff --git a/arch/arm64/kernel/machine_kex

[PATCH v13 00/16] subject: arm64: kexec: add kexec_file_load() support

2018-08-01 Thread AKASHI Takahiro
r KEXEC_FILE support (additionally allowing for IMA-based verification): Patch #1 to #6 are all preparatory patches on generic side. Patch #7 to #11 are to enable kexec_file_load on arm64. Patch #12 to #13 are for KEXEC_VERIFY_SIG (arch-specific verification) support AKASHI Takahiro (16):

[PATCH v13 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem()

2018-08-01 Thread AKASHI Takahiro
(), the current kexec_walk_memblock() won't work for kdump either in this form, this will be fixed in the next patch. Signed-off-by: AKASHI Takahiro Cc: "Eric W. Biederman" Acked-by: Dave Young Cc: Vivek Goyal Cc: Baoquan He Acked-by: James Morse --- arch/powerpc/kernel/machine_kexec_file

[PATCH v13 00/16] subject: arm64: kexec: add kexec_file_load() support

2018-08-01 Thread AKASHI Takahiro
r KEXEC_FILE support (additionally allowing for IMA-based verification): Patch #1 to #6 are all preparatory patches on generic side. Patch #7 to #11 are to enable kexec_file_load on arm64. Patch #12 to #13 are for KEXEC_VERIFY_SIG (arch-specific verification) support AKASHI Takahiro (16):

[PATCH v13 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem()

2018-08-01 Thread AKASHI Takahiro
(), the current kexec_walk_memblock() won't work for kdump either in this form, this will be fixed in the next patch. Signed-off-by: AKASHI Takahiro Cc: "Eric W. Biederman" Acked-by: Dave Young Cc: Vivek Goyal Cc: Baoquan He Acked-by: James Morse --- arch/powerpc/kernel/machine_kexec_file

Re: [PATCH v12 16/16] arm64: kexec_file: add kaslr support

2018-08-01 Thread AKASHI Takahiro
James, All the changes mentioned below were applied to my coming v13. On Fri, Jul 27, 2018 at 10:22:31AM +0100, James Morse wrote: > Hi Akashi, > > > On 07/27/2018 09:31 AM, AKASHI Takahiro wrote: > >On Thu, Jul 26, 2018 at 02:40:49PM +0100, James Morse wrote: > >&g

Re: [PATCH v12 16/16] arm64: kexec_file: add kaslr support

2018-08-01 Thread AKASHI Takahiro
James, All the changes mentioned below were applied to my coming v13. On Fri, Jul 27, 2018 at 10:22:31AM +0100, James Morse wrote: > Hi Akashi, > > > On 07/27/2018 09:31 AM, AKASHI Takahiro wrote: > >On Thu, Jul 26, 2018 at 02:40:49PM +0100, James Morse wrote: > >&g

Re: [PATCH 1/1] arm64: kexec: machine_kexec should call __flush_icache_range

2018-07-30 Thread AKASHI Takahiro
On Mon, Jul 30, 2018 at 04:36:28PM -0500, Dave Kleikamp wrote: > On 07/30/2018 11:57 AM, Will Deacon wrote: > > On Mon, Jul 30, 2018 at 11:46:24AM -0500, Dave Kleikamp wrote: > >> On 07/30/2018 11:22 AM, Will Deacon wrote: > >>> On Mon, Jul 30, 2018 at 05:16:42PM +0100, Catalin Marinas wrote: >

Re: [PATCH 1/1] arm64: kexec: machine_kexec should call __flush_icache_range

2018-07-30 Thread AKASHI Takahiro
On Mon, Jul 30, 2018 at 04:36:28PM -0500, Dave Kleikamp wrote: > On 07/30/2018 11:57 AM, Will Deacon wrote: > > On Mon, Jul 30, 2018 at 11:46:24AM -0500, Dave Kleikamp wrote: > >> On 07/30/2018 11:22 AM, Will Deacon wrote: > >>> On Mon, Jul 30, 2018 at 05:16:42PM +0100, Catalin Marinas wrote: >

Re: [PATCH v12 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem()

2018-07-26 Thread AKASHI Takahiro
On Wed, Jul 25, 2018 at 08:31:29PM +0800, Dave Young wrote: > On 07/24/18 at 03:57pm, AKASHI Takahiro wrote: > > Memblock list is another source for usable system memory layout. > > So move powerpc's arch_kexec_walk_mem() to common code so that other > > memblock-based archit

Re: [PATCH v12 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem()

2018-07-26 Thread AKASHI Takahiro
On Wed, Jul 25, 2018 at 08:31:29PM +0800, Dave Young wrote: > On 07/24/18 at 03:57pm, AKASHI Takahiro wrote: > > Memblock list is another source for usable system memory layout. > > So move powerpc's arch_kexec_walk_mem() to common code so that other > > memblock-based archit

Re: linux-next: build warning after merge of the arm64 tree

2018-07-23 Thread AKASHI Takahiro
On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the arm64 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: Where can I find this specific branch? > drivers/acpi/Kconfig:6:error: recursive dependency detected! >

Re: linux-next: build warning after merge of the arm64 tree

2018-07-23 Thread AKASHI Takahiro
On Tue, Jul 24, 2018 at 09:05:45AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the arm64 tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: Where can I find this specific branch? > drivers/acpi/Kconfig:6:error: recursive dependency detected! >

[PATCH v3 2/3] efi/arm: map UEFI memory map even w/o runtime services enabled

2018-07-08 Thread AKASHI Takahiro
=2 Signed-off-by: AKASHI Takahiro Reviewed-by: Ard Biesheuvel --- drivers/firmware/efi/arm-runtime.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 59a8c0ec94d5..a00934d263c5 100644

[PATCH v3 3/3] arm64: acpi: fix alignment fault in accessing ACPI

2018-07-08 Thread AKASHI Takahiro
ed access support (ACPI_MISALIGNMENT_NOT_SUPPORTED), any unaligned access to ACPI tables can cause a fatal panic. With this patch, acpi_os_ioremap() always honors memory attribute information provided by the firmware (EFI) and retaining cacheability allows the kernel safe access to ACPI tables.

[PATCH v3 2/3] efi/arm: map UEFI memory map even w/o runtime services enabled

2018-07-08 Thread AKASHI Takahiro
=2 Signed-off-by: AKASHI Takahiro Reviewed-by: Ard Biesheuvel --- drivers/firmware/efi/arm-runtime.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 59a8c0ec94d5..a00934d263c5 100644

[PATCH v3 3/3] arm64: acpi: fix alignment fault in accessing ACPI

2018-07-08 Thread AKASHI Takahiro
ed access support (ACPI_MISALIGNMENT_NOT_SUPPORTED), any unaligned access to ACPI tables can cause a fatal panic. With this patch, acpi_os_ioremap() always honors memory attribute information provided by the firmware (EFI) and retaining cacheability allows the kernel safe access to ACPI tables.

[PATCH v3 0/3] arm64: kexec,kdump: fix boot failures on acpi-only system

2018-07-08 Thread AKASHI Takahiro
reak bisect [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-March/565980.html [2] https://git.linaro.org/people/takahiro.akashi/kexec-tools.git arm64/resv_mem [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/573655.html [4] https://marc.info/?l=linux-efi=15293077350

[PATCH v3 0/3] arm64: kexec,kdump: fix boot failures on acpi-only system

2018-07-08 Thread AKASHI Takahiro
reak bisect [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-March/565980.html [2] https://git.linaro.org/people/takahiro.akashi/kexec-tools.git arm64/resv_mem [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/573655.html [4] https://marc.info/?l=linux-efi=15293077350

[PATCH v3 1/3] arm64: export memblock_reserve()d regions via /proc/iomem

2018-07-08 Thread AKASHI Takahiro
n initcall. Reported-by: Bhupesh Sharma Reported-by: Tyler Baicar Suggested-by: Akashi Takahiro Signed-off-by: James Morse Fixes: d28f6df1305a ("arm64/kexec: Add core kexec support") Reviewed-by: Ard Biesheuvel CC: Mark Rutland --- arch/arm64/kernel/setup.c | 38 +

  1   2   3   4   5   6   7   8   9   10   >