2021年2月1日(月) 16:43 Jiapeng Chong :
>
> Fix the following coccicheck warning:
>
> ./lib/fault-inject.c:187:0-23: WARNING: fops_stacktrace_depth should be
> defined with DEFINE_DEBUGFS_ATTRIBUTE.
>
> ./lib/fault-inject.c:169:0-23: WARNING: fops_ul should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE.
>
2020年10月26日(月) 21:52 Aleksandr Nogikh :
>
> From: Aleksandr Nogikh
>
> Describe fail_lsm_hooks fault injection capability.
>
> Signed-off-by: Aleksandr Nogikh
> ---
> v2:
> - Added this commit.
> ---
> Documentation/fault-injection/fault-injection.rst | 6 ++
> 1 file changed, 6
Hi Andrew,
Please consider taking this patch in the -mm tree.
This patch looks good to me.
Reviewed-by: Akinobu Mita
2020年10月13日(火) 18:31 Barnabás Pőcze :
>
> Hi,
>
> I had some difficulty finding who should receive this patch, and I am not
> sure I got it right. Could someone
Andrew,
Could you take a look at this series, and consider taking in -mm tree?
2020年9月1日(火) 0:49 Alexander Potapenko :
>
> > This series looks good to me.
>
> Great!
>
> Which tree do fault injection patches normally go to?
>
> > Reviewed-by: Akinobu Mita
>
> Reviewed-by: Alexander Potapenko
for usercopy
> functions. The second changes usercopy functions to use this new failure
> capability (copy_from_user, ...). The third patch adds
> get/put/clear_user failures to x86.
This series looks good to me.
Reviewed-by: Akinobu Mita
h LED trigger device. The name of the sub-directory matches the LED
trigger name.
We can find all available LED triggers by listing this directory contents.
Cc: Greg Kroah-Hartman
Cc: "Rafael J. Wysocki"
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
ek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
Documentation/ABI/testing/sysfs-class-led | 13 +++
drivers/leds/led-class.c | 10
drivers/leds/led-triggers.c | 38 +++
drivers/leds/leds.h
per file" rule of sysfs.
This series was previously developed as a part of the series "leds: fix
/sys/class/leds//trigger and add new api" [1]. Now this version
only contains the new api part.
[1]
https://lore.kernel.org/r/1567946472-10075-1-git-send-email-akinobu.m...@gmail.com
Akin
zewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c| 8 ++--
drivers/leds/led-triggers.c | 90 ++---
drivers/leds/leds.h | 6 +++
include/linux/leds.h| 5 ---
4 files changed, 78 inserti
to a certain amount of changes
* v2
- Update commit message
- Drop patches for new api
Akinobu Mita (1):
leds: remove PAGE_SIZE limit of /sys/class/leds//trigger
drivers/leds/led-class.c| 8 ++--
drivers/leds/led-triggers.c | 90 ++---
drivers/leds
2019年9月28日(土) 2:46 Greg Kroah-Hartman :
>
> On Sat, Sep 28, 2019 at 01:47:21AM +0900, Akinobu Mita wrote:
> > 2019年9月27日(金) 15:39 Greg Kroah-Hartman :
> > >
> > > On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote:
> > > > Reading /sys/cla
2019年9月27日(金) 15:39 Greg Kroah-Hartman :
>
> On Sat, Sep 14, 2019 at 12:03:24AM +0900, Akinobu Mita wrote:
> > Reading /sys/class/leds//trigger returns all available LED triggers.
> > However, the size of this file is limited to PAGE_SIZE because of the
> > limita
2019年9月21日(土) 20:49 Markus Elfring :
>
> From: Markus Elfring
> Date: Sat, 21 Sep 2019 13:43:07 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elf
zewski
Cc: Pavel Machek
Cc: Dan Murphy
Acked-by: Pavel Machek
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c| 8 ++--
drivers/leds/led-triggers.c | 90 ++---
drivers/leds/leds.h | 6 +++
include/linux/leds.h| 5 ---
4 files c
e per file" rule of sysfs. This second version dropped it because
there have been a number of problems and it turns out that the new api
should be submitted separately.
* v2
- Update commit message
- Drop patches for new api
Akinobu Mita (1):
leds: remove PAGE_SIZE limit of /sys/class/led
2019年9月13日(金) 2:15 Jacek Anaszewski :
>
> Hi Akinobu,
>
> Please bump patch version each time you send an update
> of the patch with the same subject.
Oops, should I resend with the correct subject?
zewski
Cc: Pavel Machek
Cc: Dan Murphy
Acked-by: Pavel Machek
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c| 8 ++--
drivers/leds/led-triggers.c | 90 ++---
drivers/leds/leds.h | 6 +++
include/linux/leds.h| 5 ---
4 files c
on dropped it because
there have been a number of problems and it turns out that the new api
should be submitted separately.
* v2
- Update commit message
- Drop patches for new api
Akinobu Mita (1):
leds: remove PAGE_SIZE limit of /sys/class/leds//trigger
drivers/leds/led-class.c| 8 ++--
dr
2019年9月12日(木) 0:36 Greg Kroah-Hartman :
>
> On Thu, Sep 12, 2019 at 12:25:28AM +0900, Akinobu Mita wrote:
> > 2019年9月8日(日) 22:10 Greg Kroah-Hartman :
> > >
> > > On Sun, Sep 08, 2019 at 09:41:08PM +0900, Akinobu Mita wrote:
> > > > Reading /sys/cla
2019年9月8日(日) 22:10 Greg Kroah-Hartman :
>
> On Sun, Sep 08, 2019 at 09:41:08PM +0900, Akinobu Mita wrote:
> > Reading /sys/class/leds//trigger returns all available LED triggers.
> > However, the size of this file is limited to PAGE_SIZE because of the
> > limita
only shows the current trigger name.
This new file follows the "one value per file" rule of sysfs.
We can use the /sys/class/triggers directory to get the list of available
LED triggers.
Cc: Greg Kroah-Hartman
Cc: "Rafael J. Wysocki"
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan
ry matches the LED trigger name.
Cc: Greg Kroah-Hartman
Cc: "Rafael J. Wysocki"
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
Documentation/ABI/testing/sysfs-class-led | 9 +
drivers/leds/led-class.c
ael J. Wysocki"
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 8b5a1d1..7d85181 100644
--- a/driver
follows the "one value
per file" rule of sysfs.
Akinobu Mita (5):
leds: remove PAGE_SIZE limit of /sys/class/leds//trigger
leds: make sure leds_class is initialized before triggers are
registered
driver core: class: add function to create /sys/class//foo
directory
leds
zewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
drivers/base/class.c | 7 +++
include/linux/device.h | 3 +++
2 files changed, 10 insertions(+)
diff --git a/drivers/base/class.c b/drivers/base/class.c
index d8a6a58..f4c53e7 100644
--- a/drivers/base/class.c
+++ b/dr
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c| 8 ++--
drivers/leds/led-triggers.c | 90 ++---
drivers/leds/leds.h | 6 +++
include/linux/leds.h| 5 ---
4 files changed, 79 insertions(+), 30 deletions(-)
diff --git a/driver
2019年9月3日(火) 23:07 Greg KH :
>
> On Tue, Sep 03, 2019 at 10:55:40PM +0900, Akinobu Mita wrote:
> > 2019年9月3日(火) 4:08 Greg KH :
> > >
> > > On Mon, Sep 02, 2019 at 08:47:02PM +0200, Jacek Anaszewski wrote:
> > > > On 9/2/19 8:12 PM, Greg KH wrote:
> >
gt; Thank you for the patch.
> > >>
> > >> I have one nit below but in general it looks good to me.
> > >> I've tested it with 2000 mtd triggers (~14kB file size)
> > >> and it worked flawlessly.
> > >>
> > >> Still,
available LED triggers
and which trigger is currently activated.
This converts /sys/class/leds//trigger to bin attribute and removes
the PAGE_SIZE limitation.
Cc: Jacek Anaszewski
Cc: Pavel Machek
Cc: Dan Murphy
Signed-off-by: Akinobu Mita
---
drivers/leds/led-class.c| 8 ++---
drivers/leds
s/dev_coredumpmsg/dev_coredumpsg/
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Reviewed-by: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
---
drivers/base/devcoredump.c | 2 +-
1 file
Use memory_read_from_buffer() to simplify devcd_readv().
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Reviewed-by: Chaitanya Kulkarni
Reviewed-by: Johannes Berg
Signed-off-by: Akinobu
These two patches are cleanup and typo fix for device coredump subsystem,
and these were originally a part of nvme device coredump series. However
the series requires an overhaul because it makes nvme-pci driver
compilcated, so these two independent patches are extracted from the
series.
Akinobu
AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_I3C)
> + default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 ||
> REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SCCB || REGMAP_I3C)
> select IRQ_DOMAIN if REGMAP_IRQ
> bool
Looks good.
Reviewed-by: Aki
>
> Also fix up the error check for debugfs_create_dir() which was not
> returning NULL for an error, but rather a error pointer.
>
> Cc: Akinobu Mita
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman
Looks good.
Reviewed-by: Akinobu Mita
page_alloc: rename __GFP_WAIT to __GFP_RECLAIM")
> Signed-off-by: Nicolas Boichat
Good catch.
Reviewed-by: Akinobu Mita
> ---
> mm/failslab.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/failslab.c b/mm/failslab.c
> index
phases (before resetting controller and
after resetting as soon as admin queue is available).
Akinobu Mita (7):
devcoredump: use memory_read_from_buffer
devcoredump: fix typo in comment
devcoredump: allow to create several coredump files in one device
nvme: add basic facilities to get
s/dev_coredumpmsg/dev_coredumpsg/
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Reviewed-by: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
---
* v4
- Add Reviewed-by tag
drivers/base
to create several device
coredump files in one crashed device.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
---
* v4
- No change since v2
drivers/base
: Kenneth Heitke
Cc: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
---
* v4
- Move nvme_get_telemetry_log() to nvme core module.
- Use bio_vec instead of sg_table to store telemetry log page
- Make nvme_coredump_logs() return error if the device didn't produce
a response.
drivers/nvme/host/Kconfig
/debug/fail_io_timeout/times
# echo 1 > /sys/block/nvme0n1/io-timeout-fail
# dd if=/dev/nvme0n1 of=/dev/null
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
This provides a way to trigger the nvme device coredump by writing
anything to /sys/devices/.../coredump attribute.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
Use memory_read_from_buffer() to simplify devcd_readv().
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Cc: Chaitanya Kulkarni
Reviewed-by: Chaitanya Kulkarni
Reviewed-by: Johannes Berg
Signed-off-by: Akinobu
: Chaitanya Kulkarni
Signed-off-by: Akinobu Mita
---
* v4
- Add nvme_get_telemetry_log() to nvme core module.
- Copy struct nvme_telemetry_log_page_hdr from the latest nvme-cli
drivers/nvme/host/core.c | 59
drivers/nvme/host/nvme.h | 3 +++
include
2019年5月14日(火) 0:23 Chaitanya Kulkarni :
>
> On 05/13/2019 12:46 AM, Minwoo Im wrote:
> >> +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void
> >> *buf,
> >> + size_t bytes, loff_t offset)
> >> +{
> >> +loff_t pos = 0;
> >> +u32
2019年5月14日(火) 0:34 Chaitanya Kulkarni :
>
> On 05/12/2019 08:55 AM, Akinobu Mita wrote:
> > This adds the required definisions to get telemetry log page.
> s/definisions/definitions/
OK.
> > diff --git a/include/linux/nvme.h b/include/linux/nvme.h
> > in
2019年5月13日(月) 23:03 Christoph Hellwig :
>
> Usage of a scatterlist here is rather bogus as we never use
> it for dma mapping. Why can't you store the various pages in a
> large bio_vec and then just issue that to the device in one
> get log page command? (or at least a few if MDTS kicks in?)
2019年5月13日(月) 22:55 Keith Busch :
>
> On Sun, May 12, 2019 at 08:54:15AM -0700, Akinobu Mita wrote:
> > +static void nvme_coredump_logs(struct nvme_dev *dev)
> > +{
> > + struct dev_coredumpm_bulk_data *bulk_data;
> > +
> > + if (!
2019年5月13日(月) 16:41 Minwoo Im :
>
> > -static void __maybe_unused nvme_coredump_init(struct nvme_dev *dev);
> > -static void __maybe_unused nvme_coredump_logs(struct nvme_dev *dev);
> > -static void __maybe_unused nvme_coredump_complete(struct nvme_dev
> > *dev);
> > +static void
to create several device
coredump files in one crashed device.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Signed-off-by: Akinobu Mita
---
* v3
- No change since v2
drivers/base/devcoredump.c | 155
s/dev_coredumpmsg/dev_coredumpsg/
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Signed-off-by: Akinobu Mita
---
* v3
- No change since v2
drivers/base/devcoredump.c | 2 +-
1 file changed, 1 insertion(+), 1
/debug/fail_io_timeout/times
# echo 1 > /sys/block/nvme0n1/io-timeout-fail
# dd if=/dev/nvme0n1 of=/dev/null
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Signed-off-by: Akinobu Mita
---
* v3
- Don't t
This provides a way to trigger the nvme device coredump by writing
anything to /sys/devices/.../coredump attribute.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Signed-off-by: Akinobu Mita
---
* v3
- Extracted
: Kenneth Heitke
Signed-off-by: Akinobu Mita
---
* v3
- Fix typo s/machanism/mechanism/ in commit log
- Fix max transfer size calculation for get log page
- Add function comments
- Extract 'enable to trigger device coredump by hand' patch
drivers/nvme/host/Kconfig | 1 +
drivers/nvme/host/core.c
Signed-off-by: Akinobu Mita
---
* v3
- Merge 'add telemetry log page definisions' patch and 'add facility to
check log page attributes' patch
- Copy struct nvme_telemetry_log_page_hdr from the latest nvme-cli
- Add BUILD_BUG_ON for the size of struct nvme_telemetry_log_page_hdr
drivers/nvme/host
as soon as admin queue is available).
Akinobu Mita (7):
devcoredump: use memory_read_from_buffer
devcoredump: fix typo in comment
devcoredump: allow to create several coredump files in one device
nvme: add basic facility to get telemetry log page
nvme-pci: add device coredump
Use memory_read_from_buffer() to simplify devcd_readv().
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Cc: Kenneth Heitke
Reviewed-by: Johannes Berg
Signed-off-by: Akinobu Mita
---
* v3
- No change since v2
drivers/base
2019年5月8日(水) 9:25 Minwoo Im :
>
> > This is a bit of a mine field. The shutdown_lock is held when reclaiming
> > requests that didn't see a response. If you're holding it here and your
> > telemetry log page times out, we're going to deadlock. And since the
> > controller is probably in a buggered
2019年5月8日(水) 6:28 Keith Busch :
>
> On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote:
> > On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > > +
> > > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void
> > > *buf,
> >
2019年5月8日(水) 2:53 Heitke, Kenneth :
>
>
>
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > Copy telemetry log page definisions from nvme-cli.
> >
> > Cc: Johannes Berg
> > Cc: Keith Busch
> > Cc: Jens Axboe
> > Cc: Christoph Hellwig
> >
2019年5月8日(水) 2:28 Heitke, Kenneth :
>
>
>
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > Copy telemetry log page definisions from nvme-cli.
> >
> > Cc: Johannes Berg
> > Cc: Keith Busch
> > Cc: Jens Axboe
> > Cc: Christoph Hellwig
> >
2019年5月8日(水) 2:35 Heitke, Kenneth :
>
>
>
> On 5/7/2019 10:58 AM, Akinobu Mita wrote:
> > @@ -292,6 +309,12 @@ void dev_coredumpm(struct device *dev, struct module
> > *owner,
> > if (device_add(>devcd_dev))
> > goto put_device;
> &g
s/dev_coredumpmsg/dev_coredumpsg/
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
* v2
- New patch in this version.
drivers/base/devcoredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
controller-initiated log if available
- Make coredump procedure into two phases (before resetting controller and
after resetting as soon as admin queue is available).
Akinobu Mita (7):
devcoredump: use memory_read_from_buffer
devcoredump: fix typo in comment
devcoredump: allow to create several
Use memory_read_from_buffer() to simplify devcd_readv().
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Reviewed-by: Johannes Berg
Signed-off-by: Akinobu Mita
---
* v2
- Add Reviewed-by tag.
drivers/base/devcoredump.c | 11
to create several device
coredump files in one crashed device.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
* v2
- Remove unneeded braces.
- Allocate device_entry followed by an array of devcd_file
This provides a facility to check whether the controller supports the
telemetry log pages and log page offset field for the Get Log Page
command.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
* v2
Copy telemetry log page definisions from nvme-cli.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
* v2
- New patch in this version.
include/linux/nvme.h | 23 +++
1 file changed
/debug/fail_io_timeout/times
# echo 1 > /sys/block/nvme0n1/io-timeout-fail
# dd if=/dev/nvme0n1 of=/dev/null
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
- Make coredump procedure into two phase
it, the userspace programs need
to know which driver provides what coredump file.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Cc: Minwoo Im
Signed-off-by: Akinobu Mita
---
* v2
- Exclude the doorbell registers from register dump.
- Save controller
2019年5月4日(土) 18:40 Minwoo Im :
>
> Hi Akinobu,
>
> On 5/4/19 1:20 PM, Akinobu Mita wrote:
> > 2019年5月3日(金) 21:20 Christoph Hellwig :
> >>
> >> On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote:
> >>> Could you actually explain how t
2019年5月4日(土) 19:04 Minwoo Im :
>
> Hi, Akinobu,
>
> Regardless to reply of the cover, few nits here.
>
> On 5/2/19 5:59 PM, Akinobu Mita wrote:
> > +
> > +static const struct nvme_reg nvme_regs[] = {
> > + { NVME_REG_CAP, "cap", 64
2019年5月3日(金) 21:20 Christoph Hellwig :
>
> On Fri, May 03, 2019 at 06:12:32AM -0600, Keith Busch wrote:
> > Could you actually explain how the rest is useful? I personally have
> > never encountered an issue where knowing these values would have helped:
> > every device timeout always needed
2019年5月2日(木) 21:47 Johannes Berg :
>
> On Thu, 2019-05-02 at 17:59 +0900, Akinobu Mita wrote:
> >
> > static void devcd_del(struct work_struct *wk)
> > {
> > struct devcd_entry *devcd;
> > + int i;
> >
> > devcd =
2019年5月2日(木) 22:03 Keith Busch :
>
> On Thu, May 02, 2019 at 05:59:17PM +0900, Akinobu Mita wrote:
> > This enables to capture snapshot of controller information via device
> > coredump machanism, and it helps diagnose and debug issues.
> >
> > The nvme devic
This enables the nvme driver to trigger a device coredump before resetting
the controller caused by I/O timeout.
The device coredump helps diagnose and debug issues.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Signed-off-by: Akinobu Mita
Use memory_read_from_buffer() to simplify devcd_readv().
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Signed-off-by: Akinobu Mita
---
drivers/base/devcoredump.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git
submission queue
- cq: I/O completion queue
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Signed-off-by: Akinobu Mita
---
drivers/nvme/host/Kconfig | 1 +
drivers/nvme/host/pci.c | 221 ++
2 files changed
to create several device
coredump files in one crashed device.
Cc: Johannes Berg
Cc: Keith Busch
Cc: Jens Axboe
Cc: Christoph Hellwig
Cc: Sagi Grimberg
Signed-off-by: Akinobu Mita
---
drivers/base/devcoredump.c | 162 ++--
include/linux/devcoredump.h
drivers to create several device coredump files in one crashed device.
Akinobu Mita (4):
devcoredump: use memory_read_from_buffer
devcoredump: allow to create several coredump files in one device
nvme-pci: add device coredump support
nvme-pci: trigger device coredump before resetting controller
Fix s/4.17/4.16/ typo.
Fixes: 8962e40c1993 ("docs: update kernel versions and dates in tables")
Cc: Tim Bird
Cc: Jonathan Corbet
Signed-off-by: Akinobu Mita
---
Documentation/process/2.Process.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation
Fix s/4.17/4.16/ typo.
Fixes: 8962e40c1993 ("docs: update kernel versions and dates in tables")
Cc: Tim Bird
Cc: Jonathan Corbet
Signed-off-by: Akinobu Mita
---
Documentation/process/2.Process.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation
2018-03-10 8:01 GMT+09:00 Pavel Machek :
> Hi!
>
>> > Hmm. Looks like there's a lot of fun to be had with sysfs.
>> >
>> >
>> > pavel@n900:~$ uname -a
>> > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET
>> > 2018 armv7l GNU/Linux
>> >
>> > [ 306.402496]
2018-03-10 8:01 GMT+09:00 Pavel Machek :
> Hi!
>
>> > Hmm. Looks like there's a lot of fun to be had with sysfs.
>> >
>> >
>> > pavel@n900:~$ uname -a
>> > Linux n900 4.16.0-rc4-59690-g7f84626-dirty #543 Thu Mar 8 19:53:30 CET
>> > 2018 armv7l GNU/Linux
>> >
>> > [ 306.402496] bq2415x: command
2018-01-13 2:56 GMT+09:00 Masami Hiramatsu :
> Support in-kernel fault-injection framework via debugfs.
> This allows you to inject a conditional error to specified
> function using debugfs interfaces.
>
> Here is the result of test script described in
>
2018-01-13 2:56 GMT+09:00 Masami Hiramatsu :
> Support in-kernel fault-injection framework via debugfs.
> This allows you to inject a conditional error to specified
> function using debugfs interfaces.
>
> Here is the result of test script described in
>
2018-01-12 1:15 GMT+09:00 Masami Hiramatsu <mhira...@kernel.org>:
> On Thu, 11 Jan 2018 23:44:57 +0900
> Akinobu Mita <akinobu.m...@gmail.com> wrote:
>
>> 2018-01-11 9:51 GMT+09:00 Masami Hiramatsu <mhira...@kernel.org>:
>> > Support in-ke
2018-01-12 1:15 GMT+09:00 Masami Hiramatsu :
> On Thu, 11 Jan 2018 23:44:57 +0900
> Akinobu Mita wrote:
>
>> 2018-01-11 9:51 GMT+09:00 Masami Hiramatsu :
>> > Support in-kernel fault-injection framework via debugfs.
>> > This allows you to inject a conditional
2018-01-11 9:51 GMT+09:00 Masami Hiramatsu :
> Support in-kernel fault-injection framework via debugfs.
> This allows you to inject a conditional error to specified
> function using debugfs interfaces.
>
> Here is the result of test script described in
>
2018-01-11 9:51 GMT+09:00 Masami Hiramatsu :
> Support in-kernel fault-injection framework via debugfs.
> This allows you to inject a conditional error to specified
> function using debugfs interfaces.
>
> Here is the result of test script described in
>
task context") and see if the problem
you reported is identical to the commit.
> References: commit e41d58185f14 ("fault-inject: support systematic fault
> injection")
> Signed-off-by: Bart Van Assche <bart.vanass...@wdc.com>
> Cc: Dmitry Vyukov <dvyu...@google.co
e problem
you reported is identical to the commit.
> References: commit e41d58185f14 ("fault-inject: support systematic fault
> injection")
> Signed-off-by: Bart Van Assche
> Cc: Dmitry Vyukov
> Cc: Akinobu Mita
> Cc: Michal Hocko
> Cc: Andrew Morton
> ---
>
us correct behaviour.
Fixes: 1203c8e6fb0a ("fault-inject: simplify access check for fail-nth")
Cc: Dmitry Vyukov <dvyu...@google.com>
Cc: Lu Fengqi <lufq.f...@cn.fujitsu.com>
Reported-by: Lu Fengqi <lufq.f...@cn.fujitsu.com>
Signed-off-by: Akinobu Mita <akinobu.m.
us correct behaviour.
Fixes: 1203c8e6fb0a ("fault-inject: simplify access check for fail-nth")
Cc: Dmitry Vyukov
Cc: Lu Fengqi
Reported-by: Lu Fengqi
Signed-off-by: Akinobu Mita
---
lib/fault-inject.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/fault-
2017-08-02 0:54 GMT+09:00 Akinobu Mita <akinobu.m...@gmail.com>:
> 2017-08-01 22:45 GMT+09:00 Dmitry Vyukov <dvyu...@google.com>:
>> On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi <lufq.f...@cn.fujitsu.com> wrote:
>>> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akin
2017-08-02 0:54 GMT+09:00 Akinobu Mita :
> 2017-08-01 22:45 GMT+09:00 Dmitry Vyukov :
>> On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi wrote:
>>> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akinobu Mita wrote:
>>>>The fault-inject-make-fail-nth-read-write-interface-s
2017-08-01 22:45 GMT+09:00 Dmitry Vyukov <dvyu...@google.com>:
> On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi <lufq.f...@cn.fujitsu.com> wrote:
>> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akinobu Mita wrote:
>>>The fault-inject-make-fail-nth-read-write-interface-symmetr
2017-08-01 22:45 GMT+09:00 Dmitry Vyukov :
> On Tue, Aug 1, 2017 at 3:09 PM, Lu Fengqi wrote:
>> On Fri, Jul 14, 2017 at 01:14:52AM +0900, Akinobu Mita wrote:
>>>The fault-inject-make-fail-nth-read-write-interface-symmetric.patch in
>>>-mm tree allows users to set tas
2017-07-13 5:49 GMT+09:00 Andrew Morton <a...@linux-foundation.org>:
> On Fri, 7 Apr 2017 22:37:01 +0200 Dmitry Vyukov <dvyu...@google.com> wrote:
>
>> On Thu, Apr 6, 2017 at 4:55 PM, Akinobu Mita <akinobu.m...@gmail.com> wrote:
>> > The read interface f
2017-07-13 5:49 GMT+09:00 Andrew Morton :
> On Fri, 7 Apr 2017 22:37:01 +0200 Dmitry Vyukov wrote:
>
>> On Thu, Apr 6, 2017 at 4:55 PM, Akinobu Mita wrote:
>> > The read interface for fail-nth looks a bit odd. Read from this file
>> > returns "N...&quo
e.com>
Reported-by: Dmitry Vyukov <dvyu...@google.com>
Signed-off-by: Akinobu Mita <akinobu.m...@gmail.com>
---
fs/proc/base.c | 5 +++--
lib/fault-inject.c | 7 +--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index ecc8a25
1 - 100 of 1201 matches
Mail list logo