On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote:
>
> On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
>
> > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote:
> > >
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
> > >
> > > > This set is part of a l
On Fri, Mar 26, 2021 at 3:35 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be
> on
>
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: message to
> Cc:
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote:
>
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (25):
> > HID:
Hi Jiri,
On Mon, Mar 8, 2021 at 11:15 AM Jiri Kosina wrote:
>
> On Wed, 17 Feb 2021, наб wrote:
>
> > This patchset adds support for stylus-on-touchscreen devices as found on
> > the OneMix 3 Pro and Dell Inspiron 15 7000 2-in-1 (7591), among others;
> > with it, they properly behave like a
On Sat, Jan 23, 2021 at 7:03 PM Filipe Laíns wrote:
>
> From: Filipe Laíns
>
> Tested with the G Pro X Superlight. libratbag sees the device, as
> expected, and input events are passing trough.
>
> https://github.com/libratbag/libratbag/pull/1122
>
> The receiver has a quirk where the moused
driver.
>
> Signed-off-by: Andy Shevchenko
Thanks a lot for the series. This indeed cleans things up.
For the series:
Acked-by: Benjamin Tissoires
Jiri, I wonder where we want to land this one. This is not strictly
bug fixes, but we could definitively sneak this one in 5.12-rc1.
Wel
On Mon, Mar 1, 2021 at 3:18 PM Andy Shevchenko
wrote:
>
> On Sun, Feb 28, 2021 at 3:30 AM Ronald Tschalär wrote:
> >
> > These are useful to drivers that need to scan or parse reports
> > themselves.
>
> ...
>
> > - while ((start = fetch_item(start, end, )) != NULL)
> > + while
On Wed, Feb 17, 2021 at 6:32 PM Benjamin Tissoires
wrote:
>
> [sending those patches on behalf of Roderick]
>
> There is a current thread on LED LKML which basically means that
> we have to revert the LED class exposure until things are settled.
>
> I am sending here the full
On Mon, Feb 15, 2021 at 5:39 PM Colin King wrote:
>
> From: Colin Ian King
>
> The comparison of value with the array size ps_gamepad_hat_mapping
> appears to be off-by-one. Fix this by using >= rather than > for the
> size comparison.
>
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes:
and schedules an output report
to mute/unmute the audio stream as well as toggle the mute LED.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 44 +++
1 file changed, 44
From: Roderick Colenbrander
Provide initial support for the DualSense lightbar and configure it
with a default PlayStation blue color.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 65
original patches
minus use of LED framework APIs:
- HID: playstation: add DualSense player LEDs support.
- HID: playstation: DualSense set LEDs to default player id.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c
From: Roderick Colenbrander
The ret variable in ps_battery_get_property is set in an error path,
but never actually returned. Change the function to return ret.
Reported-by: kernel test robot
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid
-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 81 +++
1 file changed, 81 insertions(+)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index 64193fdeaa0d..84f484fce1ee 100644
--- a/drivers/hid/hid
a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 70 +--
1 file changed, 1 insertion(+), 69 deletions(-)
diff --git a/drivers/hid/hid-playstation.c b/drive
th the new version, we also revert
all patches on top of the LED ones.
This is not a big deal, they are still not pushed to Linus.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 81 ---
1 file changed, 81 deletions(-)
diff --git a/drive
a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/Kconfig | 1 -
drivers/hid/hid-playstation.c | 118 --
2 files changed, 119 deletions(-)
diff --git a/drivers/hid/Kconfig b/d
a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 60 +--
1 file changed, 1 insertion(+), 59 deletions(-)
diff --git a/drivers/hid/hid-playstation.c b/drive
not a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/Kconfig | 2 -
drivers/hid/hid-playstation.c | 99 ---
2 files changed, 101 deletions(-)
diff --git a/drivers/hid
th the new version, we also revert
all patches on top of the LED ones.
This is not a big deal, they are still not pushed to Linus.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-playstation.c
ker()` to match was was in linux-next
- removed an extra new line to match the current linux-next tree.
Cheers,
Benjamin
Benjamin Tissoires (2):
Revert "HID: playstation: fix unused variable in
ps_battery_get_property."
Revert "HID: playstation: report DualSense hardware and fi
Hi Nikolai,
On Mon, Feb 8, 2021 at 9:01 AM Nikolai Kostrigin wrote:
>
> ThinkPad L13 Gen2 has both touchpad and trackpoint.
> PNP: LEN2146 PNP0f13
> With the default protocol (elantech-smbus) trackpoint is not operating,
> while touchpad does. Changing to elantech renders both operational.
>
>
On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
wrote:
>
> Palm ejection stops working on some Elan and Synaptics touchpad after
> commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for
> some devices").
>
> The commit changes the mt_class from MT_CLS_WIN_8 to
>
On Fri, Jan 15, 2021 at 6:07 PM Douglas Anderson wrote:
>
>
> The goal of this series is to support the Goodix GT7375P touchscreen.
> This touchscreen is special because it has power sequencing
> requirements that necessitate driving a reset GPIO.
>
> To do this, we totally rejigger the way
Hi,
On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
wrote:
>
> Palm ejection stops working on some Elan and Synaptics touchpad after
> commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for
> some devices").
>
> The commit changes the mt_class from MT_CLS_WIN_8 to
>
Hi,
On Wed, Jan 13, 2021 at 8:35 PM Benjamin Tissoires
wrote:
On Wed, Jan 13, 2021 at 5:05 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires
> wrote:
> >
> > > I wanted to apply the series yesterday, but for these kinds
> set but not used [-Wunused-but-set-variable]
>
> Cc: Dmitry Torokhov
> Cc: Henrik Rydberg
> Cc: Benjamin Tissoires
> Cc: linux-in...@vger.kernel.org
> Signed-off-by: Lee Jones
Reviewed-by: Benjamin Tissoires
Thanks for the cleanup :)
Cheers,
Benjamin
> ---
>
Hi Dmitry,
On Thu, Jan 14, 2021 at 7:24 AM Dmitry Torokhov
wrote:
>
> A typical USB keyboard usually splits its keys into several reports:
>
> - one for the basic alphanumeric keys, modifier keys, F keys, six pack
> keys and keypad. This report's application is normally listed as
>
On Wed, Jan 13, 2021 at 5:05 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires
> wrote:
> >
> > > I wanted to apply the series yesterday, but for these kinds of changes
> > > I like giving it a spin on actual hardw
On Fri, Jan 8, 2021 at 6:52 PM Benjamin Tissoires
wrote:
>
> Hi Doug,
>
> On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote:
> >
> > Benjamin,
> >
> > On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson
> > wrote:
> > >
> > > The goal
false pressure.
>
> [1]
> https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-required-hid-top-level-collections#windows-precision-touchpad-input-reports
> [2] https://gitlab.freedesktop.org/libinput/libinput/-/issues/562
>
>
Hi Doug,
On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote:
>
> Benjamin,
>
> On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson
> wrote:
> >
> > The goal of this series is to support the Goodix GT7375P touchscreen.
> > This touchscreen is special because it has power sequencing
> >
Hi Doug,
On Tue, Dec 1, 2020 at 10:12 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson
> wrote:
> >
> > The goal of this series is to support the Goodix GT7375P touchscreen.
> > This touchscreen is special because it has power sequencing
> > requirements
ess_touch’:
> > drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable
> > ‘timestamp’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Dmitry Torokhov
> > Cc: Henrik Rydberg
> > Cc: Benjamin Tissoires
> > Cc: linux-in...@vger.kernel.
gt;> change).
> >
> > I don't think this is the point of shutdown, but I could be corrected.
> > Shutdown isn't really supposed to be the same as driver remove or
> > anything. IIUC the main point of shutdown is to support kexec and the
> > goal is to quiesce DMA t
is 0, even no DPAD
> buttons pressed. When you send HID report with D-DPAD buttons with
> different state, it doesn't generate any axis events because the HatDir
> internally is still 0 regardless the report value of the 4 DPAD usages.
That's the part I am a little bit stuck. I can emu
Hi,
On Tue, Nov 3, 2020 at 10:09 AM Hans de Goede wrote:
>
> Hi,
>
> On 11/3/20 2:46 AM, Rob Herring wrote:
> > On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson
> > wrote:
> >>
> >> This exports some things from i2c-hid so that we can have a driver
> >> that's effectively a subclass of it and
Hi Chris,
On Sun, Nov 1, 2020 at 8:35 PM Chris Ye wrote:
>
> Generic Desktop DPAD usage is mapped by hid-input, that only the first
> DPAD usage maps to usage type EV_ABS and code of an axis. If HID
> descriptor has DPAD UP/DOWN/LEFT/RIGHT HID usages and each of usage size
> is 1 bit, then only
On Fri, Oct 30, 2020 at 7:00 PM Rob Herring wrote:
>
> On Fri, Oct 30, 2020 at 11:51:53AM +0100, Benjamin Tissoires wrote:
> > Hi Doug,
> >
> > Foreword: I was about to say "yeah, whatever" to please Rob for once.
>
> Read my other reply first... I t
Hi Doug,
On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson wrote:
>
> The Goodix GT7375P touchscreen uses i2c-hid so we can support it with
> just a few changes to the i2c-hid driver. Specifically this
> touchscreen needs to control a reset GPIO during its power sequencing.
>
> The Goodix timing
@@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Goodix GT7375P touchscreen
> +
>
Hi Doug,
Foreword: I was about to say "yeah, whatever" to please Rob for once.
But after re-reading this and more specifically patch 3 of the series,
that won't do. More comments inlined.
On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson wrote:
>
> As pointed out by Rob Herring [1], we should
...@vger.kernel.org # 5.3+
Signed-off-by: Benjamin Tissoires
---
drivers/input/mouse/elantech.c | 161 +++--
1 file changed, 91 insertions(+), 70 deletions(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 90f8765f9efc..ff8e5fb61dab 100644
On Tue, Sep 1, 2020 at 11:52 AM Marc Zyngier wrote:
>
> When calling into hid_map_usage(), the passed event code is
> blindly stored as is, even if it doesn't fit in the associated bitmap.
>
> This event code can come from a variety of sources, including devices
> masquerading as input devices,
On Thu, Aug 27, 2020 at 11:33 AM Jiri Kosina wrote:
>
> On Wed, 26 Aug 2020, Marc Zyngier wrote:
>
> > When calling into hid_map_usage(), the passed event code is
> > blindly stored as is, even if it doesn't fit in the associated bitmap.
> >
> > This event code can come from a variety of sources,
On Tue, Sep 1, 2020 at 10:14 AM Jiri Kosina wrote:
>
> On Sat, 29 Aug 2020, Marc Zyngier wrote:
>
> > It appears that a ReportSize value of zero is legal, even if a bit
> > non-sensical. Most of the HID code seems to handle that gracefully,
> > except when computing the total size in bytes. When
seem to be in some presets.)
> > >
> > > This is based on the staging/hwmon tree.
> > >
> > > Signed-off-by: Marius Zachmann
> >
> > For my reference:
> >
> > Reviewed-by: Guenter Roeck
> >
> > Waiting for Ack from HID mai
Hi Marius,
On Wed, Jun 24, 2020 at 10:16 AM Marius Zachmann wrote:
>
> Signed-off-by: Marius Zachmann
I wasn't Cc-ed on the cover letter (0/3) if any, but there are a few
things to improve here (not code wise, I haven't reviewed the series,
but on the form).
Every commit needs a commit
[adding Cristian, the author of the patch]
On Tue, Jun 23, 2020 at 2:37 AM Stephen Rothwell wrote:
>
> Hi all,
>
> On Sun, 21 Jun 2020 14:04:21 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> >
On Mon, Jun 1, 2020 at 7:13 PM Jiri Kosina wrote:
>
> On Fri, 29 May 2020, Dmitry Torokhov wrote:
>
> > > > > > > usbhid tries to give the device 50 milliseconds to drain its
> > > > > > > queues
> > > > > > > when opening the device, but does it naively by simply sleeping
> > > > > > > in open
On Wed, May 27, 2020 at 11:24 AM Benjamin Tissoires
wrote:
>
> On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng
> wrote:
> >
> >
> >
> > > On May 26, 2020, at 16:43, Benjamin Tissoires
> > > wrote:
> > >
> > > On Tue, May 26, 2020 at
On Wed, May 27, 2020 at 11:22 AM Benjamin Tissoires
wrote:
>
> On Wed, May 27, 2020 at 8:18 AM Kai-Heng Feng
> wrote:
> >
> >
> >
> > > On May 26, 2020, at 23:07, Benjamin Tissoires
> > > wrote:
> > >
> > > Two touchpad/trackstic
On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng
wrote:
>
>
>
> > On May 26, 2020, at 16:43, Benjamin Tissoires
> > wrote:
> >
> > On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote:
> >>
> >> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
> &g
On Wed, May 27, 2020 at 8:18 AM Kai-Heng Feng
wrote:
>
>
>
> > On May 26, 2020, at 23:07, Benjamin Tissoires
> > wrote:
> >
> > Two touchpad/trackstick combos are currently not behaving properly.
> > They define a mouse emulation collection, as per
for it, and manually add the 2 devices we know about.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=207235
Cc: sta...@vger.kernel.org
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-multitouch.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/hid
On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote:
>
> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
>
> > After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes"),
> > MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL
> > redundant.
> >
> > Remove MT_CLS_WIN_8_DUAL
Hi Mazin
On Sun, Oct 20, 2019 at 6:43 AM Mazin Rezk wrote:
>
> This patch allows hidpp_report_is_connect_event to support
> WirelessDeviceStatus connect events.
>
> The WirelessDeviceStatus feature index is stored in hidpp_device when
> probed. The connect event's fap feature_index is compared
Hi Mazin,
On Sun, Oct 20, 2019 at 6:41 AM Mazin Rezk wrote:
>
> This patch allows short reports to be translated into long reports.
>
> hidpp_validate_device now returns a u8 instead of a bool which represents
> the supported reports. The corresponding bits (i.e.
> HIDPP_REPORT_*_SUPPORTED) are
Hi Candle,
On Mon, Oct 21, 2019 at 9:54 AM Candle Sun wrote:
>
> Hi,
>
>
> On Mon, Oct 21, 2019 at 3:38 PM Candle Sun wrote:
> >
> > From: Candle Sun
> >
> > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation
> > to Main item") adds support for Usage Page item after Usage
On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk wrote:
>
> This patch allows WirelessDeviceStatus (0x1d4b) events to be detected as
> connection events in the hid-logitech-hidpp module.
>
> Devices with HIDPP_QUIRK_WIRELESS_DEVICE_STATUS use WirelessDeviceStatus
> instead of traditional connect
Hi Mazin,
On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk wrote:
>
> This patch adds support for the MX Master (b01e and b012) and also adds
> foundational code for other Bluetooth LE HID++ devices to be added.
>
> Some devices do not support short reports and thus have a quirk
>
On Wed, Oct 16, 2019 at 5:12 PM Kai-Heng Feng
wrote:
>
> Runtime power management in i2c-hid brings lots of issues, such as:
> - When transitioning from display manager to desktop session, i2c-hid
> was closed and opened, so the device was set to SLEEP and ON in a short
> period. Vendors
y attempt to
> trun) as well as missing support for any FF action.
>
> Thanks,
> Andrey Smirnov
>
> Changes since [v2]:
>
> - Fixes a buggy validity check "HID: logitech-hidpp: rework
> device validation" as pointed out by Benjamin Ti
On Wed, Oct 16, 2019 at 9:38 PM Andrey Smirnov wrote:
>
> On Wed, Oct 16, 2019 at 12:24 PM Benjamin Tissoires
> wrote:
> >
> > Hi Andrey,
> >
> > On Wed, Oct 16, 2019 at 8:30 PM Andrey Smirnov
> > wrote:
> > >
> &
ps://bugzilla.kernel.org/show_bug.cgi?id=204191
> Reported-by: Sam Bazely
> Signed-off-by: Andrey Smirnov
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: Henrik Rydberg
> Cc: Pierre-Loup A. Griffais
> Cc: Austin Palmer
> Cc: linux-in.
On Sat, Oct 12, 2019 at 1:33 AM Andrey Smirnov wrote:
>
> On Fri, Oct 11, 2019 at 3:33 PM Benjamin Tissoires
> wrote:
> >
> > On Fri, Oct 11, 2019 at 9:39 PM Andrey Smirnov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 7:56 AM Benjamin Tissoire
On Sat, Oct 12, 2019 at 1:24 AM Dmitry Torokhov
wrote:
>
> On Sat, Oct 12, 2019 at 12:48:42AM +0200, Benjamin Tissoires wrote:
> > On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov
~~~
> > drivers//hid/hid-logitech-hidpp.c:3794:5: note: in expansion of macro
> > 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
> > HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
> > ^~
> >
> > > > include/linux/bits.h:8:26: warning: l
On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov
wrote:
>
> On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov wrote:
> > On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote:
> > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote:
> &g
On Fri, Oct 11, 2019 at 10:33 PM Dmitry Torokhov
wrote:
>
> On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote:
> > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjami
On Fri, Oct 11, 2019 at 9:39 PM Andrey Smirnov wrote:
>
> On Fri, Oct 11, 2019 at 7:56 AM Benjamin Tissoires
> wrote:
> >
> > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov
> > wrote:
> > >
> > > G920 device only advertises REPORT_ID_HIDPP_LONG a
On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov
wrote:
>
> On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjamin Tissoires wrote:
> > Hi Andrey,
> >
> > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov
> > wrote:
> > >
> > > To simplify re
Hi Andrey,
On Fri, Oct 11, 2019 at 8:19 PM Andrey Smirnov wrote:
>
> On Fri, Oct 11, 2019 at 7:52 AM Benjamin Tissoires
> wrote:
> >
> > Hi Andrey,
> >
> > On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov
> > wrote:
> > >
> > > To si
e you are missing my acked by:
Acked-by: Benjamin Tissoires
Also, don't we want to send this one to stable as well? I can't
remember if we reverted it in all the released kernels.
Cheers,
Benjamin
> ---
> drivers/input/mouse/elantech.c | 55 ++
> 1 file change
a.kernel.org/show_bug.cgi?id=204191
> Reported-by: Sam Bazely
> Signed-off-by: Andrey Smirnov
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: Henrik Rydberg
> Cc: Sam Bazely
> Cc: Pierre-Loup A. Griffais
> Cc: Austin Palmer
> Cc: linux-in...@vger.k
Hi,
Finally, someone who takes care of the G920!
Note that when I sent my first initial version that Hans reused, I
surely broke it (looking at your patch 3/3), but no one cared to test
it :(
On Mon, Oct 7, 2019 at 7:13 AM Andrey Smirnov wrote:
>
> Everyone:
>
> This series contains patches to
t;
> Signed-off-by: Andrey Smirnov
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: Henrik Rydberg
> Cc: Sam Bazely
> Cc: Pierre-Loup A. Griffais
> Cc: Austin Palmer
> Cc: linux-in...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: sta...@vger.kernel.
Hi,
[Adding Mika, who introduced runpm in i2c-hid]
few questions, remarks:
On Tue, Oct 8, 2019 at 10:26 PM Hans de Goede wrote:
>
> Hi,
>
> On 08-10-2019 17:38, Kai-Heng Feng wrote:
> > Runtime power management in i2c-hid brings lots of issues, such as:
> > - When transitioning from display
On Fri, Oct 11, 2019 at 10:49 AM Filipe Laíns wrote:
>
> On Fri, 2019-10-11 at 00:57 +, Mazin Rezk wrote:
> > On Saturday, October 5, 2019 9:04 PM, Mazin Rezk <
> > mn...@protonmail.com> wrote:
> >
> > > This patch adds support for several MX mice over Bluetooth. The
> > > device IDs
> > >
On Fri, Oct 11, 2019 at 2:58 AM Mazin Rezk wrote:
>
> On Saturday, October 5, 2019 9:05 PM, Mazin Rezk wrote:
>
> > This patch makes WirelessDeviceStatus (0x1d4b) events get detected as
> > connection events on devices with HIDPP_QUIRK_WIRELESS_DEVICE_STATUS.
> >
> > This quirk is currently an
On Fri, Oct 11, 2019 at 10:33 AM Benjamin Tissoires
wrote:
>
> On Fri, Oct 11, 2019 at 2:57 AM Mazin Rezk wrote:
> >
> > On Saturday, October 5, 2019 9:04 PM, Mazin Rezk
> > wrote:
> >
> > > This patch adds support for the 0x0001 (FeatureSet) feature
On Fri, Oct 11, 2019 at 2:57 AM Mazin Rezk wrote:
>
> On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote:
>
> > This patch adds support for the 0x0001 (FeatureSet) feature. This feature
> > is used to look up the feature ID of a feature index on a device and list
> > the total count of
On Fri, Oct 11, 2019 at 2:57 AM Mazin Rezk wrote:
>
> On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote:
>
> > This patch allows the hid-logitech-hidpp module to support devices that do
> > not have support for Short HID++ reports. So far, it seems that Bluetooth
> > HID++ 2.0 devices are
Hi Mazin,
On Fri, Oct 11, 2019 at 2:57 AM Mazin Rezk wrote:
>
> On Saturday, October 5, 2019 9:04 PM, Mazin Rezk wrote:
>
> > This patch adds support for several MX mice over Bluetooth. The device IDs
> > have been copied from the libratbag device database and their features
> > have been based
On Wed, Oct 9, 2019 at 2:54 PM Candle Sun wrote:
>
> From: Candle Sun
>
> Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation
> to Main item") adds support for Usage Page item after Usage ID items
> (such as keyboards manufactured by Primax).
>
> Usage Page concatenation in
On Thu, Oct 10, 2019 at 5:19 AM Candle Sun wrote:
>
> On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote:
> >
> > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote:
> >
> > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> > > > index 3eaee2c..3394222 100644
> > > > ---
put on this one, but, sure, looks good to me:
Acked-By: Benjamin Tissoires
Cheers,
Benjamin
> ---
> drivers/input/input-poller.c | 9 +
> include/linux/input.h| 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/input/input-poller.c b/drivers/input/in
Hi,
[also addingg Nicolas, the author of 58e75155009c]
On Mon, Sep 30, 2019 at 10:10 AM Candle Sun wrote:
>
> From: Candle Sun
>
> Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation
> to Main item") adds support for Usage Page item following Usage items
> (such as
On Wed, Sep 25, 2019 at 1:48 PM Dan Carpenter wrote:
>
> On Mon, Sep 23, 2019 at 01:04:13PM +0200, Jiri Kosina wrote:
> > On Sun, 22 Sep 2019, Colin King wrote:
> >
> > > From: Colin Ian King
> > >
> > > There is an if statement that is indented by one extra space,
> > > fix this by removing the
Hi,
On Wed, Sep 25, 2019 at 11:43 AM You-Sheng Yang
wrote:
>
> According to HID over I2C specification v1.0 section 7.2.8, a device is
> allowed to take at most 1 second to make the transition to the specified
> power state. On some touchpad devices implements Microsoft Precision
> Touchpad, it
On Thu, Aug 29, 2019 at 1:26 AM Joshua Clayton wrote:
>
> ping?
> I'd love to see this get in.
> with distro kernel I have effectively no dmesg due to this issue
Apologies for the delay.
I really thought we should find a better way of fixing this, until I
got a laptop affected by it. This
=203467
Fixes: Fixes: 738c06d0e456 ("Input: elan_i2c - add hardware ID for multiple
Lenovo laptops")
Signed-off-by: Benjamin Tissoires
---
Note to self: once this gets in, we need to send a similar patch
to stable, as there are a few stable branches with this PnpID.
include/linux/
the series
above.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=204733
Link: https://bugzilla.kernel.org/show_bug.cgi?id=204771
Signed-off-by: Benjamin Tissoires
---
Hi,
this is a stable only patch aimed at kernels v5.2 and v4.19 branches.
We already have 2 bug reports of a failing touchpad
On Tue, Sep 3, 2019 at 8:33 PM João Moreno wrote:
>
> Hi Benjamin,
>
> On Tue, 3 Sep 2019 at 16:46, Benjamin Tissoires
> wrote:
> >
> > From: Joao Moreno
> >
> > This fixes an issue in which key down events for function keys would be
> > repe
On Tue, Sep 3, 2019 at 4:15 PM Bastien Nocera wrote:
>
> Hey,
>
> On Tue, 2019-07-02 at 10:39 +0200, Bastien Nocera wrote:
> > From: Bastien Nocera
> >
> > Add a new hid driver for the Creative SB0540 IR receiver. This
> > receiver
> > is usually coupled with an RM-1500 or an RM-1800 remote
, release F5
- fnmode=2: hold F5, hold FN, release F5, release FN
The repeated F5 key down events can be easily verified using xev.
Signed-off-by: Joao Moreno
Co-developed-by: Benjamin Tissoires
Signed-off-by: Benjamin Tissoires
---
Hi Joao,
last chance to pull back :)
If you are still happy
Hi João,
On Mon, Sep 2, 2019 at 4:44 PM João Moreno wrote:
>
> Hi Benjamin,
>
> First of all, sorry for the late reply. Turns out a newborn baby can
> keep one quite busy, who would have known? :)
heh. Well, congrats!
>
> On Tue, 27 Aug 2019 at 18:57, Benjamin Tissoires
Hi João,
On 8/12/19 6:57 PM, Benjamin Tissoires wrote:
> Hi João,
>
> On Thu, Aug 8, 2019 at 10:35 PM João Moreno wrote:
>>
>> Hi Benjamin,
>>
>> On Mon, 8 Jul 2019 at 22:35, João Moreno wrote:
>>>
>>> Hi Benjamin,
>>>
>
Hi Pedro,
On Fri, Aug 23, 2019 at 5:51 PM Pedro Vanzella wrote:
>
> Newer Logitech mice report their battery voltage through feature 0x1001
> instead of the battery levels through feature 0x1000.
>
> When the device is brought up and we try to query the battery, figure
> out if it supports the
On Fri, Aug 23, 2019 at 4:48 PM Filipe Laíns wrote:
>
> On Fri, 2019-08-23 at 16:32 +0200, Benjamin Tissoires wrote:
> > The problem I have with quirks, and that I explained to Filipe on IRC
> > is that this is kernel ABI. Even if there is a very low chance we have
> >
1 - 100 of 4109 matches
Mail list logo
