Re: [v3,1/3] thermal: mediatek: Relocate driver to mediatek folder

On 12/03/2021 04:40, Michael Kao wrote: > Add Mediatek proprietary folder to upstream more thermal zone and cooler > drivers. Relocate the original thermal controller driver to it and rename > as soc_temp.c to show its purpose more clearly. We already know the purpose :) soc_temp gives no

Re: [PATCH v2 2/2] thermal: power_allocator: update once cooling devices when temp is low

On 20/04/2021 22:01, Lukasz Luba wrote: > > > On 4/20/21 4:24 PM, Daniel Lezcano wrote: >> On 20/04/2021 16:21, Lukasz Luba wrote: >>> Hi Daniel, >>> >>> On 4/20/21 2:30 PM, Daniel Lezcano wrote: >>>> On 19/04/2021 10:45, Lukasz Luba wrote:

Re: [PATCH v2] thermal: mediatek: add sensors-support

On 20/04/2021 17:54, Frank Wunderlich wrote: > From: Frank Wunderlich > > add HWMON-support to mediateks thermal driver to allow lm-sensors > userspace tools read soc temperature > > Signed-off-by: Frank Wunderlich > --- > v2: drop ifdef and used devm_thermal_add_hwmon_sysfs > --- >

Re: [PATCH v2 1/1] thermal: ti-soc-thermal: Remove duplicated header file inclusion

On 06/04/2021 11:19, Zhen Lei wrote: > Delete one of the header files that are included > twice, all included header files are then rearranged alphabetically. The duplicate header file inclusion has been already fixed in a previous patch. Applied this patch by massaging the changelog

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

On 20/04/2021 17:24, Frank Wunderlich wrote: > Am 20. April 2021 17:18:32 MESZ schrieb Daniel Lezcano > : >> >> Hi Frank, > >> The no_hwmon usage is a bit fuzzy in the thermal core code. > > Maybe add depency in Kconfig? Else we can get undefined symbols on

Re: [PATCH v2 2/2] thermal: power_allocator: update once cooling devices when temp is low

On 20/04/2021 16:21, Lukasz Luba wrote: > Hi Daniel, > > On 4/20/21 2:30 PM, Daniel Lezcano wrote: >> On 19/04/2021 10:45, Lukasz Luba wrote: > > [snip] > >>> -    instance->cdev->updated = false; >>> +    if (update)

Re: Aw: Re: [PATCH] thermal: mediatek: add sensors-support

Hi Frank, On 20/04/2021 16:59, Frank Wunderlich wrote: > Hi, > >> Gesendet: Dienstag, 20. April 2021 um 14:07 Uhr >> Von: "Daniel Lezcano" > >> No #ifdef in C file. > ... > >> devm_thermal_add_hwmon_sysfs() ? > > based on your co

Re: [PATCH v2 2/2] thermal: power_allocator: update once cooling devices when temp is low

ce state has not changed because the temperature is still > below the first activation trip point value, so we can do this. > Add a tracking mechanism to make sure it updates cooling devices only > once - when the temperature dropps below first trip point. > > Reported-by: Daniel Lezca

Re: [PATCH] thermal: mediatek: add sensors-support

On 20/03/2021 09:06, Frank Wunderlich wrote: > From: Frank Wunderlich > > add HWMON-support to mediateks thermanl driver to allow lm-sensors > userspace tools read soc temperature > > Signed-off-by: Frank Wunderlich > --- > drivers/thermal/mtk_thermal.c | 22 ++ > 1 file

Re: [PATCH] [v4, 1/1] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on shutdown

On 09/04/2021 11:22, Fengquan Chen wrote: > mtk_syst_clkevt_shutdown is called after irq disabled in suspend flow, > clear any pending systimer irq when shutdown to avoid suspend aborted > due to timer irq pending > > Also as for systimer in mediatek socs, there must be firstly enable > timer

Re: [PATCH v3] drivers/clocksource/mediatek: Ack and disable interrupts on suspend

On 12/04/2021 05:22, Evan Benn wrote: > Interrupts are disabled during suspend before this driver disables its > timers. ARM trusted firmware will abort suspend if the timer irq is > pending, so ack and disable the timer interrupt during suspend. > > Signed-off-by: Evan Benn > --- > > Changes

Re: [PATCH v7 2/9] reboot: thermal: Export hardware protection shutdown

On 14/04/2021 07:52, Matti Vaittinen wrote: > Thermal core contains a logic for safety shutdown. System is attempted to > be powered off if temperature exceeds safety limits. > > Currently this can be also utilized by regulator subsystem as a final > protection measure if PMICs report dangerous

Re: [PATCH v7 2/9] reboot: thermal: Export hardware protection shutdown

On 14/04/2021 07:52, Matti Vaittinen wrote: > Thermal core contains a logic for safety shutdown. System is attempted to > be powered off if temperature exceeds safety limits. > > Currently this can be also utilized by regulator subsystem as a final > protection measure if PMICs report dangerous

Re: [v7,3/3] thermal: mediatek: add another get_temp ops for thermal sensors

On 16/03/2021 08:01, Michael Kao wrote: > Provide thermal zone to read thermal sensor > in the SoC. We can read all the thermal sensors > value in the SoC by the node /sys/class/thermal/ > > In mtk_thermal_bank_temperature, return -EAGAIN instead of -EACCESS > on the first read of sensor that

Re: [v7,1/3] arm64: dts: mt8183: add thermal zone node

On 16/03/2021 08:01, Michael Kao wrote: > From: "michael.kao" > > Add thermal zone node to Mediatek MT8183 dts file. > > Evaluate the thermal zone every 500ms while not cooling > and every 100ms when passive cooling is performed. > > Signed-off-by: Matthias Kaehlcke > Signed-off-by: Michael

Re: [GIT PULL] cpuidle for v5.13-rc1

On 08/04/2021 19:24, Rafael J. Wysocki wrote: > On Thu, Apr 8, 2021 at 5:10 PM Daniel Lezcano > wrote: >> >> >> Hi Rafael, >> >> please consider pulling the following change for cpuidle on ARM for >> v5.13-rc1 >> >> Thanks >>

[GIT PULL] cpuidle for v5.13-rc1

Hi Rafael, please consider pulling the following change for cpuidle on ARM for v5.13-rc1 Thanks -- Daniel The following changes since commit dde8740bd9b505c58ec8b2277d5d55c6951b7e42: Merge branch 'acpi-processor-fixes' into linux-next (2021-04-07 19:02:56 +0200) are available in the

[GIT PULL] timer drivers for v5.13

Hi Thomas, please consider these changes for v5.13 Thanks -- Daniel The following changes since commit d4c7c28806616809e3baa0b7cd8c665516b2726d: timekeeping: Allow runtime PM from change_clocksource() (2021-03-29 16:41:59 +0200) are available in the Git repository at:

Re: [v3,1/3] thermal: mediatek: Relocate driver to mediatek folder

On 07/04/2021 11:08, Michael Kao wrote: > Hi Maintainers, > > Gentle pin for this patch. > > Thanks ack, pong -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook |

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

On 06/04/2021 20:38, Lukasz Luba wrote: [ ... ] >> But there is still the polling delay because the governor is IPA in this >> case? There is also an additional trip-point0 which is not a target for >> a cooling device, just put there to ensure the IPA has enough data when >> reaching the second

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

Hi Lukasz, On 06/04/2021 14:25, Lukasz Luba wrote: > > > On 4/6/21 12:24 PM, Daniel Lezcano wrote: >> On 06/04/2021 12:39, Lukasz Luba wrote: >>> >>> >>> On 4/6/21 11:16 AM, Daniel Lezcano wrote: >>>> On 06/04/2021 10:44, Lukasz Luba wrot

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

On 06/04/2021 12:39, Lukasz Luba wrote: > > > On 4/6/21 11:16 AM, Daniel Lezcano wrote: >> On 06/04/2021 10:44, Lukasz Luba wrote: >>> >>> >>> On 4/2/21 4:54 PM, Daniel Lezcano wrote: >>>> On 31/03/2021 18:33, Lukasz Luba wrote: >>>&

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

On 06/04/2021 10:44, Lukasz Luba wrote: > > > On 4/2/21 4:54 PM, Daniel Lezcano wrote: >> On 31/03/2021 18:33, Lukasz Luba wrote: >>> When the temperature is below the first activation trip point the >>> cooling >>> devices are not checked, so they cann

Re: [PATCH v14 0/9] Add support for ipq8064 tsens

On 04/04/2021 16:48, Ansuel Smith wrote: > This patchset convert msm8960 to reg_filed, use int_common instead > of a custom function and fix wrong tsens get_temp function for msm8960. > Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs > to be registered as a gcc child as the

Re: linux-next: Fixes tag needs some work in the thermal tree

On 06/04/2021 00:35, Stephen Rothwell wrote: > Hi all, > > In commit > > 5845dd350432 ("thermal/drivers/tsens: Fix missing put_device error") > > Fixes tag > > Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into > > has these problem(s): > > - Subject has leading

Re: [PATCH v2 1/8] dt-bindings: timer: Add compatible for Mediatek MT8195

On 29/03/2021 13:52, Matthias Brugger wrote: > > > On 19/03/2021 03:34, Seiya Wang wrote: >> This commit adds dt-binding documentation of timer for Mediatek MT8195 SoC >> Platform. >> >> Signed-off-by: Seiya Wang > > Applied to v5.12-next/dts64 Usually bindings go through the subsystem

Re: [PATCH v3 1/2] dt-bindings: thermal: qcom-tsens: Add compatible for sm8350

On 24/03/2021 13:43, Robert Foss wrote: > Add tsens bindings for sm8350. > > Signed-off-by: Robert Foss > Reviewed-by: Vinod Koul > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 05/14] dt-bindings: timer: nuvoton,npcm7xx: Add wpcm450-timer

On 20/03/2021 19:16, Jonathan Neuschäfer wrote: > Add a compatible string for WPCM450, which has essentially the same > timer controller. > > Signed-off-by: Jonathan Neuschäfer > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH][next] thermal/drivers/devfreq_cooling: Fix error return if kasprintf returns NULL

Hi Colin, On 25/03/2021 18:21, Colin King wrote: > From: Colin Ian King > > Currently when kasprintf fails and returns NULL, the error return -ENOMEM > is being assigned to cdev instead of err causing the return via the label > remove_qos_re to return the incorrect error code. Fix this by

Re: [PATCH 1/2] thermal: power_allocator: maintain the device statistics from going stale

On 31/03/2021 18:33, Lukasz Luba wrote: > When the temperature is below the first activation trip point the cooling > devices are not checked, so they cannot maintain fresh statistics. It > leads into the situation, when temperature crosses first trip point, the > statistics are stale and show

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

tlin.com/linux/latest/source/include/linux/clockchips.h#L120 > > > On Thu, 25 Mar 2021 at 19:10, Daniel Lezcano > wrote: >> >> On 25/03/2021 02:35, Evan Benn wrote: >>> set_state_shutdown is called during system suspend after interrupts have >>> been disabled

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

On 02/04/2021 10:02, Greg KH wrote: > On Fri, Apr 02, 2021 at 12:08:49AM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 01/04/2021 21:28, Greg KH wrote: >>> On Thu, Apr 01, 2021 at 08:36:49PM +0200, Daniel Lezcano wrote: >>>> A SoC can be

Re: [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

On 01/04/2021 21:37, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:36:54PM +0200, Daniel Lezcano wrote: [ ... ] > Why have you not documented all of this in Documentation/ABI so that we > can find it later? You are right, I will write some documentation. >> Signed-off-by:

Re: [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

On 01/04/2021 21:37, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:36:54PM +0200, Daniel Lezcano wrote: [ ... ] > Why have you not documented all of this in Documentation/ABI so that we > can find it later? You are right, I will write some documentation. >> Signed-off-by:

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

insertion(+), 1 deletion(-) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index f32ebcff37d2..fe34f56acb0f 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -17774,7 +17774,7 @@ THERMAL/CPU_COOLING >>>   M:    Amit Daniel Ka

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

Hi Greg, On 01/04/2021 21:28, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:36:49PM +0200, Daniel Lezcano wrote: >> A SoC can be differently structured depending on the platform and the >> kernel can not be aware of all the combinations, as well as the >> specific tweaks f

[PATCH v6 6/7] powercap/drivers/dtpm: Export the symbols for the modules

The DTPM framework provides a generic API to register devices which power capable. The devices may be compiled as modules while the framework is not. Export the necessary API to let the drivers register themselves. Signed-off-by: Daniel Lezcano --- drivers/powercap/dtpm.c | 4 1 file

[PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

m:0:0/dtpm:0:0:1/power Signed-off-by: Daniel Lezcano --- drivers/powercap/Kconfig | 8 ++ drivers/powercap/Makefile| 1 + drivers/powercap/dtpm_configfs.c | 202 +++ include/linux/dtpm.h | 2 + 4 files changed, 213 insertions(+) c

[PATCH v6 5/7] powercap/drivers/dtpm: Scale the power with the load

ange: ~$ ~/dhrystone -t 1 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 113 ~$ ~/dhrystone -t 2 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 226 Signed-off-by: Daniel Lezcano Reviewe

[PATCH v6 3/7] powercap/drivers/dtpm: Simplify the dtpm table

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 4 ++-- drivers/powercap/dtpm_cpu.c | 4 +++- include/linux/dtpm.h| 20 +--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c

[PATCH v6 4/7] powercap/drivers/dtpm: Use container_of instead of a private data field

allocating the device specific dtpm structure. The dtpm_init() is provided instead. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 18 +-- drivers/powercap/dtpm_cpu.c | 46 ++--- include/linux/dtpm.h| 3 +-- 3

[PATCH v6 1/7] powercap/drivers/dtpm: Encapsulate even more the code

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V4: - Replaced s/sprintf/snprintf/ for the dtpm node name V2: - Updated the changelog with the CPU node not being removed - Commented the cpu hotplug callbacks to explain why there are two callbacks - Changed 'upt_power_uw' to 'update_power_uw

[PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

. If a specified name is not found in the list, it is assumed to be a virtual node which will have children and the default is to allocate such node. Cc: Greg KH Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V6: - Added the EXPORT_SYMBOL_GPL V5: - Decrease log level from 'info' to 'debug

Re: [PATCH] clocksource/arm_arch_timer: add __ro_after_init and __init

On 01/04/2021 10:31, Marc Zyngier wrote: > On Tue, 30 Mar 2021 07:04:44 +0100, > Jisheng Zhang wrote: >> >> Some functions are not needed after booting, so mark them as __init >> to move them to the .init section. >> >> Some global variables are never modified after init, so can be >>

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

On 01/04/2021 08:02, Greg KH wrote: > On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 31/03/2021 20:06, Greg KH wrote: >>> On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: >>>> +struct dtpm

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

Hi Greg, On 31/03/2021 20:06, Greg KH wrote: > On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: >> +struct dtpm *dtpm_lookup(const char *name); >> + >> +int dtpm_add(const char *name, struct dtpm *dtpm); >> + >> +void dtpm_del(const char *name)

Re: [PATCH v2] thermal: cpufreq_cooling: fix slab OOB issue

On 29/12/2020 06:08, Michael Kao wrote: > From: brian-sy yang > > Slab OOB issue is scanned by KASAN in cpu_power_to_freq(). > If power is limited below the power of OPP0 in EM table, > it will cause slab out-of-bound issue with negative array > index. > > Return the lowest frequency if limited

Re: [PATCH] thermal/drivers/hisi: Use the correct HiSilicon copyright

On 30/03/2021 08:45, Hao Fang wrote: > s/Hisilicon/HiSilicon/g. > It should use capital S, according to > https://www.hisilicon.com/en/terms-of-use. > > Signed-off-by: Hao Fang > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH] thermal: ti-soc-thermal: of_device.h is included twice

On 23/03/2021 03:14, Wan Jiabing wrote: > linux/of_device.h has been included at line 25, so remove > the duplicate one at line 35. > > Signed-off-by: Wan Jiabing > --- Thanks for your patch. It was actually already fixed [1]. -- D. [1]

Re: [PATCH] clocksource/arm_arch_timer: add __ro_after_init and __init

Hi, On 30/03/2021 08:04, Jisheng Zhang wrote: > Some functions are not needed after booting, so mark them as __init > to move them to the .init section. > > Some global variables are never modified after init, so can be > __ro_after_init. > > Signed-off-by: Jisheng Zhang Mar[ck] ? Any

[PATCH v5 4/5] powercap/drivers/dtpm: Use container_of instead of a private data field

allocating the device specific dtpm structure. The dtpm_init() is provided instead. Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 24 +-- drivers/powercap/dtpm_cpu.c | 46 ++--- include/linux/dtpm.h| 3

[PATCH v5 5/5] powercap/drivers/dtpm: Scale the power with the load

ange: ~$ ~/dhrystone -t 1 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 113 ~$ ~/dhrystone -t 2 -l 1& ~$ cat /sys/devices/virtual/powercap/dtpm/dtpm:0/dtpm:0:1/constraint_0_max_power_uw 226 Signed-off-by: Daniel Lezcano Reviewe

[PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

. If a specified name is not found in the list, it is assumed to be a virtual node which will have children and the default is to allocate such node. Cc: Greg KH Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V5: - Decrease log level from 'info' to 'debug' - Remove the refcount

[PATCH v5 1/5] powercap/drivers/dtpm: Encapsulate even more the code

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- V4: - Replaced s/sprintf/snprintf/ for the dtpm node name V2: - Updated the changelog with the CPU node not being removed - Commented the cpu hotplug callbacks to explain why there are two callbacks - Changed 'upt_power_uw' to 'update_power_uw

[PATCH v5 3/5] powercap/drivers/dtpm: Simplify the dtpm table

-by: Daniel Lezcano Reviewed-by: Lukasz Luba --- drivers/powercap/dtpm.c | 4 ++-- drivers/powercap/dtpm_cpu.c | 4 +++- include/linux/dtpm.h| 20 +--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c

Re: [PATCH v2 2/2] thermal: qcom-spmi-temp-alarm: add support for GEN2 rev 1 PMIC peripherals

>>> major revision 1. This revision utilizes a different temperature >>> threshold mapping than earlier revisions. >>> >>> Signed-off-by: David Collins >>> Signed-off-by: Guru Das Srinagesh >>> --- >> >> Reviewed-by: Stephen Boyd &g

Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

On 28/03/2021 21:31, Srinivas Pandruvada wrote: > Hi Daniel, [ ... ] >> I don't see where is the problem. The protocol is still compatible >> with >> the previous version, so that does not break the existing AFAICT. >> That >> is done on purpose. > > The size of netlink message is changed. This

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

On 28/03/2021 19:26, Greg KH wrote: [ ... ] >>> So why are you trying to add a kref here as the structure already has >>> support for proper lifetimes? >> >> Right, I'll revisit that part. Thanks for the review. >> >> I've a branch which is pulled by Rafael [1]. These parts are already >> merged

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

On 28/03/2021 13:24, Greg KH wrote: > On Sun, Mar 28, 2021 at 01:11:30PM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 28/03/2021 08:50, Greg KH wrote: >> >> [ ... ] >> >>>>> And any reason why you are not using "real" st

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

Hi Greg, On 28/03/2021 08:50, Greg KH wrote: [ ... ] >>> And any reason why you are not using "real" struct devices in this >>> subsystem? You seem to be rolling your own infrastructure for no good >>> reason. I imagine you want sysfs support next, right? >> >> Actually, the framework is on

Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

Hi Srinivas, On 27/03/2021 18:46, Srinivas Pandruvada wrote: > On Fri, 2021-03-26 at 17:37 +0100, Rafael J. Wysocki wrote: >> On Thu, Mar 25, 2021 at 8:38 PM Daniel Lezcano >> wrote: >>> The slope of the temperature increase or decrease can be high and >>>

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

On 27/03/2021 13:50, Greg KH wrote: > On Fri, Mar 12, 2021 at 02:04:08PM +0100, Daniel Lezcano wrote: >> A SoC can be differently structured depending on the platform and the >> kernel can not be aware of all the combinations, as well as the >> specific tweaks f

[PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

violation notification. In order to be efficient, give the temperature which resulted in the trip violation. Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c| 6 -- drivers/thermal/thermal_netlink.c | 11 ++- drivers/thermal/thermal_netlink.h | 8 include

Re: [PATCH v2] drivers/clocksource/mediatek: Ack and disable interrupts on shutdown

On 25/03/2021 02:35, Evan Benn wrote: > set_state_shutdown is called during system suspend after interrupts have > been disabled. If the timer has fired in the meantime, there will be > a pending IRQ. So we ack that now and disable the timer. Without this > ARM trusted firmware will abort the

Re: [PATCH v2 0/5] arm64: sunxi: Enable the sun4i timer

On 24/03/2021 04:51, Samuel Holland wrote: > On 3/22/21 9:18 AM, Daniel Lezcano wrote: >> On 22/03/2021 05:47, Samuel Holland wrote: >>> In preparation for adding CPU idle states, hook up the sun4i timer. >>> Having a non-c3stop clockevent source available is

Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

On 23/03/2021 16:56, Lukasz Luba wrote: > Hi Daniel, > > On 3/19/21 4:28 PM, Daniel Lezcano wrote: >> Currently the dtpm supports the CPUs via cpufreq and the energy >> model. This change provides the same for the device which supports >> devfreq. >> >> Ea

Re: [PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

On 23/03/2021 16:56, Lukasz Luba wrote: > Hi Daniel, > > On 3/19/21 4:28 PM, Daniel Lezcano wrote: >> Currently the dtpm supports the CPUs via cpufreq and the energy >> model. This change provides the same for the device which supports >> devfreq. >> >> Ea

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

On 22/03/2021 17:33, Tony Lindgren wrote: > Hi, > > * Daniel Lezcano [210322 15:56]: >> On 04/03/2021 08:37, Tony Lindgren wrote: >>> There is a timer wrap issue on dra7 for the ARM architected timer. >>> In a typical clock configuration the timer fails to wra

Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue

On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm timers instead. > > Let's prepare for adding support

Re: [PATCH v2 0/5] arm64: sunxi: Enable the sun4i timer

On 22/03/2021 05:47, Samuel Holland wrote: > In preparation for adding CPU idle states, hook up the sun4i timer. > Having a non-c3stop clockevent source available is necessary for all > CPUs to simultaneously enter a local-timer-stop idle state. Why simultaneously ? > Changes from v1: > -

Re: drivers/clocksource/dw_apb_timer_of.c:66 timer_get_base_and_rate() warn: 'timer_clk' not released on lines: 64.

On 22/03/2021 13:21, Dinh Nguyen wrote: > Hi Daniel, > > 2/21 4:58 AM, Daniel Lezcano wrote: >> >> Dinh, >> >> is it possible to have a look at this issue? >> >> Thanks >> > > Sorry, but somehow I missed cc'ing you when I first sent the

Re: [PATCH 1/2] drivers/clocksource/mediatek: Split mediatek drivers into 2 files

Hi Evan, On 18/03/2021 06:04, Evan Benn wrote: > mtk_gpt and mtk_syst drivers for mt6577 and mt6765 devices were not > sharing any code. So split them into separate files. For the sake of consistency, keeping all in one is better. Thanks -- Daniel > Signed-off-by: Evan Benn > --- > >

Re: [PATCH 10/14] clocksource/drivers/npcm: Add support for WPCM450

On 20/03/2021 19:16, Jonathan Neuschäfer wrote: > Add a compatible string for WPCM450, which has essentially the same > timer controller. > > Signed-off-by: Jonathan Neuschäfer > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940

On 04/03/2021 08:37, Tony Lindgren wrote: > There is a timer wrap issue on dra7 for the ARM architected timer. > In a typical clock configuration the timer fails to wrap after 388 days. > > To work around the issue, we need to use timer-ti-dm percpu timers instead. > > Let's configure dmtimer3

Re: [PATCH] clocksource/drivers/timer-mediatek: optimize systimer irq clear flow on Mediatek Socs

On 02/03/2021 08:28, Fengquan Chen wrote: > 1)ensure systimer is enabled before clear and disable interrupt, which only > for systimer in Mediatek Socs. > > 2)clear any pending timer-irq when shutdown to keep suspend flow clean, > when use systimer as tick-broadcast timer > > Change-Id:

Re: drivers/clocksource/dw_apb_timer_of.c:66 timer_get_base_and_rate() warn: 'timer_clk' not released on lines: 64.

Dinh, is it possible to have a look at this issue? Thanks -- Daniel On 22/02/2021 07:21, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 55f62bc873477dae2c45bbbc30b86cf3e0982f3b > commit:

Re: [PATCH] thermal/drivers/cpuidle_cooling: Fix use after error

On 22/03/2021 04:29, Viresh Kumar wrote: > On 19-03-21, 21:25, Daniel Lezcano wrote: >> When the function successfully finishes it logs an information about >> the registration of the cooling device and use its name to build the >> message. Unfortunately it was freed right

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

On 08/03/2021 16:26, Tony Lindgren wrote: > Hi, > > * Tony Lindgren [210305 07:58]: >> * Grygorii Strashko [210304 20:56]: >>> >>> >>> On 04/03/2021 09:21, Tony Lindgren wrote: We have of_translate_address() already do of_node_put() as needed. I probably looked at

Re: [RESEND PATCH v4 1/2] dt-bindings: tsens: qcom: Document MDM9607 compatible

On 20/03/2021 20:01, Konrad Dybcio wrote: > Add the compatible for MDM9607. >> Signed-off-by: Konrad Dybcio >> --- >> v4: separate from the main patch >> >> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 ++ >> 1 file changed, 2 insertions(+) > > This change was previously a-b

[PATCH] thermal/drivers/cpuidle_cooling: Fix use after error

. Fix this by freeing after the message happened. Fixes: 6fd1b186d900 ("thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering") Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/cpuidle_cooling.c | 8 +--- 1 file changed, 5 insert

[PATCH] thermal/drivers/devfreq_cooling: Fix wrong return on error path

oling: Use device name instead of auto-numbering") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drive

[PATCH] thermal: core: Fix memory leak in the error path

inter for the cooling device name") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Daniel Lezcano --- drivers/thermal/thermal_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index c8d4010940ef..3566fd291

Re: [PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

On 19/03/2021 19:05, Robin Murphy wrote: > On 2021-03-19 14:35, Daniel Lezcano wrote: >> >> Hi Robin, >> >> On 19/03/2021 13:17, Robin Murphy wrote: >>> On 2021-03-19 11:05, Daniel Lezcano wrote: >>>> The DTPM framework is looking for upstrea

[PATCH] powercap/drivers/dtpm: Add dtpm devfreq with energy model support

dtpm support: the QoS is used to aggregate the requests and the energy model gives the value of the instantaneous power consumption ponderated by the load of the device. Cc: Chanwoo Choi Cc: Lukasz Luba Cc: Kyungmin Park Cc: MyungJoo Ham Signed-off-by: Daniel Lezcano --- drivers/powercap

Re: [PATCH] MAINTAINERS: Add co-maintainer for Qualcomm tsens thermal drivers

On 19/03/2021 16:37, Thara Gopinath wrote: > Add myself as the maintainer for Qualcomm tsens drivers so that I > can help Daniel by taking care of/reviewing changes to these drivers. > > Signed-off-by: Thara Gopinath > --- Applied, thanks -- Linaro.org │ Open source

Re: [PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

Hi Robin, On 19/03/2021 13:17, Robin Murphy wrote: > On 2021-03-19 11:05, Daniel Lezcano wrote: >> The DTPM framework is looking for upstream SoC candidates to share the >> power numbers. >> >> We can see around different numbers but the one which seems to be >>

Re: [PATCH v1 2/2] arm64: dts: qcom: sm8350: Add thermal zones and throttling support

On 19/03/2021 12:24, Robert Foss wrote: > On Fri, 19 Mar 2021 at 11:49, Robert Foss wrote: >> >> sm8350 has 29 thermal sensors split across two tsens controllers. Add >> the thermal zones to expose them and wireup the cpus to throttle their >> frequencies on crossing passive temperature

[PATCH] dt: rockchip: rk3399: Add dynamic power coefficient for GPU

The DTPM framework is looking for upstream SoC candidates to share the power numbers. We can see around different numbers but the one which seems to be consistent with the initial post for the values on the CPUs can be found in the patch https://lore.kernel.org/patchwork/patch/810159/ I don't

Re: [PATCH v2 1/9] units: Add the HZ macros

Hi Rafael, is it possible to merge this series through linux-pm ? On 25/02/2021 12:22, Andy Shevchenko wrote: > On Wed, Feb 24, 2021 at 03:42:11PM +0100, Daniel Lezcano wrote: >> The macros for the unit conversion for frequency are duplicated in >> different places. >> &g

[PATCH] powercap/drivers/dtpm : Fix power limit initialization

When a DTPM node is registered its power limit must be initialized to the power max. Signed-off-by: Daniel Lezcano --- drivers/powercap/dtpm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c index a4784ac2f79b

Re: [PATCH 1/2] csky: Enable generic clockevent broadcast

state. But many other architectures(powerpc, mips, > arm, hexagon, openrisc, sh) have supported the infrastructure to > deal with Power Management issues. > > Signed-off-by: Guo Ren > Cc: Arnd Bergmann > Cc: Thomas Gleixner > Cc: Daniel Lezcano > --- Acked-by: Daniel Lezca

[GIT PULL] thermal fixes for v5.12

Hi Linus, please consider pulling this single fix for the thermal framework. Thanks -- Daniel The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at:

Re: [PATCH] thermal: power_allocator: using round the division when re-divvying up power

On 15/03/2021 10:51, Lukasz Luba wrote: > > > On 3/15/21 8:25 AM, gao.yunxi...@gmail.com wrote: >> From: "jeson.gao" >> >> The division is used directly in re-divvying up power, the decimal >> part will >> be discarded, devices will get less than the extra_actor_power - 1. >> if using round the

Re: [PATCH v2 4/5] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

On 15/03/2021 04:07, Viresh Kumar wrote: > On 12-03-21, 18:03, Daniel Lezcano wrote: >> Currently the naming of a cooling device is just a cooling technique >> followed by a number. When there are multiple cooling devices using >> the same technique, it is impossibl

Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

On 14/03/2021 13:47, Ido Schimmel wrote: > On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixed ar

[PATCH v3 5/5] thermal/drivers/cpufreq_cooling: Remove unused list

There is a list with the purpose of grouping the cpufreq cooling device together as described in the comments but actually it is unused, the code evolved since 2012 and the list was no longer needed. Delete the remaining unused list related code. Signed-off-by: Daniel Lezcano Reviewed

[PATCH v3 4/5] thermal/drivers/cpuidle_cooling: Use device name instead of auto-numbering

thermal-idle-2 thermal-idle-3 etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal prefix and changes the number by the device name. So the naming above becomes: idle-cpu0 idle-cpu1 idle-cpu2 idle-cpu3 etc ... Signed-off-by: Daniel Lezcano

[PATCH v3 2/5] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: cpufreq-cpu0 cpufreq-cpu4 etc ... Signed-off-by: Daniel Lezcano Acked-by: Viresh Kumar Reviewed-by: Lukasz

[PATCH v3 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering

etc ... The 'thermal' prefix is redundant with the subsystem namespace. This patch removes the 'thermal' prefix and changes the number by the device name. So the naming above becomes: devfreq-500.gpu devfreq-1d84000.ufshc etc ... Signed-off-by: Daniel Lezcano Reviewed-by: Lukasz Luba

[PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

path at the same time as we have to rollback the allocations in case of error. Tested with a dummy device having the name: "Llanfairpwllgwyngyllgogerychwyrndrobwantysiliogogogoch" A village on the island of Anglesey (Wales), known to have the longest name in Europe. Signed-off-

  1   2   3   4   5   6   7   8   9   10   >