Hi Guido,
On Thu, May 09, 2024 at 02:00:28PM +0200, Guido Günther wrote:
> This helps user space to figure out which keys should be used to unidle a
> device. E.g on phones the volume rocker should usually not unblank the
> screen.
How exactly this is supposed to be used? We have "disabled" keys
On Mon, Mar 11, 2024 at 11:26:16AM +0100, Karel Balej wrote:
> Krzysztof Kozlowski, 2024-03-10T21:35:36+01:00:
> > On 10/03/2024 12:35, Karel Balej wrote:
> > > Dmitry Torokhov, 2024-03-04T17:10:59-08:00:
> > >> On Mon, Mar 04, 2024 at 09:28:45PM +0100, Kar
On Sun, Mar 10, 2024 at 09:35:36PM +0100, Krzysztof Kozlowski wrote:
> On 10/03/2024 12:35, Karel Balej wrote:
> > Dmitry Torokhov, 2024-03-04T17:10:59-08:00:
> >> On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote:
> >>> Dmitry,
> >>>
> &
On Wed, Mar 06, 2024 at 03:40:05PM +0100, Duje Mihanović wrote:
> Tiny series to clean up the field extraction and add touch key support.
> This version is based on the next branch of Dmitry's input tree.
>
> Signed-off-by: Duje Mihanović
> ---
> Changes in v3:
> - Rebase on input/next
> - Add
On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote:
> Dmitry,
>
> Dmitry Torokhov, 2024-03-03T12:39:46-08:00:
> > On Sun, Mar 03, 2024 at 11:04:25AM +0100, Karel Balej wrote:
> > > From: Karel Balej
> > >
> > > Marvell 88PM886 PMIC pro
On Fri, Mar 01, 2024 at 05:40:59PM +0100, Karel Balej wrote:
> From: Karel Balej
>
> Hello,
>
> this patch series generalizes the Imagis touchscreen driver to support
> other Imagis chips, namely IST3038B and IST3032C.
>
> The motivation for IST3032C is the samsung,coreprimevelte smartphone
>
ce DT property.
> - Drop of_match_table.
I only said that you should not be using of_match_ptr(), but you still
need to have of_match_table set and have MODULE_DEVICE_TABLE() for the
proper module loading support.
With that fixed:
Acked-by: Dmitry Torokhov
Thanks.
--
Dmitry
Hi Karel,
On Sun, Dec 17, 2023 at 02:17:02PM +0100, Karel Balej wrote:
> From: Karel Balej
>
> The Marvell 88PM88X PMICs provide onkey among other things. Add client
> driver to handle it. The driver currently only provides a basic support
> omitting additional functions found in the vendor
HI,
On Thu, Apr 15, 2021 at 04:58:29PM +0800, simba.hsu wrote:
> This path makes auto-update available when IC's status is
> Recovery mode.
Could you please explain in more detail what the issue is. Also please
improve the patch subject, as "modify Raydium i2c touchscreen driver"
does not really
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
to receive updates for the input subsystem. Just a few driver fixes
here.
Changelog:
-
Arnd Bergmann (1):
Input: i8042 - fix Pegatron C15B ID entry
Caleb Connolly (1):
Hi Oleksij, Jonathan,
On Tue, Apr 13, 2021 at 11:31:05AM +0200, Oleksij Rempel wrote:
> Hi Dmitry,
>
> probably this mail passed under your radar. Can you please add your
> statement here.
Sorry, my bad, I saw "iio" and thought there is nothing for me to
comment on ;)
>
> On Mon, Mar 29, 2021
Hi Giulio, Peter,
On Wed, Apr 14, 2021 at 01:22:55PM +0200, Giulio Benetti wrote:
> Hi Peter, Dmitry,
>
> On 4/14/21 8:46 AM, Peter Hutterer wrote:
> > On Tue, Apr 13, 2021 at 10:44:07PM -0700, Dmitry Torokhov wrote:
> > > Hi Giulio,
> > >
> > > On Tue
On Tue, Apr 13, 2021 at 04:44:45PM +0200, Giulio Benetti wrote:
> This adds device tree bindings for the Hycon HY46XX touchscreen series.
>
> Signed-off-by: Giulio Benetti
Applied, thank you.
--
Dmitry
On Tue, Apr 13, 2021 at 04:44:44PM +0200, Giulio Benetti wrote:
> Update Documentation/devicetree/bindings/vendor-prefixes.yaml to
> include "hycon" as a vendor prefix for "Hycon Technology".
> Company website: https://www.hycontek.com/
>
> Signed-off-by: Giulio Benetti
> Reviewed-by: Jonathan
Hi Giulio,
On Tue, Apr 13, 2021 at 04:44:46PM +0200, Giulio Benetti wrote:
> +
> + input_mt_report_pointer_emulation(tsdata->input, true);
For touchscreens it does not make much sense to report BTN_DOUBLETAP,
BTN_TRIPLETAP, etc, events (they are really for touchpads), so I changed
this to
Hi Bartosz,
On Mon, Jun 29, 2020 at 1:56 PM Bartosz Golaszewski wrote:
>
> From: Bartosz Golaszewski
>
> Make devm_kmalloc() behave similarly to non-managed kmalloc(): return
> ZERO_SIZE_PTR when requested size is 0. Update devm_kfree() to handle
> this case.
This is wrong if you consider
to
recognize this new usage code as well.
Signed-off-by: Dmitry Torokhov
---
drivers/hid/hid-debug.c| 1 +
drivers/hid/hid-input.c| 3 +++
include/uapi/linux/input-event-codes.h | 1 +
3 files changed, 5 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid
Add missing descriptions for KEY_ASSISTANT and KEY_KBD_LAYOUT_NEXT.
Signed-off-by: Dmitry Torokhov
---
drivers/hid/hid-debug.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index 982737827b87..4d2b699daf8d 100644
--- a/drivers/hid/hid
On Fri, Apr 09, 2021 at 05:00:59PM +0800, Jiapeng Chong wrote:
> Fix the following gcc warning:
>
> drivers/input/serio/apbps2.c:106:16: warning: variable ‘tmp’ set but not
> used [-Wunused-but-set-variable].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Applied, thank you.
--
Hi Vincent,
On Fri, Mar 05, 2021 at 04:38:05PM +0100, Vincent Knecht wrote:
> Add support for the msg2638 touchscreen IC from MStar.
> Firmware handling, wakeup gestures and other specialties are not supported.
> This driver reuses zinitix.c structure, while the checksum and irq handler
>
Hi Satya,
On Wed, Apr 07, 2021 at 08:59:39PM +0530, ska...@codeaurora.org wrote:
> Gentle Reminder!
Sorry, please address Rob's comments on the bindings, the driver code
looks OK to me.
Thanks.
--
Dmitry
Hi Dinghao,
On Wed, Apr 07, 2021 at 12:07:38PM +0800, Dinghao Liu wrote:
> When mutex_lock_interruptible() fails, a pairing PM usage
> counter decrement is needed to keep the counter balanced.
Thank you for the patch.
>
> Signed-off-by: Dinghao Liu
> ---
> drivers/input/mouse/cyapa.c | 4
[] (ksys_write+0x64/0xdc)
[] (ksys_write) from [] (ret_fast_syscall+0x0/0x58)
Let's fix it up.
Fixes: c9efb0ba281e ("Input: gpio-keys - use hrtimer for software debounce, if
possible")
Reported-by: Tony Lindgren
Signed-off-by: Dmitry Torokhov
---
Tony, could you please try this pat
On Tue, Apr 06, 2021 at 11:37:07AM +0300, Tony Lindgren wrote:
> Hi,
>
> * Dmitry Torokhov [700101 02:00]:
> > On Sun, Mar 07, 2021 at 10:22:40PM +, Paul Cercueil wrote:
> > > We want to be able to report the input event as soon as the debounce
> > > delay e
Hi Alistair,
On Thu, Mar 25, 2021 at 09:52:27PM -0400, Alistair Francis wrote:
> From: Alistair Francis
>
> Signed-off-by: Alistair Francis
> ---
> v4:
> - Initial commit
>
> drivers/input/touchscreen/wacom_i2c.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git
On Thu, Mar 25, 2021 at 09:52:25PM -0400, Alistair Francis wrote:
> This is based on the out of tree rM2 driver.
>
> Signed-off-by: Alistair Francis
> ---
> drivers/input/touchscreen/wacom_i2c.c | 25 +++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git
Hi Alistair,
On Thu, Mar 25, 2021 at 09:52:23PM -0400, Alistair Francis wrote:
> Allow the wacom-i2c device to be exposed via device tree.
>
> Signed-off-by: Alistair Francis
> ---
> v4:
> - Avoid unused variable warning by not using of_match_ptr()
>
> drivers/input/touchscreen/wacom_i2c.c |
On Thu, Mar 25, 2021 at 09:52:24PM -0400, Alistair Francis wrote:
> Connect touchscreen properties to the wacom_i2c.
>
> Signed-off-by: Alistair Francis
> ---
> v4:
> - Add touchscreen_report_pos() as well
>
> drivers/input/touchscreen/wacom_i2c.c | 5 +
> 1 file changed, 5 insertions(+)
o this driver.
>
> Signed-off-by: Heikki Krogerus
> Cc: Dmitry Torokhov
Acked-by: Dmitry Torokhov
Thanks.
--
Dmitry
On Mon, Mar 29, 2021 at 02:55:07AM +0300, Dmitry Osipenko wrote:
> Drop unnecessary zero-checking of ABS_MT_TOUCH_MAJOR resolution since
> there is no difference between setting resolution to 0 vs not setting
> it at all. This change makes code cleaner a tad.
>
> Suggested-by:
Hi Dmitry,
On Tue, Mar 02, 2021 at 01:08:24PM +0300, Dmitry Osipenko wrote:
> Touchscreen firmware of ASUS Transformer TF700T reports zeros for the phys
> size. Hence check whether the size is zero and don't set the resolution in
> this case.
>
> Reported-by: Jasper Korten
> Signed-off-by:
On Thu, Mar 25, 2021 at 07:59:44AM +0100, Thomas Gleixner wrote:
> Dmitry,
>
> On Tue, Mar 23 2021 at 15:44, Dmitry Torokhov wrote:
> > On Thu, Mar 04, 2021 at 07:50:31PM +0100, Thomas Gleixner wrote:
> >> Please hold on:
> >>
> >>
> >>
On Wed, Mar 03, 2021 at 11:49:16AM +1300, Barry Song wrote:
> disable_irq() after request_irq() still has a time gap in which
> interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
> disable IRQ auto-enable because of requesting.
>
> On the other hand, request_irq() after setting
Hi Lee,
On Wed, Mar 10, 2021 at 11:12:50AM +, Lee Jones wrote:
> On Tue, 09 Mar 2021, Lee Jones wrote:
>
> > On Tue, 09 Mar 2021, Lee Jones wrote:
> >
> > > Enjoy!
> > >
> > > The following changes since commit
> > > fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8:
> > >
> > > Linux 5.12-rc1
On Thu, Mar 25, 2021 at 03:10:25PM +0100, Thierry Reding wrote:
> On Sun, Mar 21, 2021 at 03:40:28PM -0700, Dmitry Torokhov wrote:
> > On Tue, Mar 02, 2021 at 01:21:58PM +0300, Dmitry Osipenko wrote:
> > > Acer A500 uses Atmel Maxtouch 1386 touchscreen controller. This control
On Wed, Mar 24, 2021 at 11:39:35PM +, Mark Brown wrote:
> On Wed, Mar 24, 2021 at 03:27:23PM -0700, Dmitry Torokhov wrote:
> > On Wed, Mar 24, 2021 at 09:32:26PM +, Mark Brown wrote:
>
> > > TBH that looks like a fairly standard case where you probably don't want
&
On Wed, Mar 24, 2021 at 09:32:26PM +, Mark Brown wrote:
> On Tue, Mar 23, 2021 at 12:04:34PM -0700, Dmitry Torokhov wrote:
> > On Tue, Mar 23, 2021 at 05:36:06PM +, Mark Brown wrote:
>
> > No it is ordering issue. I do not have a proven real-life example for
> >
Hi Thomas,
On Thu, Mar 04, 2021 at 07:50:31PM +0100, Thomas Gleixner wrote:
> Dmitry,
>
> On Thu, Mar 04 2021 at 11:57, Thomas Gleixner wrote:
> > On Thu, Mar 04 2021 at 10:53, tip-bot wrote:
> >
> >> The following commit has been merged into the irq/core branch of tip:
> >>
> >> Commit-ID:
On Sun, Mar 07, 2021 at 10:22:40PM +, Paul Cercueil wrote:
> We want to be able to report the input event as soon as the debounce
> delay elapsed. However, the current code does not really ensure that,
> as it uses the jiffies-based schedule_delayed_work() API. With a small
> enough HZ value
On Sun, Mar 07, 2021 at 10:22:39PM +, Paul Cercueil wrote:
> Dealing with input, timing is important; if the button should be
> released in one millisecond, then it should be done in one millisecond
> and not a hundred milliseconds.
>
> Therefore, the standard timer API is not really suitable
On Sun, Mar 07, 2021 at 10:22:38PM +, Paul Cercueil wrote:
> The input_sync() function is already called after the loop in
> gpio_keys_report_state(), so it does not need to be called after each
> iteration within gpio_keys_gpio_report_event().
>
> Signed-off-by: Paul Cercueil
Applied,
On Thu, Mar 11, 2021 at 02:41:43PM +0300, Nikolai Kostrigin wrote:
> s/max_baseliune/max_baseline/
>
> Signed-off-by: Nikolai Kostrigin
Applied, thank you.
--
Dmitry
On Tue, Mar 23, 2021 at 05:36:06PM +, Mark Brown wrote:
> On Mon, Mar 22, 2021 at 12:38:15PM -0700, Dmitry Torokhov wrote:
> > On Mon, Mar 22, 2021 at 12:37:07PM +, Mark Brown wrote:
>
> > > This feels like it might make sense to push up to the driver core level
&
On Tue, Mar 23, 2021 at 02:29:15PM +0100, Rasmus Villemoes wrote:
> On 23/03/2021 14.14, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > overlapping input and output arguments to snprintf() are
> > undefined behavior in C99:
> >
>
> Good luck:
>
On Tue, Mar 23, 2021 at 02:06:13PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> The Zenbook Flip entry that was added overwrites a previous one
> because of a typo:
>
> In file included from drivers/input/serio/i8042.h:23,
> from drivers/input/serio/i8042.c:131:
>
On Mon, Mar 22, 2021 at 12:37:07PM +, Mark Brown wrote:
> On Sun, Mar 21, 2021 at 06:43:32PM -0700, Dmitry Torokhov wrote:
>
> > Note that this is not SPI-specific issue. I already send a similar
> > patch for I2C and will be sending more.
>
> This feels like it mig
Given that all serio drivers except one implement write() method
let's make it mandatory to avoid testing for its presence whenever
we attempt to use it.
Signed-off-by: Dmitry Torokhov
---
drivers/input/serio/ams_delta_serio.c | 6 ++
drivers/input/serio/serio.c | 5 +
include
On Mon, Mar 22, 2021 at 07:50:30AM +0530, Bhaskar Chowdhury wrote:
>
> s/subsytem/subsystem/
>
> Signed-off-by: Bhaskar Chowdhury
Applied, thank you.
--
Dmitry
are released immediately after driver's remove() method
returns, and not postponed until driver core gets around to releasing
resources. To fix that we open a new devres group before calling
driver's probe() and explicitly release it when we return from driver's
remove().
Signed-off-by: Dmitry Torokhov
-off-by: Dmitry Torokhov
---
Note that this problem is not I2C-specific and I will be sending patches
for other buses as well.
drivers/i2c/i2c-core-base.c | 21 -
include/linux/i2c.h | 3 +++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c
On Thu, Mar 04, 2021 at 12:09:48PM +0300, Heikki Krogerus wrote:
> The old device property API is about to be removed, so
> explaing how to use complete software nodes instead.
>
> Signed-off-by: Heikki Krogerus
Applied, thank you.
--
Dmitry
On Tue, Mar 16, 2021 at 01:48:24PM -0600, Rob Herring wrote:
> Properties with standard unit suffixes already have a type and don't need
> type references. Fix a few more cases which have gotten added.
>
> Cc: Luca Ceresoli
> Cc: Jonathan Cameron
> Cc: Dmitry Torokhov
>
On Fri, Feb 12, 2021 at 05:38:06PM +0100, Krzysztof Kozlowski wrote:
> The touchscreen can be a wake up source and it's being used in DTS:
>
> arch/arm/boot/dts/exynos5250-spring.dt.yaml:
> trackpad@4b: 'wakeup-source' does not match any of the regexes:
> 'pinctrl-[0-9]+'
>
>
Hi Dmitry,
On Sat, Mar 20, 2021 at 07:02:43PM +0300, Dmitry Osipenko wrote:
> 02.03.2021 13:21, Dmitry Osipenko пишет:
> > Some Atmel maXTouch controllers, like mXT1386 and mXT3432S1 for example,
> > have a WAKE line that needs to be asserted in order to wake controller
> > from a deep sleep,
On Tue, Mar 02, 2021 at 01:21:58PM +0300, Dmitry Osipenko wrote:
> Acer A500 uses Atmel Maxtouch 1386 touchscreen controller. This controller
> has WAKE line which could be connected to I2C clock lane, dedicated GPIO
> or fixed to HIGH level. Controller wakes up from a deep sleep when WAKE
> line
On Tue, Mar 02, 2021 at 01:21:57PM +0300, Dmitry Osipenko wrote:
> According to datasheets, chips like mXT1386 have a WAKE line, it is used
> to wake the chip up from deep sleep mode before communicating with it via
> the I2C-compatible interface.
>
> If the WAKE line is connected to a GPIO line,
On Tue, Mar 02, 2021 at 01:21:56PM +0300, Dmitry Osipenko wrote:
> Some Atmel touchscreen controllers have a WAKE line that needs to be
> asserted low in order to wake up controller from a deep sleep. Document
> the wakeup methods and the new GPIO properties.
>
> Reviewed-by: Rob Herring
>
This simplifies error unwinding path and allows us to get rid of
remove() method.
Signed-off-by: Dmitry Torokhov
---
drivers/input/touchscreen/wacom_i2c.c | 55 +--
1 file changed, 17 insertions(+), 38 deletions(-)
diff --git a/drivers/input/touchscreen/wacom_i2c.c
b
Instead of forcing interrupt trigger to "level low" rely on the
platform to set it up according to how it is wired on the given
board.
Signed-off-by: Dmitry Torokhov
---
drivers/input/touchscreen/wacom_i2c.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dri
On Sun, Mar 21, 2021 at 10:10:47AM -0400, Alistair Francis wrote:
> Add support for a VDD regulator. This allows the kernel to prove the
> Wacom-I2C device on the rM2.
>
> Signed-off-by: Alistair Francis
> ---
> drivers/input/touchscreen/wacom_i2c.c | 22 ++
> 1 file
On Sun, Mar 21, 2021 at 10:10:46AM -0400, Alistair Francis wrote:
> Improve the query device fields to be more verbose.
>
> Signed-off-by: Alistair Francis
> ---
> drivers/input/touchscreen/wacom_i2c.c | 71 +++
...
>
> + rstc =
On Sun, Mar 21, 2021 at 10:10:44AM -0400, Alistair Francis wrote:
> Connect touchscreen properties to the wacom_i2c.
>
> Signed-off-by: Alistair Francis
> ---
> drivers/input/touchscreen/wacom_i2c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
Hi Alistair,
On Sun, Mar 21, 2021 at 10:10:43AM -0400, Alistair Francis wrote:
> Allow the wacom-i2c device to be exposed via device tree.
>
> Signed-off-by: Alistair Francis
> ---
> drivers/input/touchscreen/wacom_i2c.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git
On Thu, Mar 18, 2021 at 04:55:25PM +0100, Johan Hovold wrote:
> The driver data for the data interface has already been set by
> usb_driver_claim_interface() so drop the subsequent redundant
> assignment.
>
> Signed-off-by: Johan Hovold
Applied, thank you.
--
Dmitry
Action of unbinding driver from a device is not cancellable and should not
fail, and driver core does not pay attention to the result of "remove"
method, therefore using down_interruptible() in hid_device_remove() does
not make sense.
Signed-off-by: Dmitry Torokhov
---
drivers/hid/
On Tue, Mar 09, 2021 at 10:53:34PM +0800, jingle.wu wrote:
> Hi Dmitry:
>
> Was this the only issue with the updated patch? Did it work for you
> otherwise?
> -> Yes, the updated patch can work successfully after fix this issue.
OK, great, I applied it.
Thanks.
--
Dmitry
Hi Jingle,
On Mon, Mar 08, 2021 at 04:56:14PM +0800, jingle wrote:
> Hi Dmitry:
>
> 1. missing "i<"
> + u32 quirks = 0;
> + int i;
> +
> + for (i = 0; ARRAY_SIZE(elan_i2c_quirks); i++) {
>
> -> for (i = 0; i
> 2. elan_resume () funtion are different with at Chromeos driver.
> @@
set on the subsequent ones.
Signed-off-by: Jingle Wu
Link: https://lore.kernel.org/r/20210226073537.4926-1-jingle...@emc.com.tw
Patchwork-Id: 12105967
Signed-off-by: Dmitry Torokhov
---
drivers/input/mouse/elan_i2c.h |5 +++
drivers/input/mouse/elan_i2c_core.c | 58 +++
On Fri, Mar 05, 2021 at 06:58:10PM +, Caleb Connolly wrote:
> The touch coordinate register contains the following:
>
> byte 3 byte 2 byte 1
> +++ +-+ +-+
> ||| | | |
Hi Oleksij,
On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote:
> +
> + /* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */
> + irq_set_status_flags(spi->irq, IRQ_NOAUTOEN);
> + ret = devm_request_threaded_irq(dev, spi->irq,
> +
On Sun, Mar 07, 2021 at 09:11:18PM +, Paul Cercueil wrote:
> Hi Dmitry,
>
> Le dim. 7 mars 2021 à 12:20, Dmitry Torokhov a
> écrit :
> > On Fri, Mar 05, 2021 at 08:00:43PM +, Paul Cercueil wrote:
> > > Hi Dmitry,
> > >
> > >
On Fri, Mar 05, 2021 at 08:00:43PM +, Paul Cercueil wrote:
> Hi Dmitry,
>
> Le ven. 5 mars 2021 à 10:35, Dmitry Torokhov a
> écrit :
> > Hi Paul,
> >
> > On Fri, Mar 05, 2021 at 05:01:11PM +, Paul Cercueil wrote:
> > > -static void gpio_keys_
Hi Giulio,
On Fri, Mar 05, 2021 at 05:38:34PM +0100, Giulio Benetti wrote:
> From: Giulio Benetti
>
> This patch adds support for Hycon HY46XX.
Could you please tell me where patches 1/3 and 2/3. I am guessing they
are dealing with DT bindings and are most likely to go through my tree
after
On Fri, Mar 05, 2021 at 05:01:09PM +, Paul Cercueil wrote:
> The input_sync() function will already be called within
> gpio_keys_gpio_report_event(), so there's no need to call it again after
> the loop in gpio_keys_report_state().
I'd probably go other way around and remove the sync from
Hi Paul,
On Fri, Mar 05, 2021 at 05:01:11PM +, Paul Cercueil wrote:
> -static void gpio_keys_gpio_work_func(struct work_struct *work)
> +static enum hrtimer_restart gpio_keys_debounce_timer(struct hrtimer *t)
> {
> - struct gpio_button_data *bdata =
> - container_of(work,
Hi Jingle,
On Fri, Mar 05, 2021 at 09:24:05AM +0800, jingle wrote:
> HI Dmitry:
>
> In this case (in the newer parts behavior regarding need to reset after
> powering them on), it is consistent with the original driver behavior with
> any new or old device
> (be called
Hi Jingle,
On Tue, Mar 02, 2021 at 09:04:57AM +0800, jingle.wu wrote:
> HI Dmitry:
>
> So data->ops->initialize(client) essentially performs reset of the
> controller (we may want to rename it even) and as far as I understand
> you would want to avoid resetting the controller on newer devices,
>
Hi Jingle,
On Fri, Feb 26, 2021 at 03:35:37PM +0800, jingle.wu wrote:
> @@ -273,10 +318,12 @@ static int __elan_initialize(struct elan_tp_data *data)
> bool woken_up = false;
> int error;
>
> - error = data->ops->initialize(client);
> - if (error) {
> -
he HID usage for this button is
> consumer 0xB2:
> 0x05, 0x0C,// Usage Page (Consumer)
> 0x0A, 0xB2, 0x00, // Usage (Record)
I see, thank you.
>
> Thanks!
> Chris
>
> On Wed, Feb 24, 2021 at 8:33 PM Dmitry Torokhov
> wrote:
> >
> > Hi Chri
Hi Yang,
On Wed, Feb 24, 2021 at 04:43:26PM +0800, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/input/touchscreen/edt-ft5x06.c:697:0-23: WARNING:
> debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Thank you for the patch, however reading the coccinelle
Hi Chris,
On Thu, Feb 25, 2021 at 04:00:32AM +, Chris Ye wrote:
> Add "Share" button input capability and input event mapping for
> Microsoft Xbox One controller.
> Fixed Microsoft Xbox One controller share button not working under USB
> connection.
>
> Signed-off-by: Chris Ye
> ---
>
Input: joydev - prevent potential read overflow in ioctl
Dmitry Torokhov (6):
Input: da7280 - fix missing error test
Input: da7280 - protect OF match table with CONFIG_OF
Input: imx_keypad - add dependency on HAS_IOMEM
Input: omap4-keypad - switch to use managed
On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
> On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:
> > NORMAL (0x0) and IDLE (0x4) are really two different states. Hence you
> > cannot check for both using a bitmask, as that checks for IDLE only,
> > breaking
On Fri, Jan 15, 2021 at 02:36:17PM -0800, Philip Chen wrote:
> Decouple LOCK from F13 and directly map the LOCK key (KSI3/KSO9) to
> KEY_SLEEP action key code.
>
> Signed-off-by: Philip Chen
Applied, thank you.
--
Dmitry
On Fri, Jan 15, 2021 at 02:36:15PM -0800, Philip Chen wrote:
> In Chrome OS, the keyboard matrix can be split to two groups:
>
> The keymap for the top row keys can be customized based on OEM
> preference, while the keymap for the other keys is generic/fixed
> across boards.
>
> This patch
On Fri, Jan 15, 2021 at 02:36:16PM -0800, Philip Chen wrote:
> The common cros-ec keymap has been defined as macros. This patch uses
> the macros to simply linux,keymap in cros-ec-keyboard.dtsi file.
>
> This patch also creates an alias for keyboard-controller to make it
> easier to override the
On Fri, Jan 15, 2021 at 12:24:30PM -0800, Philip Chen wrote:
> The top-row keys in a keyboard usually have dual functionalities.
> E.g. A function key "F1" is also an action key "Browser back".
>
> Therefore, when an application receives an action key code from
> a top-row key press, the
On Fri, Jan 15, 2021 at 12:24:29PM -0800, Philip Chen wrote:
> Add a new property `function-row-physmap` to the
> device tree for the custom keyboard top row design.
>
> The property describes the rows/columns of the top row keys
> from left to right.
>
> Signed-off-by: Philip Chen
Applied,
Hi Vincent,
On Wed, Feb 10, 2021 at 06:33:52PM +0100, Vincent Knecht wrote:
> +
> + for (i = 0; i < MAX_SUPPORTED_FINGER_NUM; i++) {
> + p = _event.pkt[i];
> + /* Ignore non-pressed finger data */
> + if (p->xy_hi == 0xFF && p->x_low == 0xFF && p->y_low ==
On Wed, Feb 17, 2021 at 11:07:17AM -0800, Ronald Tschalär wrote:
> For some reason, when the system is under heavy CPU load, the read
> following the write sometimes occurs unusually quickly, resulting in
> the read data not being quite ready and hence a bad packet getting read.
> Adding another
On Wed, Feb 17, 2021 at 12:45:51PM -0800, Life is hard, and then you die wrote:
>
> Hi Dmitry,
>
> On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote:
> >
> > On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:
> > &g
zinitix_init_touch() returns error code or 0 for success and therefore
return type must be int, not bool.
Fixes: 26822652c85e ("Input: add zinitix touchscreen driver")
Reported-by: kernel test robot
Reported-by: Jiapeng Chong
Signed-off-by: Dmitry Torokhov
---
drivers/input/t
Hi,
On Thu, Feb 18, 2021 at 05:59:53PM +0800, kernel test robot wrote:
> From: kernel test robot
>
> drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in
> function 'zinitix_init_touch' with return type bool
>
> Return statements in functions returning bool should use
>
Hi,
On Thu, Feb 18, 2021 at 06:23:55PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/input/touchscreen/zinitix.c:250:8-9: WARNING: return of 0/1 in
> function 'zinitix_init_touch' with return type bool.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng
On Wed, Feb 17, 2021 at 12:52:57PM -0800, Life is hard, and then you die wrote:
>
> Hi Dmitry,
>
> On Wed, Feb 17, 2021 at 12:26:18PM -0800, Dmitry Torokhov wrote:
> >
> > On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote:
> > > The problem is th
Hi Ronald,
On Wed, Feb 17, 2021 at 11:07:18AM -0800, Ronald Tschalär wrote:
> The problem is that tracing can't be set via sysfs until the module is
> loaded, at which point the keyboard and trackpad initialization commands
> have already been run and hence tracing can't be used to debug problems
Hi Ronald,
On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:
> @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data
> *applespi)
> return sts;
> }
>
> - applespi->cmd_msg_queued = true;
> + applespi->cmd_msg_queued = ktime_get();
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus
to receive updates for the input subsystem. Nothing terribly
interesting, just a few fixups.
Changelog:
-
Alexey Dobriyan (1):
Input: i8042 - unbreak Pegatron C15B
Hi Andre,
On Wed, Jan 27, 2021 at 05:24:45PM +, Andre Przywara wrote:
> On at least one board (Orangepi Zero2) the AXP305 PMIC does not have its
> interrupt line connected to the CPU (mostly because the H616 SoC does
> not feature an NMI pin anymore).
> After allowing the AXP driver to
On Sun, Jan 24, 2021 at 10:54:14PM +0300, Dmitry Osipenko wrote:
> From: Michał Mirosław
>
> Add ELAN KTF3624 touchscreen support to the elants_i2c driver.
> The eKTF3624 TS is found on a series of ASUS Transformer tablet devices,
> Nexus 7 tablet and etc. The firmware interface of eKTF3624 is
1 - 100 of 11293 matches
Mail list logo
