Re: [PATCH v3] x86/platform/uv: refactor deprecated strcpy and strncpy

2023-09-13 Thread Hans de Goede
Hi, On 9/6/23 16:09, Ingo Molnar wrote: > > * Hans de Goede wrote: > >> Hi Ingo, >> >> On 9/6/23 14:10, Ingo Molnar wrote: >>> >>> * Justin Stitt wrote: >>> >>>> Both `strncpy` and `strcpy` are deprecated for use on NUL-termi

Re: [PATCH] platform/surface: aggregator: fix a bit test

2021-04-20 Thread Hans de Goede
Hi, On 4/20/21 10:44 AM, Dan Carpenter wrote: > The "funcs" variable is a u64. If "func" is more than 31 then the > BIT() shift will wrap instead of testing the high bits. > > Fixes: c167b9c7e3d6 ("platform/surface: Add Surface Aggregator subsystem") > Reported-by: kernel test robot >

Re: [PATCH][next] platform/x86: intel_pmc_core: fix unsigned variable compared to less than zero

2021-04-20 Thread Hans de Goede
Hi Colin, On 4/20/21 2:10 PM, Colin King wrote: > From: Colin Ian King > > The check for ret < 0 is always false because ret is a (unsigned) size_t > and not a (signed) ssize_t, hence simple_write_to_buffer failures are > never detected. Fix this by making ret a ssize_t > > Addresses-Coverity:

Re: [PATCH V2 0/9] intel_pmc_core: Add sub-state requirements and mode

2021-04-19 Thread Hans de Goede
Hi, On 4/17/21 5:12 AM, David E. Box wrote: > - Patch 1 and 2 remove the use of the global struct pmc_dev > - Patches 3-7 add support for reading low power mode sub-state > requirements, latching sub-state status on different low power mode > events, and displaying the sub-state residency in

Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect

2021-04-19 Thread Hans de Goede
Hi, On 4/19/21 10:02 AM, Luke Jones wrote: > NP Hans, sorry about the length of time this took. Other duties etc. > > I appreciated the wealth of insight you were able to provide to enable this. BTW, I see that your drivers/acpi/video_detect.c patch is marked as [PATCH 1/3] I guess these 2

Re: [PATCH 0/2] Remove GA14/15 quirks to acpi/video_detect

2021-04-19 Thread Hans de Goede
Hi Luke, On 4/19/21 9:49 AM, Luke D. Jones wrote: > Revert two commits to allow a patch to acpi/video_detect to correctly > set the backlight control as native. Thank you for following up on our previous discussion about this. I'll merge this as soon as Rafael has accepted to matching

Re: [PATCH V2 0/9] intel_pmc_core: Add sub-state requirements and mode

2021-04-17 Thread Hans de Goede
Hi, On 4/17/21 5:12 AM, David E. Box wrote: > - Patch 1 and 2 remove the use of the global struct pmc_dev > - Patches 3-7 add support for reading low power mode sub-state > requirements, latching sub-state status on different low power mode > events, and displaying the sub-state residency in

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread Hans de Goede
t memory mapped but are > available from an ACPI _DSM. Collect the requirements for Tiger Lake using > the _DSM method and store in a buffer. > > Signed-off-by: Gayatri Kammela > Co-developed-by: David E. Box > Signed-off-by: David E. Box > Reviewed-by: Hans de Goede > ---

Re: [PATCH V2 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-17 Thread Hans de Goede
are not memory mapped but are > available from an ACPI _DSM. Collect the requirements for Tiger Lake using > the _DSM method and store in a buffer. > > Signed-off-by: Gayatri Kammela > Co-developed-by: David E. Box > Signed-off-by: David E. Box > Reviewed-by: Hans de Goed

Re: [PATCH] platform/x86: intel_chtdc_ti_pwrbtn: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-15 Thread Hans de Goede
Hi, On 4/15/21 11:14 AM, zhuguangqin...@gmail.com wrote: > From: Guangqing Zhu > > Coccinelle noticed: > drivers/platform/x86/intel_chtdc_ti_pwrbtn.c:59:7-32: ERROR: Threaded IRQ > with no primary handler requested without IRQF_ONESHOT > > Signed-off-by: Guangqing Zhu So I was wondering

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2021-04-14 Thread Hans de Goede
Hi, On 4/14/21 3:51 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > ff57cfaa3d68 ("platform/x86: pmc_atom: Match all Beckhoff Automation > baytrail boards with critclk_systems DMI table") > > is missing a Signed-off-by from its committer. My bad I somehow forgot to pass -s to "git

Re: [PATCH v7 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 11:19 AM, Perry Yuan wrote: > From: Perry Yuan > > add support for Dell privacy driver for the Dell units equipped > hardware privacy design, which protect users privacy of audio and > camera from hardware level. Once the audio or camera privacy mode > activated, any applications

Re: [PATCH v2] platform/x86: pmc_atom: Match all Beckhoff Automation baytrail boards with critclk_systems DMI table

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 3:30 PM, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel > > pmc_plt_clk* clocks are used for ethernet controllers, so need to stay > turned on. This adds the affected board family to critclk_systems DMI > table, so the clocks are marked as CLK_CRITICAL and not turned off. >

Re: [PATCH v5] platform/x86: add Gigabyte WMI temperature driver

2021-04-13 Thread Hans de Goede
Hi, On 4/12/21 2:35 PM, Thomas Weißschuh wrote: > Tested with > * X570 I Aorus Pro Wifi (rev 1.0) > * B550M DS3H > * B550 Gaming X V2 (rev.1.x) > * Z390 I AORUS PRO WIFI (rev. 1.0) > > Those mainboards contain an ITE chips for management and > monitoring. > > They could also be handled by

Re: [PATCH v6] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-13 Thread Hans de Goede
ing and the file is set to read-only mode via is_visible > handler. > > The register in MMIO space is defined for Cannon Lake and newer PCHs. > > Cc: Hans de Goede > Cc: David E Box > Reviewed-by: Andy Shevchenko > Signed-off-by: Tamar Mashiah > Signed-off-by: Tomas Winkl

Re: [PATCH v7 2/2] ASoC: rt715:add micmute led state control supports

2021-04-12 Thread Hans de Goede
Hi Perry, On 4/12/21 11:19 AM, Perry Yuan wrote: > From: Perry Yuan > > Some new Dell system is going to support audio internal micphone > privacy setting from hardware level with micmute led state changing > When micmute hotkey pressed by user, soft mute will need to be enabled > firstly in

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 5:15 PM, Guenter Roeck wrote: > On 4/10/21 7:40 AM, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> * Fix errno/ACPI error

Re: [PATCH v3] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 4:40 PM, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup > * Document

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 8:56 AM, Guenter Roeck wrote: > On 4/8/21 11:02 PM, Thomas Weißschuh wrote: >> On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >>> On 4/8/21 2:36 AM, Hans de Goede wrote: >>>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote: >>>>> On M

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/8/21 3:55 PM, Guenter Roeck wrote: > On 4/8/21 1:28 AM, Heikki Krogerus wrote: >> On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote: >>> Fixes the following W=1 kernel build warning: >>> >>> drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined >>> but not

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi Guenter, On 4/8/21 5:08 PM, Guenter Roeck wrote: > On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> *

Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree

2021-04-08 Thread Hans de Goede
Hi all, On 4/8/21 2:13 PM, Stephen Rothwell wrote: > Hi all, > > Commit > > 11cccec79c60 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()") > > is missing a Signed-off-by from its committer. Ugh, thanks for letting me know, this was supposed to come from a merge from an immutable branch

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/8/21 11:25 AM, Heikki Krogerus wrote: > On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote: >> Hi, >> >> On 4/7/21 11:15 AM, Zhen Lei wrote: >>> Fixes the following W=1 kernel build warning: >>> >>> drivers/usb/typec/tcpm/tcp

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > Hi Hans, > > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >> Thank you for your new driver and thank you for the quick respin >> addressing Barnabás' request to make it a WMI driver. >> >> The code l

Re: [PATCH 1/1] usb: typec: tcpm: remove unused static variable 'tcpm_altmode_ops'

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 11:15 AM, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined > but not used [-Wunused-const-variable=] > > The reference to the variable 'tcpm_altmode_ops' is deleted by the > commit

Re: [PATCH] platform/surface: aggregator_registry: Give devices time to set up when connecting

2021-04-07 Thread Hans de Goede
Hi, On 4/6/21 1:12 AM, Maximilian Luz wrote: > Sometimes, the "base connected" event that we rely on to (re-)attach the > device connected to the base is sent a bit too early. When this happens, > some devices may not be completely ready yet. > > Specifically, the battery has been observed to

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-07 Thread Hans de Goede
Hi Thomas, Thank you for your new driver and thank you for the quick respin addressing Barnabás' request to make it a WMI driver. The code looks good, so merging this should be a no-brainer, yet I'm not sure if I should merge this driver as-is, let me explain. The problem is that I assume that

Re: [PATCH v6 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-04-07 Thread Hans de Goede
Hi Perry, Barnabás, Barnabás thank you for your review. I agree with all your remarks. Perry, Thank you for the new version, this version is looking good. This is almost ready for merging. Please fix the review remarks from Barnabás. I also have a couple of small review remarks myself below.

Re: [PATCH 0/3] Adjust contacts for Dell drivers

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 6:22 PM, Mario Limonciello wrote: > The Dell drivers I'm involved with all have me as an author and/or > maintainer. In the future these will be maintained as a team effort. > Adjust the contact addresses accordingly. > > Mario Limonciello (3): > MAINTAINERS: Adjust Dell drivers

Re: [PATCH 0/9] intel_pmc_core: Add sub-state requirements and mode latching support

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 5:05 AM, David E. Box wrote: > - Patch 1 and 2 remove the use of the global struct pmc_dev > - Patches 3-7 add support for reading low power mode sub-state > requirements, latching sub-state status on different low power mode > events, and displaying the sub-state residency in

Re: [PATCH 9/9] platform/x86: intel_pmc_core: Add support for Alder Lake PCH-P

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 5:05 AM, David E. Box wrote: > Alder PCH-P is based on Tiger Lake PCH. > > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel_pmc_core.c | 1 + > 1 file changed, 1 inse

Re: [PATCH 8/9] platform/x86: intel_pmc_core: Add LTR registers for Tiger Lake

2021-04-07 Thread Hans de Goede
ust the number of LTR IPs for Tiger Lake to the correct amount. > > Signed-off-by: Gayatri Kammela > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel_pmc_core.c | 2 ++ > drivers/plat

Re: [PATCH v1 0/5] ACPI: scan: acpi_bus_check_add() simplifications

2021-04-07 Thread Hans de Goede
lease refer to the patch changelogs for details. Thanks, the entire series looks good to me: Reviewed-by: Hans de Goede Regards, Hans

Re: [PATCH 7/9] platform/x86: intel_pmc_core: Add option to set/clear LPM mode

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 5:05 AM, David E. Box wrote: > By default the Low Power Mode (LPM or sub-state) status registers will > latch condition status on every entry into Package C10. This is > configurable in the PMC to allow latching on any achievable sub-state. Add > a debugfs file to support this. > >

Re: [PATCH 6/9] platform/x86: intel_pmc_core: Add requirements file to debugfs

2021-04-07 Thread Hans de Goede
> Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel_pmc_core.c | 86 +++ > 1 file changed, 86 insertions(+) > > diff --git a/drivers/platform/x86/intel_pm

Re: [PATCH 5/9] platform/x86: intel_pmc_core: Get LPM requirements for Tiger Lake

2021-04-07 Thread Hans de Goede
Hi, On 4/1/21 5:05 AM, David E. Box wrote: > From: Gayatri Kammela > > Platforms that support low power modes (LPM) such as Tiger Lake maintain > requirements for each sub-state that a readable in the PMC. However, unlike > LPM status registers, requirement registers are not memory mapped but

Re: [PATCH 4/9] platform/x86: intel_pmc_core: Show LPM residency in microseconds

2021-04-07 Thread Hans de Goede
uble this value then divide > by two to maintain accuracy. > > Signed-off-by: Gayatri Kammela > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel_pmc_core.c | 14 -- > driver

Re: [PATCH 3/9] platform/x86: intel_pmc_core: Handle sub-states generically

2021-04-07 Thread Hans de Goede
S0i3.2 0 > > Suggested-by: David E. Box > Signed-off-by: Gayatri Kammela > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platform/x86/intel_pmc_core.c | 59 ++- > d

Re: [PATCH 2/9] platform/x86: intel_pmc_core: Remove global struct pmc_dev

2021-04-07 Thread Hans de Goede
his directly. Since the driver now binds to an ACPI device, > remove the global pmc_dev in favor of one that is allocated during probe. > Modify users of the global to obtain the object by argument instead. > > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by:

Re: [PATCH 1/9] platform/x86: intel_pmc_core: Don't use global pmcdev in quirks

2021-04-07 Thread Hans de Goede
o a function that will handle each quirk if its variable > condition is met. This allows removing the global pmc_dev later. > > Signed-off-by: David E. Box Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/platfor

Re: [PATCH] platform/x86: ISST: Account for increased timeout in some cases

2021-04-07 Thread Hans de Goede
Hi, On 3/31/21 12:08 AM, Srinivas Pandruvada wrote: > In some cases when firmware is busy or updating, some mailbox commands > still timeout on some newer CPUs. To fix this issue, change how we > process timeout. > > With this change, replaced timeout from using simple count with real > timeout

Re: [PATCH v3 0/4] add device drivers for Siemens Industrial PCs

2021-04-07 Thread Hans de Goede
Hi, On 3/29/21 7:49 PM, Henning Schild wrote: > changes since v2: > > - remove "simatic-ipc" prefix from LED names > - fix style issues found in v2, mainly LED driver > - fix OEM specific dmi code, and remove magic numbers > - more "simatic_ipc" name prefixing > - improved pmc quirk code using

Re: [PATCH] platform/x86: panasonic-laptop: remove redundant assignment of variable result

2021-04-07 Thread Hans de Goede
Hi, On 3/26/21 8:20 PM, Colin King wrote: > From: Colin Ian King > > The variable result is being assigned a value that is never > read and it is being updated later with a new value. The > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by:

Re: [PATCH] platform/surface: clean up a variable in surface_dtx_read()

2021-04-07 Thread Hans de Goede
Hi, On 3/26/21 3:06 PM, Maximilian Luz wrote: > On 3/26/21 1:28 PM, Dan Carpenter wrote: >> The ">ddev->lock" and ">lock" are the same thing.  Let's >> use ">lock" consistently. >> >> Signed-off-by: Dan Carpenter > > Good catch, thanks! > > Reviewed-by: Maximilian Luz Thank you for the

Re: [PATCH v3] platform/x86: asus-wmi: Add param to turn fn-lock mode on by default

2021-04-07 Thread Hans de Goede
Hi, On 3/23/21 10:01 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani Thank you for your patch,

[GIT PULL] platform-drivers-x86 for 5.12-3

2021-04-07 Thread Hans de Goede
caused by recent intel-hid driver changes. The following is an automated git shortlog grouped by driver: intel-hid: - Fix spurious wakeups caused by tablet-mode events during suspend Hans de Goede (1): platform/x86: intel

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 11:31 AM, Winkler, Tomas wrote: > > >> Hi, >> >> On 4/7/21 8:51 AM, Winkler, Tomas wrote: > > During PCH (platform/board) manufacturing process a global reset has > to be induced in order for configuration changes take the effect > upon following platform reset.

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-07 Thread Hans de Goede
Hi, On 4/7/21 8:51 AM, Winkler, Tomas wrote: >>> >>> During PCH (platform/board) manufacturing process a global reset has >>> to be induced in order for configuration changes take the effect upon >>> following platform reset. >>> This setting was commonly done by accessing PMC registers via

Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node

2021-04-06 Thread Hans de Goede
Hi, On 4/6/21 9:40 PM, Wolfram Sang wrote: > >> What is the plan for merging this patch / this series ? > > I'll take the series via I2C. Ok, that works for me. Regards, Hans

Re: [PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-06 Thread Hans de Goede
Hi, On 4/2/21 5:21 PM, Tomas Winkler wrote: > From: Tamar Mashiah > > During PCH (platform/board) manufacturing process a global reset > has to be induced in order for configuration changes take the effect > upon following platform reset. > This setting was commonly done by accessing PMC

Re: [External] Re: [PATCH 31/32] Documentation: update sysfs-platform_profile.rst reference

2021-04-01 Thread Hans de Goede
Hi, On 4/1/21 5:07 PM, Mark Pearson wrote: > > > On 01/04/2021 09:49, Hans de Goede wrote: >> Hi, >> >> On 4/1/21 2:17 PM, Mauro Carvalho Chehab wrote: >>> The file name: Documentation/ABI/testing/sysfs-platform_profile.rst >>> should b

Re: [PATCH 31/32] Documentation: update sysfs-platform_profile.rst reference

2021-04-01 Thread Hans de Goede
uot;ACPI: platform: Add platform profile support") > Fixes: 8e0cbf356377 ("Documentation: Add documentation for new > platform_profile sysfs attribute") > Signed-off-by: Mauro Carvalho Chehab Thanks, patch looks good to me: Reviewed-by: Hans de Goede Rafael, I assume you wil

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function >

Re: [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines

2021-03-30 Thread Hans de Goede
Hi, On 3/30/21 11:22 AM, Alexandru Ardelean wrote: > On Tue, Mar 30, 2021 at 11:21 AM Hans de Goede wrote: >> >> Hi Alexadru, Jonathan, >> >> On 3/24/21 1:55 PM, Alexandru Ardelean wrote: >>> This changeset tries to do a conversion of the toshiba_acpi d

Re: [PATCH 00/10] platform/x86: toshiba_acpi: move acpi add/remove to device-managed routines

2021-03-30 Thread Hans de Goede
Hi Alexadru, Jonathan, On 3/24/21 1:55 PM, Alexandru Ardelean wrote: > This changeset tries to do a conversion of the toshiba_acpi driver to use > only device-managed routines. The driver registers as a singleton, so no > more than one device can be registered at a time. > > My main intent here

Re: [PATCH 07/12] i2c: cht-wc: Constify the software node

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:50 PM, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Hans de Goede Thanks, patc

Re: [PATCH 06/12] platform/x86: intel_cht_int33fe_microb: Constify the software node

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:50 PM, Heikki Krogerus wrote: > Additional device properties are always just a part of a > software fwnode. If the device properties are constant, the > software node can also be constant. > > Signed-off-by: Heikki Krogerus > Cc: Hans de Goede Thanks, patc

Re: [PATCH] iio: accel: da280: Drop unnecessarily used braces

2021-03-29 Thread Hans de Goede
Hi, On 3/29/21 12:52 PM, Andy Shevchenko wrote: > +Cc: Hans (just for your opinion) > > On Sun, Mar 28, 2021 at 10:40 PM Andy Shevchenko > wrote: >> On Sunday, March 28, 2021, Mugilraj Dhavachelvan >> wrote: >>> >>> As per linux kernel coding style braces are not needed for single >>>

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-26 Thread Hans de Goede
Hi, On 3/26/21 10:55 AM, Henning Schild wrote: > Am Thu, 18 Mar 2021 12:45:01 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: >>> On 17.03.21 21:03, Hans de Goede wrote: >>> >>>

Re: [PATCH v4 2/2] ASoC: rt715:add micmute led state control supports

2021-03-25 Thread Hans de Goede
Hi, On 3/25/21 3:11 PM, Yuan, Perry wrote: > Hi Hans > >> -Original Message----- >> From: Hans de Goede >> Sent: Monday, March 22, 2021 11:02 PM >> To: Jaroslav Kysela; Yuan, Perry; Mark Brown; pierre- >> louis.boss...@linux.intel.com; Limonciello, Mario

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-25 Thread Hans de Goede
Hi, On 3/25/21 8:52 AM, Yuan, Perry wrote: > Hi Hans. > >> -Original Message----- >> From: Hans de Goede >> Sent: Wednesday, March 24, 2021 3:40 AM >> To: Pierre-Louis Bossart; Yuan, Perry; po...@protonmail.com; >> oder_ch...@realtek.com; pe

[GIT PULL] platform-drivers-x86 for 5.12-2

2021-03-24 Thread Hans de Goede
: thinkpad_acpi: Allow the FnLock LED to change state Hans de Goede (9): platform/x86: thinkpad_acpi: Disable DYTC CQL mode around switching to balanced mode platform/x86: dell-wmi-sysman: Fix crash caused by calling kset_unregister twice platform/x86: dell-wmi-sysman: Fix possible NULL

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 12:19 PM, Hans de Goede wrote: > Hi, > > On 3/22/21 10:38 AM, Perry Yuan wrote: >> From: Perry Yuan >> >> add support for Dell privacy driver for the Dell units equipped >> hardware privacy design, which protect users privacy of audio and &g

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-24 Thread Hans de Goede
Hi, On 3/22/21 10:38 AM, Perry Yuan wrote: > From: Perry Yuan > > add support for Dell privacy driver for the Dell units equipped > hardware privacy design, which protect users privacy of audio and > camera from hardware level. Once the audio or camera privacy mode > activated, any applications

Re: [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init fails

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 10:21 AM, Matti Vaittinen wrote: > Add error print for probe failure when resource managed work-queue > initialization fails. > > Signed-off-by: Matti Vaittinen > Suggested-by: Chanwoo Choi > --- > drivers/extcon/extcon-gpio.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-24 Thread Hans de Goede
Hi, On 3/24/21 6:02 AM, Matti Vaittinen wrote: > Hello Chanwoo, Greg, > > Thanks for the review. > > On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote: >> Hi, >> >> Need to fix the work as following: >> s/extconn/extcon >> >> And I'd like you to use the more correct patch title like the >>

Re: [PATCH v2] platform/x86: asus-wmi: Add param to turn fn-lock mode on by default

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 9:25 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Add a module param ( fnlock_default ) that allows > changing the default at probe time > > Signed-off-by: Luca Stefani > --- >

Re: [PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 6:29 PM, David E. Box wrote: > On Tue, 2021-03-16 at 19:44 -0700, David E. Box wrote: >> Initialize the struct resource in intel_pmt_dev_register to zero to >> avoid a >> fault should the char *name field be non-zero. > > Hi Hans. Can these 2 patches be pulled as fixes for 5.12?

Re: [PATCH 1/2] platform/x86: intel_pmt_class: Initial resource to 0

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 3:44 AM, David E. Box wrote: > Initialize the struct resource in intel_pmt_dev_register to zero to avoid a > fault should the char *name field be non-zero. > > Signed-off-by: David E. Box Thank you for your patch-series, I've applied the series to my review-hans branch:

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-23 Thread Hans de Goede
to take a look at it soon. Regards, Hans > > Hans de Goede 於 2021年3月19日 週五 上午12:21寫道: >> >> Hi, >> >> On 3/12/21 9:11 AM, YingChieh Ho wrote: >>> From: "Andrea.Ho" >>> >>> Advantech sw_button is a ACPI event trigger button. >&

Re: [PATCH] asus-laptop: fix kobj_to_dev.cocci warnings

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 1:00 PM, Julia Lawall wrote: > From: kernel test robot > > Use kobj_to_dev() instead of container_of() > > Generated by: scripts/coccinelle/api/kobj_to_dev.cocci > > CC: Denis Efremov > Reported-by: kernel test robot > Signed-off-by: kernel test robot > Signed-off-by: Julia

Re: [PATCH] platform: mellanox: Typo fix in the file mlxbf-bootctl.c

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 10:56 AM, Bhaskar Chowdhury wrote: > > s/progamming/programming/ > > Signed-off-by: Bhaskar Chowdhury Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Re: [PATCH] platform: x86: Typo fix in the file classmate-laptop.c

2021-03-23 Thread Hans de Goede
Hi, On 3/17/21 9:43 AM, Bhaskar Chowdhury wrote: > > s/derefence/dereference/ > > Signed-off-by: Bhaskar Chowdhury Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Re: [PATCH] platform/x86: asus-wmi: Disable fn-lock mode by default

2021-03-23 Thread Hans de Goede
Hi, On 3/16/21 11:17 PM, Luca Stefani wrote: > * On recent ZenBooks the fn-lock is disabled > by default on boot while running Windows. > > * Follow the same paradigm also here. > > Signed-off-by: Luca Stefani This will be a behavioral change for many users where their F-keys will now all

Re: [PATCH v5 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-23 Thread Hans de Goede
Hi, On 3/23/21 7:57 PM, Pierre-Louis Bossart wrote: > Minor comments below. > +int __init dell_privacy_acpi_init(void) > > is the __init necessary? You call this routine from another which already has > this qualifier. Yes this is necessary, all functions which are only used during

Re: [PATCH v3 5/8] platform/x86: gpd pocket fan: Clean-up by using managed work init

2021-03-23 Thread Hans de Goede
ly. All testing is appreciated. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > Changelog from RFCv2: > - RFC dropped. No functional changes. > > drivers/platform/x86/gpd-pocket-fan.c | 17 ++---

Re: [PATCH] Input: i8042 - fix Pegatron C15B ID entry

2021-03-23 Thread Hans de Goede
_noselftest_table[0].matches') > > Add the missing separator between the two. > > Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to noselftest > list") > Signed-off-by: Arnd Bergmann Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Ha

Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed work init

2021-03-23 Thread Hans de Goede
ted. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Note that this is not just a cleanup, it also actually fixes a couple of driver-unbind races where the work was stopped before the IRQ is free-ed, so there is a race where the wo

Re: [PATCH v3 1/8] workqueue: Add resource managed version of delayed work init

2021-03-23 Thread Hans de Goede
ged verision of delayed work initialization. This will also > help drivers to avoid mixing manual and devm based unwinding when other > resources are handled by devm. > > Signed-off-by: Matti Vaittinen Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans >

Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers

2021-03-23 Thread Hans de Goede
t; S: Maintained > W: http://lanana.org/docs/device-list/index.html > > +DEVICE RESOURCE MANAGEMENT HELPERS > +M: Hans de Goede > +R: Matti Vaittinen > +S: Maintained > +F: include/linux/devm-helpers.h > + > DEVICE-MAPPER (LVM) > M: Alasdair Kergon > M: Mike Snitzer >

Re: [PATCH v4 2/2] ASoC: rt715:add micmute led state control supports

2021-03-22 Thread Hans de Goede
Hi, On 3/22/21 3:37 PM, Jaroslav Kysela wrote: > Dne 22. 03. 21 v 10:25 Yuan, Perry napsal(a): >> Hi Mark: >> >>> -Original Message- >>> From: Mark Brown >>> Sent: Tuesday, March 9, 2021 1:24 AM >>> To: Yuan, Perry >>> Cc: po...@protonmail.com; pierre-louis.boss...@linux.intel.com; >>>

Re: [GIT PULL] Immutable branch between MFD and Extcon due for the v5.13 merge window

2021-03-22 Thread Hans de Goede
between MFD and Extcon due for the v5.13 merge window > > -------- > Hans de Goede (6): > mfd: arizona: Drop arizona-extcon cells > extcon: arizona: Fix some issues when HPDET IRQ fires after the jack > has been unplugged > extcon: arizona: Fix

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-18 Thread Hans de Goede
Hi, On 3/12/21 9:11 AM, YingChieh Ho wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the software define

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-18 Thread Hans de Goede
Hi, On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: > On 17.03.21 21:03, Hans de Goede wrote: > > Hi, > >>> It just identifies the box and tells subsequent drivers which one it >>> is, which watchdog and LED path to take. Moving the knowledge of which

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-03-18 Thread Hans de Goede
Hi Lee, On 3/7/21 4:17 PM, Hans de Goede wrote: > Hi All, > > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > As discussed before here is a resend rebased on 5.12-rc2, maki

Re: [GIT PULL v2] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-18 Thread Hans de Goede
Hi, On 3/10/21 11:57 AM, Lee Jones wrote: > Rebased onto -rc2 > > The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: > > Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) > > are available in the Git repository at: > >

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-17 Thread Hans de Goede
Hi, On 3/17/21 8:13 PM, Henning Schild wrote: > Am Mon, 15 Mar 2021 12:31:11 +0200 > schrieb Andy Shevchenko : > >> On Mon, Mar 15, 2021 at 12:02 PM Henning Schild >> wrote: >>> >>> This mainly implements detection of these devices and will allow >>> secondary drivers to work on such machines.

Re: [PATCH 0/2] HID: Add support for Surface Aggregator Module HID transport

2021-03-17 Thread Hans de Goede
Hi, On 3/10/21 11:53 PM, Maximilian Luz wrote: > This series adds support for the Surface System Aggregator Module (SSAM) > HID transport subsystem. > > The SSAM is an embedded controller, found on 5th- and later generation > Microsoft Surface devices. On some of these devices (specifically >

Re: [PATCH 0/2] power: supply: Add battery and AC drivers for Surface devices

2021-03-17 Thread Hans de Goede
Hi, On 3/17/21 6:47 PM, Maximilian Luz wrote: > On 3/17/21 6:39 PM, Hans de Goede wrote: >> Hi, >> >> On 3/9/21 1:05 AM, Maximilian Luz wrote: >>> This series provides battery and AC drivers for Microsoft Surface >>> devices, where this information

Re: [PATCH] platform/surface: aggregator_registry: Add support for Surface Pro 7+

2021-03-17 Thread Hans de Goede
Hi, On 3/9/21 5:25 PM, Maximilian Luz wrote: > The Surface Pro 7+ is essentially a refresh of the Surface Pro 7 with > updated hardware and a new WSID identifier. > > Signed-off-by: Maximilian Luz Thank you for your patch, I've applied this patch to my review-hans branch:

Re: [PATCH 0/3] platform/surface: Add DTX detachment system driver

2021-03-17 Thread Hans de Goede
Hi, On 3/8/21 7:48 PM, Maximilian Luz wrote: > The Microsoft Surface Book series devices consist of a so-called > clipboard part (containing the CPU, touchscreen, and primary battery) > and a base part (containing keyboard, secondary battery, and optional > discrete GPU). These parts can be

Re: [PATCH 0/2] power: supply: Add battery and AC drivers for Surface devices

2021-03-17 Thread Hans de Goede
Hi, On 3/9/21 1:05 AM, Maximilian Luz wrote: > This series provides battery and AC drivers for Microsoft Surface > devices, where this information is provided via an embedded controller > (the Surface System Aggregator Module, SSAM) instead of the usual ACPI > interface. > > Specifically, 7th

Re: AHCI SATA Runtime PM

2021-03-17 Thread Hans de Goede
Hi, On 3/4/21 4:34 PM, Alexander Monakov wrote: > Hello, Hans, Linux PM folks, > > I'm looking for clarification regarding this patch discussion: > > https://patchwork.kernel.org/project/linux-pm/patch/20180420101834.15783-2-0v3rdr...@gmail.com/ > > Hans said, > >> Ah, so the AHCI code has

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-16 Thread Hans de Goede
ans > Am Mon, 15 Mar 2021 19:01:13 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/15/21 6:00 PM, Henning Schild wrote: >>> Am Mon, 15 Mar 2021 17:31:49 +0100 >>> schrieb Hans de Goede : >>> >>>> Hi, >>>> &

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Hans de Goede
Hi, On 3/15/21 6:00 PM, Henning Schild wrote: > Am Mon, 15 Mar 2021 17:31:49 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/15/21 3:58 PM, Henning Schild wrote: >>> Introduce a global variable to remember the matching entry for later >>> pr

Re: [PATCH] platform/x86: pmc_atom: use callback for all dmi quirk entries

2021-03-15 Thread Hans de Goede
Hi, On 3/15/21 3:58 PM, Henning Schild wrote: > Introduce a global variable to remember the matching entry for later > printing. Also having a callback allows to stop matching after the first > hit. > > Signed-off-by: Henning Schild > --- > drivers/platform/x86/pmc_atom.c | 26

Re: [PATCH v2 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs

2021-03-15 Thread Hans de Goede
Hi, On 3/15/21 11:14 AM, Henning Schild wrote: > Am Mon, 15 Mar 2021 10:57:10 +0100 > schrieb Henning Schild : > >> Siemens industrial PCs unfortunately can not always be properly >> identified the way we used to. An earlier commit introduced code that >> allows proper identification without

Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Hans de Goede
Hi, On 3/13/21 8:46 AM, Wang Qing wrote: > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is not necessary at all. > > Signed-off-by: Wang Qing Thanks, patch looks good to me: Reviewed-by: Hans de Goede Re

Re: Logitech G602 wireless mouse kernel error messages in 5.10.11+ kernels

2021-03-10 Thread Hans de Goede
Hi, On 3/10/21 9:55 PM, Filipe Laíns wrote: > On Wed, 2021-03-10 at 15:24 -0500, Mark Hounschell wrote: >> >> That is correct, I don't have any buttons bound to keyboard events. With >> the original patch the G4(forward) and G5(Backward) buttons work in a >> browser. I guess G7, G8, and G9

Re: [GIT PULL] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-09 Thread Hans de Goede
Hi Lee, On 3/9/21 7:12 PM, Lee Jones wrote: > Enjoy! > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) I thought we were supposed to avoid using 5.12-rc1 as a base to avoid people hitting the swapfile related

  1   2   3   4   5   6   7   8   9   10   >