Re: [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-14 Thread Jassi Brar
On Wed, Apr 14, 2021 at 3:51 AM Matthias Brugger wrote: > > > > On 12/04/2021 17:29, Jassi Brar wrote: > > On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu > > wrote: > >> > >> This series base linux 5.12-rc2 > >> these patches will cause ho

Re: [PATCH v6 04/34] dt-bindings: Add bindings for Keem Bay IPC driver

2021-04-12 Thread Jassi Brar
On Mon, Mar 8, 2021 at 2:20 PM mark gross wrote: > > On Fri, Mar 05, 2021 at 03:01:40PM -0600, Rob Herring wrote: > > On Fri, Feb 12, 2021 at 02:22:34PM -0800, mgr...@linux.intel.com wrote: > > > From: Daniele Alessandrelli > > > > > > Add DT binding documentation for the Intel Keem Bay IPC

Re: [PATCH] mailbox: hisilicon: Use the correct HiSilicon copyright

2021-04-12 Thread Jassi Brar
On Tue, Mar 30, 2021 at 2:22 AM Leo Yan wrote: > > On Tue, Mar 30, 2021 at 02:48:40PM +0800, Hao Fang wrote: > > s/Hisilicon/HiSilicon/g. > > It should use capital S, according to > > https://www.hisilicon.com/en/terms-of-use. > > > > Signed-off-by: Hao Fang > > Though the kernel has tons of

Re: [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Jassi Brar
On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu wrote: > > This series base linux 5.12-rc2 > these patches will cause home ui flick when cursor moved, > there is no fix solution yet, revert these patches first. > > change since v1: > add mtk-gce.txt and dts modification > > Yongqiang Niu (5): >

Re: [PATCH] dt-bindings: mailbox: Add compatible for SM8350 IPCC

2021-03-25 Thread Jassi Brar
On Thu, Mar 25, 2021 at 1:08 AM Vinod Koul wrote: > > On 12-03-21, 11:28, Bjorn Andersson wrote: > > On Thu 11 Mar 23:12 CST 2021, Vinod Koul wrote: > > > > Adding Jassi as recipient. Please let Vinod know if you want him to > > resend this patch to you. (I send a patch for MAINTAINERS yesterday)

[GIT PULL] Mailbox changes for v5.12

2021-02-23 Thread Jassi Brar
Hi Linus, The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3: Linux 5.11-rc7 (2021-02-07 13:57:38 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.12 for you to fetch changes up to

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-18 Thread Jassi Brar
On Thu, Feb 18, 2021 at 6:02 AM Alessandrelli, Daniele wrote: > > Hi Jassi, > > Thank you very much for your feedback. > > On Sun, 2021-02-14 at 22:54 -0600, Jassi Brar wrote: > > IIUIC, maybe the solution is simpler What if we set txdone_poll. > > Alwa

Re: [PATCH v2] soc: mediatek: cmdq: add address shift in jump

2021-02-14 Thread Jassi Brar
On Thu, Jan 7, 2021 at 7:48 PM Yongqiang Niu wrote: > > On Wed, 2020-12-23 at 16:34 +0800, Yongqiang Niu wrote: > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > > > Fixes: 0858fde496f8 ("mailbox: cmdq: variablize address shift in platform") > > > >

Re: [PATCH v6 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-02-14 Thread Jassi Brar
On Fri, Feb 12, 2021 at 4:23 PM wrote: > > From: Daniele Alessandrelli > > Add mailbox controller enabling inter-processor communication (IPC) > between the CPU (aka, the Application Processor - AP) and the VPU on > Intel Movidius SoCs like Keem Bay. > > The controller uses HW FIFOs to enable

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Jassi Brar
On Tue, Feb 9, 2021 at 5:18 AM Viresh Kumar wrote: > > This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2 > driver. > > drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 > (different address spaces) > drivers/mailbox/arm_mhuv2.c:506:24:expected

Re: [PATCH v3 0/5] Add APCS support for SDX55

2021-02-08 Thread Jassi Brar
On Mon, Feb 8, 2021 at 12:20 PM Manivannan Sadhasivam wrote: > > On Mon, Feb 08, 2021 at 09:46:11AM -0800, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2021-01-17 20:11:51) > > > Changes in v2: > > > > > > * Modified the max_register value as per the SDX55 IPC offset in mailbox > > >

Re: [PATCH v3 03/34] mailbox: vpu-ipc-mailbox: Add support for Intel VPU IPC mailbox

2021-01-31 Thread Jassi Brar
On Fri, Jan 29, 2021 at 8:21 PM wrote: > > From: Daniele Alessandrelli > > Add mailbox controller enabling inter-processor communication (IPC) > between the CPU (aka, the Application Processor - AP) and the VPU on > Intel Movidius SoCs like Keem Bay. > > The controller uses HW FIFOs to enable

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2021-01-31 Thread Jassi Brar
On Thu, Jan 7, 2021 at 5:53 AM haidong yao wrote: > > Hi Jassi Brar > > Thank you very much for your reply. > > Look at the function sprd_mbox_outbox_isr . > > Chan is !NULL. > > chan->cl is NULL when the client driver not loaded, the controller > driver

Re: [PATCH] mailbox: bcm: Replace tasklet with threaded irq

2021-01-14 Thread Jassi Brar
On Thu, Jan 14, 2021 at 6:21 PM Davidlohr Bueso wrote: > > Tasklets have long been deprecated as being too heavy on the system > by running in irq context - and this is not a performance critical > path. If a higher priority process wants to run, it must wait for > the tasklet to finish before

Re: [PATCH] dt-bindings: Drop redundant maxItems/items

2020-12-22 Thread Jassi Brar
cases are > fixed. > > Cc: Laurent Pinchart > Cc: Vinod Koul > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: Jassi Brar > Cc: dri-de...@lists.freedesktop.org > Cc: dmaeng...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Cc: linux-...@vger.kernel.org &g

[GIT PULL] Mailbox changes for v5.11]

2020-12-16 Thread Jassi Brar
Hi Linus, The following changes since commit 509a15421674b9e1a3e1916939d0d0efd3e578da: Merge tag '5.10-rc6-smb3-fixes' of git://git.samba.org/sfrench/cifs-2.6 (2020-12-01 15:43:53 -0800) are available in the Git repository at:

Re: [PATCH] add chan->cl check in mbox_chan_received_data()

2020-12-15 Thread Jassi Brar
On Tue, Dec 15, 2020 at 2:48 AM Haidong Yao wrote: > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -152,7 +152,7 @@ static enum hrtimer_restart txdone_hrtimer(struct hrtimer > *hrtimer) > void mbox_chan_received_data(struct mbox_chan *chan, void *mssg) > { >

Re: [PATCH 02/22] dt-bindings: Add bindings for Keem Bay IPC driver

2020-12-09 Thread Jassi Brar
On Tue, Dec 8, 2020 at 6:12 PM mark gross wrote: > > On Mon, Dec 07, 2020 at 02:31:37PM -0600, Jassi Brar wrote: > > On Mon, Dec 7, 2020 at 12:43 PM Daniele Alessandrelli > > wrote: > > > > > > Hi Rob, > > > > > > Thanks for the feedba

Re: [PATCH 02/22] dt-bindings: Add bindings for Keem Bay IPC driver

2020-12-07 Thread Jassi Brar
On Mon, Dec 7, 2020 at 12:43 PM Daniele Alessandrelli wrote: > > Hi Rob, > > Thanks for the feedback. > > On Mon, 2020-12-07 at 10:01 -0600, Rob Herring wrote: > > On Tue, Dec 01, 2020 at 02:34:51PM -0800, mgr...@linux.intel.com wrote: > > > From: Daniele Alessandrelli > > > > > > Add DT binding

Re: [PATCH V5 2/2] mailbox: arm_mhuv2: Add driver

2020-11-20 Thread Jassi Brar
On Tue, Nov 17, 2020 at 4:02 AM Viresh Kumar wrote: > + > +/** > + * struct mhuv2 - MHUv2 mailbox controller data > + * > + * @mbox: Mailbox controller belonging to the MHU frame. > + * @send/recv: Base address of the register mapping region. > + * @frame: Frame type: RECEIVER_FRAME or

Re: [PATCH] mailbox: arm_mhuv2: Add driver

2020-11-12 Thread Jassi Brar
On Wed, Nov 11, 2020 at 12:02 AM Viresh Kumar wrote: > > On 27-10-20, 17:23, Viresh Kumar wrote: > > This adds driver for the ARM MHUv2 (Message Handling Unit) mailbox > > controller. > > > > This is based on the accepted DT bindings of the controller and supports > > combination of all transport

[GIT PULL] Mailbox changes for v5.10

2020-10-18 Thread Jassi Brar
platform_get_irq error handling - bcm: convert tasklets to use new tasklet_setup api - core: fix race cause by hrtimer starting inappropriately Allen Pais (1): mailbox: bcm: convert tasklets to use new tasklet_setup() API Jassi Brar (1

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 1:54 PM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 19:33, Jassi Brar wrote: > > > On Fri, Oct 16, 2020 at 4:00 AM Jerome Brunet wrote: > >> > >> > >> On Fri 16 Oct 2020 at 10:52, Ionela Voinescu > >> wrote:

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 1:38 PM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 19:30, jassisinghb...@gmail.com wrote: > > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone_hrtimer

Re: [PATCH] mailbox: avoid timer start from callback

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 12:50 PM Sudeep Holla wrote: > > On Fri, Oct 16, 2020 at 12:30:20PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > If the txdone is done by polling, it is possible for msg_submit() to start > > the timer while txdone

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-16 Thread Jassi Brar
On Fri, Oct 16, 2020 at 4:00 AM Jerome Brunet wrote: > > > On Fri 16 Oct 2020 at 10:52, Ionela Voinescu wrote: > > > On Thursday 15 Oct 2020 at 13:45:54 (-0500), Jassi Brar wrote: > > [..] > >> > >> --- a/drivers/mailbox/mailbox.c > >> >

Re: [PATCH] mailbox: cancel timer before starting it

2020-10-15 Thread Jassi Brar
On Thu, Oct 15, 2020 at 8:58 AM Jerome Brunet wrote: > > > On Thu 15 Oct 2020 at 15:46, Ionela Voinescu wrote: > > > Hi guys, > > > > On Wednesday 23 Sep 2020 at 14:39:16 (+0200), Jerome Brunet wrote: > >> If the txdone is done by polling, it is possible for msg_submit() to start > >> the timer

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-07 Thread Jassi Brar
On Wed, Oct 7, 2020 at 6:40 AM Sudeep Holla wrote: > > On Fri, Oct 02, 2020 at 02:42:37PM -0500, Jassi Brar wrote: > > On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > > > > > + > > > +static void mhu_db_shutdown(struct mbox_chan *chan) > >

Re: [PATCH 0/4] Mediatek DRM driver detect CMDQ execution timeout by vblank IRQ

2020-10-02 Thread Jassi Brar
On Sun, Sep 27, 2020 at 6:04 PM Chun-Kuang Hu wrote: > > CMDQ helper provide timer to detect execution timeout, but DRM driver > could have a better way to detect execution timeout by vblank IRQ. > For DRM, CMDQ command should execute in vblank, so if it fail to > execute in next 2 vblank,

Re: [PATCH 4/4] mailbox: arm_mhu: Add ARM MHU doorbell driver

2020-10-02 Thread Jassi Brar
On Mon, Sep 28, 2020 at 6:45 AM Sudeep Holla wrote: > + > +static void mhu_db_shutdown(struct mbox_chan *chan) > +{ > + struct mhu_db_channel *chan_info = chan->con_priv; > + struct mbox_controller *mbox = _info->mhu->mbox; > + int i; > + > + for (i = 0; i <

Re: [PATCH V3 1/2] dt-bindings: mailbox : arm,mhu: Convert to Json-schema

2020-09-15 Thread Jassi Brar
4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mailbox/arm,mhu.yaml# > > +$schema: http://dev

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-09-08 Thread Jassi Brar
On Tue, Sep 8, 2020 at 4:15 AM Arnd Bergmann wrote: > > Picking up the old thread again after and getting pinged by multiple > colleagues about it (thanks!) reading through the history. > > On Fri, Jun 12, 2020 at 7:29 AM Viresh Kumar wrote: > > > > On 11-06-

[GIT PULL] Mailbox changes for v5.9

2020-08-07 Thread Jassi Brar
Hi Linus, The following changes since commit 92ed301919932f13b9172e525674157e983d: Linux 5.8-rc7 (2020-07-26 14:14:06 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.9 for you to fetch changes up to

Re: [PATCH 0/7] Add initial Keem Bay SoC / Board support

2020-07-07 Thread Jassi Brar
On Tue, Jul 7, 2020 at 4:18 PM Daniele Alessandrelli wrote: > Just one question: should I remove the mailbox and scmi nodes from the > soc DT or can I keep them there even if the mailbox driver is not > available yet? > A device node can not be merged before its dt-bindings are.

Re: [PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr'

2020-07-06 Thread Jassi Brar
> + spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1); > dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue); > return; > case USB_REQ_CLEAR_FEATURE: Acked-by: Jassi Brar

Re: [PATCH 0/7] Add initial Keem Bay SoC / Board support

2020-07-05 Thread Jassi Brar
On Tue, Jun 16, 2020 at 10:56 AM Daniele Alessandrelli wrote: > > Hi, > > This patch-set adds initial support for a new Intel Movidius SoC code-named > Keem Bay. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. > > This initial patch-set enables only the minimal set of components

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 5:00 AM Sudeep Holla wrote: > > > > > Interesting logs ! The time taken to complete _successful_ requests > > > are arguably better in bad_trace ... there are many <10usec responses > > > in bad_trace, while the fastest response in good_trace is 53usec. > > > > Indeed

Re: [GIT PULL] Mailbox changes for v5.8

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 11:56 AM Rob Herring wrote: > > On Wed, Jun 10, 2020 at 11:10:56PM -0500, Jassi Brar wrote: > > > > Sivaprakash Murugesan (3): > > dt-bindings: mailbox: Add YAML schemas for QCOM APCS global block > > mailbox: qcom: Add clo

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-11 Thread Jassi Brar
On Thu, Jun 11, 2020 at 3:40 AM Sudeep Holla wrote: > > > > > > > > if (xfer->hdr.poll_completion) { > > > > > > - ktime_t stop = ktime_add_ns(ktime_get(), > > > > > > SCMI_MAX_POLL_TO_NS); > > > > > > + ktime_t stop = ktime_add_ns(ktime_get(), 500 * 1000 * > > >

[GIT PULL] Mailbox changes for v5.8

2020-06-10 Thread Jassi Brar
Hi Linus, The following changes since commit ffeb595d84811dde16a28b33d8a7cf26d51d51b3: Merge tag 'powerpc-5.7-6' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux (2020-05-30 12:28:44 -0700) are available in the Git repository at:

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 10:56 AM Sudeep Holla wrote: [I admit you can write bigger posts than me, so I am not going to write a passionate response to each of your paragraphs. Let's keep it to the point.] > > > > if (xfer->hdr.poll_completion) { > > > > - ktime_t stop =

Re: [PATCH] firmware: arm_scmi: fix timeout value for send_message

2020-06-10 Thread Jassi Brar
On Wed, Jun 10, 2020 at 3:23 AM Sudeep Holla wrote: > > On Sun, Jun 07, 2020 at 02:30:23PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Currently scmi_do_xfer() submits a message to mailbox api and waits > > for an apparent

Re: [PATCH V2 3/3] mailbox: qcom: Add ipq6018 apcs compatible

2020-06-07 Thread Jassi Brar
On Sat, Jun 6, 2020 at 5:59 AM Sivaprakash Murugesan wrote: > > The Qualcomm ipq6018 has apcs block, add compatible for the same. > Also, the apcs provides a clock controller functionality similar > to msm8916 but the clock driver is different. > > Create a child platform device based on the apcs

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-05 Thread Jassi Brar
On Fri, Jun 5, 2020 at 3:58 AM Sudeep Holla wrote: > > > > > >> bash-1526 [000] 1149.472553: scmi_xfer_begin: > > > > >> transfer_id=1538 msg_id=6 protocol_id=21 seq=0 poll=0 > > > > >> -0 [001] 1149.472733: scmi_xfer_begin: > > > > >> transfer_id=1539 msg_id=7

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-05 Thread Jassi Brar
On Thu, Jun 4, 2020 at 11:56 PM Sudeep Holla wrote: > > > >> bash-1526 [000] 1149.472553: scmi_xfer_begin: > > >> transfer_id=1538 msg_id=6 protocol_id=21 seq=0 poll=0 > > >> -0 [001] 1149.472733: scmi_xfer_begin: > > >> transfer_id=1539 msg_id=7 protocol_id=19 seq=1

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-04 Thread Jassi Brar
On Thu, Jun 4, 2020 at 4:20 AM Sudeep Holla wrote: > > On Wed, Jun 03, 2020 at 01:32:42PM -0500, Jassi Brar wrote: > > On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > > > > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > >

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:31 PM Sudeep Holla wrote: > > > > > > H/W is actually fine :) Its just that the driver is written to > > _also_ support a platform (my original) that doesn't have shmem and > > need to pass data via 32bit registers. > > Frankly, I am not against the doorbell mode, I am

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not allow

Re: [PATCH] mailbox: imx: Add context save/restore for suspend/resume

2020-05-30 Thread Jassi Brar
On Wed, May 27, 2020 at 8:55 PM Anson Huang wrote: > > Gentle ping... > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > suspend/resume > > > > > > > > > Subject: RE: [PATCH] mailbox: imx: Add context save/restore for > > > suspend/resume > > > > > > > From: Anson Huang

Re: [PATCH v6] support gce on mt6779 platform

2020-05-30 Thread Jassi Brar
On Thu, May 28, 2020 at 12:05 PM Dennis YC Hsieh wrote: > > This patch support gce on mt6779 platform. > > Change since v5: > - spearate address shift code in client helper and mailbox controller > - separate write_s/write_s_mask and write_s_value/write_s_mask_value so that > client can decide

Re: [PATCH] mailbox: no error log in mbox_client_txdone() for tx done by irq

2020-05-30 Thread Jassi Brar
On Mon, May 11, 2020 at 12:52 AM wrote: > > From: Joe Zhu > > client does not know and not care about how controller implement tx done. > mbox_client_txdone() may be called when controller uses irq method. > > Signed-off-by: Joe Zhu > --- > drivers/mailbox/mailbox.c | 4 +++- > 1 file changed,

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-28 Thread Jassi Brar
On Thu, May 28, 2020 at 2:20 PM Rob Herring wrote: > > On Fri, May 15, 2020 at 10:47:38AM +0530, Viresh Kumar wrote: > > From: Sudeep Holla > > > > Hi Rob, Arnd and Jassi, > > > > This stuff has been doing rounds on the mailing list since several years > > now with no agreed conclusion by all

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-21 Thread Jassi Brar
On Thu, May 21, 2020 at 7:24 AM Baolin Wang wrote: > > Hi Jassi, > > On Wed, May 13, 2020 at 2:32 PM Baolin Wang wrote: > > > > On Wed, May 13, 2020 at 2:05 PM Jassi Brar wrote: > > > > > > On Tue, May 12, 2020 at 11:14 PM Baolin Wa

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-18 Thread Jassi Brar
On Mon, May 18, 2020 at 10:40 PM Viresh Kumar wrote: > > On 18-05-20, 18:29, Bjorn Andersson wrote: > > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > > > This stuff has been doing rounds on the mailing list since several years > > > now with no agreed conclusion by all the parties. And here

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-18 Thread Jassi Brar
On Mon, May 18, 2020 at 2:42 AM Viresh Kumar wrote: > > On 15-05-20, 11:46, Jassi Brar wrote: > > As I asked you yesterday over the call, it may help if you could share > > some numbers to back up the doomsday scenario. > > Yes, I have already asked Sudeep to get s

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-15 Thread Jassi Brar
On Fri, May 15, 2020 at 12:17 AM Viresh Kumar wrote: > > - The hardware gives us the capability to write the register in > parallel, i.e. we can write 0x800 and 0x400 together without any > software locks, and so these 32 bits should be considered as separate > channel even if only one

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-13 Thread Jassi Brar
On Tue, May 12, 2020 at 11:14 PM Baolin Wang wrote: > > Hi Jassi, > > On Thu, May 7, 2020 at 11:23 AM Baolin Wang wrote: > > > > Hi Jassi, > > > > On Thu, May 7, 2020 at 7:25 AM Jassi Brar wrote: > > > > > > On Wed, May 6, 2020 a

Re: [PATCH v4 2/2] mailbox: sprd: Add Spreadtrum mailbox driver

2020-05-06 Thread Jassi Brar
On Wed, May 6, 2020 at 8:29 AM Baolin Wang wrote: > > Hi Jassi, > > On Tue, Apr 28, 2020 at 11:10 AM Baolin Wang wrote: > > > > From: Baolin Wang > > > > The Spreadtrum mailbox controller supports 8 channels to communicate > > with MCUs, and it contains 2 different parts: inbox and outbox,

Re: [BUGFIX PATCH] selftests: Use real temporary working directory for archiving

2019-10-04 Thread Jassi Brar
test${ext} created!" > > # clean up install directory > -rm -rf kselftest > +rm -rf $tmpdir > } > > main "$@" > FWIW, Acked-by: Jassi Brar -- Linaro.org │ Open source software for ARM SoCs | Follow Linaro http://facebook.com/pages/Linaro/155974581091106 - http://twitter.com/#!/linaroorg - http://linaro.org/linaro-blog

[GIT PULL] Mailbox changes for v5.4

2019-09-18 Thread Jassi Brar
Hi Linus, The following changes since commit f74c2bb98776e2de508f4d607cd519873065118e: Linux 5.3-rc8 (2019-09-08 13:33:15 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.4 for you to fetch changes up to

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 9:46 AM Andre Przywara wrote: > > On Wed, 18 Sep 2019 09:19:46 -0500 > Jassi Brar wrote: > > Hi, > > > On Wed, Sep 18, 2019 at 4:44 AM Andre Przywara > > wrote: > > > > > > > > > which needs 9 arguments to work

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 8:58 AM Andre Przywara wrote: > > > > Also there is mbox_chan_txdone() with which a controller driver can > > > signal TX completion explicitly. > > > > > No. Controller can use that only if it has specified txdone_irq, which > > is not the case here. > > I see. So does

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 4:44 AM Andre Przywara wrote: > > > which needs 9 arguments to work. The fact that the fist argument is > > always going to be same on a platform is just the way we use this > > instruction. > > > > > We should be as strict as possible to avoid any security issues. > > >

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 3:53 AM Peng Fan wrote: > > > > > > > + > > > > + "#mbox-cells": > > > > +const: 1 > > > > > > Why is this "1"? What is this number used for? It used to be the channel > > > ID, > > but since you are describing a single channel controller only, this should > > be 0

Re: [PATCH V6 2/2] mailbox: introduce ARM SMC based mailbox

2019-09-18 Thread Jassi Brar
On Wed, Sep 18, 2019 at 5:00 AM Andre Przywara wrote: > > > > > > > > > + }; > > > > +}; > > > > > > If this is the data structure that this mailbox controller uses, I would > > > expect > > > this to be documented somewhere, or even exported. > > > > Export this structure in

Re: [PATCH V6 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-17 Thread Jassi Brar
On Tue, Sep 17, 2019 at 12:31 PM Andre Przywara wrote: > > On Mon, 16 Sep 2019 09:44:37 + > Peng Fan wrote: > > Hi, > > > From: Peng Fan > > > > The ARM SMC/HVC mailbox binding describes a firmware interface to trigger > > actions in software layers running in the EL2 or EL3 exception

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-11 Thread Jassi Brar
On Wed, Sep 11, 2019 at 10:03 AM Andre Przywara wrote: > > On Tue, 10 Sep 2019 21:44:11 -0500 > Jassi Brar wrote: > > Hi, > > > On Mon, Sep 9, 2019 at 10:42 AM Andre Przywara > > wrote: > > > > > > On Wed,

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-10 Thread Jassi Brar
On Mon, Sep 9, 2019 at 10:42 AM Andre Przywara wrote: > > On Wed, 28 Aug 2019 03:02:58 + > Peng Fan wrote: > > Hi, > > sorry for the late reply, eventually managed to have a closer look on this. > > > From: Peng Fan > > > > The ARM SMC/HVC mailbox binding describes a firmware interface to

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-09-10 Thread Jassi Brar
On Mon, Sep 9, 2019 at 8:32 AM Andre Przywara wrote: > > On Fri, 30 Aug 2019 03:12:29 -0500 > Jassi Brar wrote: > > Hi, > > > On Fri, Aug 30, 2019 at 3:07 AM Peng Fan wrote: > > > > > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add bin

Re: [PATCH v2 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-09-04 Thread Jassi Brar
On Wed, Sep 4, 2019 at 12:51 AM Vinod Koul wrote: > > On 18-08-19, 00:17, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Document the devicetree bindings for Socionext Milbeaut HDMAC > > controller. Controller has upto 8 floating channels, that

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 4:32 AM Sudeep Holla wrote: > > On Fri, Aug 30, 2019 at 02:52:40AM -0500, Jassi Brar wrote: > > On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > [...] > > > > > > > If I get your point correctly, > > > On UP, both could n

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 3:07 AM Peng Fan wrote: > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the > > ARM > > SMC/HVC mailbox > > > > On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > > > > > Hi Jassi, > > > > > > > Subject: Re: [PATCH v5 1/2] dt-bindings:

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 2:37 AM Peng Fan wrote: > > Hi Jassi, > > > Subject: Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the > > ARM > > SMC/HVC mailbox > > > > On Fri, Aug 30, 2019 at 1:28 AM Peng Fan wrote: > > > > > > > +examples: > > > > > + - | > > > > > +sram@91

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-30 Thread Jassi Brar
On Fri, Aug 30, 2019 at 1:28 AM Peng Fan wrote: > > > +examples: > > > + - | > > > +sram@91 { > > > + compatible = "mmio-sram"; > > > + reg = <0x0 0x93f000 0x0 0x1000>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + ranges = <0 0x0 0x93f000

Re: [PATCH v5 1/2] dt-bindings: mailbox: add binding doc for the ARM SMC/HVC mailbox

2019-08-29 Thread Jassi Brar
On Tue, Aug 27, 2019 at 10:02 PM Peng Fan wrote: > > From: Peng Fan > > The ARM SMC/HVC mailbox binding describes a firmware interface to trigger > actions in software layers running in the EL2 or EL3 exception levels. > The term "ARM" here relates to the SMC instruction as part of the ARM >

Re: [PATCH 2/2] dmaengine: milbeaut-hdmac: Add HDMAC driver for Milbeaut platforms

2019-08-15 Thread Jassi Brar
On Mon, Jun 24, 2019 at 1:47 AM Vinod Koul wrote: > > On 12-06-19, 19:52, jassisinghb...@gmail.com wrote: > > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Do we need both, IIRC of_dma.h does

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-14 Thread Jassi Brar
On Wed, Aug 14, 2019 at 5:05 AM Sudeep Holla wrote: > > On Tue, Aug 13, 2019 at 11:36:56AM -0500, Jassi Brar wrote: > [...] > > > > >> > > > >> As mentioned in the response to your initial comment, the driver does > > > >> not cu

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-13 Thread Jassi Brar
On Fri, Aug 2, 2019 at 5:41 AM Morten Borup Petersen wrote: > > > > On 7/31/19 9:31 AM, Jassi Brar wrote: > > On Sun, Jul 28, 2019 at 4:28 PM Morten Borup Petersen > > wrote: > >> > >> > >> > >> On 7/25/19 7:49 AM, Jassi Brar wrote: &g

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-31 Thread Jassi Brar
On Sun, Jul 28, 2019 at 4:28 PM Morten Borup Petersen wrote: > > > > On 7/25/19 7:49 AM, Jassi Brar wrote: > > On Sun, Jul 21, 2019 at 4:58 PM Jassi Brar wrote: > >> > >> On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal > >> wrote: > >>

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-24 Thread Jassi Brar
On Sun, Jul 21, 2019 at 4:58 PM Jassi Brar wrote: > > On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal > wrote: > > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > > b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > >

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-07-21 Thread Jassi Brar
On Wed, Jul 17, 2019 at 2:26 PM Tushar Khandelwal wrote: > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > b/Documentation/devicetree/bindings/mailbox/arm,mhuv2.txt > new file mode 100644 > index ..3a05593414bc > --- /dev/null > +++

[GIT PULL] Mailbox changes for v5.3

2019-07-13 Thread Jassi Brar
Hi Linus, The following changes since commit 6fbc7275c7a9ba97877050335f290341a1fd8dbf: Linux 5.2-rc7 (2019-06-30 11:25:36 +0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.3 for you to fetch changes up to

Re: [PATCH 1/2] dt-bindings: milbeaut-m10v-hdmac: Add Socionext Milbeaut HDMAC bindings

2019-07-09 Thread Jassi Brar
On Tue, Jul 9, 2019 at 9:34 AM Rob Herring wrote: > > On Wed, Jun 12, 2019 at 07:52:37PM -0500, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > Document the devicetree bindings for Socionext Milbeaut HDMAC > > controller. Controller has upto

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-27 Thread Jassi Brar
On Thu, Jun 27, 2019 at 4:09 AM Sudeep Holla wrote: > > On Wed, Jun 26, 2019 at 01:27:41PM -0500, Jassi Brar wrote: > > On Wed, Jun 26, 2019 at 11:44 AM Florian Fainelli > > wrote: > > > > > > On 6/26/19 6:31 AM, Peng Fan wrote: > > > >>> Th

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-26 Thread Jassi Brar
On Wed, Jun 26, 2019 at 11:44 AM Florian Fainelli wrote: > > On 6/26/19 6:31 AM, Peng Fan wrote: > >>> The firmware driver might not have func-id, such as SCMI/SCPI. > >>> So add an optional func-id to let smc mailbox driver could > >>> use smc SiP func id. > >>> > >> There is no end to

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-26 Thread Jassi Brar
On Wed, Jun 26, 2019 at 8:31 AM Peng Fan wrote: > > > Hi All, > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox > > > > On Tue, Jun 25, 2019 at 2:30 AM Peng Fan wrote: > > > > > > Hi Jassi > > > > > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-25 Thread Jassi Brar
On Tue, Jun 25, 2019 at 2:30 AM Peng Fan wrote: > > Hi Jassi > > > Subject: Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox > > > > On Mon, Jun 3, 2019 at 3:28 AM wrote: > > > > > > From: Peng Fan > > > > > > This mailbox driver implements a mailbox which signals transmitted > > >

Re: [PATCH 0/2] Add Mailbox support for TI K3 SoCs

2019-06-24 Thread Jassi Brar
On Mon, Jun 24, 2019 at 3:39 PM Suman Anna wrote: > > Hi Jassi, > > On 6/4/19 12:01 PM, Suman Anna wrote: > > Hi Jassi, > > > > The following series adds the support for the Mailbox IP present > > within the Main NavSS module on the newer TI K3 AM65x and J721E SoCs. > > > > The Mailbox IP is

Re: [PATCH V2 2/2] mailbox: introduce ARM SMC based mailbox

2019-06-20 Thread Jassi Brar
On Mon, Jun 3, 2019 at 3:28 AM wrote: > > From: Peng Fan > > This mailbox driver implements a mailbox which signals transmitted data > via an ARM smc (secure monitor call) instruction. The mailbox receiver > is implemented in firmware and can synchronously return data when it > returns execution

Re: [PATCH V2 1/2] DT: mailbox: add binding doc for the ARM SMC mailbox

2019-06-20 Thread Jassi Brar
On Thu, Jun 20, 2019 at 11:13 AM Andre Przywara wrote: > > On Thu, 20 Jun 2019 10:22:41 +0100 > Sudeep Holla wrote: > > > On Mon, Jun 03, 2019 at 04:30:04PM +0800, peng@nxp.com wrote: > > > From: Peng Fan > > > > > > The ARM SMC mailbox binding describes a firmware interface to trigger > >

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-06-06 Thread Jassi Brar
On Thu, Jun 6, 2019 at 7:51 AM Sudeep Holla wrote: > > > BTW, this is not going to be the end of SCMI troubles (I believe > > that's what his client is). SCMI will eventually have to be broken up > > in layers (protocol and transport) for many legit platforms to use it. > > That is

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-06-05 Thread Jassi Brar
On Wed, Jun 5, 2019 at 2:46 PM Mark Brown wrote: > > On Tue, Jun 04, 2019 at 10:44:24AM +0100, Sudeep Holla wrote: > > On Mon, Jun 03, 2019 at 08:39:46PM +0100, Mark Brown wrote: > > > > > > It feels like the issues with sharing access to the hardware and with the > > > API for talking to

Re: [PATCH 1/6] mailbox: add support for doorbell/signal mode controllers

2019-06-03 Thread Jassi Brar
On Fri, May 31, 2019 at 9:33 AM Sudeep Holla wrote: > diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c > index 38d9df3fb199..e26a079f8223 100644 > --- a/drivers/mailbox/mailbox.c > +++ b/drivers/mailbox/mailbox.c > @@ -77,7 +77,10 @@ static void msg_submit(struct mbox_chan

Re: [PATCH 0/6] mailbox: arm_mhu: add support to use in doorbell mode

2019-05-31 Thread Jassi Brar
Hi Sudeep, On Fri, May 31, 2019 at 9:33 AM Sudeep Holla wrote: > > This is my another attempt to extend mailbox framework to support > doorbell mode mailbox hardware. It also adds doorbell support to ARM > MHU driver. > Nothing has really changed since the last time we discussed many months ago.

Re: [PATCH 0/2] mailbox: arm: introduce smc triggered mailbox

2019-05-26 Thread Jassi Brar
On Thu, May 23, 2019 at 12:50 AM Peng Fan wrote: > > This is a modified version from Andre Przywara's patch series > https://lore.kernel.org/patchwork/cover/812997/. > Can you please specify exact modifications on top of Andre's last submission? As in "Changes since v1: " Thanks.

[GIT PULL] Mailbox changes for v5.2

2019-05-10 Thread Jassi Brar
Hi Linus, The following changes since commit 37624b58542fb9f2d9a70e6ea006ef8a5f66c30b: Linux 5.1-rc7 (2019-04-28 17:04:13 -0700) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-v5.2 for you to fetch changes up to

[GIT PULL] Mailbox changes for v5.1

2019-03-12 Thread Jassi Brar
Hi Linus, The following changes since commit 3717f613f48df0222311f974cf8a06c8a6c97bae: Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2019-03-05 14:49:11 -0800) are available in the Git repository at:

[GIT PULL] Mailbox fixes for v5.0

2019-02-18 Thread Jassi Brar
Hi Linus, The following changes since commit a3b22b9f11d9fbc48b0291ea92259a5a810e9438: Linux 5.0-rc7 (2019-02-17 18:46:40 -0800) are available in the Git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git tags/mailbox-fixes-v5.0-rc7 for you to fetch changes

Re: [PATCH 1/3] mailbox: Add ability for clients to abort data in channel

2019-01-17 Thread Jassi Brar
On Thu, Jan 17, 2019 at 2:00 AM CK Hu wrote: > > Hi, Jassi: > > On Wed, 2019-01-16 at 10:22 -0600, Jassi Brar wrote: > > On Tue, Jan 15, 2019 at 11:07 PM CK Hu wrote: > > > > > > This patch supplies a new framework API, mbox_abort_channel(), and > >

Re: [PATCH 1/3] mailbox: Add ability for clients to abort data in channel

2019-01-16 Thread Jassi Brar
On Tue, Jan 15, 2019 at 11:07 PM CK Hu wrote: > > This patch supplies a new framework API, mbox_abort_channel(), and > a new controller interface, abort_data(). > > For some client's application, it need to clean up the data in channel > but keep the channel so it could send data to channel

  1   2   3   4   5   6   7   8   9   10   >