Re: [PATCH RESEND] PCI: Check for USB xHCI class for HAPS platform

On 02/05/2019 03:32 PM, Bjorn Helgaas wrote: [+cc Richard, Lucas] On Tue, Feb 05, 2019 at 01:04:28PM -0800, Thinh Nguyen wrote: The Synopsys HAPS USB controller has a VID PID (16c3,abcd) that matches to an existing PCIe controller. This quirk is intended for USB HAPS devices only. To fix this,

Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

hs_ep->frame_overrun = 0; + hs_ep->frame_overrun = false; } } +Felipe Acked-by: John Youn <johny...@synopsys.com> Regards, John

Re: [PATCH] usb: dwc2: gadget: Use true and false for boolean values

n = 0; + hs_ep->frame_overrun = false; } } +Felipe Acked-by: John Youn Regards, John

Re: [PATCH] usb: dwc2: add optional usb ecc reset bit

ce *dev) > dwc2_lowlevel_hw_disable(hsotg); > > reset_control_assert(hsotg->reset); > + reset_control_assert(hsotg->reset_ecc); > > return 0; > } > Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCH] usb: dwc2: add optional usb ecc reset bit

return ret; > + } > + > + reset_control_deassert(hsotg->reset_ecc); > + > /* Set default UTMI width */ > hsotg->phyif = GUSBCFG_PHYIF16; > > @@ -318,6 +327,7 @@ static int dwc2_driver_remove(struct platform_device *dev) > dwc2_lowlevel_hw_disable(hsotg); > > reset_control_assert(hsotg->reset); > + reset_control_assert(hsotg->reset_ecc); > > return 0; > } > Acked-by: John Youn John

Re: [PATCH] usb: dwc2: Fix TxFIFOn sizes and total TxFIFO size issues

HWCFG4_NUM_DEV_PERIO_IN_EP_SHIFT; > + hw->num_dev_in_eps = (hwcfg4 & GHWCFG4_NUM_IN_EPS_MASK) >> > + GHWCFG4_NUM_IN_EPS_SHIFT; > hw->dma_desc_enable = !!(hwcfg4 & GHWCFG4_DESC_DMA); > hw->power_optimized = !!(hwcfg4 & GHWCFG4_POWER_OPTIMIZ); > hw->utmi_phy_data_width = (hwcfg4 & GHWCFG4_UTMI_PHY_DATA_WIDTH_MASK) >> > @@ -704,6 +706,13 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg) > /* fifo sizes */ > hw->rx_fifo_size = (grxfsiz & GRXFSIZ_DEPTH_MASK) >> > GRXFSIZ_DEPTH_SHIFT; > + /* > + * Host specific hardware parameters. Reading these parameters > + * requires the controller to be in host mode. The mode will > + * be forced, if necessary, to read these values. > + */ > + dwc2_get_host_hwparams(hsotg); > + dwc2_get_dev_hwparams(hsotg); > > return 0; > } > Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCH] usb: dwc2: Fix TxFIFOn sizes and total TxFIFO size issues

_eps = (hwcfg4 & GHWCFG4_NUM_IN_EPS_MASK) >> > + GHWCFG4_NUM_IN_EPS_SHIFT; > hw->dma_desc_enable = !!(hwcfg4 & GHWCFG4_DESC_DMA); > hw->power_optimized = !!(hwcfg4 & GHWCFG4_POWER_OPTIMIZ); > hw->utmi_phy_data_width = (hwcfg4 & GHWCFG4_UTMI_PHY_DATA_WIDTH_MASK) >> > @@ -704,6 +706,13 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg) > /* fifo sizes */ > hw->rx_fifo_size = (grxfsiz & GRXFSIZ_DEPTH_MASK) >> > GRXFSIZ_DEPTH_SHIFT; > + /* > + * Host specific hardware parameters. Reading these parameters > + * requires the controller to be in host mode. The mode will > + * be forced, if necessary, to read these values. > + */ > + dwc2_get_host_hwparams(hsotg); > + dwc2_get_dev_hwparams(hsotg); > > return 0; > } > Acked-by: John Youn John

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

- Sent to Felipe Balbi as candiate to land this. >> - Add Cc for stable (it's always been broken so go as far is as easy) >> >> Changes in v2: >> - Address >> https://urldefense.proofpoint.com/v2/url?u=http-3A__crosreview.com_737520=DwICaQ=DPL6_X_6JkXFx7AXWqB0tg=U3o8uKoKhWme5_V9D-eeCkB11BFwt4KvWztBgdE9ZpA=Y_xpJ6Ks0XAK5_bQgmeQEvgKThZtPBQJ3cejNCGfEvM=olyPwyYvn_072esVwYxrCduKOKKJPUgc1YHX-CNhM1s= >> feedback >> > > does it need a resend? > You can add my acked-by: Acked-by: John Youn <johny...@synopsys.com> Regards, John

Re: [PATCH v3 1/2] usb: dwc2: host: Don't retry NAKed transactions right away

s as easy) >> >> Changes in v2: >> - Address >> https://urldefense.proofpoint.com/v2/url?u=http-3A__crosreview.com_737520=DwICaQ=DPL6_X_6JkXFx7AXWqB0tg=U3o8uKoKhWme5_V9D-eeCkB11BFwt4KvWztBgdE9ZpA=Y_xpJ6Ks0XAK5_bQgmeQEvgKThZtPBQJ3cejNCGfEvM=olyPwyYvn_072esVwYxrCduKOKKJPUgc1YHX-CNhM1s= >> feedback >> > > does it need a resend? > You can add my acked-by: Acked-by: John Youn Regards, John

Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

ice_id dwc2_of_match_table[] = { >> { .compatible = "st,stm32f4x9-fsotg", >>.data = dwc2_set_stm32f4x9_fsotg_params }, >> { .compatible = "st,stm32f4x9-hsotg" }, >> +{ .compatible = "st,stm32f7-hsotg", >> + .data = dwc2_set_stm32f7_hsotg_params }, >> {}, >> }; >> MODULE_DEVICE_TABLE(of, dwc2_of_match_table); >> Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCHv2 2/7] usb: dwc2: add support for STM32F7 USB OTG HS

dwc2_of_match_table[] = { >> { .compatible = "st,stm32f4x9-fsotg", >>.data = dwc2_set_stm32f4x9_fsotg_params }, >> { .compatible = "st,stm32f4x9-hsotg" }, >> +{ .compatible = "st,stm32f7-hsotg", >> + .data = dwc2_set_stm32f7_hsotg_params }, >> {}, >> }; >> MODULE_DEVICE_TABLE(of, dwc2_of_match_table); >> Acked-by: John Youn John

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

get some feedback on the patches and consideration > to be merged upstream. > > thanks > -john > > Cc: Wei Xu <xuw...@hisilicon.com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: YongQin Liu <yongqin@linaro.org

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

get some feedback on the patches and consideration > to be merged upstream. > > thanks > -john > > Cc: Wei Xu > Cc: Guodong Xu > Cc: Amit Pundir > Cc: YongQin Liu > Cc: John Youn > Cc: Minas Harutyunyan > Cc: Douglas Anderson > Cc: Chen Yu > Cc: Felipe Balbi &

Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero

->regs + DCFG, DCFG_DEVADDR_MASK); > + > if (usb_status & GOTGCTL_BSESVLD && connected) > dwc2_hsotg_core_init_disconnected(hsotg, true); > } > Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCH] usb: dwc2: gadget: On USB RESET reset device address to zero

EVADDR_MASK); > + > if (usb_status & GOTGCTL_BSESVLD && connected) > dwc2_hsotg_core_init_disconnected(hsotg, true); > } > Acked-by: John Youn John

Re: bug? dwc2: insufficient fifo memory

On 6/5/2017 5:32 AM, Minas Harutyunyan wrote: > On 6/2/2017 10:20 PM, John Stultz wrote: >> On Mon, Apr 17, 2017 at 3:36 PM, John Stultz wrote: >>> On Fri, Feb 24, 2017 at 2:46 PM, John Stultz wrote: Hey John, So after the USB tree

Re: bug? dwc2: insufficient fifo memory

On 6/5/2017 5:32 AM, Minas Harutyunyan wrote: > On 6/2/2017 10:20 PM, John Stultz wrote: >> On Mon, Apr 17, 2017 at 3:36 PM, John Stultz wrote: >>> On Fri, Feb 24, 2017 at 2:46 PM, John Stultz wrote: Hey John, So after the USB tree landed in 4.11-rc, I've been seeing the

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

On 03/30/2017 02:27 AM, Felipe Balbi wrote: > > Hi > > Roger Quadros writes: > For something that simple, we wouldn't even need to use OTG FSM layer > because that brings no benefit for such a simple requirement. no no. I think you got it wrong. I'm not using the

Re: [PATCH v2 3/4] usb: dwc3: add dual-role support

On 03/30/2017 02:27 AM, Felipe Balbi wrote: > > Hi > > Roger Quadros writes: > For something that simple, we wouldn't even need to use OTG FSM layer > because that brings no benefit for such a simple requirement. no no. I think you got it wrong. I'm not using the OTG FSM layer

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On 03/31/2017 04:04 PM, John Stultz wrote: > On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: >> Hey John, >> We've noticed that when using usb ethernet adapters on HiKey, we >> occasionally see errors like: >> >> dwc2 f72c.usb: dwc2_hc_chhltd_intr_dma: Channel 0

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On 03/31/2017 04:04 PM, John Stultz wrote: > On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: >> Hey John, >> We've noticed that when using usb ethernet adapters on HiKey, we >> occasionally see errors like: >> >> dwc2 f72c.usb: dwc2_hc_chhltd_intr_dma: Channel 0 - ChHltd set, >> but

Re: [PATCH v2] usb: dwc2: Make sure we disconnect the gadget state

Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Chen Yu <cheny...@huawei.com> &

Re: [PATCH v2] usb: dwc2: Make sure we disconnect the gadget state

every other time the OTG port is connected. > > So this patch adds a call to dwc2_hsotg_disconnect() in the > reset path so the state is properly cleared. > > With it, the gadget interface initializes properly on every > plug in. > > Cc: Wei Xu > Cc: Guodong Xu > Cc: Am

Re: bug? dwc2: insufficient fifo memory

+linux-usb On 2/24/2017 2:46 PM, John Stultz wrote: > Hey John, > So after the USB tree landed in 4.11-rc, I've been seeing the > following warning at bootup. > > It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm > seeing the addresses zip upward quickly as the txfsz values

Re: bug? dwc2: insufficient fifo memory

+linux-usb On 2/24/2017 2:46 PM, John Stultz wrote: > Hey John, > So after the USB tree landed in 4.11-rc, I've been seeing the > following warning at bootup. > > It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm > seeing the addresses zip upward quickly as the txfsz values

Re: bug? dwc2: insufficient fifo memory

On 2/24/2017 2:46 PM, John Stultz wrote: > Hey John, > So after the USB tree landed in 4.11-rc, I've been seeing the > following warning at bootup. > > It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm > seeing the addresses zip upward quickly as the txfsz values are all >

Re: bug? dwc2: insufficient fifo memory

On 2/24/2017 2:46 PM, John Stultz wrote: > Hey John, > So after the USB tree landed in 4.11-rc, I've been seeing the > following warning at bootup. > > It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm > seeing the addresses zip upward quickly as the txfsz values are all >

Re: [RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

On 2/21/2017 5:30 PM, Frank Wang wrote: > Hi John and Greg, > > Friendly ping... :-) > Hi Frank, We'll take a look at this and get back to you soon. Regards, John > On 2017/2/10 11:06, Frank Wang wrote: >> Resend this series to involve device tree maintainer and add 'Reviewed-by' >> tag for

Re: [RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

On 2/21/2017 5:30 PM, Frank Wang wrote: > Hi John and Greg, > > Friendly ping... :-) > Hi Frank, We'll take a look at this and get back to you soon. Regards, John > On 2017/2/10 11:06, Frank Wang wrote: >> Resend this series to involve device tree maintainer and add 'Reviewed-by' >> tag for

Re: [RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

reatly appreciated! > It looks good to me. Acked-by: John Youn <johny...@synopsys.com> Regards, John > thanks > -john > > > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I pl

Re: [RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

reatly appreciated! > It looks good to me. Acked-by: John Youn Regards, John > thanks > -john > > > I had seen some odd behavior with HiKey's usb-gadget interface > that I finally seemed to have chased down. Basically every other > time I pluged in the OTG port, the ga

Re: [RESEND PATCH 1/1] usb: dwc2: add multiple clock handling

On 2/6/2017 7:18 PM, Frank Wang wrote: > Hi Heiko, John and Greg, > > On 2017/2/7 8:06, Heiko Stuebner wrote: >> Hi Frank, >> >> Am Sonntag, 5. Februar 2017, 10:51:01 CET schrieb Frank Wang: >>> Originally, dwc2 just handle one clock named otg, however, it may have >>> two or more clock need to

Re: [RESEND PATCH 1/1] usb: dwc2: add multiple clock handling

On 2/6/2017 7:18 PM, Frank Wang wrote: > Hi Heiko, John and Greg, > > On 2017/2/7 8:06, Heiko Stuebner wrote: >> Hi Frank, >> >> Am Sonntag, 5. Februar 2017, 10:51:01 CET schrieb Frank Wang: >>> Originally, dwc2 just handle one clock named otg, however, it may have >>> two or more clock need to

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

On 1/30/2017 4:28 PM, John Youn wrote: > Hi Philipp, > > On 1/30/2017 3:42 AM, Philipp Zabel wrote: >> As of commit bb475230b8e5 ("reset: make optional functions really > > Where can I find this? It's not in mainline. > Never mind. I found on arm-soc per your reply el

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

On 1/30/2017 4:28 PM, John Youn wrote: > Hi Philipp, > > On 1/30/2017 3:42 AM, Philipp Zabel wrote: >> As of commit bb475230b8e5 ("reset: make optional functions really > > Where can I find this? It's not in mainline. > Never mind. I found on arm-soc per your reply el

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

sent reset controls. > > This allows to return errors from devm_reset_control_get_optional and to > call reset_control_(de)assert unconditionally. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Cc: Dinh Nguyen <dingu...@opensource.altera.com> > Cc: John Youn &

Re: [PATCH 12/14] usb: dwc2: simplify optional reset handling

sent reset controls. > > This allows to return errors from devm_reset_control_get_optional and to > call reset_control_(de)assert unconditionally. > > Signed-off-by: Philipp Zabel > Cc: Dinh Nguyen > Cc: John Youn > Cc: Felipe Balbi > Cc: Greg Kroah-Hart

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/18/2017 7:12 PM, Baolin Wang wrote: > Hi John, > > On 19 January 2017 at 09:33, John Youn <john.y...@synopsys.com> wrote: >> On 1/16/2017 2:38 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> John Youn <john.y...@synopsys.co

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/18/2017 7:12 PM, Baolin Wang wrote: > Hi John, > > On 19 January 2017 at 09:33, John Youn wrote: >> On 1/16/2017 2:38 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> John Youn writes: >>>>> Baolin Wang writes: >>&g

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/16/2017 2:38 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >>> Baolin Wang <baolin.w...@linaro.org> writes: >>>>> Baolin Wang <baolin.w...@linaro.org> writes: >>>>>> When dwc3 controll

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/16/2017 2:38 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >>> Baolin Wang writes: >>>>> Baolin Wang writes: >>>>>> When dwc3 controller acts as host role with attaching slow speed device >>>>>&

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

2_conn_id_status_change+0x130/0x250 >>> [ 86.335254] [] process_one_work+0x118/0x370 >>> [ 86.341035] [] worker_thread+0x48/0x498 >>> [ 86.346473] [] kthread+0xd0/0xe8 >>> [ 86.351299] [] ret_from_fork+0x10/0x50 >>> >>> This seems to be

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

>>> [ 86.341035] [] worker_thread+0x48/0x498 >>> [ 86.346473] [] kthread+0xd0/0xe8 >>> [ 86.351299] [] ret_from_fork+0x10/0x50 >>> >>> This seems to be caused by the dwc2_wait_for_mode() calling >>> usleep_range() while the hstog->lock

Re: [PATCH] usb: dwc2: host: use true/false for boolean

0); > - hsotg->bus_suspended = 0; > + hsotg->bus_suspended = false; > spin_unlock_irqrestore(>lock, flags); > } > > @@ -5000,7 +5000,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq) > hsotg->dev->dma_mask == NULL) { > dev_warn(

Re: [PATCH] usb: dwc2: host: use true/false for boolean

gt; + hsotg->bus_suspended = false; > spin_unlock_irqrestore(>lock, flags); > } > > @@ -5000,7 +5000,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq) > hsotg->dev->dma_mask == NULL) { > dev_warn(hsotg->dev, >

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

000, 4); > + msleep(20); > spin_lock_irqsave(>lock, flags); > } > > @@ -3691,7 +3691,7 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg > *hsotg, u16 typereq, > } > > /* Clear reset bit in 10ms

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

); > + msleep(20); > spin_lock_irqsave(>lock, flags); > } > > @@ -3691,7 +3691,7 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg > *hsotg, u16 typereq, > } > > /* Clear reset bit in 10ms (FS/LS) or 50ms (HS) */

Re: [PATCH RFC] usb: dwc2: host: use msleep() for long delay

rs/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -455,7 +455,7 @@ void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) > dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); > > if (dwc2_iddig_filter_enabled(hsotg)) > - usleep_range(10, 11); > + msleep(100); > } > > /* > +Felipe Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCH RFC] usb: dwc2: host: use msleep() for long delay

.c > +++ b/drivers/usb/dwc2/core.c > @@ -455,7 +455,7 @@ void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) > dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); > > if (dwc2_iddig_filter_enabled(hsotg)) > - usleep_range(10, 11); > + msleep(100); > } > > /* > +Felipe Acked-by: John Youn John

Re: [PATCH V2] usb: dwc2: host: fix Wmaybe-uninitialized warning

peed = NULL; > > dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb); > dev_vdbg(hsotg->dev, " Device address: %d\n", > +Felipe Acked-by: John Youn <johny...@synopsys.com> John

Re: [PATCH V2] usb: dwc2: host: fix Wmaybe-uninitialized warning

ruct usb_hcd *hcd, > struct urb *urb, > { > #ifdef VERBOSE_DEBUG > struct dwc2_hsotg *hsotg = dwc2_hcd_to_hsotg(hcd); > - char *pipetype; > - char *speed; > + char *pipetype = NULL; > + char *speed = NULL; > > dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb); > dev_vdbg(hsotg->dev, " Device address: %d\n", > +Felipe Acked-by: John Youn John

Re: [PATCH] usb: dwc2: gadget: Fix GUSBCFG.USBTRDTIM value

On 1/12/2017 7:41 AM, Amelie DELAUNAY wrote: > Hi all, > Sorry, I did not see Pengcheng Li patch which is exactly the same: >

Re: [PATCH] usb: dwc2: gadget: Fix GUSBCFG.USBTRDTIM value

On 1/12/2017 7:41 AM, Amelie DELAUNAY wrote: > Hi all, > Sorry, I did not see Pengcheng Li patch which is exactly the same: >

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/11/2017 11:51 PM, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Baolin Wang writes: When dwc3 controller acts as host role with attaching slow speed device (like mouse or keypad). Then if we plugged out the slow speed

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/11/2017 11:51 PM, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Baolin Wang writes: When dwc3 controller acts as host role with attaching slow speed device (like mouse or keypad). Then if we plugged out the slow speed device, it will timeout to run the

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

On 1/12/2017 12:07 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>> HiKey board for consideration for th

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

On 1/12/2017 12:07 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>> HiKey board for consideration for the 4.11 merge window. >>> >

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

exclude my patchset[1] to add extcon support to > dwc2, which John Youn suspects a pending rework of the dwc2 fifo > init logic might make unnecssary. > > thanks > -john > > [1] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2016_12_6_69=Dg

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

exclude my patchset[1] to add extcon support to > dwc2, which John Youn suspects a pending rework of the dwc2 fifo > init logic might make unnecssary. > > thanks > -john > > [1] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2016_12_6_69=Dg

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 3:10 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:58 PM, John Youn <john.y...@synopsys.com> wrote: >> On 1/11/2017 2:39 PM, John Stultz wrote: >>> On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: >>>> On 1/3/20

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 3:10 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:58 PM, John Youn wrote: >> On 1/11/2017 2:39 PM, John Stultz wrote: >>> On Wed, Jan 11, 2017 at 2:08 PM, John Youn wrote: >>>> On 1/3/2017 11:52 AM, John Stultz wrote: >>>>> Hope

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 2:39 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: >> On 1/3/2017 11:52 AM, John Stultz wrote: >>> Hope everyone had a happy new years! >>> >>> I just wanted to send out my curren

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 2:39 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:08 PM, John Youn wrote: >> On 1/3/2017 11:52 AM, John Stultz wrote: >>> Hope everyone had a happy new years! >>> >>> I just wanted to send out my current queue of patches for dw

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

xtcon support to dwc2, > which John Youn suspects a pending rework of the dwc2 fifo init > logic might make unnecssary. > > Any feedback would be greatly appreciated! > Hi John, Do you need these in 4.10-rc or is 4.11 ok? John

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

xtcon support to dwc2, > which John Youn suspects a pending rework of the dwc2 fifo init > logic might make unnecssary. > > Any feedback would be greatly appreciated! > Hi John, Do you need these in 4.10-rc or is 4.11 ok? John

Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

On 1/6/2017 1:52 PM, John Stultz wrote: > On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan wrote: >> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params") >> changes to type u16 for DT binding "g-rx-fifo-size" and >> "g-np-tx-fifo-size" but use type u32 for

Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

On 1/6/2017 1:52 PM, John Stultz wrote: > On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan wrote: >> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params") >> changes to type u16 for DT binding "g-rx-fifo-size" and >> "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the

[PATCH] usb: dwc2: use u32 for DT binding parameters

t two parameters cannot be passed successfully with wrong data format. This is found the data transferring broken on 96boards Hikey. This patch is to change all parameters to u32 type, and verified on Hikey board the DT parameters can pass successfully. [johnyoun: minor rebase] Signed-off-by: Leo Yan

[PATCH] usb: dwc2: use u32 for DT binding parameters

ssed successfully with wrong data format. This is found the data transferring broken on 96boards Hikey. This patch is to change all parameters to u32 type, and verified on Hikey board the DT parameters can pass successfully. [johnyoun: minor rebase] Signed-off-by: Leo Yan Signed-off-by: John Youn

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

On 12/28/2016 5:29 PM, John Youn wrote: > > >> Janusz Dziedzic <janusz.dzied...@gmail.com> writes: >>>>>> On some platfroms(like x86 platform), when one core is running the >> USB gadget >>>>>> irq thread handler by dwc3_thread_interrup

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

On 12/28/2016 5:29 PM, John Youn wrote: > > >> Janusz Dziedzic writes: >>>>>> On some platfroms(like x86 platform), when one core is running the >> USB gadget >>>>>> irq thread handler by dwc3_thread_interrupt(), meanwhile another >

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

rd for consideration for the 4.11 >> merge window. >> >> This does exclude my patchset[1] to add extcon support to dwc2, >> which John Youn suspects a pending rework of the dwc2 fifo init >> logic might make unnecssary. > > John/Vardan: Just as a heads up, al

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

or the 4.11 >> merge window. >> >> This does exclude my patchset[1] to add extcon support to dwc2, >> which John Youn suspects a pending rework of the dwc2 fifo init >> logic might make unnecssary. > > John/Vardan: Just as a heads up, along with these patches, I'm

RE: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, December 28, 2016 8:19 AM > To: Janusz Dziedzic > Cc: Lu Baolu ; Baolin Wang >

RE: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, December 28, 2016 8:19 AM > To: Janusz Dziedzic > Cc: Lu Baolu ; Baolin Wang > ; Greg KH ; USB > ; LKML ; Linaro > Kernel Mailman List ;

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 7:06 PM, John Youn wrote: > On 12/7/2016 4:44 AM, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rog...@ti.com> writes: >>>>> Roger Quadros <rog...@ti.com> writes: >>>>>> DCFG.DEVSPD == 0x3 is no

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 7:06 PM, John Youn wrote: > On 12/7/2016 4:44 AM, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>>>> Roger Quadros writes: >>>>>> DCFG.DEVSPD == 0x3 is not valid and we need to set >>>>>> D

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

On 12/8/2016 2:43 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 7:52 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/6/2016 5:48 PM, John Stultz wrote: >>> Hey John, >>> Just wanted to send this by you, as it seems something is >>> slightly off

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

On 12/8/2016 2:43 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 7:52 PM, John Youn wrote: >> On 12/6/2016 5:48 PM, John Stultz wrote: >>> Hey John, >>> Just wanted to send this by you, as it seems something is >>> slightly off with the GOTGCTL state w

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 4:44 AM, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 4:44 AM, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere between 1.73a and 2.60a.

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

d host modes? > > I suspect this isn't the best solution, but it seems to work > well for me. > The workaround seems fine, but still, this indicates that something wrong is going on somwhere. You can add my ack: Acked-by: John Youn <johny...@synopsys.com> Regards, John > Fe

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

d host modes? > > I suspect this isn't the best solution, but it seems to work > well for me. > The workaround seems fine, but still, this indicates that something wrong is going on somwhere. You can add my ack: Acked-by: John Youn Regards, John > Feedback would be greatly a

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On 12/6/2016 4:05 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 3:17 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/6/2016 12:06 AM, John Stultz wrote: >>> This patch wires up extcon support to the dwc2 driver >>> so that devices that use a modern gen

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On 12/6/2016 4:05 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 3:17 PM, John Youn wrote: >> On 12/6/2016 12:06 AM, John Stultz wrote: >>> This patch wires up extcon support to the dwc2 driver >>> so that devices that use a modern generic phy driver >>> and

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Chen Yu <cheny...@

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

Xu > Cc: Amit Pundir > Cc: Rob Herring > Cc: John Youn > Cc: Douglas Anderson > Cc: Chen Yu > Cc: Kishon Vijay Abraham I > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Signed-off-by: John Stultz > --- > v2: > * Move ex

Re: [PATCH v9 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

On 12/6/2016 4:00 AM, Ayaka wrote: > Hello John > I still waiting them be merged, but I still can't find it at next-20161206. > Can you resubmit this fixing the checkpatch issues? You can add my ack: Acked-by: John Youn <johny...@synopsys.com> Regards, John > 從我的 iPad

Re: [PATCH v9 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

On 12/6/2016 4:00 AM, Ayaka wrote: > Hello John > I still waiting them be merged, but I still can't find it at next-20161206. > Can you resubmit this fixing the checkpatch issues? You can add my ack: Acked-by: John Youn Regards, John > 從我的 iPad 傳送 > >> John Youn 於

Re: [PATCH] usb: dwc2: fix flags for DMA descriptor allocation in dwc2_hsotg_ep_enable

ev, > MAX_DMA_DESC_NUM_GENERIC * > sizeof(struct dwc2_dma_desc), > - _ep->desc_list_dma, GFP_KERNEL); > + _ep->desc_list_dma, GFP_ATOMIC); > if (!hs_ep->desc_list) { > ret = -ENOMEM; > goto error2; > Acked-by: John Youn <johny...@synopsys.com> Regards, John

Re: [PATCH] usb: dwc2: fix flags for DMA descriptor allocation in dwc2_hsotg_ep_enable

M_GENERIC * > sizeof(struct dwc2_dma_desc), > - _ep->desc_list_dma, GFP_KERNEL); > + _ep->desc_list_dma, GFP_ATOMIC); > if (!hs_ep->desc_list) { > ret = -ENOMEM; > goto error2; > Acked-by: John Youn Regards, John

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

ong...@linaro.org> >>> Cc: Amit Pundir <amit.pun...@linaro.org> >>> Cc: Rob Herring <robh...@kernel.org> >>> Cc: John Youn <johny...@synopsys.com> >>> Cc: Douglas Anderson <diand...@chromium.org> >>> Cc: Chen Yu <che

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

e usb UDC layer via a usb_phy structure. >>> >>> Not sure if this is the right way to connect phy -> UDC, >>> but I'm lacking a clear example. >>> >>> Cc: Wei Xu >>> Cc: Guodong Xu >>> Cc: Amit Pundir >>> Cc: Rob Herring

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

On 11/30/2016 4:47 AM, Felipe Balbi wrote: > > Hi, > > Raviteja Garimella writes: >> Hi Balbi, >> >> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Raviteja Garimella writes:

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

On 11/30/2016 4:47 AM, Felipe Balbi wrote: > > Hi, > > Raviteja Garimella writes: >> Hi Balbi, >> >> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Raviteja Garimella writes: This is driver for Synopsys Designware Cores USB Device Controller (UDC) Subsystem

Re: [RFC][PATCH 3/3] usb: dwc2: Make sure we disconnect the gadget state

it, the gadget interface initializes properly on every > plug in. > > Cc: Wei Xu <xuw...@hisilicon.com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...

Re: [RFC][PATCH 3/3] usb: dwc2: Make sure we disconnect the gadget state

it, the gadget interface initializes properly on every > plug in. > > Cc: Wei Xu > Cc: Guodong Xu > Cc: Amit Pundir > Cc: Rob Herring > Cc: John Youn > Cc: Douglas Anderson > Cc: Chen Yu > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-...@vge

Re: [PATCH 0/5] usb: dwc2: fix parameter handling

nged, 10 insertions(+), 22 deletions(-) > For this series: Acked-by: John Youn <johny...@synopsys.com> Felipe, This is too late for 4.10-rc1 right? Can you queue for 4.10 fixes. I can remind you after 4.10-rc1 if it's too early for that. Regards, John

Re: [PATCH 0/5] usb: dwc2: fix parameter handling

nged, 10 insertions(+), 22 deletions(-) > For this series: Acked-by: John Youn Felipe, This is too late for 4.10-rc1 right? Can you queue for 4.10 fixes. I can remind you after 4.10-rc1 if it's too early for that. Regards, John

[PATCH v3] usb: dwc2: add amcc,dwc-otg support

TA is used concurrently. Signed-off-by: Christian Lamparter <chunk...@gmail.com> Signed-off-by: John Youn <johny...@synopsys.com> --- Sorry, the previous one broke compilation. This fixes it. Regards, John v3 [johnyoun]: * Fixed compilation issue v2 [johnyoun]: * Removed params struct *

  1   2   3   4   5   >