ink it can be
- ASoC: audio-graph-card: Add audio mixer for Motorola mdm6600
: ASoC: motmdm: Add audio mixer for Motorola mdm6600
Thank you for your help !!
Best regards
---
Kuninori Morimoto
i Chiang
> Cc: Benson Leung
> Cc: Zhang Rui
> Cc: Daniel Lezcano
> Cc: Greg Kroah-Hartman
> Cc: Stefan Wahren
> Cc: Masahiro Yamada
> Cc: Odelu Kukatla
> Cc: Alex Elder
> Cc: Suman Anna
> Cc: Kuninori Morimoto
> Cc: Dmitry Baryshkov
> Cc: linux-g...@vger
o do.
>
> I think the patch does exactly the same thing as what you are
> suggesting below. Am I missing anything?
Yes, it is 100% same, but is simple patch.
I wanted to tell was it is easy to read/understand.
Your patch is already applied, so nothing we can do now ;)
Thank you for your help !!
Best regards
---
Kuninori Morimoto
e, "system-clock-frequency", ))
{
simple_dai->sysclk = val;
- } else {
- clk = devm_get_clk_from_child(dev, dlc->of_node, NULL);
- if (!IS_ERR(clk))
- simple_dai->sysclk = clk_get_rate(clk);
}
if (of_property_read_bool(node, "system-clock-direction-out"))
Thank you for your help !!
Best regards
---
Kuninori Morimoto
.
Except it
Acked-by: Kuninori Morimoto
Thank you for your help !!
Best regards
---
Kuninori Morimoto
such case, update also graph_parse_of() is nice idea for me.
- int graph_parse_of(...)
+ int audio_graph_parse_of()
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Hi Sameer
> Audio graph based sound card drivers can call graph_remove() function
> for cleanups during driver removal. To facilitate this export above
> mentioned function.
>
> Signed-off-by: Sameer Pujar
> Cc: Kuninori Morimoto
(snip)
> -static int graph_remove(struct
witched it to plain serdev and split it to two drivers to be easier
> to debug and understand. Credit is Tony's, bugs are probably Pavel's.
>
> Signed-off-by: Pavel Machek
> Co-authored-by: Tony Lindgren
> ---
This is not a big deal, but the this patch is not
directly relate
rt of above patch-set.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
From: Kuninori Morimoto
We have endpoint base functions
- of_graph_get_next_endpoint()
- of_graph_get_endpoint_count()
- for_each_endpoint_of_node()
Here, for_each_endpoint_of_node() loop finds endpoint
ports {
port@0 {
(1
d audio-graph-card
You can reuse audio-graph-card code by calling graph_parse_of(),
and customize before/after that.
I think no duplicate code is needed.
I hope it can help you.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
l.org/r/1606413823-19885-1-git-send-email-spu...@nvidia.com
Thank you for your help !!
Best regards
---
Kuninori Morimoto
o-graph-card2 which also supports
# overwriting/customizing each/all functions.
# It is not full compatible with audio-graph-card, but almost same if you
# uses normal connection.
# I hope I can post it next year
Thank you for your help !!
Best regards
---
Kuninori Morimoto
if (channel > 2)
> + return -EINVAL;
> + }
I think you want to add "fallthrough" between case 1/3/4 and case 0 ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
rty
>
> Custom sound cards can just reference 'audio-graph.yaml' and define its
> own compatible and specific properties.
Thank you for your patches.
I'm not expert of Json-schema, but for audio-graph-card Doc customizing
Acked-by: Kuninori Morimoto
Thank you for yo
eric ASoC driver updates. Below are the summary
> > of changes done.
>
> Morimoto-san, are you OK with these?
Yes. For audio-graph part
Acked-by: Kuninori Morimoto
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Hi Sameer
> >> Convert device tree bindings of audio graph card to YAML format. Also
> >> expose some common definitions which can be used by similar graph based
> >> audio sound cards.
> >>
> >> Signed-off-by: Sameer Pujar
> >> Cc:
Hi Sameer
> Convert device tree bindings of audio graph card to YAML format. Also
> expose some common definitions which can be used by similar graph based
> audio sound cards.
>
> Signed-off-by: Sameer Pujar
> Cc: Kuninori Morimoto
> ---
I'm posting this patch to
rd->probe = tegra_audio_graph_card_probe;
>
> /* graph_parse_of() depends on below */
> card->component_chaining = 1;
> priv->simple.ops = _audio_graph_ops;
> priv->simple.force_dpcm = 1;
>
> return graph_parse_of(>simple);
> }
I think graph side can handle card->owner / card->dev,
but, it looks good to me
Thank you for your help !!
Best regards
---
Kuninori Morimoto
haining = true;
card->probe = tegra_audio_graph_card_probe;
priv = >simple;
priv->ops_hook_pre = _audio_graph_ops;
priv->force_dpcm = 1;
/* audio-graph remain */
return audio_graph_prove(priv, pdev);
}
Thank you for your help !!
Best regards
---
Kuninori Morimoto
;
> - Populate 'dpcm_selectable' flag which is then used to detect
>DPCM DAI links.
>
> Signed-off-by: Sameer Pujar
> Cc: Kuninori Morimoto
> ---
Can we merge [06/13] and [07/13] patches ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
struct my_priv {
struct asoc_simple_priv *simple;
...
};
#define simple_to_priv(_simple) container_of((_simple), struct my_priv,
simple)
Thank you for your help !!
Best regards
---
Kuninori Morimoto
er functions are indeed exported function, but is used from
topology.c which is calling it under mutex.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
fter that I'm happy your next patch can re-use it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
without client_mutex.
(same/sof are calling it with mutex, simple-card/audio-graph are calling
without mutex)
Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex().
I'm not sure which style is best.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
\
=> WARN_ON(debug_locks && !lockdep_is_held(l));\
} while (0)
> May be snd_soc_dai_link_set_capabilities() requires similar fix?
Yes, I'm posting fixup patch.
https://patchwork.kernel.org/patch/11719919/
Thank you for your help !!
Best regards
---
Kuninori Morimoto
to test this patch-set this week, and report/review it.
>
> Thank you for review so far. Have you also got a chance to review
> remaining commits in the series?
I have no comment/opinion for other patches.
Thanks
Thank you for your help !!
Best regards
---
Kuninori Morimoto
t; + return false;
> +}
This snd_soc_find_dai() will indicate WARNING
if .config has CONFIG_LOCKDEP for me.
Maybe implement it at soc-core.c with client_mutex lock
is needed.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
m(cpus))
> + dai_link->no_pcm = 1;
> +
For safety, I want to judge with data->component_chaining.
if (data->component_chaining &&
!soc_component_is_pcm(cpus))
dai_link->no_pcm = 1;
Thank you for your help !!
Best regards
---
Kuninori Morimoto
I link names.
>
> Signed-off-by: Sameer Pujar
> ---
Acked-by: Kuninori Morimoto
Thank you for your help !!
Best regards
---
Kuninori Morimoto
ver proposal were discussed.
> * https://lkml.org/lkml/2020/4/30/519 (DPCM for Tegra)
> * https://lkml.org/lkml/2020/6/27/4 (simple-card driver)
I will try to test this patch-set this week, and report/review it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
codec_0: endpoint {
remote-endpoint = <_0>;
};
codec_1: endpoint {
remote-endpoint = <_1>;
};
}
};
Thank you for your help !!
Best regards
---
Kuninori Morimoto
> > or select one of 10 connections when use ?
>
> One ore more ADMAIF interfaces can be used simultaneously. In fact all
> of them can be used at the same time.
Ah, sorry my questoin was not correct.
I want to clarify was that below.
In my understanding,
if your system has 10 interf
'm not familiar with your system, so, one question.
Does this ADMAIF has total 10 interface which is used in the same time ?
or select one of 10 connections when use ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
breaks DPCM connection which is used for MIXer
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Hi Shengjiu
> Add missed return for calling soc_component_ret, otherwise the return
> value is wrong.
>
> Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> Signed-off-by: Shengjiu Wang
> ---
Acked-by: Kuninori Morimoto
Thank you fo
ems these functions are also missing "return"
snd_soc_pcm_component_new()
snd_soc_pcm_component_sync_stop()
Can you please care these, too ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
if (dai &&
(dai->pcm_new || dai->component->driver->pcm_construct))
return xxx
Thank you for your help !!
Best regards
---
Kuninori Morimoto
ed to describe FE component? or is there a better
> alternative?
soc_component_is_pcm() is called from simple_dai_link_of_dpcm :: "FE" side.
I wonder component->driver->non_legacy_dai_naming can't work for you ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
fusable point for me.
Using fe/be instead of cpu/codec is easy to understand.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
cm_construct)
> + return true;
> + }
> + }
> +
> + return false;
> +}
At least my CPU driver doesn't use component:pcm_construct
but is using DAI:pcm_new for some reasons.
I'm not sure checking DAI:pcm here is enough, or not...
Thank you for your help !!
Best regards
---
Kuninori Morimoto
rgument from
> simple_dai_link_of_dpcm().
Yes. 'codec' argument on current simple_dai_link_of_dpcm()
is not good match for multi Codec support.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
+ simple_parse_mclk_fs(top, np, np, dai_props, prefix);
Because of (A), cpu = codec = np in simple_parse_mclk_fs().
Do we have chance to call (B) ?
And it still have read_u32(cpu, ...) at (C),
this means all np will read mclk_fs anyway ?
For me, if you don't want/need mclk_fs, don't set it on DT
is the best answer, but am I misunderstanding ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
we can support it more easily :)
But, if it was difficult to keep compatibility on simple-card,
we/you need to have new one.
Actually, I had a plan to create more flexible sound card
driver, but it is not hi priority for me in these days.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
red? Isn't it better if we explicitly mention
> which
> DAI we want to operate as 'Master'?
I think Lars-Peter has (had ?) plan for this SND_SOC_DAIFMT_CBx_CFx
flag flexibility ? Yes maybe it is needed for multi CPU/Codec system.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
t; ../sound/soc/soc-io.c' failed with return code 1
>
> Signed-off-by: Randy Dunlap
> Cc: Kuninori Morimoto
> Cc: Mark Brown
> ---
We want to have
Fixes: 460b42d162e3 ("ASoC: soc-component: merge soc-io.c into
soc-component.c")
Acked-by: Kuninori Morimoto
Than
gt; + bool component_chaining;
snd_soc_card has many /* bit field */ variables.
Please use it instead of bool.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
+ continue;
We can/should NULL poinster check for "dlc->dai_name" on top of
this function instead of inside loop ?
And then, we can remove "dai->name" check because next strcmp()
automatically fail if dai->name was NULL.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
aving simple_node_is_codec(np, xxx) function
or something can help it ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
de
without using magical code in simple_parse_mclk_fs() side ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
ngly while parsing both CPU and
> Codec.
I'm sorry but I don't 100% understand about this case...
asoc_simple_parse_daifmt() should work in this case
The reason why it needs codec node is that
SND_SOC_DAIFMT_CBx_CFx are "Codec" base Master/Slave.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
t; }
This is nit-pick but it can be like this ?
if (snd_soc_is_matching_component(>dlc, component) &&
map->name_prefix) {
...
}
Thank you for your help !!
Best regards
---
Kuninori Morimoto
From: Kuninori Morimoto
This patch switches from .txt base to .yaml base Document.
Signed-off-by: Kuninori Morimoto
---
.../devicetree/bindings/sound/ak4642.txt | 37
.../devicetree/bindings/sound/ak4642.yaml | 57 +++
2 files changed, 57 insertions
From: Kuninori Morimoto
This patch switches from .txt base to .yaml base Document.
Signed-off-by: Kuninori Morimoto
---
v1 -> v2
- use patternProperties
.../devicetree/bindings/sound/ak4613.txt | 27 --
.../devicetree/bindings/sound/ak4613.yaml |
From: Kuninori Morimoto
FSI has FSI-A and FSI-B, and has fsia-xxx/fsib-xxx properties.
This patch uses patternProperties, and reduce verbose settings.
Signed-off-by: Kuninori Morimoto
---
.../bindings/sound/renesas,fsi.yaml | 19 ---
1 file changed, 4 insertions
From: Kuninori Morimoto
Audio Graph Card is using "audio-graph-card" prefix instead of
"simple-graph-card", and moreover "widgets / routing" doesn't need it.
This patch removes unsupported "simple-graph-card" prefix from
motorola-mapphone-common.dt
The Subject was "Re: [PATCH] ASoC: dt-bindings: simple-card: care missing
address #address-cells"
Hi Rob
I'm trying to create v2 of simple-card patch,
And got issue which I can't solve by myself.
I think "xxx,yyy" (= which has "," at the property name)
needs special care, but it is very
Uytterhoeven
> i.e. will queue in renesas-devel for v5.9.
Acked-by: Kuninori Morimoto
Thank you for your help !!
Best regards
---
Kuninori Morimoto
From: Kuninori Morimoto
Current simple-card will get below error,
because it doesn't care about #address-cells at some part.
DTC
Documentation/devicetree/bindings/sound/simple-card.example.dt.yaml
Documentation/devicetree/bindings/sound/simple-card.example.dts:171.46
or SSI BUSIF buffer.
>
> Cc: Kuninori Morimoto
> Reported-by: Chen Li
> Signed-off-by: Yongbo Zhang
> Tested-by: Chen Li
> ---
(snip)
> @@ -635,6 +713,19 @@ static int rsnd_ssi_irq(struct rsnd_mod *mod,
> if (enable)
> val = rsnd_ssi_is_
ut I know you are using it.
Thus don't say Acked-by and/or Reviewed-by,
but I have no objection about this patch.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
a address with consider of
> BUSIF")
> Signed-off-by: Jiada Wang
> Signed-off-by: Timo Wischer
> [erosca: minor improvements in commit description]
> Cc: Andrew Gabbasov
> Cc: sta...@vger.kernel.org # v4.20+
> Signed-off-by: Eugeniu Rosca
> ---
Acked-by: Kuninori Morimoto
kernel.org # v3.17+
> Signed-off-by: Junya Monden
> Signed-off-by: Eugeniu Rosca
> ---
Acked-by: Kuninori Morimoto
e using this as DPCM, but unfortunately
> it is not upstreamed. Using local patch.
I mean DT part.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
amed. Using local patch.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
t; Signed-off-by: Daniel Baluta
> ---
Acked-by: Kuninori Morimoto
Thank you for your help !!
Best regards
---
Kuninori Morimoto
nstraints don't have a requested
> PCM rate. But it's not expected.
>
> For example, if constraints are 32k, 21.33k, 16k, hw_params() will
> be called with 32k when an user requests to play 48k sounds.
Oh, I see.
Thank you for explaining.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
> avoid this problem.
>
> Signed-off-by: Katsuhiro Suzuki
> ---
I'm not 100% understand your issue.
.hw_params (= set mclk/sysclk) is not called in bad case ??
Or it is called but Codec driver ignores it somehow ??
Thank you for your help !!
Best regards
---
Kuninori Morimoto
e, how about to add new counter for hw_params/hw_free ?
Anyway, [3/3] patch is too much over-kill to me.
And, please don't exchange usrcnt inc/dec position at [2/3].
It is for open/close.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Hi Jiada, again
> The solution looks very over-kill to me,
> especiallyq [3/3] patch is too much to me.
>
> 1st, can we start clock at .hw_param, instead of .prepare ?
> and stop it at .hw_free ?
>
> 2nd, can we keep usrcnt setup as-is ?
> I guess we can just avoid rsnd_ssi_master_clk_start()
Hi Jiada
The solution looks very over-kill to me,
especiallyq [3/3] patch is too much to me.
1st, can we start clock at .hw_param, instead of .prepare ?
and stop it at .hw_free ?
2nd, can we keep usrcnt setup as-is ?
I guess we can just avoid rsnd_ssi_master_clk_start() if ssi->rate was not 0
d()")
> Link: https://github.com/ClangBuiltLinux/linux/issues/600
> Signed-off-by: Nathan Chancellor
> ---
Maybe
ec3042ad39d4e2ddbc3a3344f90bb10d8feb53bc
("ASoC: audio-graph-card: add missing const at graph_get_dai_id()")
Thank you for your help !!
Best regards
---
Kuninori Morimoto
fix an use-after-free in simple_for_each_link()
> ASoC: audio-graph-card: fix use-after-free in graph_dai_link_of_dpcm()
> ASoC: audio-graph-card: fix an use-after-free in graph_get_dai_id()
Actually, I was curious about these issue.
Thank you for your patches.
Acked-by: Kuninori Mo
ust been solved by Kuninori Morimoto with
> commit 1d7689892878 ("ASoC: soc-core: allow no Platform on dai_link").
>
> However, this change may still be useful for those who need multiple
> platform components on a single dai_link (it solves one of the FIXME
> note in soc-core)
> Fixes: c16015f36cc1 ("ASoC: rsnd: add .get_id/.get_id_sub")
>
> Signed-off-by: Nilkanth Ahirrao
> Signed-off-by: Suresh Udipi
> Signed-off-by: Jiada Wang
> ---
Acked-by: Kuninori Morimoto
> Fixes: 7e4f3419ebfe ("ASoC: rsnd: add .get_id/.get_id_sub")
>
> Signed-off-by: Nilkanth Ahirrao
> Signed-off-by: Suresh Udipi
> Signed-off-by: Jiada Wang
> ---
Thanks !!
Acked-by: Kuninori Morimoto
But, I guess commit ID is this for upstream ?
c16015f36cc128244
version
>
> Jiada Wang (2):
> ASoC: rsnd: src: Avoid a potential deadlock
> ASoC: rsnd: src: fix compiler warnings
Thank you for your patches.
For both patches
Acked-by: Kuninori Morimoto
Hi Jiada
Thank you for your patch
> This patch moves the 'static' keyword to the front of the
> declaration to fix the compiler warnings
>
> Fixes: linux-next commit 7674bec4fc09 ("ASoC: rsnd: update BSDSR/BSDISR
> handling")
> Signed-off-by: Jiada Wang
> ---
Acked-by: Kuninori Morimoto
Hi Jiada
Thank you for your patch
> lockdep warns us that priv->lock and k->k_lock can cause a
> deadlock when after acquire of k->k_lock, process is interrupted
> by src, while in another routine of src .init, k->k_lock is
> acquired with priv->lock held.
>
> This patch avoids a potential
ts: renesas:
> r8a7796: remove BUSIF0 settings from rcar_sound,ssi") for r8a77965.
>
> Signed-off-by: Jiada Wang
> Signed-off-by: Timo Wischer
> ---
Acked-by: Kuninori Morimoto
and access these registers in case of
> SSI9 BUSIF 4/5/6/7.
>
> Fixes: commit 8c9d75033340 ("ASoC: rsnd: ssiu: Support BUSIF other than
> BUSIF0")
> Signed-off-by: Jiada Wang
> Signed-off-by: Timo Wischer
> ---
Acked-by: Kuninori Morimoto
Hi Jiada
Thank you for your patch
> From: Jiada Wang
>
> rsnd driver supports SSIU now, let's use it.
> Then, BUSIF DMA settings on rcar_sound,ssi (= rxu, txu) are
> no longer needed.
> Applies commit 8d14bfa074db ("arm64: dts: renesas: r8a7796: add SSIU
> support for sound") for r8a77965.
>
t.
>
> Signed-off-by: Jiada Wang
> Signed-off-by: Timo Wischer
> ---
I thought I had mentioned about this, but it seems no fix...
Anyway
Acked-by: Kuninori Morimoto
Hi Jiada
Thank you for your patch
> Currently each SSI unit 's busif mode/adinr/dalign address is
> registered by: (in busif4 case)
> RSND_GEN_M_REG(SSI_BUSIF4_MODE, 0x500, 0x80)
> RSND_GEN_M_REG(SSI_BUSIF4_ADINR,0x504, 0x80)
> RSND_GEN_M_REG(SSI_BUSIF4_DALIGN, 0x508, 0x80)
>
> But according
Hi Jiada, again
> > Currently each SSI unit 's busif dma address is calculated by
> > following calculation formulation:
> > 0xec54 + 0x1000 * id + busif / 4 * 0xA000 + busif % 4 * 0x400
> >
> > But according to user manual 41.1.4 Register Configuration
> > ssi9 4/5/6/7 busif data register
/7, because its address is
* out of calculation rule
*/
if ((id == 9) && (busif >= 4))
dev_err(dev, "This driver doesn't support SSI%d-%d, so far",
id, busif);
Best regards
---
Kuninori Morimoto
.299387] of_get_next_child+0x3c/0x60
> > [1.303315] simple_for_each_link+0x1dc/0x230
> > [1.307676] simple_probe+0x80/0x540
> > [1.311256] platform_drv_probe+0x50/0xa0
> >
> > This patch is based on an earlier version posted by Kuninori Morimoto
> > and
> [1.307676] simple_probe+0x80/0x540
> [1.311256] platform_drv_probe+0x50/0xa0
>
> This patch is based on an earlier version posted by Kuninori Morimoto
> and commit message includes explanations from Mark Brown.
>
> https://patchwork.kernel.org/patch/10814255/
>
> Report
Hi Colin
> From: Colin Ian King
>
> There is a spelling mistake in a dev_err message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Acked-by: Kuninori Morimoto
> sound/soc/sh/fsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
driver is one of them.
I could find your branch at LinuxTV, and merged vc branch,
but unfortunately it can't solve compile issue.
I could understand its background.
It is OK for me if it will be solved on the next version.
I will skip it so far.
Thank you for your help
Best regards
---
Kuninori Morimoto
t is of type 'struct
media_entity *'
void media_pipeline_stop(struct media_pad *pad);
~~^~~
Best regards
---
Kuninori Morimoto
lt;< 4" should be used.
>
> This patch fix incorrect shifting issue in SSIU-9 case
>
> Fixes: commit b7169ddea2f2 ("ASoC: rsnd: remove RSND_REG_ from rsnd_reg")
>
> Signed-off-by: Jiada Wang
> ---
Thank you for your patch
Acked-by: Kuninori Morimoto
&g
rent cfg.
>
> Fixes: commit 9c698e8481a1 ("ASoC: rsnd: tidyup registering method for
> rsnd_kctrl_new()")
>
> Signed-off-by: Jiada Wang
> ---
I and Jiada discussed about this issue locally,
and agreed we can use my patch instead of this.
I will post it soon, so, please drop this patch.
Best regards
---
Kuninori Morimoto
round
3) switch to modern style as much as possible
1) and 2) are needed immediately.
3) needs more time, but we can try
Best regards
---
Kuninori Morimoto
rent
driver should select "legacy style" or "modern style".
If driver setup it as "legacy", but access to "modern" member,
it is driver side bug, right ?
Best regards
---
Kuninori Morimoto
Hi Rohit
> > I got below WARNING by this patch.
> > I guess we need mutex_lock() on snd_soc_register_card() ?
>
> Right, we should have client_mutex lock before calling
> soc_find_component().
>
> We will post fix.
Thanks !!
Best regards
---
Kuninori Morimoto
e correct ?
If so my posted patch can solve all issues ?
Best regards
---
Kuninori Morimoto
Hi Mark, Ajit
> From: Ajit Pandey
> Date: Wed, 9 Jan 2019 14:17:07 +0530
> Subject: [PATCH] ASoC: soc-core: defer card probe until all component is added
> to list
>
> DAI component probe is not called if it is not present
> in component list during sound card registration.
> Check if
nter" issue, "memory leak" issue,
and "memory leak attack" issue.
The problem is that code can be dirty temporary.
But it will be removed if all driver can be swtich to modern style.
Best regards
---
Kuninori Morimoto
orting snd_soc_dai_link_component style.
If all CPU/Codec/Platform supports snd_soc_dai_link_component style,
all driver can switch to it, and then, all will be static style.
Currently, simple card series is only(?) using this style.
The reason why platform is using pointer style is that
someone (not me ;P) will support multi platform style in the future.
Best regards
---
Kuninori Morimoto
1 - 100 of 1650 matches
Mail list logo
