[PATCH 2/3] MAINTAINERS: Add missing section for alienware-wmi driver

2021-04-01 Thread Mario Limonciello
This driver is maintained by Dell, but it was missing in MAINTAINERS. Signed-off-by: Mario Limonciello --- MAINTAINERS | 5 + drivers/platform/x86/dell/alienware-wmi.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH 1/3] MAINTAINERS: Adjust Dell drivers to email alias

2021-04-01 Thread Mario Limonciello
A team of engineers will be helping to service these drivers in the future rather than just one person. Signed-off-by: Mario Limonciello --- MAINTAINERS | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6e91994b8d3b..46c8fadb59c3

[PATCH 0/3] Adjust contacts for Dell drivers

2021-04-01 Thread Mario Limonciello
The Dell drivers I'm involved with all have me as an author and/or maintainer. In the future these will be maintained as a team effort. Adjust the contact addresses accordingly. Mario Limonciello (3): MAINTAINERS: Adjust Dell drivers to email alias MAINTAINERS: Add missing section

[PATCH 3/3] platform/x86: Adjust Dell drivers to a personal email address

2021-04-01 Thread Mario Limonciello
So that I can always be reached in the future if necessary, add a personal email address. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell/alienware-wmi.c | 2 +- drivers/platform/x86/dell/dell-smbios-base.c | 2 +- drivers/platform/x86/dell/dell-wmi-descriptor.c

[PATCH] platform/x86: dell-wmi-sysman: correct an initialization failure

2021-02-18 Thread Mario Limonciello
On Dell systems that don't support this interface the module is mistakingly returning error code "0", when it should be returning -ENODEV. Correct a logic error to guarantee the correct return code. Cc: Divya Bharathi Reported-by: Alexander Naumann Signed-off-by: Mario L

[RFC 0/2] Split out firmware upgrade from CAP_SYS_ADMIN

2021-02-18 Thread Mario Limonciello
that performs firmware upgrades to run without CAP_SYS_ADMIN, create a new capability CAP_FIRMWARE_UPGRADE that software can run with. For the RFC, only include NVME. Other drivers can be added if suggested. Mario Limonciello (2): capability: Introduce CAP_FIRMWARE_UPGRADE nvme: Use

[RFC 2/2] nvme: Use CAP_FIRMWARE_UPGRADE to check user commands

2021-02-18 Thread Mario Limonciello
Software that is running with CAP_FIRMWARE_UPGRADE needs a limited set of opcode access: * Identify the disk * Download firmware to the disk * Commit the firmwware to the disk Signed-off-by: Mario Limonciello --- drivers/nvme/host/core.c | 28 1 file changed, 24

[RFC 1/2] capability: Introduce CAP_FIRMWARE_UPGRADE

2021-02-18 Thread Mario Limonciello
Split out permissions specifically for firmware upgrades from CAP_SYS_ADMIN to a new separate capability. This will allow userspace applications that would traditionally have needed CAP_SYS_ADMIN to perform firmware upgrades to have a reduced permission set. Signed-off-by: Mario Limonciello

[PATCH v2] platform/x86: Move all dell drivers to their own subdirectory

2021-02-03 Thread Mario Limonciello
A user without a Dell system doesn't need to pick any of these drivers. Users with a Dell system can enable this submenu and all drivers behind it will be enabled. Suggested-by: Andy Shevchenko Signed-off-by: Mario Limonciello --- Changes from v1->v2: - Rename menu per Andy's suggest

[PATCH] platform/x86: Move all dell drivers to their own subdirectory

2021-02-03 Thread Mario Limonciello
A user without a Dell system doesn't need to pick any of these drivers. Suggested-by: Andy Shevchenko Signed-off-by: Mario Limonciello --- MAINTAINERS | 22 +-- drivers/platform/x86/Kconfig | 182 +- drivers/platform/x86

[PATCH] platform/x86: dell-wmi-sysman: fix a NULL pointer dereference

2021-01-29 Thread Mario Limonciello
An upcoming Dell platform is causing a NULL pointer dereference in dell-wmi-sysman initialization. Validate that the input from BIOS matches correct ACPI types and abort module initialization if it fails. This leads to a memory leak that needs to be cleaned up properly. Signed-off-by: Mario

[PATCH v5 2/4] e1000e: bump up timeout to wait when ME un-configures ULP mode

2020-12-14 Thread Mario Limonciello
-lan/patch/20200323191639.48826-1-aaron...@canonical.com/ Link: https://lkml.org/lkml/2020/12/13/15 Link: https://lkml.org/lkml/2020/12/14/708 Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

[PATCH v5 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-14 Thread Mario Limonciello
pervious to platform firmware behavior. Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- 1 file changed, 2 insertions(+

[PATCH v5 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-14 Thread Mario Limonciello
If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++-- 1 file changed, 7

[PATCH v5 4/4] e1000e: Export S0ix flags to ethtool

2020-12-14 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/e1000.h | 1 + drivers/net/ethernet/intel/e1000e/ethtool.c | 46 + drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++-- 3 files changed, 52 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet

[PATCH v5 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Mario Limonciello
ing - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (4): e1000e: Only run S0ix flows if shutdown succeeded e1000e: bump up timeout to wait when ME un

[PATCH 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems"

2020-12-14 Thread Mario Limonciello
pervious to platform firmware behavior. Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 45 +- 1 file changed, 2 insertions(+), 43 deletions(-) diff --gi

[PATCH v4 0/4] Improve s0ix flows for systems i219LM

2020-12-14 Thread Mario Limonciello
DMI matching to PCI subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (4): e1000e: Only run S0ix flows if shutdow

[PATCH 1/4] e1000e: Only run S0ix flows if shutdown succeeded

2020-12-14 Thread Mario Limonciello
If the shutdown failed, the part will be thawed and running S0ix flows will put it into an undefined state. Reported-by: Alexander Duyck Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/netdev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff

[PATCH 2/4] e1000e: bump up timeout to wait when ME un-configure ULP mode

2020-12-14 Thread Mario Limonciello
nk: https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200323191639.48826-1-aaron...@canonical.com/ Link: https://lkml.org/lkml/2020/12/13/15 Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[PATCH 4/4] e1000e: Export S0ix flags to ethtool

2020-12-14 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/e1000.h | 1 + drivers/net/ethernet/intel/e1000e/ethtool.c | 40 + drivers/net/ethernet/intel/e1000e/netdev.c | 9 ++--- 3 files changed, 46 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet

[PATCH RESEND] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Mario Limonciello
;). Fixes: 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown Signed-off-by: Tony Nguyen Reviewed-by: Alexander Duyck Signed-off-by: Mario Limonciello --- This patch was originally part of https://marc.info/?l=linux-ne

Re: [PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-08 Thread Mario Limonciello
On 12/4/20 2:09 PM, Mario Limonciello wrote: From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case").

[PATCH v3 6/7] e1000e: Add Dell TGL desktop systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
These Tiger Lake systems are not yet released, but have been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello

[PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Mario Limonciello
subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain. Mario Limonciello (6): e1000e: Move all S0ix related code into its own source file

[PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-04 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown

[PATCH v3 5/7] e1000e: Add more Dell CML systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net/ethernet/intel/e1000e/s0ix.c index 74043e80c32f..0dd2e2702ebb 100644 --- a/drivers/net/ethernet/intel/e1000e/s0ix.c +++ b

[PATCH v3 2/7] e1000e: Move all S0ix related code into its own source file

2020-12-04 Thread Mario Limonciello
Introduce a flag to indicate the device should be using the S0ix flows and use this flag to run those functions. Splitting the code to it's own file will make future heuristics more self contained. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e

[PATCH v3 7/7] e1000e: Add another Dell TGL notebook system into S0ix heuristics

2020-12-04 Thread Mario Limonciello
This Tiger Lake system is not yet released, but has been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello

[PATCH v3 4/7] e1000e: Add Dell's Comet Lake systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
entry and exit flows for ME systems") Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +--- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net/ethe

[PATCH v3 3/7] e1000e: Export S0ix flags to ethtool

2020-12-04 Thread Mario Limonciello
This flag can be used for debugging and development purposes including determining if S0ix flows work properly for a system not currently recognized by heuristics. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ethtool.c | 40

[PATCH v2 1/5] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-02 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown

[PATCH v2 3/5] e1000e: Add Dell's Comet Lake systems into s0ix heuristics

2020-12-02 Thread Mario Limonciello
Dell's Comet Lake Latitude and Precision systems containing i219LM are properly configured and should use the s0ix flows. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 33 +--- 1 file changed, 29 insertions(+), 4

[PATCH v2 0/5] Improve s0ix flows for systems i219LM

2020-12-02 Thread Mario Limonciello
the series - Split out s0ix code into it's own file - Adjust from DMI matching to PCI subsystem vendor ID/device matching - Remove module parameter and sysfs, use ethtool flag instead. - Export s0ix flag to ethtool private flags - Include more people and lists directly in this submission chain

[PATCH v2 5/5] e1000e: Export s0ix flags to ethtool

2020-12-02 Thread Mario Limonciello
This flag can be used for debugging and development purposes including determining if s0ix flows work properly for a system not currently recognized by heuristics. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ethtool.c | 40

[PATCH v2 2/5] e1000e: Move all s0ix related code into it's own source file

2020-12-02 Thread Mario Limonciello
Introduce a flag to indicate the device should be using the s0ix flows and use this flag to run those functions. Splitting the code to it's own file will make future heuristics more self containted. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e

[PATCH v2 4/5] e1000e: Add more Dell CML systems into s0ix heuristics

2020-12-02 Thread Mario Limonciello
-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/s0ix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/e1000e/s0ix.c b/drivers/net/ethernet/intel/e1000e/s0ix.c index 74043e80c32f..0dd2e2702ebb 100644 --- a/drivers/net/ethernet/intel/e1000e/s0ix.c +++ b

[PATCH 3/3] e1000e: Add more Dell CML systems into s0ix heuristics

2020-09-27 Thread Mario Limonciello
These comet lake systems are not yet released, but have been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello

[PATCH 1/3] e1000e: allow turning s0ix flows on for systems with ME

2020-09-27 Thread Mario Limonciello
: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") Signed-off-by: Mario Limonciello --- .../device_drivers/ethernet/intel/e1000e.rst | 23 drivers/net/ethernet/intel/e1000e/e1000.h | 7 ++ drivers/net/ethernet/intel/e1000e/netdev.c| 64 +- d

[PATCH 0/3] Improve s0ix flows for systems i219LM

2020-09-27 Thread Mario Limonciello
havior on by default for Dell's CML systems. These patches should only be carried if that patch linked above is also applied. Mario Limonciello (3): e1000e: allow turning s0ix flows on for systems with ME e1000e: Add Dell's Comet Lake systems into s0ix heuristics e1000e: Add more Dell C

[PATCH 2/3] e1000e: Add Dell's Comet Lake systems into s0ix heuristics

2020-09-27 Thread Mario Limonciello
Dell's Comet Lake Latitude and Precision systems containing i219LM are properly configured and should use the s0ix flows. Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/Kconfig| 1 + drivers/net/ethernet/intel/e1000e/param.c | 80 ++- 2 files

[PATCH v3 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-06-23 Thread Mario Limonciello
- Adjust function and parameter names to Mika's preferences - Rebase onto thunderbolt.git/bleeding-edge to move on top of retimer work Mario Limonciello (2): thunderbolt: Add support for separating the flush to SPI and authenticate thunderbolt: Add support for authenticate on disconnect

[PATCH v3 2/2] thunderbolt: Add support for authenticate on disconnect

2020-06-23 Thread Mario Limonciello
Some external devices can support completing thunderbolt authentication when they are unplugged. For this to work though, the link controller must remain operational. The only device known to support this right now is the Dell WD19TB, so add a quirk for this. Signed-off-by: Mario Limonciello

[PATCH v3 1/2] thunderbolt: Add support for separating the flush to SPI and authenticate

2020-06-23 Thread Mario Limonciello
This allows userspace to have a shorter period of time that the device is unusable and to call it at a more convenient time. For example flushing the image may happen while the user is using the machine and authenticating/rebooting may happen while logging out. Signed-off-by: Mario Limonciello

[PATCH v2 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-06-22 Thread Mario Limonciello
complete the update when unplugged. Export that functionality to userspace as well. Changes from v1 to v2: - Improve documentation - Drop tb-quirks.h - Adjust function and parameter names to Mika's preferences - Rebase onto thunderbolt.git/bleeding-edge to move on top of retimer work Mario

[PATCH v2 2/2] thunderbolt: Add support for authenticate on disconnect

2020-06-22 Thread Mario Limonciello
Some external devices can support completing thunderbolt authentication when they are unplugged. For this to work though, the link controller must remain operational. The only device known to support this right now is the Dell WD19TB, so add a quirk for this. Signed-off-by: Mario Limonciello

[PATCH v2 1/2] thunderbolt: Add support for separating the flush to SPI and authenticate

2020-06-22 Thread Mario Limonciello
This allows userspace to have a shorter period of time that the device is unusable and to call it at a more convenient time. For example flushing the image may happen while the user is using the machine and authenticating/rebooting may happen while logging out. Signed-off-by: Mario Limonciello

[PATCH 2/2] thunderbolt: Add support for authenticate on disconnect

2020-06-22 Thread Mario Limonciello
Some external devices can support completing thunderbolt authentication when they are unplugged. For this to work though, the link controller must remain operational. The only device known to support this right now is the Dell WD19TB, so add a quirk for this. Signed-off-by: Mario Limonciello

[PATCH 1/2] thunderbolt: Add support for separating the flush to SPI and authenticate

2020-06-22 Thread Mario Limonciello
This allows userspace to have a shorter period of time that the device is unusable and to call it at a more convenient time. For example flushing the image may happen while the user is using the machine and authenticating/rebooting may happen while logging out. Signed-off-by: Mario Limonciello

[PATCH 0/2] Allow breaking up Thunderbolt/USB4 updates

2020-06-22 Thread Mario Limonciello
complete the update when unplugged. Export that functionality to userspace as well. This patch series is done relative thunderbolt.git/next. Mario Limonciello (2): thunderbolt: Add support for separating the flush to SPI and authenticate thunderbolt: Add support for authenticate

[PATCH] tpm: Revert "tpm: fix invalid locking in NONBLOCKING mode"

2020-05-26 Thread Mario Limonciello
mode") Reported-by: Alex Guzman Signed-off-by: Mario Limonciello --- drivers/char/tpm/tpm-dev-common.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c index 87f449340202..bc9d7c7ddc01 100644 --- a/drivers/char/t

[PATCH] ACPI: PM: Revert "ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360"

2019-09-26 Thread Mario Limonciello
n adjusted in d916b1be this is expected to be now resolved. Cc: 'Paul Menzel ' BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=196907 Signed-off-by: Mario Limonciello --- The particular failing configuration was reported by only ever failed for Paul Menzel, so hopefully he can test on h

[PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-18 Thread Mario Limonciello
/system combinations. Signed-off-by: Mario Limonciello --- drivers/nvme/host/pci.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) Changes from v1: * Discard saved state in error scenario * Removed unneeded goto statement in error scenario diff --git a/drivers/nvme

[PATCH] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-11 Thread Mario Limonciello
/system combinations. Signed-off-by: Mario Limonciello --- drivers/nvme/host/pci.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 732d5b6..9b3fed4 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme

[PATCH] Revert "Bluetooth: btusb: driver to enable the usb-wakeup feature"

2019-08-19 Thread Mario Limonciello
kernel.org/show_bug.cgi?id=200039 Link: https://marc.info/?l=linux-bluetooth=156441081612627=2 Link: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/750073/ CC: Bastien Nocera CC: Christian Kellner CC: Sukumar Ghorai Signed-off-by: Mario Limonciello --- drivers/bluetooth/b

[PATCH v3] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-16 Thread Mario Limonciello
in the next firmware version. As this firmware is already in the field, avoid running nvme specific suspend to idle flow. Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend") Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html Signed-off

[PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Mario Limonciello
in the next firmware version. As this firmware is already in the field, avoid running nvme specific suspend to idle flow. Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend") Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html Signed-off

[PATCH] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Mario Limonciello
in the next firmware version. As this firmware is already in the field, avoid running nvme specific suspend to idle flow. Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend") Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html Signed-off

[PATCH] platform/x86: dell-laptop: fix rfkill functionality

2019-03-27 Thread Mario Limonciello
When converting the driver two arguments were transposed leading to rfkill not working. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 Reported-by: Pepijn de Vos Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") Signed-off-by: Mario Limoncie

[PATCH] r8152: Add support for MAC address pass through on RTL8153-BND

2018-12-11 Thread Mario Limonciello
containing RTL8153-BND should activate MAC pass through and there won't use pass through bit on efuse like in RTL8153-AD. Signed-off-by: Mario Limonciello --- drivers/net/usb/r8152.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb

[PATCH] platform/x86: intel-wmi-thunderbolt: Add dynamic debugging

2018-09-26 Thread Mario Limonciello
be turned on with dynamic debugging to better root cause this problem. Suggested-by: Mika Westerberg Signed-off-by: Mario Limonciello --- drivers/platform/x86/intel-wmi-thunderbolt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel-wmi

[PATCH] platform/x86: intel-wmi-thunderbolt: Add dynamic debugging

2018-09-26 Thread Mario Limonciello
be turned on with dynamic debugging to better root cause this problem. Suggested-by: Mika Westerberg Signed-off-by: Mario Limonciello --- drivers/platform/x86/intel-wmi-thunderbolt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel-wmi

[PATCH 2/2] platform/x86: alienware-wmi: Correct a memory leak

2018-09-10 Thread Mario Limonciello
An ACPI buffer that was allocated was not being freed after use. Signed-off-by: Mario Limonciello Cc: sta...@vger.kernel.org --- drivers/platform/x86/alienware-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c

[PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak

2018-09-10 Thread Mario Limonciello
ACPI buffers were being allocated but never freed. Reported-by: Pinzhen Xu Signed-off-by: Mario Limonciello Cc: sta...@vger.kernel.org --- drivers/platform/x86/dell-smbios-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86

[PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak

2018-09-10 Thread Mario Limonciello
ACPI buffers were being allocated but never freed. Reported-by: Pinzhen Xu Signed-off-by: Mario Limonciello Cc: sta...@vger.kernel.org --- drivers/platform/x86/dell-smbios-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86

[PATCH 2/2] platform/x86: alienware-wmi: Correct a memory leak

2018-09-10 Thread Mario Limonciello
An ACPI buffer that was allocated was not being freed after use. Signed-off-by: Mario Limonciello Cc: sta...@vger.kernel.org --- drivers/platform/x86/alienware-wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c

[PATCH] platform/x86: dell-smbios-base: Support systems without tokens

2018-06-15 Thread Mario Limonciello
Some Dell servers can use dell-smbios but they don't support the token interface. Make it optional. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios-base.c | 35 - 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH] platform/x86: dell-smbios-base: Support systems without tokens

2018-06-15 Thread Mario Limonciello
Some Dell servers can use dell-smbios but they don't support the token interface. Make it optional. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios-base.c | 35 - 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

2018-04-20 Thread Mario Limonciello
p;& SERIO_I8042 [=y] >> Right now it's possible to set dell laptop to compile in but this causes dell-smbios to compile in which breaks if dcdbas is a module. Dell laptop shouldn't select dell-smbios anymore, but depend on it. Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency erro

[PATCH] platform/x86: Kconfig: Fix dell-laptop dependency chain.

2018-04-20 Thread Mario Limonciello
p;& SERIO_I8042 [=y] >> Right now it's possible to set dell laptop to compile in but this causes dell-smbios to compile in which breaks if dcdbas is a module. Dell laptop shouldn't select dell-smbios anymore, but depend on it. Fixes: 32d7b19 (platform/x86: dell-smbios: Resolve dependency e

[PATCH] platform/x86: dell-smbios: Match on www.dell.com in OEM strings too

2018-04-17 Thread Mario Limonciello
Sergey reported that some much older Dell systems don't support the OEM string "Dell System" but instead supported www.dell.com in OEM strings. Match both of these to indicate that this driver is running on a Dell system. Reported-by: Sergey Kubushyn <k...@koi8.net> Sign

[PATCH] platform/x86: dell-smbios: Match on www.dell.com in OEM strings too

2018-04-17 Thread Mario Limonciello
Sergey reported that some much older Dell systems don't support the OEM string "Dell System" but instead supported www.dell.com in OEM strings. Match both of these to indicate that this driver is running on a Dell system. Reported-by: Sergey Kubushyn Signed-off-by: Mario Limonciel

[PATCH v3 2/2] power/hibernate: Change message when writing to /sys/power/resume

2018-03-28 Thread Mario Limonciello
This file is used both for setting the wakeup device without kernel command line as well as for actually waking the system (when appropriate swap header is in place). To avoid confusion on incorrect logs in system log downgrade the message to debug and make it clearer. Signed-off-by: Mario

[PATCH v3 2/2] power/hibernate: Change message when writing to /sys/power/resume

2018-03-28 Thread Mario Limonciello
This file is used both for setting the wakeup device without kernel command line as well as for actually waking the system (when appropriate swap header is in place). To avoid confusion on incorrect logs in system log downgrade the message to debug and make it clearer. Signed-off-by: Mario

[PATCH v3 1/2] power/hibernate: Make passing hibernate offsets more friendly

2018-03-28 Thread Mario Limonciello
Currently the only way to specify a hibernate offset for a swap file is on the kernel command line. Add a new /sys/power/resume_offset that lets userspace specify the offset and disk to use when initiating a hibernate cycle. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.

[PATCH v3 1/2] power/hibernate: Make passing hibernate offsets more friendly

2018-03-28 Thread Mario Limonciello
Currently the only way to specify a hibernate offset for a swap file is on the kernel command line. Add a new /sys/power/resume_offset that lets userspace specify the offset and disk to use when initiating a hibernate cycle. Signed-off-by: Mario Limonciello --- Changes from v2: * Cast

[PATCH v2 2/2] power/hibernate: Change message when writing to /sys/power/resume

2018-03-27 Thread Mario Limonciello
This file is used both for setting the wakeup device without kernel command line as well as for actually waking the system (when appropriate swap header is in place). To avoid confusion on incorrect logs in system log downgrade the message to debug and make it clearer. Signed-off-by: Mario

[PATCH v2 2/2] power/hibernate: Change message when writing to /sys/power/resume

2018-03-27 Thread Mario Limonciello
This file is used both for setting the wakeup device without kernel command line as well as for actually waking the system (when appropriate swap header is in place). To avoid confusion on incorrect logs in system log downgrade the message to debug and make it clearer. Signed-off-by: Mario

[PATCH v2 1/2] power/hibernate: Make passing hibernate offsets more friendly

2018-03-27 Thread Mario Limonciello
Currently the only way to specify a hibernate offset for a swap file is on the kernel command line. Add a new /sys/power/resume_offset that lets userspace specify the offset and disk to use when initiating a hibernate cycle. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.

[PATCH v2 1/2] power/hibernate: Make passing hibernate offsets more friendly

2018-03-27 Thread Mario Limonciello
Currently the only way to specify a hibernate offset for a swap file is on the kernel command line. Add a new /sys/power/resume_offset that lets userspace specify the offset and disk to use when initiating a hibernate cycle. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/sysfs

[PATCH] power/hibernate: Make passing hibernate offsets more friendly

2018-03-06 Thread Mario Limonciello
/power/resume and /sys/power/disk_offset parsing. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentation/ABI/testing/sysfs-power | 43 + Documentation/power/swsusp.txt| 10 +++- kernel/power/hibernate.c

[PATCH] power/hibernate: Make passing hibernate offsets more friendly

2018-03-06 Thread Mario Limonciello
/power/resume and /sys/power/disk_offset parsing. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/sysfs-power | 43 + Documentation/power/swsusp.txt| 10 +++- kernel/power/hibernate.c | 88 +-- 3 files changed, 125

[RFC] power/hibernate: Make passing hibernate offsets more friendly

2018-02-28 Thread Mario Limonciello
with it. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- An alternative to introducing a new sysfs parameter may be to document setting these values via /sys/power/resume. If the wrong signature is found on the swapfile/swap partition by the kernel it does show an error but it u

[RFC] power/hibernate: Make passing hibernate offsets more friendly

2018-02-28 Thread Mario Limonciello
with it. Signed-off-by: Mario Limonciello --- An alternative to introducing a new sysfs parameter may be to document setting these values via /sys/power/resume. If the wrong signature is found on the swapfile/swap partition by the kernel it does show an error but it updates the values and they'll work when

[PATCH v3 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 8 +--- 1 file changed, 5 insertions(+), 3 del

[PATCH v3 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH v3 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/platform

[PATCH v3 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH v3 2/3] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base

2018-02-27 Thread Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios drivers together. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Makefile | 1 + drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0

[PATCH v3 2/3] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base

2018-02-27 Thread Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios drivers together. Signed-off-by: Mario Limonciello --- drivers/platform/x86/Makefile | 1 + drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0 2 files changed, 1 insert

[PATCH v2 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH v2 2/3] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base

2018-02-27 Thread Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios drivers together. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Makefile | 1 + drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0

[PATCH v2 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH v2 2/3] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base

2018-02-27 Thread Mario Limonciello
This is being done to faciliate a later change to link all the dell-smbios drivers together. Signed-off-by: Mario Limonciello --- drivers/platform/x86/Makefile | 1 + drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0 2 files changed, 1 insert

[PATCH v2 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- changes from v1: * Adjust comment style drivers/platform/x86/dell-smbios.c | 8 +---

[PATCH v2 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello --- changes from v1: * Adjust comment style drivers/platform/x86/dell-smbios.c | 8 +--- 1 file changed, 5 insertions(+), 3

[PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-02-27 Thread Mario Limonciello
of this change the Kconfig needs to be adjusted so that CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean rather than modules. CONFIG_DELL_SMBIOS is a visually selectable option again and both CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional. Signed-off-by: Mario Limonciello

[PATCH 1/3] platform/x86: dell-smbios: Correct some style warnings

2018-02-27 Thread Mario Limonciello
at least + 6 bytes of entry */ WARNING: Block comments use a trailing */ on a separate line + 6 bytes of entry */ Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/platform

  1   2   3   4   5   6   7   8   >