Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

t;h...@rock-chips.com> Looks good. Reviewed-by:  Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/dri

Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

Looks good. Reviewed-by:  Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm

Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

t;h...@rock-chips.com> Looks good. Reviewed-by:  Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/dri

Re: [PATCH 2/2] drm/rockchip: vop: add rk3126 vop support

Looks good. Reviewed-by:  Mark Yao --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 30 + drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 6 ++ 2 files changed, 36 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm

[PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

For personal reasons, Mark Yao will leave rockchip, can not continue maintain drm/rockchip, Sandy Huang will take over the drm/rockchip. Cc: Sandy Huang <h...@rock-chips.com> Cc: Heiko Stuebner <he...@sntech.de> Signed-off-by: Mark Yao <mark@rock-chips.com> --- MAINTAIN

[PATCH] MAINTAINERS: change maintainer for Rockchip drm drivers

For personal reasons, Mark Yao will leave rockchip, can not continue maintain drm/rockchip, Sandy Huang will take over the drm/rockchip. Cc: Sandy Huang Cc: Heiko Stuebner Signed-off-by: Mark Yao --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

Re: [PATCH] drm/rockchip: analogix_dp: Use mutex rather than spinlock

On 2017年11月10日 20:07, Enric Balletbo Serra wrote: 2017-10-04 19:53 GMT+02:00 Emil Renner Berthing : On the Samsung Chromebook Plus I get this error with 4.14-rc3: BUG: scheduling while atomic: kworker/3:1/50/0x0002 Modules linked in: CPU: 3 PID: 50 Comm: kworker/3:1 Not

Re: [PATCH] drm/rockchip: analogix_dp: Use mutex rather than spinlock

On 2017年11月10日 20:07, Enric Balletbo Serra wrote: 2017-10-04 19:53 GMT+02:00 Emil Renner Berthing : On the Samsung Chromebook Plus I get this error with 4.14-rc3: BUG: scheduling while atomic: kworker/3:1/50/0x0002 Modules linked in: CPU: 3 PID: 50 Comm: kworker/3:1 Not tainted

Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path

ock-chips.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark

Re: [PATCH v6 10/10] drm/rockchip: dw_hdmi: Fix error handling path

r me Acked-by: Mark Yao Mark

Re: [PATCH v6 07/10] drm/rockchip: inno_hdmi: Fix error handling path

On 2017年10月19日 11:48, Jeffy Chen wrote: Add missing error handling in bind(). Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Signed-off-by: Jeffy Chen<jeffy.c...@rock-chips.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark

Re: [PATCH v6 07/10] drm/rockchip: inno_hdmi: Fix error handling path

On 2017年10月19日 11:48, Jeffy Chen wrote: Add missing error handling in bind(). Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support") Signed-off-by: Jeffy Chen Looks good for me Acked-by: Mark Yao Mark

Re: [PATCH v6 06/10] drm/rockchip: dw-mipi-dsi: Fix error handling path

com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark

Re: [PATCH v6 06/10] drm/rockchip: dw-mipi-dsi: Fix error handling path

On 2017年10月19日 11:48, Jeffy Chen wrote: Add missing pm_runtime_disable() in bind()'s error handling path. Also cleanup encoder & connector in unbind(). Fixes: 80a9a059d4e4 ("drm/rockchip/dsi: add dw-mipi power domain support") Signed-off-by: Jeffy Chen Looks good for me Acke

Re: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

On 2017年10月19日 11:48, Jeffy Chen wrote: The rockchip_drm_psr_register() can fail, so add a sanity check for that. Also reorder the calls in unbind() to match bind(). Signed-off-by: Jeffy Chen<jeffy.c...@rock-chips.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> Mark

Re: [PATCH v6 05/10] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()

On 2017年10月19日 11:48, Jeffy Chen wrote: The rockchip_drm_psr_register() can fail, so add a sanity check for that. Also reorder the calls in unbind() to match bind(). Signed-off-by: Jeffy Chen Looks good for me Acked-by: Mark Yao Mark

Re: [PATCH v6 02/10] drm/rockchip: analogix_dp: Remove unnecessary init code

.com> Looks good for me Acked-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: None Changes in v5: None drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 27 ++--- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/rockchip/ana

Re: [PATCH v6 02/10] drm/rockchip: analogix_dp: Remove unnecessary init code

On 2017年10月19日 11:48, Jeffy Chen wrote: Remove unnecessary init code, since we would do it in the power_on() callback. Also move of parse code to probe(). Fixes: 9e32e16e9e98 ("drm: rockchip: dp: add rockchip platform dp driver") Signed-off-by: Jeffy Chen Looks good for me Acke

Re: [RESEND PATCH v2 1/5] arm64: dts: rockchip: Enable edp disaplay on kevin

On 2017年10月16日 18:06, Jeffy Chen wrote: Add edp panel and enable related nodes on kevin. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Looks good. Reviewed-by: Mark Yao <mark@rock-chips.com> Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru-ke

Re: [RESEND PATCH v2 1/5] arm64: dts: rockchip: Enable edp disaplay on kevin

On 2017年10月16日 18:06, Jeffy Chen wrote: Add edp panel and enable related nodes on kevin. Signed-off-by: Jeffy Chen --- Looks good. Reviewed-by: Mark Yao Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 29 +++ arch/arm64/boot/dts/rockchip

Re: [PATCH v3 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface

On 2017年10月09日 16:06, Sandy Huang wrote: Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang --- Changes in v3: update for

Re: [PATCH v3 3/4] drm/rockchip: Add support for Rockchip Soc RGB output interface

On 2017年10月09日 16:06, Sandy Huang wrote: Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang --- Changes in v3: update for rgb-mode move to panel

Re: [PATCH] drm/rockchip: add PINCTRL dependency for LVDS

On 2017年10月05日 20:09, Arnd Bergmann wrote: The new driver fails to build when CONFIG_PINCTRL is disabled: drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config': drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct

Re: [PATCH] drm/rockchip: add PINCTRL dependency for LVDS

On 2017年10月05日 20:09, Arnd Bergmann wrote: The new driver fails to build when CONFIG_PINCTRL is disabled: drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_grf_config': drivers/gpu/drm/rockchip/rockchip_lvds.c:229:39: error: dereferencing pointer to incomplete type 'struct

Re: [PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

an you rebase your patches to drm-misc-next, these patches would conflict to current drm-misc-next branch. And please see my comment inline. Mark Yao --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390 drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drive

Re: [PATCH v2 2/8] drm/rockchip/dsi: add dual mipi channel support

-misc-next, these patches would conflict to current drm-misc-next branch. And please see my comment inline. Mark Yao --- drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 390 drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

On 2017年09月26日 15:55, Nickey Yang wrote: This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider

Re: [PATCH v2 1/8] drm/rockchip/dsi: correct Feedback divider setting

On 2017年09月26日 15:55, Nickey Yang wrote: This patch correct Feedback divider setting: 1、Set Feedback divider [8:5] when HIGH_PROGRAM_EN 2、Due to the use of a "by 2 pre-scaler," the range of the feedback multiplication Feedback divider is limited to even division numbers, and Feedback divider

Re: [PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

On 2017年09月26日 15:55, Nickey Yang wrote: Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang Hi Nickey Haneen Mohammed already send similar patch, and it was applied, see following

Re: [PATCH v2 5/8] drm/rockchip/dsi: Use DRM_DEV_ERROR instead of dev_err

On 2017年09月26日 15:55, Nickey Yang wrote: Rockchip driver has been moved to using the DRM_DEV_ERROR log messages, so change all instances of dev_err. Signed-off-by: Nickey Yang Hi Nickey Haneen Mohammed already send similar patch, and it was applied, see following patch on drm-misc-next

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月26日 16:08, Daniel Vetter wrote: On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: On 2017年09月26日 13:12, Daniel Vetter wrote: On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月26日 16:08, Daniel Vetter wrote: On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: On 2017年09月26日 13:12, Daniel Vetter wrote: On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月26日 13:12, Daniel Vetter wrote: On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Th

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月26日 13:12, Daniel Vetter wrote: On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Th

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <tho...@m3y3r.de> --- Looks good for me: Acked-by: Mark Yao <mark@rock-chips

Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

On 2017年09月21日 06:29, Thomas Meyer wrote: Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- Looks good for me: Acked-by: Mark Yao diff -u -p a/drivers/gpu/drm/rockchip/rockchip

Re: [PATCH v2] drm/rockchip: Replace dev_* with DRM_DEV_*

On 2017年09月15日 16:36, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the help of the following Coccinelle script: @r@ @@ ( -dev_info +DRM_DEV_INFO |

Re: [PATCH v2] drm/rockchip: Replace dev_* with DRM_DEV_*

On 2017年09月15日 16:36, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the help of the following Coccinelle script: @r@ @@ ( -dev_info +DRM_DEV_INFO |

Re: [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*

Change the tile to: drm/rockchip: Replace dev_* with DRM_DEV_* Thanks. On 2017年09月15日 14:47, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the

Re: [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*

Change the tile to: drm/rockchip: Replace dev_* with DRM_DEV_* Thanks. On 2017年09月15日 14:47, Haneen Mohammed wrote: This patch replace instances of dev_info/err/debug with DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted specific log messages. Issue corrected with the

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 14:12, Mark yao wrote: On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 14:12, Mark yao wrote: On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao <mark@r

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月08日 13:04, Heiko Stuebner wrote: Am Freitag, 8. September 2017, 09:23:09 CEST schrieb Mark yao: On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao I'd like to apply

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao <mark@rock-chips.com> I'd like to apply these lvds patches tomorrow if there is no more doubts. Rob had some minor co

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

On 2017年09月07日 20:09, Heiko Stübner wrote: Hi Mark, Am Donnerstag, 7. September 2017, 18:16:29 CEST schrieb Mark yao: Looks good for me, so: Reviewed-by: Mark Yao I'd like to apply these lvds patches tomorrow if there is no more doubts. Rob had some minor comments on v7 of the dt-binding

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

Hi Sandy Looks good for me, so: Reviewed-by: Mark Yao <mark@rock-chips.com> I'd like to apply these lvds patches tomorrow if there is no more doubts. Best Regards Mark On 2017年09月02日 19:28, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the p

Re: [PATCH v8 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

Hi Sandy Looks good for me, so: Reviewed-by: Mark Yao I'd like to apply these lvds patches tomorrow if there is no more doubts. Best Regards Mark On 2017年09月02日 19:28, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko

Re: [PATCH v7 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

On 2017年08月23日 14:26, Sandy Huang wrote: This patch add Document for Rockchip Soc RK3288 LVDS, This based on the patches from Mark yao and Heiko Stuebner. Signed-off-by: Sandy Huang <h...@rock-chips.com> Signed-off-by: Mark yao <mark@rock-chips.com> Signed-off-by: Heiko

Re: [PATCH v7 1/3] dt-bindings: display: Add Document for Rockchip Soc LVDS

On 2017年08月23日 14:26, Sandy Huang wrote: This patch add Document for Rockchip Soc RK3288 LVDS, This based on the patches from Mark yao and Heiko Stuebner. Signed-off-by: Sandy Huang Signed-off-by: Mark yao Signed-off-by: Heiko Stuebner --- Looks good for me: Reviewed-by: Mark Yao

Re: [PATCH] arm64: dts: rk3399: init vop clock rates

On 2017年08月16日 10:51, Kever Yang wrote: We need to init vop aclk and hclk incase the U-Boot does not do the initialize. Signed-off-by: Kever Yang <kever.y...@rock-chips.com> --- Looks good for me: Reviewed-by: Mark Yao <mark@rock-chips.com> arch/arm64/boot/dts/rockchip

Re: [PATCH] arm64: dts: rk3399: init vop clock rates

On 2017年08月16日 10:51, Kever Yang wrote: We need to init vop aclk and hclk incase the U-Boot does not do the initialize. Signed-off-by: Kever Yang --- Looks good for me: Reviewed-by: Mark Yao arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH v4 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

Hi Sandy On 2017年08月15日 08:56, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang <h...@rock-chips.com> Signed-off-by: Mark yao <mark@rock-chips.com> Signed-off-by: Heiko

Re: [PATCH v4 3/3] drm/rockchip: Add support for Rockchip Soc LVDS

Hi Sandy On 2017年08月15日 08:56, Sandy Huang wrote: This adds support for Rockchip soc lvds found on rk3288 Based on the patches from Mark yao and Heiko Stuebner Signed-off-by: Sandy Huang Signed-off-by: Mark yao Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/Kconfig

Re: [PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

-by: Jose Abreu <joab...@synopsys.com> Tested-by: Mark Yao <mark@rock-chips.com> This is needed for RK3399 support. Can you please apply it? Best regards, Jose Miguel Abreu Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Laurent Pinchart <laurent.pinchart+ren

Re: [PATCH v2] drm: bridge: synopsys/dw-hdmi: Provide default configuration function for HDMI 2.0 PHY

-by: Jose Abreu Tested-by: Mark Yao This is needed for RK3399 support. Can you please apply it? Best regards, Jose Miguel Abreu Cc: Kieran Bingham Cc: Laurent Pinchart Cc: Archit Taneja Cc: Andrzej Hajda Cc: Mark Yao Cc: Carlos Palminha Cc: Heiko Stübner Changes in v2: - Rebased

[PATCH v1.1] drm/rockchip: fix race with kms hotplug and fbdev

xf0 [0.756316] [] ret_from_fork+0x10/0x40 [0]: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms-helpers.html Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v1.1: - According to the kerneldoc, fix the race bug in generic way. drivers/gpu/drm/rockchip/rockchip_drm_d

[PATCH v1.1] drm/rockchip: fix race with kms hotplug and fbdev

xf0 [0.756316] [] ret_from_fork+0x10/0x40 [0]: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms-helpers.html Signed-off-by: Mark Yao --- Changes in v1.1: - According to the kerneldoc, fix the race bug in generic way. drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 13 ++--- 1 f

Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

On 2017年07月31日 20:28, Daniel Vetter wrote: On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov <emil.l.veli...@gmail.com> wrote: On 31 July 2017 at 10:50, Mark Yao <mark@rock-chips.com> wrote: Since fb_helper is not a pointer on rockchip_drm_private, it's no need to check pointer.

Re: [PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

On 2017年07月31日 20:28, Daniel Vetter wrote: On Mon, Jul 31, 2017 at 1:57 PM, Emil Velikov wrote: On 31 July 2017 at 10:50, Mark Yao wrote: Since fb_helper is not a pointer on rockchip_drm_private, it's no need to check pointer. Kms hotplug event may race into fbdev helper initial

[PATCH 0/6] drm/rockchip: Some fixes

Here are some fixes port from rockchip_linux project[0], Tested on rk3399 and rk3288 board. [0]: https://github.com/rockchip-linux/kernel Mark Yao (6): drm/rockchip: vop: no need wait vblank on crtc enable drm/rockchip: vop: fix iommu page fault when resume drm/rockchip: vop: fix NV12

[PATCH 0/6] drm/rockchip: Some fixes

Here are some fixes port from rockchip_linux project[0], Tested on rk3399 and rk3288 board. [0]: https://github.com/rockchip-linux/kernel Mark Yao (6): drm/rockchip: vop: no need wait vblank on crtc enable drm/rockchip: vop: fix iommu page fault when resume drm/rockchip: vop: fix NV12

[PATCH 1/6] drm/rockchip: vop: no need wait vblank on crtc enable

Since atomic framework, crtc enable and disable are in pairs, no need to wait vblank. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 - 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/ro

[PATCH 1/6] drm/rockchip: vop: no need wait vblank on crtc enable

Since atomic framework, crtc enable and disable are in pairs, no need to wait vblank. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 36 - 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers

[PATCH 5/6] drm/rockchip: vop: report error when check resource error

The user would be confused while facing a error commit without any error report. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vo

[PATCH 5/6] drm/rockchip: vop: report error when check resource error

The user would be confused while facing a error commit without any error report. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

[PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

316] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c inde

[PATCH 6/6] drm/rockchip: fix race with kms hotplug and fbdev

316] [] ret_from_fork+0x10/0x40 Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index 81f9548..e6bd0f4 100644 --- a/driv

[PATCH 2/6] drm/rockchip: vop: fix iommu page fault when resume

igned-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33 + 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 0

[PATCH 2/6] drm/rockchip: vop: fix iommu page fault when resume

igned-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 33 + 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 0bfd563..0b5fd75 100644 --- a/dr

[PATCH 4/6] drm/rockchip: vop: round_up pitches to word align

) + (win0_vir_width%3) RGB565 : ceil(win0_vir_width/2) YUV : ceil(win0_vir_width/4) Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vo

[PATCH 3/6] drm/rockchip: vop: fix NV12 video display error

fixup the scale calculation formula on the case src_height == (dst_height/2). Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/g

[PATCH 3/6] drm/rockchip: vop: fix NV12 video display error

fixup the scale calculation formula on the case src_height == (dst_height/2). Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h

[PATCH 4/6] drm/rockchip: vop: round_up pitches to word align

) + (win0_vir_width%3) RGB565 : ceil(win0_vir_width/2) YUV : ceil(win0_vir_width/4) Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip

Re: [PATCH v6 0/7] drm/rockchip: add all full framework vop support

Hi Pushed to drm-misc-next. Thanks Sean Paul, Jeffy Chen's review, Heiko's test and Rob's ack. Best regards. On 2017年07月26日 14:18, Mark Yao wrote: These patches try to make all current rockchip full framework vop works on drm, fill missing vop on full framework. Vop Full framework now has

Re: [PATCH v6 0/7] drm/rockchip: add all full framework vop support

Hi Pushed to drm-misc-next. Thanks Sean Paul, Jeffy Chen's review, Heiko's test and Rob's ack. Best regards. On 2017年07月26日 14:18, Mark Yao wrote: These patches try to make all current rockchip full framework vop works on drm, fill missing vop on full framework. Vop Full framework now has

[PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6.1 - fix Null p

[PATCH v6.1 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao Reviewed-by: Jeffy Chen --- Changes in v6.1 - fix Null pointer crash on vop_reg_set drivers/gpu/drm/rockchip/rockchip_drm_vop.c

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko On 2017年07月28日 09:02, Mark yao wrote: Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko On 2017年07月28日 09:02, Mark yao wrote: Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers facilitates make register definition clearer, and also

Re: [PATCH v6 4/7] drm/rockchip: vop: group vop registers

Hi Heiko Thanks for the test. On 2017年07月27日 18:10, Heiko Stübner wrote: Am Donnerstag, 27. Juli 2017, 11:51:06 CEST schrieb Heiko Stübner: Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:25 CEST schrieb Mark Yao: Grouping the vop registers facilitates make register definition clearer, and also

[PATCH v6 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 drivers/gpu/drm/ro

[PATCH v6 5/7] drm/rockchip: vop: add a series of vop support

then old one. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v6 4/7] drm/rockchip: vop: group vop registers

Grouping the vop registers facilitates make register definition clearer, and also is useful for different vop reuse the same group register. Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 99 drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 60

[PATCH v6 5/7] drm/rockchip: vop: add a series of vop support

then old one. Signed-off-by: Mark Yao --- Changes in v3: - fixup some mistake - use separate structures instead VOP_REG_VER mechanism Changes in v2: - rename rk322x to rk3228(Heiko Stübner) - correct some vop registers define drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 9 + drivers/gpu/drm

[PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao <mark@rock-chips.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/g

[PATCH v6 7/7] drm/rockchip: vop: rk3328: fix overlay abnormal

] win_rid_win0_cbr axi read id of win0 cbr channel bit[3:0] win_rid_win0_yrgb axi read id of win0 yrgb channel Signed-off-by: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip/rockchip_vop_reg.c

[PATCH v6 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

In the hardware design process, the design of line flags register is associated with the interrupt register, placing the line flags in the interrupt definition is more reasonable, and it would make multi-vop define easilier. Signed-off-by: Mark Yao <mark@rock-chips.com> Reviewed-by: Sea

[PATCH v6 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: - fix compile error drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 --- drivers/gpu/drm/rockchip/rockchip_drm

[PATCH v6 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

In the hardware design process, the design of line flags register is associated with the interrupt register, placing the line flags in the interrupt definition is more reasonable, and it would make multi-vop define easilier. Signed-off-by: Mark Yao Reviewed-by: Sean Paul --- Changes in v6

[PATCH v6 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

flags to vop registers, then can only do synchronize write for those actual needed register. Signed-off-by: Mark Yao --- Changes in v6: - fix compile error drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 28 --- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm

[PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series

Signed-off-by: Mark Yao <mark@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v5: - clean document commit title - move changes description out of docummit commit msg Changes in v2: - rename rk322x to rk3228 - correct some vop registers define Documentatio

[PATCH v6 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Signed-off-by: Mark Yao <mark@rock-chips.com> --- Changes in v6: - fix rk3036 blank display Changes in v3: - Explain more in details drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.

[PATCH v6 0/7] drm/rockchip: add all full framework vop support

some vop registers define Mark Yao (7): drm/rockchip: vop: initialize registers directly drm/rockchip: vop: move write_relaxed flags to vop register drm/rockchip: vop: move line_flag_num to interrupt registers drm/rockchip: vop: group vop registers drm/rockchip: vop: add a series of vop

[PATCH v6 1/7] drm/rockchip: vop: initialize registers directly

registers directly, and drops init_table mechanism out. Signed-off-by: Mark Yao --- Changes in v6: - fix rk3036 blank display Changes in v3: - Explain more in details drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ++-- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 10 ++- drivers/gpu/drm

[PATCH v6 0/7] drm/rockchip: add all full framework vop support

some vop registers define Mark Yao (7): drm/rockchip: vop: initialize registers directly drm/rockchip: vop: move write_relaxed flags to vop register drm/rockchip: vop: move line_flag_num to interrupt registers drm/rockchip: vop: group vop registers drm/rockchip: vop: add a series of vop

[PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series

Signed-off-by: Mark Yao Acked-by: Rob Herring --- Changes in v5: - clean document commit title - move changes description out of docummit commit msg Changes in v2: - rename rk322x to rk3228 - correct some vop registers define Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt

Re: [PATCH v5 3/7] drm/rockchip: vop: move line_flag_num to interrupt registers

On 2017年07月26日 05:54, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:32 CEST schrieb Mark Yao: In the hardware design process, the design of line flags register is associated with the interrupt register, placing the line flags in the interrupt definition is more reasonable

Re: [PATCH v5 2/7] drm/rockchip: vop: move write_relaxed flags to vop register

On 2017年07月26日 05:47, Heiko Stuebner wrote: Hi Mark, Am Donnerstag, 20. Juli 2017, 10:43:27 CEST schrieb Mark Yao: Since the drm atomic framework, only a small part of the vop register needs sync write, Currently seems only following registers need sync write: cfg_done, standby

  1   2   3   4   5   6   7   8   9   10   >