On Tue, 7 May 2024, zhangwar...@gmail.com wrote:
> From: Wardenjohn
>
> The original macros of KLP_* is about the state of the transition.
> Rename macros of KLP_* to KLP_TRANSITION_* to fix the confusing
> description of klp transition state.
>
> Signed-off-by: Wardenjohn
Hi,
> > Summary of changes in this minimal version
> >
> >
> > - rebase for v6.5
> > - cleaned-up SoB chains (suggested by pmladek)
> > - klp-convert: remove the symbol map auto-resolving solution
> > - klp-convert: add macro for flagging variables inside a LP src to be
Hello,
On Fri, 11 Aug 2023, Miroslav Benes wrote:
> Hi,
>
> On Wed, 14 Jun 2023, Miroslav Benes wrote:
>
> > Hello,
> >
> > the Live Patching Microconference for Linux Plumbers Conference 2023 has
> > been accepted.
> >
> > It is
On Wed, 14 Apr 2021, Josef Bacik wrote:
> On 4/14/21 11:21 AM, xiaojun.zhao...@gmail.com wrote:
> > On Wed, 14 Apr 2021 13:27:43 +0200 (CEST)
> > Miroslav Benes wrote:
> >
> >> Hi,
> >>
> >> On Wed, 14 Apr 2021, xiaojun.zhao...@gmail.com wrote:
Hi,
On Wed, 14 Apr 2021, xiaojun.zhao...@gmail.com wrote:
> I found the qemu-nbd process(started with qemu-nbd -t -c /dev/nbd0
> nbd.qcow2) will automatically exit when I patched for functions of
> the nbd with livepatch.
>
> The nbd relative source:
> static int nbd_start_device_ioctl(struct
Hi,
> > Driver developers will simply have to open code these protections. In
> > light of what I see on LTP / fuzzing, I suspect the use case will grow
> > and we'll have to revisit this in the future. But for now, sure, we can
> > just open code the required protections everywhere to not crash
tely
> rewritten, but it all seems to work nicely.
Reviewed-by: Miroslav Benes
for the objtool changes. All looks much better in this version.
I have only one minor thing. There are only two call sites of
elf_add_string(). The one in elf_create_section() passes shstrtab, the
other one in e
ur bespoke solution with the generic one.
Reviewed-by: Jens Axboe
Reviewed-by: Petr Mladek
Signed-off-by: Miroslav Benes
---
v2:
- #include from kernel/signal.c removed [Petr]
kernel/livepatch/transition.c | 5 ++---
kernel/signal.c | 4 +---
2 files changed, 3 insertions(+), 6
ur bespoke solution with the generic one.
Signed-off-by: Miroslav Benes
---
Tested on x86_64, s390x and ppc64le archs.
kernel/livepatch/transition.c | 5 ++---
kernel/signal.c | 3 +--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/kernel/livepatch/transition.
On Thu, 25 Mar 2021, Jens Axboe wrote:
> On 3/25/21 3:30 AM, Miroslav Benes wrote:
> >> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is
> >> a
> >> silly question, but...
> >>
> >> If the livepatch code could
> (PF_KTHREAD | PF_IO_WORKER) is open coded in soo many places maybe this is a
> silly question, but...
>
> If the livepatch code could use fake_signal_wake_up(), we could consolidate
> the pattern in klp_send_signals() with the one in freeze_task(). Then there
> would only one place for wake up
On Thu, 25 Mar 2021, Dong Kai wrote:
> commit 15b2219facad ("kernel: freezer should treat PF_IO_WORKER like
> PF_KTHREAD for freezing") is to fix the freezeing issue of IO threads
> by making the freezer not send them fake signals.
>
> Here live patching consistency model call klp_send_signals
On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:
> On 10:05 Thu 25 Mar 2021, Miroslav Benes wrote:
> >Hi,
> >
> >On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:
> >
> >>
> >> s/varibles/variables/
> >>
> >> Signed-off-by: Bhaskar Chowdh
Hi,
On Thu, 25 Mar 2021, Bhaskar Chowdhury wrote:
>
> s/varibles/variables/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> Documentation/livepatch/shadow-vars.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/livepatch/shadow-vars.rst
>
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -1045,6 +1045,12 @@ static int add_call_destinations(struct
> } else
> insn->call_dest = reloc->sym;
>
> + if (insn->call_dest && insn->call_dest->static_call_tramp) {
> +
On Wed, 17 Mar 2021, Peter Zijlstra wrote:
> On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote:
>
> > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) {
> > > + WARN("elf_symbol_add");
> > > + return NULL;
> > > + }
[ also correcting my e-mail address ]
On Fri, 12 Mar 2021, Peter Zijlstra wrote:
Just a remark regarding SHN_XINDEX...
> +static bool elf_symbol_add(struct elf *elf, struct symbol *sym, Elf32_Word
> shndx)
> +{
> + struct list_head *entry;
> + struct rb_node *pnode;
> +
> +
Hi Masami,
> --- a/include/linux/kprobes.h
> +++ b/include/linux/kprobes.h
> @@ -205,15 +205,23 @@ extern void arch_prepare_kretprobe(struct
> kretprobe_instance *ri,
> struct pt_regs *regs);
> extern int arch_trampoline_kprobe(struct kprobe *p);
>
> +void
Hi,
I cannot really comment on mips arch specifics but few words from the live
patching perspective.
On Mon, 1 Mar 2021, Jinyang He wrote:
> Add the basic code of livepatch. livepatch is temporarily unavailable.
> Two core functions are missing, one is DYNAMIC_FTRACE_WITH_REGS, and
> another
y missing ORC data
>
> arch/x86/kernel/unwind_orc.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
I apologize for a really late reply. It seems it has not been merged yet,
so
Reviewed-by: Miroslav Benes
M
67cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Dan Carpenter
Reviewed-by: Miroslav Benes
M
.
>
> - rebased to tip/objtool/core
I haven't tested it, but it all looks good to me.
Reviewed-by: Miroslav Benes
M
On Tue, 9 Feb 2021, Steven Rostedt wrote:
> On Tue, 9 Feb 2021 09:32:34 +0100 (CET)
> Miroslav Benes wrote:
>
> > powerpc has this
> >
> > static inline unsigned long klp_get_ftrace_l
On Mon, 8 Feb 2021, Steven Rostedt wrote:
> On Mon, 8 Feb 2021 16:47:05 +0100
> Peter Zijlstra wrote:
>
> > > /*
> > > * Convert a function address into the appropriate ftrace location.
> > > *
> > > * Usually this is just the address of the function, but on some
> > > architectures
> > >
mbol_args to find_symbol
>
> Simplify the calling convention by passing the find_symbol_args structure
> to find_symbol instead of initializing it inside the function.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> each_symbol_in_section just contains a trivial loop over its arguments.
> Just open code the loop in the two callers.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> each_symbol_section is only called by find_symbol, so merge the two
> functions.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
> void *__symbol_get(const char *symbol)
> {
> - struct module *owner;
> - const struct kernel_symbol *sym;
> + struct find_symbol_arg fsa = {
> + .name = symbol,
> + .gplok = true,
> + .warn = true,
> + };
>
> preempt_disable();
>
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> EXPORT_UNUSED_SYMBOL* is not actually used anywhere. Remove the
> unused functionality as we generally just remove unused code anyway.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> As far as I can tell this has never been used at all, and certainly
> not any time recently.
Right, I've always wondered about this one.
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> struct symsearch is only used inside of module.h, so move the definition
> out of module.h.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Tue, 2 Feb 2021, Christoph Hellwig wrote:
> kallsyms_on_each_symbol and module_kallsyms_on_each_symbol are only used
> by the livepatching code, so don't build them if livepatching is not
> enabled.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Miroslav Benes
M
On Mon, 1 Feb 2021, Christoph Hellwig wrote:
> On Mon, Feb 01, 2021 at 02:37:12PM +0100, Miroslav Benes wrote:
> > > > This change is not needed. (objname == NULL) means that we are
> > > > interested only in symbols in "vmlinux".
> > > >
> &g
One more thing...
> @@ -4379,8 +4379,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *,
> const char *,
> unsigned int i;
> int ret;
>
> - module_assert_mutex();
> -
> + mutex_lock(_mutex);
> list_for_each_entry(mod, , list) {
> /* We hold
On Mon, 1 Feb 2021, Christoph Hellwig wrote:
> On Fri, Jan 29, 2021 at 10:43:36AM +0100, Petr Mladek wrote:
> > > --- a/kernel/livepatch/core.c
> > > +++ b/kernel/livepatch/core.c
> > > @@ -164,12 +164,8 @@ static int klp_find_object_symbol(const char
> > > *objname, const char *name,
> > >
On Mon, 1 Feb 2021, Jessica Yu wrote:
> +++ Miroslav Benes [29/01/21 16:29 +0100]:
> >On Thu, 28 Jan 2021, Christoph Hellwig wrote:
> >
> >> Allow for a RCU-sched critical section around find_module, following
> >> the lower level find_module_all helper, and sw
mas Gleixner
> Cc: Ingo Molnar
> Cc: Borislav Petkov
> Cc: "H. Peter Anvin"
> Cc: Heiko Carstens
> Cc: Vasily Gorbik
> Cc: Christian Borntraeger
> Cc: Josh Poimboeuf
> Cc: Jiri Kosina
> Cc: Miroslav Benes
> Cc: Petr Mladek
> Cc: Joe Lawrence
>
trace.rst | 309 ++
> 4 files changed, 313 insertions(+), 22 deletions(-)
> create mode 100644 Documentation/livepatch/reliable-stacktrace.rst
sorry for the late reply (slowly crawling through my email backlog).
Thanks a lot for putting this together!
FWIW (so it is at least archived in the thread)
Acked-by: Miroslav Benes
M
ooking for objtool warnings than
> ever before, so such warnings not likely to be ignored for long.
>
> Suggested-by: Nick Desaulniers
> Signed-off-by: Josh Poimboeuf
Reviewed-by: Miroslav Benes
M
t; Signed-off-by: Josh Poimboeuf
Reviewed-by: Miroslav Benes
with the note below.
> ---
> tools/objtool/elf.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
> index be89c741ba9a..2b0f4f52f7b5 1
> That comment is indeed now obsolete. I can squash something like so:
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 81d56fdef1c3..ce67437aaf3f 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -958,21 +958,8 @@ static int
On Tue, 22 Dec 2020, Josh Poimboeuf wrote:
> BTW, another benefit of these changes is that, thanks to some related
> cleanups (new fake nops and alt_group struct) objtool can finally be rid
> of fake jumps, which were a constant source of headaches.
\o/
You may also want to remove/edit the
wed-by: Nick Desaulniers
> Link: https://github.com/ClangBuiltLinux/linux/issues/1207
> Signed-off-by: Josh Poimboeuf
Reviewed-by: Miroslav Benes
M
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index e00fe88146e0..7c9474d52060 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -54,6 +54,9 @@ arch_ftrace_get_regs(struct ftrace_regs *fregs)
> return NULL;
>
he old unpatched function will be called
> placing the system into an unknown state.
>
> Link: https://lore.kernel.org/r/20201029145709.GD16774@alley
>
> Cc: Josh Poimboeuf
> Cc: Jiri Kosina
> Cc: Joe Lawrence
> Cc: live-patch...@vger.kernel.org
> Suggested-by: Miroslav Benes
28115613.291169...@goodmis.org
>
> Cc: Masami Hiramatsu
> Cc: Andrew Morton
> Cc: Josh Poimboeuf
> Cc: Jiri Kosina
> Cc: Miroslav Benes
> Cc: Joe Lawrence
> Cc: live-patch...@vger.kernel.org
> Reviewed-by: Petr Mladek
> Signed-off-by: Steven Rostedt (VMware)
Acked-by: Miroslav Benes
M
ule: avoid *goto*s in module_sig_check()
> [3/3] module: only handle errors with the *switch* statement in
> module_sig_check()
Reviewed-by: Miroslav Benes
M
ed my tests too and the patch looks good to me, so
Acked-by: Miroslav Benes
M
> Signed-off-by: Steven Rostedt (VMware)
> ---
> arch/powerpc/include/asm/livepatch.h | 4 +++-
> arch/s390/include/asm/livepatch.h| 5 -
> arch/x86/include/asm/ftrace.h| 3 +++
> arch/x
> > > > + bit = ftrace_test_recursion_trylock();
> > > > + if (bit < 0)
> > > > + return;
> > >
> > > This means that the original function will be called in case of
> > > recursion.
> > > That's probably fair, but I'm wondering if we should at least WARN about
> >
Hi,
> +static __always_inline int trace_get_context_bit(void)
> +{
> + int bit;
> +
> + if (in_interrupt()) {
> + if (in_nmi())
> + bit = 0;
> +
> + else if (in_irq())
> + bit = 1;
> + else
> +
On Thu, 29 Oct 2020, Petr Mladek wrote:
> On Thu 2020-10-29 14:51:06, Miroslav Benes wrote:
> > On Wed, 28 Oct 2020, Steven Rostedt wrote:
>
> > Hm, I've always thought that we did not need any kind of recursion
> > protection for our callback. It is marked as notr
he patch set
correctly.
> Cc: Josh Poimboeuf
> Cc: Jiri Kosina
> Cc: Miroslav Benes
> Cc: Petr Mladek
> Cc: Joe Lawrence
> Cc: live-patch...@vger.kernel.org
> Signed-off-by: Steven Rostedt (VMware)
> ---
> kernel/livepatch/patch.c | 5 +
> 1 file changed,
On Wed, 28 Oct 2020, Jessica Yu wrote:
> +++ Miroslav Benes [27/10/20 15:03 +0100]:
> >If a module fails to load due to an error in prepare_coming_module(),
> >the following error handling in load_module() runs with
> >MODULE_STATE_COMING in module's state. Fix it
Hi,
On Fri, 23 Oct 2020, Mark Rutland wrote:
> Add documentation for reliable stacktrace. This is intended to describe
> the semantics and to be an aid for implementing architecture support for
> HAVE_RELIABLE_STACKTRACE.
thanks a lot for doing the work!
> Unwinding is a subtle area, and
If a module fails to load due to an error in prepare_coming_module(),
the following error handling in load_module() runs with
MODULE_STATE_COMING in module's state. Fix it by correctly setting
MODULE_STATE_GOING under "bug_cleanup" label.
Signed-off-by: Miroslav Benes
---
kernel/mo
On Sat, 10 Oct 2020, Jens Axboe wrote:
> On 10/9/20 9:21 AM, Jens Axboe wrote:
> > On 10/9/20 2:01 AM, Miroslav Benes wrote:
> >> On Thu, 8 Oct 2020, Oleg Nesterov wrote:
> >>
> >>> On 10/05, Jens Axboe wrote:
> >>>>
> >>>> Hi,
On Thu, 8 Oct 2020, Oleg Nesterov wrote:
> On 10/05, Jens Axboe wrote:
> >
> > Hi,
> >
> > The goal is this patch series is to decouple TWA_SIGNAL based task_work
> > from real signals and signal delivery.
>
> I think TIF_NOTIFY_SIGNAL can have more users. Say, we can move
> try_to_freeze() from
On Fri, 2 Oct 2020, Josh Poimboeuf wrote:
> On Thu, Oct 01, 2020 at 03:36:12PM +0200, Peter Zijlstra wrote:
> > On Thu, Oct 01, 2020 at 03:17:07PM +0200, Miroslav Benes wrote:
> >
> > > I also wonder about making 'mcount' command separate from 'check'.
> > > Si
Hi Sami,
On Tue, 29 Sep 2020, Sami Tolvanen wrote:
> From: Peter Zijlstra
>
> Add the --mcount option for generating __mcount_loc sections
> needed for dynamic ftrace. Using this pass requires the kernel to
> be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined
> in Makefile.
>
>
Hi Kristen,
On Wed, 23 Sep 2020, Kristen Carlson Accardi wrote:
> Function Granular Kernel Address Space Layout Randomization (fgkaslr)
> -
>
> This patch set is an implementation of finer grained kernel address space
>
Hi,
On Wed, 23 Sep 2020, Kristen Carlson Accardi wrote:
> If any type of function granular randomization is enabled, the sympos
> algorithm will fail, as it will be impossible to resolve symbols when
> there are duplicates using the previous symbol position.
>
> Override the value of sympos to
4: stacktrace: Make stack walk callback consistent with generic
> code
> arm64: stacktrace: Convert to ARCH_STACKWALK
The patches look good to me.
Reviewed-by: Miroslav Benes
M
] https://lkml.org/lkml/2020/7/30/424
Hi,
Josh merged the patch set already, but FWIW
Reviewed-by: Miroslav Benes
for the new changes (patches 7, 9 and 10).
Miroslav
On Thu, 3 Sep 2020, Josh Poimboeuf wrote:
> On Wed, Aug 12, 2020 at 10:57:11AM -0700, Kristen Carlson Accardi wrote:
>
> > if (GELF_ST_TYPE(sym.st_info) == STT_SECTION) {
> > - scn = elf_getscn(elf, sym.st_shndx);
> > + if
On Wed, 12 Aug 2020, Kristen Carlson Accardi wrote:
> When getting the symbol index number, make sure to use the
> extended symbol table information in order to support symbol
> index's greater than 64K.
>
> Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Miroslav Benes
M
Hi,
first, I'm sorry for the late reply. Thanks, Josh, for the reminder.
CCing Nicolai. Nicolai, could you take a look at the proposed
documentation too, please? You have more up-to-date experience.
On Tue, 21 Jul 2020, Joe Lawrence wrote:
> +Examples
> +
> +
> +Interprocedural
[side note: So not only that my INBOX is a mess after the summer. I also
lost some emails apparently. I'm really sorry about that. ]
CCing Nicolai too.
> Hi Petr, Josh,
>
> The compiler optimization pitfall document can wait for refactored livepatch
> documentation if that puts it into better
ed-by: Josh Poimboeuf
> Signed-off-by: Joe Lawrence
Acked-by: Miroslav Benes
M
Hi,
it could be a silly question, but better to ask...
> + if (regs)
> + start_backtrace(, regs->regs[29], regs->pc);
> + else
> + start_backtrace(, thread_saved_fp(task),
> + thread_saved_pc(task));
Would this also work for task ==
ion when arm64 is converted to use
> arch_stack_walk() change the signature of the arm64 specific callback to
> match that of the generic code.
>
> Signed-off-by: Mark Brown
Reviewed-by: Miroslav Benes
M
; Signed-off-by: Mark Brown
Reviewed-by: Miroslav Benes
M
I used Masami's address which did not work. Sorry about that. Should be ok
now.
On Mon, 31 Aug 2020, Miroslav Benes wrote:
> Commit fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
> missed to remove ops from new ftrace_ops_trampoline_list in
ine itself is not freed in this case.
Fix it by calling ftrace_trampoline_free() during the rollback.
Fixes: fc0ea795f53c ("ftrace: Add symbols for ftrace trampolines")
Signed-off-by: Miroslav Benes
---
It would be fair to add
Fixes: f8b8be8a310a ("ftrace, kprobes: Support IPMODI
Leaving Josh's proposals here for reference...
> > I'm not sure how LTO does it, but a few more (half-brained) ideas
> > that
> > could work:
> >
> > 1) Add a field in kallsyms to keep track of a symbol's original
> > offset
> >before randomization/re-sorting. Livepatch could use that field
hes with no orc implementation to provide dummy
> orc definitions.
>
> Signed-off-by: Julien Thierry
This is definitely simpler than what v3 had.
Reviewed-by: Miroslav Benes
M
On Tue, 25 Aug 2020, Julien Thierry wrote:
> Now that the objtool_file can be obtained outside of the check function,
> orc generation builtin no longer requires check to explicitly call its
> orc related functions.
>
> Signed-off-by: Julien Thierry
Reviewed-by: Miroslav Benes
M
Normal state
[ 86.844422] livepatch: 'test_klp_callbacks_demo': starting unpatching
transition
, "comm" fails with "comm: file 2 is not in sorted order". Suppress the
order checking with --nocheck-order option.
Signed-off-by: Miroslav Benes
---
The strange thing is, I can reprod
Hi,
during v5.9-rc1 testing I ran into an issue (BUG dump at the end of the
email). I suspected commit fc0ea795f53c ("ftrace: Add symbols for ftrace
trampolines") (which git bisect later confirmed) and a missing call to
ftrace_remove_trampoline_from_kallsyms() somewhere. And indeed there is an
> Changes since v1 [4]:
> - Rebased on recent tip/objtool/core
> - Split the unwind hint rework into multiple patches as suggested by
> Miroslav
For remaining patches 7-9
Reviewed-by: Miroslav Benes
M
On Thu, 30 Jul 2020, Julien Thierry wrote:
>
>
> On 7/30/20 3:15 PM, Josh Poimboeuf wrote:
> > On Thu, Jul 30, 2020 at 02:29:20PM +0100, Julien Thierry wrote:
> >>
> >>
> >> On 7/30/20 2:22 PM, pet...@infradead.org wrote:
> >>> On Thu, Jul 30, 2020 at 01:40:42PM +0100, Julien Thierry wrote:
>
Let me CC live-patching ML, because from a quick glance this is something
which could impact live patching code. At least it invalidates assumptions
which "sympos" is based on.
Miroslav
On Fri, 17 Jul 2020, Kristen Carlson Accardi wrote:
> Function Granular Kernel Address Space Layout
On Sun, 19 Jul 2020, Joe Lawrence wrote:
> On 7/17/20 2:29 PM, Josh Poimboeuf wrote:
> > Use of the new -flive-patching flag was introduced with the following
> > commit:
> >
> >43bd3a95c98e ("kbuild: use -flive-patching when CONFIG_LIVEPATCH is
> >enabled")
> >
> > This flag has
;
> This reverts commit 43bd3a95c98e1a86b8b55d97f745c224ecff02b9.
>
> Fixes: 43bd3a95c98e ("kbuild: use -flive-patching when CONFIG_LIVEPATCH is
> enabled")
> Reported-by: Randy Dunlap
> Signed-off-by: Josh Poimboeuf
Acked-by: Miroslav Benes
M
On Thu, 16 Jul 2020, Mark Brown wrote:
> On Thu, Jul 16, 2020 at 01:56:13PM +0200, Miroslav Benes wrote:
> > On Wed, 15 Jul 2020, Mark Brown wrote:
>
> > > -void save_stack_trace(struct stack_trace *trace)
> > > -{
> > > - __save_stack_trace(current,
On Wed, 15 Jul 2020, Mark Brown wrote:
> Currently the callback passed to arch_stack_walk() has an argument called
> reliable passed to it to indicate if the stack entry is reliable, a comment
> says that this is used by some printk() consumers. However in the current
> kernel none of the
Hi,
On Wed, 15 Jul 2020, Mark Brown wrote:
> Historically architectures have had duplicated code in their stack trace
> implementations for filtering what gets traced. In order to avoid this
> duplication some generic code has been provided using a new interface
> arch_stack_walk(), enabled by
On Wed, 15 Jul 2020, Josh Poimboeuf wrote:
> On Wed, Jul 15, 2020 at 03:41:55PM +0200, Petr Mladek wrote:
> > On Wed 2020-07-15 14:10:54, Petr Mladek wrote:
> > > On Wed 2020-07-15 13:11:14, Miroslav Benes wrote:
> > > > Petr, would you agree to revert -flive-patch
On Tue, 14 Jul 2020, Josh Poimboeuf wrote:
> On Tue, Jul 14, 2020 at 12:56:21PM +0200, Miroslav Benes wrote:
> > On Thu, 2 Jul 2020, Josh Poimboeuf wrote:
> >
> > > On Tue, Jun 23, 2020 at 08:06:07AM -0700, Randy Dunlap wrote:
> > > > On 6/22/20 11:28 PM, Step
sions using '-q' option.
>
> Explicitly print the final status on success so that it can be verified
> in the log. The error message is enough on failure.
>
> Reported-by: Kamalesh Babulal
> Signed-off-by: Petr Mladek
Acked-by: Miroslav Benes
M
On Thu, 2 Jul 2020, Josh Poimboeuf wrote:
> On Tue, Jun 23, 2020 at 08:06:07AM -0700, Randy Dunlap wrote:
> > On 6/22/20 11:28 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Changes since 20200622:
> > >
> >
> > on x86_64:
> >
> > arch/x86/kernel/cpu/mce/core.o: warning: objtool:
On Thu, 18 Jun 2020, Matt Helsley wrote:
> Rather than a standalone executable merge recordmcount as a sub command
> of objtool. This is a small step towards cleaning up recordmcount and
> eventually sharing ELF code with objtool.
>
> For the initial step all that's required is a bit of
Hi,
this is a nice improvement.
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index 7770edcda3a0..aa0c6d3d2d46 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile
> @@ -1,6 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> include ../scripts/Makefile.include
>
Hi,
On Fri, 12 Jun 2020, Tobias Klauser wrote:
> Avoid a memory leak in case get_alt_entry returns an error.
yes, this is not the only one, but I doubt we want to spend time on that.
The process is about to exit anyway.
Miroslav
> Signed-off-by: Tobias Klauser
> ---
>
5 add abstraction to handle alternatives
> - Patch 6 adds abstraction to handle jump table
> - Patch 7 abstracts the use of unwind hints. Adding it as RFC as I'm sure
> there's room for improvement.
Reviewed-by: Miroslav Benes
for patches 1-6.
M
Hi Julien,
On Mon, 8 Jun 2020, Julien Thierry wrote:
> Unwind hints are useful to give some information about the call frame
> or stack states in non-standard code.
>
> Despite unwind hints being used in arch-independent code, the
> unwind_hint structure type itself is define in x86 kernel
4.html
> [2] https://lkml.org/lkml/2020/6/4/675
Reviewed-by: Miroslav Benes
M
gt; Signed-off-by: Joe Lawrence
Acked-by: Miroslav Benes
M
Hi,
a nit below...
On Thu, 4 Jun 2020, Julien Thierry wrote:
> One orc_entry is associated with each instruction in the object file,
> but having the orc_entry contained by the instruction structure forces
> architectures not implementing the orc subcommands to provide a dummy
> definition of
Hi,
On Thu, 4 Jun 2020, Max Filippov wrote:
> On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
> build fails with the following message:
>
> kernel/module.c:3593:2: error: implicit declaration of function
> ‘module_enable_ro’;
>
> Add empty module_enable_ro
1 - 100 of 1260 matches
Mail list logo
