Re: [PATCH net-next v3 6/8] net: phy: mscc: timestamping and PHC support

2020-06-21 Thread Quentin Schulz
Hi Antoine, On 2020-06-19 14:22, Antoine Tenart wrote: [...] @@ -999,9 +1553,35 @@ int vsc8584_ptp_probe(struct phy_device *phydev) if (!vsc8531->ptp) return -ENOMEM; + mutex_init(>phc_lock); mutex_init(>ts_lock); + /* Retrieve the shared load/save

Re: [PATCH net-next v3 5/8] net: phy: mscc: 1588 block initialization

2020-06-21 Thread Quentin Schulz
Hi Antoine, Feels weird to review my own patches a year later having written them, almost nostalgic :) The review is mostly nitpicks. On 2020-06-19 14:22, Antoine Tenart wrote: [...] @@ -373,6 +374,21 @@ struct vsc8531_private { unsigned long ingr_flows; unsigned long

Re: [PATCH net-next v3 4/8] net: phy: mscc: take into account the 1588 block in MACsec init

2020-06-21 Thread Quentin Schulz
Hi Antoine, On 2020-06-19 14:22, Antoine Tenart wrote: This patch takes in account the use of the 1588 block in the MACsec initialization, as a conditional configuration has to be done (when the 1588 block is used). Signed-off-by: Antoine Tenart --- drivers/net/phy/mscc/mscc_macsec.c | 4

Re: [GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-14 Thread Quentin Schulz
Hi Josh, On Fri, Dec 14, 2018 at 07:57:37AM -0500, Josh Boyer wrote: > On Thu, Dec 6, 2018 at 5:34 AM Quentin Schulz > wrote: > > > > Hi all, > > > > Both VSC8574 and VSC8584 Ethernet PHYs require a firmware patch to be > > applied before making use of

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-10 Thread Quentin Schulz
Hi Lee, On Mon, Dec 10, 2018 at 06:27:18AM +, Lee Jones wrote: > On Sat, 08 Dec 2018, Quentin Schulz wrote: > > > Hi Lee, > > > > On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > > > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > >

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-08 Thread Quentin Schulz
Hi Lee, On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > > On Fri, Dec 7, 2018 at 8:40 AM Lee Jones wrote: > > > > > My OCD-dar is going crazy. > > > > > > Why haven't you used the same alignment as is already there? > > > > > > If

Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803

2018-12-08 Thread Quentin Schulz
Hi Lee, On Fri, Dec 07, 2018 at 07:22:37PM +, Lee Jones wrote: > On Fri, 07 Dec 2018, Vasily Khoruzhick wrote: > > > On Fri, Dec 7, 2018 at 8:40 AM Lee Jones wrote: > > > > > My OCD-dar is going crazy. > > > > > > Why haven't you used the same alignment as is already there? > > > > > > If

[GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-06 Thread Quentin Schulz
(2018-12-06 11:02:51 +0100) Quentin Schulz (1): microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs LICENCE.microchip| 40 WHENCE

[GIT PULL firmware] microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs

2018-12-06 Thread Quentin Schulz
(2018-12-06 11:02:51 +0100) Quentin Schulz (1): microchip: add firmware for VSC8574 and VSC8584 Ethernet PHYs LICENCE.microchip| 40 WHENCE

Re: [PATCH v6 4/6] power: supply: core: Add some helpers to use the battery OCV capacity table

2018-11-01 Thread Quentin Schulz
Hi Baolin, On Thu, Nov 01, 2018 at 03:22:18PM +0800, Baolin Wang wrote: > Hi Quentin, > > On 29 October 2018 at 22:48, Quentin Schulz > wrote: [...] > > > >> + return len; > >> + } else if (len > POWER_SUPPLY_OCV_TEMP_MAX) { >

Re: [PATCH v6 4/6] power: supply: core: Add some helpers to use the battery OCV capacity table

2018-11-01 Thread Quentin Schulz
Hi Baolin, On Thu, Nov 01, 2018 at 03:22:18PM +0800, Baolin Wang wrote: > Hi Quentin, > > On 29 October 2018 at 22:48, Quentin Schulz > wrote: [...] > > > >> + return len; > >> + } else if (len > POWER_SUPPLY_OCV_TEMP_MAX) { >

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-29 Thread Quentin Schulz
Hi Jonathan, On Sun, Oct 28, 2018 at 03:40:11PM +, Jonathan Cameron wrote: > On Wed, 24 Oct 2018 08:56:33 -0500 > Rob Herring wrote: > > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > > The AXP803 ADC is compatible with AXP813 ADC, but add > > > specific compatible for it.

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-29 Thread Quentin Schulz
Hi Jonathan, On Sun, Oct 28, 2018 at 03:40:11PM +, Jonathan Cameron wrote: > On Wed, 24 Oct 2018 08:56:33 -0500 > Rob Herring wrote: > > > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > > The AXP803 ADC is compatible with AXP813 ADC, but add > > > specific compatible for it.

Re: [PATCH v3 6/7] mfd: axp20x: Add AC power supply cell for AXP813

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:07PM +0300, Oskari Lemmela wrote: > As axp20x-ac-power-supply now supports AXP813, add a cell for it. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 6/7] mfd: axp20x: Add AC power supply cell for AXP813

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:07PM +0300, Oskari Lemmela wrote: > As axp20x-ac-power-supply now supports AXP813, add a cell for it. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 4/7] arm64: dts: allwinner: a64: sopine: enable power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:05PM +0300, Oskari Lemmela wrote: > Sopine baseboard have ACIN and battery connectors. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 4/7] arm64: dts: allwinner: a64: sopine: enable power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:05PM +0300, Oskari Lemmela wrote: > Sopine baseboard have ACIN and battery connectors. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 3/7] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:04PM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 3/7] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:04PM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:02PM +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:02PM +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 2/7] ARM: dts: axp81x: add AC power supply subnode

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:03PM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH v3 2/7] ARM: dts: axp81x: add AC power supply subnode

2018-10-12 Thread Quentin Schulz
Hi Oskari, On Mon, Oct 08, 2018 at 09:19:03PM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
c: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
c: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-10 Thread Quentin Schulz
lect/restore_page > functions") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next 1/2] net: phy: mscc: fix signedness bug in vsc85xx_downshift_get

2018-10-10 Thread Quentin Schulz
lect/restore_page > functions") Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
Hi Gustavo, On Tue, Oct 09, 2018 at 09:39:53PM +0200, Gustavo A. R. Silva wrote: > In case memory resources for *fw* were successfully allocated, > release them before return. > > Addresses-Coverity-ID: 1473968 ("Resource leak") > Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574

Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init

2018-10-10 Thread Quentin Schulz
Hi Gustavo, On Tue, Oct 09, 2018 at 09:39:53PM +0200, Gustavo A. R. Silva wrote: > In case memory resources for *fw* were successfully allocated, > release them before return. > > Addresses-Coverity-ID: 1473968 ("Resource leak") > Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Quentin Schulz
Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: > Hi, > > On 27.09.2018 10:14, Maxime Ripard wrote: > > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > > > On 26-09-18 16:44, Frieder Schrempf wrote: > > > > Hi, > > > > > > > > On Fri, Feb 09, 2018

Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

2018-10-09 Thread Quentin Schulz
Hi Frieder, On Mon, Oct 08, 2018 at 11:53:21AM +0200, Frieder Schrempf wrote: > Hi, > > On 27.09.2018 10:14, Maxime Ripard wrote: > > On Wed, Sep 26, 2018 at 10:19:22PM +0200, Hans de Goede wrote: > > > On 26-09-18 16:44, Frieder Schrempf wrote: > > > > Hi, > > > > > > > > On Fri, Feb 09, 2018

Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug

2018-10-09 Thread Quentin Schulz
size of SERDES_MAX > in the for loop. > > Quentin Schulz pointed out that SERDES_MAX is a valid value to > index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1 > in include/dt-bindings/phy/phy-ocelot-serdes.h. > > Then I changed the condition in the for loo

Re: [PATCH 0/2] phy: ocelot-serdes: fix out-of-bounds bug

2018-10-09 Thread Quentin Schulz
size of SERDES_MAX > in the for loop. > > Quentin Schulz pointed out that SERDES_MAX is a valid value to > index ctrl->phys. So, I updated SERDES_MAX to be SERDES6G_MAX + 1 > in include/dt-bindings/phy/phy-ocelot-serdes.h. > > Then I changed the condition in the for loo

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-10-09 Thread Quentin Schulz
for loop from > i <= SERDES_MAX to i < SERDES_MAX. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

2018-10-09 Thread Quentin Schulz
for loop from > i <= SERDES_MAX to i < SERDES_MAX. > Reviewed-by: Quentin Schulz Thanks, Quentin signature.asc Description: PGP signature

Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1

2018-10-09 Thread Quentin Schulz
, because the size of > array ctrl->phys is SERDES_MAX. > > Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1. > > Notice that this is the first part of the solution to > the out-of-bounds bug mentioned above. Although this > change is not dependent on any

Re: [PATCH 1/2] dt-bindings: phy: Update SERDES_MAX to be SERDES_MAX + 1

2018-10-09 Thread Quentin Schulz
, because the size of > array ctrl->phys is SERDES_MAX. > > Partially fix this by updating SERDES_MAX to be SERDES6G_MAX + 1. > > Notice that this is the first part of the solution to > the out-of-bounds bug mentioned above. Although this > change is not dependent on any

Re: [PATCH] phy: ocelot-serdes: fix out-of-bounds read

2018-10-08 Thread Quentin Schulz
Hi Gustavo, On Mon, Oct 08, 2018 at 08:06:49PM +0200, Gustavo A. R. Silva wrote: > Currently, there is an out-of-bounds read on array ctrl->phys, > once variable i reaches the maximum array size of SERDES_MAX > in the for loop. > > Fix this by changing the condition in the for loop from > i <=

Re: [PATCH] phy: ocelot-serdes: fix out-of-bounds read

2018-10-08 Thread Quentin Schulz
Hi Gustavo, On Mon, Oct 08, 2018 at 08:06:49PM +0200, Gustavo A. R. Silva wrote: > Currently, there is an out-of-bounds read on array ctrl->phys, > once variable i reaches the maximum array size of SERDES_MAX > in the for loop. > > Fix this by changing the condition in the for loop from > i <=

[PATCH net-next v3 3/6] net: phy: mscc: Add EEE init sequence

2018-10-08 Thread Quentin Schulz
to EEE in order to improve performance. Reviewed-by: Florian Fainelli Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy

[PATCH net-next v3 2/6] net: phy: mscc: add ethtool statistics counters

2018-10-08 Thread Quentin Schulz
-by: Andrew Lunn Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 119 + 1 file changed, 119 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 52198be46c68..47fbab489287 100644

[PATCH net-next v3 3/6] net: phy: mscc: Add EEE init sequence

2018-10-08 Thread Quentin Schulz
to EEE in order to improve performance. Reviewed-by: Florian Fainelli Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 65 ++ 1 file changed, 65 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy

[PATCH net-next v3 2/6] net: phy: mscc: add ethtool statistics counters

2018-10-08 Thread Quentin Schulz
-by: Andrew Lunn Signed-off-by: Raju Lakkaraju Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 119 + 1 file changed, 119 insertions(+) diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index 52198be46c68..47fbab489287 100644

Re: [PATCH v2 6/6] power: supply: add AC power supply driver for AXP813

2018-10-08 Thread Quentin Schulz
r_supply_property psp, > + const union power_supply_propval *val) > +{ Argh, missed this one in the first version. Since you're introducing it with the AXP813 and it isn't used with the AXP20X, I'd name it axp813_ac_power_set_property. I'll let Maxime or Chen-Yu confirm though. With the modification in the header from the previous patch in this patch, Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH v2 6/6] power: supply: add AC power supply driver for AXP813

2018-10-08 Thread Quentin Schulz
r_supply_property psp, > + const union power_supply_propval *val) > +{ Argh, missed this one in the first version. Since you're introducing it with the AXP813 and it isn't used with the AXP20X, I'd name it axp813_ac_power_set_property. I'll let Maxime or Chen-Yu confirm though. With the modification in the header from the previous patch in this patch, Reviewed-by: Quentin Schulz Thanks! Quentin signature.asc Description: PGP signature

Re: [PATCH v2 5/6] mfd: axp20x: add support AXP803 AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:35AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. > Adding needed cells for AC and battery power supplies. > > AXP813 AC power supply cell added. > > Signed-off-by: Oskari Lemmela > --- > drivers/mfd/axp20x.c | 22

Re: [PATCH v2 5/6] mfd: axp20x: add support AXP803 AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:35AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. > Adding needed cells for AC and battery power supplies. > > AXP813 AC power supply cell added. > > Signed-off-by: Oskari Lemmela > --- > drivers/mfd/axp20x.c | 22

Re: [PATCH v2 3/6] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:33AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > > Signed-off-by: Oskari Lemmela > --- > arch/arm64/boot/dts/allwinner/axp803.dtsi | 31 +++ > 1 file

Re: [PATCH v2 3/6] arm64: dts: allwinner: axp803: add AC and battery power supplies

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:33AM +0300, Oskari Lemmela wrote: > AXP803 is compatible with AXP813. Add DT nodes ADC, GPIO, > AC and battery power supplies. > > Signed-off-by: Oskari Lemmela > --- > arch/arm64/boot/dts/allwinner/axp803.dtsi | 31 +++ > 1 file

Re: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > > Signed-off-by: Oskari Lemmela > --- > arch/arm/boot/dts/axp81x.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi

Re: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote: > Add AC power supply subnode for AXP81X PMIC. > > Signed-off-by: Oskari Lemmela > --- > arch/arm/boot/dts/axp81x.dtsi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/axp81x.dtsi

Re: [PATCH v2 0/6] AXP8x3 AC and battery power supply support

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:30AM +0300, Oskari Lemmela wrote: > AXP813 AC power supply support with input current and > voltage limiting support. > > AXP803 AC and battery power supply support. > Great to see a new developer taking interest in those PMICs :) I received the v2

Re: [PATCH v2 0/6] AXP8x3 AC and battery power supply support

2018-10-08 Thread Quentin Schulz
Hi Oskari, On Sun, Oct 07, 2018 at 12:18:30AM +0300, Oskari Lemmela wrote: > AXP813 AC power supply support with input current and > voltage limiting support. > > AXP803 AC and battery power supply support. > Great to see a new developer taking interest in those PMICs :) I received the v2

Re: [PATCH 4/4] power: supply: add AXP803/AXP813 AC and battery power supply support

2018-10-05 Thread Quentin Schulz
Hi Oskari, On Thu, Oct 04, 2018 at 10:34:10PM +0300, Oskari Lemmela wrote: > AXP803 PMIC is register compatible with AXP813. > > Added support for AXP803/AXP813 AC power supply. > AXP8x3 is capable to limit input current and minimum input voltage. > Both of these register values are writeable. >

Re: [PATCH 4/4] power: supply: add AXP803/AXP813 AC and battery power supply support

2018-10-05 Thread Quentin Schulz
Hi Oskari, On Thu, Oct 04, 2018 at 10:34:10PM +0300, Oskari Lemmela wrote: > AXP803 PMIC is register compatible with AXP813. > > Added support for AXP803/AXP813 AC power supply. > AXP8x3 is capable to limit input current and minimum input voltage. > Both of these register values are writeable. >

Re: [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote: > > > struct vsc8531_private { > > int rate_magic; > > u16 supp_led_modes; > > @@ -181,6 +354,7 @@ struct vsc8531_private { > > struct vsc85xx_hw_stat *hw_stats; > > u64 *stats; > > int nstats; > > +

Re: [PATCH net-next 2/7] net: phy: mscc: add support for VSC8584 PHY

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:27:54PM +0200, Andrew Lunn wrote: > > > struct vsc8531_private { > > int rate_magic; > > u16 supp_led_modes; > > @@ -181,6 +354,7 @@ struct vsc8531_private { > > struct vsc85xx_hw_stat *hw_stats; > > u64 *stats; > > int nstats; > > +

Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:02:21PM +0200, Andrew Lunn wrote: > On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > >

Re: [PATCH 5/7] MIPS: mscc: ocelot: add GPIO4 pinmuxing DT node

2018-10-01 Thread Quentin Schulz
Hi Andrew, On Fri, Sep 14, 2018 at 07:02:21PM +0200, Andrew Lunn wrote: > On Fri, Sep 14, 2018 at 06:26:38PM +0200, Quentin Schulz wrote: > > Hi Alexandre, > > > > On Fri, Sep 14, 2018 at 04:54:46PM +0200, Alexandre Belloni wrote: > > > Hi, > > > >

[PATCH net-next 4/5] net: phy: mscc: shorten `x != 0` condition to `x`

2018-09-14 Thread Quentin Schulz
`if (x != 0)` is basically a more verbose version of `if (x)` so let's use the latter so it's consistent throughout the whole driver. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH net-next 4/5] net: phy: mscc: shorten `x != 0` condition to `x`

2018-09-14 Thread Quentin Schulz
`if (x != 0)` is basically a more verbose version of `if (x)` so let's use the latter so it's consistent throughout the whole driver. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH net-next 5/5] net: phy: mscc: remove unneeded temporary variable

2018-09-14 Thread Quentin Schulz
Here, the rc variable is either used only for the condition right after the assignment or right before being used as the return value of the function it's being used in. So let's remove this unneeded temporary variable whenever possible. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c

[PATCH net-next 5/5] net: phy: mscc: remove unneeded temporary variable

2018-09-14 Thread Quentin Schulz
Here, the rc variable is either used only for the condition right after the assignment or right before being used as the return value of the function it's being used in. So let's remove this unneeded temporary variable whenever possible. Signed-off-by: Quentin Schulz --- drivers/net/phy/mscc.c

[PATCH net-next v3 04/11] net: mscc: ocelot: move the HSIO header to include/soc

2018-09-14 Thread Quentin Schulz
Since HSIO address space can be used by different drivers (PLL, SerDes muxing, temperature sensor), let's move it somewhere it can be included by all drivers. Acked-by: Alexandre Belloni Signed-off-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 1 +- drivers/net/ethernet

[PATCH net-next v3 04/11] net: mscc: ocelot: move the HSIO header to include/soc

2018-09-14 Thread Quentin Schulz
Since HSIO address space can be used by different drivers (PLL, SerDes muxing, temperature sensor), let's move it somewhere it can be included by all drivers. Acked-by: Alexandre Belloni Signed-off-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 1 +- drivers/net/ethernet

Re: [PATCH net-next v2 1/7] net: phy: mscc: factorize code for LEDs mode

2018-09-04 Thread Quentin Schulz
Hi David, On Tue, Sep 04, 2018 at 10:48:27AM -0700, David Miller wrote: > From: Quentin Schulz > Date: Mon, 3 Sep 2018 10:48:47 +0200 > > > LEDs modes are set the same way, except they are offset by 4 times the > > index of the LED. > > > > Let's factorize

Re: [PATCH net-next v2 1/7] net: phy: mscc: factorize code for LEDs mode

2018-09-04 Thread Quentin Schulz
Hi David, On Tue, Sep 04, 2018 at 10:48:27AM -0700, David Miller wrote: > From: Quentin Schulz > Date: Mon, 3 Sep 2018 10:48:47 +0200 > > > LEDs modes are set the same way, except they are offset by 4 times the > > index of the LED. > > > > Let's factorize

[PATCH v2 10/11] phy: add driver for Microsemi Ocelot SerDes muxing

2018-09-03 Thread Quentin Schulz
The Microsemi Ocelot can mux SerDes lanes (aka macros) to different switch ports or even make it act as a PCIe interface. This adds support for the muxing of the SerDes. Signed-off-by: Quentin Schulz --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1

[PATCH v2 10/11] phy: add driver for Microsemi Ocelot SerDes muxing

2018-09-03 Thread Quentin Schulz
The Microsemi Ocelot can mux SerDes lanes (aka macros) to different switch ports or even make it act as a PCIe interface. This adds support for the muxing of the SerDes. Signed-off-by: Quentin Schulz --- drivers/phy/Kconfig | 1 + drivers/phy/Makefile | 1

[PATCH v2 00/11] mscc: ocelot: add support for SerDes muxing configuration

2018-09-03 Thread Quentin Schulz
for the deferring of the probe in the SerDes driver, - use constants in the Device Tree to select the SerDes macro in use with a port, - adapt the SerDes driver to use those constants, - add a header file in include/dt-bindings for the constants, - fix space/tab issue, Quentin Schulz (11

[PATCH net-next v2 05/11] net: mscc: ocelot: simplify register access for PLL5 configuration

2018-09-03 Thread Quentin Schulz
-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 73 drivers/net/ethernet/mscc/ocelot_regs.c | 92 +++-- include/soc/mscc/ocelot_hsio.h | 74 3 files changed, 83 insertions(+), 156 deletions(-) diff --git a/drivers/net

[PATCH v2 00/11] mscc: ocelot: add support for SerDes muxing configuration

2018-09-03 Thread Quentin Schulz
for the deferring of the probe in the SerDes driver, - use constants in the Device Tree to select the SerDes macro in use with a port, - adapt the SerDes driver to use those constants, - add a header file in include/dt-bindings for the constants, - fix space/tab issue, Quentin Schulz (11

[PATCH net-next v2 05/11] net: mscc: ocelot: simplify register access for PLL5 configuration

2018-09-03 Thread Quentin Schulz
-by: Quentin Schulz --- drivers/net/ethernet/mscc/ocelot.h | 73 drivers/net/ethernet/mscc/ocelot_regs.c | 92 +++-- include/soc/mscc/ocelot_hsio.h | 74 3 files changed, 83 insertions(+), 156 deletions(-) diff --git a/drivers/net

Re: [PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-08-06 Thread Quentin Schulz
Hi Linus, On Mon, Aug 06, 2018 at 01:06:23PM +0200, Linus Walleij wrote: > Hi Quentin, sorry for delays! > No worries :) > On Wed, Jul 25, 2018 at 2:27 PM Quentin Schulz > wrote: > > > This GPIO controller can serve as an interrupt controller as well on the

Re: [PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-08-06 Thread Quentin Schulz
Hi Linus, On Mon, Aug 06, 2018 at 01:06:23PM +0200, Linus Walleij wrote: > Hi Quentin, sorry for delays! > No worries :) > On Wed, Jul 25, 2018 at 2:27 PM Quentin Schulz > wrote: > > > This GPIO controller can serve as an interrupt controller as well on the

[PATCH 1/2] MIPS: mscc: ocelot: add interrupt controller properties to GPIO controller

2018-07-25 Thread Quentin Schulz
The GPIO controller also serves as an interrupt controller for events on the GPIO it handles. An interrupt occurs whenever a GPIO line has changed. Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/boot/dts

[PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-07-25 Thread Quentin Schulz
only after the line gets hold in its default state, this is what's done with the fasteoi functions. Only IRQ_TYPE_EDGE_BOTH and IRQ_TYPE_LEVEL_HIGH are supported for now. Signed-off-by: Quentin Schulz --- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/pinctrl-ocelot.c | 102

[PATCH 1/2] MIPS: mscc: ocelot: add interrupt controller properties to GPIO controller

2018-07-25 Thread Quentin Schulz
The GPIO controller also serves as an interrupt controller for events on the GPIO it handles. An interrupt occurs whenever a GPIO line has changed. Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/mips/boot/dts

[PATCH 2/2] pinctrl: ocelot: add support for interrupt controller

2018-07-25 Thread Quentin Schulz
only after the line gets hold in its default state, this is what's done with the fasteoi functions. Only IRQ_TYPE_EDGE_BOTH and IRQ_TYPE_LEVEL_HIGH are supported for now. Signed-off-by: Quentin Schulz --- drivers/pinctrl/Kconfig | 1 + drivers/pinctrl/pinctrl-ocelot.c | 102

[PATCH] MIPS: mscc: ocelot: add MIIM1 bus

2018-07-25 Thread Quentin Schulz
-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi index 7096915f26e0..d7f0e3551500 100644 --- a/arch/mips/boot/dts/mscc/ocelot.dtsi +++ b/arch/mips

[PATCH] MIPS: mscc: ocelot: add MIIM1 bus

2018-07-25 Thread Quentin Schulz
-by: Quentin Schulz --- arch/mips/boot/dts/mscc/ocelot.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi index 7096915f26e0..d7f0e3551500 100644 --- a/arch/mips/boot/dts/mscc/ocelot.dtsi +++ b/arch/mips

[PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

2018-07-25 Thread Quentin Schulz
The length of memory address space for MIIM0 is from 0x7107009c to 0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in hexadecimal and not 0x36. Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot") Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/o

[PATCH] MIPS: mscc: ocelot: fix length of memory address space for MIIM

2018-07-25 Thread Quentin Schulz
The length of memory address space for MIIM0 is from 0x7107009c to 0x710700bf included which is 36 bytes long in decimal, or 0x24 bytes in hexadecimal and not 0x36. Fixes: 49b031690abe ("MIPS: mscc: Add switch to ocelot") Signed-off-by: Quentin Schulz --- arch/mips/boot/dts/mscc/o

[PATCH v5 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi

[PATCH v5 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi

[PATCH v5 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c | 12

[PATCH v5 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 11 +++ drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6 ++ drivers/mtd/ubi/ubi.h | 4 drivers/mtd/ubi/vmt.c | 12

[PATCH v5 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

[PATCH v5 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

[PATCH v4 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
: - fix a few typos, v2: - use volume flags instead of arguments on the kernel command line as suggested by Richard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/kapi.c

[PATCH v4 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3

[PATCH v4 0/2] ubi: add possibility to skip CRC check for static UBI volumes

2018-07-02 Thread Quentin Schulz
: - fix a few typos, v2: - use volume flags instead of arguments on the kernel command line as suggested by Richard, Quentin Schulz (2): ubi: provide a way to skip CRC checks ubi: expose the volume CRC check skip flag drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/kapi.c

[PATCH v4 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 7 +++ drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 18 -- 3

[PATCH v4 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

[PATCH v4 1/2] ubi: provide a way to skip CRC checks

2018-07-02 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon Reviewed-by: Richard Weinberger --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd

Re: [PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
> > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz: > > > > Now that we have the logic for skipping CRC check for static UBI volumes > > > > in the core, let's expose it to users. > > > > > > > > This makes use of a padd

Re: [PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-07-02 Thread Quentin Schulz
> > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz: > > > > Now that we have the logic for skipping CRC check for static UBI volumes > > > > in the core, let's expose it to users. > > > > > > > > This makes use of a padd

[PATCH v3 1/2] ubi: provide a way to skip CRC checks

2018-06-28 Thread Quentin Schulz
at the block granularity instead of verifying the whole volume. Skipping this test drastically improves the boot-time. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/kapi.c | 2 +- drivers/mtd/ubi/ubi-media.h | 6

[PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-06-28 Thread Quentin Schulz
volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3 files

[PATCH v3 2/2] ubi: expose the volume CRC check skip flag

2018-06-28 Thread Quentin Schulz
volume for which we are trying to skip the CRC check is static. Suggested-by: Boris Brezillon Signed-off-by: Quentin Schulz Reviewed-by: Boris Brezillon --- drivers/mtd/ubi/cdev.c | 4 drivers/mtd/ubi/vmt.c | 3 +++ include/uapi/mtd/ubi-user.h | 16 ++-- 3 files

  1   2   3   4   5   6   7   8   9   10   >