[PATCH 2/2] HID: hid-sensor-custom: Process failure of sensor_hub_set_feature()

2021-04-15 Thread Srinivas Pandruvada
When user modifies a custom feature value and sensor_hub_set_feature() fails, return error. Reported-by: Abaci Robot Signed-off-by: Srinivas Pandruvada --- Replaces patch: HID: hid-sensor-custom: remove useless variable by Jiapeng Chong drivers/hid/hid-sensor-custom.c | 2 ++ 1 file changed

[PATCH 1/2] HID: hid-sensor-hub: Return error for hid_set_field() failure

2021-04-15 Thread Srinivas Pandruvada
In the function sensor_hub_set_feature(), return error when hid_set_field() fails. Signed-off-by: Srinivas Pandruvada --- drivers/hid/hid-sensor-hub.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c

Re: [PATCH] iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER

2021-04-15 Thread Srinivas Pandruvada
oves the IIO_TRIGGERED_BUFFER enforcement from each driver. > > Fixes: 067fda1c065ff ("iio: hid-sensors: move triggered buffer setup > into hid_sensor_setup_trigger") > Reported-by: Thomas Deutschmann > Cc: Srinivas Pandruvada > Signed-off-by: Alexandru Ardelean Ac

Re: [thermal] 9223d0dccb: stress-ng.msg.ops_per_sec -27.4% regression

2021-04-14 Thread Srinivas Pandruvada
On Tue, 2021-04-13 at 21:58 +0800, kernel test robot wrote: > > Greeting, > > FYI, we noticed a -27.4% regression of stress-ng.msg.ops_per_sec due > to commit: > > > commit: 9223d0dccb8f8523754122f68316dd1a4f39f7f8 ("thermal: Move > therm_throt there from x86/mce") >

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-12 Thread srinivas pandruvada
On Mon, 2021-04-12 at 11:20 +0100, Jonathan Cameron wrote: > On Sun, 11 Apr 2021 09:06:35 -0700 > Srinivas Pandruvada wrote: > > > On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote: > > > On Fri, 09 Apr 2021 11:19:12 -0700 > > > Srinivas Pandruvada wro

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-11 Thread Srinivas Pandruvada
On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote: > On Fri, 09 Apr 2021 11:19:12 -0700 > Srinivas Pandruvada wrote: > > > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote: > > > Fix the following gcc warning: > > > > > > drivers/hid/hi

Re: [PATCH] HID: hid-sensor-custom: remove useless variable

2021-04-09 Thread Srinivas Pandruvada
On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote: > Fix the following gcc warning: > > drivers/hid/hid-sensor-custom.c:400:7: warning: variable ‘ret’ set > but > not used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng C

Re: [PATCH] HID: intel-ish-hid: Remove an unused variable 'ret'

2021-04-02 Thread Srinivas Pandruvada
On Fri, 2021-04-02 at 18:06 +0800, Yang Li wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable > ‘ret’ > set but not used > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Acked

[PATCH] platform/x86: ISST: Account for increased timeout in some cases

2021-03-30 Thread Srinivas Pandruvada
more than average processing time, yield to other tasks. The worst case timeout is extended upto 1 milli-second. Signed-off-by: Srinivas Pandruvada --- .../intel_speed_select_if/isst_if_mbox_pci.c | 33 +-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers

Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

2021-03-28 Thread Srinivas Pandruvada
Hi Daniel, On Sat, 2021-03-27 at 21:25 +0100, Daniel Lezcano wrote: > Hi Srinivas, > > On 27/03/2021 18:46, Srinivas Pandruvada wrote: > > On Fri, 2021-03-26 at 17:37 +0100, Rafael J. Wysocki wrote: > > > On Thu, Mar 25, 2021 at 8:38 PM Daniel Lezcano > &g

Re: [PATCH] thermal/drivers/netlink: Add the temperature when crossing a trip point

2021-03-27 Thread Srinivas Pandruvada
On Fri, 2021-03-26 at 17:37 +0100, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:38 PM Daniel Lezcano > wrote: > > The slope of the temperature increase or decrease can be high and > > when > > the temperature crosses the trip point, there could be a > > significant > > difference between

Re: [PATCH 00/25] Rid W=1 warnings from HID

2021-03-24 Thread Srinivas Pandruvada
On Wed, 2021-03-24 at 17:33 +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > For changes in drivers/hid/intel-ish-hid folder Acked-by: Sriniva

[PATCH v2] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-16 Thread Srinivas Pandruvada
standby bit in the SYSTEM_STATE_STATUS command. This change sets CONNECTED_STANDBY_STATE_BIT bit to 1 during suspend callback and clears during resume callback. Signed-off-by: Ye Xiang [srinivas.pandruv...@linux.intel.com: changelog rewrite] Acked-by: Srinivas Pandruvada --- v2: changed

Re: [PATCH] tools/power/x86/intel-speed-select: drop __DATE__ and __TIME__ macros

2021-03-12 Thread Srinivas Pandruvada
On Fri, 2021-03-12 at 10:57 -0300, Antonio Terceiro wrote: > These macros introduce nondeterminism in builds, and break > reproducible > builds. Thanks. I will include this change in my pull request. -Srinivas > > Signed-off-by: Antonio Terceiro > Cc: Srinivas Pandruvada &g

Re: [PATCH V2 1/25] x86/cpufeatures: Enumerate Intel Hybrid Technology feature bit

2021-03-10 Thread Srinivas Pandruvada
; > maximum level of CPUID, which may not be reliable. > > > > On Wed, Mar 10, 2021 at 11:33:54AM -0800, Srinivas Pandruvada > > wrote: > > > We are working on changes to P-State driver for hybrid CPUs using > > > this > > > define. They are still w

Re: [PATCH V2 1/25] x86/cpufeatures: Enumerate Intel Hybrid Technology feature bit

2021-03-10 Thread Srinivas Pandruvada
ndi Kleen > > Cc: Kan Liang > > Cc: "Peter Zijlstra (Intel)" > > Cc: "Rafael J. Wysocki" > > Cc: "Ravi V. Shankar" > > Cc: Srinivas Pandruvada > > Cc: linux-kernel@vger.kernel.org > > Reviewed-by: Len Brown > > Reviewed

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-09 Thread Srinivas Pandruvada
On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote: > Hi Srinivas, Jiri > > On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote: > > On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > > > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > > >

Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition

2021-03-08 Thread Srinivas Pandruvada
On Mon, 2021-03-08 at 17:16 +0100, Jiri Kosina wrote: > On Mon, 8 Mar 2021, Srinivas Pandruvada wrote: > > > > > A remove callback is only ever called for a bound device. So > > > > there > > > > is no > > > > need to check for device or dr

Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition

2021-03-08 Thread Srinivas Pandruvada
On Mon, 2021-03-08 at 11:07 +0100, Jiri Kosina wrote: > On Sat, 6 Feb 2021, Uwe Kleine-König wrote: > > > A remove callback is only ever called for a bound device. So there > > is no > > need to check for device or driver being NULL. > > Srinivas, any objections to this patchset? The cleanups

Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

2021-03-08 Thread Srinivas Pandruvada
On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote: > On Wed, 3 Mar 2021, Ye Xiang wrote: > > > ISH firmware uses connected standby state bit > > (CONNECTED_STANDBY_STATE_BIT bit 1) > > to notify current power state to sensors instead of suspend state > > bit (bit 0). > > So send both

Re: [PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in illuminance too.

2021-03-01 Thread Srinivas Pandruvada
On Sun, 2021-02-28 at 14:45 +, Jonathan Cameron wrote: > On Sat, 27 Feb 2021 17:26:40 -0800 > Ronald Tschalär wrote: > > > Recent MacBook Pro's specify the usage of the change sensitivity > > field > > as illuminance (with a change sensitivity modifier) rather than as > > light. > > > >

Re: [RFC PATCH] powercap: Add Hygon Fam18h RAPL support

2021-02-28 Thread Srinivas Pandruvada
On Thu, 2021-02-25 at 21:01 +0800, Pu Wen wrote: > Enable Hygon Fam18h RAPL support for the power capping framework. > If this patch is tested and works on this processor, not sure why this is RFC? Thanks, Srinivas > Signed-off-by: Pu Wen > --- > drivers/powercap/intel_rapl_common.c | 1 + >

Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID

2021-02-08 Thread Srinivas Pandruvada
On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote: > Added Tiger Lake H PCI device ID to the supported device list. > > Signed-off-by: You-Sheng Yang Acked-by: Srinivas Pandruvada > --- > drivers/hid/intel-ish-hid/ipc/hw-ish.h | 1 + > drivers/hid/intel-ish-hid/ipc/pc

Re: [PATCH 1/2] powercap/intel_rapl: Use topology interface in rapl_add_package()

2021-02-05 Thread Srinivas Pandruvada
On Fri, 2021-02-05 at 13:45 +0100, Rafael J. Wysocki wrote: > On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye > wrote: > > It's not a good way to access phys_proc_id and cpu_die_id directly. > > So using topology_physical_package_id(cpu) and topology_die_id(cpu) > > instead. > > > > Signed-off-by:

Re: [PATCH 2/2] powercap/intel_rapl: Use topology interface in rapl_init_domains()

2021-02-05 Thread Srinivas Pandruvada
On Fri, 2021-02-05 at 13:46 +0100, Rafael J. Wysocki wrote: > On Sat, Jan 23, 2021 at 11:07 AM Yunfeng Ye > wrote: > > It's not a good way to access the phys_proc_id of cpuinfo directly. > > So using topology_physical_package_id(cpu) instead. > > > > Signed-off-by: Yunfeng Ye > > Srinivas,

Re: [PATCH] HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID

2021-02-04 Thread Srinivas Pandruvada
On Thu, 2021-02-04 at 16:33 +0800, You-Sheng Yang wrote: > Added Tiger Lake H PCI device ID to the supported device list. > > Signed-off-by: You-Sheng Yang Did you get chance to verify on a platform? Do you see sensors enumerated in /sys/bus/iio? Thanks, Srinivas > --- >

Re: [PATCH] platform/x86/intel-uncore-freq: Add Sapphire Rapids server support

2021-02-03 Thread Srinivas Pandruvada
; Reviewed-by: Tony Luck Acked-by: Srinivas Pandruvada > --- > drivers/platform/x86/intel-uncore-frequency.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel-uncore-frequency.c > b/drivers/platform/x86/intel-uncore-frequency.c > index 12d5

Re: [PATCH v3 2/2] thermal: Move therm_throt there from x86/mce

2021-02-02 Thread Srinivas Pandruvada
On Tue, 2021-02-02 at 13:10 +0100, Borislav Petkov wrote: > On Mon, Feb 01, 2021 at 11:10:29AM -0800, Srinivas Pandruvada wrote: > > Only user of the above interface is in drivers/thermal/intel. > > So why can't we move these to > > drivers/thermal/intel/thermal_inter

Re: [PATCH v3 0/2] Move ...mce/therm_throt.c to drivers/thermal/

2021-02-01 Thread Srinivas Pandruvada
mal LNXTHERM:00: registered as thermal_zone0 > > Logic in patch 1 got a bit simplified too. > [...] > > Borislav Petkov (2): > x86/mce: Get rid of mcheck_intel_therm_init() > thermal: Move therm_throt there from x86/mce > I have applied this series and test

Re: [PATCH v3 2/2] thermal: Move therm_throt there from x86/mce

2021-02-01 Thread Srinivas Pandruvada
On Mon, 2021-02-01 at 15:27 +0100, Borislav Petkov wrote: > From: Borislav Petkov > > This functionality has nothing to do with MCE, move it to the thermal > framework and untangle it from MCE. > > [...] > /* > * Used by APEI to report memory error via /dev/mcelog > */ > diff --git

Re: [PATCH 2/3] hid-sensor-common: Add relative sensitivity check

2021-01-31 Thread Srinivas Pandruvada
On Sun, 2021-01-31 at 11:26 +, Jonathan Cameron wrote: > On Fri, 29 Jan 2021 00:35:49 +0800 > "Ye, Xiang" wrote: > > > Hi Srinivas andd Jonathan > > > > Thanks for the review. > > > > On Sun, Jan 24, 2021 at 08:20:12AM -0800, Srinivas Pandru

Re: [PATCH v2 2/2] thermal: Move therm_throt there from x86/mce

2021-01-25 Thread Srinivas Pandruvada
On Mon, 2021-01-25 at 18:18 +0100, Borislav Petkov wrote: > On Mon, Jan 25, 2021 at 09:14:35AM -0800, Srinivas Pandruvada wrote: > > Can the handler, processing architectural features via thermal > > interrupt, reside in arch/x86 folder or need to be > > drivers/the

Re: [PATCH v2 2/2] thermal: Move therm_throt there from x86/mce

2021-01-25 Thread Srinivas Pandruvada
Hi All, On Mon, 2021-01-25 at 23:42 +0800, Zhang Rui wrote: > Hi, Borislav, > > Thanks for the patch. CC Srinivas. > Thanks for adding me. > On Mon, 2021-01-25 at 14:05 +0100, Borislav Petkov wrote: > > From: Borislav Petkov > > > > This functionality has nothing to do with MCE, move it to

Re: [PATCH 2/3] hid-sensor-common: Add relative sensitivity check

2021-01-24 Thread Srinivas Pandruvada
On Sun, 2021-01-24 at 13:14 +, Jonathan Cameron wrote: > On Wed, 20 Jan 2021 15:47:05 +0800 > Ye Xiang wrote: > > > Some hid sensors may use relative sensitivity such as als sensor. > > This patch add relative sensitivity check for all hid-sensors. > > > > Signed-off-by: Ye Xiang > > --- >

Re: [PATCH 2/2][v2] cpufreq: intel_pstate: Get percpu max freq via HWP MSR register if available

2021-01-11 Thread Srinivas Pandruvada
On Mon, 2021-01-11 at 15:43 +0800, Chen Yu wrote: > Currently when turbo is disabled(either by BIOS or by the user), the > intel_pstate > driver reads the max frequency from the package-wide > MSR_PLATFORM_INFO(0xce) register. > However on asymmetric platforms it is possible in theory that small >

Re: [PATCH] cpufreq: intel_pstate: Use HWP capabilities in intel_cpufreq_adjust_perf()

2021-01-05 Thread Srinivas Pandruvada
) > to always read the "guaranteed" and "maximum turbo" performance > levels from the cached HWP_CAP value. > > Signed-off-by: Rafael J. Wysocki Acked-by: Srinivas Pandruvada > --- >  drivers/cpufreq/intel_pstate.c |    5 +++-- >  1 fi

Re: [PATCH v3 0/6] add timestamp channel for hid-sensors

2021-01-05 Thread Srinivas Pandruvada
On Tue, 2021-01-05 at 15:21 +0800, Ye Xiang wrote: > This patch series add a timestamp channel for hid sensors, > including gravity sensor, gyro sensor, magnetometer sensor, > ambient light sensor, inclinometer sensor, and rotation sensor. > > With this patch series, user can get the time when

Re: [PATCH 0/2] hid: intel-ish-hid: ipc: enable OOB support for EHL

2021-01-04 Thread Srinivas Pandruvada
On Mon, 2021-01-04 at 16:12 +0100, Jiri Kosina wrote: > On Wed, 16 Dec 2020, Zhang Lixu wrote: > > > The EHL (Elkhart Lake) based platforms provide a OOB (Out of band) > > service, which allows wakup device when the system is in S5 (Soft- > > Off > > state). This OOB service can be

Re: [PATCH 2/2] hid: intel-ish-hid: ipc: Address EHL Sx resume issues

2021-01-04 Thread Srinivas Pandruvada
s alive, > just > set host ready bit to let fw know host is up. > > Co-developed-by: Wei Jiang > Signed-off-by: Wei Jiang > Signed-off-by: Even Xu > Signed-off-by: Zhang Lixu Acked-by: Srinivas Pandruvada > --- >  drivers/hid/intel-ish-hid/ipc/h

Re: [PATCH 1/2] hid: intel-ish-hid: ipc: finish power flow for EHL OOB

2021-01-04 Thread Srinivas Pandruvada
. > > Since this feature is only present on EHL, we use EHL PCI device id > to > enable this feature. > > Co-developed-by: Najumon Ba > Signed-off-by: Najumon Ba > Signed-off-by: Even Xu > Signed-off-by: Zhang Lixu Acked-by: Srinivas Pandru

Re: tools/power/x86/intel-speed-select: Fixes for regression

2021-01-04 Thread Srinivas Pandruvada
On Mon, 2021-01-04 at 12:56 +0100, Hans de Goede wrote: > Hi, > > On 12/21/20 8:18 AM, Srinivas Pandruvada wrote: > > One side-effect of fixing the scaling frequency limits using the > > commit eacc9c5a927e ("cpufreq: intel_pstate: Fix > > intel_pstate_get_

Re: tools/power/x86/intel-speed-select: Fixes for regression

2021-01-04 Thread Srinivas Pandruvada
Hi Hans, On Mon, 2021-01-04 at 12:57 +0100, Hans de Goede wrote: > Hi, > > On 1/4/21 12:56 PM, Hans de Goede wrote: > > Hi, > > > > On 12/21/20 8:18 AM, Srinivas Pandruvada wrote: > > > One side-effect of fixing the scaling frequency limits using the

Re: [PATCH 1/2] thermal: int340x: Add critical callback to override default shutdown behavior

2020-12-21 Thread Srinivas Pandruvada
On Mon, 2020-12-21 at 17:03 +0100, Daniel Lezcano wrote: > On 21/12/2020 16:00, Kai-Heng Feng wrote: > > On Mon, Dec 21, 2020 at 9:59 PM Daniel Lezcano > > wrote: > > > > > > On 21/12/2020 14:52, Kai-Heng Feng wrote: > > > > We are seeing thermal shutdown on Intel based mobile > > > >

Re: [PATCH 1/2] thermal: int340x: Add critical callback to override default shutdown behavior

2020-12-21 Thread Srinivas Pandruvada
On Mon, 2020-12-21 at 21:52 +0800, Kai-Heng Feng wrote: > We are seeing thermal shutdown on Intel based mobile workstations, > the > shutdown happens during the first trip handle in > thermal_zone_device_register(): > kernel: thermal thermal_zone15: critical temperature reached (101 C), > shutting

[PATCH 1/2] tools/power/x86/intel-speed-select: Set scaling_max_freq to base_frequency

2020-12-20 Thread Srinivas Pandruvada
. So when the turbo is disabled and cpufreq base_frequency is higher than scaling_max_freq, update the scaling_max_freq to the base_frequency. Signed-off-by: Srinivas Pandruvada --- .../x86/intel-speed-select/isst-config.c | 21 +++ 1 file changed, 21 insertions(+) diff --git

[PATCH 2/2] tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or base_frequency

2020-12-20 Thread Srinivas Pandruvada
In some case when BIOS disabled turbo, cpufreq cpuinfo_max_freq can be lower than base_frequency at higher config level. So, in that case set scaling_min_freq to base_frequency. Signed-off-by: Srinivas Pandruvada --- tools/power/x86/intel-speed-select/isst-config.c | 11 +++ 1 file

tools/power/x86/intel-speed-select: Fixes for regression

2020-12-20 Thread Srinivas Pandruvada
a new max while Intel SST is in use. This is not a problem as the change of guaranteed is caused by user space action, so user space knows that guarantee will change. This series causes user space to trigger scaling_max_freq update with the new base_frequency. Srinivas Pandruvada (2): tools/power

Re: [PATCH] cpufreq: intel_pstate: Use most recent guaranteed performance values

2020-12-18 Thread srinivas pandruvada
he reduced scaling > frequency values, but caused stale HWP_CAP.GUARANTEED to be used in > the case at hand. > > Fixes: eacc9c5a927e ("cpufreq: intel_pstate: Fix > intel_pstate_get_hwp_max() for turbo disabled") > Reported-by: Srinivas Pandruvada > > Tested-by: Srini

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Srinivas Pandruvada
On Thu, 2020-12-17 at 16:24 +0100, Rafael J. Wysocki wrote: > On Thu, Dec 17, 2020 at 4:21 PM Srinivas Pandruvada > wrote: > > > > On Thu, 2020-12-17 at 16:12 +0100, Rafael J. Wysocki wrote: > > > On Thursday, December 17, 2020 3:23:44 PM CET Srinivas Pandruvada > &

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Srinivas Pandruvada
On Thu, 2020-12-17 at 16:12 +0100, Rafael J. Wysocki wrote: > On Thursday, December 17, 2020 3:23:44 PM CET Srinivas Pandruvada > wrote: > > On Thu, 2020-12-17 at 06:19 -0800, Srinivas Pandruvada wrote: > > > On Thu, 2020-12-17 at 14:58 +0100, Rafael J. Wysocki wrote: > &g

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Srinivas Pandruvada
On Thu, 2020-12-17 at 06:19 -0800, Srinivas Pandruvada wrote: > On Thu, 2020-12-17 at 14:58 +0100, Rafael J. Wysocki wrote: > > On Thu, Dec 17, 2020 at 11:44 AM Srinivas Pandruvada > > wrote: > > > > > > This change tries to address an issue, when BIOS disabled t

Re: [PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Srinivas Pandruvada
On Thu, 2020-12-17 at 14:58 +0100, Rafael J. Wysocki wrote: > On Thu, Dec 17, 2020 at 11:44 AM Srinivas Pandruvada > wrote: > > > > This change tries to address an issue, when BIOS disabled turbo > > but HWP_CAP guaranteed is changed later and user space wants t

Re: [PATCH 3/5] thermal/drivers/acpi: Use hot and critical ops

2020-12-17 Thread Srinivas Pandruvada
On Thu, 2020-12-17 at 07:28 +0100, Daniel Lezcano wrote: > On 10/12/2020 13:15, Daniel Lezcano wrote: > > The acpi driver wants to do a netlink notification in case of a hot > > or > > critical trip point. Implement the corresponding ops to be used for > > the thermal zone and use them instead of

[PATCH] cpufreq: intel_pstate: Use the latest guaranteed freq during verify

2020-12-17 Thread Srinivas Pandruvada
ng HWP.REQ to HWP_CAP.GUARANTEED in this case. Cc: 5.8+ # 5.8+ Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 2a4db856222f..7081d1edb

Re: [PATCH] thermal: int340x: Support Alder Lake

2020-12-15 Thread srinivas pandruvada
On Tue, 2020-11-17 at 11:48 -0800, Srinivas Pandruvada wrote: > Add ACPI IDs for thermal drivers for Alder Lake support. > This patch was not in PULL request. It is simple patch, adding ids. Can we send as part of second PULL? Thanks, Srinivas > Signed-off-by: Srinivas P

Re: [PATCH v2 3/3] cpufreq: intel_pstate: Implement the ->adjust_perf() callback

2020-12-14 Thread Srinivas Pandruvada
iding sufficient capacity. > > Signed-off-by: Rafael J. Wysocki Acked-by: Srinivas Pandruvada > --- > > v1 -> v2: >  - No changes. > > --- >  drivers/cpufreq/intel_pstate.c |   70 > + >  1 file changed, 58 inse

Re: [PATCH -next] hid/hid-sensor-custom: convert comma to semicolon

2020-12-14 Thread Srinivas Pandruvada
On Mon, 2020-12-14 at 21:32 +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Acked-by: Srinivas Pandruvada > --- >  drivers/hid/hid-sensor-custom.c | 2 +- >  1 file changed, 1 insertion(+), 1 del

[PATCH] thermal: int340x: processor_thermal: Correct workload type name

2020-12-10 Thread Srinivas Pandruvada
Change "Burusty" to "bursty". Reported-by: Michael Larabel Signed-off-by: Srinivas Pandruvada --- drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/proc

Re: [PATCH 3/4] thermal: int340x: processor_thermal: Add RFIM driver

2020-12-09 Thread Srinivas Pandruvada
On Wed, 2020-12-09 at 21:48 +0100, Daniel Lezcano wrote: > On 26/11/2020 18:18, Srinivas Pandruvada wrote: > > Add support for RFIM (Radio Frequency Interference Mitigation) > > support > > via processor thermal PCI device. This drivers allows adjustment of > > FIV

Re: [PATCH 1/4] thermal: int340x: processor_thermal: Refactor MMIO interface

2020-12-09 Thread Srinivas Pandruvada
On Thu, 2020-11-26 at 09:18 -0800, Srinivas Pandruvada wrote: > The Processor Thermal PCI device supports multiple features. > Currently > we export only RAPL. But we need more features from this device > exposed > for Tiger Lake and Alder Lake based platforms. So re-structure the

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-12-09 Thread Srinivas Pandruvada
On Wed, 2020-12-09 at 10:30 +0100, Daniel Lezcano wrote: > On 07/12/2020 06:36, Kai-Heng Feng wrote: > > > > > On Dec 1, 2020, at 02:39, Srinivas Pandruvada < > > > srinivas.pandruv...@linux.intel.com> wrote: > > > > > > On Tue, 2020-12-01 at 0

[PATCH v2 3/3] platform/x86: ISST: Change PCI device macros

2020-12-07 Thread Srinivas Pandruvada
Use PCI_VDEVICE and PCI_DEVICE_DATA macros. No functional changes are expected. Signed-off-by: Srinivas Pandruvada --- .../platform/x86/intel_speed_select_if/isst_if_common.h | 8 .../platform/x86/intel_speed_select_if/isst_if_mbox_pci.c | 4 ++-- drivers/platform/x86

[PATCH v2 2/3] platform/x86: ISST: Allow configurable offset range

2020-12-07 Thread Srinivas Pandruvada
-off-by: Srinivas Pandruvada --- LKP test robot reported sparse warning. Added "Reported-by" as suggested by the message. .../x86/intel_speed_select_if/isst_if_mmio.c | 50 +-- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/drivers/pl

[PATCH v2 1/3] platform/x86: ISST: Check for unaligned mmio address

2020-12-07 Thread Srinivas Pandruvada
The address should be aligned to 4 byte boundary. So send an error for unaligned address. Signed-off-by: Srinivas Pandruvada --- drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/intel_speed_select_if

[PATCH v2 0/3] Intel Speed Select interface changes for 5.11

2020-12-07 Thread Srinivas Pandruvada
v2 Fix sparse warnings reported by LKP. Srinivas Pandruvada (3): platform/x86: ISST: Check for unaligned mmio address platform/x86: ISST: Allow configurable offset range platform/x86: ISST: Change PCI device macros .../intel_speed_select_if/isst_if_common.h| 8

Re: add custom hinge sensor support

2020-12-04 Thread Srinivas Pandruvada
On Thu, 2020-12-03 at 11:53 +0800, Ye Xiang wrote: > Here three separate iio devices are presented which presents angle > for > hinge, keyboard and screen. You are presenting one IIO device now with three channels. > > This driver works on devices with Intel integrated sensor hub, where > hinge

Re: [PATCH v3 3/3] iio:Documentation: Add documentation for hinge sensor channels

2020-12-04 Thread Srinivas Pandruvada
On Thu, 2020-12-03 at 11:53 +0800, Ye Xiang wrote: > Add channel description for hinge sensor, including channel label > attribute and raw data description. > > Signed-off-by: Ye Xiang > --- > Documentation/ABI/testing/sysfs-bus-iio | 17 + > 1 file changed, 17 insertions(+) >

[PATCH 3/3] platform/x86: ISST: Change PCI device macros

2020-12-03 Thread Srinivas Pandruvada
Use PCI_VDEVICE and PCI_DEVICE_DATA macros. No functional changes are expected. Signed-off-by: Srinivas Pandruvada --- .../platform/x86/intel_speed_select_if/isst_if_common.h | 8 .../platform/x86/intel_speed_select_if/isst_if_mbox_pci.c | 4 ++-- drivers/platform/x86

[PATCH 2/3] platform/x86: ISST: Allow configurable offset range

2020-12-03 Thread Srinivas Pandruvada
The mmio offset range can be different based on the PCI device id. Here for INTEL_RAPL_PRIO_DEVID_1, the range is increased from 45 to 64. Pass the range as the driver_data. Also account for different ranges during save/restore via suspend/resume callbacks. Signed-off-by: Srinivas Pandruvada

[PATCH 1/3] platform/x86: ISST: Check for unaligned mmio address

2020-12-03 Thread Srinivas Pandruvada
The address should be aligned to 4 byte boundary. So send an error for unaligned address. Signed-off-by: Srinivas Pandruvada --- drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/intel_speed_select_if

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Srinivas Pandruvada
On Tue, 2020-12-01 at 02:22 +0800, Kai-Heng Feng wrote: > > On Dec 1, 2020, at 02:13, Srinivas Pandruvada < > > srinivas.pandruv...@linux.intel.com> wrote: > > [snipped] > > > > > What about creating an new callback &g

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Srinivas Pandruvada
On Tue, 2020-12-01 at 02:04 +0800, Kai-Heng Feng wrote: > > On Dec 1, 2020, at 00:19, Srinivas Pandruvada < > > srinivas.pandruv...@linux.intel.com> wrote: > > > > On Mon, 2020-11-30 at 16:23 +0800, Kai-Heng Feng wrote: > > > > On Nov 30, 2020, at 1

Re: [PATCH 1/3] thermal: core: Add indication for userspace usage

2020-11-30 Thread Srinivas Pandruvada
On Mon, 2020-11-30 at 16:23 +0800, Kai-Heng Feng wrote: > > On Nov 30, 2020, at 15:57, Daniel Lezcano < > > daniel.lezc...@linaro.org> wrote: > > > > > > [Added Srinivas] > > > > On 28/11/2020 18:54, Kai-Heng Feng wrote: > > > We are seeing thermal shutdown on Intel based mobile > > >

Re: [PATCH 2/3] thermal: int340x: Indicate userspace usage

2020-11-29 Thread Srinivas Pandruvada
On Sun, 2020-11-29 at 01:54 +0800, Kai-Heng Feng wrote: > The device isn't present under ACPI ThermalZone, and there's a > dedicated > userspace daemon for this thermal device. > > Let thermal core know it shouldn't handle trips to avoid surprising > thermal shutdown. > > Signed-off-by: Kai-Heng

[PATCH 3/4] thermal: int340x: processor_thermal: Add RFIM driver

2020-11-26 Thread Srinivas Pandruvada
te_point_2 (RO): DDR data rate selection 3rd point ddr_data_rate_point_3 (RO): DDR data rate selection 4th point rfi_disable (RW): Disable DDR rate change feature Signed-off-by: Srinivas Pandruvada --- .../thermal/intel/int340x_thermal/Makefile| 1 + .../processor_thermal_device.c

[PATCH 1/4] thermal: int340x: processor_thermal: Refactor MMIO interface

2020-11-26 Thread Srinivas Pandruvada
function Signed-off-by: Srinivas Pandruvada --- drivers/thermal/intel/int340x_thermal/Kconfig | 6 +- .../thermal/intel/int340x_thermal/Makefile| 1 + .../processor_thermal_device.c| 261 -- .../processor_thermal_device.h| 72

[PATCH 2/4] thermal: int340x: processor_thermal: Add AlderLake PCI device id

2020-11-26 Thread Srinivas Pandruvada
Added AlderLake PCI device id to support processor thermal driver. Reuse the feature set (just includes RAPL) from previous generations. Signed-off-by: Srinivas Pandruvada --- drivers/thermal/intel/int340x_thermal/processor_thermal_device.c | 1 + drivers/thermal/intel/int340x_thermal

[PATCH 4/4] thermal: int340x: processor_thermal: Add mailbox driver

2020-11-26 Thread Srinivas Pandruvada
setting Signed-off-by: Srinivas Pandruvada --- .../thermal/intel/int340x_thermal/Makefile| 1 + .../processor_thermal_device.c| 17 +- .../processor_thermal_device.h| 4 + .../int340x_thermal/processor_thermal_mbox.c | 212 ++ 4 files

[PATCH] thermal: int340x: Support Alder Lake

2020-11-17 Thread Srinivas Pandruvada
Add ACPI IDs for thermal drivers for Alder Lake support. Signed-off-by: Srinivas Pandruvada --- drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 1 + drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/thermal/intel

[PATCH] ACPI: DPTF: Support Alder Lake

2020-11-10 Thread Srinivas Pandruvada
Add Alder Lake ACPI IDs for DPTF devices. Signed-off-by: Srinivas Pandruvada --- drivers/acpi/dptf/dptf_pch_fivr.c | 1 + drivers/acpi/dptf/dptf_power.c | 2 ++ drivers/acpi/dptf/int340x_thermal.c | 6 ++ drivers/acpi/fan.c | 1 + 4 files changed, 10 insertions

Re: [PATCH v3 3/4] powercap: Add AMD Fam17h RAPL support

2020-11-05 Thread Srinivas Pandruvada
On Thu, 2020-11-05 at 14:53 +1100, Victor Ding wrote: > On Wed, Nov 4, 2020 at 1:17 PM Srinivas Pandruvada > wrote: > > On Wed, 2020-11-04 at 12:43 +1100, Victor Ding wrote: > > > On Wed, Nov 4, 2020 at 4:09 AM Srinivas Pandruvada > > > wrote: > > > >

Re: [PATCH] HID: hid-sensor-hub: Fix issue with devices with no report ID

2020-11-04 Thread Srinivas Pandruvada
t > skip > over the first byte. > > Signed-off-by: Pablo Ceballos Acked-by: Srinivas Pandruvada > --- > drivers/hid/hid-sensor-hub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor- > hu

Re: [PATCH v3 3/4] powercap: Add AMD Fam17h RAPL support

2020-11-03 Thread Srinivas Pandruvada
On Wed, 2020-11-04 at 12:43 +1100, Victor Ding wrote: > On Wed, Nov 4, 2020 at 4:09 AM Srinivas Pandruvada > wrote: > > On Tue, 2020-11-03 at 17:10 +1100, Victor Ding wrote: > > > On Mon, Nov 2, 2020 at 12:39 PM Zhang Rui > > > wrote: > > > > On Tue, 20

Re: [PATCH v3 3/4] powercap: Add AMD Fam17h RAPL support

2020-11-03 Thread Srinivas Pandruvada
On Tue, 2020-11-03 at 17:10 +1100, Victor Ding wrote: > On Mon, Nov 2, 2020 at 12:39 PM Zhang Rui > wrote: > > On Tue, 2020-10-27 at 07:23 +, Victor Ding wrote: > > > This patch enables AMD Fam17h RAPL support for the power capping > > > framework. The support is as per AMD Fam17h Model31h

Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX

2020-10-21 Thread Srinivas Pandruvada
On Tue, 2020-10-20 at 12:40 -0700, Dave Hansen wrote: > On 10/20/20 11:40 AM, Srinivas Pandruvada wrote: > > On Tue, 2020-10-20 at 19:47 +0200, Borislav Petkov wrote: > > > On Tue, Oct 20, 2020 at 10:21:48AM -0700, Srinivas Pandruvada > > > wrote: > > > &

Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX

2020-10-20 Thread Srinivas Pandruvada
On Tue, 2020-10-20 at 19:47 +0200, Borislav Petkov wrote: > On Tue, Oct 20, 2020 at 10:21:48AM -0700, Srinivas Pandruvada wrote: > > These command id are model specific. There is no guarantee that > > even > > meaning changes. So I don't think we should write any code in >

Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX

2020-10-20 Thread Srinivas Pandruvada
On Mon, 2020-10-19 at 19:15 +0200, Borislav Petkov wrote: > On Tue, Sep 08, 2020 at 06:02:05PM -0700, Srinivas Pandruvada wrote: > > The actual OC mailbox implementation itself is implemented in Linux > > in > > intel_turbo_max_3 driver. So that is public. > > So s

Re: [PATCH 1/2] ACPI: DPTF: Fix participant driver names

2020-10-15 Thread Srinivas Pandruvada
: Add PCH FIVR participant driver") > Fixes: 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participant > driver") > Signed-off-by: Rafael J. Wysocki Reviewed-by: Srinivas Pandruvada > --- > drivers/acpi/dptf/dptf_pch_fivr.c |2 +- > drivers/acpi/dptf/dptf_

Re: [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu

2020-10-15 Thread Srinivas Pandruvada
While at it, do a few assorted cleanups for a good measure. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Srinivas Pandruvada > --- > drivers/acpi/dptf/Kconfig | 29 - > 1 file changed, 24 insertions(+), 5 deletions(-) > >

Re: [RFC][PATCH] cpufreq: intel_pstate: Delete intel_pstate sysfs if failed to register the driver

2020-10-12 Thread srinivas pandruvada
this issue by deleting the intel_pstate sysfs if the driver > failed > to be loaded during bootup. > > Reported-by: Wendy Wang > Suggested-by: Zhang Rui > Signed-off-by: Chen Yu Acked-by: Srinivas Pandruvada ---> > drivers/cpufreq/intel_pstate.c | 24

[PATCH] ACPI / DPTF: Add PCH FIVR participant driver

2020-09-15 Thread Srinivas Pandruvada
value. GFC1: This ACPI method to get PCH FIVR switching frequency when FIVR clock is 38.4MHz. Signed-off-by: Srinivas Pandruvada --- Documentation/ABI/testing/sysfs-platform-dptf | 16 +++ drivers/acpi/dptf/Kconfig | 14 ++ drivers/acpi/dptf/Makefile

[PATCH 3/3] thermal: int340x: Add keep alive response method

2020-09-15 Thread Srinivas Pandruvada
g response to firmware request for keep alive. Signed-off-by: Srinivas Pandruvada --- .../intel/int340x_thermal/int3400_thermal.c | 29 +++ 1 file changed, 29 insertions(+) diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int34

[PATCH 1/3] thermal: int340x: Provide notification for OEM variable change

2020-09-15 Thread Srinivas Pandruvada
When we receive ACPI notification for OEM variable change pass the notification to user space handler. This will avoid polling for OEM variable change from user space. Signed-off-by: Srinivas Pandruvada --- .../intel/int340x_thermal/int3400_thermal.c | 22 +-- 1 file changed

[PATCH 2/3] thermal: core: Add new event for sending keep alive notifications

2020-09-15 Thread Srinivas Pandruvada
This event is sent by the platform firmware to confirm that user space thermal solution is alive. The response to this event from the user space thermal solution is platform specific. Signed-off-by: Srinivas Pandruvada --- include/linux/thermal.h | 1 + 1 file changed, 1 insertion(+) diff

thermal: int340x: New notifications for INT340X thermal

2020-09-15 Thread Srinivas Pandruvada
This series contains notifications to user space using currently used mechanism in these drivers. Srinivas Pandruvada (3): thermal: int340x: Provide notification for OEM variable change thermal: core: Add new event for sending keep alive notifications thermal: int340x: Add keep alive

Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX

2020-09-08 Thread Srinivas Pandruvada
On Tue, 2020-09-08 at 21:30 +0200, Borislav Petkov wrote: > On Tue, Sep 08, 2020 at 12:18:38PM -0700, Sultan Alsawaf wrote: > > I'd like to point out that on Intel's recent 14nm parts, > > undervolting > > is not so much for squeezing every last drop of performance out of > > the > > SoC as it is

Re: [PATCH] x86/msr: do not warn on writes to OC_MAILBOX

2020-09-08 Thread Srinivas Pandruvada
On Mon, 2020-09-07 at 12:06 +0200, Borislav Petkov wrote: > + Srinivas. > + kitsunyan. > > On Mon, Sep 07, 2020 at 11:48:43AM +0200, Jason A. Donenfeld wrote: > > Popular tools, like intel-undervolt, use MSR 0x150 to control the > > CPU > > voltage offset. In fact, evidently the intel_turbo_max_3

Re: [PATCH v4 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-09-01 Thread Srinivas Pandruvada
scm/linux/kernel/git/rafael/linux-pm.git \ > intel_pstate-testing > > I've done my best to address all of the possible corner cases, but > the test > matrix is quite extensive and I may have missed something, so go > ahead > and test. Acked-by: Srinivas Pandruvada > > Thanks, > Rafael > > >

Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-25 Thread Srinivas Pandruvada
On Tue, 2020-08-25 at 17:14 +0200, Rafael J. Wysocki wrote: > On Tue, Aug 25, 2020 at 5:06 PM Srinivas Pandruvada > wrote: > > On Tue, 2020-08-25 at 16:51 +0200, Rafael J. Wysocki wrote: > > > On Tue, Aug 25, 2020 at 8:20 AM Artem Bityutskiy < > > >

Re: [PATCH v2 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-08-25 Thread Srinivas Pandruvada
000 80002b0c 80002b0d 80002d0c 8000 80002b0c 8000 80002b0d 8000 8000 > On 2020.08.24 16:56 Srinivas Pandruvada wrote: > > On Mon, 2020-08-24 at 19:39 +0200, Rafael J. Wysocki wrote: > > > Hi All, > > > > > > The v2 is here to address fee

  1   2   3   4   5   6   7   8   9   10   >