Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-04-09 Thread Stefan Wahren
Hi Nicolas, Am 09.04.21 um 12:54 schrieb Nicolas Saenz Julienne: > Hi again, > > On Wed, 2021-04-07 at 16:37 -0400, Alan Cooper wrote: >> Nicolas, >> >> I got a better description of the failure and it looks like the bus >> clock needs to be limited to 300KHz for a 500MHz core clock. >> What's

Re: [PATCH 2/3] mmc: sdhci-iproc: Cap min clock frequency on BCM2711

2021-04-06 Thread Stefan Wahren
Hi Nicolas, Am 06.04.21 um 12:48 schrieb Nicolas Saenz Julienne: > There is a known bug on BCM2711's SDHCI core integration where the > controller will hang when the difference between the core clock and the > bus clock is too great. Specifically this can be reproduced under the > following

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-26 Thread Stefan Wahren
Am 26.03.21 um 17:17 schrieb Nicolas Saenz Julienne: > On Thu, 2021-03-25 at 20:11 +0100, Stefan Wahren wrote: >> Am 24.03.21 um 16:34 schrieb Nicolas Saenz Julienne: >>> Hi Stefan, >>> >>> On Wed, 2021-03-24 at 16:16 +0100, Stefan Wahren wrote: >>>

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-25 Thread Stefan Wahren
Am 24.03.21 um 16:34 schrieb Nicolas Saenz Julienne: > Hi Stefan, > > On Wed, 2021-03-24 at 16:16 +0100, Stefan Wahren wrote: >> Hi Nicolas, >> >> Am 22.03.21 um 19:58 schrieb Nicolas Saenz Julienne: >>> From: Nicolas Saenz Julienne >>> >>> F

Re: [PATCH 4/4] ARM: dts: Fix-up EMMC2 controller's frequency

2021-03-24 Thread Stefan Wahren
Hi Nicolas, Am 22.03.21 um 19:58 schrieb Nicolas Saenz Julienne: > From: Nicolas Saenz Julienne > > Force emmc2's frequency to 150MHz as the default 100MHz (set by FW) > seems to interfere with the VPU clock when setup at frequencies bigger > than 500MHz (a pretty common case). This ends up

Re: [PATCH v2] hwrng: iproc: set quality to 1024

2021-02-22 Thread Stefan Wahren
Hi, Am 20.02.21 um 21:01 schrieb Álvaro Fernández Rojas: > This allows khwrngd to make use of iproc-rng200. > > Justification: > cat /dev/hwrng | rngtest -c 1000 > rngtest 6.10 > Copyright (c) 2004 by Henrique de Moraes Holschuh > This is free software; see the source for copying conditions.

Re: [RFC/PATCH 09/11] ARM: dts: bcm2711: Enable V3D

2021-02-06 Thread Stefan Wahren
Hi, Am 05.02.21 um 14:52 schrieb Nicolas Saenz Julienne: > This enables V3D for bcm2711 (used in the Raspberry Pi 4). > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/arm/boot/dts/bcm2711.dtsi | 12 > 1 file changed, 12 insertions(+) > > diff --git

Re: [RFC/PATCH 02/11] dt-bindings: soc: bcm: brcm,bcm2835-pm: Add support for bcm2711

2021-02-06 Thread Stefan Wahren
Hi, Am 05.02.21 um 14:52 schrieb Nicolas Saenz Julienne: > Add a new compatible string for bcm2711 and the option to provide a > third reg property for the board's new Argon ASB. > > The new Argon ASB took over V3D, which is our only consumer of this > driver so far. The old ASB is still be

Re: [RFC/PATCH 01/11] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema

2021-02-06 Thread Stefan Wahren
Hi, Am 05.02.21 um 14:52 schrieb Nicolas Saenz Julienne: > This converts the brcm,bcm2835-pc bindings from text to proper schema. s/bcm2835-pc/bcm2835-pm/ > > Signed-off-by: Nicolas Saenz Julienne > --- > .../bindings/soc/bcm/brcm,bcm2835-pm.txt | 46 --- >

Re: [PATCH] mmc: sdhci-iproc: Add ACPI bindings for the rpi4

2021-01-11 Thread Stefan Wahren
Hi, Am 11.01.21 um 04:39 schrieb Jeremy Linton: > Hi, > > On 1/9/21 5:07 AM, Stefan Wahren wrote: >> Hi Jeremy, >> >> +add Nicolas >> >> Am 08.01.21 um 22:13 schrieb Jeremy Linton: >>> The rpi4 has a Arasan controller it carries over >>>

Re: [PATCH] mmc: sdhci-iproc: Add ACPI bindings for the rpi4

2021-01-09 Thread Stefan Wahren
Hi Jeremy, +add Nicolas Am 08.01.21 um 22:13 schrieb Jeremy Linton: > The rpi4 has a Arasan controller it carries over > from the rpi3, and a newer eMMC2 controller. > Because of a couple "quirks" it seems wiser to bind > these controllers to the same driver that DT is using > on this platform

[PATCH] MAINTAINERS: Include bcm2835 subsequents into search

2021-01-03 Thread Stefan Wahren
Change the bcm2835 maintainer info in order to handle subsequent SoCs. After this get_maintainers.pl provides the proper maintainers for irqchip-bcm2836. Signed-off-by: Stefan Wahren --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: [PATCH] tty: serial: amba-pl011: added RS485 support v2

2020-12-28 Thread Stefan Wahren
Hi Ivan, please place the patch version between [ ... ] in the subject. Am 28.12.20 um 17:41 schrieb Ivan Sistik: > AMBA PL011 do not have hardware support for RS485. This implementation is > for drive enable signal (DE), which switch direction of RS485 driver chip. > This signal si drived by

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-30 Thread Stefan Wahren
;>>> Reviewed-by: Dave Stevenson >>>> Tested-by: Chanwoo Choi >>>> Tested-by: Hoegeun Kwon >>>> Tested-by: Stefan Wahren >>>> Signed-off-by: Maxime Ripard >>> Apologies if this has already been reported or have a

[BUG] NULL ptr deref in css_free_rwork_fn

2020-09-16 Thread Stefan Wahren
Hi, i noticed a regular crash (NULL pointer dereference) on my ARM i.MX28 board using the current mainline kernel (last tested version Linux 5.9-rc5). I also tested Linux 5.8, but i wasn't able to reproduce with this version, so i assume this is a regression. The crash happens mostly short after

Re: [PATCH v2 1/1] ARM: dts: bcm2711: Enable ddr modes on emmc2 controller

2020-09-02 Thread Stefan Wahren
Hi Tobias, Am 31.08.20 um 23:59 schrieb Tobias Schramm: > This commit enables ddr modes for eMMC storage on emmc2. > The bcm2711 supports eMMC storage using ddr modes. The board > layout of the Raspberry Pi 4 supports them, too. i want to inform you that Ulf Hansson already applied my driver

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-09-01 Thread Stefan Wahren
Hi Maxime, Am 01.09.20 um 11:58 schrieb Maxime Ripard: > Hi Stefan > > On Tue, Aug 25, 2020 at 11:30:58PM +0200, Stefan Wahren wrote: >> Am 25.08.20 um 17:06 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stef

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi Maxime, Am 28.08.20 um 17:25 schrieb Maxime Ripard: > Hi, > > On Fri, Aug 28, 2020 at 02:45:49PM +0200, Stefan Wahren wrote: >> Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: >>> On 8/27/20 6:49 PM, Stefan Wahren wrote: >>>> Am 27.08.20 um 06:35 s

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-28 Thread Stefan Wahren
Hi, Am 28.08.20 um 08:30 schrieb Hoegeun Kwon: > On 8/27/20 6:49 PM, Stefan Wahren wrote: >> Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: >>> Hi Stefan, >>> >>> Thank you for your review. >>> >>> >>> On 8/26/20 7:04 PM, Stefan Wahren

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Stefan Wahren
Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: > Hi Stefan, > > Thank you for your review. > > > On 8/26/20 7:04 PM, Stefan Wahren wrote: >> Hi Hoeguen, >> >> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >>> There is a problem that the output does not wor

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-26 Thread Stefan Wahren
Hi Hoeguen, Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: > There is a problem that the output does not work at a resolution > exceeding FHD. To solve this, we need to adjust the bvb clock at a > resolution exceeding FHD. this patch introduces a mandatory clock, please update brcm,bcm2835-hdmi.yaml

Re: [PATCH 0/3] drm/vc4: Support HDMI QHD or higher output

2020-08-26 Thread Stefan Wahren
Hi Hoegeun, Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: > Hi everyone, > > There is a problem that the output does not work at a resolution > exceeding FHD. To solve this, we need to adjust the bvb clock at a > resolution exceeding FHD. thanks for providing this. > > Rebased on top of

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-08-25 Thread Stefan Wahren
Hi Maxime, Am 25.08.20 um 17:06 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jul 29, 2020 at 05:50:31PM +0200, Stefan Wahren wrote: >> Am 29.07.20 um 16:42 schrieb Maxime Ripard: >>> Hi, >>> >>> On Wed, Jul 29, 2020 at 03:09:21PM +0100, Dave Stevens

Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-07-29 Thread Stefan Wahren
Hi Maxime, Am 29.07.20 um 16:42 schrieb Maxime Ripard: > Hi, > > On Wed, Jul 29, 2020 at 03:09:21PM +0100, Dave Stevenson wrote: >> On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: >>> In order to avoid pixels getting stuck in the (unflushable) FIFO between >>> the HVS and the PV, we need to

Re: [PATCH v4 00/78] drm/vc4: Support BCM2711 Display Pipeline

2020-07-10 Thread Stefan Wahren
ify the FIFO level stuff > - Reordered the patches according to Eric's reviews > - Fixed a regression with VID_CTL setting on RPI3 > i additionally applied "drm/vc4/vc4_hdmi: fill ASoC card owner" on top of your series (potential merge conflict). I didn't see any issues with a RPI 3B or RPI 4B. So this whole series is Tested-by: Stefan Wahren Regards Stefan

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-16 Thread Stefan Wahren
Hi Maxime, Am 16.06.20 um 14:30 schrieb Maxime Ripard: > On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: >> Am 11.06.20 um 15:34 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: >>

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-14 Thread Stefan Wahren
Hi Maxime, Am 11.06.20 um 15:34 schrieb Maxime Ripard: > Hi Stefan, > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 05.06.20 um 16:35 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jun 03,

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Stefan Wahren
Am 11.06.20 um 19:06 schrieb Florian Fainelli: > > On 6/11/2020 9:52 AM, Maxime Ripard wrote: >> Hi Stefan, >> >> On Thu, Jun 11, 2020 at 05:50:30PM +0200, Stefan Wahren wrote: >>>> diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c >>>> b/drivers/clk

Re: [PATCH v4 2/3] clk: bcm: Add BCM2711 DVP driver

2020-06-11 Thread Stefan Wahren
Hi Maxime, Am 11.06.20 um 11:23 schrieb Maxime Ripard: > The HDMI block has a block that controls clocks and reset signals to the > HDMI0 and HDMI1 controllers. > > Let's expose that through a clock driver implementing a clock and reset > provider. > > Cc: Michael Turquette > Cc: Stephen Boyd >

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-06 Thread Stefan Wahren
Hi Maxime, Am 05.06.20 um 16:35 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: >>> On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >>>> On Wed, M

Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings

2020-06-04 Thread Stefan Wahren
Am 04.06.20 um 18:40 schrieb Florian Fainelli: > > On 6/3/2020 9:20 PM, Lukas Wunner wrote: >> On Wed, Jun 03, 2020 at 08:46:54PM -0700, Florian Fainelli wrote: >>> The BCM2711 SoC features 5 SPI controllers which all share the same >>> interrupt line, the SPI driver needs to support interrupt

Re: [PATCH 2/3] ARM: dts: bcm2711: Update SPI nodes compatible strings

2020-06-04 Thread Stefan Wahren
Hi Florian, Am 04.06.20 um 05:46 schrieb Florian Fainelli: > The BCM2711 SoC features 5 SPI controllers which all share the same > interrupt line, the SPI driver needs to support interrupt sharing, > therefore use the chip specific compatible string to help with that. the commit message is

Re: [PATCH v3 105/105] ARM: dts: bcm2711: Enable the display pipeline

2020-06-03 Thread Stefan Wahren
Hi Maxime, Am 27.05.20 um 17:49 schrieb Maxime Ripard: > Now that all the drivers have been adjusted for it, let's bring in the > necessary device tree changes. > > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 46 +++- > arch/arm/boot/dts/bcm2711.dtsi

Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders

2020-06-03 Thread Stefan Wahren
Am 02.06.20 um 17:54 schrieb Maxime Ripard: > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: >>> the vc4_hdmi driver has some custom structures to hold the data it needs to >>> associate with the drm_encoder and drm_connector

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-06-03 Thread Stefan Wahren
Hi Maxime, Am 03.06.20 um 15:14 schrieb Maxime Ripard: > Hi Stefan, > > On Tue, Jun 02, 2020 at 10:03:13PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 21:31 schrieb Eric Anholt: >>> On Tue, Jun 2, 2020 at 8:02 AM Dave Stevenson >>> wrote: >>>> Hi

Re: [PATCH v3 000/105] drm/vc4: Support BCM2711 Display Pipeline

2020-06-02 Thread Stefan Wahren
Hi Maxime, Am 27.05.20 um 17:47 schrieb Maxime Ripard: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are that there's two HDMI controllers and that

Re: [PATCH v3 032/105] drm/vc4: crtc: Enable and disable the PV in atomic_enable / disable

2020-06-02 Thread Stefan Wahren
Hi, Am 02.06.20 um 21:31 schrieb Eric Anholt: > On Tue, Jun 2, 2020 at 8:02 AM Dave Stevenson > wrote: >> Hi Maxime and Eric >> >> On Tue, 2 Jun 2020 at 15:12, Maxime Ripard wrote: >>> Hi Eric >>> >>> On Wed, May 27, 2020 at 09:54:44AM -0700, Eric Anholt wrote: On Wed, May 27, 2020 at 8:50

Re: [PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-30 Thread Stefan Wahren
Hi Florian, Am 30.05.20 um 23:19 schrieb Florian Fainelli: > > On 5/30/2020 12:49 AM, Stefan Wahren wrote: >> Hi Florian, >> >> Am 29.05.20 um 21:15 schrieb Florian Fainelli: >>> } >>> >>> +static int bcm2835_gpio_irq_set_wake(struct irq_data

Re: [PATCH v2 4/4] pinctrl: bcm2835: Add support for wake-up interrupts

2020-05-30 Thread Stefan Wahren
Hi Florian, Am 29.05.20 um 21:15 schrieb Florian Fainelli: > Leverage the IRQCHIP_MASK_ON_SUSPEND flag in order to avoid having to > specifically treat the GPIO interrupts during suspend and resume, and > simply implement an irq_set_wake() callback that is responsible for > enabling the parent

Re: [PATCH 3/4] pinctrl: bcm2835: Match BCM7211 compatible string

2020-05-29 Thread Stefan Wahren
Hi Florian, Am 28.05.20 um 21:21 schrieb Florian Fainelli: > The BCM7211 SoC uses the same pinconf_ops as the ones defined for the > BCM2711 SoC, match the compatible string and use the correct set of > options. > > Signed-off-by: Florian Fainelli > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c |

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-21 Thread Stefan Wahren
Hi Lukasz, Am 19.05.20 um 23:25 schrieb Łukasz Stelmach: > The value was estimaded with ea_iid[1] using on 10485760 bytes read from > the RNG via /dev/hwrng. The min-entropy value calculated using the most > common value estimate (NIST SP 800-90P[2], section 6.3.1) was 7.964464. could you please

Re: [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-09 Thread Stefan Wahren
Am 09.05.20 um 12:02 schrieb Stefan Wahren: > Hi Nicolas, > > Am 07.05.20 um 23:48 schrieb Rob Herring: >> On Tue, 5 May 2020 18:13:15 +0200, Nicolas Saenz Julienne wrote: >>> The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip >>> that implemen

Re: [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-09 Thread Stefan Wahren
"VL805 RAM firmware version %08x\n", version);     return 0;  }  EXPORT_SYMBOL_GPL(rpi_firmware_init_vl805); Here are the my results with 3x Raspberry Pi 4: VL805 EEPROM firmware version 000137ad VL805 EEPROM firmware version 00013701 VL805 RAM firmware version 000137ad So the whole patch series is: Tested-by: Stefan Wahren

Re: [PATCH net v2] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed

2020-05-08 Thread Stefan Wahren
Hi Marek, Am 07.05.20 um 12:03 schrieb Marek Szyprowski: > Hi > > On 07.05.2020 11:46, Marek Szyprowski wrote: >> On 25.02.2020 14:11, Nicolas Saenz Julienne wrote: >>> Outdated Raspberry Pi 4 firmware might configure the external PHY as >>> rgmii although the kernel currently sets it as

Re: [PATCH v2 89/91] drm/vc4: hdmi: Support the BCM2711 HDMI controllers

2020-05-07 Thread Stefan Wahren
Hi Maxime, Am 24.04.20 um 17:35 schrieb Maxime Ripard: > Now that the driver is ready for it, let's bring in the HDMI controllers > variants for the BCM2711. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 276 +- > drivers/gpu/drm/vc4/vc4_hdmi.h

Re: [PATCH v7 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-04 Thread Stefan Wahren
Hi Nicolas, Am 04.05.20 um 10:59 schrieb Nicolas Saenz Julienne: > Hi Stefan, thanks for the review! > > On Sat, 2020-05-02 at 11:05 +0200, Stefan Wahren wrote: >>> + if (version) >>> + goto exit; >>> + >>> + dev_addr = pdev->

Re: [PATCH v7 2/4] firmware: raspberrypi: Introduce vl805 init routine

2020-05-02 Thread Stefan Wahren
Hi Nicolas, Am 29.04.20 um 18:47 schrieb Nicolas Saenz Julienne: > The Raspberry Pi 4 gets its USB functionality from VL805, a PCIe chip > that implements xHCI. After a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > co-processor,

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-15 Thread Stefan Wahren
Hi Florian, Am 11.10.19 um 21:31 schrieb Florian Fainelli: > On 10/11/19 11:48 AM, matthias@kernel.org wrote: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. >> >> Signed-off-by: Matthias Brugger >> >> --- >> >>

[GIT PULL 2/3] bcm2835-soc-next-2019-10-15

2019-10-15 Thread Stefan Wahren
. Stefan Wahren (1): ARM: bcm: Add support for BCM2711 SoC arch/arm/mach-bcm/Kconfig| 4 +++- arch/arm/mach-bcm/Makefile | 3 ++- arch/arm/mach-bcm/bcm2711.c | 24 arch/arm64/Kconfig.platforms | 5 +++-- 4 files changed, 32

[GIT PULL 1/3] bcm2835-dt-next-2019-10-15

2019-10-15 Thread Stefan Wahren
. Stefan Wahren (7): ARM: dts: bcm283x: Remove simple-bus from fixed clocks ARM: dts: bcm283x: Remove brcm,bcm2835-pl011 compatible ARM: dts: bcm283x: Move BCM2835/6/7 specific to bcm2835-common.dtsi dt-bindings

[GIT PULL 3/3] bcm2835-maintainers-next-2019-10-15

2019-10-15 Thread Stefan Wahren
contributor. Simon Arlott (1): mailmap: Add Simon Arlott (replacement for expired email address) Stefan Wahren (1): MAINTAINERS: Add BCM2711 to BCM2835 ARCH .mailmap| 1 + MAINTAINERS | 3 ++- 2 files changed, 3

Re: [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

2019-10-13 Thread Stefan Wahren
Hi Jules, Am 13.10.19 um 20:34 schrieb Jules Irenge: > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > In the process, change driver functions name in the multiple files from: > vchiq_mmal_port_parameter_set to vmp_prmtr_set > vchiq_mmal_component_disable to

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-13 Thread Stefan Wahren
Hi Florian, Am 11.10.19 um 21:31 schrieb Florian Fainelli: > On 10/11/19 11:48 AM, matthias@kernel.org wrote: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. >> >> Signed-off-by: Matthias Brugger >> >> --- >> >>

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-12 Thread Stefan Wahren
Am 12.10.19 um 01:09 schrieb Stefan Wahren: > Am 11.10.19 um 20:48 schrieb matthias@kernel.org: >> From: Matthias Brugger >> >> Enable Gigabit Ethernet support on the Raspberry Pi 4 >> Model B. > I asked some questions about genet to the RPi guys [1] whic

Re: [PATCH] mailmap: Add Simon Arlott (replacement for expired email address)

2019-10-12 Thread Stefan Wahren
Am 22.08.19 um 21:01 schrieb Simon Arlott: > Add replacement email address for the one on my expired domain. > > Signed-off-by: Simon Arlott > --- Applied to bcm2835-maintainers-next

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-12 Thread Stefan Wahren
Hi, Am 03.10.19 um 18:36 schrieb Will Deacon: > On Wed, Oct 02, 2019 at 01:39:40PM -0700, Linus Torvalds wrote: >> On Wed, Oct 2, 2019 at 5:56 AM Geert Uytterhoeven >> wrote: Then use the C preprocessor to force the inlining. I'm sorry it's not as pretty as static inline functions.

Re: [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4

2019-10-11 Thread Stefan Wahren
Am 11.10.19 um 20:48 schrieb matthias@kernel.org: > From: Matthias Brugger > > Enable Gigabit Ethernet support on the Raspberry Pi 4 > Model B. I asked some questions about genet to the RPi guys [1] which are relevant to this patch (missing clocks and interrupt, MAC address assignment) but i

Re: [PATCH] mmc: sdhci-iproc: fix spurious interrupts on Multiblock reads with bcm2711

2019-10-04 Thread Stefan Wahren
>> Signed-off-by: Nicolas Saenz Julienne >> Tested-by: Matthias Brugger > Forgot to add: > > Fixes: f84e411c85be ("mmc: sdhci-iproc: Add support for emmc2 of the BCM2711") > > I'll resend if needed. Yes, please and you can add my: Acked-by: Stefan Wahren > > Regards, > Nicolas > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dt: check MPIDR on MP devices built without SMP

2019-10-03 Thread Stefan Wahren
ble. > > This was seen on a Raspberry Pi 2 build with bcm2835_defconfig. > > Reported-by: "kernelci.org bot" > Signed-off-by: Nicolas Saenz Julienne > --- Tested-by: Stefan Wahren Thanks

Re: [PATCH RFC V2] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
Hi Johannes, Am 29.09.19 um 16:12 schrieb Stefan Wahren: > The commit 2a38075cd0be ("nl80211: Add support for EDMG channels") > introduced a member to the cfg80211 channel definition. Unfortunately > the channel definitions are allocated on the stack and are not always >

[PATCH RFC V2] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
r, because cfg80211_chandef_valid() accesses uninitialized memory and fail. Fix this by init the remaining occurences with memset. Reported-by: Dmitry Osipenko Signed-off-by: Stefan Wahren Fixes: 2a38075cd0be ("nl80211: Add support for EDMG channels") --- net/mac80211/util.c| 1 + ne

[PATCH RFC] nl80211: Fix init of cfg80211 channel definition

2019-09-29 Thread Stefan Wahren
r, because cfg80211_chandef_valid() accesses uninitialized memory and fail. Fix this by init the remaining occurences with memset. Reported-by: Dmitry Osipenko Signed-off-by: Stefan Wahren --- net/mac80211/util.c| 1 + net/wireless/nl80211.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletio

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-27 Thread Stefan Wahren
Hi Matthias, Am 17.09.19 um 20:03 schrieb Stefan Wahren: > Hi Matthias, > > Am 17.09.19 um 11:04 schrieb Matthias Brugger: >> On 16/09/2019 21:19, Stefan Wahren wrote: >>> Hi Matthias, >>> >>> [drop uninvolved receiver] >>> >>>

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-17 Thread Stefan Wahren
Hi Matthias, Am 17.09.19 um 11:04 schrieb Matthias Brugger: > > On 16/09/2019 21:19, Stefan Wahren wrote: >> Hi Matthias, >> >> [drop uninvolved receiver] >> >> Am 13.09.19 um 12:39 schrieb Matthias Brugger: >>>>>>> If you talk about th

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-16 Thread Stefan Wahren
Hi Matthias, [drop uninvolved receiver] Am 13.09.19 um 12:39 schrieb Matthias Brugger: > > If you talk about the > downstream kernel, I suppose you mean we should change this in the FW DT > blob > and in the downstream kernel. That would work for me. > > Did I

Re: [PATCH] staging: bcm2835-audio: Fix draining behavior regression

2019-09-15 Thread Stefan Wahren
ent to provide more context of the unexpected behavior? Nevertheless: Acked-by: Stefan Wahren > Cc: sta...@vger.kernel.org > Signed-off-by: Takashi Iwai > --- > drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 4 ++-- > drivers/staging/vc04_services/bcm2835-audi

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-13 Thread Stefan Wahren
Am 13.09.19 um 11:25 schrieb Matthias Brugger: > > On 13/09/2019 10:50, Stefan Wahren wrote: >> Am 13.09.19 um 10:09 schrieb Matthias Brugger: >>> On 12/09/2019 21:32, Stefan Wahren wrote: >>>> Am 12.09.19 um 19:18 schrieb Matthias Brugger: >>>>

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-13 Thread Stefan Wahren
Am 13.09.19 um 10:09 schrieb Matthias Brugger: > > On 12/09/2019 21:32, Stefan Wahren wrote: >> Am 12.09.19 um 19:18 schrieb Matthias Brugger: >>> On 10/09/2019 11:27, Matthias Brugger wrote: >>>> On 09/09/2019 21:33, Stefan Wahren wrote: >>>>> Hi N

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-12 Thread Stefan Wahren
Am 12.09.19 um 19:18 schrieb Matthias Brugger: > > On 10/09/2019 11:27, Matthias Brugger wrote: >> >> On 09/09/2019 21:33, Stefan Wahren wrote: >>> Hi Nicolas, >>> >>> Am 09.09.19 um 11:58 schrieb Nicolas Saenz Julienne: >>>> Hi all,

Re: [PATCH v5 0/4] Raspberry Pi 4 DMA addressing support

2019-09-09 Thread Stefan Wahren
Hi Nicolas, Am 09.09.19 um 11:58 schrieb Nicolas Saenz Julienne: > Hi all, > this series attempts to address some issues we found while bringing up > the new Raspberry Pi 4 in arm64 and it's intended to serve as a follow > up of these discussions: > v4: https://lkml.org/lkml/2019/9/6/352 > v3:

Re: [PATCH -next 02/15] thermal: bcm2835: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread Stefan Wahren
Am 04.09.19 um 14:29 schrieb YueHaibing: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Stefan Wahren

Re: [PATCH -next 06/36] spi: bcm2835: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread Stefan Wahren
Am 04.09.19 um 15:58 schrieb YueHaibing: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Stefan Wahren

Re: [PATCH -next 05/36] spi: bcm2835aux: use devm_platform_ioremap_resource() to simplify code

2019-09-05 Thread Stefan Wahren
Am 04.09.19 um 15:58 schrieb YueHaibing: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Acked-by: Stefan Wahren

Re: [PATCH] mailmap: Add Simon Arlott (replacement for expired email address)

2019-08-24 Thread Stefan Wahren
Am 22.08.19 um 21:01 schrieb Simon Arlott: > Add replacement email address for the one on my expired domain. > > Signed-off-by: Simon Arlott I already send out my pull requests. Can anyone else take care of this?

Re: [PATCH v3] gpiolib: Take MUX usage into account

2019-08-19 Thread Stefan Wahren
Am 14.08.19 um 13:00 schrieb Ramon Fried: > From: Stefan Wahren > > The user space like gpioinfo only see the GPIO usage but not the > MUX usage (e.g. I2C or SPI usage) of a pin. As a user we want to know which > pin is free/safe to use. So take the MUX usage of strict pin

[GIT PULL 3/3] bcm2835-defconfig-64-next-2019-08-15

2019-08-15 Thread Stefan Wahren
Hi Florian, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-64-next-2019-08-15 for you to fetch changes up to

[GIT PULL 2/3] bcm2835-defconfig-next-2019-08-15

2019-08-15 Thread Stefan Wahren
Hi Florian, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the git repository at: git://github.com/anholt/linux tags/bcm2835-defconfig-next-2019-08-15 for you to fetch changes up to

[GIT PULL 1/3] bcm2835-dt-next-2019-08-15

2019-08-15 Thread Stefan Wahren
. Stefan Wahren (4): ARM: bcm283x: Reduce register ranges for UART, SPI and I2C ARM: dts: bcm283x: Define MMC interfaces at board level ARM: dts: bcm283x: Define memory at board level ARM: dts: bcm283x: Enable HDMI at board level arch/arm/boot/dts/bcm2835

[PATCH 3/3] net: qca: update MODULE_AUTHOR() email address

2019-08-13 Thread Stefan Wahren
I2SE has been acquired by in-tech. So the email address listed in MODULE_AUTHOR() will be disabled in the near future. I only have access to QCA7000 boards at in-tech, so use my new company address. Signed-off-by: Stefan Wahren --- drivers/net/ethernet/qualcomm/qca_7k_common.c | 2 +- drivers

Re: [PATCH v2] gpiolib: Take MUX usage into account

2019-08-13 Thread Stefan Wahren
Am 13.08.19 um 08:10 schrieb Fried, Ramon: > > On 8/13/2019 08:38, Stefan Wahren wrote: >> Hi Ramon, >> >> On 13.08.19 03:42, Ramon Fried wrote: >>> From: Stefan Wahren >>> >>> The user space like gpioinfo only see the GPIO usage but not

Re: [PATCH v2] gpiolib: Take MUX usage into account

2019-08-12 Thread Stefan Wahren
Hi Ramon, On 13.08.19 03:42, Ramon Fried wrote: > From: Stefan Wahren > > The user space like gpioinfo only see the GPIO usage but not the > MUX usage (e.g. I2C or SPI usage) of a pin. As a user we want to know which > pin is free/safe to use. So take the MUX usage of strict pin

Re: [PATCH v2 -next] staging: vc04_services: fix used-but-set-variable warning

2019-07-26 Thread Stefan Wahren
Hi Yue, Am 26.07.19 um 11:26 schrieb YueHaibing: > Fix gcc used-but-set-variable warning: just a nit. It is call "unused-but-set-variable" Acked-by: Stefan Wahren > > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function > vchiq_release_inter

Re: [PATCH v4 7/7] arm64: defconfig: enable cpufreq support for RPi3

2019-07-23 Thread Stefan Wahren
Am 12.06.19 um 20:24 schrieb Nicolas Saenz Julienne: > This enables both the new firmware clock driver and cpufreq driver > available for the RPi3 family of boards. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Stefan Wahren > --- > > Changes since v2: > - Bu

Re: [PATCH v4 6/7] ARM: defconfig: enable cpufreq driver for RPi

2019-07-23 Thread Stefan Wahren
he conservative governor was selected as default since it better > handles the high frequency transition latency. > > Signed-off-by: Nicolas Saenz Julienne > Acked-by: Stefan Wahren Applied to bcm2835-defconfig-next Thanks

[PATCH] dmaengine: bcm2835: Print error in case setting DMA mask fails

2019-07-16 Thread Stefan Wahren
During enabling of the RPi 4, we found out that the driver doesn't provide a helpful error message in case setting DMA mask fails. So add one. Signed-off-by: Stefan Wahren --- drivers/dma/bcm2835-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/bcm2835

Re: [PATCH] spi: spi-bcm2835.c: Fix 3-wire mode

2019-06-28 Thread Stefan Wahren
Hi Nuno, Am 28.06.19 um 14:30 schrieb Nuno Sá: > As stated in > https://www.raspberrypi.org/documentation/hardware/raspberrypi/spi/README.md, > one of rx or tx buffer's must be null. However, if DMA is enabled, the > driver sets the SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX on the >

Re: [PATCH v5 04/12] PCI: brcmstb: add dma-range mapping for inbound traffic

2019-06-27 Thread Stefan Wahren
Hi Jim, Am 24.09.18 um 17:01 schrieb Jim Quinlan: > On Mon, Sep 24, 2018 at 4:25 AM Ard Biesheuvel > wrote: >> On Fri, 21 Sep 2018 at 19:41, Jim Quinlan wrote: >>> On Thu, Sep 20, 2018 at 5:39 PM Florian Fainelli >>> wrote: On 09/20/2018 02:33 PM, Ard Biesheuvel wrote: > On 20

Re: [PATCH] staging: bcm2835-camera: Avoid apotential sleep while holding a spin_lock

2019-06-24 Thread Stefan Wahren
Hi Christophe, Am 24.06.2019 um 07:33 schrieb Christophe JAILLET: Do not allocate memory with GFP_KERNEL when holding a spin_lock, it may sleep. Use GFP_NOWAIT instead. Fixes: 950fd867c635 ("staging: bcm2835-camera: Replace open-coded idr with a struct idr.") Signed-off-by: Christophe JAILLET

Re: [PATCH v4 0/7] cpufreq support for Raspberry Pi

2019-06-22 Thread Stefan Wahren
Hi Stephen, hi Mike, Am 13.06.19 um 06:31 schrieb Stefan Wahren: > Hi Florian, > hi Stephen, > > Am 13.06.19 um 05:31 schrieb Florian Fainelli: >> On 6/12/2019 11:24 AM, Nicolas Saenz Julienne wrote: >>> Hi all, >>> this aims at adding cpufreq support to t

Re: [PATCH v4 0/7] cpufreq support for Raspberry Pi

2019-06-13 Thread Stefan Wahren
Hi Florian, hi Stephen, Am 13.06.19 um 05:31 schrieb Florian Fainelli: > > On 6/12/2019 11:24 AM, Nicolas Saenz Julienne wrote: >> Hi all, >> this aims at adding cpufreq support to the Raspberry Pi family of >> boards. >> >> The series first factors out 'pllb' from clk-bcm2385 and creates a new

Re: [PATCH v4 0/7] cpufreq support for Raspberry Pi

2019-06-12 Thread Stefan Wahren
iver that populates the CPU's opp > table, and registers cpufreq-dt. Which is needed as the firmware > controls the max and min frequencies available. > > This was tested on a RPi3b+ and RPI2b, both using multi_v7_defconfig and > arm64's defconfig. > this whole series is: Acked-by: Stefan Wahren Thanks

Re: [PATCH v2 0/7] cpufreq support for Raspberry Pi

2019-06-08 Thread Stefan Wahren
Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > Hi all, > this aims at adding cpufreq support to the Raspberry Pi family of > boards. > > The series first factors out 'pllb' from clk-bcm2385 and creates a new > clk driver that operates it over RPi's firmware interface[1]. We are > forced to

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Stefan Wahren
Hi Nicolas, Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > Raspberry Pi's firmware offers and interface though which update it's > performance requirements. It allows us to request for specific runtime > frequencies, which the firmware might or might not respect, depending on > the

Re: [PATCH v2 6/7] ARM: defconfig: enable cpufreq driver for RPi

2019-06-07 Thread Stefan Wahren
Hi Nicolas, Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > This enables on both multi_v7_defconfig and bcm2835_defconfig the new > firmware based clock and cpufreq drivers for the Raspberry Pi platform. > > In the case of bcm2835_defconfig, as the cpufreq subsystem was disabled, > the

Re: [PATCH v2 7/7] arm64: defconfig: enable cpufreq support for RPi3

2019-06-07 Thread Stefan Wahren
Hi Nicolas, Am 06.06.19 um 16:23 schrieb Nicolas Saenz Julienne: > This enables both the new firmware clock driver and cpufreq driver > available for the RPi3 family of boards. > > Signed-off-by: Nicolas Saenz Julienne > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2

Re: [PATCH v2 2/7] clk: bcm283x: add driver interfacing with Raspberry Pi's firmware

2019-06-07 Thread Stefan Wahren
Am 07.06.19 um 11:42 schrieb Nicolas Saenz Julienne: > On Fri, 2019-06-07 at 11:26 +0200, Stefan Wahren wrote: >> Hi Nicolas, >> >> Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: >>> Raspberry Pi's firmware offers an interface though which updat

Re: [PATCH v2 2/7] clk: bcm283x: add driver interfacing with Raspberry Pi's firmware

2019-06-07 Thread Stefan Wahren
Hi Nicolas, Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > Raspberry Pi's firmware offers an interface though which update it's > clock's frequencies. This is specially useful in order to change the CPU > clock (pllb_arm) which is 'owned' by the firmware and we're unable to > scale using

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Stefan Wahren
Hi Viresh, Am 07.06.19 um 05:09 schrieb Viresh Kumar: > On 06-06-19, 11:23, Stephen Boyd wrote: >> Yes, thanks. I see that largely follows the commit description so it >> looks OK to me. > Do you want to provide your Reviewed/Acked-by tag before I apply it ? Nicolas wanted to send a V3 of this

Re: [PATCH 0/4] cpufreq support for the Raspberry Pi

2019-06-05 Thread Stefan Wahren
Hi Nicolas, >> Am 05.06.19 um 13:00 schrieb Nicolas Saenz Julienne: >>> Hi Stefan, >>> thanks for the review, I took note of your code comments. >>> >>> On Wed, 2019-06-05 at 11:46 +0200, Stefan Wahren wrote: >>>> Hi Nicolas, >>>>

Re: [PATCH 0/4] cpufreq support for the Raspberry Pi

2019-06-05 Thread Stefan Wahren
Am 05.06.19 um 14:27 schrieb Nicolas Saenz Julienne: > Ok, this looks more more like my fault, probably an overflow error somewhere. > I > saw something similar while testing it on RPI2b. Which board & config was this > run with? It's an RPi 3B+ with multi_v7_defconfig > Could you confirm the

  1   2   3   4   5   6   7   8   9   10   >