Re: [PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:52 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:45 AM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR s

Re: [PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:52 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:45 AM, Yakir Yang wrote: Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir

Re: [PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:51 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:44 AM, Yakir Yang <y...@rock-chips.com> wrote: Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp

Re: [PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-19 Thread Yakir Yang
Hi Sean, On 09/12/2016 09:51 PM, Sean Paul wrote: On Fri, Sep 9, 2016 at 5:44 AM, Yakir Yang wrote: Signed-off-by: Yakir Yang --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix

[PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-09 Thread Yakir Yang
Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 18 +- 2 files changed, 11 insertions(+), 10 del

[PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v3: - Update commit message - Add DP_TIMEOUT_PSR_LOOP_MS

[PATCH v3 2/3] drm/bridge: analogix_dp: use jiffies to simulate timeout loop

2016-09-09 Thread Yakir Yang
Signed-off-by: Yakir Yang --- Changes in v3: - Suggested by Sean Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 3 ++- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 18 +- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH v3 3/3] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
Make sure the request PSR state takes effect in analogix_dp_send_psr_spd() function, or print the sink PSR error state if we failed to apply the requested PSR setting. Signed-off-by: Yakir Yang --- Changes in v3: - Update commit message - Add DP_TIMEOUT_PSR_LOOP_MS marcos - Correct the return

Re: [PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
On 09/08/2016 10:12 PM, Sean Paul wrote: On Wed, Sep 7, 2016 at 11:48 PM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting.

Re: [PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-09 Thread Yakir Yang
On 09/08/2016 10:12 PM, Sean Paul wrote: On Wed, Sep 7, 2016 at 11:48 PM, Yakir Yang wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Let's change to: Make sure

[PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-07 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: - A bunch of good fixes from Sean drivers/gpu/drm/

[PATCH v2 2/2] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-07 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang --- Changes in v2: - A bunch of good fixes from Sean drivers/gpu/drm/bridge/analogix

[PATCH v2 1/2] drm/bridge: analogix_dp: Remove duplicated code v2

2016-09-07 Thread Yakir Yang
nstead of duplicating them. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter <daniel.vet...@intel.com> Reviewed-by: Sean P

[PATCH v2 1/2] drm/bridge: analogix_dp: Remove duplicated code v2

2016-09-07 Thread Yakir Yang
-by: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter Reviewed-by: Sean Paul Reviewed-by: Yakir Yang Tested-by: Javier Martinez Canillas Tested-by: Sean Paul --- Changes in v2: - A bunch of good fixes from Sean and Yakir - Moved the transfer function

Re: [PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-06 Thread Yakir Yang
Sean, Thanks for your comments. On 09/07/2016 03:51 AM, Sean Paul wrote: On Fri, Aug 26, 2016 at 6:19 AM, Yakir Yang <y...@rock-chips.com> wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to

Re: [PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-09-06 Thread Yakir Yang
Sean, Thanks for your comments. On 09/07/2016 03:51 AM, Sean Paul wrote: On Fri, Aug 26, 2016 at 6:19 AM, Yakir Yang wrote: Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting

[PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-08-26 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 ++--- drive

[PATCH] drm/bridge: analogix_dp: detect Sink PSR state after configuring the PSR

2016-08-26 Thread Yakir Yang
Make sure the request PSR state could effect in analogix_dp_send_psr_spd() function, or printing the error Sink PSR state if we failed to effect the request PSR setting. Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 6 ++--- drivers/gpu/drm/bridge/analogix

Re: [PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-08-17 Thread Yakir Yang
Hello Archit, On 08/17/2016 01:41 PM, Archit Taneja wrote: Hi, On 07/24/2016 12:27 PM, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-08-17 Thread Yakir Yang
Hello Archit, On 08/17/2016 01:41 PM, Archit Taneja wrote: Hi, On 07/24/2016 12:27 PM, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-08 Thread Yakir Yang
accidentally turn the panel off at the wrong time. Signed-off-by: Sean Paul <seanp...@chromium.org> Reviewed-by: Yakir Yang <y...@rock-chips.com> And I also tested this patch on RK3399 Kevin board, panel works rightly, so: Tested-by: Yakir Yang <y...@rock-chips.com> Also add Archit i

Re: [PATCH v2] drm/bridge: analogix_dp: Ensure the panel is properly prepared/unprepared

2016-08-08 Thread Yakir Yang
accidentally turn the panel off at the wrong time. Signed-off-by: Sean Paul Reviewed-by: Yakir Yang And I also tested this patch on RK3399 Kevin board, panel works rightly, so: Tested-by: Yakir Yang Also add Archit into CC list, guess this patch should go through his drm_bridge's tree. Thanks

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Yakir Yang
+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang <y...@rock-chips.com> I guess this patch should go through Archit's drm_

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code v2

2016-08-08 Thread Yakir Yang
+ Archit Tomeu, Thanks for the update :-) But you have missed three tiny align problems, please see my inline notes, wish you could fix them. After that this patch looks good to me, so: Reviewed-by: Yakir Yang I guess this patch should go through Archit's drm_bridge tree, so I added him

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
gt; Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter <daniel.vet...@intel.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 390 +++-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 39 +-- d

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
. Besides the obvious code reduction, other helpers are being added to the core that could be used in this driver and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Mika Kahola <mika.kah...@intel.com> Cc: Yakir Yang <y...@rock-chips.com> Cc: Daniel Vetter

Re: [PATCH] drm/bridge: analogix_dp: Remove duplicated code

2016-08-05 Thread Yakir Yang
and will be good to be able to use them instead of duplicating them. Signed-off-by: Tomeu Vizoso Cc: Javier Martinez Canillas Cc: Mika Kahola Cc: Yakir Yang Cc: Daniel Vetter --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 390 +++-- drivers/gpu/drm/bridge/analogix

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-03 Thread Yakir Yang
"efc9194 ASoC: hdmi-codec: callback function will be called with private data", the hdmi_codec_ops had some changes. Can you rebase your patch to the newest kernel? Thanks. On 2016年06月15日 21:28, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function.

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-03 Thread Yakir Yang
"efc9194 ASoC: hdmi-codec: callback function will be called with private data", the hdmi_codec_ops had some changes. Can you rebase your patch to the newest kernel? Thanks. On 2016年06月15日 21:28, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function.

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-01 Thread Yakir Yang
Hi Mark & Heiko, Ping.. Thanks, - Yakir On 06/15/2016 09:28 PM, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/rockchip/inno_hd

Re: [PATCH 1/3] drm/rockchip: inno_hdmi: add audio support

2016-08-01 Thread Yakir Yang
Hi Mark & Heiko, Ping.. Thanks, - Yakir On 06/15/2016 09:28 PM, Yakir Yang wrote: Using the common hdmi-codec driver to support hdmi audio function. Signed-off-by: Yakir Yang --- drivers/gpu/drm/rockchip/inno_hdmi.c | 237 ++- drivers/gpu/drm/rock

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH] drm/analogix_dp: Ensure the panel is properly prepared/unprepared

2016-07-31 Thread Yakir Yang
Sean, On 07/30/2016 03:16 AM, Sean Paul wrote: Instead of just preparing the panel on bind, actually prepare/unprepare during modeset/disable. The panel must be prepared in order to read hpd status, so we need to refcount the prepares in order to ensure we don't accidentally turn the panel off

Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver

2016-07-31 Thread Yakir Yang
On 07/29/2016 04:38 PM, Tomeu Vizoso wrote: On 5 April 2016 at 04:06, Yakir Yang <y...@rock-chips.com> wrote: Hi Daniel, On 03/31/2016 06:15 PM, Daniel Vetter wrote: On Mon, Feb 15, 2016 at 07:08:05PM +0800, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Ro

Re: [PATCH v14 0/17] Add Analogix Core Display Port Driver

2016-07-31 Thread Yakir Yang
On 07/29/2016 04:38 PM, Tomeu Vizoso wrote: On 5 April 2016 at 04:06, Yakir Yang wrote: Hi Daniel, On 03/31/2016 06:15 PM, Daniel Vetter wrote: On Mon, Feb 15, 2016 at 07:08:05PM +0800, Yakir Yang wrote: Hi all, The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller

Re: [PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-27 Thread Yakir Yang
Sean, Oops, sorry about miss your suggest :( On 07/22/2016 11:03 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:00 PM, Yakir Yang <y...@rock-chips.com> wrote: Sean, Thanks for your fast respond :-) But this patch is not the latest one, I have upgraded this to "v1.1" versio

Re: [PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-27 Thread Yakir Yang
Sean, Oops, sorry about miss your suggest :( On 07/22/2016 11:03 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:00 PM, Yakir Yang wrote: Sean, Thanks for your fast respond :-) But this patch is not the latest one, I have upgraded this to "v1.1" version to fix the eDP can't b

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Doug, On 07/23/2016 12:04 PM, Doug Anderson wrote: Yakir, On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang <y...@rock-chips.com> wrote: +static void psr_set_state(struct psr_drv *psr, enum psr_state state) +{ + mutex_lock(>state_mutex); + + if (psr->st

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
Doug, On 07/23/2016 12:04 PM, Doug Anderson wrote: Yakir, On Wed, Jul 13, 2016 at 9:15 PM, Yakir Yang wrote: +static void psr_set_state(struct psr_drv *psr, enum psr_state state) +{ + mutex_lock(>state_mutex); + + if (psr->state == state) { + mutex_

[PATCH v5 1/4] drm/rockchip: vop: export line flag function

2016-07-24 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sea

[PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-24 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v5: - Add reviewed flag from Sean. Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Se

[PATCH v5 1/4] drm/rockchip: vop: export line flag function

2016-07-24 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang Reviewed-by: Sean Paul --- Changes in v5

[PATCH v5 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-24 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang Reviewed-by: Sean Paul --- Changes in v5: - Add reviewed flag from Sean. Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Sean) - Remove PSR_VID_CRC_FLUSH setting

[PATCH v5 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
the encoder registered callback to set the PSR state. Fb driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v5: - Only keep 'psr_l

[PATCH v5 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-24 Thread Yakir Yang
river. Changes in v2: - Introduce in v2, split VOP line flag changes out - introduce in v2, splite the common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip

[PATCH v5 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-24 Thread Yakir Yang
the encoder registered callback to set the PSR state. Fb driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang --- Changes in v5: - Only keep 'psr_list_mutex' at register/unregis

[PATCH v5 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-24 Thread Yakir Yang
river. Changes in v2: - Introduce in v2, split VOP line flag changes out - introduce in v2, splite the common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip

[PATCH v5 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-24 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v5: - Add reviewed flag from Se

[PATCH v5 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-24 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang Reviewed-by: Sean Paul --- Changes in v5: - Add reviewed flag from Sean. Changes in v4: - Return 'void' instead of 'int

[PATCH v2 2/3] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: - s/Panle/Panel/ (Sean) - Move the drm_panel_ out of a conditional, and throw the return code away (Sean) - Add comments about why we need unprepare

[PATCH v2 3/3] drm/bridge: analogix_dp: remove the panel prepare/unprepare in suspend/resume

2016-07-21 Thread Yakir Yang
We already manager the panel power status in bridge_disable and connector->detect functions, then we don't need to manager the panel power status at suspend/resume in particular. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v2: None drivers/gpu/drm/bridge

[PATCH v2 2/3] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- Changes in v2: - s/Panle/Panel/ (Sean) - Move the drm_panel_ out of a conditional, and throw the return code away (Sean) - Add comments about why we need unprepare the panel in bridge_disable (S

[PATCH v2 3/3] drm/bridge: analogix_dp: remove the panel prepare/unprepare in suspend/resume

2016-07-21 Thread Yakir Yang
We already manager the panel power status in bridge_disable and connector->detect functions, then we don't need to manager the panel power status at suspend/resume in particular. Signed-off-by: Yakir Yang --- Changes in v2: None drivers/gpu/drm/bridge/analogix/analogix_dp_core.c |

[PATCH v2 1/3] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> --- Changes in v2: - Add the reviewed tag from Sean. drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm

[PATCH v2 1/3] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang Reviewed-by: Sean Paul --- Changes in v2: - Add the reviewed tag from Sean. drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644

Re: [PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
Sean, On 07/21/2016 10:30 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang <y...@rock-chips.com> wrote: According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus t3 (0ms~100ms), and

Re: [PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
Sean, On 07/21/2016 10:30 PM, Sean Paul wrote: On Thu, Jul 21, 2016 at 9:14 AM, Yakir Yang wrote: According to page 16 of Sharp LQ123P1JX31 datasheet, we need to add the missing delay timing. Panel prepare time should be t1 (0.5ms~10ms) plus t3 (0ms~100ms), and panel enable time should equal

[PATCH v1.1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v1.1: - unprepare the panel at the end of bridge->disable() function drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +++--- 1 file

[PATCH v1.1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- Changes in v1.1: - unprepare the panel at the end of bridge->disable() function drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +++--- 1 file changed, 15 insertions(+), 7 del

[PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_

[PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable

2016-07-21 Thread Yakir Yang
ect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/

[PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang <y...@rock-chips.com> --- drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drive

[PATCH v1 1/2] drm/panel: simple-panel: add the delay timing for Sharp LQ123P1JX31

2016-07-21 Thread Yakir Yang
-by: Yakir Yang --- drivers/gpu/drm/panel/panel-simple.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..f178998 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel

Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

2016-07-18 Thread Yakir Yang
Thierry, On 07/08/2016 05:57 AM, Thierry Reding wrote: On Thu, Jul 07, 2016 at 11:55:23PM +0200, Thierry Reding wrote: On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote: The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel connected using eDP interfaces. Signe

Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding

2016-07-18 Thread Yakir Yang
Thierry, On 07/08/2016 05:57 AM, Thierry Reding wrote: On Thu, Jul 07, 2016 at 11:55:23PM +0200, Thierry Reding wrote: On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote: The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel connected using eDP interfaces. Signe

Re: [PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:13 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 06:55:17PM +0800, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:13 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 06:55:17PM +0800, Yakir Yang wrote: The full name of PSR is Panel Self Refresh, panel device could refresh itself with the hardware framebuffer in panel, this would make lots of sense to save the power consumption

Re: [PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:04 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 6:55 AM, Yakir Yang <y...@rock-chips.com> wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line

Re: [PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
Sean, On 07/15/2016 09:04 PM, Sean Paul wrote: On Fri, Jul 15, 2016 at 6:55 AM, Yakir Yang wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line number to vop line_flag register

[PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes i

[PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Sean) - Remove PSR_VID_CRC_FLUSH setting analogix_dp_enable_psr_crc(). - Add comment about PBx magic numbers.

[PATCH v4.1 1/4] drm/rockchip: vop: export line flag function

2016-07-15 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang --- Changes in v4.1: - Remove

[PATCH v4.1 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-15 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang --- Changes in v4.1: - Take use of existing edp_psr_vsc struct to swap HBx and DBx setting. (Sean) - Remove PSR_VID_CRC_FLUSH setting analogix_dp_enable_psr_crc(). - Add comment about PBx magic numbers. (Sean) Changes in v4

Re: [PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:26 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:58PM +0800, Yakir Yang wrote: Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@r

Re: [PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:26 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:58PM +0800, Yakir Yang wrote: Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang Reviewed

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 11:14 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:49PM +0800, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister() - rockchip_drm_psr_enable() - rockchip_drm_psr_disable

Re: [PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 10:46 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:44PM +0800, Yakir Yang wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line number to vop line_flag

Re: [PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-14 Thread Yakir Yang
Sean, On 07/14/2016 10:46 PM, Sean Paul wrote: On Thu, Jul 14, 2016 at 12:15:44PM +0800, Yakir Yang wrote: VOP have integrated a hardware counter which indicate the exact display line that vop is scanning. And if we're interested in a specific line, we can set the line number to vop line_flag

[PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-13 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Return 'void' instead of 'int' in analogix_dp_psr_set(). (Sean) - Pull th

[PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-13 Thread Yakir Yang
driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Tuck the global "psr_list" & "psr_list_mutex&quo

[PATCH v4 4/4] drm/rockchip: analogix_dp: implement PSR function

2016-07-13 Thread Yakir Yang
Alway enable the PSR function for Rockchip analogix_dp driver. If panel don't support PSR, then the core analogix_dp would ignore this setting. Signed-off-by: Yakir Yang --- Changes in v4: - Return 'void' instead of 'int' in analogix_dp_psr_set(). (Sean) - Pull the 10ms delay time out

[PATCH v4 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-13 Thread Yakir Yang
driver would call the flush interface in 'fb->dirty' callback, this helper function would force all PSR enabled encoders to exit from PSR for 3 seconds. Signed-off-by: Yakir Yang --- Changes in v4: - Tuck the global "psr_list" & "psr_list_mutex" in struct rockchip_

[PATCH v4 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-13 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes in v4: - Downgrade the PSR version print message to debug level. (Sean) - Return 'void' instead of 'int' in analogix_dp_enable_sink_psr(). (Sean) - Delete the unused read dpcd oper

[PATCH v4 3/4] drm/bridge: analogix_dp: add the PSR function support

2016-07-13 Thread Yakir Yang
: - analogix_dp_active_psr() - analogix_dp_inactive_psr() Signed-off-by: Yakir Yang --- Changes in v4: - Downgrade the PSR version print message to debug level. (Sean) - Return 'void' instead of 'int' in analogix_dp_enable_sink_psr(). (Sean) - Delete the unused read dpcd operations in analogix_dp_enable_sink_psr

[PATCH v4 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-13 Thread Yakir Yang
common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip: add an common abstracted PSR driver drm/bridge: analogix_dp: add the PSR function support drm

[PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-13 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang <y...@rock-chips.com> --- Changes

[PATCH v4 0/4] Add PSR function support for Analogix/Rockchip DP

2016-07-13 Thread Yakir Yang
common Analogix DP changes out - remove vblank notify out (Daniel) - create a psr_active() callback in vop data struct. Yakir Yang (4): drm/rockchip: vop: export line flag function drm/rockchip: add an common abstracted PSR driver drm/bridge: analogix_dp: add the PSR function support drm

[PATCH v4 1/4] drm/rockchip: vop: export line flag function

2016-07-13 Thread Yakir Yang
in the vertical blanking period, then driver could set the line number to zero. This patch have exported a symbol that allow other driver to listen the line flag event with given timeout limit: - rockchip_drm_wait_line_flag() Signed-off-by: Yakir Yang --- Changes in v4: - Avoid the weird

Re: [PATCH v1 5/6] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

2016-07-13 Thread Yakir Yang
Heiko, On 07/12/2016 10:27 PM, Heiko Stübner wrote: Hi Yakir, Am Montag, 11. Juli 2016, 19:05:49 schrieb Yakir Yang: For RK3399 HDMI, there is an external clock need for HDMI PHY, and it should keep the same clock rate with VOP DCLK. VPLL have supported the clock for HDMI PHY

Re: [PATCH v1 5/6] drm/rockchip: dw_hdmi: introduce the VPLL clock setting

2016-07-13 Thread Yakir Yang
Heiko, On 07/12/2016 10:27 PM, Heiko Stübner wrote: Hi Yakir, Am Montag, 11. Juli 2016, 19:05:49 schrieb Yakir Yang: For RK3399 HDMI, there is an external clock need for HDMI PHY, and it should keep the same clock rate with VOP DCLK. VPLL have supported the clock for HDMI PHY

Re: [PATCH v1 4/6] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2016-07-13 Thread Yakir Yang
Philipp, On 07/11/2016 07:51 PM, Philipp Zabel wrote: Am Montag, den 11.07.2016, 19:05 +0800 schrieb Yakir Yang: RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang <y...@rock-chips.com> Reviewed-by: Philipp

Re: [PATCH v1 4/6] drm/rockchip: dw_hdmi: add RK3399 HDMI support

2016-07-13 Thread Yakir Yang
Philipp, On 07/11/2016 07:51 PM, Philipp Zabel wrote: Am Montag, den 11.07.2016, 19:05 +0800 schrieb Yakir Yang: RK3399 and RK3288 shared the same HDMI IP controller, only some light difference with GRF configure. Signed-off-by: Yakir Yang Reviewed-by: Philipp Zabel Thanks for your fast

Re: [PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-12 Thread Yakir Yang
Daniel, On 07/12/2016 08:38 PM, Daniel Vetter wrote: On Fri, Jul 01, 2016 at 02:00:00PM -0400, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang <y...@rock-chips.com> wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_re

Re: [PATCH v3 2/4] drm/rockchip: add an common abstracted PSR driver

2016-07-12 Thread Yakir Yang
Daniel, On 07/12/2016 08:38 PM, Daniel Vetter wrote: On Fri, Jul 01, 2016 at 02:00:00PM -0400, Sean Paul wrote: On Fri, Jul 1, 2016 at 5:19 AM, Yakir Yang wrote: The PSR driver have exported four symbols for specific device driver: - rockchip_drm_psr_register() - rockchip_drm_psr_unregister

  1   2   3   4   5   6   7   8   9   10   >