Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-17 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/17/05, Alan Stern <[EMAIL PROTECTED]> wrote: > On Tue, 16 Aug 2005, Dmitry Torokhov wrote: > > > Alan, > > > > I am sorry I don't have time to properly review the patch at > > themoment, just a couple of comments about serio - I would not look at > > serio for examples of typical use as

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-17 Thread Alan Stern
On Tue, 16 Aug 2005, Dmitry Torokhov wrote: > Alan, > > I am sorry I don't have time to properly review the patch at > themoment, just a couple of comments about serio - I would not look at > serio for examples of typical use as it was trying very hard to work > around the original driver model

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-17 Thread Alan Stern
On Tue, 16 Aug 2005, Dmitry Torokhov wrote: Alan, I am sorry I don't have time to properly review the patch at themoment, just a couple of comments about serio - I would not look at serio for examples of typical use as it was trying very hard to work around the original driver model

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-17 Thread Bartlomiej Zolnierkiewicz
Hi, On 8/17/05, Alan Stern [EMAIL PROTECTED] wrote: On Tue, 16 Aug 2005, Dmitry Torokhov wrote: Alan, I am sorry I don't have time to properly review the patch at themoment, just a couple of comments about serio - I would not look at serio for examples of typical use as it was trying

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-16 Thread Dmitry Torokhov
On 8/15/05, Alan Stern <[EMAIL PROTECTED]> wrote: > On the face of it, neither is particularly more attractive than the other. > However, reading through the various places that call these routines (for > example, drivers/input/serio/serio.c or drivers/pnp/card.c) revealed a > pattern. In most

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-16 Thread Dmitry Torokhov
On 8/15/05, Alan Stern [EMAIL PROTECTED] wrote: On the face of it, neither is particularly more attractive than the other. However, reading through the various places that call these routines (for example, drivers/input/serio/serio.c or drivers/pnp/card.c) revealed a pattern. In most cases,

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-15 Thread Alan Stern
Dmitry, Pat, Greg, and everyone else: This is a revised version of the patch I sent in last week -- not yet a submission, more of an RFC. It turns out that removing the driver's list of bound devices isn't practical, because there are times when a device not yet on the bus's overall klist will

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-15 Thread Alan Stern
Dmitry, Pat, Greg, and everyone else: This is a revised version of the patch I sent in last week -- not yet a submission, more of an RFC. It turns out that removing the driver's list of bound devices isn't practical, because there are times when a device not yet on the bus's overall klist will

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-12 Thread Alan Stern
On Thu, 11 Aug 2005, Dmitry Torokhov wrote: > Hmm, so what do I do in the following scenario - I have a serio port > (AUX) that has a synaptics touchpad bound to it which is driven by > psmouse driver. psmouse driver registers a child port (synaptics > pass-through) during probe call. The child

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-12 Thread Alan Stern
On Thu, 11 Aug 2005, Dmitry Torokhov wrote: Hmm, so what do I do in the following scenario - I have a serio port (AUX) that has a synaptics touchpad bound to it which is driven by psmouse driver. psmouse driver registers a child port (synaptics pass-through) during probe call. The child port

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Alan Stern
On Thu, 11 Aug 2005, Dmitry Torokhov wrote: > Hmm, so what do I do in the following scenario - I have a serio port > (AUX) that has a synaptics touchpad bound to it which is driven by > psmouse driver. psmouse driver registers a child port (synaptics > pass-through) during probe call. The child

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Dmitry Torokhov
On 8/11/05, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 11 Aug 2005, Christoph Hellwig wrote: > > > On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: > > > > This patch (as536) simplifies the driver-model core by replacing the > > > > klist > > > > used to store the set of devices

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Alan Stern
On Thu, 11 Aug 2005, Christoph Hellwig wrote: > On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: > > > This patch (as536) simplifies the driver-model core by replacing the > > > klist > > > used to store the set of devices bound to a driver with a regular list > > > protected by a

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: > > This patch (as536) simplifies the driver-model core by replacing the klist > > used to store the set of devices bound to a driver with a regular list > > protected by a mutex. It turns out that even with a klist, there are too > >

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Greg KH
On Wed, Aug 10, 2005 at 04:56:08PM -0400, Alan Stern wrote: > Greg and Pat: > > This patch (as536) simplifies the driver-model core by replacing the klist > used to store the set of devices bound to a driver with a regular list > protected by a mutex. It turns out that even with a klist, there

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Greg KH
On Wed, Aug 10, 2005 at 04:56:08PM -0400, Alan Stern wrote: Greg and Pat: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver with a regular list protected by a mutex. It turns out that even with a klist, there are

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver with a regular list protected by a mutex. It turns out that even with a klist, there are too many

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Alan Stern
On Thu, 11 Aug 2005, Christoph Hellwig wrote: On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver with a regular list protected by a mutex. It turns

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Dmitry Torokhov
On 8/11/05, Alan Stern [EMAIL PROTECTED] wrote: On Thu, 11 Aug 2005, Christoph Hellwig wrote: On Thu, Aug 11, 2005 at 11:24:23AM -0700, Greg KH wrote: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver

Re: [PATCH] Don't use a klist for drivers' set-of-devices

2005-08-11 Thread Alan Stern
On Thu, 11 Aug 2005, Dmitry Torokhov wrote: Hmm, so what do I do in the following scenario - I have a serio port (AUX) that has a synaptics touchpad bound to it which is driven by psmouse driver. psmouse driver registers a child port (synaptics pass-through) during probe call. The child port

[PATCH] Don't use a klist for drivers' set-of-devices

2005-08-10 Thread Alan Stern
Greg and Pat: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver with a regular list protected by a mutex. It turns out that even with a klist, there are too many opportunities for races for the list to be used safely

[PATCH] Don't use a klist for drivers' set-of-devices

2005-08-10 Thread Alan Stern
Greg and Pat: This patch (as536) simplifies the driver-model core by replacing the klist used to store the set of devices bound to a driver with a regular list protected by a mutex. It turns out that even with a klist, there are too many opportunities for races for the list to be used safely