Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-24 Thread Gregory CLEMENT
Hi Pali, > On Tuesday 08 September 2020 09:47:33 Pali Rohár wrote: >> On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: >> > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: >> > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: >> > > > > I would not say it is a "new

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-23 Thread Pali Rohár
On Tuesday 08 September 2020 09:47:33 Pali Rohár wrote: > On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: > > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: > > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > > > > I would not say it is a "new feature". But

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-23 Thread Gregory CLEMENT
Hello Pali, > Espressobin boards have 3 ethernet ports and some of them got assigned more > then one MAC address. MAC addresses are stored in U-Boot environment. > > Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave > device") kernel can use MAC addresses from DT for

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-08 Thread Pali Rohár
On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > > > I would not say it is a "new feature". But rather that patch in this > > > > email fixes issue that Linux kernel

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andrew Lunn
> As a result of this cleanup should be binary DTB file for V7 with same > structure as DTB file without such cleanup patch, right? Should be. If need be, you can decompile the DTB back to a DTS and make sure it looks correct. Andrew

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andre Heider
On 07/09/2020 19:47, Pali Rohár wrote: On Monday 07 September 2020 19:43:08 Andre Heider wrote: On 07/09/2020 19:35, Pali Rohár wrote: On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: My dts-foo is a little rusty, but now that you labeled the ports in the .dtsi, can this whole

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:43:08 Andre Heider wrote: > On 07/09/2020 19:35, Pali Rohár wrote: > > On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: > > > > My dts-foo is a little rusty, but now that you labeled the ports in the > > > > .dtsi, can this whole "switch0" block reduced to

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andre Heider
On 07/09/2020 19:42, Pali Rohár wrote: On Monday 07 September 2020 19:13:41 Andre Heider wrote: @@ -120,7 +124,7 @@ #address-cells = <1>; #size-cells = <0>; - port@0 { + switch0port0: port@0 { This

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andre Heider
On 07/09/2020 19:35, Pali Rohár wrote: On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: My dts-foo is a little rusty, but now that you labeled the ports in the .dtsi, can this whole "switch0" block reduced to something like: { label = "lan1"; }; { label = "wan"; };

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:13:41 Andre Heider wrote: > > @@ -120,7 +124,7 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > - port@0 { > > + switch0port0: port@0 { > > This label is unused it seems. Yes, it is

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: > > My dts-foo is a little rusty, but now that you labeled the ports in the > > .dtsi, can this whole "switch0" block reduced to something like: > > > > { > > label = "lan1"; > > }; > > > > { > > label = "wan"; > > }; > >

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andrew Lunn
> My dts-foo is a little rusty, but now that you labeled the ports in the > .dtsi, can this whole "switch0" block reduced to something like: > > { > label = "lan1"; > }; > > { > label = "wan"; > }; Probably yes. But that is definitely too much for stable. Andrew

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andrew Lunn
On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > > I would not say it is a "new feature". But rather that patch in this > > > email fixes issue that Linux kernel did not set correct MAC address for > > > DSA slave ports. I

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andre Heider
Hi Pali, On 07/09/2020 13:27, Pali Rohár wrote: Espressobin boards have 3 ethernet ports and some of them got assigned more then one MAC address. MAC addresses are stored in U-Boot environment. Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave device") kernel can use

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > I would not say it is a "new feature". But rather that patch in this > > email fixes issue that Linux kernel did not set correct MAC address for > > DSA slave ports. I think it is something which could be backported also > > to stable

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andrew Lunn
> I would not say it is a "new feature". But rather that patch in this > email fixes issue that Linux kernel did not set correct MAC address for > DSA slave ports. I think it is something which could be backported also > to stable releases as "ignoring" vendor/factory MAC address is not > correct

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Andrew Lunn
On Mon, Sep 07, 2020 at 01:27:17PM +0200, Pali Rohár wrote: > Espressobin boards have 3 ethernet ports and some of them got assigned more > then one MAC address. MAC addresses are stored in U-Boot environment. > > Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave >

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 16:42:28 Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 01:27:17PM +0200, Pali Rohár wrote: > > Espressobin boards have 3 ethernet ports and some of them got assigned more > > then one MAC address. MAC addresses are stored in U-Boot environment. > > > > Since commit

[PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
Espressobin boards have 3 ethernet ports and some of them got assigned more then one MAC address. MAC addresses are stored in U-Boot environment. Since commit a2c7023f7075c ("net: dsa: read mac address from DT for slave device") kernel can use MAC addresses from DT for particular DSA port.