Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-05-17 Thread Petr Mladek
On Mon 2017-05-08 15:37:41, Sergey Senozhatsky wrote: > Hello, > > On (04/07/17 10:40), Steven Rostedt wrote: > [..] > > On Fri, 7 Apr 2017 14:44:55 +0200 > > Pavel Machek wrote: > > > > > Well, I have to agree here. This is 20 years worth of mess :-(. > > > > Maybe someone

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-05-17 Thread Petr Mladek
On Mon 2017-05-08 15:37:41, Sergey Senozhatsky wrote: > Hello, > > On (04/07/17 10:40), Steven Rostedt wrote: > [..] > > On Fri, 7 Apr 2017 14:44:55 +0200 > > Pavel Machek wrote: > > > > > Well, I have to agree here. This is 20 years worth of mess :-(. > > > > Maybe someone should propose a

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-05-08 Thread Sergey Senozhatsky
Hello, On (04/07/17 10:40), Steven Rostedt wrote: [..] > On Fri, 7 Apr 2017 14:44:55 +0200 > Pavel Machek wrote: > > > Well, I have to agree here. This is 20 years worth of mess :-(. > > Maybe someone should propose a micro-conf at Linux Plumbers where we > can brain storm a way

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-05-08 Thread Sergey Senozhatsky
Hello, On (04/07/17 10:40), Steven Rostedt wrote: [..] > On Fri, 7 Apr 2017 14:44:55 +0200 > Pavel Machek wrote: > > > Well, I have to agree here. This is 20 years worth of mess :-(. > > Maybe someone should propose a micro-conf at Linux Plumbers where we > can brain storm a way to re-invent

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Sergey Senozhatsky
Hello Petr, thanks for taking a look! On (04/13/17 16:03), Petr Mladek wrote: > > +static inline bool console_offload_printing(void) > > +{ > > + static struct task_struct *printing_task = NULL; > > + static unsigned long lines_printed = 0; > > + > > + if (!atomic_print_limit ||

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Sergey Senozhatsky
Hello Petr, thanks for taking a look! On (04/13/17 16:03), Petr Mladek wrote: > > +static inline bool console_offload_printing(void) > > +{ > > + static struct task_struct *printing_task = NULL; > > + static unsigned long lines_printed = 0; > > + > > + if (!atomic_print_limit ||

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Petr Mladek
On Wed 2017-04-12 01:19:53, Sergey Senozhatsky wrote: > On (04/11/17 10:46), Sergey Senozhatsky wrote: > > On (04/10/17 20:48), Pavel Machek wrote: > > [..] > > > > but, once again, I see your point. > > > > > > Good. Does that mean that the next version of patches will work ok in > > > that

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Petr Mladek
On Wed 2017-04-12 01:19:53, Sergey Senozhatsky wrote: > On (04/11/17 10:46), Sergey Senozhatsky wrote: > > On (04/10/17 20:48), Pavel Machek wrote: > > [..] > > > > but, once again, I see your point. > > > > > > Good. Does that mean that the next version of patches will work ok in > > > that

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Sergey Senozhatsky
On (04/13/17 14:50), Sergey Senozhatsky wrote: [..] > On (04/12/17 01:19), Sergey Senozhatsky wrote: > [..] > > it does offloading after X printed lines by the same process. > > if we reschedule, then the counter resets. which is probably OK, > > we don't really want any process, except for

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-13 Thread Sergey Senozhatsky
On (04/13/17 14:50), Sergey Senozhatsky wrote: [..] > On (04/12/17 01:19), Sergey Senozhatsky wrote: > [..] > > it does offloading after X printed lines by the same process. > > if we reschedule, then the counter resets. which is probably OK, > > we don't really want any process, except for

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Sergey Senozhatsky
On (04/12/17 01:19), Sergey Senozhatsky wrote: [..] > it does offloading after X printed lines by the same process. > if we reschedule, then the counter resets. which is probably OK, > we don't really want any process, except for printk_kthread, to > stay in console_unlock() forever. may be this

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Sergey Senozhatsky
On (04/12/17 01:19), Sergey Senozhatsky wrote: [..] > it does offloading after X printed lines by the same process. > if we reschedule, then the counter resets. which is probably OK, > we don't really want any process, except for printk_kthread, to > stay in console_unlock() forever. may be this

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Sergey Senozhatsky
On (04/12/17 20:43), Pavel Machek wrote: [..] > > when the limit of "number of lines printed" is 0, then no > > offloading takes place. > > And with "number of lines printed" set to 99, it will get us > previous behaviour, right? `atomic_print_limit' set to zero disables offloading

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Sergey Senozhatsky
On (04/12/17 20:43), Pavel Machek wrote: [..] > > when the limit of "number of lines printed" is 0, then no > > offloading takes place. > > And with "number of lines printed" set to 99, it will get us > previous behaviour, right? `atomic_print_limit' set to zero disables offloading

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Pavel Machek
On Wed 2017-04-12 01:19:53, Sergey Senozhatsky wrote: > On (04/11/17 10:46), Sergey Senozhatsky wrote: > > On (04/10/17 20:48), Pavel Machek wrote: > > [..] > > > > but, once again, I see your point. > > > > > > Good. Does that mean that the next version of patches will work ok in > > > that

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-12 Thread Pavel Machek
On Wed 2017-04-12 01:19:53, Sergey Senozhatsky wrote: > On (04/11/17 10:46), Sergey Senozhatsky wrote: > > On (04/10/17 20:48), Pavel Machek wrote: > > [..] > > > > but, once again, I see your point. > > > > > > Good. Does that mean that the next version of patches will work ok in > > > that

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-11 Thread Sergey Senozhatsky
On (04/11/17 10:46), Sergey Senozhatsky wrote: > On (04/10/17 20:48), Pavel Machek wrote: > [..] > > > but, once again, I see your point. > > > > Good. Does that mean that the next version of patches will work ok in > > that case? > > yes. ok... so I'm looking at something like below right now.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-11 Thread Sergey Senozhatsky
On (04/11/17 10:46), Sergey Senozhatsky wrote: > On (04/10/17 20:48), Pavel Machek wrote: > [..] > > > but, once again, I see your point. > > > > Good. Does that mean that the next version of patches will work ok in > > that case? > > yes. ok... so I'm looking at something like below right now.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Sergey Senozhatsky
On (04/10/17 20:48), Pavel Machek wrote: [..] > > but, once again, I see your point. > > Good. Does that mean that the next version of patches will work ok in > that case? yes. we also likely will get rid of printk_begin/end in PM code. but we still need to have printk_emergency hints from the

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Sergey Senozhatsky
On (04/10/17 20:48), Pavel Machek wrote: [..] > > but, once again, I see your point. > > Good. Does that mean that the next version of patches will work ok in > that case? yes. we also likely will get rid of printk_begin/end in PM code. but we still need to have printk_emergency hints from the

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Pavel Machek
On Mon 2017-04-10 13:53:39, Sergey Senozhatsky wrote: > On (04/09/17 12:12), Pavel Machek wrote: > [..] > > > a side note, > > > that's rather unclear to me how would "message delayed" really help. > > > if your system hard-lockup so badly and there are no printk messages > > > even from NMI

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Pavel Machek
On Mon 2017-04-10 13:53:39, Sergey Senozhatsky wrote: > On (04/09/17 12:12), Pavel Machek wrote: > [..] > > > a side note, > > > that's rather unclear to me how would "message delayed" really help. > > > if your system hard-lockup so badly and there are no printk messages > > > even from NMI

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Sergey Senozhatsky
On (04/10/17 13:54), Petr Mladek wrote: [..] > > > that works with my proposal, but not with yours. Seen it happen many > > > times before. > > > > I see your point, sure. > > I can't completely agree on "that works with my proposal, but not with > > yours." > > > > on SMP system this would be

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Sergey Senozhatsky
On (04/10/17 13:54), Petr Mladek wrote: [..] > > > that works with my proposal, but not with yours. Seen it happen many > > > times before. > > > > I see your point, sure. > > I can't completely agree on "that works with my proposal, but not with > > yours." > > > > on SMP system this would be

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Petr Mladek
On Mon 2017-04-10 13:53:39, Sergey Senozhatsky wrote: > On (04/09/17 12:12), Pavel Machek wrote: > [..] > > > a side note, > > > that's rather unclear to me how would "message delayed" really help. > > > if your system hard-lockup so badly and there are no printk messages > > > even from NMI

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-10 Thread Petr Mladek
On Mon 2017-04-10 13:53:39, Sergey Senozhatsky wrote: > On (04/09/17 12:12), Pavel Machek wrote: > [..] > > > a side note, > > > that's rather unclear to me how would "message delayed" really help. > > > if your system hard-lockup so badly and there are no printk messages > > > even from NMI

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Sergey Senozhatsky
On (04/09/17 12:12), Pavel Machek wrote: [..] > > a side note, > > that's rather unclear to me how would "message delayed" really help. > > if your system hard-lockup so badly and there are no printk messages > > even from NMI watchdog, then we won't be able to print that message. > > We are

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Sergey Senozhatsky
On (04/09/17 12:12), Pavel Machek wrote: [..] > > a side note, > > that's rather unclear to me how would "message delayed" really help. > > if your system hard-lockup so badly and there are no printk messages > > even from NMI watchdog, then we won't be able to print that message. > > We are

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Sergey Senozhatsky
Hello Eric, On (04/09/17 13:21), Eric W. Biederman wrote: [..] > It sounds like you are blaming printk when the problem is a very slow > logging device. sure, slow logging device definitely adds up to the problem. if there is no delay in call_console_driver() then printk()->console_unlock() take

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Sergey Senozhatsky
Hello Eric, On (04/09/17 13:21), Eric W. Biederman wrote: [..] > It sounds like you are blaming printk when the problem is a very slow > logging device. sure, slow logging device definitely adds up to the problem. if there is no delay in call_console_driver() then printk()->console_unlock() take

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Eric W. Biederman
Sergey Senozhatsky writes: > On (04/07/17 17:23), Peter Zijlstra wrote: > [..] >> > we are looking at different typical setups :) serial console being 45 >> > seconds behind logbuf does not surprise me anymore. >> >> That does sound like you're doing something

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Eric W. Biederman
Sergey Senozhatsky writes: > On (04/07/17 17:23), Peter Zijlstra wrote: > [..] >> > we are looking at different typical setups :) serial console being 45 >> > seconds behind logbuf does not surprise me anymore. >> >> That does sound like you're doing something wrong and should look at >>

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Pavel Machek
On Sat 2017-04-08 00:13:06, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > > > > a warning here can be very

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Pavel Machek
On Sat 2017-04-08 00:13:06, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > > > > a warning here can be very

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Pavel Machek
On Fri 2017-04-07 10:29:17, Steven Rostedt wrote: > On Fri, 7 Apr 2017 10:14:49 +0200 > Pavel Machek wrote: > > > > serial console can be quite slow. and port->lock, that is acquired by > > > console_unlock()->call_console_drivers()->write(), is also accessible > > > by serial

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-09 Thread Pavel Machek
On Fri 2017-04-07 10:29:17, Steven Rostedt wrote: > On Fri, 7 Apr 2017 10:14:49 +0200 > Pavel Machek wrote: > > > > serial console can be quite slow. and port->lock, that is acquired by > > > console_unlock()->call_console_drivers()->write(), is also accessible > > > by serial driver's IRQ

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 17:23), Peter Zijlstra wrote: [..] > > we are looking at different typical setups :) serial console being 45 > > seconds behind logbuf does not surprise me anymore. > > That does sound like you're doing something wrong and should look at > reducing printk() more than anything else.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 17:23), Peter Zijlstra wrote: [..] > > we are looking at different typical setups :) serial console being 45 > > seconds behind logbuf does not surprise me anymore. > > That does sound like you're doing something wrong and should look at > reducing printk() more than anything else.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Peter Zijlstra
On Sat, Apr 08, 2017 at 12:13:06AM +0900, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > > > > a warning here

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Peter Zijlstra
On Sat, Apr 08, 2017 at 12:13:06AM +0900, Sergey Senozhatsky wrote: > On (04/07/17 14:44), Pavel Machek wrote: > [..] > > > [..] > > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > > and offload" is a solution closer to what we had before. > > > > > > a warning here

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 14:44), Pavel Machek wrote: [..] > > [..] > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > and offload" is a solution closer to what we had before. > > > > a warning here can be very noisy. > > Well, on normally-configured it should be ok. We don't

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 14:44), Pavel Machek wrote: [..] > > [..] > > > I believe "spend at most 2 seconds in printk(), then print a warning > > > and offload" is a solution closer to what we had before. > > > > a warning here can be very noisy. > > Well, on normally-configured it should be ok. We don't

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Steven Rostedt
On Fri, 7 Apr 2017 14:44:55 +0200 Pavel Machek wrote: > Well, I have to agree here. This is 20 years worth of mess :-(. Maybe someone should propose a micro-conf at Linux Plumbers where we can brain storm a way to re-invent printk()? Seems it can do with a completely new rewrite.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Steven Rostedt
On Fri, 7 Apr 2017 14:44:55 +0200 Pavel Machek wrote: > Well, I have to agree here. This is 20 years worth of mess :-(. Maybe someone should propose a micro-conf at Linux Plumbers where we can brain storm a way to re-invent printk()? Seems it can do with a completely new rewrite. ;-) -- Steve

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Steven Rostedt
On Fri, 7 Apr 2017 10:14:49 +0200 Pavel Machek wrote: > > serial console can be quite slow. and port->lock, that is acquired by > > console_unlock()->call_console_drivers()->write(), is also accessible > > by serial driver's IRQ handler, and this lock may be busy long > > enough --

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Steven Rostedt
On Fri, 7 Apr 2017 10:14:49 +0200 Pavel Machek wrote: > > serial console can be quite slow. and port->lock, that is acquired by > > console_unlock()->call_console_drivers()->write(), is also accessible > > by serial driver's IRQ handler, and this lock may be busy long > > enough -- as long as

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 21:10:21, Sergey Senozhatsky wrote: > On (04/07/17 10:14), Pavel Machek wrote: > [..] > > Well. This is what we had for 20 years. > > I guess it's not just me who is a bit unhappy with printk. ask > Peter Zijlstra what's the first word that comes into his mind > when we reads

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 21:10:21, Sergey Senozhatsky wrote: > On (04/07/17 10:14), Pavel Machek wrote: > [..] > > Well. This is what we had for 20 years. > > I guess it's not just me who is a bit unhappy with printk. ask > Peter Zijlstra what's the first word that comes into his mind > when we reads

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 10:14), Pavel Machek wrote: [..] > Well. This is what we had for 20 years. I guess it's not just me who is a bit unhappy with printk. ask Peter Zijlstra what's the first word that comes into his mind when we reads "printk" :) [..] > I believe "spend at most 2 seconds in printk(),

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 10:14), Pavel Machek wrote: [..] > Well. This is what we had for 20 years. I guess it's not just me who is a bit unhappy with printk. ask Peter Zijlstra what's the first word that comes into his mind when we reads "printk" :) [..] > I believe "spend at most 2 seconds in printk(),

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 16:46:34, Sergey Senozhatsky wrote: > On (04/07/17 09:15), Pavel Machek wrote: > > On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > > > Hello, > > > > > > On (04/06/17 19:33), Pavel Machek wrote: > > > > > This patch set gives up part of the printk() reliability for

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 16:46:34, Sergey Senozhatsky wrote: > On (04/07/17 09:15), Pavel Machek wrote: > > On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > > > Hello, > > > > > > On (04/06/17 19:33), Pavel Machek wrote: > > > > > This patch set gives up part of the printk() reliability for

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 09:15), Pavel Machek wrote: > On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > > Hello, > > > > On (04/06/17 19:33), Pavel Machek wrote: > > > > This patch set gives up part of the printk() reliability for bounded > > > > latency (at least unless we detect we are really in

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Sergey Senozhatsky
On (04/07/17 09:15), Pavel Machek wrote: > On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > > Hello, > > > > On (04/06/17 19:33), Pavel Machek wrote: > > > > This patch set gives up part of the printk() reliability for bounded > > > > latency (at least unless we detect we are really in

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > Hello, > > On (04/06/17 19:33), Pavel Machek wrote: > > > This patch set gives up part of the printk() reliability for bounded > > > latency (at least unless we detect we are really in trouble) which is IMHO > > > a good trade-off for lots

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-07 Thread Pavel Machek
On Fri 2017-04-07 13:44:40, Sergey Senozhatsky wrote: > Hello, > > On (04/06/17 19:33), Pavel Machek wrote: > > > This patch set gives up part of the printk() reliability for bounded > > > latency (at least unless we detect we are really in trouble) which is IMHO > > > a good trade-off for lots

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-06 Thread Sergey Senozhatsky
Hello, On (04/06/17 19:33), Pavel Machek wrote: > > This patch set gives up part of the printk() reliability for bounded > > latency (at least unless we detect we are really in trouble) which is IMHO > > a good trade-off for lots of users (and others can just turn this feature > > off). > > If

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-06 Thread Sergey Senozhatsky
Hello, On (04/06/17 19:33), Pavel Machek wrote: > > This patch set gives up part of the printk() reliability for bounded > > latency (at least unless we detect we are really in trouble) which is IMHO > > a good trade-off for lots of users (and others can just turn this feature > > off). > > If

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-06 Thread Pavel Machek
Hi! > This patch set gives up part of the printk() reliability for bounded > latency (at least unless we detect we are really in trouble) which is IMHO > a good trade-off for lots of users (and others can just turn this feature > off). If they can ever realize they were bitten by this feature.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-06 Thread Pavel Machek
Hi! > This patch set gives up part of the printk() reliability for bounded > latency (at least unless we detect we are really in trouble) which is IMHO > a good trade-off for lots of users (and others can just turn this feature > off). If they can ever realize they were bitten by this feature.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-05 Thread Sergey Senozhatsky
On (04/05/17 15:29), Ye Xiaolong wrote: [..] > >>does this patch make it any better? > > > >I am trying it and will post the result once I get it. > > Sorry for the late. I applied the patch of on top of the fbc14616f4 ("printk: > enable printk offloading") > and the "reboot-without-waring"

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-05 Thread Sergey Senozhatsky
On (04/05/17 15:29), Ye Xiaolong wrote: [..] > >>does this patch make it any better? > > > >I am trying it and will post the result once I get it. > > Sorry for the late. I applied the patch of on top of the fbc14616f4 ("printk: > enable printk offloading") > and the "reboot-without-waring"

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-05 Thread Ye Xiaolong
On 03/31, Ye Xiaolong wrote: >On 03/31, Sergey Senozhatsky wrote: >>On (03/31/17 11:35), Sergey Senozhatsky wrote: >>[..] >>> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile >>> > your binary. >>> > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-05 Thread Ye Xiaolong
On 03/31, Ye Xiaolong wrote: >On 03/31, Sergey Senozhatsky wrote: >>On (03/31/17 11:35), Sergey Senozhatsky wrote: >>[..] >>> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile >>> > your binary. >>> > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call.

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Sergey Senozhatsky
On (03/31/17 10:28), Eric W. Biederman wrote: [..] > > ... I'd also probably add pr_emerg() print-out to emergency_restart(), > > the same way kernel_restart()/kernel_halt()/kernel_power_off() do. > > > > for those cases when emergency_restart() is called with printk in > > kthreaded mode, not in

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Sergey Senozhatsky
On (03/31/17 10:28), Eric W. Biederman wrote: [..] > > ... I'd also probably add pr_emerg() print-out to emergency_restart(), > > the same way kernel_restart()/kernel_halt()/kernel_power_off() do. > > > > for those cases when emergency_restart() is called with printk in > > kthreaded mode, not in

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Petr Mladek
On Mon 2017-04-03 11:31:52, Jan Kara wrote: > On Fri 31-03-17 10:28:15, Eric W. Biederman wrote: > > Sergey Senozhatsky writes: > > > > > On (03/31/17 14:39), Ye Xiaolong wrote: > > >> On 03/31, Sergey Senozhatsky wrote: > > >> >On (03/31/17 11:35), Sergey

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Petr Mladek
On Mon 2017-04-03 11:31:52, Jan Kara wrote: > On Fri 31-03-17 10:28:15, Eric W. Biederman wrote: > > Sergey Senozhatsky writes: > > > > > On (03/31/17 14:39), Ye Xiaolong wrote: > > >> On 03/31, Sergey Senozhatsky wrote: > > >> >On (03/31/17 11:35), Sergey Senozhatsky wrote: > > >> >[..] > > >>

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Jan Kara
On Fri 31-03-17 10:28:15, Eric W. Biederman wrote: > Sergey Senozhatsky writes: > > > On (03/31/17 14:39), Ye Xiaolong wrote: > >> On 03/31, Sergey Senozhatsky wrote: > >> >On (03/31/17 11:35), Sergey Senozhatsky wrote: > >> >[..] > >> >> > [ 21.009531] VFS:

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-04-03 Thread Jan Kara
On Fri 31-03-17 10:28:15, Eric W. Biederman wrote: > Sergey Senozhatsky writes: > > > On (03/31/17 14:39), Ye Xiaolong wrote: > >> On 03/31, Sergey Senozhatsky wrote: > >> >On (03/31/17 11:35), Sergey Senozhatsky wrote: > >> >[..] > >> >> > [ 21.009531] VFS: Warning: trinity-c2 using old

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Eric W. Biederman
Sergey Senozhatsky writes: > On (03/31/17 14:39), Ye Xiaolong wrote: >> On 03/31, Sergey Senozhatsky wrote: >> >On (03/31/17 11:35), Sergey Senozhatsky wrote: >> >[..] >> >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. >> >> > Recompile your

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Eric W. Biederman
Sergey Senozhatsky writes: > On (03/31/17 14:39), Ye Xiaolong wrote: >> On 03/31, Sergey Senozhatsky wrote: >> >On (03/31/17 11:35), Sergey Senozhatsky wrote: >> >[..] >> >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. >> >> > Recompile your binary. >> >> > [ 21.148898]

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Sergey Senozhatsky
On (03/31/17 14:39), Ye Xiaolong wrote: > On 03/31, Sergey Senozhatsky wrote: > >On (03/31/17 11:35), Sergey Senozhatsky wrote: > >[..] > >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile > >> > your binary. > >> > [ 21.148898] VFS: Warning: trinity-c0 using old

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Sergey Senozhatsky
On (03/31/17 14:39), Ye Xiaolong wrote: > On 03/31, Sergey Senozhatsky wrote: > >On (03/31/17 11:35), Sergey Senozhatsky wrote: > >[..] > >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile > >> > your binary. > >> > [ 21.148898] VFS: Warning: trinity-c0 using old

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Ye Xiaolong
On 03/31, Sergey Senozhatsky wrote: >On (03/31/17 11:35), Sergey Senozhatsky wrote: >[..] >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile >> > your binary. >> > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call. Recompile >> > your binary. >> > [

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-31 Thread Ye Xiaolong
On 03/31, Sergey Senozhatsky wrote: >On (03/31/17 11:35), Sergey Senozhatsky wrote: >[..] >> > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile >> > your binary. >> > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call. Recompile >> > your binary. >> > [

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread Sergey Senozhatsky
On (03/31/17 11:35), Sergey Senozhatsky wrote: [..] > > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile > > your binary. > > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call. Recompile > > your binary. > > [ 22.298208] warning: process `trinity-c2' used

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread Sergey Senozhatsky
On (03/31/17 11:35), Sergey Senozhatsky wrote: [..] > > [ 21.009531] VFS: Warning: trinity-c2 using old stat() call. Recompile > > your binary. > > [ 21.148898] VFS: Warning: trinity-c0 using old stat() call. Recompile > > your binary. > > [ 22.298208] warning: process `trinity-c2' used

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread Sergey Senozhatsky
On (03/31/17 05:38), kernel test robot wrote: > FYI, we noticed the following commit: > > commit: fbc14616f483788afabe77d05bfb99883dc66c73 ("printk: enable printk > offloading") > url: >

Re: [printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread Sergey Senozhatsky
On (03/31/17 05:38), kernel test robot wrote: > FYI, we noticed the following commit: > > commit: fbc14616f483788afabe77d05bfb99883dc66c73 ("printk: enable printk > offloading") > url: >

[printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread kernel test robot
FYI, we noticed the following commit: commit: fbc14616f483788afabe77d05bfb99883dc66c73 ("printk: enable printk offloading") url: https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/printk-introduce-printing-kernel-thread/20170330-185752 in testcase: trinity with following parameters:

[printk] fbc14616f4: BUG:kernel_reboot-without-warning_in_test_stage

2017-03-30 Thread kernel test robot
FYI, we noticed the following commit: commit: fbc14616f483788afabe77d05bfb99883dc66c73 ("printk: enable printk offloading") url: https://github.com/0day-ci/linux/commits/Sergey-Senozhatsky/printk-introduce-printing-kernel-thread/20170330-185752 in testcase: trinity with following parameters: