Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-08 Thread John Levon
On Wed, 6 Sep 2000, George Anzinger wrote: > Actually I was not quite correct. The call to timeout WILL return > immediately, however, the timeout code will clean up the timer, so there > should be no worry there. It is a bug in that the sleep does not happen > as expected. I saw at least one

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-08 Thread John Levon
On Wed, 6 Sep 2000, George Anzinger wrote: Actually I was not quite correct. The call to timeout WILL return immediately, however, the timeout code will clean up the timer, so there should be no worry there. It is a bug in that the sleep does not happen as expected. I saw at least one

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-07 Thread Stuart Lynne
You can ran into problems using schedule_timeout() in a block device request function under 2.4. This can be demonstrated by starting some I/O intensive tasks to your block device and running sync in another task. Eventually the block layer will lock up. This can be fixed by creating a kernel

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-07 Thread George Anzinger
David Woodhouse wrote: > > [EMAIL PROTECTED] said: > > So it seems to be a bug at least in terms of timing. Unfortunately I > > only got about 4 replies to the patches that touched 20+ drivers. I > > suppose I should just hassle maintainers until they fix it or tell me > > where I've gone wrong

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-07 Thread George Anzinger
John Levon wrote: > > On Wed, 6 Sep 2000, George Anzinger wrote: > > > John Levon wrote: > > > > > > Am I right ? against test8pre1 > > > > > > Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a > > > schedule_timeout() ? What will happen ? > > > > > Well, first the "timeout"

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-07 Thread George Anzinger
David Woodhouse wrote: [EMAIL PROTECTED] said: So it seems to be a bug at least in terms of timing. Unfortunately I only got about 4 replies to the patches that touched 20+ drivers. I suppose I should just hassle maintainers until they fix it or tell me where I've gone wrong ...

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-07 Thread Stuart Lynne
You can ran into problems using schedule_timeout() in a block device request function under 2.4. This can be demonstrated by starting some I/O intensive tasks to your block device and running sync in another task. Eventually the block layer will lock up. This can be fixed by creating a kernel

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-06 Thread John Levon
On Wed, 6 Sep 2000, George Anzinger wrote: > John Levon wrote: > > > > Am I right ? against test8pre1 > > > > Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a > > schedule_timeout() ? What will happen ? > > > Well, first the "timeout" call will return immediately. Next,

Re: Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-06 Thread George Anzinger
John Levon wrote: > > Am I right ? against test8pre1 > > Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a > schedule_timeout() ? What will happen ? > Well, first the "timeout" call will return immediately. Next, when the time out actually happens, if the task is not

Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-02 Thread John Levon
Am I right ? against test8pre1 Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a schedule_timeout() ? What will happen ? thanks john --- drivers/pcmcia/yenta.c Fri Aug 11 00:21:32 2000 +++ drivers/pcmcia/yenta.c.new Fri Sep 1 02:42:55 2000 @@ -574,6 +574,7 @@

Drivers that potentially leave state as TASK_{UN}INTERRUPTIBLE

2000-09-02 Thread John Levon
Am I right ? against test8pre1 Also, is it a bug to not set TASK_{UN}INTERRUPTIBLE before doing a schedule_timeout() ? What will happen ? thanks john --- drivers/pcmcia/yenta.c Fri Aug 11 00:21:32 2000 +++ drivers/pcmcia/yenta.c.new Fri Sep 1 02:42:55 2000 @@ -574,6 +574,7 @@