Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

>> The mutex was (and is still only) locked within case branches, isn't it? >> > You are correct, this does however reflect the issue with the resulting > lack of balance here. Do you find changes for the other function implementations easier to integrate? Regards, Markus

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

>> The mutex was (and is still only) locked within case branches, isn't it? >> > You are correct, this does however reflect the issue with the resulting > lack of balance here. Do you find changes for the other function implementations easier to integrate? Regards, Markus

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

>> The mutex was (and is still only) locked within case branches, isn't it? >> > You are correct, this does however reflect the issue with the resulting > lack of balance here. I suggest to reconsider affected software aspects a bit more. > I saw the mutex was getting unlocked outside the local

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

>> The mutex was (and is still only) locked within case branches, isn't it? >> > You are correct, this does however reflect the issue with the resulting > lack of balance here. I suggest to reconsider affected software aspects a bit more. > I saw the mutex was getting unlocked outside the local

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Sun, 18 Mar 2018 09:19:47 +0100 SF Markus Elfring wrote: > Am 17.03.2018 um 20:54 schrieb Jonathan Cameron: > > On Wed, 14 Mar 2018 16:15:32 +0100 > > SF Markus Elfring wrote: > > > >> From: Markus Elfring

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Sun, 18 Mar 2018 09:19:47 +0100 SF Markus Elfring wrote: > Am 17.03.2018 um 20:54 schrieb Jonathan Cameron: > > On Wed, 14 Mar 2018 16:15:32 +0100 > > SF Markus Elfring wrote: > > > >> From: Markus Elfring > >> Date: Wed, 14 Mar 2018 16:06:49 +0100 > >> > >> * Add jump targets so that a

Re: [PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Sat, Mar 17, 2018 at 07:54:22PM +, Jonathan Cameron wrote: > On Wed, 14 Mar 2018 16:15:32 +0100 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Wed, 14 Mar 2018 16:06:49 +0100 > > > > * Add jump targets so

Re: [PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Sat, Mar 17, 2018 at 07:54:22PM +, Jonathan Cameron wrote: > On Wed, 14 Mar 2018 16:15:32 +0100 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Wed, 14 Mar 2018 16:06:49 +0100 > > > > * Add jump targets so that a call of the function "mutex_unlock" is stored > > only

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

Am 17.03.2018 um 20:54 schrieb Jonathan Cameron: > On Wed, 14 Mar 2018 16:15:32 +0100 > SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Wed, 14 Mar 2018 16:06:49 +0100 >> >> * Add jump targets so that a call of the

Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

Am 17.03.2018 um 20:54 schrieb Jonathan Cameron: > On Wed, 14 Mar 2018 16:15:32 +0100 > SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Wed, 14 Mar 2018 16:06:49 +0100 >> >> * Add jump targets so that a call of the function "mutex_unlock" is stored >> only once in these function

Re: [PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Wed, 14 Mar 2018 16:15:32 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 14 Mar 2018 16:06:49 +0100 > > * Add jump targets so that a call of the function "mutex_unlock" is stored > only once in these

Re: [PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

On Wed, 14 Mar 2018 16:15:32 +0100 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 14 Mar 2018 16:06:49 +0100 > > * Add jump targets so that a call of the function "mutex_unlock" is stored > only once in these function implementations. > > * Replace 19 calls by goto statements.

[PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

From: Markus Elfring Date: Wed, 14 Mar 2018 16:06:49 +0100 * Add jump targets so that a call of the function "mutex_unlock" is stored only once in these function implementations. * Replace 19 calls by goto statements. This issue was detected by using the

[PATCH] iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions

From: Markus Elfring Date: Wed, 14 Mar 2018 16:06:49 +0100 * Add jump targets so that a call of the function "mutex_unlock" is stored only once in these function implementations. * Replace 19 calls by goto statements. This issue was detected by using the Coccinelle software. Signed-off-by: