Re: [PATCH] MAINTAINERS: update QUALCOMM IOMMU after Arm SSMU drivers move

2020-08-25 Thread Lukas Bulwahn
On Fri, 21 Aug 2020, Will Deacon wrote: > On Sun, Aug 02, 2020 at 08:53:20AM +0200, Lukas Bulwahn wrote: > > Commit e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own > > subdirectory") moved drivers/iommu/qcom_iommu.c to > > drivers/iommu/arm/arm-smmu/qcom_iommu.c amongst

KASAN: slab-out-of-bounds Read in read_descriptors (2)

2020-08-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:da2968ff Merge tag 'pci-v5.9-fixes-1' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=153afba690 kernel config: https://syzkaller.appspot.com/x/.config?x=a0437fdd630bee11

KASAN: use-after-free Read in cgroup_path_ns

2020-08-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:da2968ff Merge tag 'pci-v5.9-fixes-1' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=159763ce90 kernel config: https://syzkaller.appspot.com/x/.config?x=bb68b9e8a8cc842f

Re: [PATCH v3 2/5] cpufreq: move invariance setter calls in cpufreq core

2020-08-25 Thread Viresh Kumar
On 24-08-20, 22:02, Ionela Voinescu wrote: > To properly scale its per-entity load-tracking signals, the task scheduler > needs to be given a frequency scale factor, i.e. some image of the current > frequency the CPU is running at. Currently, this scale can be computed > either by using counters

Kernel panic - not syncing: Attempted to kill init! x86_64 running 4.19

2020-08-25 Thread Naresh Kamboju
While running LTP tracing ftrace-stress-test kernel on x86_64 got panic on stable rc 4.19 branch. I have checked this kernel panic has been happening from the beginning of 4.19 release. I will run git bisect starting from 4.18 and get back to you on this email thread. steps to reproduce: # Boot

Re: pcm|dmaengine|imx-sdma race condition on i.MX6

2020-08-25 Thread Sascha Hauer
On Fri, Aug 21, 2020 at 09:52:00AM +, Robin Gong wrote: > On 2020/08/20 14:52 Sascha Hauer wrote: > > On Wed, Aug 19, 2020 at 01:08:29PM +0200, Lars-Peter Clausen wrote: > > > > For the first option, which is potentially more performant, we have > > > > to leave the atomic PCM context and we

Re: x86/kprobes: kretprobe fails to triggered if kprobe at function entry is not optimized (trigger by int3 breakpoint)

2020-08-25 Thread Masami Hiramatsu
Hi Eddy, On Mon, 24 Aug 2020 16:41:58 + "eddy...@trendmicro.com" wrote: > > -Original Message- > > From: Masami Hiramatsu > > Sent: Monday, August 24, 2020 11:54 PM > > To: Eddy Wu (RD-TW) > > Cc: Peter Zijlstra ; linux-kernel@vger.kernel.org; > > x...@kernel.org; David S. Miller

Re: [PATCH] Fix s390x compile error on F32 utils/stat-display.c

2020-08-25 Thread Thomas Richter
On 8/24/20 10:22 PM, Jiri Olsa wrote: > On Wed, Aug 12, 2020 at 08:27:08AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, Jul 22, 2020 at 11:20:53AM +0200, Thomas Richter escreveu: >>> Fix a compile error on F32 and gcc version 10.1 on s390 in file >>> utils/stat-display.c. The error does not

[PATCH 2/2] arm64/kvm: Drop checking target CPU type on initializing module

2020-08-25 Thread Gavin Shan
The target CPU type is validated when KVM module is initialized. However, we always have a valid target CPU type since commit ("arm64/kvm: Add generic v8 KVM target"). So it's unnecessary to validate the target CPU type at that time and this just drops it. Signed-off-by: Gavin Shan ---

[PATCH 1/2] arm64/kvm: Drop unnecessary check in kvm_vcpu_preferred_target()

2020-08-25 Thread Gavin Shan
Since commit ("arm64/kvm: Add generic v8 KVM target"), there is no negative number returned from kvm_target_cpu(). So it's not needed to validate its return value in kvm_vcpu_preferred_target() and this just drops the unnecessary check. Signed-off-by: Gavin Shan --- arch/arm64/kvm/guest.c | 3

Re: [PATCH v2 2/5] cpufreq: intel_pstate: Always return last EPP value from sysfs

2020-08-25 Thread Artem Bityutskiy
On Mon, 2020-08-24 at 19:42 +0200, Rafael J. Wysocki wrote: > From: "Rafael J. Wysocki" > > Make the energy_performance_preference policy attribute in sysfs > always return the last EPP value written to it instead of the one > currently in the HWP Request MSR to avoid possible confusion when >

[PATCH v5] i3c: master: fix for SETDASA and DAA process

2020-08-25 Thread Parshuram Thombare
This patch fixes the following issue. Controller slots blocked for the devices with only static_addr or init_dyn_addr may limit the number of I3C devices on the bus which gets dynamic address in DAA. So instead of attaching all the devices with static_addr, now we only attach the devices which

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-25 Thread Feng Tang
On Mon, Aug 24, 2020 at 06:12:38PM +0200, Borislav Petkov wrote: > > -DEFINE_PER_CPU(struct mce, injectm); > > +DEFINE_PER_CPU_ALIGNED(struct mce, injectm); > > EXPORT_PER_CPU_SYMBOL_GPL(injectm); > > I don't think this is the right fix. Agreed :) This is a debug patch, what we want is to root

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Christoph Hellwig
On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > New Intel laptops with VMD cannot reach deeper power saving state, > renders very short battery time. So what about just disabling VMD given how bloody pointless it is? Hasn't anyone learned from the AHCI remapping debacle? I'm

Re: [PATCH 01/16] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements

2020-08-25 Thread Vaittinen, Matti
Hello Krzysztof, On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > The input clock and number of clock provider cells are not required > for > the PMIC to operate. They are needed only for the optional bd718x7 > clock driver. I have always found the DT bindings hard to do. I

Re: [PATCH v6 00/76] x86: SEV-ES Guest Support

2020-08-25 Thread Joerg Roedel
Hi Mike, On Tue, Aug 25, 2020 at 12:21:03AM +, Mike Stunes wrote: > Thanks for the new update! I still see the same FSGSBASE behavior on our > platform. > > That is, APs come up offline; masking out either FSGSBASE or RDPID from the > guest's CPUID results in all CPUs online. > > Is that

RE: [PATCH v5] i3c: master: fix for SETDASA and DAA process

2020-08-25 Thread Parshuram Raju Thombare
Please ignore this patch. Regards, Parshuram Thombare >-Original Message- >From: Parshuram Thombare >Sent: Tuesday, August 25, 2020 11:51 AM >To: bbrezil...@kernel.org; vitor.soa...@synopsys.com >Cc: Przemyslaw Gaj ; linux-...@lists.infradead.org; linux- >ker...@vger.kernel.org; Milind

Re: [PATCH v3 4/5] arch_topology, cpufreq: constify arch_* cpumasks

2020-08-25 Thread Viresh Kumar
On 24-08-20, 22:02, Ionela Voinescu wrote: > From: Valentin Schneider > > The passed cpumask arguments to arch_set_freq_scale() and > arch_freq_counters_available() are only iterated over, so reflect this > in the prototype. This also allows to pass system cpumasks like > cpu_online_mask without

Re: [PATCH v3 3/5] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-08-25 Thread Viresh Kumar
On 24-08-20, 22:02, Ionela Voinescu wrote: > Now that the update of the FI scale factor is done in cpufreq core for > selected functions - target(), target_index() and fast_switch(), > we can provide feedback to the task scheduler and architecture code > on whether cpufreq supports FI. > > For

[PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

2020-08-25 Thread Dinghao Liu
When radeon_kick_out_firmware_fb() fails, info should be freed just like the subsequent error paths. Fixes: 069ee21a82344 ("fbdev: Fix loading of module radeonfb on PowerMac") Signed-off-by: Dinghao Liu --- drivers/video/fbdev/aty/radeon_base.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v5] i3c: master: fix for SETDASA and DAA process

2020-08-25 Thread Parshuram Thombare
This patch fix following issue. Controller slots blocked for devices with static_addr but no init_dyn_addr may limit the number of I3C devices on the bus which gets dynamic address in DAA. So instead of attaching all the devices with static_addr, now we only attach the devices which successfully

[PATCH] perf stat: Fix s390x compile error on F32 utils/stat-display.c

2020-08-25 Thread Thomas Richter
Fix a compile error on F32 and gcc version 10.1 on s390 in file utils/stat-display.c. The error does not show up with make DEBUG=y. In fact the issue shows up when using both compiler options -O6 and -D_FORTIFY_SOURCE=2 (which are omitted with DEBUG=Y). This is the offending call chain:

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Himadri Pandya
On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote: > On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote: > > Initialize the buffer before passing it to usb_read_cmd() function(s) to > > fix the uninit-was-stored issue in asix_read_cmd(). > > > > Fixes: KMSAN: kernel-infoleak in

[PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-25 Thread Jing Xiangfeng
The variable ret is being initialized with 'FAILED'. So we can remove this assignement. Signed-off-by: Jing Xiangfeng --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c

Re: [PATCH] sched/fair: Fix wrong cpu selecting from isolated domain

2020-08-25 Thread Jiang Biao
On Mon, 24 Aug 2020 at 20:31, Xunlei Pang wrote: > > We've met problems that occasionally tasks with full cpumask > (e.g. by putting it into a cpuset or setting to full affinity) > were migrated to our isolated cpus in production environment. > > After some analysis, we found that it is due to

Re: [PATCH 02/29] alpha: Avoid comma separated statements

2020-08-25 Thread Robert Richter
On 24.08.20 21:55:59, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches > --- > arch/alpha/kernel/pci_iommu.c | 8 +--- > arch/alpha/oprofile/op_model_ev4.c | 22 ++ > arch/alpha/oprofile/op_model_ev5.c | 8 +--- > 3 files changed,

Re: [PATCH 3/5] i2c: aspeed: Mask IRQ status to relevant bits

2020-08-25 Thread Joel Stanley
On Thu, 20 Aug 2020 at 16:12, Eddie James wrote: > > Mask the IRQ status to only the bits that the driver checks. This > prevents excessive driver warnings when operating in slave mode > when additional bits are set that the driver doesn't handle. > > Signed-off-by: Eddie James > --- >

[PATCH v9 3/4] power: supply: core: add wireless signal strength property

2020-08-25 Thread Qiwu Huang
From: Qiwu Huang reports wireless signal strength. The value show degree of coupling between tx and rx. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 22 + drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h

[PATCH v9 1/4] power: supply: core: add quick charge type property

2020-08-25 Thread Qiwu Huang
From: Qiwu Huang Reports the kind of quick charge type based on different adapter power. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 21 ++ drivers/power/supply/power_supply_sysfs.c | 1 + drivers/power/supply/qcom_smbb.c| 79

[PATCH v9 4/4] power: supply: core: property to control reverse charge

2020-08-25 Thread Qiwu Huang
From: Qiwu Huang Interface to control wireless reverse charge. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 14 ++ drivers/power/supply/power_supply_sysfs.c | 1 + include/linux/power_supply.h| 1 + 3 files changed, 16

[PATCH v9 2/4] power: supply: core: add wireless charger adapter type property

2020-08-25 Thread Qiwu Huang
From: Qiwu Huang Reports what type of wireless adapter connection is currently active for the supply. for example it can show if ADAPTER_PD capable source is attached. Signed-off-by: Qiwu Huang --- Documentation/ABI/testing/sysfs-class-power | 28 +

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Kai Heng Feng
Hi Christoph, > On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: >> New Intel laptops with VMD cannot reach deeper power saving state, >> renders very short battery time. > > So what about just disabling VMD given how

[PATCH v9 0/4] add some power supply properties about wireless/wired charging

2020-08-25 Thread Qiwu Huang
From: Qiwu Huang This patchset aims to provide power supply properties about wireless/wired charging. "quick_charge_type" reports different types of quick charge based on the charging power; "tx_adapter" shows" the type of wireless charging adapter; "signal_strength" shows the coupling level

Re: [PATCH 02/16] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

2020-08-25 Thread Sascha Hauer
On Mon, Aug 24, 2020 at 09:06:47PM +0200, Krzysztof Kozlowski wrote: > Driver requires different amount of clocks for different SoCs. Describe > these requirements properly to fix dtbs_check warnings like: > > arch/arm64/boot/dts/freescale/imx8mm-beacon-kit.dt.yaml: >

[PATCH v2 2/2] mm/rmap: Fixup copying of soft dirty and uffd ptes

2020-08-25 Thread Alistair Popple
During memory migration a pte is temporarily replaced with a migration swap pte. Some pte bits from the existing mapping such as the soft-dirty and uffd write-protect bits are preserved by copying these to the temporary migration swap pte. However these bits are not stored at the same location

[PATCH v2 1/2] mm/migrate: Fixup setting UFFD_WP flag

2020-08-25 Thread Alistair Popple
Commit f45ec5ff16a75 ("userfaultfd: wp: support swap and page migration") introduced support for tracking the uffd wp bit during page migration. However the non-swap PTE variant was used to set the flag for zone device private pages which are a type of swap page. This leads to corruption of the

Re: [PATCH 4.19 00/73] 4.19.142-rc2 review

2020-08-25 Thread Naresh Kamboju
On Mon, 24 Aug 2020 at 22:20, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.142 release. > There are 73 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [RFC PATCH 3/3] opp: Power on (virtual) power domains managed by the OPP core

2020-08-25 Thread Ulf Hansson
On Tue, 25 Aug 2020 at 06:43, Viresh Kumar wrote: > > On 24-08-20, 17:08, Stephan Gerhold wrote: > > On Mon, Aug 24, 2020 at 04:36:57PM +0200, Ulf Hansson wrote: > > > That said, perhaps should rely on the consumer to deploy runtime PM > > > support, but let the OPP core to set up the device

[PATCH] dmaengine: pl330: Fix burst length if burst size is smaller than bus width

2020-08-25 Thread Marek Szyprowski
Move the burst len fixup after setting the generic value for it. This finally enables the fixup introduced by commit 137bd11090d8 ("dmaengine: pl330: Align DMA memcpy operations to MFIFO width"), which otherwise was overwritten by the generic value. Reported-by: kernel test robot Fixes:

Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM

2020-08-25 Thread Kuninori Morimoto
Hi Sameer > > Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex(). > > I'm not sure which style is best. > > I don't know how complex it is to have a unified solution. But if we > can protect snd_soc_find_dai() itself, things would be simpler may be > in long term.

Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion

2020-08-25 Thread Christoph Hellwig
On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > Remove BUG/BUG_ON from androind/ion Please just remove ion. It has been rejected and we have developed proper kernel subsystens to replace it. Don't waste your time on it.

[PATCH 2/2] iommu/vt-d:Add support for probing ACPI device in RMRR

2020-08-25 Thread FelixCuioc
In the probe_acpi_namespace_devices function,when the physical node of the acpi device is NULL,the unlock function is missing. Add mutex_unlock(>physical_node_lock). Reported-by: Dan Carpenter Signed-off-by: FelixCuioc --- drivers/iommu/intel/iommu.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH 02/16] dt-bindings: mtd: gpmi-nand: Fix matching of clocks on different SoCs

2020-08-25 Thread Krzysztof Kozlowski
On Tue, Aug 25, 2020 at 08:40:20AM +0200, Sascha Hauer wrote: > On Mon, Aug 24, 2020 at 09:06:47PM +0200, Krzysztof Kozlowski wrote: > > Driver requires different amount of clocks for different SoCs. Describe > > these requirements properly to fix dtbs_check warnings like: > > > >

Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression

2020-08-25 Thread Feng Tang
On Mon, Aug 24, 2020 at 05:56:53PM +0100, Mel Gorman wrote: > On Mon, Aug 24, 2020 at 06:12:38PM +0200, Borislav Petkov wrote: > > > > > :) Right, this is what I'm doing right now. Some test job is queued on > > > the test box, and it may needs some iterations of new patch. Hopefully we > > >

Re: [RFC PATCH 2/3] dmaengine: add peripheral configuration

2020-08-25 Thread Peter Ujfalusi
Hi Vinod, On 24/08/2020 11.47, Vinod Koul wrote: > Some complex dmaengine controllers have capability to program the > peripheral device, so pass on the peripheral configuration as part of > dma_slave_config > > Signed-off-by: Vinod Koul > --- > include/linux/dmaengine.h | 75

Re: linux-next: build failure after merge of the bpf-next tree

2020-08-25 Thread Stephen Rothwell
Hi Alexei, On Mon, 24 Aug 2020 20:27:28 -0700 Alexei Starovoitov wrote: > > I didn't receive the first email you've replied to. > The build error is: > " > No libelf found > make[5]: *** [Makefile:284: elfdep] Error 1 > " > and build process stops because libelf is not found, right? > That is

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Greg Kroah-Hartman
On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > wrote: > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > On Sun, Aug 23, 2020 at 12:19 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Sun, Aug

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread Vaittinen, Matti
Hello Krzysztof, Just some questions - please ignore if I misunderstood the impact of the change. On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > Device tree schema expects regulator names to be lowercase. This > fixes > dtbs_check warnings like: > >

Re: [PATCH] drm/msm: drop cache sync hack

2020-08-25 Thread Christoph Hellwig
On Sat, Aug 22, 2020 at 10:52:54AM -0700, Rob Clark wrote: > From: Rob Clark > > Now that it isn't causing problems to use dma_map/unmap, we can drop the > hack of using dma_sync in certain cases. Great to see! What did solve the problems?

Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion

2020-08-25 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 07:47:29AM +0100, Christoph Hellwig wrote: > On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > > Remove BUG/BUG_ON from androind/ion > > Please just remove ion. It has been rejected and we have developed > proper kernel subsystens to replace it. Don't waste

Re: [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()

2020-08-25 Thread Greg Kroah-Hartman
On Tue, Aug 25, 2020 at 08:51:35AM +0200, Greg Kroah-Hartman wrote: > On Mon, Aug 24, 2020 at 10:55:28AM +0200, Dmitry Vyukov wrote: > > On Sun, Aug 23, 2020 at 12:57 PM Greg Kroah-Hartman > > wrote: > > > > > > On Sun, Aug 23, 2020 at 12:31:03PM +0200, Dmitry Vyukov wrote: > > > > On Sun, Aug

Re: [PATCH 01/16] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 06:23:36AM +, Vaittinen, Matti wrote: > > Hello Krzysztof, > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > The input clock and number of clock provider cells are not required > > for > > the PMIC to operate. They are needed only for the optional

Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain

2020-08-25 Thread Christoph Hellwig
On Tue, Aug 25, 2020 at 02:39:55PM +0800, Kai Heng Feng wrote: > Hi Christoph, > > > On Aug 25, 2020, at 2:23 PM, Christoph Hellwig wrote: > > > > On Fri, Aug 21, 2020 at 08:32:20PM +0800, Kai-Heng Feng wrote: > >> New Intel laptops with VMD cannot reach deeper power saving state, > >> renders

[PATCH v2 1/3] clk: at91: remove the checking of parent_name

2020-08-25 Thread Claudiu Beznea
There is no need to check parent_name variable while assigning it to init.parent_names. parent_name variable is already checked at the beginning of at91_clk_register_peripheral() function. Fixes: 6114067e437eb ("clk: at91: add PMC peripheral clocks") Signed-off-by: Claudiu Beznea Reviewed-by:

[PATCH v2 2/3] clk: at91: clk-main: update key before writing AT91_CKGR_MOR

2020-08-25 Thread Claudiu Beznea
SAMA5D2 datasheet specifies on chapter 33.22.8 (PMC Clock Generator Main Oscillator Register) that writing any value other than 0x37 on KEY field aborts the write operation. Use the key when selecting main clock parent. Fixes: 27cb1c2083373 ("clk: at91: rework main clk implementation")

[PATCH v2 0/3] fixes for at91 clocks

2020-08-25 Thread Claudiu Beznea
Hi, In this series I collected 2 patches send previously and add another that fixes a compilation warning. Changes in v2: - add patches "clk: at91: remove the checking of parent_name" and "clk: at91: clk-main: update key before writing AT91_CKGR_MOR" in the same series and collect

[PATCH v2 3/3] clk: at91: clk-sam9x60-pll: remove unused variable

2020-08-25 Thread Claudiu Beznea
Fix variable set but not used compilation warning. Fixes: 43b1bb4a9b3e ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs") Reported-by: kernel test robot Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-sam9x60-pll.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote: > The variable ret is being initialized with 'FAILED'. So we can remove > this assignement. If you are going to change the code at all, might as well try to improve it more by removing the unnecessary out: label altogether. Perhaps: ---

Re: kernel/dma/pool.c:79 cma_in_zone() warn: always true condition '(end <= ((((32) == 64)) << (32)) - 1))) => (0-u32max <= u32max)'

2020-08-25 Thread Christoph Hellwig
Looks like we might have to replace the IS_ENABLED with an ifdef to cater for the 32-bit phys_addr_t and overzealous compilers. On Tue, Aug 25, 2020 at 01:45:38PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head:

Re: [PATCH] scsi: megaraid: Remove unnecessary assignment to variable ret

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote: > On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote: > > The variable ret is being initialized with 'FAILED'. So we can remove > > this assignement. > > If you are going to change the code at all, > might as well try to improve it more

[PATCH v4 3/7] perf util: Compare two streams

2020-08-25 Thread Jin Yao
Stream is the branch history which is aggregated by the branch records from perf samples. Now we only support the callchain as stream. If the callchain entries of one stream are fully matched with the callchain entries of another stream, we think two streams are matched. For example, cycles:

[PATCH v4 1/7] perf util: Create streams

2020-08-25 Thread Jin Yao
We define the stream is the branch history which is aggregated by the branch records from perf samples. For example, the callchains aggregated from the branch records are considered as streams. By browsing the hot stream, we can understand the hot code path. Now we only support the callchain for

[PATCH v4 6/7] perf util: Report hot streams

2020-08-25 Thread Jin Yao
We show the streams separately. They are divided into different sections. 1. "Matched hot streams" 2. "Hot streams in old perf data only" 3. "Hot streams in new perf data only". For each stream, we report the cycles and hot percent (hits%). For example, cycles: 2, hits: 4.08%

[PATCH v4 0/7] perf: Stream comparison

2020-08-25 Thread Jin Yao
Sometimes, a small change in a hot function reducing the cycles of this function, but the overall workload doesn't get faster. It is interesting where the cycles are moved to. What it would like is to diff before/after streams. The stream is the branch history which is aggregated by the branch

[PATCH v4 2/7] perf util: Get the evsel_streams by evsel_idx

2020-08-25 Thread Jin Yao
In previous patch, we have created evsel_streams array This patch returns the specified evsel_streams according to the evsel_idx. Signed-off-by: Jin Yao --- v4: - Rename the patch from 'perf util: Return per-event callchain streams' to 'perf util: Get the evsel_streams by evsel_idx'

[PATCH v4 7/7] perf diff: Support hot streams comparison

2020-08-25 Thread Jin Yao
This patch enables perf-diff with "--stream" option. "--stream": Enable hot streams comparison Now let's see examples. perf record -b ... Generate perf.data.old with branch data perf record -b ... Generate perf.data with branch data perf diff --stream [ Matched hot streams ] hot

[PATCH v4 4/7] perf util: Link stream pair

2020-08-25 Thread Jin Yao
In previous patch, we have created an evsel_streams for one event, and top N hottest streams will be saved in a stream array in evsel_streams. This patch compares total streams among two evsel_streams. Once two streams are fully matched, they will be linked as a pair. From the pair, we can know

[PATCH v4 5/7] perf util: Calculate the sum of total streams hits

2020-08-25 Thread Jin Yao
We have used callchain_node->hit to measure the hot level of one stream. This patch calculates the sum of hits of total streams. Thus in next patch, we can use following formula to report hot percent for one stream. hot percent = callchain_node->hit / sum of total hits Signed-off-by: Jin Yao

Re: [PATCH v2 12/19] dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible matching

2020-08-25 Thread Krzysztof Kozlowski
On Mon, Aug 24, 2020 at 08:38:01PM -0600, Rob Herring wrote: > On Mon, Aug 24, 2020 at 06:26:45PM +0200, Krzysztof Kozlowski wrote: > > The i.MX 8 DTSes use two compatibles so update the binding to fix > > dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml:

Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'

2020-08-25 Thread Christoph Hellwig
On Mon, Aug 24, 2020 at 02:16:30PM -0700, Keith Busch wrote: > On Mon, Aug 24, 2020 at 01:00:11PM -0700, Sagi Grimberg wrote: > > > The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent > > > in this function. > > > > > > Use 'spin_lock_irqsave()' also here, as there is no

Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'

2020-08-25 Thread Christoph Hellwig
On Fri, Aug 21, 2020 at 09:58:19AM +0200, Christophe JAILLET wrote: > The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent > in this function. > > Use 'spin_lock_irqsave()' also here, as there is no guarantee that > interruptions are disabled at that point, according to

Re: [PATCH 2/7] spi: fsi: Fix clock running too fast

2020-08-25 Thread Joel Stanley
On Thu, 20 Aug 2020 at 21:06, Eddie James wrote: > > > On 8/20/20 12:12 PM, Mark Brown wrote: > > On Thu, Aug 20, 2020 at 12:02:23PM -0500, Eddie James wrote: > >> From: Brad Bishop > >> > >> Use a clock divider tuned to a 200MHz FSI clock. Use of the previous > >> divider at 200MHz results in

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

2020-08-25 Thread Wolfram Sang
On Wed, Aug 12, 2020 at 02:36:18PM -0600, Rob Herring wrote: > Clean-up incorrect indentation, extra spaces, long lines, and missing > EOF newline in schema files. Most of the clean-ups are for list > indentation which should always be 2 spaces more than the preceding > keyword. > > Found with

[PATCH] checkpatch: Warn if trace_printk and friends are called

2020-08-25 Thread Nicolas Boichat
trace_printk is meant as a debugging tool, and should not be compiled into production code without specific debug Kconfig options enabled, or source code changes, as indicated by the warning that shows up on boot if any trace_printk is called: ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE

Re: [RFC PATCH 2/3] dmaengine: add peripheral configuration

2020-08-25 Thread Vinod Koul
Hello Peter, On 25-08-20, 09:52, Peter Ujfalusi wrote: > Hi Vinod, > > On 24/08/2020 11.47, Vinod Koul wrote: > > Some complex dmaengine controllers have capability to program the > > peripheral device, so pass on the peripheral configuration as part of > > dma_slave_config > > > >

Re: [kbuild-all] Re: drivers/greybus/es2.c:439 message_send() error: double unlocked 'es2->cport_out_urb_lock' (orig line 417)

2020-08-25 Thread Johan Hovold
On Tue, Aug 25, 2020 at 02:37:04AM +, Xia, Hui wrote: > >-Original Message- > >From: Johan Hovold > >Sent: 2020年8月24日 17:54 > >To: kernel test robot > >Cc: Greg Kroah-Hartman ; kbuild-...@lists.01.org; > >linux-kernel@vger.kernel.org > >Subject: [kbuild-all] Re:

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-25 Thread Nick Desaulniers
On Mon, Aug 24, 2020 at 10:34 AM Arvind Sankar wrote: > > On Tue, Aug 25, 2020 at 12:57:22AM +0900, Masahiro Yamada wrote: > > > > > > To prevent transformation from foo() into bar(), > > there are two ways in Clang to do that; > > -fno-builtin-foo, and -fno-builtin-bar. > > There is only one in

[PATCH] perf test: Perf test 67 dumps core on s390

2020-08-25 Thread Thomas Richter
Linux 5.9 introduced perf test case "Parse and process metrics" and on s390 this test case always dumps core: [root@t35lp67 perf]# ./perf test - -F 67 67: Parse and process metrics : --- start --- metric expr inst_retired.any / cpu_clk_unhalted.thread for IPC

Re: [PATCH] perf stat: Fix s390x compile error on F32 utils/stat-display.c

2020-08-25 Thread Jiri Olsa
On Tue, Aug 25, 2020 at 08:33:04AM +0200, Thomas Richter wrote: SNIP > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index 57d0706e1330..cbe836649f84 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -117,12 +117,11 @@

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-08-25 Thread Fengkehuan Feng
Hi Hillf, I just tried the updated version and the system can boot up now. It does mitigate the issue a lot but still couldn't get rid of it thoroughly. It seems to me like the effect of Cong's patch. Hillf Danton 于2020年8月25日周二 上午11:23写道: > > > Hi Feng, > > On Tue, 25 Aug 2020 10:18:05 +0800

Re: [PATCH v2 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles

2020-08-25 Thread Krzysztof Kozlowski
On Tue, Aug 25, 2020 at 06:46:53AM +0200, Sascha Hauer wrote: > On Mon, Aug 24, 2020 at 06:26:46PM +0200, Krzysztof Kozlowski wrote: > > +oneOf: > > + - items: > > + - enum: > > + - fsl,imx6q-ocotp > > + - fsl,imx6sl-ocotp > > + -

Re: [PATCH v2 3/9] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM

2020-08-25 Thread Sameer Pujar
Hi Morimoto-san, Other solution is create both snd_soc_find_dai_with_mutex()/without_mutex(). I'm not sure which style is best. I don't know how complex it is to have a unified solution. But if we can protect snd_soc_find_dai() itself, things would be simpler may be in long term. Right now

Re: [PATCH v2 13/19] dt-bindings: nvmem: imx-ocotp: Update i.MX 8M compatibles

2020-08-25 Thread Krzysztof Kozlowski
On Mon, Aug 24, 2020 at 08:39:04PM -0600, Rob Herring wrote: > On Mon, Aug 24, 2020 at 06:26:46PM +0200, Krzysztof Kozlowski wrote: > > DTSes with new i.MX 8M SoCs use two compatibles so update the binding to > > fix dtbs_check warnings like: > > > >

Re: LOOP_CONFIGURE ioctl doesn't work if lo_offset/lo_sizelimit are set

2020-08-25 Thread Martijn Coenen
Hi, I just sent a patch to fix the issue. The loop device would have respected the configuration, but indeed the size of the underlying block device was not set correctly, so reading back the size would give the wrong result. Thanks, Martijn On Mon, Aug 24, 2020 at 8:24 PM Martijn Coenen

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-08-25 Thread Stephen Boyd
Quoting Bjorn Andersson (2020-08-24 09:42:12) > On Fri 21 Aug 14:41 PDT 2020, Stephen Boyd wrote: > > > Quoting Sibi Sankar (2020-08-21 13:49:20) > > > Add GENPD_FLAG_NO_SUSPEND/RESUME flags to instruct genpd to keep the > > > status of the PM domain unaltered during suspend/resume respectively.

Re: [PATCH v18 00/32] per memcg lru_lock

2020-08-25 Thread Michal Hocko
On Mon 24-08-20 11:42:04, Andrew Morton wrote: > On Mon, 24 Aug 2020 20:54:33 +0800 Alex Shi > wrote: > > > The new version which bases on v5.9-rc2. The first 6 patches was picked into > > linux-mm, and add patch 25-32 that do some further post optimization. > > 32 patches, version 18. That's

Re: [PATCH] irqchip/eznps: Fix build error for !ARC700 builds

2020-08-25 Thread Sebastian Andrzej Siewior
On 2020-08-24 16:01:49 [-0700], Vineet Gupta wrote: A little of patch description wouldn't hurt. Especially since it is not a simple move but IENABLE comes out of nowhere. > Reported-by: kernel test robot > Reported-by: Sebastian Andrzej Siewior > Link: >

Re: fsl_espi errors on v5.7.15

2020-08-25 Thread Heiner Kallweit
On 25.08.2020 05:54, Chris Packham wrote: > > On 25/08/20 10:04 am, Chris Packham wrote: >> >> On 20/08/20 9:08 am, Chris Packham wrote: >>> >>> On 19/08/20 6:15 pm, Heiner Kallweit wrote: On 19.08.2020 00:44, Chris Packham wrote: > Hi Again, > > On 17/08/20 9:09 am, Chris

Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes

2020-08-25 Thread Matthias Schiffer
On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer > wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > index 9513020ddd1a..7aaae83c1fae 100644 > > ---

Re: [PATCH] checkpatch: Warn if trace_printk and friends are called

2020-08-25 Thread Joe Perches
On Tue, 2020-08-25 at 15:09 +0800, Nicolas Boichat wrote: > trace_printk is meant as a debugging tool, and should not be > compiled into production code without specific debug Kconfig > options enabled, or source code changes, as indicated by the > warning that shows up on boot if any trace_printk

linux-next: build failure after merge of the akpm-current tree

2020-08-25 Thread Stephen Rothwell
Hi all, After merging the akpm-current tree, today's linux-next build (powerpc allnoconfig) failed like this: mm/memory.c: In function '__apply_to_page_range': mm/memory.c:2358:13: error: 'ARCH_PAGE_TABLE_SYNC_MASK' undeclared (first use in this function) 2358 | if (mask &

Re: [PATCH 4.14 00/51] 4.14.195-rc2 review

2020-08-25 Thread Naresh Kamboju
On Mon, 24 Aug 2020 at 22:19, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.195 release. > There are 51 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

2020-08-25 Thread k...@kernel.org
On Tue, Aug 25, 2020 at 06:51:33AM +, Vaittinen, Matti wrote: > Hello Krzysztof, > > Just some questions - please ignore if I misunderstood the impact of > the change. > > On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > > Device tree schema expects regulator names to be

Re: [Resend PATCH 1/6] mm/memcg: warning on !memcg after readahead page charged

2020-08-25 Thread Michal Hocko
On Tue 25-08-20 09:25:01, Alex Shi wrote: > reproduce using our linux-mm random bug collection on NUMA systems. > >> > >> OK, I must have missed that this was on ppc. The order makes more sense > >> now. I will have a look at this next week. > > > > OK, so I've had a look and I know what's going

Re: [PATCH] ALSA: ca0106: fix error code handling

2020-08-25 Thread Takashi Iwai
On Tue, 25 Aug 2020 00:45:41 +0200, Tong Zhang wrote: > > snd_ca0106_spi_write() returns 1 on error, snd_ca0106_pcm_power_dac() > is returning the error code directly, and the caller is expecting an > negative error code > > Signed-off-by: Tong Zhang Thanks, applied with Cc to stable.

Re: [PATCH] soc: qcom: initialize local variable

2020-08-25 Thread Sibi Sankar
On 2020-08-20 00:16, t...@redhat.com wrote: From: Tom Rix clang static analysis reports this problem pdr_interface.c:596:6: warning: Branch condition evaluates to a garbage value if (!req.service_path[0]) ^~~~ This check that req.service_path was set in

Re: [PATCH v4 7/7] sdhci: tegra: Add missing TMCLK for data timeout

2020-08-25 Thread Jon Hunter
On 24/08/2020 20:15, Sowjanya Komatineni wrote: > commit b5a84ecf025a ("mmc: tegra: Add Tegra210 support") > > Tegra210 and later has a separate sdmmc_legacy_tm (TMCLK) used by Tegra > SDMMC hawdware for data timeout to achive better timeout than using > SDCLK and using TMCLK is recommended. >

Re: [PATCH 0/4] -ffreestanding/-fno-builtin-* patches

2020-08-25 Thread Nick Desaulniers
On Tue, Aug 25, 2020 at 12:10 AM Nick Desaulniers wrote: > > On Mon, Aug 24, 2020 at 10:34 AM Arvind Sankar wrote: > > > > On Tue, Aug 25, 2020 at 12:57:22AM +0900, Masahiro Yamada wrote: > > > > > > > > > To prevent transformation from foo() into bar(), > > > there are two ways in Clang to do

Re: [PATCH v2] HID: roccat: add bounds checking in kone_sysfs_write_settings()

2020-08-25 Thread Dan Carpenter
On Mon, Aug 24, 2020 at 03:35:16PM +, Walter Harms wrote: > hello Dan, > > i notice that you can shorten the line to: > (line above checks for count==sizeof(struct kone_settings)) > > difference = memcmp(settings, >settings, count); > > nothing special just to shorten the line and make use

Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper.

2020-08-25 Thread Guido Günther
Hi Swapnil, On Mon, Aug 24, 2020 at 07:16:31AM +, Swapnil Kashinath Jakhade wrote: [..snip..] > Following are the differences between MHDP IPs from Cadence for Rockchip, TI > and NxP: > > The Rockchip and NXP MHDP Core shares the same part (IP8501) which is DP v1.3 > SST > Controller with

  1   2   3   4   5   6   7   8   9   10   >