On 03/01/08 18:18, Ian Abbott wrote:
On 02/11/07 21:16, [EMAIL PROTECTED] wrote:
The Fake PCI Hot Plug module fakephp does not complete the slot
shutdown and will hang a terminal.
I am attempting to use the fakephp module to shutdown and restart a
PCI Express FPGA board when the FPGA
From: Ian Abbott [EMAIL PROTECTED]
If the fakephp driver is used to emulate removal of a PCI device by
writing text string 0 to the power sysfs attribute file, this causes
its parent directory and its contents (including the power file) to be
deleted before the write operation returns
[ 90.410971] [c0180c4e] vfs_write+0xbe/0x170
[ 90.411033] [c01c3000] sysfs_write_file+0x0/0x110
[ 90.411098] [c0181361] sys_write+0x41/0x70
[ 90.411161] [c01041d2] sysenter_past_esp+0x6b/0xa9
[ 90.411226] [c02f] clip_ioctl+0x500/0x510
[ 90.411290] ===
--
-=( Ian
split out
the one-line fix for 3.6?
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 2012-09-27 16:35, Greg Kroah-Hartman wrote:
On Thu, Sep 27, 2012 at 10:31:17AM +0100, Ian Abbott wrote:
On 2012-09-26 18:56, Greg Kroah-Hartman wrote:
On Wed, Sep 26, 2012 at 10:56:06AM -0700, Greg Kroah-Hartman wrote:
With 3.6 about to be released, I've now closed the 3.7 staging-next
,
- dev-minor);
+ dev_err(dev-class_dev,
+ comedi%d: Failed to remap I/O memory\n, dev-minor);
return -ENOMEM;
}
And the same sort of thing for all of those.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
);
}
Same here.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
.
Apologies for the inconvenience it caused you.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
-count, dev-board.name);
+ dev_info(intf-dev, %s: board #%d [%s] now detached\n,
+ __FILE__, dev-count, dev-board.name);
up(dev-limit_sem);
mutex_unlock(glb_mutex);
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Tel: +44 (0)161
On 10/07/2005 22:11, Parag Warudkar wrote:
What's funny - I rebuilt hotplug - same version - and it works now! Probably
it was failing for some reason the first time.
Maybe the original version separated hotplugging from coldplugging and
your rebuilt version doesn't.
--
-=( Ian Abbott @ MEV
On 2012-07-19 02:24, H Hartley Sweeten wrote:
Introduce a wrapper for to_pci_dev() to allow the comedi pci drivers
to store the pci_dev pointer in the comedi_device hw_dev variable and
retrieve it easily.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo
On 2012-07-19 02:30, H Hartley Sweeten wrote:
Use pci_is_enabled() in the find pci device function to determine if
the found pci device is not in use and move the comedi_pci_enable() call
into the attach.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo
the pci_is_enabled() test for the same reason.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
the linked list.
As mentioned in my replies to your patches to adv_pci1723 and
adv_pci1710, pci_is_enabled() might not be sufficient. I think it's
better just to take out the free/in-use test.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898
if the attach() failed.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 2012-07-19 11:10, Ian Abbott wrote:
On 2012-07-19 02:37, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit
a PCI device.
The original code should have checked thisboard-bustype too although it
works by accident because dev-iobase is 0.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from
On 2012-07-19 11:27, Ian Abbott wrote:
On 2012-07-19 11:10, Ian Abbott wrote:
On 2012-07-19 02:37, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate
On 2012-07-19 11:30, Ian Abbott wrote:
On 2012-07-19 02:39, H Hartley Sweeten wrote:
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.
Since the pci_dev is no longer held in the provate data, we can
also cleanup the detach a bit
to the `from` parameter in dt_pci_find_device()), but your version
is cleaner.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
is really only meant to hold I/O port addresses,
although it is wide enough to hold a 32-bit PCI memory address.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers
.
As I mentioned for dt3000, dev-iobase isn't ideal for holding PCI
memory addresses and is even less ideal to hold a PCI memory address
that is passed to ioremap().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre
= pci_resource_start(pcidev, LAS1_PCIINDEX);
+ physLcfg = pci_resource_start(pcidev, LCFG_PCIINDEX);
...in the use of dev-iobase to hold a PCI memory address.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587
. Please
change it back to 0444 or S_IFREG | S_IRUGO. Thanks.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On 2013-04-11 20:05, Greg Kroah-Hartman wrote:
On Thu, Apr 11, 2013 at 04:15:52PM +0100, David Howells wrote:
Ian Abbott abbo...@mev.co.uk wrote:
Don't use create_proc_read_entry() as that is deprecated, but rather use
proc_create_data() and seq_file instead.
It seems to work okay
. :-)
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, but these can be changed to use
PCI_VENDOR_ID_AMCC easily enough. The only other user of
PCI_VENDOR_ID_ADDIDATA_OLD is drivers/tty/serial/8250_pci.c which
could also be changed to use AMCC easily enough. Once all that is done,
PCI_VENDOR_ID_ADDIDATA_OLD can be removed.
Signed-off-by: Ian Abbott
been written (similarly for
the analog outputs). We could read back the initial state of the
digital and analog outputs during hardware initialization and keep the
state up-to-date in software without having to query the hardware again.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
On 2013-02-13 11:56, Ian Abbott wrote:
For a digital output subdevice, you could either read back the current
values directly from the hardware or just use the value previously
written. The Velleman K8055 doesn't have a command to read back the
digital outputs from the hardware, so the last
foobar_pci_driver = {
.name = foobar,
.id_table = foobar_pci_table,
.probe = foobar_pci_probe,
.remove = comedi_pci_auto_unconfig,
};
module_comedi_pci_driver(foobar_comedi_driver, foobar_pci_driver);
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo
On 2013-01-30 11:04, Ian Abbott wrote:
static int foobar_auto_attach(struct comedi_device *dev,
unsigned long context_bn)
{
struct pci_dev *pcidev = comedi_to_pci_dev(dev);
struct foobar_board *thisboard = foobar_boards[bn_foo];
Oops, I meant
compile and UNIT_none is used by user space.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 2013-01-30 17:54, H Hartley Sweeten wrote:
On Wednesday, January 30, 2013 4:04 AM, Ian Abbott wrote:
Here's some code to illustrate what I'm on about in the above description:
struct foobar_board {
const char *name;
unsigned int ai_chans;
unsigned int ai_bits;
};
I
On 2013/01/24 09:30 PM, Peter Huewe wrote:
Am Donnerstag, 24. Januar 2013, 11:02:35 schrieb Ian Abbott:
On 2013-01-22 23:03, Peter Huewe wrote:
Since comedi_pci_auto_unconfig cannot be inlined anymore after
staging/comedi: Use comedi_pci_auto_unconfig directly for
pci_driver.remove
the exact opposite
previously, but I've no problem doing it this way if it saves some code.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux
of the test altogether.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
;
- if (num_bytes = DMA_BUFFER_SIZE) ;
load_ao_dma(dev, cmd);
dma_start_sync(dev, 0);
I suppose I'd better sign it off since you mentioned me. ;)
Signed-off-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44
of msleep_interruptible().
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
Documentation/timers/timers-howto.txt | 11 +--
include/linux/delay.h | 2 ++
kernel/timer.c| 32 +++-
3 files changed, 38 insertions(+), 7 deletions(-)
diff --git
On 2013-02-22 06:07, Kumar Amit Mehta wrote:
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.
Looks good here too.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Would you mind doing the same for usbdux.c
On 2013-02-22 14:26, Kumar amit mehta wrote:
On Fri, Feb 22, 2013 at 10:02:44AM +, Ian Abbott wrote:
On 2013-02-22 06:07, Kumar Amit Mehta wrote:
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch
version are you using exactly?
--
-=( Ian Abbott @ MEV Ltd.E-mail: [EMAIL PROTECTED])=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
On 02/08/05 22:12, NZG wrote:
On Tuesday 02 August 2005 08:27, Ian Abbott wrote:
On 01/08/05 14:17, NZG wrote:
I managed to successfully cross-compile Comedi for the Coldfire uClinux
2.6, however it has several unresolved symbols when I try to load it.
comedi: Unknown symbol pgd_offset_k
My recent patch to add DIRECT_IO support to the UDF filesystem handler
contains a mistake in the error recovery if blockdev_direct_IO() fails.
The test `rw WRITE` should be `rw WRITE`. Fix it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
fs/udf/inode.c | 2 +-
1 file changed, 1 insertion
by udf_direct_IO().
Also change the whitespace in udf_aops and udf_adinicb_aops to make them
a bit neater.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Rework error handling in udf_direct_IO to avoid calling deprecated
vmtruncate().
---
fs/udf/file.c | 29 +
fs
by udf_direct_IO().
Also change the whitespace in udf_aops and udf_adinicb_aops to make them
a bit neater.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Rework error handling in udf_direct_IO to avoid calling deprecated
vmtruncate().
v3: Rebased to next-20120904.
---
fs/udf/file.c | 29
that for UDF announcements etc. so people caring
about UDF can watch there and don't have to read high-volume LKML).
Oops, sorry about the misspelling. Also, I've noted the linux-fsdevel
for future (I was just following what it said in MAINTAINERS).
On Tue 04-09-12 10:49:39, Ian Abbott wrote:
Add
Some rbtree documentation fixes/changes. After applying these changes,
the rb_entry() macro only gets a single mention in the document to say
it does the same thing as container_of().
1) Documentation/rbtree.txt: Fix possible typo in example
2) Documentation/rbtree.txt: Remove bogus description
in a
patch by Wang Tinggong back in May/June 2009. However, the example code
uses rb_entry() to access the containing structure whereas the preceding
paragraph (now) only mentions container_of(), so change the example to
match the preceding text.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
The example code for rb_erase() usage has a function call to mysearch().
Presumably this ought to be my_search() to match the example code
earlier in the document.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
Documentation/rbtree.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Mention that rb_entry() can be used as a synonym for the standard
container_of() macro.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
Documentation/rbtree.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/rbtree.txt b/Documentation/rbtree.txt
index 47a8cb5
On 2012-09-04 16:11, Ian Abbott wrote:
On 2012-09-04 15:39, Jan Kara wrote:
On Tue 04-09-12 10:49:39, Ian Abbott wrote:
Add support for the O_DIRECT flag. There are two cases to deal with:
Out of curiosity, do you have a use for this feature or is it mostly
academic interest?
I'm
in udf_aops to make it a bit neater.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
v2: Rework error handling in udf_direct_IO to avoid calling deprecated
vmtruncate().
v3: Rebased to next-20120904.
v4: Removed special handling in udf_adinicb_writepage() as that turned
out to be a bug
this
but I can't recall which one of the top of my head...
You could always cast to unsigned long as that is the same size as a
pointer, at least in the Linux kernel.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587
!
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
From: Ian Abbott [EMAIL PROTECTED]
Stable request for 2.6.23.
This patch works around a problem in the fakephp driver when a process
writing 0 to a power sysfs file to fake removal of a PCI device ends
up deadlocking itself in the sysfs code.
The patch is functionally identical to the one
From: Ian Abbott [EMAIL PROTECTED]
Stable request for 2.6.21.
This patch works around a problem in the fakephp driver when a process
writing 0 to a power sysfs file to fake removal of a PCI device ends
up deadlocking itself in the sysfs code.
This patch is *not* functionally identical
From: Ian Abbott [EMAIL PROTECTED]
Stable request for 2.6.24.
This patch works around a problem in the fakephp driver when a process
writing 0 to a power sysfs file to fake removal of a PCI device ends
up deadlocking itself in the sysfs code.
The patch was recently accepted into Linus' tree
From: Ian Abbott [EMAIL PROTECTED]
Stable request for 2.6.22.
This patch works around a problem in the fakephp driver when a process
writing 0 to a power sysfs file to fake removal of a PCI device ends
up deadlocking itself in the sysfs code.
The patch is functionally identical to the one
From: Ian Abbott [EMAIL PROTECTED]
I last sent this 11 days ago and didn't get any replies, so my timeout
handler has kicked in. :)
The patch is same as last time except I've bumped the revision from rc7
to rc8 and have remembered to use diff's -p option this time!
---
From: Ian Abbott [EMAIL
On 23/01/08 17:46, Greg KH wrote:
On Tue, Jan 22, 2008 at 02:28:08PM +, Ian Abbott wrote:
#include linux/init.h
#include linux/string.h
#include linux/slab.h
+#include linux/workqueue.h
#include ../pci.h
#if !defined(MODULE)
@@ -63,10 +64,13 @@ struct dummy_slot {
struct list_head
From: Ian Abbott [EMAIL PROTECTED]
This is the second (or third if you count the resend) version of my
patch to fix the problem of a process deadlocking itself when it uses
the fakephp driver to fake the removal of a PCI device.
This section describes the changes since the first version
From: Ian Abbott [EMAIL PROTECTED]
This is the third version of my patch to fix the problem of a process
deadlocking itself when it uses the fakephp driver to fake the removal
of a PCI device.
This section describes the changes since the first version of the
patch. Skip to the next section
cases in sysfs that do that?
--
-=( Ian Abbott @ MEV Ltd.E-mail: [EMAIL PROTECTED])=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo
for the LAS0_ADC_CONVERSION register are no longer
documented anywhere.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On 2012-07-11 11:20, Ian Abbott wrote:
On 2012-07-11 00:36, H Hartley Sweeten wrote:
My main concern with this series of patches is they make it harder to
determine what the register accesses actually do, mainly due to the
removal of useful comments. For example:
- RtdPacerStart(dev
H Hartley Sweeten's recent series of patches to clean up the rtd520
driver made some of the register accesses harder to understand. Add a
few comments to provide some clues to the reader.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
Cc: Greg
wrapper struct pointer in
the same hole. (Maybe 'h' for 'hardware' would be better than 'u'.)
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe
'struct device *hw_dev' member that could be
used for this purpose.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On 2012-07-21 23:41, Alan Cox wrote:
On Fri, 20 Jul 2012 23:07:06 +0100
Ian Abbott abbo...@mev.co.uk wrote:
I'm getting an Oops in the linux-next tree today after the merge of the
remote-tracking branch 'tty/tty-next'. I bisected it down to commit
36b3c070d2346c890d690d71f6eab02f8c511137
()
because it does not like this i_alloc_type value.
I think the simplest fix would be to add a 'goto' after the assignment
to iinfo-i_lenAlloc, bypassing the call to udf_extend_file().
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0
If the new size is larger than the old size and the old file data was
stored in the ICB (iinfo-i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) and the
new size still fits in the ICB, skip the call to udf_extend_file() as it
does not handle this i_alloc_type value (it calls BUG()).
Signed-off-by: Ian
On 2012-07-23 16:19, Ian Abbott wrote:
Hi folks,
in fs/udf/inode.c, udf_setsize(), if the new size is larger than the old
size and the old data is in the ICB and the new size still fits in the
ICB (iinfo-i_alloc_type == ICBTAG_FLAG_AD_IN_ICB and iinfo-i_lenAlloc
= newsize), udf_extend_file
and the length of the uncopied
part on failure. So if copy_to_user() returns a non-zero value you
should either return -EFAULT or work out the partial amount successfully
read (as long as it is greater than zero) and return that.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
: nothing special here. Just call
blockdev_direct_IO() from our new udf_direct_IO() handler and tidy up
any blocks instantiated outside i_size on error. This is pretty
standard.
Also change the whitespace in udf_aops and udf_adinicb_aops to make them
a bit neater.
Signed-off-by: Ian Abbott abbo
)
...
#endif
Otherwise it will fail to compile when PCMCIA is disabled in the kernel
config. (This was also necessary for USB.)
#if IS_ENABLED(CONFIG_USB)
int comedi_usb_driver_register(struct comedi_driver *comedi_driver,
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
peterhu...@gmx.de
---
v2:
Removed unnecessary stuff. Thanks HartleyIan
This looks (and builds with and without PCMCIA support) fine. Thanks!
Signed-off-by: Ian Abbott abbo...@mev.co.uk
(all 8 patches)
drivers/staging/comedi/comedidev.h | 21 +
drivers/staging/comedi
or DEV_ATTR_PTR could
be used.
[1] see Jargon File.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 2013-07-15 10:41, Ian Abbott wrote:
On 2013-07-15 00:05, Greg Kroah-Hartman wrote:
Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I
considered it, but that would also mean a BUS_PATTR() and the like, which I
guess works, but I hate even a _hint_ of Hungarian notation
on some of their earlier PCI boards. The
PCI_VENDOR_ID_ADDIDATA_OLD define is still being used by the 8250_pci
PCI serial board driver.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedidev.h | 1 -
include/linux/pci_ids.h| 4 +++-
2 files changed, 3 insertions
. Change it to use the more accurate
PCI_VENDOR_ID_AMCC.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/tty/serial/8250/8250_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c
b/drivers/tty/serial/8250/8250_pci.c
index c52948b
), and
PCI_DEVICE_ID_ADDIDATA_APCI7800 has been replaced with a local #define
PCI_DEVICE_ID_AMCC_ADDIDATA_APCI7800 with the same value (0x818e).
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
include/linux/pci_ids.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 9d99119
with #define PCI_DEVICE_ID_AMCC_ADDIDATA_APCI7800.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/tty/serial/8250/8250_pci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c
b/drivers/tty/serial/8250/8250_pci.c
index 3e3d59b..e9b915c
The 8250_pci driver uses PCI_VENDOR_ID_ADDIDATA_OLD (0x10e8),
PCI_DEVICE_ID_ADDIDATA_APCI7800 (0x818e) to recognize the original
ADDI-DATA APCI-7800 PCI serial card. However vendor ID 0x10e8 was
assigned by PCI-SIG to Applied Micro Circuits Corporation (AMCC) and the
associated device ID 0x818e
Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
;
s-maxdata = 0x;
s-insn_read = ni_660x_GPCT_rinsn;
Looks good!
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587
Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write
Staging: comedi: remove MACRO pr_fmt in unioxx5.c
drivers/staging/comedi/drivers/unioxx5.c | 50 ++
1 file changed, 31 insertions(+), 19 deletions(-)
Looks okay!
Reviewed-by: Ian Abbott
unioxx5_subd_priv *usp = s-private;
struct device *csdev = s-device-class_dev;
int i, mask;
mask = (mode == ALL_2_OUTPUT) ? 0xFF : 0x00;
dev_dbg(csdev, mode = %d\n, mask);
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898
to deliver the mail to a proper mail server. :)
(Also, the patches in the driverdev-devel archive don't apply as-is,
partly because it replaces '@' with ' at ', and partly because it
replaces the ezsett character in 'Dieselstraße' with a question mark '?'.)
--
-=( Ian Abbott @ MEV Ltd.E
to the first driver I touched. I found some more
things that could be cleaned up a little.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list
not apply if only one
branch of a conditional statement is a single statement; in the latter
case use braces in both branches: in the CodingStyle).
return;
}
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587
...@yahoo.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
...@yahoo.com
---
2: Some changes to PATCH 2/3 v2 occurred in the immediate context of
changes in this patch. I've redone this patch after updating PATCH 2/3
so that it still applies cleanly.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
of if. Left
braces on single line else if matched to an if requiring braces, per
CodingStyle.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from
.
if (IS_ERR(async-cmd.chanlist)) {
ret = PTR_ERR(async-cmd.chanlist);
async-cmd.chanlist = NULL;
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
--
To unsubscribe from
impression, however, was that this extra clearing is
useless.
Yes, the extra clearing was useless. There are also some useless
initializers for this variable and others.
Fine, apart from the description.
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo
Southwood chase.southw...@yahoo.com
---
.../comedi/drivers/addi-data/hwdrv_apci035.c | 26 +++---
1 file changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Ian Abbott abbo...@mev.co.uk
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0
be propagated, especially for
s626_send_dac() which is only reachable from very few paths.
There are other infinite loops involving calls to the s626_mc_test()
function, but those could be dealt with by other patches.
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk)=-
-=( Tel: +44 (0
On 2014-03-01 05:48, Chase Southwood wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-28 07:35, Chase Southwood wrote:
And finally, are timeouts here even necessary or helpful, or are there
any better ways to do it?
In the case of s626_send_dac
On 2014-03-02 04:13, Chase Southwood wrote:
On Friday, February 28, 2014 11:49 PM, Chase Southwood
chase.southw...@yahoo.com wrote:
On Friday, February 28, 2014 11:26 AM, Ian Abbott abbo...@mev.co.uk wrote:
On 2014-02-28 07:35, Chase Southwood wrote:
[snip]
In the case of s626_send_dac
= comedi_timeout(dev, NULL, NULL, s626_send_dac_eoc,
+ S626_P_FB_BUFFER2_MSB_FF);
+ if (ret)
+ comedi_error(dev, TSL timeout waiting for slot 0 to execute.);
}
/*
--
-=( Ian Abbott @ MEV Ltd.E-mail: abbo...@mev.co.uk
1 - 100 of 2849 matches
Mail list logo
