Re: TCP keepalive seems to send to only one port

2000-12-23 Thread James Morris
code (used for NAT) uses a value of five days for this. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: PROBLEM: 2.4.0 Kernel Fails to compile when CONFIG_IP_NF_FTP isselected

2001-01-05 Thread James Morris
-2.4.0/net' make: *** [_mod_net] Error 2 This is the error I get if I try to compile in the kernel or as a module. Did you configure the kernel with 'Full NAT'? (CONFIG_IP_NF_NAT in the .config file). - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: No buffer space available when using the ip_queue module

2001-06-05 Thread James Morris
, these are standard Netlink sockets, and you can tune their receive buffer sizes via /proc, or use the SO_RCVBUF socket option on the file descriptor. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] Don't attach callback to a going-away netlink socket

2007-04-16 Thread James Morris
Please post networking patches to the networking developer list: http://vger.kernel.org/vger-lists.html#netdev - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: AppArmor FAQ

2007-04-16 Thread James Morris
, with the labeling behavior for newly created objects being controlled from a well defined policy. You probably want to avoid getting into the situation of needing a TE relabel on a production system in any case. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: AppArmor FAQ

2007-04-17 Thread James Morris
-- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: AppArmor FAQ

2007-04-17 Thread James Morris
existing access control. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: AppArmor FAQ

2007-04-17 Thread James Morris
the underlying complexity. Good progress has already been made in this area, and more is expected. I certainly don't think the solution is to start out by ignoring the underlying complexity. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux

Re: AppArmor FAQ

2007-04-17 Thread James Morris
and whatever other fantastic ideas that people might be inclined to drag out of the kitchen sink. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: AppArmor FAQ

2007-04-17 Thread James Morris
. The answer is likely to be it depends. This is not what the discussion is about. It's about addressing the many points in the FAQ posted here which are likely to cause misunderstandings, and then subsequent responses of a similar nature. - James -- James Morris [EMAIL PROTECTED

Re: AppArmor FAQ

2007-04-18 Thread James Morris
-- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: AppArmor FAQ

2007-04-18 Thread James Morris
can't protect against software flaws, which has been a pretty fundamental and widely understood requirement in general computing for at least a decade. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: AppArmor FAQ

2007-04-18 Thread James Morris
On Wed, 18 Apr 2007, Crispin Cowan wrote: James Morris wrote: On Tue, 17 Apr 2007, Alan Cox wrote: I'm not sure if AppArmor can be made good security for the general case, but it is a model that works in the limited http environment (eg .htaccess) and is something people can play

Re: AppArmor FAQ

2007-04-19 Thread James Morris
read the full thread. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: AppArmor FAQ

2007-04-19 Thread James Morris
On Thu, 19 Apr 2007, Stephen Smalley wrote: Lastly, if you want to judge AA as a jail mechanism, I think you'll find it fails there too. So where does that leave it? An easy-to-use yet inadequate solution for MAC or jail. It's not easy to use. -- James Morris [EMAIL PROTECTED

[RFC PATCH] Re: BUG in sysfs_remove_group

2007-04-19 Thread James Morris
(), lookup_one_len_kern(). Additionally, as sysfs_remove_group() does not check the return value of the lookup before using it, a BUG_ON has been added to pinpoint the cause of any problems potentially caused by this (and as a form of annotation). Signed-off-by: James Morris [EMAIL PROTECTED] --- fs/namei.c

[RFC PATCH - Try #2] Re: BUG in sysfs_remove_group

2007-04-20 Thread James Morris
it, a BUG_ON has been added to pinpoint the cause of any problems potentially caused by this (and as a form of annotation). Signed-off-by: James Morris [EMAIL PROTECTED] --- fs/namei.c| 72 +++- fs/sysfs/group.c |6 +++- include

Re: [PATCH] Return EPERM not ECHILD on security_task_wait failure

2007-04-23 Thread James Morris
On Thu, 15 Mar 2007, Roland McGrath wrote: This patch makes do_wait return -EPERM instead of -ECHILD if some children were ruled out solely because security_task_wait failed. What about using the return value from the security_task_wait hook (which should be -EACCES) ? - James -- James

Re: [PATCH] Return EPERM not ECHILD on security_task_wait failure

2007-04-23 Thread James Morris
On Mon, 23 Apr 2007, Roland McGrath wrote: As I said in some earlier discussion following my original patch, that would be fine with me. I haven't coded up that variant, but it's simple enough. Would you like to do it? Sure. -- James Morris [EMAIL PROTECTED] - To unsubscribe from

[PATCH try #2] Return access error not ECHILD on security_task_wait failure

2007-04-23 Thread James Morris
a bug with wait or ptrace or something. This patch makes do_wait return -EACCES (or other appropriate error returned from security_task_wait() instead of -ECHILD if some children were ruled out solely because security_task_wait failed. Signed-off-by: James Morris [EMAIL PROTECTED] --- Updated

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-08 Thread James Morris
to avoid merge commits). This is just one possible workflow. There are probably several better. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: What will be in the x86-64/x86 2.6.21 merge

2007-02-12 Thread James Morris
On Sat, 10 Feb 2007, Andi Kleen wrote: - lguest * still seems heavily in development. Not sure it will be ready in time. How would you define ready? It's currently useful and stable, and features a lack of enterprise-class complexity. - James -- James Morris [EMAIL PROTECTED

Re: What will be in the x86-64/x86 2.6.21 merge

2007-02-12 Thread James Morris
On Mon, 12 Feb 2007, Andi Kleen wrote: It's currently useful and stable, How do you know? I've been working on it for some weeks. At this stage, it's also useful for some simple kernel hacking. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [PATCH 1/8] lguest: Kconfig and headers

2007-02-12 Thread James Morris
FWIW, I've set up an unofficial git tree with these patches, and will try and track changes as they're posted. git://git.infradead.org/~jmorris/lguest-testing.git Use the 'current' branch. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [BUG] 2.6.20 Oopses in xfrm_audit_log

2007-02-12 Thread James Morris
check. How does this look to others? Looks good to me. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-15 Thread James Morris
Hit a BUG() via lvm: Scanning logical volumes Reading all physical volumes. This may take a while... Found volume group VolGroup00 using metadata type lvm2 Activating logical volumes [ 75.215078] [ cut here ] [ 75.230165] kernel BUG at mm/swap.c:442! [

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-15 Thread James Morris
On Thu, 15 Feb 2007, James Morris wrote: Hit a BUG() via lvm: Also, I just disabled paravirt ops and saw the same bug, so it's not that stuff. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-16 Thread James Morris
void try_to_set_mlocked(struct pa struct zone *zone; unsigned long flags; + return; + if (!PageLRU(page) || PageMlocked(page)) return; -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-16 Thread James Morris
00 10 00 74 3f 8b 03 a8 20 74 04 0f 0b eb fe f0 0f ba 2b 05 f0 0f ba 33 14 f0 0f ba 2b 06 ba 03 -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: 2.6.20-mm1 [kernel BUG at mm/swap.c:442]

2007-02-16 Thread James Morris
On Fri, 16 Feb 2007, Christoph Lameter wrote: Andrew already has this fix which cures it for me. PG_mlocked pages can be freed in some situations and thus we need the correct handling in the page allocator: Works for me. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from

Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)

2007-03-20 Thread James Morris
On Tue, 20 Mar 2007, Tasos Parisinos wrote: The main purpose behind the development of this module was to create an in-kernel system of signed modules. I suggest you read this thread: http://lkml.org/lkml/2007/2/14/164 -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send

[PATCH] time: fix formatting in /proc/timer_list

2007-03-21 Thread James Morris
Fix the print formatting of three unsigned long fields in /proc/timer_list, which are currently being formatted as unsigned int. Signed-off-by: James Morris [EMAIL PROTECTED] --- diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c index f82c635..59df5e8 100644 --- a/kernel/time

Re: [PATCH] time: fix formatting in /proc/timer_list

2007-03-21 Thread James Morris
On Wed, 21 Mar 2007, James Morris wrote: Fix the print formatting of three unsigned long fields in /proc/timer_list, which are currently being formatted as unsigned int. ^^ The last bit should be 'signed long'. -- James

Re: oprofile / selinux / security_port_sid

2007-03-27 Thread James Morris
/compat_net = 0 Even with this setting, you'll be hitting security_port_sid() via connect(2) and bind(2). We need to fix it. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 09/29] selinux: tag avc cache alloc as non-critical

2007-02-21 Thread James Morris
On Wed, 21 Feb 2007, Peter Zijlstra wrote: Failing to allocate a cache entry will only harm performance. Signed-off-by: Peter Zijlstra [EMAIL PROTECTED] --- security/selinux/avc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: James Morris [EMAIL PROTECTED] Index

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread James Morris
On Mon, 5 Mar 2007, Venkat Yekkirala wrote: Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: Venkat Yekkirala [EMAIL PROTECTED] What about your previous comment: I guess you meant to do this here? else if (err) return err; -- James Morris [EMAIL

Re: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread James Morris
On Fri, 2 Mar 2007, Eric Paris wrote: Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-05 Thread James Morris
the auditing hooks as well. Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa

2007-03-05 Thread James Morris
to the exit path such that all failures (and successes) will actually get audited. Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: Problem With LOCAL IN HOOK

2007-03-06 Thread James Morris
On Tue, 6 Mar 2007, Kanhu Rauta wrote: I am not able to understand the behavior and struggled to resolve this issue for last 1 week . Can anybody help me on this regard ? Please post a link to your code so people can see the full context. -- James Morris [EMAIL PROTECTED

Re: + stupid-hack-to-make-mainline-build.patch added to -mm tree

2007-03-07 Thread James Morris
in another 10 years? ;) What do you suggest instead ? (Digging into this for lguest now...) - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: + stupid-hack-to-make-mainline-build.patch added to -mm tree

2007-03-07 Thread James Morris
TSC frequency changes, stolen time accounting, synthetic programmable clockevent etc. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH] chaostables

2007-03-08 Thread James Morris
On Thu, 8 Mar 2007, Alan Cox wrote: Any chance of tweaking the name - it's just there is/was a chaosnet protocol/network system and you don't want people to assume that since its a chaosfilter its for chaosnet ? That's exactly what I thought it was from the subject line. - James -- James

Re: [PATCH 9/9] clocksource: refactor duplicate registration checking

2007-03-30 Thread James Morris
clocksource *c) Return should be void, then. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [TOMOYO #6 retry 08/21] Utility functions and policy manipulation interface.

2008-01-08 Thread James Morris
On Wed, 9 Jan 2008, Kentaro Takeda wrote: Common functions for TOMOYO Linux. TOMOYO Linux uses /sys/kernel/security/tomoyo interface for configuration. Why aren't you using securityfs for this? (It was designed for LSMs). - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from

Re: [TOMOYO #6 retry 08/21] Utility functions and policy manipulation interface.

2008-01-08 Thread James Morris
On Wed, 9 Jan 2008, James Morris wrote: On Wed, 9 Jan 2008, Kentaro Takeda wrote: Common functions for TOMOYO Linux. TOMOYO Linux uses /sys/kernel/security/tomoyo interface for configuration. Why aren't you using securityfs for this? (It was designed for LSMs). Doh, it is using

Re: [TOMOYO #6 retry 08/21] Utility functions and policy manipulationinterface.

2008-01-11 Thread James Morris
On Sat, 12 Jan 2008, Tetsuo Handa wrote: Hello. James Morris wrote: TOMOYO Linux uses /sys/kernel/security/tomoyo interface for configuration. Why aren't you using securityfs for this? (It was designed for LSMs). Doh, it is using securityfs, don't worry. I got a mm

[PATCH][RFC] security: call security_file_permission from rw_verify_area

2008-01-12 Thread James Morris
Please review. Tested with SELinux in enforcing mode. --- All instances of rw_verify_area() are followed by a call to security_file_permission(), so just call the latter from the former. Signed-off-by: James Morris [EMAIL PROTECTED] --- fs/compat.c |4 --- fs/read_write.c | 63

Re: [PATCH] selinux: Improving SELinux read/write performance

2007-09-17 Thread James Morris
-- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] NetLabel: Introduce a new kernel configuration API for NetLabel - Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-09 Thread James Morris
subsystem without relying on assistance from userspace. Signed-off-by: Paul Moore [EMAIL PROTECTED] You sent it, so this patch needs a Signed-off-by:you, please. Also add Reviewed-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr

2007-11-16 Thread James Morris
On Fri, 16 Nov 2007, Eric Paris wrote: On Sat, 2007-11-17 at 08:42 +1100, James Morris wrote: On Fri, 16 Nov 2007, Eric Paris wrote: +#ifdef CONFIG_SECURITY + /* + * If a hint addr is less than mmap_min_addr change addr to be as + * low as possible but still greater than

Re: [PATCH 2/3] mmap: round mmap hint address above mmap_min_addr

2007-11-16 Thread James Morris
*/ ret = validate_mmap_request(file, addr, len, prot, flags, pgoff, -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
that it is not done with !CONFIG_SECURITY ? - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
On Fri, 16 Nov 2007, Eric Paris wrote: On Sat, 2007-11-17 at 08:47 +1100, James Morris wrote: On Fri, 16 Nov 2007, Eric Paris wrote: On a kernel with CONFIG_SECURITY but without an LSM which implements security_file_mmap it is impossible for an application to mmap addresses lower

Re: [PATCH 3/3] security: allow capable check to permit mmap or low vm space

2007-11-16 Thread James Morris
still default this to off so noone is going to 'accidentally' see and security checks in the dummy hooks) If it's off by default and generally useful across LSMs, why not just put it in the base kernel code? - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2007-12-19 Thread James Morris
, either. In any case, I think the right solution is not to include security.h at all in mm.h, as it is only being done to get a declaration for mmap_min_addr. How about this, instead ? Signed-off-by: James Morris [EMAIL PROTECTED] --- mm.h |5 - 1 file changed, 4 insertions(+), 1 deletion

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2007-12-19 Thread James Morris
queue it for -mm 2.6.25. - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] mm/mmap: Remove sparse-warning (NULL as 0).

2007-12-21 Thread James Morris
Knutsson [EMAIL PROTECTED] --- Added by: 8869477a49c3e99def1fcdadd6bbc407fea14b45 (Linus' tree) Compile-tested on i386 with all[yes|mod|no]config. Thanks, applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm - James -- James Morris [EMAIL PROTECTED

Re: Out of tree module using LSM

2007-11-29 Thread James Morris
been accepted. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Out of tree module using LSM

2007-11-30 Thread James Morris
by myself) for the case of valid out of tree users. The only case of this so far has been Multiadm, although there seems to be no reason for it to stay out of tree. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: Out of tree module using LSM

2007-11-30 Thread James Morris
have upstream maintain stable kernel APIs which are naturally mismatched to the unknown requirements of out of tree users. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] VM/Security: add security hook to do_brk

2007-12-05 Thread James Morris
security checks in do_brk(). Signed-off-by: Eric Paris [EMAIL PROTECTED] ACK Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [TOMOYO #5 18/18] LSM expansion for TOMOYO Linux.

2007-11-19 Thread James Morris
which touches core networking to netdev, too, and get an ack from one of the core developers there. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH 57/59] security/selinux: Add missing space

2007-11-19 Thread James Morris
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [patch 1/1] selinux: do not clear f_op when removing entries

2007-11-21 Thread James Morris
On Wed, 21 Nov 2007, Stephen Smalley wrote: Do not clear f_op when removing entries since it isn't safe to do. Signed-off-by: Stephen Smalley [EMAIL PROTECTED] Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James Morris [EMAIL PROTECTED

Re: [PATCH 3/3-v2] security: allow capable check to permit mmap or low vm space

2007-11-26 Thread James Morris
with mmap_min_addr set. Signed-off-by: Eric Paris [EMAIL PROTECTED] Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm If nobody hollers, I'll push it to Linus when the next merge window opens. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe

Re: [PATCH -mm 2/2] do_wait: cleanup delay_group_leader() usage

2007-11-26 Thread James Morris
: /* * It's running now, so it might later * exit, stop, or stop and then continue. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 1/3] mmap: protect from stack expantion into low vm addresses

2007-11-26 Thread James Morris
; /* Somebody else might have raced and expanded it already */ if (address vma-vm_start) { unsigned long size, grow; -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH 2/3 -v2] mmap: round mmap hint address above mmap_min_addr

2007-11-26 Thread James Morris
); + /* decide whether we should attempt the mapping, and if so what sort of * mapping */ ret = validate_mmap_request(file, addr, len, prot, flags, pgoff, -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: Out of tree module using LSM

2007-11-28 Thread James Morris
. Then, propose a solution to the problem and have it reviewed by core kernel folk (cc it to lkml), so that it can be evaluated in terms of e.g. VFS correctness, maintainability etc. That would be at least a useful first step in taking this issue seriously. Thanks, - James -- James Morris [EMAIL

Re: [PATCH] Fix lguest documentation

2007-12-08 Thread James Morris
On Sat, 8 Dec 2007, Sheela wrote: Share net is not supported , Rusty is an idiot . Signed-off-by: Sheela Sequeira [EMAIL PROTECTED] Reviewed-by: James Morris [EMAIL PROTECTED] - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux

Re: [patch, rfc] mm.h, security.h, key.h and preventing namespace poisoning

2007-12-25 Thread James Morris
On Tue, 25 Dec 2007, Andrew Morton wrote: On Thu, 20 Dec 2007 15:11:40 +1100 (EST) James Morris [EMAIL PROTECTED] wrote: +#ifdef CONFIG_SECURITY +extern unsigned long mmap_min_addr; +#endif + #include asm/page.h #include asm/pgtable.h #include asm/processor.h

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-25 Thread James Morris
). Any clues/hints/advice/patches? Can you post your .config ? Also, is that the plain upstream Tcl package you're compiling, or a distro package? -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread James Morris
On Wed, 26 Dec 2007, [EMAIL PROTECTED] wrote: On Wed, 26 Dec 2007 18:34:26 +1100, James Morris said: Can you post your .config ? The gzip'ed config as of when I quit bisecting is attached. It's probably not directly usable unless you have a quilt tree that's positioned fairly close

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread James Morris
On Wed, 26 Dec 2007, James Morris wrote: What does the following say ? # sestatus rpm -q selinux-policy Don't worry about that -- I reproduced it with Paul Moore's git tree: git://git.infradead.org/users/pcmoore/lblnet-2.6_testing (under current -mm, the e1000 driver doesn't find my

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread James Morris
never being initialized correctly? To my untrained eye it looks like __netdev_alloc_skb() should be setting skb-iif (like it does for skb-dev) but it currently doesn't. -iif will be zeroed during skb allocation, then set during netif_receive_skb(). - James -- James Morris [EMAIL

Re: 2.6.24-rc6-mm1 - e1000 breakage

2007-12-26 Thread James Morris
On Wed, 26 Dec 2007, Andrew Morton wrote: (under current -mm, the e1000 driver doesn't find my ethernet card the tcl tests won't run without an external interface). You might need to enable CONFIG_E1000E. Indeed, it works for me. - James -- James Morris [EMAIL PROTECTED

Re: [PATCH] Exporting capability code/name pairs

2007-12-27 Thread James Morris
); + if (rc) + return rc; + + *ppos += count; Use simple_read_from_buffer(). - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] Exporting capability code/name pairs

2007-12-27 Thread James Morris
On Fri, 28 Dec 2007, KaiGai Kohei wrote: + snprintf(tmp, sizeof(tmp), + cap_entry == cap_entries[0] ? 0x%08x : %u, + cap_entry-code); + len = strlen(tmp); You don't need to call strlen(), just use scnprintf() and grab the return value. - James -- James

Re: [PATCH] Exporting capability code/name pairs

2007-12-28 Thread James Morris
); + if (!f_caps[i]) Ditto. Another issue is that securityfs depends on CONFIG_SECURITY, which might be undesirable, given that capabilities are a standard feature. - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] security: remove security_sb_post_mountroot hook

2007-12-29 Thread James Morris
initramfs. Stephen Smalley confirmed on 2007-07-19 that this hook was originally used by SELinux but can now be safely removed: http://marc.info/?l=linux-kernelm=118485683612916w=2 Thanks. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm -- James

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-31 Thread James Morris
in __copy_skb_header() Seems valid. - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] Exporting capability code/name pairs

2008-01-02 Thread James Morris
? I prefer procfs or sysfs instead. Sysfs makes more sense, as this information is system-wide and does not relate to specific processes. -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [AppArmor 34/45] Factor out sysctl pathname code

2007-10-26 Thread James Morris
On Thu, 25 Oct 2007, [EMAIL PROTECTED] wrote: Convert the selinux sysctl pathname computation code into a standalone function. Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Signed-off-by: John Johansen [EMAIL PROTECTED] Reviewed-by: James Morris [EMAIL PROTECTED] -- James Morris

Re: [PATCHv2] selinux: suppress a warning for 64k pages.

2007-10-31 Thread James Morris
+++-- 1 files changed, 7 insertions(+), 6 deletions(-) This version suppresses the warning without ugly ifdefs. Thanks, Stephen. Applied to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-linus -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: LSM conversion to static interface

2007-10-19 Thread James Morris
. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: LSM conversion to static interface

2007-10-20 Thread James Morris
maintenance, as your code will be visible in the tree. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: LSM conversion to static interface [revert patch]

2007-10-22 Thread James Morris
capability_exit and general modular bits for security/capability.c. - James -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH 07/37] Security: De-embed task security record from task and use refcounting

2008-02-11 Thread James Morris
; } Why manually copy these fields after a kmemdup? What about the task backpointer? (i.e. tsec2-task) -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 06/37] Security: Separate task security context from task_struct

2008-02-11 Thread James Morris
. Sparc needs further alteration as it refers to UID GID in sclow.S via asm offsets. Signed-off-by: David Howells [EMAIL PROTECTED] Reviewed-by: James Morris [EMAIL PROTECTED] (SELinux stuff mostly). -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line

Re: [PATCH 05/37] Security: Change current-fs[ug]id to current_fs[ug]id()

2008-02-11 Thread James Morris
On Fri, 8 Feb 2008, David Howells wrote: Change current-fs[ug]id to current_fs[ug]id() so that fsgid and fsuid can be separated from the task_struct. Signed-off-by: David Howells [EMAIL PROTECTED] Reviewed-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED

Re: [PATCH 08/37] Security: Add a kernel_service object class to SELinux

2008-02-11 Thread James Morris
SECCLASS_KERNEL_SERVICE 69 I just pushed a patch to Linus from Stephen which uses this class number; you'll likely need to bump it to 70. -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [2.6 patch] make secmark_tg_destroy() static

2008-02-13 Thread James Morris
] Applied -- will push to Linus unless the netfilter folk do it first. - James -- James Morris [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PULL] IBM vTPM driver update

2012-10-31 Thread James Morris
/shpedoikal/linux.git tpmdd-v3.7-rc3 I get massive merge conflicts pulling this into my -next branch. -- James Morris jmor...@namei.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PULL] IBM vTPM driver update

2012-11-01 Thread James Morris
this? Nope, my 'master' tracks Linus. Use the -next branch. See http://kernsec.org/wiki/index.php/Kernel_Repository -- James Morris jmor...@namei.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PULL v2] IBM vTPM driver update

2012-11-02 Thread James Morris
://vger.kernel.org/majordomo-info.html -- James Morris jmor...@namei.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH 1/1] drivers/char/tpm: remove tasklet and cleanup

2012-09-23 Thread James Morris
at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- James Morris jmor...@namei.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 2/4] security: introduce kernel_module_from_file hook

2012-10-05 Thread James Morris
. Other LSMs can, for example, read extended attributes for signatures, etc. Signed-off-by: Kees Cook keesc...@chromium.org Acked-by: Serge E. Hallyn serge.hal...@canonical.com Acked-by: Eric Paris epa...@redhat.com Acked-by: Mimi Zohar zo...@us.ibm.com Acked-by: James Morris james.l.mor

[GIT] Security subsystem: IMA bugfix

2012-10-05 Thread James Morris
Kasatkin dmitry.kasat...@intel.com Signed-off-by: Mimi Zohar zo...@linux.vnet.ibm.com Signed-off-by: James Morris james.l.mor...@oracle.com diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h index 8180add..6ee8826 100644 --- a/security/integrity/ima/ima.h +++ b

[GIT] TPM bugfixes

2012-10-11 Thread James Morris
/pub/scm/linux/kernel/git/jmorris/linux-security.git for-linus Gang Wei (1): driver/char/tpm: fix regression causesd by ppi James Morris (2): Merge branch 'tpmdd-fixes-v3.6' of git://github.com/shpedoikal/linux into for-linus Merge branch 'tpmdd-next-v3.6' of git://github.com

  1   2   3   4   5   6   7   8   9   10   >