Re: quota and 2.4.0-ac9

2001-01-18 Thread Jan Kara
When running 'quotaon -a' I get message 'quotaon: using /quota.user on /dev/hdc3: Invalid argument'. This occurs at least with 2.4.0-ac4 and 2.4.0-ac9, but not with 2.4.0. That's because 2.4.0-ac? supports new quota format which is incompatible with the old one... You need also new

Small bugfix in ext2/namei.c

2000-09-01 Thread Jan Kara
Hello. Following patch against 2.4.0-test7 fixes returning of errors from ext2_new_inode(). Currenly if ext2_new_inode() failed EIO was returned from functions like ext2_create() which is bad as it can fail also with EDQUOT and such.

Re: Bugfix in dquot_transfer()

2000-09-14 Thread Jan Kara
On Mon, 4 Sep 2000, Jan Kara wrote: Hello. Following patch fixes bug in dquot_transfer() - while we were sleeping i_blocks might change and so number quota was miscounted. Patches are against 2.2.16 and 2.4.0-test6 (but should apply well on newer versions). Umm

Re: Bugfix in dquot_transfer()

2000-09-14 Thread Jan Kara
of blocks after notify_change() once more all the quota will be counted properly. The only problem is that quota can be exceeded this way. We have to check Nope. You've just shifted the race window (and inverted the effect) - think what happens if you've got new allocations after

Re: Bugfix in dquot_transfer()

2000-09-17 Thread Jan Kara
How about the following: * dquot_{alloc,free}_block() _never_ blocks. * we have 3 inlined helper functions - alloc_block(), free_block() and change_xid(). They get exclusion (BKL, spinlock, whatever) and update both quota and i_blocks. Consequences: * quota for

Re: [PATCH] (was: [OOPS] dquot_transfer() - 2.4.0-test8)

2000-09-14 Thread Jan Kara
On Mon, 11 Sep 2000, Martin Diehl wrote: transfer_to[cnt] is initialized to NODQUOT from the first loop (due to several continue's e.g.) when entering the second loop. Unfortunately I do not feel familiar enough to the quota code to provide a patch for this problem. well, was a

Fixes in quota (fwd)

2000-09-29 Thread Jan Kara
Hello. So I did the fixes of races in quota Al found. The patch can be found at ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/quota-fix-2.4.0-test8-1.diff. In the patch are included also some cleanups (especially change in invalidate_dquots()) which I originally wanted to

Quota fixes and a few questions

2000-09-27 Thread Jan Kara
Hello. So I've been thinking about fixes in quota (and also writing some parts). I think I thought of a bit easier implementation of featureas Al suggested. So: * i_blocks is updated by quota in DQUOT_{ALLOC|FREE}_BLOCK (as a bonus we get fix of those unpleasant ext2 preallocation vs.

Quota fixes

2000-10-19 Thread Jan Kara
Hello. I found one bug in the quota fixes (forgot to mark_inode_dirty() when i_blocks were changed). Patch which fixes this is at: ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/quota-fix-2.4.0-test9-2a.diff It's supposed to be applied after quota-fix-2.4.0-test9-1.diff in the

Re: Quota fixes and a few questions

2000-10-19 Thread Jan Kara
Hello. "Stephen C. Tweedie" wrote: Hi Jan, On Wed, Sep 27, 2000 at 02:56:20PM +0200, Jan Kara wrote: So I've been thinking about fixes in quota (and also writing some parts). While we're at it, I've attached a patch which I was sent which simply tea

Re: quota 2.2.x

2000-10-24 Thread Jan Kara
Hello. Running with 2.2.17 VFS: Diskquotas version dquot_6.4.0 initialized We have some problem with the quota with only SOME users. Is there any new version of quota which fix this kind of bug ? #cat /etc/fstab | grep home /dev/rd/c0d0p7 /home ext2defaults,usrquota1 2

Small fix in quota

2000-11-21 Thread Jan Kara
Hello. I'm sending you a small fix in quota. Currently on systems with many different users there are problems that too many dquots are bound in unused inodes. Following patch fixes it - quota tries to get dquots from unused inodes more than once.

Umount quotas

2000-11-21 Thread Jan Kara
Hello. After rewrite of umount checks some time ago (just now reading your mail I realized I never asked) filesystem doesn't umount when quotas are turned on on it - it fails on check (atomic_read(mnt-mnt_count) 2) in do_umount(). Is this intended behaviour? If so, we can remove later

Re: Umount quotas

2000-11-21 Thread Jan Kara
Hello. --- fs/super.c Thu Nov 2 22:38:59 2000 +++ fs/super.c.new Tue Nov 21 11:36:05 2000 @@ -1037,13 +1037,13 @@ } spin_lock(dcache_lock); - if (atomic_read(mnt-mnt_count) 2) { - spin_unlock(dcache_lock); - mntput(mnt); -

Re: Quota files on root FS get too large error after 2.4.x upgrade

2000-11-21 Thread Jan Kara
Hello. After installing and configuring kernel 2.4.0-test11, all is working well, except quota's on the root FS. I am at a loss as to how to correct this: ls -l /quota.* ls: /quota.group: Value too large for defined data type ls: /quota.user: Value too large for defined data type rm

Umount quotas

2000-11-28 Thread Jan Kara
Hello. After rewrite on umount code automagical turning of quotas off stopped working - filesystem was considered busy. I would restore the behaviour in 2.4 and probably in 2.5 move this to userland together with other quota changes... Following patch (written by Al Viro) should restore

Re: Used space in bytes

2000-11-14 Thread Jan Kara
On 14 Nov 00 at 18:39, Jan Kara wrote: Hello. On 9 Nov 00 at 19:18, Jan Kara wrote: used (I tried to contact Ulrich Drepper [EMAIL PROTECTED] who should be right person to ask about such things (at least I was said so) but go no answer...). Does anybody have any better

[PATCH] Quota patches for test12

2000-12-21 Thread Jan Kara
Hello. I've ported my quota patches for 2.4.0-test12. You can download the patches from ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/ quota-fix-2.4.0-test12-1.diff.gz and quota-patch-2.4.0-test12-1.diff.gz Honza - To unsubscribe from this

Re: [PATCH] Quota patches for test12

2000-12-21 Thread Jan Kara
I've ported my quota patches for 2.4.0-test12. You can download the patches from ftp://atrey.karlin.mff.cuni.cz/pub/local/jack/quota/v2.4/ quota-fix-2.4.0-test12-1.diff.gz and quota-patch-2.4.0-test12-1.diff.gz Sorry to follow up myself. I had better tell what those patches do :-):

Re: Where to get quota.

2001-01-05 Thread Jan Kara
Hello. Perhaps the help text for disk quotas needs to be updated, or at least the howto for quotas. The help text for disk quotas says to see the Quota mini-HOWTO. The howto says to get the quota source from: ftp://ftp.funet.fi/pub/Linux/PEOPLE/Linus/subsystems/quota/all.tar.gz

Update of quota patches

2001-01-05 Thread Jan Kara
Hello. So I've updated my quota patches for 2.4.0-prerelease. I also fixed one locking bug in implementation of new quotafile format and added a few comments. I also fixed compilation problems (when quota was disabled) - Alan, were there any problems I didn't fix (I've seen you and someone

Small fix

2000-11-03 Thread Jan Kara
Hello. I've got a report that some people using quotas for lots of users are experiencing being out of dquots. The problem is that we have quota structs bound in unused inodes and we are not aggressive enough to get it back. The following patch should fix it (OK, more proper would be to make

Re: [patch] linux likes to kill bad inodes

2001-04-26 Thread Jan Kara
happen. Honza -- Jan Kara [EMAIL PROTECTED] SuSE Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Update of quota patches

2001-05-07 Thread Jan Kara
Hello. I'm sending you update of my quota patches. There are fixed some syscall issues on ia64, sparc64 and s390x architectures. There's also one small bugfix (or maybe new feature :)) - general users are now allowed to get information about quota files. The incremental patch is attached.

Re: filldir() function

2001-06-20 Thread Jan Kara
by user. Honza -- Jan Kara [EMAIL PROTECTED] SuSE Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: block size for quotas?

2001-02-09 Thread Jan Kara
Hello. I maintain quotatool, a command-line quota utility. Right now, I'm using BLOCK_SIZE -- defined in linux/fs.h -- to convert between blocks and bytes. I'd like to not use the linux header files at all for this, but how else can I find the info? In current kernel there's no

Re: [PATCH 0/6] UDF cleanup and fixes

2007-04-16 Thread Jan Kara
On Thu, Apr 12, 2007 at 18:01:12 +0200, Jan Kara wrote: On Wed 04-04-07 08:36:20, Tino Keitel wrote: On Mon, Apr 02, 2007 at 10:48:27 -0400, Chuck Ebbert wrote: [...] Well, it works for me on 32-bit as well, right up to 100% full. No problems at all... Maybe

Re: why UDF have so ugly filesize limit?

2007-04-20 Thread Jan Kara
;). Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: BUG: Dentry still in use during umount in 2.6.21-rc5-git6

2007-04-24 Thread Jan Kara
majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 1/7] revoke: special mmap handling

2007-03-12 Thread Jan Kara
has been revoked */ + Is it intended to conflict with VM_ALWAYSDUMP? I'd guess not and if yes, it definitely deserves a comment... Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list

Re: do_generic_mapping_read performance issue

2007-03-12 Thread Jan Kara
I'm not sure anybody remembers ;). Nick, do you have an idea? Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: do_generic_mapping_read performance issue

2007-03-12 Thread Jan Kara
On Mon 12-03-07 15:39:00, Nick Piggin wrote: On Mon, Mar 12, 2007 at 03:20:12PM +0100, Jan Kara wrote: Hi, Hi, I am encountering a performance problem, which I have tracked into the Linux kernel. The problem occurs with my experimental web server that uses sendfile

Re: do_generic_mapping_read performance issue

2007-03-12 Thread Jan Kara
On Mon 12-03-07 13:05:17, Ashif Harji wrote: On Mon, 12 Mar 2007, Jan Kara wrote: On Mon 12-03-07 15:39:00, Nick Piggin wrote: On Mon, Mar 12, 2007 at 03:20:12PM +0100, Jan Kara wrote: Hi, Hi, I am encountering a performance problem, which I have tracked into the Linux kernel

Re: do_generic_mapping_read performance issue

2007-03-13 Thread Jan Kara
. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] FAT: DIO-write fallback to normal buffered

2007-02-14 Thread Jan Kara
-by: OGAWA Hirofumi [EMAIL PROTECTED] Signed-off-by: Jan Kara [EMAIL PROTECTED] Just to explain a bit: I think that returning EINVAL is quite unexpected for users in this case (I actually got a bugreport which turned out to be this problem) and fallback to buffered IO seems to be a reasonable

Re: PROBLEM: 2.6.19.1 Oops while doing Disk IO + playing sound, 2.6.20 too

2007-02-14 Thread Jan Kara
On Sun 11-02-07 14:59:53, Frank Hartmann wrote: Jan Kara [EMAIL PROTECTED] writes: OK, thanks for the news. Please, write me when you try out 2.6.20. Just if it rings bell to someone on this list: It looks like the page had no buffers but PagePrivate was set. Strange. Hi Jan, below

Re: PROBLEM: 2.6.19.1 Oops while doing Disk IO + playing sound, 2.6.20 too

2007-02-15 Thread Jan Kara
On Thu 15-02-07 00:33:31, Frank Hartmann wrote: Jan Kara [EMAIL PROTECTED] writes: Yes I see some correlation. Again it seems there is a problem with buffers attached to a page which got truncated but Private flag of the page stayed. It's probably not important but just out of curiosity

Re: PROBLEM: 2.6.19.1 Oops while doing Disk IO + playing sound, 2.6.20 too

2007-02-16 Thread Jan Kara
On Fri 16-02-07 00:01:32, Frank Hartmann wrote: Jan Kara [EMAIL PROTECTED] writes: On Thu 15-02-07 00:33:31, Frank Hartmann wrote: Jan Kara [EMAIL PROTECTED] writes: Yes I see some correlation. Again it seems there is a problem with buffers attached to a page which got

Re: dquot.c: possible circular locking Re: [2.6.20] BUG: workqueue leaked lock

2007-03-20 Thread Jan Kara
of that dependency either. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: dquot.c: possible circular locking Re: [2.6.20] BUG: workqueue leaked lock

2007-03-20 Thread Jan Kara
On Tue 20-03-07 14:44:46, Jarek Poplawski wrote: On Tue, Mar 20, 2007 at 01:19:09PM +0100, Jan Kara wrote: On Tue 20-03-07 12:31:51, Jarek Poplawski wrote: On Tue, Mar 20, 2007 at 12:22:53PM +0100, Jarek Poplawski wrote: On Tue, Mar 20, 2007 at 12:17:01PM +0100, Jarek Poplawski wrote

Re: dquot.c: possible circular locking Re: [2.6.20] BUG: workqueue leaked lock

2007-03-20 Thread Jan Kara
. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] Improve heuristic detecting sequential reads

2007-04-10 Thread Jan Kara
? Bye Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs Introduce ra.offset and store in it an offset where the previous read ended. This way we can detect whether reads are really sequential (and thus we should not mark the page

Re: [PATCH] Improve heuristic detecting sequential reads

2007-04-11 Thread Jan Kara
On Tue 10-04-07 19:27:22, Andrew Morton wrote: On Tue, 10 Apr 2007 17:54:11 +0200 Jan Kara [EMAIL PROTECTED] wrote: Introduce ra.offset and store in it an offset where the previous read ended. This way we can detect whether reads are really sequential (and thus we should not mark

Re: [PATCH] Improve heuristic detecting sequential reads

2007-04-12 Thread Jan Kara
. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs Rename file_ra_state.prev_page to prev_index and file_ra_state.offset to prev_offset. Also update of prev_index in do_generic_mapping_read() is now moved close to the update of prev_offset. Signed-off-by: Jan Kara [EMAIL PROTECTED] diff

Re: [PATCH 0/6] UDF cleanup and fixes

2007-04-12 Thread Jan Kara
? Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [2.6 patch] make remove_inode_dquot_ref() static

2007-02-20 Thread Jan Kara
On Tue 20-02-07 01:07:38, Adrian Bunk wrote: remove_inode_dquot_ref() can now become static. ACK. I should have noticed it when acking Christophs patch... Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Jan Kara [EMAIL PROTECTED

Re: [RFC] Heads up on sys_fallocate()

2007-03-05 Thread Jan Kara
guide preallocation for things like defragmentation (e.g. preallocate space for the file being defragmented and move the file to it). Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line

[PATCH 0/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
of following patches for details. The patches sustained some torturing so I hope that I did not introduce more bugs than I've fixed ;). Andrew, could you please put the patches into -mm kernels for testing? Thanks. Honza -- Jan

[PATCH 1/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Use sector_t and loff_t for file offsets in UDF filesystem. Otherwise an overflow may occur for long files. Also make inode_bmap() return offset in the extent in number of blocks instead of number of bytes - for most callers this is more convenient. Signed-off-by: Jan Kara [EMAIL PROTECTED

[PATCH 3/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Make UDF use get_bh() instead of directly accessing b_count and use brelse() instead of udf_release_data() which does just brelse()... Signed-off-by: Jan Kara [EMAIL PROTECTED] diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-2-udf_extent_position_t/fs/udf/balloc.c linux-2.6.20-3

[PATCH 4/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Add a few assertions into udf_discard_prealloc() to check that the file is sane (mostly helps debugging further patches ;). Signed-off-by: Jan Kara [EMAIL PROTECTED] diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-3-udf_buffer_handling/fs/udf/truncate.c linux-2.6.20-4

[PATCH 5/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
Make UDF work correctly for files larger than 1GB. As no extent can be longer than (130)-blocksize bytes, we have to create several extents if a big hole is being created. As a side-effect, we now don't discard preallocated blocks when creating a hole. Signed-off-by: Jan Kara [EMAIL PROTECTED

[PATCH 6/6] UDF cleanup and fixes

2007-03-06 Thread Jan Kara
We have to decrease link-count of the parent directory when removing a subdirectory. Signed-off-by: Jan Kara [EMAIL PROTECTED] diff -rupX /home/jack/.kerndiffexclude linux-2.6.20-5-large_file_fix/fs/udf/namei.c linux-2.6.20-6-rmdir_fix/fs/udf/namei.c --- linux-2.6.20-5-large_file_fix/fs/udf

Re: [RFC] Heads up on sys_fallocate()

2007-03-06 Thread Jan Kara
because it needs a few blocks from a ton of distinct files (shared libs, config files, etc). As these files are mostly read only, it's advantageous to interleave them on disk or at least keep them close. Honza -- Jan Kara

Re: [RFC] Heads up on sys_fallocate()

2007-03-07 Thread Jan Kara
On Tue 06-03-07 12:23:22, Eric Sandeen wrote: Jan Kara wrote: On Tue 06-03-07 06:36:09, Ulrich Drepper wrote: Christoph Hellwig wrote: fallocate with the whence argument and flags is already quite complicated, I'd rather have another call for placement decisions, that would be called

Re: Corrupt XFS -Filesystems on new Hardware and Kernel

2007-03-29 Thread Jan Kara
... Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Linux page cache issue?

2007-03-29 Thread Jan Kara
- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs

Re: Linux page cache issue?

2007-04-02 Thread Jan Kara
file will be affected. Is this the aliasing issue you referred to? Yes, this is exactly what I meant. Note that these problems are not only about writes but also about truncate and such... Honza -- Jan Kara [EMAIL PROTECTED] SuSE

Re: [PATCH 0/6] UDF cleanup and fixes

2007-04-02 Thread Jan Kara
On Fri 30-03-07 06:59:23, Tino Keitel wrote: On Tue, Mar 06, 2007 at 17:44:47 +0100, Jan Kara wrote: Hello, the patches attached to six following emails implement some cleanup and fixes in the UDF code. The main two fixes are: 1) UDF now works correctly for files larger than 1GB

Re: [PATCH 0/6] UDF cleanup and fixes

2007-04-02 Thread Jan Kara
On Fri 30-03-07 06:59:23, Tino Keitel wrote: On Tue, Mar 06, 2007 at 17:44:47 +0100, Jan Kara wrote: Hello, the patches attached to six following emails implement some cleanup and fixes in the UDF code. The main two fixes are: 1) UDF now works correctly for files larger than 1GB

Re: [PATCH 19/24] udf: check if udf_load_logicalvol failed

2008-01-07 Thread Jan Kara
On Sun 23-12-07 02:51:09, [EMAIL PROTECTED] wrote: udf_load_logicalvol may fail eg in out of memory conditions - check it and propagate error further Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] I certainly agree

Re: [PATCH 21/24] udf: remove some UDF_SB_* macros

2008-01-07 Thread Jan Kara
PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] Looks fine. Acked-by: Jan Kara [EMAIL PROTECTED] Honza --- fs/udf/balloc.c| 76 +++-- fs/udf/inode.c |2

Re: [PATCH 22/24] udf: convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function

2008-01-07 Thread Jan Kara
On Sun 23-12-07 02:51:12, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] Looks much better :). Acked-by: Jan Kara [EMAIL PROTECTED

Re: [PATCH 23/24] udf: convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function

2008-01-07 Thread Jan Kara
PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] Looks fine. Acked-by: Jan Kara [EMAIL PROTECTED] Honza --- fs/udf/super.c |8 fs/udf/udf_sb.h | 31 ++- 2 files

Re: [PATCH 24/24] udf: fix sparse warnings (shadowing mismatch between declaration and definition)

2008-01-07 Thread Jan Kara
-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] Looks fine. Acked-by: Jan Kara [EMAIL PROTECTED] Honza --- fs/udf/super.c |3 +-- 1 files

Re: [PATCH] udf: fix coding style of super.c

2008-01-07 Thread Jan Kara
Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] I've already acked this patch in the previous submission so I ack it here as well :) Honza --- fs/udf/super.c | 295

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-07 Thread Jan Kara
); + if (bit_already_cleared) + udf_debug(bit already cleared for block %d\n, bit); + } while (bit_already_cleared); mark_buffer_dirty(bh); -- 1.5.3.7 -- Jan Kara [EMAIL PROTECTED] SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 5/7] udf: convert byte order of constant instead of variable

2008-01-07 Thread Jan Kara
On Sun 06-01-08 02:21:51, [EMAIL PROTECTED] wrote: convert byte order of constant instead of variable, which can be done at compile time (vs run time) Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] OK, makes sence. Acked-by: Jan Kara [EMAIL PROTECTED

Re: [PATCH] Handle i_size s_maxbytes correctly

2008-01-07 Thread Jan Kara
On Sat 22-12-07 00:12:06, Andrew Morton wrote: Sorry for a late reply but I was on vacation. On Thu, 20 Dec 2007 18:51:04 +0100 Jan Kara [EMAIL PROTECTED] wrote: Although we don't allow writes over s_maxbytes, it can happen that a file's size is larger than s_maxbytes. For example we can

Re: [PATCH] Handle i_size s_maxbytes correctly

2008-01-07 Thread Jan Kara
to i_size_read_trunc() and if I fail I'll investigate how hard it would be to handle the problems inside OCFS2. Honza -- Jan Kara [EMAIL PROTECTED] SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 4/7] udf: replace loops coded with goto to real loops

2008-01-08 Thread Jan Kara
On Mon 07-01-08 22:10:01, Marcin Slusarz wrote: On Mon, Jan 07, 2008 at 03:48:21PM +0100, Jan Kara wrote: On Sun 06-01-08 02:21:50, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] I'm not sure if this improves readability in general. If the code is really

Re: [PATCH] udf: convert some macros to functions

2008-01-08 Thread Jan Kara
... Honza -- Jan Kara [EMAIL PROTECTED] SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Handle i_size s_maxbytes correctly

2008-01-09 Thread Jan Kara
Hi Andrew, On Sat 22-12-07 00:12:06, Andrew Morton wrote: On Thu, 20 Dec 2007 18:51:04 +0100 Jan Kara [EMAIL PROTECTED] wrote: Although we don't allow writes over s_maxbytes, it can happen that a file's size is larger than s_maxbytes. For example we can write the file from a computer

Re: Oops in touch_atime for kernel 2.6.23.12

2008-01-09 Thread Jan Kara
8b 54 53 54 7e 35 8b 1c 00 00 74 24 04 8b 7c 24 40 28 c4 0c c3 0f b7 43 8b 4c 00 Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [vm] writing to UDF DVD+RW (/dev/sr0) while under memory pressure: box == doorstop

2008-01-10 Thread Jan Kara
to write the inode explicitely. But there's really no need to wait on IO. We only have to copy all data from inode structure into buffers and that happens even if we don't wait on sync. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR

[PATCH] Fix private_list handling

2008-01-10 Thread Jan Kara
Hi, -- Jan Kara [EMAIL PROTECTED] SUSE Labs, CR -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Fix private_list handling

2008-01-10 Thread Jan Kara
below should fix them. It survived beating with LTP and fsstress on ext2 filesystem on my testing machine so it should be reasonably bugfree... Andrew, would you put the patch into -mm? Thanks. Honza -- Jan Kara [EMAIL PROTECTED

Re: [PATCH 04/16] udf: check if udf_load_logicalvol failed

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:20, [EMAIL PROTECTED] wrote: udf_load_logicalvol may fail eg in out of memory conditions - check it and propagate error further Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig

Re: [PATCH 05/16] udf: convert macros related to bitmaps to functions

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:21, [EMAIL PROTECTED] wrote: convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL

Re: [PATCH 06/16] udf: move calculating of nr_groups into helper function

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:22, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Ben Fennema [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/udf/balloc.c |4 +--- fs/udf

Re: [PATCH 09/16] udf: create common function for tag checksumming

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:25, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/udf/inode.c | 15 ++- fs/udf/misc.c| 35

Re: [PATCH 10/16] udf: create common function for changing free space counter

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:26, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Just two minor comment... --- fs/udf/balloc.c | 49 - 1 files

Re: [PATCH 11/16] udf: replace loops coded with goto to real loops

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:27, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/udf/balloc.c | 118

Re: [PATCH 15/16] udf: fix udf_debug macro

2008-01-10 Thread Jan Kara
') Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] --- include/linux/udf_fs.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/udf_fs.h b/include/linux/udf_fs.h index 36c684e..c954527 100644 --- a/include/linux/udf_fs.h +++ b

Re: [PATCH 16/16] udf: improve readability of udf_load_partition

2008-01-10 Thread Jan Kara
On Thu 10-01-08 23:06:32, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Jan Kara [EMAIL PROTECTED] --- fs/udf/super.c | 59

Re: [PATCH] Fix private_list handling

2008-01-11 Thread Jan Kara
On Thu 10-01-08 16:36:35, Andrew Morton wrote: On Thu, 10 Jan 2008 16:55:13 +0100 Jan Kara [EMAIL PROTECTED] wrote: Hi, sorry for the previous empty email... Supriya noted in his testing that sometimes buffers removed by __remove_assoc_queue() don't have b_assoc_mapping set

Re: [PATCH 10/16] udf: create common function for changing free space counter

2008-01-14 Thread Jan Kara
On Sat 12-01-08 14:13:31, Marcin Slusarz wrote: On Fri, Jan 11, 2008 at 12:24:49AM +0100, Jan Kara wrote: On Thu 10-01-08 23:06:26, [EMAIL PROTECTED] wrote: Signed-off-by: Marcin Slusarz [EMAIL PROTECTED] CC: Jan Kara [EMAIL PROTECTED] CC: Christoph Hellwig [EMAIL PROTECTED] Just

Re: [PATCH] Fix private_list handling

2008-01-14 Thread Jan Kara
On Fri 11-01-08 15:33:54, Andrew Morton wrote: On Fri, 11 Jan 2008 15:21:31 +0100 Jan Kara [EMAIL PROTECTED] wrote: On Thu 10-01-08 16:36:35, Andrew Morton wrote: On Thu, 10 Jan 2008 16:55:13 +0100 Jan Kara [EMAIL PROTECTED] wrote: Hi, sorry for the previous empty

Re: lockdep warning with LTP dio test (v2.6.24-rc6-125-g5356f66)

2008-01-14 Thread Jan Kara
transaction start ranks below page lock (standard buffered write path) and page lock ranks below mmap_sem. So we have at least one more dependency mmap_sem must go before transaction start... Honza -- Jan Kara [EMAIL PROTECTED

Re: [PATCH] Fix private_list handling

2008-01-14 Thread Jan Kara
On Fri 11-01-08 15:33:54, Andrew Morton wrote: On Fri, 11 Jan 2008 15:21:31 +0100 Jan Kara [EMAIL PROTECTED] wrote: On Thu 10-01-08 16:36:35, Andrew Morton wrote: On Thu, 10 Jan 2008 16:55:13 +0100 Jan Kara [EMAIL PROTECTED] wrote: Hi, sorry for the previous empty

Re: O_NOLINK for open()

2007-09-13 Thread Jan Kara
deleted. So there would be no stale files... Or did you mean anything else? Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [2/3] 2.6.23-rc6: known regressions v2

2007-09-18 Thread Jan Kara
-By : ? Handled-By : ? Status : unknown I thought Shaggy asked Oliver about some details (and he did not answer so far) so I'd assume Shaggy is handling this. Honza -- Jan Kara [EMAIL PROTECTED

Re: iso9660 vs udf

2007-09-18 Thread Jan Kara
should produce some better error message into the log? Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: 2.4.35 SMP: ext3_readdir: bad entry in directory #323888: rec_len is smaller than minimal

2007-09-18 Thread Jan Kara
Hello, I got a bunch of these into dmesg: EXT3-fs error (device sd(8,2)): ext3_readdir: bad entry in directory #323880: rec_len is smaller than minimal - offset=0, inode=0, rec_len=0, name_len=0 EXT3-fs error (device sd(8,2)): ext3_readdir: bad entry in directory #323888: rec_len is

Re: 2.4.35 SMP: ext3_readdir: bad entry in directory #323888: rec_len is smaller than minimal

2007-09-18 Thread Jan Kara
On Tue, Sep 18, 2007 at 05:12:06PM +0200, you [Jan Kara] wrote: Hello, I got a bunch of these into dmesg: EXT3-fs error (device sd(8,2)): ext3_readdir: bad entry in directory #323880: rec_len is smaller than minimal - offset=0, inode=0, rec_len=0, name_len=0 EXT3-fs

Ext3 not marking filesystems as with errors

2007-09-20 Thread Jan Kara
are safe). Any feeling what is less hacky? Honza -- Jan Kara [EMAIL PROTECTED] SUSE Labs, CR - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Oops 2.6.23.1 in ext3+jbd at journal_put_journal_head

2007-11-13 Thread Jan Kara
2b 16 19 c0 85 c0 75 ec 8b 46 04 85 c0 7f 30 c7 44 24 : EIP: [journal_put_journal_head+64/209] journal_put_journal_head+0x40/0xd1 SS:ESP 0068:c2bf7e38 : note: kswapd0[243] exited with preempt_count 2 Honza -- Jan Kara

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Jan Kara
reproducible, there's low chance of finding the bug). Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Reproducable hang with 2.6.24-rc2 using oprofile

2007-11-13 Thread Jan Kara
is from Linus's git, last commit 6e800af233e0bdf108efb7bd23c11ea6fa34cdeb which is from Sunday Nov 11. The machine is Athlon XP 1400+, 512 MB RAM, only loop module loaded, .config attached. Honza -- Jan Kara [EMAIL

Re: Reproducable hang with 2.6.24-rc2 using oprofile

2007-11-13 Thread Jan Kara
, only loop module loaded, .config attached. Honza -- Jan Kara [EMAIL PROTECTED] SuSE CR Labs # # Automatically generated make config: don't edit # Linux kernel version: 2.6.24-rc2 # Tue Nov 13 14:53:48 2007

  1   2   3   4   5   6   7   8   9   10   >