Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-13 Thread Michal Simek
On 10/13/2015 07:33 AM, Mike Looijmans wrote: > On 12-10-15 14:38, Michal Simek wrote: >> Hi Mike, >> >> On 10/12/2015 02:22 PM, Mike Looijmans wrote: >>> On 12-10-15 13:16, Michal Simek wrote: >>> +static int zynq_fpga_ops_write(struct fpga_manager *mgr, >>> +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-13 Thread Michal Simek
On 10/13/2015 07:33 AM, Mike Looijmans wrote: > On 12-10-15 14:38, Michal Simek wrote: >> Hi Mike, >> >> On 10/12/2015 02:22 PM, Mike Looijmans wrote: >>> On 12-10-15 13:16, Michal Simek wrote: >>> +static int zynq_fpga_ops_write(struct fpga_manager *mgr, >>> +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Mike Looijmans
On 12-10-15 14:38, Michal Simek wrote: Hi Mike, On 10/12/2015 02:22 PM, Mike Looijmans wrote: On 12-10-15 13:16, Michal Simek wrote: +static int zynq_fpga_ops_write(struct fpga_manager *mgr, +const char *buf, size_t count) +{ + struct zynq_fpga_priv *priv; +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Mike Looijmans
On 12-10-15 13:16, Michal Simek wrote: +static int zynq_fpga_ops_write(struct fpga_manager *mgr, +const char *buf, size_t count) +{ + struct zynq_fpga_priv *priv; + int err; + char *kbuf; + size_t i, in_count; + dma_addr_t dma_addr; + u32

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Michal Simek
Hi Mike, On 10/12/2015 02:22 PM, Mike Looijmans wrote: > On 12-10-15 13:16, Michal Simek wrote: >> > +static int zynq_fpga_ops_write(struct fpga_manager *mgr, > +const char *buf, size_t count) > +{ > + struct zynq_fpga_priv *priv; > + int

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Michal Simek
>>> +static int zynq_fpga_ops_write(struct fpga_manager *mgr, >>> +const char *buf, size_t count) >>> +{ >>> + struct zynq_fpga_priv *priv; >>> + int err; >>> + char *kbuf; >>> + size_t i, in_count; >>> + dma_addr_t dma_addr; >>> + u32

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Michal Simek
Hi Mike, On 10/12/2015 02:22 PM, Mike Looijmans wrote: > On 12-10-15 13:16, Michal Simek wrote: >> > +static int zynq_fpga_ops_write(struct fpga_manager *mgr, > +const char *buf, size_t count) > +{ > + struct zynq_fpga_priv *priv; > + int

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Michal Simek
>>> +static int zynq_fpga_ops_write(struct fpga_manager *mgr, >>> +const char *buf, size_t count) >>> +{ >>> + struct zynq_fpga_priv *priv; >>> + int err; >>> + char *kbuf; >>> + size_t i, in_count; >>> + dma_addr_t dma_addr; >>> + u32

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Mike Looijmans
On 12-10-15 13:16, Michal Simek wrote: +static int zynq_fpga_ops_write(struct fpga_manager *mgr, +const char *buf, size_t count) +{ + struct zynq_fpga_priv *priv; + int err; + char *kbuf; + size_t i, in_count; + dma_addr_t dma_addr; + u32

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-12 Thread Mike Looijmans
On 12-10-15 14:38, Michal Simek wrote: Hi Mike, On 10/12/2015 02:22 PM, Mike Looijmans wrote: On 12-10-15 13:16, Michal Simek wrote: +static int zynq_fpga_ops_write(struct fpga_manager *mgr, +const char *buf, size_t count) +{ + struct zynq_fpga_priv *priv; +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-11 Thread Moritz Fischer
Hi Alan, thanks for your feedback! On Fri, Oct 9, 2015 at 8:09 PM, atull wrote: > On Thu, 8 Oct 2015, Moritz Fischer wrote: > >> --- /dev/null >> +++ b/drivers/fpga/zynq-fpga.c >> @@ -0,0 +1,478 @@ >> +/* >> + * Copyright (c) 2011-2015 Xilinx Inc. >> + * Copyright (c) 2015, National Instruments

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-11 Thread Moritz Fischer
Hi Alan, thanks for your feedback! On Fri, Oct 9, 2015 at 8:09 PM, atull wrote: > On Thu, 8 Oct 2015, Moritz Fischer wrote: > >> --- /dev/null >> +++ b/drivers/fpga/zynq-fpga.c >> @@ -0,0 +1,478 @@ >> +/* >> + * Copyright (c) 2011-2015 Xilinx Inc. >> + * Copyright

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread atull
On Fri, 9 Oct 2015, Greg KH wrote: > On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote: > > On Thu, 8 Oct 2015, Moritz Fischer wrote: > > > > > --- /dev/null > > > +++ b/drivers/fpga/zynq-fpga.c > > > @@ -0,0 +1,478 @@ > > > +/* > > > + * Copyright (c) 2011-2015 Xilinx Inc. > > > + *

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread atull
On Thu, 8 Oct 2015, Moritz Fischer wrote: > --- /dev/null > +++ b/drivers/fpga/zynq-fpga.c > @@ -0,0 +1,478 @@ > +/* > + * Copyright (c) 2011-2015 Xilinx Inc. > + * Copyright (c) 2015, National Instruments Corp. > + * > + * FPGA Manager Driver for Xilinx Zynq, heavily based on xdevcfg driver > +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Greg KH
On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote: > On Thu, 8 Oct 2015, Moritz Fischer wrote: > > > --- /dev/null > > +++ b/drivers/fpga/zynq-fpga.c > > @@ -0,0 +1,478 @@ > > +/* > > + * Copyright (c) 2011-2015 Xilinx Inc. > > + * Copyright (c) 2015, National Instruments Corp. > > + * > > +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Moritz Fischer
Hi Josh, thanks for the review! On Fri, Oct 9, 2015 at 6:33 PM, Josh Cartwright wrote: > Hey Moritz- > > On Fri, Oct 09, 2015 at 12:45:07AM +0200, Moritz Fischer wrote: >> This commit adds FPGA Manager support for the Xilinx Zynq chip. >> The code heavily borrows from the xdevcfg driver in

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Josh Cartwright
Hey Moritz- On Fri, Oct 09, 2015 at 12:45:07AM +0200, Moritz Fischer wrote: > This commit adds FPGA Manager support for the Xilinx Zynq chip. > The code heavily borrows from the xdevcfg driver in Xilinx' > vendor tree. > > Signed-off-by: Moritz Fischer [..] > +++ b/drivers/fpga/zynq-fpga.c [..]

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Josh Cartwright
Hey Moritz- On Fri, Oct 09, 2015 at 12:45:07AM +0200, Moritz Fischer wrote: > This commit adds FPGA Manager support for the Xilinx Zynq chip. > The code heavily borrows from the xdevcfg driver in Xilinx' > vendor tree. > > Signed-off-by: Moritz Fischer [..] > +++

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Moritz Fischer
Hi Josh, thanks for the review! On Fri, Oct 9, 2015 at 6:33 PM, Josh Cartwright wrote: > Hey Moritz- > > On Fri, Oct 09, 2015 at 12:45:07AM +0200, Moritz Fischer wrote: >> This commit adds FPGA Manager support for the Xilinx Zynq chip. >> The code heavily borrows from the xdevcfg

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread Greg KH
On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote: > On Thu, 8 Oct 2015, Moritz Fischer wrote: > > > --- /dev/null > > +++ b/drivers/fpga/zynq-fpga.c > > @@ -0,0 +1,478 @@ > > +/* > > + * Copyright (c) 2011-2015 Xilinx Inc. > > + * Copyright (c) 2015, National Instruments Corp. > > + * > > +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread atull
On Thu, 8 Oct 2015, Moritz Fischer wrote: > --- /dev/null > +++ b/drivers/fpga/zynq-fpga.c > @@ -0,0 +1,478 @@ > +/* > + * Copyright (c) 2011-2015 Xilinx Inc. > + * Copyright (c) 2015, National Instruments Corp. > + * > + * FPGA Manager Driver for Xilinx Zynq, heavily based on xdevcfg driver > +

Re: [PATCH 3/3] fpga manager: Adding FPGA Manager support for Xilinx Zynq 7000

2015-10-09 Thread atull
On Fri, 9 Oct 2015, Greg KH wrote: > On Fri, Oct 09, 2015 at 07:09:15PM +0100, atull wrote: > > On Thu, 8 Oct 2015, Moritz Fischer wrote: > > > > > --- /dev/null > > > +++ b/drivers/fpga/zynq-fpga.c > > > @@ -0,0 +1,478 @@ > > > +/* > > > + * Copyright (c) 2011-2015 Xilinx Inc. > > > + *